D27923: [FileIndexScheduler] Cleanup firstRun handling

2020-03-14 Thread Nathaniel Graham
ngraham added a comment. In D27923#627611 , @bruns wrote: > In D27923#627606 , @ngraham wrote: > > > Maybe next we should make `baloo_file` get killed automatically when indexing is disabled. ;)

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-03-14 Thread Noah Davis
ndavis added a comment. In D27540#627615 , @ngraham wrote: > @ndavis I know you had some idea for which icon to use, and an idea to make it a clickable button, right? Right, it's like MuseScore: F8176442:

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-03-14 Thread Nathaniel Graham
ngraham added a reviewer: ndavis. ngraham added a comment. @ndavis I know you had some idea for which icon to use, and an idea to make it a clickable button, right? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson,

D27923: [FileIndexScheduler] Cleanup firstRun handling

2020-03-14 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:ea77c412324e: [FileIndexScheduler] Cleanup firstRun handling (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27923?vs=77580=77641 REVISION

D27923: [FileIndexScheduler] Cleanup firstRun handling

2020-03-14 Thread Stefan Brüns
bruns added a comment. In D27923#627606 , @ngraham wrote: > Maybe next we should make `baloo_file` get killed automatically when indexing is disabled. ;) baloo_file **is** stopped when you disable indexing, so I don't know what you are

D21466: Recommend rebooting after installing Samba

2020-03-14 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R432:8a104aa4fb41: Recommend rebooting after installing Samba (authored by ngraham). REPOSITORY R432 File Sharing (Samba) integration CHANGES SINCE LAST UPDATE

D27923: [FileIndexScheduler] Cleanup firstRun handling

2020-03-14 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Good stuff. Maybe next we should make `baloo_file` get killed automatically when indexing is disabled. ;) REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 162 - Still Unstable!

2020-03-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/162/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Mar 2020 20:54:57 + Build duration: 2 min 0 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 169 - Still Unstable!

2020-03-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/169/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 14 Mar 2020 20:54:57 + Build duration: 2 min 1 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 276 - Still Unstable!

2020-03-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/276/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Mar 2020 20:54:57 + Build duration: 2 min 13 sec and counting JUnit Tests Name:

D28050: Add edit-reset

2020-03-14 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:27683f464437: Add edit-reset (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28050?vs=77634=77637 REVISION DETAIL

D28046: Change document-revert style to be more like edit-undo

2020-03-14 Thread Nathaniel Graham
ngraham added a comment. Retroactive +1; really very nice. Much clearer. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28046 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28050: Add edit-reset

2020-03-14 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH edit-beginning-end (branched from master) REVISION DETAIL https://phabricator.kde.org/D28050 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28033: Create ExpandableListItem

2020-03-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 77636. ngraham added a comment. Rebase better REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77635=77636 BRANCH ExpandableListItem (branched from master) REVISION DETAIL

D28033: Create ExpandableListItem

2020-03-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 77635. ngraham added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77603=77635 BRANCH ExpandableListItem (branched from master) REVISION DETAIL

D28050: Add edit-reset

2020-03-14 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28050 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28050: Add edit-reset

2020-03-14 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Use this for buttons that reset to the default value REPOSITORY R266 Breeze Icons

D28002: [WIP]Allow disabling of data collection

2020-03-14 Thread George Vogiatzis
gvgeo added a comment. In D28002#626663 , @davidedmundson wrote: > > Currently data is collected by default, with no way of disabling it. > > That's far from true. Things are off by default. Most providers are not run at all. > The

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 168 - Still Unstable!

2020-03-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/168/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 14 Mar 2020 19:34:42 + Build duration: 2 min 53 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 275 - Still Unstable!

2020-03-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/275/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Mar 2020 19:34:42 + Build duration: 3 min 34 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 161 - Still Unstable!

2020-03-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/161/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Mar 2020 19:34:42 + Build duration: 1 min 55 sec and counting JUnit Tests Name:

D28046: Change document-revert style to be more like edit-undo

2020-03-14 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:db3092cd945b: Change document-revert style to be more like edit-undo (authored by ndavis). REPOSITORY R266 Breeze

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-14 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes. Closed by commit R242:7d80f01c3162: WIP: Create a new TopArea element using widgets/toparea svg (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27444: Added plasmoid heading svg

2020-03-14 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes. Closed by commit R242:f55f1044479a: Added plasmoid heading svg (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77625=77626 REVISION

D27444: Added plasmoid heading svg

2020-03-14 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH top_area (branched from master) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added plasmoid heading svg

2020-03-14 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77625. niccolove added a comment. Polish REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77624=77625 BRANCH top_area (branched from master) REVISION DETAIL

D27444: Added plasmoid heading svg

2020-03-14 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77624. niccolove added a comment. Made opacity consistent REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77623=77624 BRANCH top_area (branched from master) REVISION DETAIL

D27444: Added plasmoid heading svg

2020-03-14 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77623. niccolove added a comment. Merge with master pt2 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77622=77623 BRANCH top_area (branched from master) REVISION DETAIL

D28046: Change document-revert style to be more like edit-undo

2020-03-14 Thread Noah Davis
ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28046 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added plasmoid heading svg

2020-03-14 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77622. niccolove added a comment. - Merge branch 'master' into top_area REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77407=77622 BRANCH top_area (branched from master) REVISION

D28046: Change document-revert style to be more like edit-undo

2020-03-14 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH document-revert (branched from master) REVISION DETAIL

D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

2020-03-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:b2ace3e804ad: Lua: add # as additional deliminator to activate auto-completion with… (authored by jpoelen, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

2020-03-14 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok ;=) REPOSITORY R216 Syntax Highlighting BRANCH lua (branched from master) REVISION DETAIL https://phabricator.kde.org/D28045 To: jpoelen, #framework_syntax_highlighting,

D27951: Allow users to change dropAction to MoveAction through kdeglobals

2020-03-14 Thread Nathaniel Graham
ngraham added a comment. All right, let's see what #VDG people and @davidedmundson have to say. I would like for this to go in in some form, but we have to make sure that everyone's okay with it. REPOSITORY R241 KIO REVISION DETAIL

D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

2020-03-14 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH lua (branched from master) REVISION DETAIL

D17816: Support for xattrs on kio copy/move

2020-03-14 Thread Nathaniel Graham
ngraham added a comment. Thanks for coming back to finish this up! @dfaure and @bruns, does it look okay now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall Cc: scheirle, anthonyfieroni, tmarshall,

D28044: C: remove ' as digit separator

2020-03-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:755904a6ff2e: C: remove as digit separator (authored by jpoelen, committed by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28044?vs=77614=77615#toc REPOSITORY R216 Syntax

D28044: C: remove ' as digit separator

2020-03-14 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. True, guess I copied too large parts during my fix-up of this. REPOSITORY R216 Syntax Highlighting BRANCH c (branched from master) REVISION DETAIL

D28044: C: remove ' as digit separator

2020-03-14 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY This is not in C standard, but only in C++ REPOSITORY R216 Syntax Highlighting

D28039: optimize dynamic regex matching

2020-03-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:764957b1d23c: optimize dynamic regex matching (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28039?vs=77593=77613 REVISION

D28039: optimize dynamic regex matching

2020-03-14 Thread Christoph Cullmann
cullmann added a comment. First let's have this, the current state is bad ;=) INLINE COMMENTS > dhaumann wrote in rule_p.h:126 > I dislike this protected hack :-) That is called inheritance ;=) I first had a virtual function, but this is much easier and faster. (and just costs a few bytes)

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.14 - Build # 5 - Failure!

2020-03-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.14/5/ Project: kf5-qt5 AndroidQt5.14 Date of build: Sat, 14 Mar 2020 13:02:57 + Build duration: 40 sec and counting CONSOLE OUTPUT [...truncated 393

D27952: Simplify minimum size handling

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:0d64bdd22e7c: Simplify minimum size handling (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27952?vs=77611=77612 REVISION DETAIL

D27952: Simplify minimum size handling

2020-03-14 Thread Volker Krause
vkrause updated this revision to Diff 77611. vkrause added a comment. Rebase and bump version numbers. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27952?vs=77302=77611 BRANCH arcpatch-D27952 REVISION DETAIL https://phabricator.kde.org/D27952

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

2020-03-14 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27591 To: alex, elvisangelaccio, #frameworks, mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27909: Move barcode image scaling logic to AbstractBarcode

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:ea1f6c1abeb0: Move barcode image scaling logic to AbstractBarcode (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27909?vs=77158=77610

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:3d4b8780a8d5: Add API to check whether a barcode is one- or two-dimensional (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE

D28030: Also expose the true minimum size to QML

2020-03-14 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH pending REVISION DETAIL https://phabricator.kde.org/D28030 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-14 Thread Volker Krause
vkrause updated this revision to Diff 77607. vkrause added a comment. Rebase and bump version number to 5.69. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27730?vs=77128=77607 BRANCH arcpatch-D27730 REVISION DETAIL https://phabricator.kde.org/D27730

D28039: optimize dynamic regex matching

2020-03-14 Thread Dominik Haumann
dhaumann added a comment. Thanks yes, maybe you can add a comment to the skipOffset, Christoph :) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D28039 To: cullmann, dhaumann, vkrause, nibags Cc: mwolff, kwrite-devel,

D28039: optimize dynamic regex matching

2020-03-14 Thread Milian Wolff
mwolff added a comment. Let me try to explain the skip offset idea (it's been years since I came up with this in GeSHi :) ) A code highlighter will repeatedly ask all highlight contexts and items therein to find the closest token to highlight next to the current cursor position. The