D27923: [FileIndexScheduler] Cleanup firstRun handling

2020-03-14 Thread Nathaniel Graham
ngraham added a comment.


  In D27923#627611 , @bruns wrote:
  
  > In D27923#627606 , @ngraham 
wrote:
  >
  > > Maybe next we should make `baloo_file` get killed automatically when 
indexing is disabled. ;)
  >
  >
  > baloo_file **is** stopped when you disable indexing, so I don't know what 
you are referring to ...
  
  
  It's definitely better with d74d1cbb65db03a03d5fdb91681ad906e8f098f8 
, 
but the baloo_file processes don't immediately terminate. Maybe it's not a big 
deal.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27923

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-03-14 Thread Noah Davis
ndavis added a comment.


  In D27540#627615 , @ngraham wrote:
  
  > @ndavis I know you had some idea for which icon to use, and an idea to make 
it a clickable button, right?
  
  
  Right, it's like MuseScore:
  
  F8176442: Screenshot_20200314_132437.PNG 

  
  - It's simple to understand with the right iconography.
  - It's convenient when you're working with a lot of settings.
  - By being enabled or disabled, it indicates whether or not a control is set 
to the default value or not.
  
  Some extra rules I thought of:
  
  - With the checkable label example in the mockup above, it should reset both 
the label and the checkbox.
  - In cases where there is no default value and a user is expected/required to 
change the value (e.g., LineEdits for the user's first and last names), we 
should not show a reset button.
- I don't want users to mistake it for a clear text or undo button.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis
Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns


D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-03-14 Thread Nathaniel Graham
ngraham added a reviewer: ndavis.
ngraham added a comment.


  @ndavis I know you had some idea for which icon to use, and an idea to make 
it a clickable button, right?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis
Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns


D27923: [FileIndexScheduler] Cleanup firstRun handling

2020-03-14 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:ea77c412324e: [FileIndexScheduler] Cleanup firstRun 
handling (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27923?vs=77580=77641

REVISION DETAIL
  https://phabricator.kde.org/D27923

AFFECTED FILES
  autotests/unit/file/filewatchtest.cpp
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/firstrunindexer.cpp
  src/file/indexerstate.h
  src/file/main.cpp
  src/file/mainhub.cpp
  src/file/mainhub.h
  src/file/migrator.cpp
  src/lib/CMakeLists.txt
  src/lib/indexerconfig.cpp
  src/lib/indexerconfig.h

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D27923: [FileIndexScheduler] Cleanup firstRun handling

2020-03-14 Thread Stefan Brüns
bruns added a comment.


  In D27923#627606 , @ngraham wrote:
  
  > Maybe next we should make `baloo_file` get killed automatically when 
indexing is disabled. ;)
  
  
  baloo_file **is** stopped when you disable indexing, so I don't know what you 
are referring to ...

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27923

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D21466: Recommend rebooting after installing Samba

2020-03-14 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R432:8a104aa4fb41: Recommend rebooting after installing Samba 
(authored by ngraham).

REPOSITORY
  R432 File Sharing (Samba) integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21466?vs=58801=77640

REVISION DETAIL
  https://phabricator.kde.org/D21466

AFFECTED FILES
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #vdg, #frameworks, #dolphin, apol, sitter
Cc: anthonyfieroni, sitter, bruns


D27923: [FileIndexScheduler] Cleanup firstRun handling

2020-03-14 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Good stuff.
  
  Maybe next we should make `baloo_file` get killed automatically when indexing 
is disabled. ;)

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27923

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 162 - Still Unstable!

2020-03-14 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/162/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Mar 2020 20:54:57 +
 Build duration:
2 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 169 - Still Unstable!

2020-03-14 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/169/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 14 Mar 2020 20:54:57 +
 Build duration:
2 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 276 - Still Unstable!

2020-03-14 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/276/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 14 Mar 2020 20:54:57 +
 Build duration:
2 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

D28050: Add edit-reset

2020-03-14 Thread Noah Davis
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:27683f464437: Add edit-reset (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28050?vs=77634=77637

REVISION DETAIL
  https://phabricator.kde.org/D28050

AFFECTED FILES
  icons-dark/actions/16/edit-reset.svg
  icons-dark/actions/22/edit-reset.svg
  icons-dark/actions/32/edit-reset.svg
  icons/actions/16/edit-reset.svg
  icons/actions/22/edit-reset.svg
  icons/actions/32/edit-reset.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28046: Change document-revert style to be more like edit-undo

2020-03-14 Thread Nathaniel Graham
ngraham added a comment.


  Retroactive +1; really very nice. Much clearer.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28046

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


D28050: Add edit-reset

2020-03-14 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  edit-beginning-end (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28050

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28033: Create ExpandableListItem

2020-03-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 77636.
ngraham added a comment.


  Rebase better

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=77635=77636

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ExpandableListItem.qml
  src/declarativeimports/plasmacomponents3/qmldir

To: ngraham, #vdg, #plasma
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham


D28033: Create ExpandableListItem

2020-03-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 77635.
ngraham added a comment.


  Rebase

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=77603=77635

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ExpandableListItem.qml
  src/declarativeimports/plasmacomponents3/qmldir
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: ngraham, #vdg, #plasma
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham


D28050: Add edit-reset

2020-03-14 Thread Noah Davis
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28050

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28050: Add edit-reset

2020-03-14 Thread Noah Davis
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Use this for buttons that reset to the default value

REPOSITORY
  R266 Breeze Icons

BRANCH
  edit-beginning-end (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28050

AFFECTED FILES
  icons-dark/actions/16/edit-reset.svg
  icons-dark/actions/22/edit-reset.svg
  icons-dark/actions/32/edit-reset.svg
  icons/actions/16/edit-reset.svg
  icons/actions/22/edit-reset.svg
  icons/actions/32/edit-reset.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28002: [WIP]Allow disabling of data collection

2020-03-14 Thread George Vogiatzis
gvgeo added a comment.


  In D28002#626663 , @davidedmundson 
wrote:
  
  > > Currently data is collected by default, with no way of disabling it.
  >
  > That's far from true. Things are off by default. Most providers are not run 
at all.
  >  The commit message is either confused or misleading.
  
  
  I'm not even sure, why you said that. Now, I'm confused.
  
  Checked gammaray's source and seems that it uses the kuserfeedback code 
without any change. Although is a bit outdated, I didn't find any newer commit 
fixing that.
  
  But I found that kuserfeedback tracks itself. Running "UserFeedback Console" 
collects usage statistics about time spend in each view.
  F8176092: UserFeedback.org.kde.UserFeedbackConsole.conf 

  (Side note: Even if does not target users, shouldn't include "UserFeedback 
Console" in "Telemetry Use" page.)

REPOSITORY
  R849 User Feedback Collection Framework

REVISION DETAIL
  https://phabricator.kde.org/D28002

To: gvgeo, #frameworks, apol, vkrause
Cc: davidedmundson, #frameworks


KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 168 - Still Unstable!

2020-03-14 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/168/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 14 Mar 2020 19:34:42 +
 Build duration:
2 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 275 - Still Unstable!

2020-03-14 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/275/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 14 Mar 2020 19:34:42 +
 Build duration:
3 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 161 - Still Unstable!

2020-03-14 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/161/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Mar 2020 19:34:42 +
 Build duration:
1 min 55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

D28046: Change document-revert style to be more like edit-undo

2020-03-14 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:db3092cd945b: Change document-revert style to be more 
like edit-undo (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28046?vs=77619=77632

REVISION DETAIL
  https://phabricator.kde.org/D28046

AFFECTED FILES
  icons-dark/actions/16/document-revert.svg
  icons-dark/actions/22/document-revert.svg
  icons-dark/actions/32/document-revert.svg
  icons-dark/actions/symbolic/document-revert-symbolic-rtl.svg
  icons/actions/16/document-revert.svg
  icons/actions/22/document-revert.svg
  icons/actions/32/document-revert.svg
  icons/actions/symbolic/document-revert-symbolic-rtl.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-14 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7d80f01c3162: WIP: Create a new TopArea element using 
widgets/toparea svg (authored by niccolove).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=77588=77627

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir

To: niccolove, mart, ngraham
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns


D27444: Added plasmoid heading svg

2020-03-14 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f55f1044479a: Added plasmoid heading svg (authored by 
niccolove).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=77625=77626

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27444: Added plasmoid heading svg

2020-03-14 Thread Noah Davis
ndavis accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27444: Added plasmoid heading svg

2020-03-14 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77625.
niccolove added a comment.


  Polish

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=77624=77625

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27444: Added plasmoid heading svg

2020-03-14 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77624.
niccolove added a comment.


  Made opacity consistent

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=77623=77624

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27444: Added plasmoid heading svg

2020-03-14 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77623.
niccolove added a comment.


  Merge with master pt2

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=77622=77623

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28046: Change document-revert style to be more like edit-undo

2020-03-14 Thread Noah Davis
ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28046

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27444: Added plasmoid heading svg

2020-03-14 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77622.
niccolove added a comment.


  - Merge branch 'master' into top_area

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=77407=77622

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/qmldir
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28046: Change document-revert style to be more like edit-undo

2020-03-14 Thread Noah Davis
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  document-revert (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28046

AFFECTED FILES
  icons-dark/actions/16/document-revert.svg
  icons-dark/actions/22/document-revert.svg
  icons-dark/actions/32/document-revert.svg
  icons-dark/actions/symbolic/document-revert-symbolic-rtl.svg
  icons/actions/16/document-revert.svg
  icons/actions/22/document-revert.svg
  icons/actions/32/document-revert.svg
  icons/actions/symbolic/document-revert-symbolic-rtl.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

2020-03-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b2ace3e804ad: Lua: add # as additional deliminator to 
activate auto-completion with… (authored by jpoelen, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28045?vs=77617=77618

REVISION DETAIL
  https://phabricator.kde.org/D28045

AFFECTED FILES
  data/syntax/lua.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

2020-03-14 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok ;=)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  lua (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28045

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D27951: Allow users to change dropAction to MoveAction through kdeglobals

2020-03-14 Thread Nathaniel Graham
ngraham added a comment.


  All right, let's see what #VDG  people 
and @davidedmundson have to say. I would like for this to go in in some form, 
but we have to make sure that everyone's okay with it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns


D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

2020-03-14 Thread jonathan poelen
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  lua (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28045

AFFECTED FILES
  data/syntax/lua.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D17816: Support for xattrs on kio copy/move

2020-03-14 Thread Nathaniel Graham
ngraham added a comment.


  Thanks for coming back to finish this up! @dfaure and @bruns, does it look 
okay now?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall
Cc: scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh


D28044: C: remove ' as digit separator

2020-03-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:755904a6ff2e: C: remove  as digit separator 
(authored by jpoelen, committed by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28044?vs=77614=77615#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28044?vs=77614=77615

REVISION DETAIL
  https://phabricator.kde.org/D28044

AFFECTED FILES
  data/syntax/c.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28044: C: remove ' as digit separator

2020-03-14 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  True, guess I copied too large parts during my fix-up of this.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  c (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28044

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28044: C: remove ' as digit separator

2020-03-14 Thread jonathan poelen
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  This is not in C standard, but only in C++

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  c (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28044

AFFECTED FILES
  data/syntax/c.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28039: optimize dynamic regex matching

2020-03-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:764957b1d23c: optimize dynamic regex matching (authored 
by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28039?vs=77593=77613

REVISION DETAIL
  https://phabricator.kde.org/D28039

AFFECTED FILES
  src/lib/abstracthighlighter.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, dhaumann, vkrause, nibags
Cc: mwolff, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28039: optimize dynamic regex matching

2020-03-14 Thread Christoph Cullmann
cullmann added a comment.


  First let's have this, the current state is bad ;=)

INLINE COMMENTS

> dhaumann wrote in rule_p.h:126
> I dislike this protected hack :-)

That is called inheritance ;=)
I first had a virtual function, but this is much easier and faster. (and just 
costs a few bytes)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28039

To: cullmann, dhaumann, vkrause, nibags
Cc: mwolff, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.14 - Build # 5 - Failure!

2020-03-14 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.14/5/
 Project:
kf5-qt5 AndroidQt5.14
 Date of build:
Sat, 14 Mar 2020 13:02:57 +
 Build duration:
40 sec and counting
   CONSOLE OUTPUT
  [...truncated 393 lines...][2020-03-14T13:03:33.174Z] -- Detecting C compile features[2020-03-14T13:03:33.174Z] -- Detecting C compile features - done[2020-03-14T13:03:33.174Z] -- Check for working CXX compiler: /opt/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++[2020-03-14T13:03:33.429Z] -- Check for working CXX compiler: /opt/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ -- works[2020-03-14T13:03:33.429Z] -- Detecting CXX compiler ABI info[2020-03-14T13:03:33.429Z] -- Detecting CXX compiler ABI info - done[2020-03-14T13:03:33.429Z] -- Detecting CXX compile features[2020-03-14T13:03:33.429Z] -- Detecting CXX compile features - done[2020-03-14T13:03:33.429Z] -- [2020-03-14T13:03:33.429Z] [2020-03-14T13:03:33.429Z] Installing in /home/user/install-prefix. Run /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.14/build/prefix.sh to set the environment for prison.[2020-03-14T13:03:33.429Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-03-14T13:03:33.429Z] -- Looking for __GLIBC__[2020-03-14T13:03:33.429Z] -- Looking for __GLIBC__ - not found[2020-03-14T13:03:33.429Z] -- Performing Test _OFFT_IS_64BIT[2020-03-14T13:03:33.429Z] -- Performing Test _OFFT_IS_64BIT - Failed[2020-03-14T13:03:33.429Z] -- Performing Test HAVE_DATE_TIME[2020-03-14T13:03:33.684Z] -- Performing Test HAVE_DATE_TIME - Success[2020-03-14T13:03:33.684Z] -- Found QRencode: /home/user/install-prefix/lib/libqrencode.a  [2020-03-14T13:03:33.684Z] -- Could NOT find Dmtx (missing: Dmtx_LIBRARIES Dmtx_INCLUDE_DIRS) [2020-03-14T13:03:33.684Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2020-03-14T13:03:33.684Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2020-03-14T13:03:33.684Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2020-03-14T13:03:33.684Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2020-03-14T13:03:33.684Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2020-03-14T13:03:33.684Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2020-03-14T13:03:33.684Z] -- The following OPTIONAL packages have been found:[2020-03-14T13:03:33.684Z] [2020-03-14T13:03:33.684Z]  * Qt5Network (required version >= 5.14.1)[2020-03-14T13:03:33.684Z]  * Qt5Qml (required version >= 5.14.1)[2020-03-14T13:03:33.684Z]  * Qt5QmlModels (required version >= 5.14.1)[2020-03-14T13:03:33.684Z]  * Qt5Quick[2020-03-14T13:03:33.684Z] [2020-03-14T13:03:33.684Z] -- The following REQUIRED packages have been found:[2020-03-14T13:03:33.684Z] [2020-03-14T13:03:33.684Z]  * ECM (required version >= 5.68.0), Extra CMake Modules., [2020-03-14T13:03:33.684Z]  * Qt5Core[2020-03-14T13:03:33.684Z]  * Qt5Gui[2020-03-14T13:03:33.684Z]  * QRencode, The QRencode library, [2020-03-14T13:03:33.684Z]  * Qt5Test[2020-03-14T13:03:33.684Z]  * Qt5Widgets[2020-03-14T13:03:33.684Z]  * Qt5 (required version >= 5.12.0)[2020-03-14T13:03:33.684Z] [2020-03-14T13:03:33.684Z] -- The following features have been disabled:[2020-03-14T13:03:33.684Z] [2020-03-14T13:03:33.684Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2020-03-14T13:03:33.684Z] [2020-03-14T13:03:33.684Z] -- The following RECOMMENDED packages have not been found:[2020-03-14T13:03:33.684Z] [2020-03-14T13:03:33.684Z]  * Dmtx, The Datamatrix library, [2020-03-14T13:03:33.684Z] [2020-03-14T13:03:33.684Z] -- Configuring done[2020-03-14T13:03:33.684Z] -- Generating done[2020-03-14T13:03:33.684Z] CMake Warning:[2020-03-14T13:03:33.684Z]   Manually-specified variables were not used by the project:[2020-03-14T13:03:33.684Z] [2020-03-14T13:03:33.684Z] KF5_HOST_TOOLING[2020-03-14T13:03:33.684Z] [2020-03-14T13:03:33.684Z] [2020-03-14T13:03:33.684Z] -- Build files have been written to: /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.14/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-03-14T13:03:34.699Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project prison --branchGroup kf5-qt5 --platform AndroidQt5.14 --usingInstall /home/user/install-prefix/[2020-03-14T13:03:34.699Z] Scanning dependencies of target KF5Prison_autogen[2020-03-14T13:03:34.699Z] [  1%] Automatic MOC for target KF5Prison[2020-03-14T13:03:34.699Z] [  1%] Built target KF5Prison_autogen[2020-03-14T13:03:34.699Z] Scanning dependencies of target KF5Prison[2020-03-14T13:03:34.699Z] [  3%] Building CXX object src/lib/CMakeFiles/KF5Prison.dir/KF5Prison_autogen/mocs_compilation.cpp.o[2020-03-14T13:03:34.699Z] [  5%] Building CXX object src/lib/CMakeFiles/KF5Prison.dir/abstractbarcode.cpp.o[2020-03-14T13:03:34.699Z] [  7%] Building CXX object 

D27952: Simplify minimum size handling

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes.
Closed by commit R280:0d64bdd22e7c: Simplify minimum size handling (authored by 
vkrause).

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27952?vs=77611=77612

REVISION DETAIL
  https://phabricator.kde.org/D27952

AFFECTED FILES
  src/lib/abstractbarcode.cpp
  src/lib/abstractbarcode.h
  src/lib/aztecbarcode.cpp
  src/lib/code128barcode.cpp
  src/lib/code39barcode.cpp
  src/lib/code93barcode.cpp
  src/lib/datamatrixbarcode.cpp
  src/lib/qrcodebarcode.cpp

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27952: Simplify minimum size handling

2020-03-14 Thread Volker Krause
vkrause updated this revision to Diff 77611.
vkrause added a comment.


  Rebase and bump version numbers.

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27952?vs=77302=77611

BRANCH
  arcpatch-D27952

REVISION DETAIL
  https://phabricator.kde.org/D27952

AFFECTED FILES
  src/lib/abstractbarcode.cpp
  src/lib/abstractbarcode.h
  src/lib/aztecbarcode.cpp
  src/lib/code128barcode.cpp
  src/lib/code39barcode.cpp
  src/lib/code93barcode.cpp
  src/lib/datamatrixbarcode.cpp
  src/lib/qrcodebarcode.cpp

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

2020-03-14 Thread Elvis Angelaccio
elvisangelaccio accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27591

To: alex, elvisangelaccio, #frameworks, mlaurent, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27909: Move barcode image scaling logic to AbstractBarcode

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes.
Closed by commit R280:ea1f6c1abeb0: Move barcode image scaling logic to 
AbstractBarcode (authored by vkrause).

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27909?vs=77158=77610

REVISION DETAIL
  https://phabricator.kde.org/D27909

AFFECTED FILES
  autotests/aztec/encoding/aztec-complete-big.png
  autotests/aztec/encoding/aztec-complete-compact1.png
  autotests/aztec/encoding/aztec-complete-compact3.png
  autotests/aztec/encoding/aztec-complete-compact4.png
  autotests/aztec/encoding/aztec-complete-full5.png
  autotests/aztecbarcodetest.cpp
  autotests/code128barcodetest.cpp
  src/lib/abstractbarcode.cpp
  src/lib/abstractbarcode.h
  src/lib/aztecbarcode.cpp
  src/lib/aztecbarcode.h
  src/lib/code128barcode.cpp
  src/lib/code39barcode.cpp
  src/lib/code93barcode.cpp
  src/lib/datamatrixbarcode.cpp
  src/lib/qrcodebarcode.cpp

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes.
Closed by commit R280:3d4b8780a8d5: Add API to check whether a barcode is one- 
or two-dimensional (authored by vkrause).

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27730?vs=77607=77609

REVISION DETAIL
  https://phabricator.kde.org/D27730

AFFECTED FILES
  CMakeLists.txt
  autotests/aztecbarcodetest.cpp
  autotests/code128barcodetest.cpp
  src/lib/CMakeLists.txt
  src/lib/abstractbarcode.cpp
  src/lib/abstractbarcode.h
  src/lib/aztecbarcode.cpp
  src/lib/code128barcode.cpp
  src/lib/code39barcode.cpp
  src/lib/code93barcode.cpp
  src/lib/datamatrixbarcode.cpp
  src/lib/qrcodebarcode.cpp
  src/quick/barcodequickitem.cpp
  src/quick/barcodequickitem.h
  tests/barcode.qml

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28030: Also expose the true minimum size to QML

2020-03-14 Thread Sune Vuorela
svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R280 Prison

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D28030

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-14 Thread Volker Krause
vkrause updated this revision to Diff 77607.
vkrause added a comment.


  Rebase and bump version number to 5.69.

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27730?vs=77128=77607

BRANCH
  arcpatch-D27730

REVISION DETAIL
  https://phabricator.kde.org/D27730

AFFECTED FILES
  CMakeLists.txt
  autotests/aztecbarcodetest.cpp
  autotests/code128barcodetest.cpp
  src/lib/CMakeLists.txt
  src/lib/abstractbarcode.cpp
  src/lib/abstractbarcode.h
  src/lib/aztecbarcode.cpp
  src/lib/code128barcode.cpp
  src/lib/code39barcode.cpp
  src/lib/code93barcode.cpp
  src/lib/datamatrixbarcode.cpp
  src/lib/qrcodebarcode.cpp
  src/quick/barcodequickitem.cpp
  src/quick/barcodequickitem.h
  tests/barcode.qml

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28039: optimize dynamic regex matching

2020-03-14 Thread Dominik Haumann
dhaumann added a comment.


  Thanks yes, maybe you can add a comment to the skipOffset, Christoph :)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28039

To: cullmann, dhaumann, vkrause, nibags
Cc: mwolff, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28039: optimize dynamic regex matching

2020-03-14 Thread Milian Wolff
mwolff added a comment.


  Let me try to explain the skip offset idea (it's been years since I came up 
with this in GeSHi :) )
  
  A code highlighter will repeatedly ask all highlight contexts and items 
therein to find the closest token to highlight next to the current cursor 
position.
  The closest token will win and then the highlighter will repeat its question 
at the position after the token.
  For regular expressions, it's often cheaper (as indicated by this patch once 
again), to match the line once starting from the current position and then 
remember where the first match - if any - is in the current line.
  Then, the next time the highlighter asks for a token position, we can check 
the last matched position. This is essentially the skip offset - i.e. we know 
that we can skip querying the regexp again until the cursor position is beyond 
the next match.
  
  Dominik, does this clear things up?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28039

To: cullmann, dhaumann, vkrause, nibags
Cc: mwolff, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann