KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 339 - Still Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/339/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Mar 2020 04:50:36 + Build duration: 10 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 472 - Still Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/472/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Mar 2020 04:50:35 + Build duration: 8 min 34 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 348 - Still Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/348/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 20 Mar 2020 04:50:35 + Build duration: 8 min 47 sec and counting BUILD ARTIFACTS

D27255: nota

2020-03-19 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. The dotted lines are placed on half pixels, which we should avoid doing. Depending on the look you're going for, you could do either one of the following: - Align the 1px

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 118 - Still Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/118/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Mar 2020 01:52:51 + Build duration: 3 min 22 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Still Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/66/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Mar 2020 00:07:19 + Build duration: 22 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 73 - Fixed!

2020-03-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/73/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 20 Mar 2020 00:07:19 + Build duration: 6 min 58 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 114 - Fixed!

2020-03-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/114/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Mar 2020 00:07:19 + Build duration: 6 min 59 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 113 - Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/113/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Mar 2020 23:36:23 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 65 - Still Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/65/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Mar 2020 23:36:23 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 72 - Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/72/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 19 Mar 2020 23:36:23 + Build duration: 4 min 21 sec and counting BUILD ARTIFACTS

D26858: Provide an implementation for the tablet interface

2020-03-19 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R127:a009c8c0d91a: Provide an implementation for the tablet interface (authored by apol). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=78028=78055 REVISION

D28151: Autotest file showing wrong File path

2020-03-19 Thread Ömer Fadıl Usta
usta closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28151 To: usta, meven, aacid, hchain Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28151: Autotest file showing wrong File path

2020-03-19 Thread Ömer Fadıl Usta
usta added a commit: R237:67630e49d69c: Autotest file showing wrong File path. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28151 To: usta, meven, aacid, hchain Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28151: Autotest file showing wrong File path

2020-03-19 Thread Ömer Fadıl Usta
usta added a reviewer: hchain. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28151 To: usta, meven, aacid, hchain Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28151: Autotest file showing wrong File path

2020-03-19 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28151 To: usta, meven, aacid Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28151: Autotest file showing wrong File path

2020-03-19 Thread Ömer Fadıl Usta
usta created this revision. usta added a reviewer: meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. usta requested review of this revision. REVISION SUMMARY It look like this is a trivial typo but causing tests doesnt work correctly REPOSITORY R237

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 347 - Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/347/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 19 Mar 2020 20:37:47 + Build duration: 19 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 338 - Still Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/338/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Mar 2020 20:37:47 + Build duration: 10 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 64 - Still Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/64/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Mar 2020 20:40:37 + Build duration: 5 min 19 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 471 - Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/471/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Mar 2020 20:37:47 + Build duration: 5 min 51 sec and counting BUILD ARTIFACTS

D28147: [server] Don't make assumptions about the order of damage_buffer and attach requests

2020-03-19 Thread Vlad Zahorodnii
This revision was automatically updated to reflect the committed changes. Closed by commit R127:ff9cadf00f21: [server] Dont make assumptions about the order of damage_buffer and attach… (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-19 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:14b7f2c7ee72: [DesktopExecParser] Open {ssh,telnet,rlogin}:// urls with ktelnetservice (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-19 Thread Ahmad Samir
ahmadsamir added a comment. In D27999#630756 , @feverfew wrote: > Quick testing with `fish` protocol doesn't break anything KIOFuse side. Going to page in @ngraham, if it works for him with `smb` it's an all good from the "KIOFuse people" ;)

D28147: [server] Don't make assumptions about the order of damage_buffer and attach requests

2020-03-19 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Heh, I'm having some de ja vu. I did this already, for the same situation for the same bug: https://bugs.kde.org/show_bug.cgi?id=397834#c19

D28147: [server] Don't make assumptions about the order of damage_buffer and attach requests

2020-03-19 Thread Vlad Zahorodnii
zzag added a comment. In general, the idea of raising a protocol error when the client tries to damage a surface with no buffer seems sensible. But the spec doesn't say damage_buffer requests must be followed by attach requests and we can't really predict the future. REPOSITORY R127

D28147: [server] Don't make assumptions about the order of damage_buffer and attach requests

2020-03-19 Thread Vlad Zahorodnii
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The spec says nothing about the order between damage_buffer and attach requests. TEST PLAN

D25515: Only extract lyrics when the plain text flag is set

2020-03-19 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems sane. REPOSITORY R286 KFileMetaData BRANCH lyricsExtraction REVISION DETAIL https://phabricator.kde.org/D25515 To: astippich, #baloo, bruns, mgallien, ngraham Cc:

D24895: [RFC] Drop implicit size from PC buttons

2020-03-19 Thread Nathaniel Graham
ngraham added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart, #vdg Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, mart, LeGast00n, cblack, GB_2, michaelh, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-19 Thread Nathaniel Graham
ngraham added a comment. Shipit! REPOSITORY R241 KIO BRANCH l-krun-ssh (branched from master) REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-19 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R241 KIO BRANCH l-krun-ssh (branched from master) REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-19 Thread Alexander Saoutkin
feverfew added a reviewer: ngraham. feverfew accepted this revision. feverfew added a subscriber: ngraham. feverfew added a comment. Quick testing with `fish` protocol doesn't break anything KIOFuse side. Going to page in @ngraham, if it works for him with `smb` it's an all good from the

D27210: add KDEconnect Icons

2020-03-19 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Also this needs the corresponding dark versions submitted as well. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27210 To: mbruchert, #vdg,

D27235: add calindori icon in the new pm style

2020-03-19 Thread Nathaniel Graham
ngraham added a comment. Generally LGTM, though I agree that the hole in the top seems unnecessary. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27235 To: mbruchert, dkardarakos, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27255: nota

2020-03-19 Thread Nathaniel Graham
ngraham added subscribers: ndavis, ngraham. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. @ndavis? REPOSITORY R266 Breeze Icons BRANCH nota (branched from master) REVISION DETAIL https://phabricator.kde.org/D27255 To:

D27504: smb faster copy to local

2020-03-19 Thread Nathaniel Graham
ngraham added a comment. Still +1 functionally. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck, #frameworks, #dolphin Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D27760: WIP | Added BatchMoveJob

2020-03-19 Thread Nathaniel Graham
ngraham added a comment. The general concept seems sane to me, but let's make sure @dfaure agrees. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27760 To: emateli, dfaure, ngraham Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28144: Make animation durations consistent with Kirigami values

2020-03-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 78036. ngraham added a comment. Forgot one more thing REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28144?vs=78035=78036 BRANCH improved-durations (branched from master) REVISION DETAIL

D28144: Make animation durations consistent with Kirigami values

2020-03-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 78035. ngraham added a comment. Don't forget kirigamiplasmastyle REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28144?vs=78031=78035 BRANCH improved-durations (branched from master) REVISION

D28033: Create ExpandableListItem

2020-03-19 Thread Nathaniel Graham
ngraham added a comment. D28143: Add "veryLongDuration" animation duration D28144: Make animation durations consistent with Kirigami values REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28144: Make animation durations consistent with Kirigami values

2020-03-19 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, davidedmundson, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now longDuration is 120ms and shortDuration is 24ms. This

D28033: Create ExpandableListItem

2020-03-19 Thread Nathaniel Graham
ngraham added a comment. In fact it looks like Kirigami already uses 150 for short and 250 for long, so there's an argument for making Plasma consistent with that. Will submit patches. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To:

D26858: Provide an implementation for the tablet interface

2020-03-19 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 78028. apol added a comment. rebase REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=78027=78028 BRANCH arcpatch-D26858 REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES CMakeLists.txt

D26858: Provide an implementation for the tablet interface

2020-03-19 Thread David Edmundson
davidedmundson accepted this revision. REPOSITORY R127 KWayland BRANCH arcpatch-D26858 REVISION DETAIL https://phabricator.kde.org/D26858 To: apol, #kwin, #frameworks, zzag, davidedmundson Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

2020-03-19 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 78027. apol added a comment. Fix the refcounting Expose teh set_cursor interface as well REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=77926=78027 BRANCH arcpatch-D26858 REVISION DETAIL

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

2020-03-19 Thread Christoph Feck
cfeck added a comment. Are more changes planned? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: cfeck, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

2020-03-19 Thread Marco Martin
mart added a comment. In D28033#630450 , @ngraham wrote: > > shortDuration: 150ms > longDuration: 250ms > veryLongDuration: 500ms veryLongDuration doesn't sound too good, but if longduration goes 500ms probably a lot of

D18878: Force NT1 protocol when listing smb:// network [work in progress]

2020-03-19 Thread Mikhail Novosyolov
mikhailnov abandoned this revision. mikhailnov added a comment. +1, it is nod needed with recent WSD support REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikhailnov, #dolphin, #frameworks, broulik, ngraham Cc: sitter, ngraham, acrouthamel,

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 171 - Still Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/171/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Mar 2020 14:45:10 + Build duration: 25 min and counting JUnit Tests Name:

D28033: Create ExpandableListItem

2020-03-19 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2,

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 178 - Still Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/178/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 19 Mar 2020 14:45:06 + Build duration: 7 min 13 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 285 - Still Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/285/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Mar 2020 14:45:06 + Build duration: 3 min 3 sec and counting JUnit Tests Name: (root)

D27927: Use more flexible shebang

2020-03-19 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R266:485e7be3b7ef: Use more flexible shebang (authored by tcberner, committed by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27927?vs=77198=78011

D25984: Load translations

2020-03-19 Thread Volker Krause
vkrause added a comment. In D25984#589426 , @mart wrote: > ping, what's the current status of this? There's also https://phabricator.kde.org/D27595, which might address the same/a similar issue. REPOSITORY R169 Kirigami REVISION

D28129: Read the new message string after rather than before

2020-03-19 Thread Harald Sitter
sitter added a comment. Quick recap from what we talked about on telegram: putting the print after the bt is most definitely going to throw off the backtrace parsing logic, so doing it this way would require extensive changes there, which is a dangerous place to make extensive changes. Or

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-19 Thread David Redondo
davidre added a comment. In D27617#630440 , @ilya-fedin wrote: > In D27617#629987 , @ngraham wrote: > > > Would it help this use case if we moved the Telegram icon into the Plasma theme for now,

D27883: Register spawned applications as an independent cgroups

2020-03-19 Thread David Edmundson
davidedmundson added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27883 To: davidedmundson, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27883: Register spawned applications as an independent cgroups

2020-03-19 Thread David Edmundson
davidedmundson added a comment. Relevant docs on the spec we're moving towards: https://github.com/systemd/systemd/pull/14846 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27883 To: davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27883: Register spawned applications as an independent cgroups

2020-03-19 Thread David Edmundson
davidedmundson updated this revision to Diff 78002. davidedmundson added a comment. rebase on David F's work REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27883?vs=77071=78002 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27883 AFFECTED

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 63 - Still Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/63/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Mar 2020 14:04:41 + Build duration: 11 min and counting JUnit Tests Name:

D27883: Register spawned applications as an independent cgroups

2020-03-19 Thread David Edmundson
davidedmundson marked 6 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27883 To: davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

2020-03-19 Thread Vlad Zahorodnii
zzag added a comment. Urgh, the authorship information is screwed up. :/ REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14910 To: graesslin, #kwin, #frameworks, davidedmundson, zzag Cc: plasma-devel, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

2020-03-19 Thread Vlad Zahorodnii
This revision was automatically updated to reflect the committed changes. Closed by commit R127:6bfa71d89aee: Pass a dedicated fd to each keyboard for the xkb keymap (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14910?vs=77916=78000

D18878: Force NT1 protocol when listing smb:// network [work in progress]

2020-03-19 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. We now have WS-Discovery support, so I don't think this patch is needed. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikhailnov,

D26794: [WIP] Implement comment posting (and reenable voting)

2020-03-19 Thread Dan Leinir Turthra Jensen
leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26794 To: leinir Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

2020-03-19 Thread Nathaniel Graham
ngraham added a comment. I agree 150ms for shortDuration is much more sensible; the current speed it too short to even notice that something is animating. I think we need more durations though. My proposal would be something like this: shortDuration: 150ms mediumDuration: 250ms

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-19 Thread Ilya Fedin
ilya-fedin added a comment. In D27617#629987 , @ngraham wrote: > Would it help this use case if we moved the Telegram icon into the Plasma theme for now, pending a fix in Telegram itself? There is nothing to do on Telegram side.

D18878: Force NT1 protocol when listing smb:// network [work in progress]

2020-03-19 Thread Harald Sitter
sitter removed a reviewer: sitter. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikhailnov, #dolphin, #frameworks, broulik Cc: sitter, ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas,

D25984: Load translations

2020-03-19 Thread Harald Sitter
sitter removed a reviewer: sitter. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid Cc: mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

2020-03-19 Thread Vlad Zahorodnii
zzag added a comment. Maybe it would be worth to send an email to wm-spec-list proposing to deprecate LAUNCHED_BY, but on the other hand fixing X11 stuff in any way is like beating a dead horse. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL

D27883: Register spawned applications as an independent cgroups

2020-03-19 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > apol wrote in kprocessrunner.cpp:281 > Who defines this environment variable? I figured startplasma? It's just so we don't change existing code with new frameworks > apol wrote in kprocessrunner.cpp:302 > *signatuRe > > Also I'm not

D27871: sftp: fix seekPos + file resuming when part file is of size 11

2020-03-19 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:d8cf85ec2f0f: sftp: fix seekPos + file resuming when part file is of size 11 (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D28078: guard against duplicated service discoveries

2020-03-19 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:ba96d3b93a96: smb: guard against duplicated service discoveries (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28078?vs=77737=77990

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

2020-03-19 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I don't 100% agree that "it doesn't seem used". It's used in KStartupInfoData::Private::to_text() which affects what gets written out over the wire to everyone else.

D28020: New class ProcessLauncherJob in KIOGui

2020-03-19 Thread David Edmundson
davidedmundson added a comment. In D28020#630185 , @dfaure wrote: > Ah there was still the WId question. I'll remove it before anyone starts using this API. > > We can always add a setter later if we want to (but if it's just for the unused

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-19 Thread Ilya Bizyaev
IlyaBizyaev added a comment. In D27617#630339 , @davidre wrote: > Huh that case is working what I found that `IconName` and `OverlayIconName` is currently broken, see D28107 . > `IconName and

D27544: Fix update scenarios with no explicit downloadlink selected

2020-03-19 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:f1dcbddf12ea: Fix update scenarios with no explicit downloadlink selected (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27544?vs=77818=77989#toc REPOSITORY R304

D27544: Fix update scenarios with no explicit downloadlink selected

2020-03-19 Thread Arjen Hiemstra
ahiemstra accepted this revision. REPOSITORY R304 KNewStuff BRANCH fix-update (branched from master) REVISION DETAIL https://phabricator.kde.org/D27544 To: leinir, #knewstuff, #frameworks, #plasma, ngraham, apol, #discover_software_store, ahiemstra Cc: ahiemstra, alexde,

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 88 - Still Unstable!

2020-03-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/88/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Mar 2020 10:22:57 + Build duration: 4 min 26 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.13 - Build # 74 - Failure!

2020-03-19 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.13/74/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 19 Mar 2020 10:23:12 + Build duration: 1 min 2 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.12 - Build # 107 - Failure!

2020-03-19 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.12/107/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Mar 2020 10:23:11 + Build duration: 56 sec and counting CONSOLE OUTPUT [...truncated 286

D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R296:cebaeb4daf59: Introduce api for passive notifications (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28130?vs=77983=77987 REVISION DETAIL

D28131: listen to passiveNotificationRequested

2020-03-19 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R295:3fe22e067a73: listen to passiveNotificationRequested (authored by mart). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28131?vs=77984=77988 REVISION DETAIL

D28131: listen to passiveNotificationRequested

2020-03-19 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH phab/passiveNotifications REVISION DETAIL https://phabricator.kde.org/D28131 To: mart, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28130: Introduce api for passive notifications

2020-03-19 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH phab/passivenot REVISION DETAIL https://phabricator.kde.org/D28130 To: mart, broulik Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28131: listen to passiveNotificationRequested

2020-03-19 Thread Marco Martin
mart updated this revision to Diff 77984. mart added a comment. - const QVariant REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28131?vs=77941=77984 BRANCH phab/passiveNotifications REVISION DETAIL https://phabricator.kde.org/D28131 AFFECTED FILES

D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin
mart updated this revision to Diff 77983. mart added a comment. - const QVariant & REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28130?vs=77982=77983 BRANCH phab/passivenot REVISION DETAIL https://phabricator.kde.org/D28130 AFFECTED FILES

D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin
mart updated this revision to Diff 77982. mart added a comment. - const QVariant & REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28130?vs=77940=77982 BRANCH phab/passivenot REVISION DETAIL https://phabricator.kde.org/D28130 AFFECTED FILES

D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin
mart added a comment. In D28130#630325 , @davidre wrote: > I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions? doesn't really *need* it, but matches the existing api already existing in

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-19 Thread Ahmad Samir
ahmadsamir added a comment. In D27999#630329 , @dfaure wrote: > Only if an external browser is set, but yeah. Right, I missed the bit about the external browser; however with the recent change to fallback to mimeapps.list if external

D28033: Create ExpandableListItem

2020-03-19 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in ExpandableListItem.qml:230 > If it's multiplied by a factor it's not a "standard duration" anymore. to me this tells more that - default durations right now are waaay too short - we don't take into account that for movements

D28033: Create ExpandableListItem

2020-03-19 Thread Marco Martin
mart added a comment. In D28033#630073 , @ngraham wrote: > (WRT duration) What should I do then? Hardcode something? Add a new duration in a separate patch? The only standard durations we have are all quite short; neither one feels suitable for

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-19 Thread David Redondo
davidre added a comment. In D27617#630336 , @IlyaBizyaev wrote: > In D27617#630228 , @ngraham wrote: > > > So... how do we fix this so that you can use a nice monochrome Breeze icon in your system

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-19 Thread Ilya Bizyaev
IlyaBizyaev added subscribers: ilya-fedin, davidre. IlyaBizyaev added a comment. In D27617#630228 , @ngraham wrote: > So... how do we fix this so that you can use a nice monochrome Breeze icon in your system tray? Whose code needs to change?

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-19 Thread David Faure
dfaure added a comment. Only if an external browser is set, but yeah. REPOSITORY R241 KIO BRANCH l-krun-ssh (branched from master) REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew Cc: kde-frameworks-devel, LeGast00n,

D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin
mart added a comment. In D28130#630325 , @davidre wrote: > I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions? doesn't really *need* it, but matches the existing api already existing in

D28130: Introduce api for passive notifications

2020-03-19 Thread David Redondo
davidre added a comment. I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28130 To: mart Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28130: Introduce api for passive notifications

2020-03-19 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > configmodule.h:507 > + */ > +void showPassiveNotification(const QString , QVariant timeout = > QVariant(), const QString = QString(), const QJSValue = > QJSValue()); > Q_SIGNALS: `const QVariant &` REPOSITORY R296 KDeclarative