D28229: [FileIndexScheduler] Emit change to LowPowerIdle state

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice catch. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28229 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs,

D27724: Synchronise setNeedsSave between KCModule and ConfigModule in both directions

davidedmundson retitled this revision from "Syncronise setNeedsSave between KCModule and ConfigModule in both directions" to "Synchronise setNeedsSave between KCModule and ConfigModule in both directions". REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27724 To:

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

davidedmundson added a comment. > Unfortunately, if the user clicks on reset button at first, the apply button is disabled an stays disabled. I'm not sure I understand why that would happen. That means there's something else going on, and we shouldn't ship this till we understand

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

davidedmundson updated this revision to Diff 78329. davidedmundson added a comment. typo fix REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27724?vs=76644=78329 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27724 AFFECTED FILES

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

davidedmundson marked an inline comment as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27724 To: davidedmundson, ervin Cc: ervin, meven, iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

aacid added a comment. In D26342#632842 , @sdepiets wrote: > In D26342#623729 , @aacid wrote: > > > Would it make sense to enshrine this behaviour with an autotest? > > > Sorry what do you mean

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 78324. ngraham added a comment. Rebase better (one of these days I'll remember to do it right the first time around...) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=78323=78324 BRANCH

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 78323. ngraham added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=78177=78323 BRANCH ExpandableListItem (branched from master) REVISION DETAIL

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f363a06ae697: Update window-pin, Add more sizes, Remove redundant edit-delete (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D28229: [FileIndexScheduler] Emit change to LowPowerIdle state

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The state update is emitted from scheduleIndexing. Trigger it also on

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

ngraham added a dependent revision: D28211: Make Pin buttons consistently sized in System Tray and Clock pop-ups. REPOSITORY R242 Plasma Framework (Library) BRANCH pin-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D28228 To: ndavis, #vdg, #plasma, cblack,

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

ngraham accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH pin-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D28228 To: ndavis, #vdg, #plasma, cblack, ngraham Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

ahmadsamir added inline comments. INLINE COMMENTS > commandlauncherjobtest.cpp:3 > +This file is part of the KDE libraries > +Copyright (c) 2014, 2020 David Faure > + same. > commandlauncherjobtest.h:3 > +This file is part of the KDE libraries > +Copyright (c) 2014, 2020 David

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

ndavis added a comment. In D28228#633141 , @cblack wrote: > Pin icon looks good, but I fail to see how removing edit-delete is a related change in this patch. eh, it's not. I guess I could do it in a separate patch. It's just a pain to

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

cblack accepted this revision as: VDG, cblack. cblack added a comment. This revision is now accepted and ready to land. Pin icon looks good, but I fail to see how removing edit-delete is a related change in this patch. REPOSITORY R242 Plasma Framework (Library) BRANCH pin-icon (branched

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28228 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY 16 and 22px sizes added for window-pin and unpin. Style was also updated for

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added a comment. Anyway, @develoot, could you provide your email address so we can land this patch with proper authorship information? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28200 To: develoot, #vdg, #plasma, #frameworks, davidedmundson Cc:

D27951: Allow users to change dropAction to MoveAction through kdeglobals

ngraham added a comment. Just to add a different perspective on this, while I agree that "many users want it" isn't an automatic justification, I don't think it should carry no weight, either. We are making this software for users, and we ought to pay attention to their desires. Yes, it's

D28128: Add force save behavior to KEntryMap

bport planned changes to this revision. bport added inline comments. INLINE COMMENTS > dfaure wrote in kconfigtest.cpp:1965 > This would pass no matter in which file the write happened, no, due to > caching? > Doesn't this need a generalLocal.reparseConfiguration() to be meaningful? yes indeed

D28128: Add force save behavior to KEntryMap

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Sounds like you need another feature, not breaking an existing one. INLINE COMMENTS > kconfigtest.cpp:1965 > +QVERIFY(local.sync()); > +

D28203: Move corner fold to top right in 24 icons

davidhurka added a comment. There are 172 icons in 16px but not in 22px, and 348 icons in 22px but not in 16px. There are 1561 icons in 22px but not in 32px, and 9 icons in 32px but not in 22px. What are 12px and 32px good for? I fixed the 6 32px icons which had the old style. 2

D28203: Move corner fold to top right in 24 icons

davidhurka updated this revision to Diff 78305. davidhurka added a comment. - link 32px document-preview-archive and document-preview - Move corner fold to top for 6 32px icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28203?vs=78230=78305

D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

davidhurka abandoned this revision. davidhurka added a comment. garg. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28204 To: davidhurka Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

davidhurka updated this revision to Diff 78304. davidhurka added a comment. - link 32px document-preview-archive and document-preview - Move corner fold to top for 6 32px icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28204?vs=78231=78304

D28223: Add "Stat" prefix to StatDetails Enum entries

meven created this revision. meven added reviewers: Frameworks, kossebau, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Relates to D25010 TEST PLAN

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven added a comment. In D25010#632977 , @kossebau wrote: > In D25010#632835 , @dfaure wrote: > > > Yes, either prefixes or the C++11 way with enum class. > > > I propose to go with prefixes

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78299. ahmadsamir added a comment. Also enable size spinbox when enabling the size list box REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78295=78299 BRANCH l-kfontchooser (branched from master)

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

kossebau added a comment. In D25010#632835 , @dfaure wrote: > Yes, either prefixes or the C++11 way with enum class. I propose to go with prefixes again, for consistency with currrent enum usages in KF/KIO APIs. REPOSITORY R241 KIO

D27502: Create ConfigView an unmanaged ConfigWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R246:12d1e200f081: Create ConfigView an unmanaged ConfigWidget (authored by bport). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27502?vs=77269=78296 REVISION DETAIL

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78295. ahmadsamir added a comment. Make connect() actually work for the QCheckBoxes REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78265=78295 BRANCH l-kfontchooser (branched from master)

D28203: Move corner fold to top right in 24 icons

davidhurka added a comment. I understand the concerns. It looks unbalanced. But these icons also look unbalanced now: acrobat, filename-title-amarok. By the way I changed the arrow of document-export to point //outwards// the document, not inwards. That often confused me in inkscape,

D28203: Move corner fold to top right in 24 icons

ngraham added a comment. Looks fine to me in practice: F8195133: Screenshot_20200323_105905.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis Cc: ngraham, kde-frameworks-devel,

D28203: Move corner fold to top right in 24 icons

ndavis added a comment. In D28203#632917 , @ngraham wrote: > Why do you think we shouldn't change the copy icon? Then it would be the only one not using the new style. Admittedly, my justification isn't rock solid. I just think it looks

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport created this revision. bport added reviewers: ervin, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY This will allow administrator to change default value and be

D28128: Add force save behavior to KEntryMap

bport added a dependent revision: D28221: Don't write default value to configuration file when default value came from /etc/* file. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28128 To: bport, ervin, dfaure, meven, crossi, hchain Cc: kde-frameworks-devel,

D27902: smb: figure out the best host to use for the UDS_URL

meven added a comment. Seems fine to me REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27902 To: sitter, ngraham, dfaure Cc: meven, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew,

D28203: Move corner fold to top right in 24 icons

ngraham added a comment. Why do you think we shouldn't change the copy icon? Then it would be the only one not using the new style. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n,

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Maybe the first one should be renamed to ApplicationLauncherJob, now that I found out it wouldn't be a good place for running commands (the setters are too different).

D28203: Move corner fold to top right in 24 icons

ndavis added a comment. I don't think we should change the copy icon. Other than that, this patch looks great. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added reviewers: ahiemstra, broulik, mart. leinir added a comment. tagging in a couple of people who definitely know things about the new thing :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma,

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added reviewers: KNewStuff, Frameworks, Plasma. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28220: Switch to using Kirigami's ShadowedRectangle

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This switches from using the QML DropShadow to using the new, high efficiency ShadowedRectangle in Kirigami. -

Re: Problems in KWayland causes by API and ABI compatibility promises

> > That's a good question! On one hand, it's nice to have Qt-friendly > wrappers for Wayland protocols. On the other hand, it would be even > better to have a library to write Wayland compositors. So, one just > needs to plug a few classes in order to get started with drm and > xdg-shell stuff.

D27504: smb faster copy to local

ngraham added a comment. Yeah due to the quantity of new code, it feels more like 20.08 material, TBH. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck, #frameworks, #dolphin Cc: meven, hallas, anthonyfieroni, asturmlechner,

D27504: smb faster copy to local

sitter added a comment. Any opinions on landing this for 20.04 still? It is technically a bugfix. It is also practically a whole lot of risky code, making me rather uneasy about putting it in past beta. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To:

D28128: Add force save behavior to KEntryMap

bport marked 2 inline comments as done. bport added a comment. Added a unittest REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28128 To: bport, ervin, dfaure, meven, crossi, hchain Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

bport updated this revision to Diff 78289. bport added a comment. Add unit test REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28128?vs=77925=78289 REVISION DETAIL https://phabricator.kde.org/D28128 AFFECTED FILES autotests/kconfigtest.cpp

D28129: Read the new message string after rather than before

sitter added a comment. Mh. Not quite what I had in mind but I suppose it makes sense this way. I think we need a test case for the highlighter though :| It totally blows up in my face when I trace a running dolphin because toskip isn't quite right. INLINE COMMENTS >

D20986: Don't call click on the delegate, when we just want it to become current item

leinir abandoned this revision. leinir added a comment. No longer needed REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20986 To: leinir, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27883: Register spawned applications as an independent cgroups

davidedmundson marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27883 To: davidedmundson, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27883: Register spawned applications as an independent cgroups

davidedmundson updated this revision to Diff 78288. davidedmundson added a comment. review comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27883?vs=78002=78288 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27883 AFFECTED FILES

D26342: Allow overriding to disable auto language detection

sdepiets added a comment. In D26342#623729 , @aacid wrote: > Would it make sense to enshrine this behaviour with an autotest? Sorry what do you mean by that? Similar to tests/BackgroundTest.cpp ? REPOSITORY R246 Sonnet REVISION DETAIL

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added a comment. Yes, either prefixes or the C++11 way with enum class. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28197: [KSortFilterProxyModel QML] Make invalidateFilter public

This revision was automatically updated to reflect the committed changes. Closed by commit R275:37754045e2b8: [KSortFilterProxyModel QML] Make invalidateFilter public (authored by broulik). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE

D27741: KCodecs: Convert license statements to SPDX expressions

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R270 KCodecs BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27741 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in global.h:320 > This injects generic terms like `Basic`, `User`, `Time`, `Acl`, etc. into the > KIO namespace, with no futher hint that these belong to this very enum, > resulting in