D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

2020-04-04 Thread Ahmad Samir
ahmadsamir added a comment. Ping. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28161 To: ahmadsamir, dfaure, sitter, apol Cc: kfm-devel, kde-frameworks-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela,

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

2020-04-04 Thread Ahmad Samir
ahmadsamir abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27216 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27097: [KTextWidgets] Port from QRegExp to QRegularExpression

2020-04-04 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 79373. ahmadsamir retitled this revision from "Port from QRegExp to QRegularExpression" to "[KTextWidgets] Port from QRegExp to QRegularExpression". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision.

D28530: newServicePath(): Docs say add prefix but it's actually suffix

2020-04-04 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R309:0ba647670c31: newServicePath(): Docs say add prefix but its actually suffix (authored by ahmadsamir). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE

D28466: Added Page element

2020-04-04 Thread Nathaniel Graham
ngraham added a task: T10470: Improve the visuals of tray popups. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28466 To: niccolove, #plasma, ngraham, mart Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28573: Add 16px System Settings icon

2020-04-04 Thread Nathaniel Graham
ngraham added a comment. What email address should we use for your commits? BTW If you submit patches with `arc`, I won't have to bug you about this :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28573 To: manueljlin, #vdg, ndavis, ngraham Cc:

D28573: Add 16px System Settings icon

2020-04-04 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28573 To: manueljlin, #vdg, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.14 - Build # 10 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.14/10/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 05 Apr 2020 02:59:19 + Build duration: 5 min 29 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 332 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/332/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 05 Apr 2020 02:59:19 + Build duration: 3 min 48 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.14 - Build # 9 - Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.14/9/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 05 Apr 2020 02:53:18 + Build duration: 5 min 56 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 331 - Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/331/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 05 Apr 2020 02:53:18 + Build duration: 5 min 56 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 14 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/14/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 05 Apr 2020 02:55:32 + Build duration: 1 min 33 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 13 - Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/13/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 05 Apr 2020 02:53:18 + Build duration: 2 min 9 sec and counting JUnit Tests

D27848: Remove the panel tooltip icon

2020-04-04 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R242:863ec93adec6: Remove the panel tooltip icon (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27848?vs=76971=79368 REVISION

D28033: Create ExpandableListItem

2020-04-04 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R242:3bd31386abbf: Create ExpandableListItem (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=79366=79367 REVISION

D28033: Create ExpandableListItem

2020-04-04 Thread Nathaniel Graham
ngraham updated this revision to Diff 79366. ngraham marked an inline comment as done. ngraham added a comment. height -> contentHeight REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=78593=79366 BRANCH ExpandableListItem

D28144: Make animation durations consistent with Kirigami values

2020-04-04 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R242:0739113a4477: Make animation durations consistent with Kirigami values (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D28579: Improve the look of kcachegrind

2020-04-04 Thread Aleix Pol Gonzalez
apol added a comment. +1 much better! REPOSITORY R266 Breeze Icons BRANCH kcachegrind (branched from master) REVISION DETAIL https://phabricator.kde.org/D28579 To: ndavis, #vdg, cblack, ngraham Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28565: [QueryParser] Replace single-use helper with std::none_of

2020-04-04 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28565 To: bruns, #baloo, ngraham, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28579: Improve the look of kcachegrind

2020-04-04 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH kcachegrind (branched from master) REVISION DETAIL https://phabricator.kde.org/D28579 To: ndavis, #vdg, cblack, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28579: Improve the look of kcachegrind

2020-04-04 Thread Carson Black
cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH kcachegrind (branched from master) REVISION DETAIL https://phabricator.kde.org/D28579 To: ndavis, #vdg, cblack Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.14 - Build # 23 - Fixed!

2020-04-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.14/23/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 04 Apr 2020 23:58:09 + Build duration: 1 hr 17 min and counting JUnit Tests Name:

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.14 - Build # 15 - Fixed!

2020-04-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.14/15/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 04 Apr 2020 23:32:36 + Build duration: 1 hr 10 min and counting JUnit Tests

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.14 - Build # 3 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.14/3/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 23:38:26 + Build duration: 26 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 3 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/3/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 23:33:26 + Build duration: 30 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » sonnet » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 23:30:05 + Build duration: 28 min and counting JUnit Tests Name: projectroot

D28561: Remove border from format-border-set-* icons

2020-04-04 Thread Noah Davis
ndavis added a comment. Remove the border. I don't think it makes any sense to use different styled borders to show a lack of borders in certain places. REPOSITORY R266 Breeze Icons BRANCH simplify-format-border REVISION DETAIL https://phabricator.kde.org/D28561 To: davidhurka,

KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.14 - Build # 22 - Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.14/22/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 04 Apr 2020 22:38:40 + Build duration: 1 hr 19 min and counting JUnit Tests

D28561: Remove border from format-border-set-* icons

2020-04-04 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH simplify-format-border REVISION DETAIL https://phabricator.kde.org/D28561 To: davidhurka, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 23:29:56 + Build duration: 27 min and counting JUnit Tests Name: projectroot

D28573: Add 16px System Settings icon

2020-04-04 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28573 To: manueljlin, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 23:20:17 + Build duration: 31 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.14 - Build # 4 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.14/4/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 23:25:22 + Build duration: 25 min and counting BUILD ARTIFACTS

A new playground repo: Kirigami-addons

2020-04-04 Thread David Edmundson
This email is to announce a new pending repo, in playground that I'm hoping to put into kdereview at some point. I've been ridiculously slow with the repository, making promises and then letting people down. I've finally pushed this onto playground in the hope that others can take it to where it

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 23:20:06 + Build duration: 26 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 7 - Fixed!

2020-04-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/7/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 23:12:40 + Build duration: 31 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.14 - Build # 2 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.14/2/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 22:39:39 + Build duration: 58 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 23:10:51 + Build duration: 25 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 23:09:04 + Build duration: 24 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 2 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/2/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 22:37:59 + Build duration: 55 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.14/14/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 04 Apr 2020 22:35:41 + Build duration: 56 min and counting JUnit Tests Name:

KDE CI: Frameworks » sonnet » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 22:39:39 + Build duration: 50 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 22:39:33 + Build duration: 50 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.14 - Build # 3 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.14/3/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 22:37:06 + Build duration: 48 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 22:38:00 + Build duration: 42 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 22:38:22 + Build duration: 41 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 6 - Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/6/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 22:34:03 + Build duration: 38 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kemoticons » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Fixed!

2020-04-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kemoticons/job/kf5-qt5%20WindowsMSVCQt5.14/14/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 04 Apr 2020 22:35:00 + Build duration: 37 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 22:37:28 + Build duration: 33 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 22:33:22 + Build duration: 35 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 22:37:06 + Build duration: 31 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.12 - Build # 88 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.12/88/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 Apr 2020 22:39:39 + Build duration: 24 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 36 - Fixed!

2020-04-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/36/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 22:36:04 + Build duration: 27 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 94 - Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/94/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 Apr 2020 22:37:06 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 2 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/2/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 22:34:29 + Build duration: 18 min and counting JUnit Tests Name:

D28530: newServicePath(): Docs say add prefix but it's actually suffix

2020-04-04 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Buggy since 2003 :-) REPOSITORY R309 KService BRANCH l-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D28530 To: ahmadsamir, #frameworks, dfaure, apol Cc:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 22:34:40 + Build duration: 12 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 22:34:19 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 22:34:03 + Build duration: 9 min 6 sec and counting JUnit Tests Name:

D28295: Introduce KNotificationJobUiDelegate

2020-04-04 Thread David Faure
dfaure added a comment. Done, thanks for the pointer. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28295 To: broulik, #frameworks, nicolasfella, dfaure Cc: ahmadsamir, kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28579: Improve the look of kcachegrind

2020-04-04 Thread Noah Davis
ndavis updated this revision to Diff 79359. ndavis added a comment. Update breeze dark version REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28579?vs=79358=79359 BRANCH kcachegrind (branched from master) REVISION DETAIL

D28579: Improve the look of kcachegrind

2020-04-04 Thread Noah Davis
ndavis updated this revision to Diff 79358. ndavis added a comment. Remove unused element REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28579?vs=79357=79358 BRANCH kcachegrind (branched from master) REVISION DETAIL

D28579: Improve the look of kcachegrind

2020-04-04 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28579 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 122 - Fixed!

2020-04-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/122/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 Apr 2020 22:29:41 + Build duration: 4 min 36 sec and counting BUILD ARTIFACTS

D28579: Improve the look of kcachegrind

2020-04-04 Thread Noah Davis
ndavis updated this revision to Diff 79357. ndavis added a comment. Improve gear contrast with UIs REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28579?vs=79356=79357 BRANCH kcachegrind (branched from master) REVISION DETAIL

D28579: Improve the look of kcachegrind

2020-04-04 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28579 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.14 - Build # 3 - Fixed!

2020-04-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.14/3/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 22:23:48 + Build duration: 4 min 10 sec and counting BUILD ARTIFACTS

D28579: Improve the look of kcachegrind

2020-04-04 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH kcachegrind (branched from master) REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 178 - Fixed!

2020-04-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/178/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 Apr 2020 22:23:13 + Build duration: 3 min 3 sec and counting BUILD ARTIFACTS

D28570: Add 3mf thumbnail support

2020-04-04 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R320:a5ded8f01e60: Add 3mf thumbnail support (authored by davidedmundson). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28570?vs=79329=79355 REVISION DETAIL

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.14 - Build # 2 - Still Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.14/2/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 22:14:41 + Build duration: 1 min 30 sec and counting BUILD ARTIFACTS

D28577: Add StatusBarExtension(KParts::Part *) overloaded constructor.

2020-04-04 Thread David Faure
dfaure created this revision. dfaure added reviewers: vkrause, aacid, cgiboudeaux, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY There's nothing specific to ReadOnlyPart about the

D28574: KRunner: Improve code snippet

2020-04-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH master REVISION DETAIL https://phabricator.kde.org/D28574 To: alex, #plasma, davidedmundson, broulik, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28574: KRunner: Improve code snippet

2020-04-04 Thread Alexander Lohnau
alex created this revision. alex added reviewers: Plasma, davidedmundson, broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The code snippet now uses the Qt5 syntax for the signals and

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

2020-04-04 Thread Méven Car
meven accepted this revision. meven added a comment. Nice, plus a nice test added. Give some time to others to have a final say before merging. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28478 To: ahmadsamir, #frameworks, dfaure, meven, bruns Cc:

D28573: Add 16px System Settings icon

2020-04-04 Thread Manuel Jesús de la Fuente
manueljlin edited the summary of this revision. manueljlin added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28573 To: manueljlin, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28573: Add 16px System Settings icon

2020-04-04 Thread Manuel Jesús de la Fuente
manueljlin created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. manueljlin requested review of this revision. REVISION SUMMARY Adds a pixel fitted icon for System Settings REPOSITORY R266 Breeze Icons REVISION DETAIL

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

2020-04-04 Thread Ahmad Samir
ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > bruns wrote in jobtest.cpp:1510 > The first goal should be to test if it works at all, i.e. if there is an > UDS_DEVICE_ID/INODE at all. OK, that makes sense. Done. REPOSITORY R241 KIO REVISION

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

2020-04-04 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 79339. ahmadsamir added a comment. Skip the smallest part of the unit test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28478?vs=79315=79339 BRANCH l-statx (branched from master) REVISION DETAIL

T12641: Refactor KFileProtocol::copy

2020-04-04 Thread Méven Car
meven updated the task description. TASK DETAIL https://phabricator.kde.org/T12641 To: meven Cc: apol, dfaure, #frameworks, #dolphin, ognarb, broulik, meven, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 35 - Unstable!

2020-04-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/35/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 18:52:59 + Build duration: 5 min 55 sec and counting JUnit Tests Name:

D28555: File ioslave : use Better setting for sendfile syscall

2020-04-04 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R241:10cf5aca5b3d: File ioslave : use Better setting for sendfile syscall (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28555?vs=79284=79338 REVISION

D28555: File ioslave : use Better setting for sendfile syscall

2020-04-04 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH sendfile-opt REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D28555: File ioslave : use Better setting for sendfile syscall

2020-04-04 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH sendfile-opt REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

2020-04-04 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > ahmadsamir wrote in jobtest.cpp:1510 > Why? The goal is to test if the UDS_DEVICE_ID is unique for individual > partitions, which won't work unless there are two separate partitions. The first goal should be to test if it works at all, i.e. if

D28570: Add 3mf thumbnail support

2020-04-04 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D28570 To: davidedmundson, broulik Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n,

D28570: Add 3mf thumbnail support

2020-04-04 Thread David Edmundson
davidedmundson created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY 3D Modelling Format is based on "Open Packaging Conventions" which is already

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

2020-04-04 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > bruns wrote in jobtest.cpp:1510 > This should only apply to the `QVERIFY(device != otherDevice);` Why? The goal is to test if the UDS_DEVICE_ID is unique for individual partitions, which won't work unless there are two separate partitions.

D28561: Remove border from format-border-set-* icons

2020-04-04 Thread David Hurka
davidhurka added a comment. There are 22px versions of these icons. They passed the auto-generation, because they use a different approach. They have a border, but it is not in ViewBackground, but in Text with transparency 0.1. Should I add such a border to the 16px version, or remove it in

Re: New Framework Review: KDAV

2020-04-04 Thread Volker Krause
Thanks for the review! We are cutting it close again with the 20.04 deadline, but fortunately most of these findings aren't ABI-breaking :) The result was discussed in more detail at the (virtual) PIM sprint, summary below for the record. On Saturday, 4 April 2020 16:20:21 CEST Kevin Ottens

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

2020-04-04 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 79315. ahmadsamir marked 2 inline comments as done. ahmadsamir added a comment. - Change unit test name - More QCOMPARE() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28478?vs=79133=79315 BRANCH l-statx (branched

D28555: File ioslave : use Better setting for sendfile syscall

2020-04-04 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah sorry, I missed the fact that one doesn't actually need to call sendfile64() explicitly. And if sendfile fails we have a fall back, so yeah, might as well try in all cases.

D28565: [QueryParser] Replace single-use helper with std::none_of

2020-04-04 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28565

D28555: File ioslave : use Better setting for sendfile syscall

2020-04-04 Thread Stefan Brüns
bruns added a comment. In D28555#641390 , @dfaure wrote: > Sounds like the size check should stay then. Pessimizing sendfile for everyone, for the sake of Linux 2.2.x users? REPOSITORY R241 KIO REVISION DETAIL

D28561: Remove border from format-border-set-* icons

2020-04-04 Thread David Hurka
davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28561 To: davidhurka, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28561: Remove border from format-border-set-* icons

2020-04-04 Thread David Hurka
davidhurka created this revision. davidhurka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY These icons had a kind of border in ViewBackground color, which made them look

D28555: File ioslave : use Better setting for sendfile syscall

2020-04-04 Thread David Faure
dfaure added a comment. Sounds like the size check should stay then. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

Re: New Framework Review: KDAV

2020-04-04 Thread Kevin Ottens
Hello, On Saturday, 9 November 2019 12:33:54 CEST Volker Krause wrote: > during Akademy there was a request to promote KDAV from KDE PIM to > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav support. It > would

D28555: File ioslave : use Better setting for sendfile syscall

2020-04-04 Thread Stefan Brüns
bruns added a comment. @dfaure: probably this: man sendfile, NOTES > The original Linux sendfile() system call was not designed to handle large file offsets. Consequently, Linux 2.4 added sendfile64(), with a wider type for the offset argument. The glibc sendfile() wrapper

D28555: File ioslave : use Better setting for sendfile syscall

2020-04-04 Thread Méven Car
meven added a comment. In D28555#641276 , @dfaure wrote: > any idea what buff_src.st_size < 0x7FFF was for? None, it does not makes sense to me, perhaps, we had an implementation limitation. In D28555#641277

  1   2   >