KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/35/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Wed, 08 Apr 2020 04:23:52 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)65%
(268/412)65%
(268/412)53%
(33421/62686)38%
(17054/44339)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(58/60)97%
(58/60)82%
(8685/10555)40%
(4089/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core83%
(99/119)83%
(99/119)56%
(8153/14612)49%
(4302/8845)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8344)43%
(2081/4824)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(697/1286)39%
(408/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 534 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/534/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 08 Apr 2020 04:23:52 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)65%
(268/412)65%
(268/412)53%
(33412/62685)38%
(17044/44343)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(58/60)97%
(58/60)82%
(8687/10556)40%
(4086/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core83%
(99/119)83%
(99/119)56%
(8145/14611)49%
(4301/8845)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4690/8342)43%
(2081/4828)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(697/1286)39%
(409/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4287)36%
(1300/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/43/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Wed, 08 Apr 2020 04:23:52 +
 Build duration:
6 min 21 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28669: make CopyJob non-recursive

[Friedrich W. H. Kossebau]

kossebau edited reviewers, added: Frameworks, dfaure, meven, ahmadsamir; 
removed: kossebau.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28669

To: McPain, #frameworks, dfaure, meven, ahmadsamir
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28669: make CopyJob non-recursive

[Oleg Solovyov]

McPain created this revision.
McPain added a reviewer: kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
McPain requested review of this revision.

REVISION SUMMARY
  Break recursive loop causing Dolphin to crash when linking 2 objects from 
one directory to another.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28669

AFFECTED FILES
  src/core/copyjob.cpp

To: McPain, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Tips for testing and debugging KWindowSystem

[Victor Dodon]

Hi all,

Can someone give me tips on how to test KWindowSystem while developing? I
have a dual 4K monitor setup and I have found a bug that seems to reside in
KWindowSystem. I would like to try to fix it and then submit a patch, but I
would like to know what's the best way to test and especially to debug this
component. Especially, is it safe to install alongside system packages (I'm
running Arch linux)? How can I debug it (gdb, qDebug())?

Kind regards,
Victor Dodon.

D28397: Replace Vokoscreen with VokoscreenNG

[Nathaniel Graham]

ngraham added a comment.


  You're welcome!

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 31 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/31/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 07 Apr 2020 20:28:12 +
 Build duration:
2 min 42 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 33 test(s)

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 58 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/58/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 07 Apr 2020 20:28:12 +
 Build duration:
1 min 20 sec and counting

D28397: Replace Vokoscreen with VokoscreenNG

[Gaston Haro]

harogaston added a comment.


  In D28397#643937 , @ngraham wrote:
  
  > Great patches, @harogaston! Keep 'em coming! :)
  
  
  Yes, quarantine is working good for me ;).
  I've also got a couple of PRs on Konsole.
  Thank you for your work and support @ngraham !

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

[Stefan Brüns]

bruns added a comment.


  In D28400#643965 , @bcooksley 
wrote:
  
  > Sorry, but that isn't how this works. Also, you will notice that one of the 
failing platforms is FreeBSD. Which is freely available and OSS.
  
  
  That does not change the fact it requires extra effort to install it and keep 
it up to date.
  
  > The responsibility of people to keep code compiling rests with those 
working on it. Should there be platform specific issues they may from time to 
time get assistance from those who look after those platforms, but in general 
the responsibility lies with the person working on the code.
  
  Thats your opinion. Mine differs.
  
  > The FreeBSD failure is most likely due to Clang being more strict with C++ 
than GCC is.
  
  "most likely". So maybe, maybe not...
  
  > As for Windows, that looks to be a namespacing issue.
  
  More guesswork ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28400

To: bruns, #baloo, ngraham
Cc: vkrause, bcooksley, kossebau, kde-frameworks-devel, hurikhan77, lots0logs, 
LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> bruns wrote in searchstore.cpp:82
> Thanks for the heads-up.
> 
> As you have noticed, the message is vague, so someone with access to one of 
> the affected systems should test it and submit a review.

I don't have either of those here to test it for sure, but I have fixed similar 
errors elsewhere recently for those platforms by just adding the  
include, so I think @kossebau is right.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28400

To: bruns, #baloo, ngraham
Cc: vkrause, bcooksley, kossebau, kde-frameworks-devel, hurikhan77, lots0logs, 
LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

[Ben Cooksley]

bcooksley added a comment.


  Sorry, but that isn't how this works. Also, you will notice that one of the 
failing platforms is FreeBSD. Which is freely available and OSS.
  
  The responsibility of people to keep code compiling rests with those working 
on it. Should there be platform specific issues they may from time to time get 
assistance from those who look after those platforms, but in general the 
responsibility lies with the person working on the code.
  
  The FreeBSD failure is most likely due to Clang being more strict with C++ 
than GCC is.
  
  As for Windows, that looks to be a namespacing issue.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28400

To: bruns, #baloo, ngraham
Cc: bcooksley, kossebau, kde-frameworks-devel, hurikhan77, lots0logs, 
LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> kossebau wrote in searchstore.cpp:82
> This might need an explicit `#include ` on some systems, not exactly 
> sure by the error message.
> 
> At least with FreeBSD & Windows KDE CI fails over this: 
> https://build.kde.org/view/Failing/job/Frameworks/job/baloo/

Thanks for the heads-up.

As you have noticed, the message is vague, so someone with access to one of the 
affected systems should test it and submit a review.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28400

To: bruns, #baloo, ngraham
Cc: bcooksley, kossebau, kde-frameworks-devel, hurikhan77, lots0logs, 
LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

[Stefan Brüns]

bruns added a comment.


  In D28400#643934 , @bcooksley 
wrote:
  
  > The following is notice that the following reviews/commits are being 
scheduled to be reverted in 24 hours due to the FTBFS on Windows and FreeBSD:
  >
  > - 2b9c468816459a318dd2c8fe96e5e5acf1cedfd1 

  > - 2fa16a2865dc385f1106c3eadb363bbe9d1244b1 

  > - d4494ee496640325fb6fd72b80f12c5c4b124d22 

  
  
  This is complete nonsense. It is the responsibility of the #windows 
 and #freebsd 
 teams to keep their builds working. 
If Windows/FreeBSD keep failing, *their builds* should be scheduled for removal.
  
  I have no WIndows license, I have no Visual Studio license, I don't care for 
WIndows, and I won't invest any time in it.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28400

To: bruns, #baloo, ngraham
Cc: bcooksley, kossebau, kde-frameworks-devel, hurikhan77, lots0logs, 
LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D28397: Replace Vokoscreen with VokoscreenNG

[Nathaniel Graham]

ngraham added a comment.


  Great patches, @harogaston! Keep 'em coming! :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

[Ben Cooksley]

bcooksley added a comment.


  The following is notice that the following reviews/commits are being 
scheduled to be reverted in 24 hours due to the FTBFS on Windows and FreeBSD:
  
  - 2b9c468816459a318dd2c8fe96e5e5acf1cedfd1 

  - 2fa16a2865dc385f1106c3eadb363bbe9d1244b1 

  - d4494ee496640325fb6fd72b80f12c5c4b124d22 


REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28400

To: bruns, #baloo, ngraham
Cc: bcooksley, kossebau, kde-frameworks-devel, hurikhan77, lots0logs, 
LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D28397: Replace Vokoscreen with VokoscreenNG

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:5613fd66c5f4: Replace Vokoscreen with VokoscreenNG 
(authored by harogaston, committed by ngraham).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28397?vs=79185=79611

REVISION DETAIL
  https://phabricator.kde.org/D28397

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/vokoscreen.desktop
  data/kmoretools-desktopfiles/vokoscreen.png
  data/kmoretools-desktopfiles/vokoscreenNG.desktop
  data/kmoretools-desktopfiles/vokoscreenNG.png
  src/kmoretools/kmoretoolspresets.cpp

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> searchstore.cpp:82
> +};
> +constexpr std::array internalProperties {{
> +{ "filename","F",QVariant::String },

This might need an explicit `#include ` on some systems, not exactly 
sure by the error message.

At least with FreeBSD & Windows KDE CI fails over this: 
https://build.kde.org/view/Failing/job/Frameworks/job/baloo/

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28400

To: bruns, #baloo, ngraham
Cc: kossebau, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28520: Fix lifetime of slot in KIO-MTP

[Alexander Saoutkin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:f4e0183adfd8: Fix lifetime of slot in KIO-MTP (authored 
by feverfew).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28520?vs=79196=79609

REVISION DETAIL
  https://phabricator.kde.org/D28520

AFFECTED FILES
  mtp/kio_mtp.cpp

To: feverfew, akrutzler, dfaure, elvisangelaccio, apol, meven
Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D28460: Add KCModuleStateProbe as base class for plugin

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcmoduleloader.cpp:161
> +if (!mod.service() || mod.service()->noDisplay() || 
> mod.library().isEmpty())
> +{
> +return true;

Curly brace should be on the previous line

> kcmoduleloader.cpp:167
> +args2.reserve(args.count());
> +for (const QString  : args) {
> +args2 << arg;

Wouldn't it be better to initialize args2 with arg iterators?
i.e. `QVariantList args2(arg.cbegin(), arg.cend());`

> kcmodulestateprobe.cpp:47
> +
> +KCModuleStateProbe::~KCModuleStateProbe() {
> +delete d;

Curly brace on the next line

> kcmodulestateprobe.cpp:55
> +
> +void KCModuleStateProbe::registerSkeleton(KCoreConfigSkeleton *skeleton) {
> +if (!skeleton || d->_skeletons.contains(skeleton)) {

Curly brace on the next line

> kcmodulestateprobe.h:44
> +
> +virtual void virtual_hook(int id, void *data);
> +

Should be protected not public

> broulik wrote in kcmodulestateprobe.h:39
> Please add a `virtual_hook` so we can extend this class in the future without 
> breaking ABI should we have the need to extract more data out of a settings 
> module:
> 
>   virtual void virtual_hook(int id, void *data)

I'd slightly disagree here though, if that inherits from QObject anyway I'd 
just rely on meta call dispatching. But OK, let's go virtual_hook.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28460

To: bport, #plasma, ervin
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28221: Don't write default value to configuration file when default value came from /etc/* file

[Benjamin Port]

bport added a comment.


  In D28221#641971 , @dfaure wrote:
  
  > I have a hard time accepting that the documentation was wrong -- and if it 
was, then this commit has to fix it, and port as much of the app code that does 
exactly this, as possible.
  
  
  From my POV documentation is not "wrong", but this point of view describe 
only default from cpp, no default from global file.
  The current implementation and I don't know why (perhaps I will need to do 
some archeology there) don't allow to follow default value if it came from a 
file and follow changes made in the file over time. Like we do with cpp default.
  
  > I don't really know what mReference is. What about a test that uses KConfig 
directly (no skeletons), to test e.g. what kwindowconfig.cpp?
  >  Sorry to be a non-believer, I just sense a very strong risk of regression 
here, and if not, then a lot of porting effort. Unless there's a good reason 
for this stuff to be that way, that we still have to find out.
  
  It's important to consider this kind of stuff. I think we can check to port 
stuff. However I don't think we can have regression but more incoherence 
between not yet ported code that will behave like now (don't follow new value 
in the file providing default) and ported code that will track default if 
default change in the file.
  
  > I lack time and concentration right now to dig further, but I wanted to not 
delay my reply longer.
  
  No proble, thanks for all your feedback

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28221

To: bport, ervin, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28221: Don't write default value to configuration file when default value came from /etc/* file

[Kevin Ottens]

ervin added a comment.


  LGTM but @dfaure concerns need to be addressed.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28221

To: bport, ervin, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

[Kevin Ottens]

ervin accepted this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28128

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 30 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/30/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 07 Apr 2020 15:23:03 +
 Build duration:
1 min 18 sec and counting
   CONSOLE OUTPUT
  [...truncated 609 lines...][2020-04-07T15:24:07.085Z] [ 46%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/queryparsertest.cpp.o[2020-04-07T15:24:07.085Z] [ 46%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/unindexedfileindexer.cpp.o[2020-04-07T15:24:08.920Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/file/fileindexerconfig.cpp:56:12: warning: local variable 'path' will be copied despite being returned by name [-Wreturn-std-move][2020-04-07T15:24:08.920Z] return path;[2020-04-07T15:24:08.920Z]^~~~[2020-04-07T15:24:08.920Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/file/fileindexerconfig.cpp:56:12: note: call 'std::move' explicitly to avoid copying[2020-04-07T15:24:08.920Z] return path;[2020-04-07T15:24:08.920Z]^~~~[2020-04-07T15:24:08.920Z]std::move(path)[2020-04-07T15:24:08.920Z] [ 46%] Linking CXX executable ../../../bin/transactiontest[2020-04-07T15:24:08.920Z] [ 46%] Built target transactiontest[2020-04-07T15:24:08.920Z] [ 46%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexer.cpp.o[2020-04-07T15:24:08.920Z] 1 warning generated.[2020-04-07T15:24:08.920Z] [ 46%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexerprovider.cpp.o[2020-04-07T15:24:08.920Z] [ 46%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/storagedevices.cpp.o[2020-04-07T15:24:08.920Z] [ 47%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/regexpcache.cpp.o[2020-04-07T15:24:08.920Z] [ 47%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileexcludefilters.cpp.o[2020-04-07T15:24:08.920Z] [ 47%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/singledbtest.cpp.o[2020-04-07T15:24:09.583Z] [ 48%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/extractorprocess.cpp.o[2020-04-07T15:24:09.583Z] [ 48%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/propertydata.cpp.o[2020-04-07T15:24:09.583Z] [ 48%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/timeestimator.cpp.o[2020-04-07T15:24:10.160Z] [ 48%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/searchstore.cpp.o[2020-04-07T15:24:10.160Z] [ 49%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/dbus/maininterface.cpp.o[2020-04-07T15:24:10.160Z] [ 50%] Linking CXX executable ../../../bin/queryparsertest[2020-04-07T15:24:10.160Z] [ 50%] Built target queryparsertest[2020-04-07T15:24:10.422Z] Scanning dependencies of target mtimedbtest[2020-04-07T15:24:10.422Z] [ 50%] Building CXX object autotests/unit/engine/CMakeFiles/mtimedbtest.dir/mtimedbtest_autogen/mocs_compilation.cpp.o[2020-04-07T15:24:10.686Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/file/extractorprocess.cpp:37:21: warning: unused parameter 'exitCode' [-Wunused-parameter][2020-04-07T15:24:10.686Z] [=](int exitCode, QProcess::ExitStatus exitStatus)[2020-04-07T15:24:10.686Z] ^[2020-04-07T15:24:10.686Z] [ 51%] Building CXX object autotests/unit/engine/CMakeFiles/mtimedbtest.dir/mtimedbtest.cpp.o[2020-04-07T15:24:10.980Z] 1 warning generated.[2020-04-07T15:24:10.980Z] [ 51%] Building CXX object autotests/unit/engine/CMakeFiles/mtimedbtest.dir/singledbtest.cpp.o[2020-04-07T15:24:10.980Z] [ 51%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/indexcleaner.cpp.o[2020-04-07T15:24:11.240Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/lib/searchstore.cpp:82:43: error: constexpr variable cannot have non-literal type 'const std::array'[2020-04-07T15:24:11.240Z] constexpr std::array internalProperties {{[2020-04-07T15:24:11.240Z]   ^[2020-04-07T15:24:11.240Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/lib/searchstore.cpp:82:43: error: implicit instantiation of undefined template 'std::__1::array'[2020-04-07T15:24:11.240Z] /usr/include/c++/v1/__tuple:223:64: note: template is declared here[2020-04-07T15:24:11.240Z] template  struct _LIBCPP_TEMPLATE_VIS array;[2020-04-07T15:24:11.240Z]^[2020-04-07T15:24:11.549Z] 2 errors generated.[2020-04-07T15:24:11.549Z] gmake[2]: *** [src/lib/CMakeFiles/KF5Baloo.dir/build.make:271: src/lib/CMakeFiles/KF5Baloo.dir/searchstore.cpp.o] Error 1[2020-04-07T15:24:11.549Z] gmake[2]: *** Waiting for unfinished jobs[2020-04-07T15:24:11.812Z] Scanning dependencies of target documentiddbtest[2020-04-07T15:24:11.812Z] [ 51%] Building CXX object 

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 57 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/57/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 07 Apr 2020 15:23:03 +
 Build duration:
58 sec and counting
   CONSOLE OUTPUT
  [...truncated 406 lines...][2020-04-07T15:23:53.259Z] [30/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\database.cpp.obj[2020-04-07T15:23:53.834Z] [31/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\vectorpostingiterator.cpp.obj[2020-04-07T15:23:53.834Z] [32/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\postingiterator.cpp.obj[2020-04-07T15:23:54.094Z] [33/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\KF5BalooEngine_autogen\mocs_compilation.cpp.obj[2020-04-07T15:23:54.094Z] [34/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\mtimedb.cpp.obj[2020-04-07T15:23:54.358Z] [35/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\global.cpp.obj[2020-04-07T15:23:54.358Z] [36/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\phraseanditerator.cpp.obj[2020-04-07T15:23:54.358Z] [37/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\queryparser.cpp.obj[2020-04-07T15:23:54.358Z] [38/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\postingdb.cpp.obj[2020-04-07T15:23:54.358Z] ..\src\engine\postingdb.cpp(103): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:23:54.358Z] ..\src\engine\postingdb.cpp(139): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:23:54.358Z] ..\src\engine\postingdb.cpp(178): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data[2020-04-07T15:23:54.358Z] ..\src\engine\postingdb.cpp(326): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:23:54.358Z] ..\src\engine\postingdb.cpp(327): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:23:54.358Z] ..\src\engine\postingdb.cpp(232): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:23:54.358Z] ..\src\engine\postingdb.cpp(259): note: see reference to function template instantiation 'Baloo::PostingIterator *Baloo::PostingDB::iter>(const QByteArray &,Validator)' being compiled[2020-04-07T15:23:54.358Z] with[2020-04-07T15:23:54.358Z] [[2020-04-07T15:23:54.358Z] Validator=Baloo::PostingDB::prefixIter::[2020-04-07T15:23:54.358Z] ][2020-04-07T15:23:54.358Z] ..\src\engine\postingdb.cpp(237): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data[2020-04-07T15:23:54.636Z] [39/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\positiondb.cpp.obj[2020-04-07T15:23:54.636Z] ..\src\engine\positiondb.cpp(105): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:23:54.636Z] ..\src\engine\positiondb.cpp(145): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:23:54.636Z] ..\src\engine\positiondb.cpp(168): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:23:54.636Z] ..\src\engine\positiondb.cpp(169): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:23:54.636Z] [40/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\writetransaction.cpp.obj[2020-04-07T15:23:54.636Z] [41/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\vectorpositioninfoiterator.cpp.obj[2020-04-07T15:23:54.907Z] [42/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\termgenerator.cpp.obj[2020-04-07T15:23:54.907Z] [43/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\transaction.cpp.obj[2020-04-07T15:23:55.172Z] [44/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\enginedebug.cpp.obj[2020-04-07T15:23:55.172Z] [45/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\fsutils.cpp.obj[2020-04-07T15:23:55.759Z] [46/81] Linking CXX shared library bin\KF5BalooEngine.dll[2020-04-07T15:23:55.759Z]Creating library lib\KF5BalooEngine.lib and object lib\KF5BalooEngine.exp[2020-04-07T15:23:55.759Z]Creating library lib\KF5BalooEngine.lib and object lib\KF5BalooEngine.exp[2020-04-07T15:23:56.025Z] [47/81] Automatic MOC for target KF5Baloo[2020-04-07T15:23:56.025Z] [48/81] Generating baloosettings.h, baloosettings.cpp[2020-04-07T15:23:56.025Z] [49/81] Generating baloosettings.moc[2020-04-07T15:23:57.437Z] [50/81] Building CXX object src\lib\CMakeFiles\KF5Baloo.dir\queryrunnable.cpp.obj[2020-04-07T15:23:57.701Z] [51/81] Building CXX object src\lib\CMakeFiles\KF5Baloo.dir\advancedqueryparser.cpp.obj[2020-04-07T15:23:57.701Z] [52/81] Building CXX object 

D28500: [PhraseAndIteratorTest] Cleanup, use better variable names

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:d4494ee49664: [PhraseAndIteratorTest] Cleanup, use better 
variable names (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28500?vs=79107=79587

REVISION DETAIL
  https://phabricator.kde.org/D28500

AFFECTED FILES
  autotests/unit/engine/phraseanditeratortest.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 29 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/29/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 07 Apr 2020 15:20:03 +
 Build duration:
1 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 586 lines...][2020-04-07T15:21:15.094Z] return path;[2020-04-07T15:21:15.094Z]^~~~[2020-04-07T15:21:15.094Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/file/fileindexerconfig.cpp:56:12: note: call 'std::move' explicitly to avoid copying[2020-04-07T15:21:15.094Z] return path;[2020-04-07T15:21:15.094Z]^~~~[2020-04-07T15:21:15.094Z]std::move(path)[2020-04-07T15:21:15.094Z] [ 41%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/xattrindexer.cpp.o[2020-04-07T15:21:15.356Z] [ 42%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/modifiedfileindexer.cpp.o[2020-04-07T15:21:15.356Z] [ 43%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/regexpcache.cpp.o[2020-04-07T15:21:15.618Z] 1 warning generated.[2020-04-07T15:21:15.618Z] [ 43%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileexcludefilters.cpp.o[2020-04-07T15:21:15.893Z] [ 43%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/unindexedfileindexer.cpp.o[2020-04-07T15:21:16.159Z] [ 43%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexer.cpp.o[2020-04-07T15:21:16.431Z] [ 44%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/propertydata.cpp.o[2020-04-07T15:21:16.729Z] [ 44%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/propertydata.cpp.o[2020-04-07T15:21:16.729Z] [ 44%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/searchstore.cpp.o[2020-04-07T15:21:16.729Z] [ 44%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloodebug.cpp.o[2020-04-07T15:21:17.704Z] [ 45%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/dbus/maininterface.cpp.o[2020-04-07T15:21:17.704Z] [ 45%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/baloodebug.cpp.o[2020-04-07T15:21:17.704Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/lib/searchstore.cpp:82:43: error: constexpr variable cannot have non-literal type 'const std::array'[2020-04-07T15:21:17.704Z] constexpr std::array internalProperties {{[2020-04-07T15:21:17.704Z]   ^[2020-04-07T15:21:17.704Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/lib/searchstore.cpp:82:43: error: implicit instantiation of undefined template 'std::__1::array'[2020-04-07T15:21:17.704Z] /usr/include/c++/v1/__tuple:223:64: note: template is declared here[2020-04-07T15:21:17.704Z] template  struct _LIBCPP_TEMPLATE_VIS array;[2020-04-07T15:21:17.704Z]^[2020-04-07T15:21:17.972Z] [ 45%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexerprovider.cpp.o[2020-04-07T15:21:17.972Z] 2 errors generated.[2020-04-07T15:21:17.972Z] gmake[2]: *** [src/lib/CMakeFiles/KF5Baloo.dir/build.make:271: src/lib/CMakeFiles/KF5Baloo.dir/searchstore.cpp.o] Error 1[2020-04-07T15:21:17.972Z] gmake[2]: *** Waiting for unfinished jobs[2020-04-07T15:21:17.972Z] Scanning dependencies of target orpostingiteratortest[2020-04-07T15:21:18.239Z] [ 45%] Building CXX object autotests/unit/engine/CMakeFiles/orpostingiteratortest.dir/orpostingiteratortest_autogen/mocs_compilation.cpp.o[2020-04-07T15:21:18.239Z] Scanning dependencies of target andpostingiteratortest[2020-04-07T15:21:18.239Z] [ 45%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloosettings.cpp.o[2020-04-07T15:21:18.239Z] [ 45%] Building CXX object autotests/unit/engine/CMakeFiles/andpostingiteratortest.dir/andpostingiteratortest_autogen/mocs_compilation.cpp.o[2020-04-07T15:21:18.824Z] Scanning dependencies of target transactiontest[2020-04-07T15:21:18.824Z] [ 45%] Building CXX object autotests/unit/engine/CMakeFiles/transactiontest.dir/transactiontest_autogen/mocs_compilation.cpp.o[2020-04-07T15:21:19.896Z] [ 46%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/extractorprocess.cpp.o[2020-04-07T15:21:19.896Z] [ 46%] Building CXX object autotests/unit/engine/CMakeFiles/andpostingiteratortest.dir/andpostingiteratortest.cpp.o[2020-04-07T15:21:19.896Z] [ 46%] Building CXX object autotests/unit/engine/CMakeFiles/orpostingiteratortest.dir/orpostingiteratortest.cpp.o[2020-04-07T15:21:19.896Z] [ 46%] Linking CXX executable ../../../bin/baloo_file_extractor[2020-04-07T15:21:20.162Z] [ 46%] Built target baloo_file_extractor[2020-04-07T15:21:20.162Z] [ 46%] Building CXX object autotests/unit/engine/CMakeFiles/andpostingiteratortest.dir/singledbtest.cpp.o[2020-04-07T15:21:20.433Z] gmake[1]: *** [CMakeFiles/Makefile2:2021: src/lib/CMakeFiles/KF5Baloo.dir/all] Error 

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 56 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/56/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 07 Apr 2020 15:20:03 +
 Build duration:
48 sec and counting
   CONSOLE OUTPUT
  [...truncated 406 lines...][2020-04-07T15:20:46.078Z] [30/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\KF5BalooEngine_autogen\mocs_compilation.cpp.obj[2020-04-07T15:20:46.078Z] [31/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\database.cpp.obj[2020-04-07T15:20:46.647Z] [32/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\postingiterator.cpp.obj[2020-04-07T15:20:46.647Z] [33/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\orpostingiterator.cpp.obj[2020-04-07T15:20:46.647Z] [34/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\phraseanditerator.cpp.obj[2020-04-07T15:20:47.217Z] [35/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\vectorpostingiterator.cpp.obj[2020-04-07T15:20:47.217Z] [36/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\postingdb.cpp.obj[2020-04-07T15:20:47.217Z] ..\src\engine\postingdb.cpp(103): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:20:47.217Z] ..\src\engine\postingdb.cpp(139): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:20:47.217Z] ..\src\engine\postingdb.cpp(178): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data[2020-04-07T15:20:47.217Z] ..\src\engine\postingdb.cpp(326): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:20:47.217Z] ..\src\engine\postingdb.cpp(327): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:20:47.217Z] ..\src\engine\postingdb.cpp(232): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:20:47.217Z] ..\src\engine\postingdb.cpp(259): note: see reference to function template instantiation 'Baloo::PostingIterator *Baloo::PostingDB::iter>(const QByteArray &,Validator)' being compiled[2020-04-07T15:20:47.217Z] with[2020-04-07T15:20:47.217Z] [[2020-04-07T15:20:47.217Z] Validator=Baloo::PostingDB::prefixIter::[2020-04-07T15:20:47.217Z] ][2020-04-07T15:20:47.217Z] ..\src\engine\postingdb.cpp(237): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data[2020-04-07T15:20:47.217Z] [37/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\positiondb.cpp.obj[2020-04-07T15:20:47.217Z] ..\src\engine\positiondb.cpp(105): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:20:47.217Z] ..\src\engine\positiondb.cpp(145): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:20:47.217Z] ..\src\engine\positiondb.cpp(168): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:20:47.217Z] ..\src\engine\positiondb.cpp(169): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:20:47.217Z] [38/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\termgenerator.cpp.obj[2020-04-07T15:20:47.217Z] [39/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\global.cpp.obj[2020-04-07T15:20:47.217Z] [40/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\queryparser.cpp.obj[2020-04-07T15:20:47.217Z] [41/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\vectorpositioninfoiterator.cpp.obj[2020-04-07T15:20:47.217Z] [42/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\enginedebug.cpp.obj[2020-04-07T15:20:47.217Z] [43/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\transaction.cpp.obj[2020-04-07T15:20:47.475Z] [44/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\fsutils.cpp.obj[2020-04-07T15:20:47.734Z] [45/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\writetransaction.cpp.obj[2020-04-07T15:20:48.305Z] [46/81] Linking CXX shared library bin\KF5BalooEngine.dll[2020-04-07T15:20:48.305Z]Creating library lib\KF5BalooEngine.lib and object lib\KF5BalooEngine.exp[2020-04-07T15:20:48.305Z]Creating library lib\KF5BalooEngine.lib and object lib\KF5BalooEngine.exp[2020-04-07T15:20:48.305Z] [47/81] Automatic MOC for target KF5Baloo[2020-04-07T15:20:48.305Z] [48/81] Generating baloosettings.h, baloosettings.cpp[2020-04-07T15:20:48.566Z] [49/81] Generating baloosettings.moc[2020-04-07T15:20:49.509Z] [50/81] Building CXX object src\lib\CMakeFiles\KF5Baloo.dir\queryrunnable.cpp.obj[2020-04-07T15:20:49.509Z] [51/81] Building CXX object src\lib\CMakeFiles\KF5Baloo.dir\advancedqueryparser.cpp.obj[2020-04-07T15:20:49.509Z] [52/81] Building CXX object 

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 55 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/55/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 07 Apr 2020 15:18:37 +
 Build duration:
59 sec and counting
   CONSOLE OUTPUT
  [...truncated 406 lines...][2020-04-07T15:19:29.392Z] ..\src\engine\postingdb.cpp(139): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:19:29.392Z] ..\src\engine\postingdb.cpp(178): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data[2020-04-07T15:19:29.392Z] ..\src\engine\postingdb.cpp(314): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:19:29.392Z] ..\src\engine\postingdb.cpp(315): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:19:29.392Z] ..\src\engine\postingdb.cpp(232): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:19:29.392Z] ..\src\engine\postingdb.cpp(259): note: see reference to function template instantiation 'Baloo::PostingIterator *Baloo::PostingDB::iter>(const QByteArray &,Validator)' being compiled[2020-04-07T15:19:29.392Z] with[2020-04-07T15:19:29.392Z] [[2020-04-07T15:19:29.392Z] Validator=Baloo::PostingDB::prefixIter::[2020-04-07T15:19:29.392Z] ][2020-04-07T15:19:29.392Z] ..\src\engine\postingdb.cpp(237): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data[2020-04-07T15:19:29.392Z] [30/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\database.cpp.obj[2020-04-07T15:19:29.976Z] [31/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\orpostingiterator.cpp.obj[2020-04-07T15:19:30.322Z] [32/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\idtreedb.cpp.obj[2020-04-07T15:19:30.322Z] ..\src\engine\idtreedb.cpp(96): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:19:30.322Z] ..\src\engine\idtreedb.cpp(191): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:19:30.322Z] [33/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\enginequery.cpp.obj[2020-04-07T15:19:30.322Z] [34/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\KF5BalooEngine_autogen\mocs_compilation.cpp.obj[2020-04-07T15:19:30.322Z] [35/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\vectorpostingiterator.cpp.obj[2020-04-07T15:19:30.322Z] [36/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\documentiddb.cpp.obj[2020-04-07T15:19:30.322Z] ..\src\engine\documentiddb.cpp(151): warning C4267: 'return': conversion from 'size_t' to 'uint', possible loss of data[2020-04-07T15:19:30.322Z] [37/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\idfilenamedb.cpp.obj[2020-04-07T15:19:30.322Z] ..\src\engine\idfilenamedb.cpp(105): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:19:30.322Z] ..\src\engine\idfilenamedb.cpp(164): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-07T15:19:30.581Z] [38/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\vectorpositioninfoiterator.cpp.obj[2020-04-07T15:19:30.581Z] [39/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\mtimedb.cpp.obj[2020-04-07T15:19:30.581Z] [40/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\termgenerator.cpp.obj[2020-04-07T15:19:30.581Z] [41/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\global.cpp.obj[2020-04-07T15:19:30.581Z] [42/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\writetransaction.cpp.obj[2020-04-07T15:19:30.581Z] [43/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\transaction.cpp.obj[2020-04-07T15:19:30.839Z] [44/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\enginedebug.cpp.obj[2020-04-07T15:19:31.099Z] [45/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\fsutils.cpp.obj[2020-04-07T15:19:31.363Z] [46/81] Linking CXX shared library bin\KF5BalooEngine.dll[2020-04-07T15:19:31.363Z]Creating library lib\KF5BalooEngine.lib and object lib\KF5BalooEngine.exp[2020-04-07T15:19:31.363Z]Creating library lib\KF5BalooEngine.lib and object lib\KF5BalooEngine.exp[2020-04-07T15:19:31.621Z] [47/81] Automatic MOC for target KF5Baloo[2020-04-07T15:19:31.621Z] [48/81] Generating baloosettings.h, baloosettings.cpp[2020-04-07T15:19:31.621Z] [49/81] Generating baloosettings.moc[2020-04-07T15:19:32.663Z] [50/81] Building CXX object src\lib\CMakeFiles\KF5Baloo.dir\filemonitor.cpp.obj[2020-04-07T15:19:32.663Z] [51/81] Building CXX object src\lib\CMakeFiles\KF5Baloo.dir\advancedqueryparser.cpp.obj[2020-04-07T15:19:32.663Z] [52/81] Building CXX object 

D28401: [SearchStore] Handle double values in property queries

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:2fa16a2865dc: [SearchStore] Handle double values in 
property queries (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28401?vs=78784=79585

REVISION DETAIL
  https://phabricator.kde.org/D28401

AFFECTED FILES
  src/engine/postingdb.cpp
  src/engine/postingdb.h
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 28 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/28/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 07 Apr 2020 15:18:51 +
 Build duration:
44 sec and counting
   CONSOLE OUTPUT
  [...truncated 666 lines...][2020-04-07T15:19:29.316Z] [ 57%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloodebug.cpp.o[2020-04-07T15:19:29.316Z] [ 57%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloosettings.cpp.o[2020-04-07T15:19:29.316Z] [ 57%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/storagedevices.cpp.o[2020-04-07T15:19:29.572Z] [ 57%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/fileindexerconfig.cpp.o[2020-04-07T15:19:30.033Z] [ 58%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/regexpcache.cpp.o[2020-04-07T15:19:30.033Z] [ 58%] Linking CXX executable ../../../bin/positiondbtest[2020-04-07T15:19:30.033Z] [ 58%] Built target positiondbtest[2020-04-07T15:19:30.033Z] [ 58%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/basicindexingjob.cpp.o[2020-04-07T15:19:30.033Z] [ 58%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileexcludefilters.cpp.o[2020-04-07T15:19:30.033Z] [ 58%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/powerstatemonitor.cpp.o[2020-04-07T15:19:30.033Z] [ 59%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/fileindexscheduler.cpp.o[2020-04-07T15:19:30.033Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/file/fileindexerconfig.cpp:56:12: warning: local variable 'path' will be copied despite being returned by name [-Wreturn-std-move][2020-04-07T15:19:30.033Z] return path;[2020-04-07T15:19:30.033Z]^~~~[2020-04-07T15:19:30.033Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/file/fileindexerconfig.cpp:56:12: note: call 'std::move' explicitly to avoid copying[2020-04-07T15:19:30.033Z] return path;[2020-04-07T15:19:30.033Z]^~~~[2020-04-07T15:19:30.033Z]std::move(path)[2020-04-07T15:19:30.328Z] [ 59%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/firstrunindexer.cpp.o[2020-04-07T15:19:30.328Z] [ 59%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/propertydata.cpp.o[2020-04-07T15:19:30.328Z] [ 59%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/searchstore.cpp.o[2020-04-07T15:19:30.584Z] 1 warning generated.[2020-04-07T15:19:30.584Z] [ 60%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/dbus/maininterface.cpp.o[2020-04-07T15:19:30.584Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/file/fileindexerconfig.cpp:56:12: warning: local variable 'path' will be copied despite being returned by name [-Wreturn-std-move][2020-04-07T15:19:30.584Z] return path;[2020-04-07T15:19:30.584Z]^~~~[2020-04-07T15:19:30.584Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/file/fileindexerconfig.cpp:56:12: note: call 'std::move' explicitly to avoid copying[2020-04-07T15:19:30.584Z] return path;[2020-04-07T15:19:30.584Z]^~~~[2020-04-07T15:19:30.584Z]std::move(path)[2020-04-07T15:19:30.584Z] [ 60%] Linking CXX executable ../../../bin/baloo_file_extractor[2020-04-07T15:19:30.584Z] [ 60%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/newfileindexer.cpp.o[2020-04-07T15:19:30.584Z] [ 60%] Built target baloo_file_extractor[2020-04-07T15:19:30.584Z] [ 60%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/xattrindexer.cpp.o[2020-04-07T15:19:30.845Z] [ 60%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/baloodebug.cpp.o[2020-04-07T15:19:30.845Z] [ 61%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/modifiedfileindexer.cpp.o[2020-04-07T15:19:30.845Z] [ 61%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/baloosettings.cpp.o[2020-04-07T15:19:30.845Z] 1 warning generated.[2020-04-07T15:19:31.108Z] [ 61%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/unindexedfileindexer.cpp.o[2020-04-07T15:19:31.108Z] [ 61%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexer.cpp.o[2020-04-07T15:19:31.108Z] [ 61%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexerprovider.cpp.o[2020-04-07T15:19:31.108Z] [ 62%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/extractorprocess.cpp.o[2020-04-07T15:19:31.368Z] [ 62%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/timeestimator.cpp.o[2020-04-07T15:19:31.368Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/lib/searchstore.cpp:82:43: error: constexpr variable cannot have non-literal type 'const std::array'[2020-04-07T15:19:31.368Z] constexpr std::array internalProperties {{[2020-04-07T15:19:31.368Z]   ^[2020-04-07T15:19:31.368Z] 

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:2b9c46881645: [AdvancedQueryParser] Move semantic 
handling of tokens to SearchStore (authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28400?vs=78783=79584#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28400?vs=78783=79584

REVISION DETAIL
  https://phabricator.kde.org/D28400

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp
  src/engine/postingdb.cpp
  src/engine/postingdb.h
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/lib/advancedqueryparser.cpp
  src/lib/searchstore.cpp
  src/lib/searchstore.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28324: [Inotify] Remove dead/duplicate code

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:bcb5950e958e: [Inotify] Remove dead/duplicate code 
(authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28324?vs=78600=79582#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28324?vs=78600=79582

REVISION DETAIL
  https://phabricator.kde.org/D28324

AFFECTED FILES
  src/file/kinotify.cpp

To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28328: [Inotify] Remove not-so-OptimizedByteArray

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:24e64713592a: [Inotify] Remove not-so-OptimizedByteArray 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28328?vs=78608=79583

REVISION DETAIL
  https://phabricator.kde.org/D28328

AFFECTED FILES
  src/file/kinotify.cpp
  src/file/optimizedbytearray.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28500: [PhraseAndIteratorTest] Cleanup, use better variable names

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28500

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28401: [SearchStore] Handle double values in property queries

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28401

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28400

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28328: [Inotify] Remove not-so-OptimizedByteArray

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28328

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28324: [Inotify] Remove dead/duplicate code

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I think this is fine.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28324

To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 34 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/34/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 07 Apr 2020 13:23:04 +
 Build duration:
48 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)65%
(268/412)65%
(268/412)53%
(33433/62687)38%
(17058/44339)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(58/60)97%
(58/60)82%
(8687/10555)40%
(4090/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core83%
(99/119)83%
(99/119)56%
(8158/14612)49%
(4303/8845)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8344)43%
(2081/4824)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(697/1286)39%
(408/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

D27557: Auto-generate 24px monochrome icons

[David Hurka]

davidhurka added a comment.


  In D27557#616831 , @sitter wrote:
  
  >
  
  
  
  
  > - if your script is doing a lot of stuff you may want to revise how the 
script works. specifically for this diff sed needs to iter all the content of 
all the SVGs this can benefit greatly from running across multiple cores, but 
with the way it is written it cannot. a better solution would be to move the 
for loop into cmake and then construct targets for all files where each target 
calls `generate.sh inputfile` and the shell script only has the logic from 
inside the loop. this effectively gives you free "threading" in that 
cmake/make/ninja know how to run build targets in parallel so by making each 
file its own target you can now utilize all cores of a system without having to 
manage threading manually.
  
  
  
  1. I’m sure most build systems don’t run on Tianhe-2, so we don’t need one 
thread per icon.
  2. If someone uses make instead of ninja, make will take very much time to 
fire up the 2000 (11000 if we also auto-generate dark versions) threads.
  
  I think it makes more sense to define one target for every directory, and 
then 4 (43) parralel-running Python scripts iterate through their own 
directory. Then we also don’t need a for loop in cmake.
  
  By the way that inefficient shell script needs only 18 seconds on my 
slowbook. I think that is fast enough and competitively green enough, and a 
streamlined Python script will probably be even better.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: davidhurka, usta, davidre, bcooksley, kossebau, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 533 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/533/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 07 Apr 2020 13:23:22 +
 Build duration:
33 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)65%
(268/412)65%
(268/412)53%
(33431/62685)38%
(17047/44343)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(58/60)97%
(58/60)82%
(8685/10556)40%
(4081/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core83%
(99/119)83%
(99/119)56%
(8164/14612)49%
(4306/8845)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8342)43%
(2080/4828)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(697/1286)39%
(409/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 42 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/42/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 07 Apr 2020 13:23:02 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Ahmad Samir]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d025ed9bfe4d: [FileProtocol] change statx stat_dev() to 
return makedev(major, minor) (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28478?vs=79567=79568

REVISION DETAIL
  https://phabricator.kde.org/D28478

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Ahmad Samir]

ahmadsamir updated this revision to Diff 79567.
ahmadsamir marked an inline comment as done.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28478?vs=79411=79567

BRANCH
  l-statx (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28478

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27910: Make sure warning output is enabled before testing if the correct warning is printed

[David Faure]

dfaure added a comment.


  I like your first suggestion.
  
  I don't like the second one, because QT_LOGGING_RULES is used (by at least CI 
and myself) to enable *more* debug output. unsetenv would break that.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D27910

To: sandsmark, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27910: Make sure warning output is enabled before testing if the correct warning is printed

[Martin Tobias Holmedahl Sandsmark]

sandsmark abandoned this revision.
sandsmark added a comment.


  In D27910#632041 , @dfaure wrote:
  
  > Note that in both cases the env var QT_LOGGING_RULES would break the 
unittest anyway... so yeah it's only about qtlogging.ini which we can easily 
skip with test mode.
  
  
  Yeah, the issue for me was qtlogging.ini, but it's not that far fetched that 
the user has set QT_LOGGING_RULES manually. Because it's a bit surprising and 
not obvious why this fails, maybe we could check if the warnings are disabled 
(e. g. `if (!KArchiveLog().isWarningEnabled()) { qWarning()<< "Warnings 
disabled for" << KArchiveLog().categoryName() << ", the test will probably 
fail"; }`), if not outright calling `qunsetenv("QT_LOGGING_RULES");`

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D27910

To: sandsmark, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[Noah Davis]

ndavis added a comment.


  I could probably make the python script instead, but I'm in the same spot 
when it comes to writing CMake.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

[Jonathan Marten]

marten created this revision.
marten added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
marten requested review of this revision.

REVISION SUMMARY
  I've been looking at porting Konqueror's User Agent Changer plugin to current 
KF5.  The GUI is ported and working, but trying to change the user agent more 
than once in any given invocation of the browser does not seem to work.
  
  After changing the user agent string in kio_httprc, the plugin calls 
KIO::Scheduler::emitReparseSlaveConfiguration() to inform all running ioslaves 
of the change.  This first of all calls slotReparseSlaveConfiguration() 
directly to update in the current process, and then sets m_ignoreConfigReparse 
to true and emits the reparseSlaveConfiguration() signal.  The signal calls 
slotReparseSlaveConfiguration() via DBus;  when activated in the same process 
slotReparseSlaveConfiguration() ignores the signal because 
m_ignoreConfigReparse is set, it is reset to false and simply returns.
  
  However, it appears that the signal does not get looped back to the current 
process; in other words, slotReparseSlaveConfiguration() is not called via the 
DBus signal.  This means that m_ignoreConfigReparse is never reset to false 
and, the next time that KIO::Scheduler::emitReparseSlaveConfiguration() is 
called it has no effect.  This can be confirmed by uncommenting the "Ignoring 
signal sent by myself" debug line in slotReparseSlaveConfiguration(), the 
message is never printed.
  
  The change fixes this by explicitly setting m_ignoreConfigReparse to false 
before the direct call of slotReparseSlaveConfiguration(), then to true before 
the DBus call.  This inhibits the loopback signal in case it does happen, but 
ensures that the direct call is not ignored.

TEST PLAN
  Tested with https://kluge.in-chemnitz.de/tools/browser.php to show the user 
agent as sent.
  Observed that, with this fix, the user agent can be changed as many times as 
required.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28647

AFFECTED FILES
  src/core/scheduler.cpp

To: marten, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28476: Samba: Ensure to differenciate mounts sharing the same source

[Méven Car]

meven added a comment.


  In D28476#639524 , @bruns wrote:
  
  > The comment and commit message are lacking required information. One should 
not have to go to the bug report to actually see why this is needed.
  
  
  How about the commit title "Ensure to differenciate mounts sharing the same 
source" -> it implies that before this, mounts sharing the same source where 
not differentiated. That already sounds pretty bad to me...

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28476

To: meven, #frameworks, sitter
Cc: bruns, ahmadsamir, anthonyfieroni, sitter, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham