D28590: Add a QString Solid::Device::label, used in Fstab Device for network mounts

[Méven Car]

meven updated this revision to Diff 79807.
meven marked 2 inline comments as done.
meven added a comment.


  Rename label to displayName

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28590?vs=79397&id=79807

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28590

AFFECTED FILES
  src/solid/devices/backends/fakehw/fakedevice.cpp
  src/solid/devices/backends/fakehw/fakedevice.h
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabmanager.cpp
  src/solid/devices/backends/shared/rootdevice.cpp
  src/solid/devices/backends/shared/rootdevice.h
  src/solid/devices/backends/udev/udevdevice.cpp
  src/solid/devices/backends/udev/udevdevice.h
  src/solid/devices/backends/udev/udevmanager.cpp
  src/solid/devices/backends/udisks2/udisksdevice.cpp
  src/solid/devices/backends/udisks2/udisksdevice.h
  src/solid/devices/backends/udisks2/udisksmanager.cpp
  src/solid/devices/backends/upower/upowerdevice.cpp
  src/solid/devices/backends/upower/upowerdevice.h
  src/solid/devices/backends/upower/upowermanager.cpp
  src/solid/devices/frontend/device.cpp
  src/solid/devices/frontend/device.h
  src/solid/devices/ifaces/device.h

To: meven, #frameworks, bruns, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven added a dependent revision: D28738: Use KFileItem::recursiveSize to 
Display recursize size as total size.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven updated this revision to Diff 79804.
meven marked 3 inline comments as done.
meven added a comment.


  Rebase, update @since, add precision to KFileItem comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24773?vs=68829&id=79804

BRANCH
  arcpatch-D24773_1

REVISION DETAIL
  https://phabricator.kde.org/D24773

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kfileitem.h
  src/core/udsentry.h
  src/ioslaves/trash/kio_trash.cpp
  src/ioslaves/trash/trashimpl.cpp
  src/ioslaves/trash/trashimpl.h

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28737: Add sim card device icons

[Carson Black]

cblack accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  sim-card (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28737

To: ndavis, #vdg, cblack
Cc: kde-frameworks-devel, Orage, LeGast00n, cblack, hannahk, frmdstryr, 
fbampaloukas, GB_2, emrek, mkraemer, cahfofpai, asghaier, michaelh, tbalzer, 
dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, alexeymin, 
jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas

D28737: Add sim card device icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28737

To: ndavis, #vdg
Cc: kde-frameworks-devel, Orage, LeGast00n, cblack, hannahk, frmdstryr, 
fbampaloukas, GB_2, emrek, mkraemer, cahfofpai, asghaier, michaelh, tbalzer, 
dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, alexeymin, 
jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas

D28737: Add sim card device icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  For Plasma Mobile

REPOSITORY
  R266 Breeze Icons

BRANCH
  sim-card (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28737

AFFECTED FILES
  icons-dark/devices/16/auth-sim.svg
  icons-dark/devices/22/auth-sim.svg
  icons-dark/devices/64/auth-sim.svg
  icons-dark/devices/symbolic/auth-sim-symbolic.svg
  icons/devices/16/auth-sim.svg
  icons/devices/22/auth-sim.svg
  icons/devices/64/auth-sim.svg
  icons/devices/symbolic/auth-sim-symbolic.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28737: Add sim card device icons

[Noah Davis]

ndavis added a project: Plasma: Mobile.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28737

To: ndavis, #vdg
Cc: kde-frameworks-devel, Orage, LeGast00n, cblack, hannahk, frmdstryr, 
fbampaloukas, GB_2, emrek, mkraemer, cahfofpai, asghaier, michaelh, tbalzer, 
dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, alexeymin, 
jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas

D28734: Port to Aether Bootstrap 4

[Carson Black]

cblack updated this revision to Diff 79798.
cblack added a comment.


  Remove unused Bootstrap 3 assets

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28734?vs=79796&id=79798

BRANCH
  cblack+ognarb/bootstrap-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28734

AFFECTED FILES
  src/kapidox/data/htmlresource/3rd-party/bootstrap/LICENSE.txt
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap-theme.css
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap-theme.css.map
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap-theme.min.css
  
src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap-theme.min.css.map
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap.css
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap.css.map
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap.min.css
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap.min.css.map
  
src/kapidox/data/htmlresource/3rd-party/bootstrap/fonts/glyphicons-halflings-regular.eot
  
src/kapidox/data/htmlresource/3rd-party/bootstrap/fonts/glyphicons-halflings-regular.svg
  
src/kapidox/data/htmlresource/3rd-party/bootstrap/fonts/glyphicons-halflings-regular.ttf
  
src/kapidox/data/htmlresource/3rd-party/bootstrap/fonts/glyphicons-halflings-regular.woff
  
src/kapidox/data/htmlresource/3rd-party/bootstrap/fonts/glyphicons-halflings-regular.woff2
  src/kapidox/data/htmlresource/3rd-party/bootstrap/js/bootstrap.js
  src/kapidox/data/htmlresource/3rd-party/bootstrap/js/bootstrap.min.js
  src/kapidox/data/htmlresource/3rd-party/bootstrap/js/npm.js
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html

To: cblack, #vdg, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28734: Port to Aether Bootstrap 4

[Carson Black]

cblack updated this revision to Diff 79796.
cblack added a comment.


  Fix footer text

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28734?vs=79794&id=79796

BRANCH
  cblack+ognarb/bootstrap-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28734

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html

To: cblack, #vdg, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28734: Port to Aether Bootstrap 4

[Carson Black]

cblack edited the summary of this revision.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28734

To: cblack, #vdg, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28734: Port to Aether Bootstrap 4

[Carson Black]

cblack edited the summary of this revision.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28734

To: cblack, #vdg, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28734: Port to Aether Bootstrap 4

[Carson Black]

cblack created this revision.
cblack added reviewers: VDG, ochurlaud.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Output generated by kapidox now uses Aether Bootstrap from the KDE CDN.
  
  F8230701: 
janpontaoski.ddns.net_8000_frameworks_kwayland_html_classKWayland_1_1Server_1_1BufferHandle.html
 (1).png 
  
  F8230699: 
janpontaoski.ddns.net_8000_frameworks_kwayland_html_classKWayland_1_1Server_1_1BufferHandle.html.png
 

REPOSITORY
  R264 KApiDox

BRANCH
  cblack+ognarb/bootstrap-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28734

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html

To: cblack, #vdg, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D19736: Add rotation icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:48a112fb64dc: Add rotation icons (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19736?vs=79765&id=79791

REVISION DETAIL
  https://phabricator.kde.org/D19736

AFFECTED FILES
  icons-dark/actions/16/screen-rotate-auto-off.svg
  icons-dark/actions/16/screen-rotate-auto-on.svg
  icons-dark/actions/22/screen-rotate-auto-off.svg
  icons-dark/actions/22/screen-rotate-auto-on.svg
  icons-dark/actions/32/screen-rotate-auto-off.svg
  icons-dark/actions/32/screen-rotate-auto-on.svg
  icons-dark/actions/symbolic/screen-rotate-auto-off-symbolic.svg
  icons-dark/actions/symbolic/screen-rotate-auto-on-symbolic.svg
  icons-dark/status/16/rotation-allowed.svg
  icons-dark/status/16/rotation-locked-landscape.svg
  icons-dark/status/16/rotation-locked-portrait.svg
  icons-dark/status/22/rotation-allowed.svg
  icons-dark/status/22/rotation-locked-landscape.svg
  icons-dark/status/22/rotation-locked-portrait.svg
  icons-dark/status/32/rotation-allowed.svg
  icons-dark/status/32/rotation-locked-landscape.svg
  icons-dark/status/32/rotation-locked-portrait.svg
  icons-dark/status/symbolic/rotation-allowed-symbolic.svg
  icons-dark/status/symbolic/rotation-locked-landscape-symbolic.svg
  icons-dark/status/symbolic/rotation-locked-portrait-symbolic.svg
  icons-dark/status/symbolic/rotation-locked-symbolic.svg
  icons/status/16/rotation-allowed.svg
  icons/status/16/rotation-locked-landscape.svg
  icons/status/16/rotation-locked-portrait.svg
  icons/status/22/rotation-allowed.svg
  icons/status/22/rotation-locked-landscape.svg
  icons/status/22/rotation-locked-portrait.svg
  icons/status/32/rotation-allowed.svg
  icons/status/32/rotation-locked-landscape.svg
  icons/status/32/rotation-locked-portrait.svg
  icons/status/symbolic/rotation-allowed-symbolic.svg
  icons/status/symbolic/rotation-locked-landscape-symbolic.svg
  icons/status/symbolic/rotation-locked-portrait-symbolic.svg
  icons/status/symbolic/rotation-locked-symbolic.svg

To: ndavis, #vdg, apol, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D19736: Add rotation icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  rotate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[Konrad Materka]

kmaterka added a comment.


  ping, review needed :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/5/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 10 Apr 2020 17:58:49 +
 Build duration:
7 min 1 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.69.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)87%
(260/298)87%
(260/298)67%
(33011/49189)49%
(14807/30096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src97%
(37/38)97%
(37/38)93%
(4791/5129)49%
(1812/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5526/5568)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1677/1892)74%
(1082/1472)src.completion100%
(11/11)100%
(11/11)57%
(1785/3131)42%
(1008/2423)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/855)0%
(0/180)src.document100%
(4/4)100%
(4/4)61%
(1937/3176)48%
(1419/2977)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)84%
(187/222)55%
(125/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1050)16%
(146/897)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(7/7)100%
(7/7)77%
(947/1224)67%
(612/916)src.schema29%
(2/7)29%
(2/7)1%
(19/1468)1%
(6/625)src.script100%
(16/16)100%
(16/16)68%
(706/1038)54%

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/6/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 10 Apr 2020 17:58:49 +
 Build duration:
5 min 7 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testAdaFailed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D27844: Store and fetch complete view config in and from session config

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:0611924df7b0: Store and fetch complete view config in and 
from session config (authored by kossebau).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27844?vs=76962&id=79783

REVISION DETAIL
  https://phabricator.kde.org/D27844

AFFECTED FILES
  src/view/kateview.cpp

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28460: Add KCModuleStateProbe as base class for plugin

[Benjamin Port]

bport updated this revision to Diff 79780.
bport added a comment.


  Rename state probe to data (because can be useful for more than only state 
probe)

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28460?vs=79772&id=79780

REVISION DETAIL
  https://phabricator.kde.org/D28460

AFFECTED FILES
  src/CMakeLists.txt
  src/kcmoduledata.cpp
  src/kcmoduledata.h
  src/kcmoduleloader.cpp
  src/kcmoduleloader.h

To: bport, #plasma, ervin
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/36/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 10 Apr 2020 16:54:14 +
 Build duration:
7 min 26 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)65%
(268/412)65%
(268/412)53%
(33426/62687)38%
(17065/44339)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(58/60)97%
(58/60)82%
(8685/10555)40%
(4090/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core83%
(99/119)83%
(99/119)56%
(8153/14612)49%
(4309/8845)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8344)43%
(2081/4824)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(697/1286)39%
(408/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 535 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/535/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 10 Apr 2020 16:54:14 +
 Build duration:
7 min 28 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)65%
(268/412)65%
(268/412)53%
(33418/62685)38%
(17058/44343)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(58/60)97%
(58/60)82%
(8685/10556)40%
(4090/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core83%
(99/119)83%
(99/119)56%
(8152/14612)49%
(4305/8845)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8342)43%
(2083/4828)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(697/1286)39%
(408/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/44/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 10 Apr 2020 16:54:14 +
 Build duration:
6 min 33 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28723: [KPropertiesDialog] Fix QLayout warning

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e4bf478b7d07: [KPropertiesDialog] Fix QLayout warning 
(authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28723?vs=79767&id=79778

REVISION DETAIL
  https://phabricator.kde.org/D28723

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28723: [KPropertiesDialog] Fix QLayout warning

[Méven Car]

meven accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  l-kprop-qframe (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28723

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28726: [KJS] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, porten.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R314 KJs

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28726

AFFECTED FILES
  autotests/ecmatest.cpp
  autotests/kjsapitest.cpp

To: ahmadsamir, #frameworks, porten
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28460: Add KCModuleStateProbe as base class for plugin

[Benjamin Port]

bport marked 10 inline comments as done.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28460

To: bport, #plasma, ervin
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28460: Add KCModuleStateProbe as base class for plugin

[Benjamin Port]

bport updated this revision to Diff 79772.
bport added a comment.


  ervin feedback

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28460?vs=79496&id=79772

REVISION DETAIL
  https://phabricator.kde.org/D28460

AFFECTED FILES
  src/CMakeLists.txt
  src/kcmoduleloader.cpp
  src/kcmoduleloader.h
  src/kcmodulestateprobe.cpp
  src/kcmodulestateprobe.h

To: bport, #plasma, ervin
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28712: Redo api.kde.org to look more like Aether

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R264:a6c47b24d1df: Redo api.kde.org to look more like Aether 
(authored by cblack).

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28712?vs=79738&id=79769

REVISION DETAIL
  https://phabricator.kde.org/D28712

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/frontpage-sidebar.html
  src/kapidox/data/templates/frontpage.html
  src/kapidox/data/templates/library-sidebar.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna

D28723: [KPropertiesDialog] Fix QLayout warning

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, meven.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  If a widget, QFrame in this case, already has a QLayout, adding/parenting
  another layout to it shows a warning:
  
  QLayout: Attempting to add QLayout "" to QFrame "", which already has a 
layout"
  
  this happens when showing the properties of a symlink to a dir.

REPOSITORY
  R241 KIO

BRANCH
  l-kprop-qframe (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28723

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28679: [KPropertiesDialog] Disable changing remote dir icons

[Ahmad Samir]

ahmadsamir updated this revision to Diff 79766.
ahmadsamir retitled this revision from "[KPropertiesDialog] Disable changing 
dir icon on samba shares" to "[KPropertiesDialog] Disable changing remote dir 
icons".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir removed a subscriber: broulik.
ahmadsamir added a comment.


  Exclude everything that's !isLocalFile() or desktop:/

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28679?vs=79643&id=79766

BRANCH
  l-kprop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28679

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: ahmadsamir, #frameworks, dfaure, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns, 
broulik

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

[Ahmad Samir]

ahmadsamir added a comment.


  And it seems recentdocuments:/ shows representation of recent "documents", 
parsed from .desktop files in ~/.local/share/RecentDocuments/, so it doesn't 
need to be handled here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28679

To: ahmadsamir, #frameworks, dfaure, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D19736: Add rotation icons

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D19736: Add rotation icons

[Noah Davis]

ndavis retitled this revision from "Add 
view-orientation-auto/landscape/portrait" to "Add rotation icons".
ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D19736: Add view-orientation-auto/landscape/portrait

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D19736: Add view-orientation-auto/landscape/portrait

[Noah Davis]

ndavis updated this revision to Diff 79765.
ndavis added a comment.


  - Update style

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19736?vs=55804&id=79765

BRANCH
  rotate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19736

AFFECTED FILES
  icons-dark/actions/16/screen-rotate-auto-off.svg
  icons-dark/actions/16/screen-rotate-auto-on.svg
  icons-dark/actions/22/screen-rotate-auto-off.svg
  icons-dark/actions/22/screen-rotate-auto-on.svg
  icons-dark/actions/32/screen-rotate-auto-off.svg
  icons-dark/actions/32/screen-rotate-auto-on.svg
  icons-dark/actions/symbolic/screen-rotate-auto-off-symbolic.svg
  icons-dark/actions/symbolic/screen-rotate-auto-on-symbolic.svg
  icons-dark/status/16/rotation-allowed.svg
  icons-dark/status/16/rotation-locked-landscape.svg
  icons-dark/status/16/rotation-locked-portrait.svg
  icons-dark/status/22/rotation-allowed.svg
  icons-dark/status/22/rotation-locked-landscape.svg
  icons-dark/status/22/rotation-locked-portrait.svg
  icons-dark/status/32/rotation-allowed.svg
  icons-dark/status/32/rotation-locked-landscape.svg
  icons-dark/status/32/rotation-locked-portrait.svg
  icons-dark/status/symbolic/rotation-allowed-symbolic.svg
  icons-dark/status/symbolic/rotation-locked-landscape-symbolic.svg
  icons-dark/status/symbolic/rotation-locked-portrait-symbolic.svg
  icons-dark/status/symbolic/rotation-locked-symbolic.svg
  icons/status/16/rotation-allowed.svg
  icons/status/16/rotation-locked-landscape.svg
  icons/status/16/rotation-locked-portrait.svg
  icons/status/22/rotation-allowed.svg
  icons/status/22/rotation-locked-landscape.svg
  icons/status/22/rotation-locked-portrait.svg
  icons/status/32/rotation-allowed.svg
  icons/status/32/rotation-locked-landscape.svg
  icons/status/32/rotation-locked-portrait.svg
  icons/status/symbolic/rotation-allowed-symbolic.svg
  icons/status/symbolic/rotation-locked-landscape-symbolic.svg
  icons/status/symbolic/rotation-locked-portrait-symbolic.svg
  icons/status/symbolic/rotation-locked-symbolic.svg

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/6/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 10 Apr 2020 13:16:58 +
 Build duration:
1 min 28 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D28699: Add startCapture method

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:5eb3c795a8f2: Add startCapture method (authored by 
davidre).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28699?vs=79691&id=79764

REVISION DETAIL
  https://phabricator.kde.org/D28699

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml

To: davidre, #frameworks, davidedmundson, broulik, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

[Benjamin Port]

bport accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-monospace-checkbox

REVISION DETAIL
  https://phabricator.kde.org/D28274

To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

[Ahmad Samir]

ahmadsamir added a comment.


  I did some more testing:
  
$ grep -ir :local *protocol
about.protocol:Class=:local
activities.protocol:Class=:local
applications.protocol:Class=:local
ar.protocol:Class=:local
baloosearch.protocol:Class=:local
bookmarks.protocol:Class=:local
camera.protocol:Class=:local
desktop.protocol:Class=:local
filenamesearch.protocol:Class=:local
fonts.protocol:Class=:local
info.protocol:Class=:local
man.protocol:Class=:local
programs.protocol:Class=:local
recentdocuments.protocol:Class=:local
settings.protocol:Class=:local
tags.protocol:Class=:local
tar.protocol:Class=:local
timeline.protocol:Class=:local
zip.protocol:Class=:local
  
$ grep -ir writ *protocol
activities.protocol:writing=true
applications.protocol:writing=false
baloosearch.protocol:writing=false
camera.protocol:writing=false
cifs.protocol:writing=true
desktop.protocol:writing=true
filenamesearch.protocol:writing=false
fish.protocol:writing=true
fonts.protocol:writing=true
ldap.protocol:writing=true
ldaps.protocol:writing=true
metainfo.protocol:writing=true
mmst.protocol:writing=false
mmsu.protocol:writing=false
mtp.protocol:writing=true
pnm.protocol:writing=false
programs.protocol:writing=false
recentdocuments.protocol:writing=true
rtsp.protocol:writing=false
rtspt.protocol:writing=false
rtspu.protocol:writing=false
settings.protocol:writing=false
sftp.protocol:writing=true
smb.protocol:writing=true
tags.protocol:writing=true
timeline.protocol:writing=true
  
  from all these, I would enable changing icon for KItemFile.isLocalFile(), 
desktop:/ and recentdocuments:/; I couldn't test the camera:/ protocol as I 
don't currently have access to a camera.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28679

To: ahmadsamir, #frameworks, dfaure, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28712: Redo api.kde.org to look more like Aether

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.


  LGTM

REPOSITORY
  R264 KApiDox

BRANCH
  cblack/aether (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna

D27844: Store and fetch complete view config in and from session config

[Christoph Cullmann]

cullmann added a comment.


  Yes, please push, thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  fullviewconfigsessionsupport

REVISION DETAIL
  https://phabricator.kde.org/D27844

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28682: rename and export done signal in filecontentindexer

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> filecontentindexer.cpp:111
>  [this, elapsed, batchSize] { newBatchTime(elapsed, 
> batchSize); },
>  Qt::QueuedConnection);
>  }

Sorry, seems I got a little bit confused, the `commitedBatch` has to go here.

And when I look at it, you can piggy-back on `newBatchTime`, which is emitted 
on each batch. For your use case, just ignore the values.

So new proposal, rename `newBatchTime(elapsed, batchSize)` to 
`committedBatch(elapsed, batchSize)` and export it. Keep `done` as is.

> filecontentindexer.cpp:114
>  }
> -QMetaObject::invokeMethod(this, &FileContentIndexer::done, 
> Qt::QueuedConnection);
> +QMetaObject::invokeMethod(this, &FileContentIndexer::committedBatch, 
> Qt::QueuedConnection);
>  }

This has to stay as is, as it means **everything**done

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi added a comment.


  In D27951#645212 , @meven wrote:
  
  > I might take over to finish it eventually.
  
  
  Yes, please. I'm very glad that you support this. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: bruns, elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, ngraham

D24773: kio_trash: Add size, modification, access and create date for trash:/

[David Faure]

dfaure added a comment.


  This looks good. I think I failed to notice the last update, sorry for the 
delay.
  
  Can you rebase (I suspect a few conflicts) and update version numbers to 
5.70? Then it'll be good to go.
  
  Ah, and the documentation for the KFileItem getter needs to say that this is 
generally NOT available and right now only implemented for trash:/.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28682: rename and export done signal in filecontentindexer

[Alexander Stippich]

astippich retitled this revision from "export done signal in 
filecontentindexer" to "rename and export done signal in filecontentindexer".

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28682: export done signal in filecontentindexer

[Alexander Stippich]

astippich updated this revision to Diff 79751.
astippich added a comment.


  - rename signal

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28682?vs=79657&id=79751

BRANCH
  exportSignal

REVISION DETAIL
  https://phabricator.kde.org/D28682

AFFECTED FILES
  src/file/filecontentindexer.cpp
  src/file/filecontentindexer.h
  src/file/fileindexscheduler.cpp

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams