D27152: Introduce FilesystemEntry class

2020-04-11 Thread David Hallas
hallas marked an inline comment as done.
hallas added a comment.


  Hi @bruns  - did you have a chance to go through this patch again? Am I 
missing anything to move on with this?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27152

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28766: Add auth-sim-locked and auth-sim-missing

2020-04-11 Thread Noah Davis
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:169b438c9fc1: Add auth-sim-locked and auth-sim-missing 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28766?vs=79895=79896

REVISION DETAIL
  https://phabricator.kde.org/D28766

AFFECTED FILES
  icons-dark/status/16/auth-sim-locked.svg
  icons-dark/status/16/auth-sim-missing.svg
  icons-dark/status/22/auth-sim-locked.svg
  icons-dark/status/22/auth-sim-missing.svg
  icons-dark/status/symbolic/auth-sim-locked-symbolic.svg
  icons-dark/status/symbolic/auth-sim-missing-symbolic.svg
  icons/status/16/auth-sim-locked.svg
  icons/status/16/auth-sim-missing.svg
  icons/status/22/auth-sim-locked.svg
  icons/status/22/auth-sim-missing.svg
  icons/status/symbolic/auth-sim-locked-symbolic.svg
  icons/status/symbolic/auth-sim-missing-symbolic.svg

To: ndavis, #vdg, cblack
Cc: kde-frameworks-devel, salvahg, Orage, LeGast00n, cblack, hannahk, 
frmdstryr, fbampaloukas, emrek, mkraemer, cahfofpai, asghaier, michaelh, 
tbalzer, dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, 
alexeymin, jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas


D28766: Add auth-sim-locked and auth-sim-missing

2020-04-11 Thread Carson Black
cblack accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  sim-card (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28766

To: ndavis, #vdg, cblack
Cc: kde-frameworks-devel, salvahg, Orage, LeGast00n, cblack, hannahk, 
frmdstryr, fbampaloukas, emrek, mkraemer, cahfofpai, asghaier, michaelh, 
tbalzer, dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, 
alexeymin, jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas


D28766: Add auth-sim-locked and auth-sim-missing

2020-04-11 Thread Noah Davis
ndavis edited the test plan for this revision.
ndavis added a project: Plasma: Mobile.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28766

To: ndavis, #vdg
Cc: kde-frameworks-devel, salvahg, Orage, LeGast00n, cblack, hannahk, 
frmdstryr, fbampaloukas, emrek, mkraemer, cahfofpai, asghaier, michaelh, 
tbalzer, dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, 
alexeymin, jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas


D28766: Add auth-sim-locked and auth-sim-missing

2020-04-11 Thread Noah Davis
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  For Plasma Mobile

REPOSITORY
  R266 Breeze Icons

BRANCH
  sim-card (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28766

AFFECTED FILES
  icons-dark/status/16/auth-sim-locked.svg
  icons-dark/status/16/auth-sim-missing.svg
  icons-dark/status/22/auth-sim-locked.svg
  icons-dark/status/22/auth-sim-missing.svg
  icons-dark/status/symbolic/auth-sim-locked-symbolic.svg
  icons-dark/status/symbolic/auth-sim-missing-symbolic.svg
  icons/status/16/auth-sim-locked.svg
  icons/status/16/auth-sim-missing.svg
  icons/status/22/auth-sim-locked.svg
  icons/status/22/auth-sim-missing.svg
  icons/status/symbolic/auth-sim-locked-symbolic.svg
  icons/status/symbolic/auth-sim-missing-symbolic.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-04-11 Thread Carson Black
cblack added inline comments.

INLINE COMMENTS

> kcmoduleinfo.h:130
>   * @return a QExplicitlySharedDataPointer to KService created from the 
> modules .desktop file
> + * WARNING: this will be null if this KCModuleInfo was created from a 
> KPluginInfo coming from KPluginMetaData
> + * Prefer using pluginInfo() instead, which works for both kinds.

Use `@warning` instead of `WARNING:` for better markup

`WARNING:`
F8232033: image.png 
`@warning:`
F8232034: image.png 

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28765

To: dfaure, pino, broulik, mart, davidedmundson
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-04-11 Thread David Faure
dfaure created this revision.
dfaure added reviewers: pino, broulik, mart, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  KPluginInfo evolved into an abstraction over old-style plugins
  (KService i.e. desktop files) and new-style plugins with JSON
  (KPluginMetaData/KPluginLoader).
  
  When porting kontact to new-style plugins, I hit the issue that
  KSettings::Dialog has a code path that creates a 'fake' KCM module
  just to get a checkable item in the config dialog. That fake module
  was using the plugininfo's KService, which was null, into the KCModuleInfo.
  
  So I added support for metadata-based plugins to KCModuleInfo.
  But rather than using KPluginMetaData and then turning KCModuleInfo into
  yet another abstraction over old and new, I just used KPluginInfo in
  there. One can still create a KCModuleInfo from a KService, but
  internally it'll use a KPluginInfo. This makes KCModuleInfo::service()
  dangerous now though, it can be null [but only in apps that start passing
  new-style KPluginInfos, so not in systemsettings5 yet].
  This commits ports kcmutils away from it as much as possible.

TEST PLAN
  kontact's configuration dialog works (with and without my
  not-yet-committed port to KPluginLoader). systemsettings5 still works.
  konqueror's configuration dialog still works.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28765

AFFECTED FILES
  src/kcmoduleinfo.cpp
  src/kcmoduleinfo.h
  src/kcmoduleloader.cpp
  src/kcmultidialog.cpp
  src/kpluginselector.cpp
  src/ksettings/dialog.cpp

To: dfaure, pino, broulik, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


Re: Update on Status of Gitlab Migration

2020-04-11 Thread Ben Cooksley
On Sun, Apr 12, 2020 at 11:04 AM Johan Ouwerkerk  wrote:
>
> On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk  
> wrote:
> >
> > Yes the only reason why a cleanup script might be needed is if the
> > logical path used to express the repo in dependency information
> > changes at the same time. E.g. suppose a `frameworks/kf5foo` gets
> > remapped to `frameworks/kf5/foo` or something like that. In that case
> > unless you use the flat repository layout, kdesrc-build would try to
> > clone a new `frameworks/kf5/foo` repo, leaving your old
> > `frameworks/kf5foo` to consume some wasted disk space.
> >
>
> This is obviously a poor example, but the same problem occurs if
> something moves from playground to extragear. Basically if the
> `projectpath` YAML key changes.

I had been considering adding the Gitlab Project ID number to the YAML
metadata files as a way of allowing us to track projects through their
whole lifetime.

>
> Regards,
>
> - Johan

Cheers,
Ben


Re: Update on Status of Gitlab Migration

2020-04-11 Thread Johan Ouwerkerk
On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk  wrote:
>
> Yes the only reason why a cleanup script might be needed is if the
> logical path used to express the repo in dependency information
> changes at the same time. E.g. suppose a `frameworks/kf5foo` gets
> remapped to `frameworks/kf5/foo` or something like that. In that case
> unless you use the flat repository layout, kdesrc-build would try to
> clone a new `frameworks/kf5/foo` repo, leaving your old
> `frameworks/kf5foo` to consume some wasted disk space.
>

This is obviously a poor example, but the same problem occurs if
something moves from playground to extragear. Basically if the
`projectpath` YAML key changes.

Regards,

- Johan


Re: Update on Status of Gitlab Migration

2020-04-11 Thread Johan Ouwerkerk
On Sat, Apr 11, 2020 at 11:03 PM Michael Pyne  wrote:
>
> On Sat, Apr 11, 2020 at 09:25:11PM +0200, Johan Ouwerkerk wrote:
>
> >
> > A cleanup script could be handy. I think kdesrc-build will
> > automatically pick up new repo paths from metadata and that should
> > work transparently, but the old clones may get left behind as well.
> > People who use the kdesrc-build option to ignore KDE repo structure
> > shouldn't be affected at all.
>
> (...)
>
> All of the kde: repositories use the kde:foo syntax, where the 'foo'
> comes from the 'repopath' parameter of the sysadmin/repo-metadata YAML
> files.
>

Yes the only reason why a cleanup script might be needed is if the
logical path used to express the repo in dependency information
changes at the same time. E.g. suppose a `frameworks/kf5foo` gets
remapped to `frameworks/kf5/foo` or something like that. In that case
unless you use the flat repository layout, kdesrc-build would try to
clone a new `frameworks/kf5/foo` repo, leaving your old
`frameworks/kf5foo` to consume some wasted disk space.

>
> We may need to do on-the-fly conversion of the kde: repo paths if they
> won't be expressible as 'kde:foo' in the future, but we should have the
> information needed to do this in kdesrc-build to make this happen
> on-the-fly.
>

Yes, this should be fairly straight forward: we could do a `git remote
set-url` based on what the repo metadata tells us before updating a
local clone. In fact: we could build this right now and sell it as
"automagically recover your upstream".  :)

I might try to hack something up tomorrow or monday for that.

Regards,

- Johan


D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

2020-04-11 Thread David Faure
dfaure updated this revision to Diff 79892.
dfaure edited the summary of this revision.
dfaure removed a subscriber: pino.
dfaure added a comment.


  Use QMap, thanks Pino for the idea.

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28760?vs=79877=79892

BRANCH
  fix_duplicates

REVISION DETAIL
  https://phabricator.kde.org/D28760

AFFECTED FILES
  src/ksettings/dialog.cpp

To: dfaure, apol, broulik, davidedmundson, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns, pino


D28372: Remove rounded borders to plasmoidHeading

2020-04-11 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0f9abc2d403d: Remove rounded borders to plasmoidHeading 
(authored by niccolove).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28372?vs=79740=79888

REVISION DETAIL
  https://phabricator.kde.org/D28372

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #plasma, ngraham
Cc: manueljlin, ahiemstra, ndavis, ngraham, mart, davidedmundson, 
kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D28734: Port to Aether Bootstrap 4

2020-04-11 Thread Carson Black
cblack closed this revision.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28734

To: cblack, #vdg, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna


Re: Notice of upcoming changes to the behaviour of the anongit network

2020-04-11 Thread Michael Pyne
On Sat, Apr 11, 2020 at 10:14:38PM +1200, Ben Cooksley wrote:
> Hi all,
> 
> As part of the preparations for the move to Gitlab, and the rewrite of
> our anongit tooling, one of the things we have looked into is how the
> anongit network in general operates.
> 
> As part of this, it has been observed that the git:// protocol is
> unencrypted, and thus vulnerable to intercept and manipulation by
> hostile actors.
> 
> We have therefore decided that support for the git:// protocol to
> access KDE Git repositories will cease following our migration to
> Gitlab.
> 
> Going forward, all anonymous access should take place instead over
> https, which is encrypted, and has the added benefit of offering
> support for redirects (should those be needed)

For kdesrc-build users, as Johan Ouwerkerk noted on the other Gitlab
thread, kdesrc-build since January 2020 has already switched over to
using https for KDE-based source repositories in anticipation of this
change. Thanks to Ben and the sysadmin team for coordinating ahead of
time on this, it's allowed us to have it deployed for 3 months now and
we haven't heard of any breakage as a result of this change.

One important note is that if you have any git repositories that you
have manually checked out using KDE's anongit, you may need to either
manually adjust it to use a https:// git remote (if it uses git:// now),
or adjust it to use a kde: remote (as explained at
https://community.kde.org/Sysadmin/GitKdeOrgManual#Let_Git_rewrite_URL_prefixes).
kdesrc-build configures git to understand this "kde:" prefix by default.

Regards,
 - Michael Pyne


D27632: Implement UString operator= to make gcc happy

2020-04-11 Thread Harri Porten
porten accepted this revision.
porten added a comment.
This revision is now accepted and ready to land.


  I now see that the member is kept as a RefPtr. Unlike the previously used raw 
pointer I now understand why the the assignment operator can be implemented 
that simple.
  
  For completness: the gcc switch that triggers the warning is -Wdeprecated-copy

REPOSITORY
  R314 KJs

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27632

To: aacid, porten
Cc: porten, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


Re: Update on Status of Gitlab Migration

2020-04-11 Thread Michael Pyne
On Sat, Apr 11, 2020 at 09:25:11PM +0200, Johan Ouwerkerk wrote:
> On Sat, Apr 11, 2020 at 8:39 PM Ben Cooksley  wrote:
> >
> > Yes, the hostname git.kde.org will be fully retired as part of this 
> > transition.
> >
> > From my understanding kdesrc-build will automatically pick this up
> > once we update sysadmin/repo-metadata to show the new repository
> > paths.
> > This is something we'll confirm with mpyne though to ensure we can
> > make the cutover as smooth as possible.
> >
> 
> Just to be clear, my understanding based on reading the
> `Updated/Git.pm` module is that KDE repo paths are abstracted via
> ~/.gitconfig URL remapping using `insteadOf`and `pushInsteadOf`.
> Currently the code manipulates the user's ~/.gitconfig to bind the
> correct mappings to the `kde:` prefix (this happens even before
> cloning sysadmin repos for metadata).
> 
> So if my understanding of the code is correct, the entire switch over
> is transparent provided that kdesrc-build is updated beforehand to set
> the updated value for `pushInsteadOf`. We already have the same
> mechanism in place in kdesrc-build for ensuring that people use
> https://anongit.kde.org instead of git://anongit.kde.org when
> cloning/fetching.

Yeah, when Ben asked me a couple of months back about it, this was the
same conclusion I reached after reviewing the existing code.

But I need to note that the way this works right now is that a module is
cloned via a URL such as 'kde:juk' (not kde:kde/kdemultimedia/juk!).
This is transparent to how git operates when setup with ~/.gitconfig, so
you won't notice it in `git remote -v`, you need to actually look at the
repository's .git/config, or run `git config --local --get
remote.origin.url` in the source directory, to see whether it uses a
kde: URL or a full URL.

Either way, once the switchover happens, then *in theory* it can be as
easy as running kdesrc-build once (to update ~/.gitconfig) and from
there Git will rewrite to the updated URL automatically.

We could add the switchover logic before that and guard it with a date
check, that way we can do some testing early.

> > Depending on how things look we may also make available a script that
> > will update the configuration of a repository to reflect both the
> > change in hostname as well as the change in path.
> >
> 
> A cleanup script could be handy. I think kdesrc-build will
> automatically pick up new repo paths from metadata and that should
> work transparently, but the old clones may get left behind as well.
> People who use the kdesrc-build option to ignore KDE repo structure
> shouldn't be affected at all.

I don't know that we'll even necessarily need a cleanup script (though
it couldn't hurt).

In my case, my entire source repository contains only one repository
directly referencing anongit (or git.kde.org), all others are non-KDE or
kde:

  1 git://anongit.kde.org/scratch/
  1 git://cmake.org/
 16 git://code.qt.io/
  1 git://git.freedesktop.org/
  1 git://git.gnupg.org/
  3 git://github.com/
 23 https://code.qt.io/
  7 https://github.com/
  1 https://gitlab.com/
344 kde:

All of the kde: repositories use the kde:foo syntax, where the 'foo'
comes from the 'repopath' parameter of the sysadmin/repo-metadata YAML
files.

We may need to do on-the-fly conversion of the kde: repo paths if they
won't be expressible as 'kde:foo' in the future, but we should have the
information needed to do this in kdesrc-build to make this happen
on-the-fly.

Regards,
 - Michael Pyne


Re: Update on Status of Gitlab Migration

2020-04-11 Thread Nicolás Alvarez
El sáb., 11 de abr. de 2020 a la(s) 16:26, Johan Ouwerkerk
(jm.ouwerk...@gmail.com) escribió:
>
> On Sat, Apr 11, 2020 at 8:39 PM Ben Cooksley  wrote:
> >
> > Yes, the hostname git.kde.org will be fully retired as part of this 
> > transition.
> >
> > From my understanding kdesrc-build will automatically pick this up
> > once we update sysadmin/repo-metadata to show the new repository
> > paths.
> > This is something we'll confirm with mpyne though to ensure we can
> > make the cutover as smooth as possible.
> >
>
> Just to be clear, my understanding based on reading the
> `Updated/Git.pm` module is that KDE repo paths are abstracted via
> ~/.gitconfig URL remapping using `insteadOf`and `pushInsteadOf`.
> Currently the code manipulates the user's ~/.gitconfig to bind the
> correct mappings to the `kde:` prefix (this happens even before
> cloning sysadmin repos for metadata).
>
> So if my understanding of the code is correct, the entire switch over
> is transparent provided that kdesrc-build is updated beforehand to set
> the updated value for `pushInsteadOf`. We already have the same
> mechanism in place in kdesrc-build for ensuring that people use
> https://anongit.kde.org instead of git://anongit.kde.org when
> cloning/fetching.

Changing .gitconfig won't be enough, per-repo changes will still be
needed (although kdesrc-build could be updated to do those for you
too).

Currently if a project moves to gitlab, you need to change
g...@git.kde.org:kdenlive to g...@invent.kde.org:kde/kdenlive (note the
kde/ addition). If that was all, in principle you could use insteadOf
to map kde: to "g...@invent.kde.org:kde/". But depending on future
discussions about structure, it's possible that eg. kcoreaddons will
end up moving to frameworks/kcoreaddons rather than kde/kcoreaddons.

-- 
Nicolás


Re: Update on Status of Gitlab Migration

2020-04-11 Thread Johan Ouwerkerk
On Sat, Apr 11, 2020 at 9:01 PM Nicolás Alvarez
 wrote:
>
> How would it work during the "grace period"? Keeping an outdated read-only 
> mirror on the old URL? I have done some research into redirecting or 
> remapping from the old URL to the new one so we can keep it working for a 
> longer period of time, and it's harder than it seems... It can be done but I 
> need to be convinced that it's actually necessary / worth the effort.
>

My idea was that when the button is pushed people could update their
kdesrc-build once, run it once and continue to work as if nothing
happened. If a grace period is not feasible from a sysadmin
perspective, then things could still work if at the same time that
git.kde.org is decommissioned a pre-prepared MR/commit is merged into
kdesrc-build that fixes it. At the very least the code that sets the
pushInsteadOf mapping in the user's ~/.gitconfig would become outdated
and needs to be fixed at that point.

Regards,

- Johan


Re: Update on Status of Gitlab Migration

2020-04-11 Thread Johan Ouwerkerk
On Sat, Apr 11, 2020 at 8:39 PM Ben Cooksley  wrote:
>
> Yes, the hostname git.kde.org will be fully retired as part of this 
> transition.
>
> From my understanding kdesrc-build will automatically pick this up
> once we update sysadmin/repo-metadata to show the new repository
> paths.
> This is something we'll confirm with mpyne though to ensure we can
> make the cutover as smooth as possible.
>

Just to be clear, my understanding based on reading the
`Updated/Git.pm` module is that KDE repo paths are abstracted via
~/.gitconfig URL remapping using `insteadOf`and `pushInsteadOf`.
Currently the code manipulates the user's ~/.gitconfig to bind the
correct mappings to the `kde:` prefix (this happens even before
cloning sysadmin repos for metadata).

So if my understanding of the code is correct, the entire switch over
is transparent provided that kdesrc-build is updated beforehand to set
the updated value for `pushInsteadOf`. We already have the same
mechanism in place in kdesrc-build for ensuring that people use
https://anongit.kde.org instead of git://anongit.kde.org when
cloning/fetching.

>
> Depending on how things look we may also make available a script that
> will update the configuration of a repository to reflect both the
> change in hostname as well as the change in path.
>

A cleanup script could be handy. I think kdesrc-build will
automatically pick up new repo paths from metadata and that should
work transparently, but the old clones may get left behind as well.
People who use the kdesrc-build option to ignore KDE repo structure
shouldn't be affected at all.

Regards,

- Johan


Re: Update on Status of Gitlab Migration

2020-04-11 Thread Nicolás Alvarez
El 11 abr. 2020, a la(s) 08:31, Johan Ouwerkerk  
escribió:
> 
> On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley  wrote:
>> Should anyone have any questions on the above, please let us know.
> 
> Does the migration also mean that `git.kde.org` push URL will be
> retired and would need to be remapped to `invent.kde.org`?
> 
> In that case, it would be good to have a grace period after the
> initial migration to Gitlab so kdesrc-build (etc.) could be updated
> before the cut off date to perform this migration automatically for
> the user. I expect such a grace period would not need to last very
> long because the feature would be trivial to implement.

How would it work during the "grace period"? Keeping an outdated read-only 
mirror on the old URL? I have done some research into redirecting or remapping 
from the old URL to the new one so we can keep it working for a longer period 
of time, and it's harder than it seems... It can be done but I need to be 
convinced that it's actually necessary / worth the effort.

-- 
Nicolás
KDE Sysadmin Team

Re: Update on Status of Gitlab Migration

2020-04-11 Thread Ben Cooksley
On Sat, Apr 11, 2020 at 11:31 PM Johan Ouwerkerk  wrote:
>
> On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley  wrote:
> >
> > Should anyone have any questions on the above, please let us know.
> >
>
> Does the migration also mean that `git.kde.org` push URL will be
> retired and would need to be remapped to `invent.kde.org`?

Yes, the hostname git.kde.org will be fully retired as part of this transition.

>From my understanding kdesrc-build will automatically pick this up
once we update sysadmin/repo-metadata to show the new repository
paths.
This is something we'll confirm with mpyne though to ensure we can
make the cutover as smooth as possible.

Depending on how things look we may also make available a script that
will update the configuration of a repository to reflect both the
change in hostname as well as the change in path.

>
> In that case, it would be good to have a grace period after the
> initial migration to Gitlab so kdesrc-build (etc.) could be updated
> before the cut off date to perform this migration automatically for
> the user. I expect such a grace period would not need to last very
> long because the feature would be trivial to implement.
>
> Regards,
>
> - Johan

Cheers,
Ben


D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

2020-04-11 Thread Pino Toscano
pino added a comment.


  Why not instead use a `QMap` to collect the files? This way you wouldn't need the double 
QStandardPaths lookup.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28760

To: dfaure, apol, broulik, davidedmundson, kossebau
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

2020-04-11 Thread David Faure
dfaure created this revision.
dfaure added reviewers: apol, broulik, davidedmundson, kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  I had every toplevel entry doubled in kontact's configuration dialog
  due to $XDG_DATA_DIRS=/share:/usr/share
  which led to parsing both
  /share/kontact/ksettingsdialog/knotes.setdlg
  and
  /usr/share/kontact/ksettingsdialog/knotes.setdlg
  
  Solution: do this in two steps (collect names, then look up each name to
  only the most local variant of it). This was more natural with
  KStandardDirs API, I admit.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28760

AFFECTED FILES
  src/ksettings/dialog.cpp

To: dfaure, apol, broulik, davidedmundson, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D24773: kio_trash: Add size, modification, access and create date for trash:/

2020-04-11 Thread Méven Car
meven planned changes to this revision.
meven added a comment.


  The modification date is not what to expect currently, working on it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28739: activities: Close the database connection to prevent file descriptor leak

2020-04-11 Thread Méven Car
meven added a comment.


  Well done @akandaurov
  Keep the patch coming ;-)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28739

To: akandaurov, ivan, meven
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov


D28739: activities: Close the database connection to prevent file descriptor leak

2020-04-11 Thread Méven Car
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:8c3c27daa03b: activities: Close the database connection 
to prevent file descriptor leak (authored by akandaurov, committed by meven).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28739?vs=79827=79875#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28739?vs=79827=79875

REVISION DETAIL
  https://phabricator.kde.org/D28739

AFFECTED FILES
  activities/fileitemplugin/FileItemLinkingPluginActionLoader.cpp

To: akandaurov, ivan, meven
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov


D24773: kio_trash: Add size, modification, access and create date for trash:/

2020-04-11 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D24773_1

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28743: Port kruntest to ApplicationLauncherJob

2020-04-11 Thread David Faure
dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28743

To: dfaure, broulik, davidedmundson, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28675: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM

2020-04-11 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:75298895a5e3: [KMimeTypeChooser] Add the ability to 
filter the treeview with a QSFPM (authored by ahmadsamir).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28675?vs=79866=79872

REVISION DETAIL
  https://phabricator.kde.org/D28675

AFFECTED FILES
  docs/pics/kmimetypechooserdialog.png
  src/kmimetypechooser.cpp
  src/kmimetypechooser.h
  tests/kmimetypechoosertest.cpp

To: ahmadsamir, #frameworks, cfeck, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28758: [KFontChooser] Make the code slightly more readable

2020-04-11 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:9e97265723f2: [KFontChooser] Make the code slightly more 
readable (authored by ahmadsamir).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28758?vs=79863=79871

REVISION DETAIL
  https://phabricator.kde.org/D28758

AFFECTED FILES
  src/kfontchooser.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28758: [KFontChooser] Make the code slightly more readable

2020-04-11 Thread David Faure
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks ;)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser-5 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28758

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28675: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM

2020-04-11 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kmimechooser (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28675

To: ahmadsamir, #frameworks, cfeck, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28739: activities: Close the database connection to prevent file descriptor leak

2020-04-11 Thread Alexander Kandaurov
akandaurov added a comment.


  Yes, I don't have an account, so I'll need someone to land it, thanks.

REVISION DETAIL
  https://phabricator.kde.org/D28739

To: akandaurov, ivan, meven
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov


D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  (nullptr used as arguments always make me consider finally working on a patch 
to add to normal kdevelop the feature "Show argument names at call site" like 
demoed here among other things:  
https://kate-editor.org/wp-content/uploads/2018/08/inline-note-anim.gif so far 
hoped someone else would do it, but seems it is time to help myself possibly)

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28742

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread David Faure
dfaure closed this revision.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28742

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin added a comment.


  Agreed, nullptr is going to be the boolean flag of our time, before it was 0 
though, so still an improvement. ;-)
  
  More seriously, here I'm not sure how to avoid it, at least it's a case of 
"if you feel like passing nullptr here you might be doing something wrong".

REPOSITORY
  R288 KJobWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28755: Breeze Icons cannot be built from read-only source location

2020-04-11 Thread Jonathan Marten
marten updated this revision to Diff 79867.
marten added a comment.


  Yes, that would mean fewer changes to the validate_svg.sh script.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28755?vs=79845=79867

REVISION DETAIL
  https://phabricator.kde.org/D28755

AFFECTED FILES
  CMakeLists.txt
  validate_svg.sh

To: marten, #breeze
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28675: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM

2020-04-11 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 79866.
ahmadsamir added a comment.


  - Bring the comment column back, more filter-ability
  - Use QFontMetrics fm(fontMetrics()), more efficient as it gets copied

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28675?vs=79630=79866

BRANCH
  l-kmimechooser (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28675

AFFECTED FILES
  docs/pics/kmimetypechooserdialog.png
  src/kmimetypechooser.cpp
  src/kmimetypechooser.h
  tests/kmimetypechoosertest.cpp

To: ahmadsamir, #frameworks, cfeck, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28739: activities: Close the database connection to prevent file descriptor leak

2020-04-11 Thread Méven Car
meven added a comment.


  Do you want me to land the commit ?
  I believe you don't have a KDE Developer account.

REVISION DETAIL
  https://phabricator.kde.org/D28739

To: akandaurov, ivan, meven
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov


KDE CI: Frameworks » ktextwidgets » kf5-qt5 WindowsMSVCQt5.14 - Build # 19 - Fixed!

2020-04-11 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20WindowsMSVCQt5.14/19/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 11 Apr 2020 14:57:22 +
 Build duration:
5 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  Not into details, so if there is no sane default, forcing developers to pass 
something sane here  make sense
  Second thought I also had was avoiding code which uses `nullptr` as 
arguments, which harms humans reading code a bit as in, "nullptr of what?!!" 
(compare boolean flags) ;)

REPOSITORY
  R288 KJobWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


KDE CI: Frameworks » ktextwidgets » kf5-qt5 SUSEQt5.14 - Build # 6 - Fixed!

2020-04-11 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.14/6/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 11 Apr 2020 14:57:22 +
 Build duration:
1 min 59 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextWidgets-5.70.0.xmlcompat_reports/KF5TextWidgets_compat_report.htmllogs/KF5TextWidgets/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)82%
(18/22)82%
(18/22)50%
(1531/3058)39%
(575/1479)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)97%
(621/638)58%
(136/233)src.dialogs0%
(0/1)0%
(0/1)0%
(0/40)0%
(0/4)src.findreplace100%
(7/7)100%
(7/7)63%
(601/947)51%
(268/522)src.widgets67%
(4/6)67%
(4/6)22%
(309/1422)24%
(171/718)tests0%
(0/1)0%
(0/1)0%
(0/11)0%
(0/2)

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin accepted this revision.

REPOSITORY
  R288 KJobWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


KDE CI: Frameworks » ktextwidgets » kf5-qt5 SUSEQt5.12 - Build # 79 - Fixed!

2020-04-11 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.12/79/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 11 Apr 2020 14:57:22 +
 Build duration:
1 min 58 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextWidgets-5.70.0.xmlcompat_reports/KF5TextWidgets_compat_report.htmllogs/KF5TextWidgets/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)82%
(18/22)82%
(18/22)50%
(1532/3059)39%
(575/1479)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)97%
(622/639)58%
(136/233)src.dialogs0%
(0/1)0%
(0/1)0%
(0/40)0%
(0/4)src.findreplace100%
(7/7)100%
(7/7)63%
(601/947)51%
(268/522)src.widgets67%
(4/6)67%
(4/6)22%
(309/1422)24%
(171/718)tests0%
(0/1)0%
(0/1)0%
(0/11)0%
(0/2)

KDE CI: Frameworks » ktextwidgets » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Fixed!

2020-04-11 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20FreeBSDQt5.14/7/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 11 Apr 2020 14:57:22 +
 Build duration:
1 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin added a comment.


  In D28742#646050 , @dfaure wrote:
  
  > In D28742#646009 , @kossebau 
wrote:
  >
  > > And perhaps could be defaulted to nullptr, for use-cases which do not 
have a window at hand and are fine with any default?
  >
  >
  > I've been wondering. But people tend to forget to do so, and in most cases, 
if we choose the dialog delegate, then there's a QWidget based window somewhere.
  >  Plasma uses KNotificationJobUiDelegate so it's not a problem here.
  >  My thinking is that I'd rather force people to think about it, and 
possibly pass a nullptr in case there's really no window around.
  
  
  +1, I don't think defaulting to nullptr is a good idea.

REPOSITORY
  R288 KJobWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28756: [findreplace] Handle searching for WholeWordsOnly in Regex mode

2020-04-11 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R310:fcaeccbcd633: [findreplace] Handle searching for 
WholeWordsOnly in Regex mode (authored by ahmadsamir).

REPOSITORY
  R310 KTextWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28756?vs=79858=79864

REVISION DETAIL
  https://phabricator.kde.org/D28756

AFFECTED FILES
  src/findreplace/kfind.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28758: [KFontChooser] Make the code slightly more readable

2020-04-11 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser-5 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28758

AFFECTED FILES
  src/kfontchooser.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

2020-04-11 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
ahmadsamir marked an inline comment as done.
Closed by commit R236:e9c92b7e3620: [KFontChooser] Add a checkbox to toggle 
showing only monospaced fonts (authored by ahmadsamir).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28274?vs=79861=79862

REVISION DETAIL
  https://phabricator.kde.org/D28274

AFFECTED FILES
  src/kfontchooser.cpp
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

2020-04-11 Thread Ahmad Samir
ahmadsamir marked an inline comment as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kfontchooser.cpp:393
> would `true` be more readable?
> 
> (same for the previous line, actually)

Indeed; however onlyFixedCheckbox->setChecked(usingFixed) doesn't need to be in 
that if block at all.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-monospace-checkbox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28274

To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28756: [findreplace] Handle searching for WholeWordsOnly in Regex mode

2020-04-11 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R310 KTextWidgets

BRANCH
  l-wholewords (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28756

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread David Faure
dfaure added a comment.


  In D28742#646009 , @kossebau wrote:
  
  > `window` parameter wants API dox mentioning, though.
  
  
  Oops, I thought I did that. Fixed.
  
  > And perhaps could be defaulted to nullptr, for use-cases which do not have 
a window at hand and are fine with any default?
  
  I've been wondering. But people tend to forget to do so, and in most cases, 
if we choose the dialog delegate, then there's a QWidget based window somewhere.
  Plasma uses KNotificationJobUiDelegate so it's not a problem here.
  My thinking is that I'd rather force people to think about it, and possibly 
pass a nullptr in case there's really no window around.

REPOSITORY
  R288 KJobWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

2020-04-11 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 79861.
ahmadsamir added a comment.


  A better location for onlyFixedCheckbox->setChecked() is next to its siblings

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28274?vs=79823=79861

BRANCH
  l-monospace-checkbox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28274

AFFECTED FILES
  src/kfontchooser.cpp
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28726: [KJS] Port QRegExp to QRegularExpression

2020-04-11 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R314:da9d1e44ebf2: [KJS] Port QRegExp to QRegularExpression 
(authored by ahmadsamir).

REPOSITORY
  R314 KJs

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28726?vs=79776=79860

REVISION DETAIL
  https://phabricator.kde.org/D28726

AFFECTED FILES
  autotests/ecmatest.cpp
  autotests/kjsapitest.cpp

To: ahmadsamir, #frameworks, porten, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28756: [findreplace] Handle searching for WholeWordsOnly in Regex mode

2020-04-11 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  The unit test passes again.

TEST PLAN
  make && ctest

REPOSITORY
  R310 KTextWidgets

BRANCH
  l-wholewords (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28756

AFFECTED FILES
  src/findreplace/kfind.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread David Faure
dfaure updated this revision to Diff 79857.
dfaure added a comment.


  Expand docs about the associated window

REPOSITORY
  R288 KJobWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28742?vs=79848=79857

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

AFFECTED FILES
  src/kdialogjobuidelegate.cpp
  src/kdialogjobuidelegate.h

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  `window` parameter wants API dox mentioning, though. And perhaps could be 
defaulted to nullptr, for use-cases which do not have a window at hand and are 
fine with any default?

REPOSITORY
  R288 KJobWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin accepted this revision.
ervin added a comment.


  Indeed, good point.

REPOSITORY
  R288 KJobWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28753: Add KNotificationJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread David Faure
dfaure closed this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28753

To: dfaure, broulik, davidedmundson, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28753: Add KNotificationJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kai Uwe Broulik
broulik accepted this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28753

To: dfaure, broulik, davidedmundson, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28726: [KJS] Port QRegExp to QRegularExpression

2020-04-11 Thread Harri Porten
porten accepted this revision.

REPOSITORY
  R314 KJs

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28726

To: ahmadsamir, #frameworks, porten, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread David Faure
dfaure updated this revision to Diff 79848.
dfaure added a comment.


  Add QWidget *window parameter. Even better, no?
  
  Needed for dialog boxes to respect stacking order, centering to parent, focus 
going back to parent after closing...

REPOSITORY
  R288 KJobWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28742?vs=79840=79848

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

AFFECTED FILES
  src/kdialogjobuidelegate.cpp
  src/kdialogjobuidelegate.h

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28753: Add KNotificationJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28753

To: dfaure, broulik, davidedmundson, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28755: Breeze Icons cannot be built from read-only source location

2020-04-11 Thread Pino Toscano
pino added a comment.


  Or maybe the other way round:
  
  - add an optional parameter to the script to specify the source directory, 
defaulting to "."
  - run the script in the build directory, passing the source directory as 
parameter

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28755

To: marten, #breeze
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin accepted this revision.

REPOSITORY
  R288 KJobWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28755: Breeze Icons cannot be built from read-only source location

2020-04-11 Thread Jonathan Marten
marten created this revision.
marten added a reviewer: Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
marten requested review of this revision.

REVISION SUMMARY
  In the situation, for example, where a master source tree may be shared among 
a number of build systems via NFS (each build system needs its own writeable 
build directory, of course).  However, building the Breeze icons needs write 
access to the source tree for the SVG validation check, which is run in 
CMAKE_CURRENT_SOURCE_DIR:
  
  [100%] Validating SVG
  breezeicons/validate_svg.sh: line 3: xmlerrors: Read-only file system
  rm: cannot remove 'xmlerrors': No such file or directory
  make[2]: *** [CMakeFiles/breeze-validate-svg.dir/build.make:58: 
CMakeFiles/breeze-validate-svg] Error 1
  make[1]: *** [CMakeFiles/Makefile2:231: 
CMakeFiles/breeze-validate-svg.dir/all] Error 2
  make: *** [Makefile:130: all] Error 2
  
  This change writes the temporary XML error file to CMAKE_CURRENT_BINARY_DIR, 
which can be relied on to be writeable.

TEST PLAN
  Build Breeze Icons with this change, observed that the SVG validation check 
completes with no 'read-only file system' errors.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28755

AFFECTED FILES
  CMakeLists.txt
  validate_svg.sh

To: marten, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

2020-04-11 Thread David Faure
dfaure accepted this revision.
dfaure added inline comments.

INLINE COMMENTS

> kfontchooser.cpp:393
>  q->setFont(QFontDatabase::systemFont(QFontDatabase::FixedFont), 
> usingFixed);
> +onlyFixedCheckbox->setChecked(usingFixed);
>  } else {

would `true` be more readable?

(same for the previous line, actually)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-monospace-checkbox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28274

To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 10 - Unstable!

2020-04-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/10/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 11 Apr 2020 13:51:54 +
 Build duration:
2 min 51 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.70.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6934/9126)43%
(10805/24857)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2902/2996)49%
(6200/12734)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/800)42%
(956/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 182 - Fixed!

2020-04-11 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/182/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 11 Apr 2020 13:51:49 +
 Build duration:
3 min 9 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.70.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6933/9127)43%
(10804/24863)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2901/2996)49%
(6198/12736)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/801)42%
(957/2273)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D28753: Add KNotificationJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread David Faure
dfaure created this revision.
dfaure added reviewers: broulik, davidedmundson, ervin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

TEST PLAN
  Builds

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28753

AFFECTED FILES
  src/knotificationjobuidelegate.cpp
  src/knotificationjobuidelegate.h

To: dfaure, broulik, davidedmundson, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 9 - Fixed!

2020-04-11 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/9/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 11 Apr 2020 13:48:37 +
 Build duration:
3 min 16 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.70.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6933/9126)43%
(10802/24857)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2901/2996)49%
(6197/12734)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/800)42%
(956/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

2020-04-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/9/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 11 Apr 2020 13:50:17 +
 Build duration:
1 min 29 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 181 - Unstable!

2020-04-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/181/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 11 Apr 2020 13:48:37 +
 Build duration:
3 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.70.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittestFailed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6934/9127)43%
(10802/24863)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2902/2996)49%
(6196/12736)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/801)42%
(957/2273)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread David Faure
dfaure updated this revision to Diff 79840.
dfaure marked an inline comment as done.
dfaure added a comment.


  explicit

REPOSITORY
  R288 KJobWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28742?vs=79820=79840

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

AFFECTED FILES
  src/kdialogjobuidelegate.cpp
  src/kdialogjobuidelegate.h

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

2020-04-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/8/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 11 Apr 2020 13:48:37 +
 Build duration:
1 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread David Faure
dfaure marked an inline comment as done.
dfaure added inline comments.

INLINE COMMENTS

> kossebau wrote in kdialogjobuidelegate.h:51
> Why no explicit?

good point

REPOSITORY
  R288 KJobWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Friedrich W. H. Kossebau
kossebau added inline comments.

INLINE COMMENTS

> kdialogjobuidelegate.h:51
> + */
> +KDialogJobUiDelegate(KJobUiDelegate::Flags flags); // KF6 TODO merge 
> with default constructor, using AutoHandlingDisabled as default value
> +

Why no explicit?

REPOSITORY
  R288 KJobWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

To: dfaure, broulik, davidedmundson, ervin
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

2020-04-11 Thread David Faure
dfaure closed this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D28741

To: dfaure, broulik, davidedmundson, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28743: Port kruntest to ApplicationLauncherJob

2020-04-11 Thread Kevin Ottens
ervin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28743

To: dfaure, broulik, davidedmundson, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R288 KJobWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28742

To: dfaure, broulik, davidedmundson, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

2020-04-11 Thread Kevin Ottens
ervin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28741

To: dfaure, broulik, davidedmundson, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28739: activities: Close the database connection to prevent file descriptor leak

2020-04-11 Thread Alexander Kandaurov
akandaurov retitled this revision from "Close the database connection to 
prevent file descriptor leak" to "activities: Close the database connection to 
prevent file descriptor leak".

REVISION DETAIL
  https://phabricator.kde.org/D28739

To: akandaurov, ivan, meven
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, rdieter, mikesomov


D28739: Close the database connection to prevent file descriptor leak

2020-04-11 Thread Méven Car
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Too bad we have so many lines to change.
  
  Could you maybe add some context to your commit comment like `activities: 
Close the database connection to prevent file descriptor leak`
  
  LGTM

REVISION DETAIL
  https://phabricator.kde.org/D28739

To: akandaurov, ivan, meven
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, rdieter, mikesomov


D28726: [KJS] Port QRegExp to QRegularExpression

2020-04-11 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R314 KJs

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28726

To: ahmadsamir, #frameworks, porten, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28737: Add sim card device icons

2020-04-11 Thread Noah Davis
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:95ebf0c1d3ea: Add sim card device icons (authored by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28737?vs=79800=79839

REVISION DETAIL
  https://phabricator.kde.org/D28737

AFFECTED FILES
  icons-dark/devices/16/auth-sim.svg
  icons-dark/devices/22/auth-sim.svg
  icons-dark/devices/64/auth-sim.svg
  icons-dark/devices/symbolic/auth-sim-symbolic.svg
  icons/devices/16/auth-sim.svg
  icons/devices/22/auth-sim.svg
  icons/devices/64/auth-sim.svg
  icons/devices/symbolic/auth-sim-symbolic.svg

To: ndavis, #vdg, cblack
Cc: kde-frameworks-devel, salvahg, Orage, LeGast00n, cblack, hannahk, 
frmdstryr, fbampaloukas, GB_2, emrek, mkraemer, cahfofpai, asghaier, michaelh, 
tbalzer, dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, 
alexeymin, jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas


D28739: Close the database connection to prevent file descriptor leak

2020-04-11 Thread Alexander Kandaurov
akandaurov marked an inline comment as done.

REVISION DETAIL
  https://phabricator.kde.org/D28739

To: akandaurov, ivan, meven
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, rdieter, mikesomov


D28745: Skipping catching of thumbnails on encrytped filesystems

2020-04-11 Thread Marcin Gurtowski
marcingu added a dependency: D28746: Show previews on encrypted filesystems.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu
Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, 
fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov


D28746: Show previews on encrypted filesystems

2020-04-11 Thread Marcin Gurtowski
marcingu added a dependent revision: D28745: Skipping catching of thumbnails on 
encrytped filesystems.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28746

To: marcingu
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28746: Show previews on encrypted filesystems

2020-04-11 Thread Marcin Gurtowski
marcingu created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
marcingu requested review of this revision.

REVISION SUMMARY
  Instead of skipping generating previews on encrypted filesystems, do create 
them but don't cache.
  BUG: 411919

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28746

AFFECTED FILES
  src/widgets/previewjob.cpp

To: marcingu
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28745: Skipping catching of thumbnails on encrytped filesystems

2020-04-11 Thread Marcin Gurtowski
marcingu created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
marcingu requested review of this revision.

REVISION SUMMARY
  When generating thumbnails for directory, don't cache the previews for files 
stored on encrypted filesystems.
  BUG: 411919
  This change is only part of solution and will be added as dependency for the 
rest of the fix.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

AFFECTED FILES
  thumbnail/thumbnail.cpp

To: marcingu
Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, 
fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov


D28739: Close the database connection to prevent file descriptor leak

2020-04-11 Thread Alexander Kandaurov
akandaurov updated this revision to Diff 79827.
akandaurov added a comment.


  Added indentation. The block is suggested by the Qt Documentation 
. Without it, a 
warning will be thrown:
  
QSqlDatabasePrivate::removeDatabase: connection 
'kactivities_db_resources_94156823977952' is still in use, all queries will 
cease to work.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28739?vs=79808=79827

REVISION DETAIL
  https://phabricator.kde.org/D28739

AFFECTED FILES
  activities/fileitemplugin/FileItemLinkingPluginActionLoader.cpp

To: akandaurov, ivan, meven
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, rdieter, mikesomov


D28406: Fix sonnet autodetect test failure

2020-04-11 Thread Waqar Ahmed
waqar added a comment.


  In D28406#644383 , @dfaure wrote:
  
  > @waqar ping? What do you think about my suggestion? If you agree, can you 
update the patch?
  
  
  Sorry I have been really busy at work, and overlooked the last email. I did 
plan to work on this today though  
  and you already committed the changes.
  
  It looks great. I have a couple of ideas to improve this though, So i will 
create another patch.
  
  There are other sonnet bugs that I want to work on in the meantime. And if 
you have something particular in mind, you can point me there.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D28406

To: dfaure, waqar
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28406: Fix sonnet autodetect test failure

2020-04-11 Thread David Faure
dfaure added a comment.


  I pushed it with my changes included. The test is fixed: 
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/sonnet/job/kf5-qt5%20SUSEQt5.12/

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D28406

To: dfaure, waqar
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.12 - Build # 90 - Fixed!

2020-04-11 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.12/90/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 11 Apr 2020 11:53:06 +
 Build duration:
2 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Sonnet-5.70.0.xmlcompat_reports/KF5Sonnet_compat_report.htmllogs/KF5Sonnet/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(3/8)29%
(14/48)29%
(14/48)20%
(623/3186)12%
(175/1481)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)63%
(225/356)33%
(71/214)data50%
(1/2)50%
(1/2)30%
(21/71)22%
(7/32)examples0%
(0/6)0%
(0/6)0%
(0/116)0%
(0/2)src.core47%
(7/15)47%
(7/15)26%
(377/1439)15%
(97/649)src.plugins.aspell0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/20)src.plugins.hunspell0%
(0/3)0%
(0/3)0%
(0/110)0%
(0/64)src.plugins.voikko0%
(0/2)0%
(0/2)0%
(0/153)0%
(0/66)src.ui0%
(0/11)0%
(0/11)0%
(0/872)0%
(0/434)

KDE CI: Frameworks » sonnet » kf5-qt5 WindowsMSVCQt5.14 - Build # 21 - Fixed!

2020-04-11 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20WindowsMSVCQt5.14/21/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 11 Apr 2020 11:53:06 +
 Build duration:
1 min 57 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.14 - Build # 5 - Fixed!

2020-04-11 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.14/5/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 11 Apr 2020 11:53:06 +
 Build duration:
2 min 1 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Sonnet-5.70.0.xmlcompat_reports/KF5Sonnet_compat_report.htmllogs/KF5Sonnet/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(3/8)29%
(14/48)29%
(14/48)20%
(623/3186)12%
(175/1481)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)63%
(225/356)33%
(71/214)data50%
(1/2)50%
(1/2)30%
(21/71)22%
(7/32)examples0%
(0/6)0%
(0/6)0%
(0/116)0%
(0/2)src.core47%
(7/15)47%
(7/15)26%
(377/1439)15%
(97/649)src.plugins.aspell0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/20)src.plugins.hunspell0%
(0/3)0%
(0/3)0%
(0/110)0%
(0/64)src.plugins.voikko0%
(0/2)0%
(0/2)0%
(0/153)0%
(0/66)src.ui0%
(0/11)0%
(0/11)0%
(0/872)0%
(0/434)

KDE CI: Frameworks » sonnet » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Fixed!

2020-04-11 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20FreeBSDQt5.14/7/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 11 Apr 2020 11:53:06 +
 Build duration:
57 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

D28406: Fix sonnet autodetect test failure

2020-04-11 Thread David Faure
dfaure commandeered this revision.
dfaure edited reviewers, added: waqar; removed: dfaure.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D28406

To: dfaure, waqar
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28406: Fix sonnet autodetect test failure

2020-04-11 Thread David Faure
This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R246:78450298149e: Fix sonnet autodetect test failure 
(authored by waqar, committed by dfaure).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28406?vs=78793=79824#toc

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28406?vs=78793=79824

REVISION DETAIL
  https://phabricator.kde.org/D28406

AFFECTED FILES
  autotests/test_autodetect.cpp

To: dfaure, waqar
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

2020-04-11 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 79823.
ahmadsamir added a comment.


  Handle the case where KFontChooser::FixedFontsOnly is set, the 
fixedOnlyCheckBox should be shown as "checked" from the get go.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28274?vs=78979=79823

BRANCH
  l-monospace-checkbox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28274

AFFECTED FILES
  src/kfontchooser.cpp
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


  1   2   >