D19913: [plasma-framework] make it compiles without foreach

2020-04-14 Thread Laurent Montel
mlaurent retitled this revision from "[plasma-desktop] make it compiles without foreach" to "[plasma-framework] make it compiles without foreach". REPOSITORY R242 Plasma Framework (Library) BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19913: [plasma-desktop] make it compiles without foreach

2020-04-14 Thread Laurent Montel
mlaurent updated this revision to Diff 80170. mlaurent added a comment. Fix David comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19913?vs=80169=80170 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19913: [plasma-desktop] make it compiles without foreach

2020-04-14 Thread Laurent Montel
mlaurent updated this revision to Diff 80169. mlaurent added a comment. Port last element to for(...:...) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19913?vs=80168=80169 BRANCH compile_without_foreach (branched from master)

D19913: [plasma-desktop] make it compiles without foreach

2020-04-14 Thread Laurent Montel
mlaurent updated this revision to Diff 80168. mlaurent added a comment. Rebase against master REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19913?vs=55796=80168 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D25267: Improve XCF support

2020-04-14 Thread Albert Astals Cid
aacid added a comment. In D25267#647547 , @sandsmark wrote: > In D25267#647148 , @aacid wrote: > > > Seems like the windows build is broken :/ > > > >

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

2020-04-14 Thread Igor Poboiko
This revision was automatically updated to reflect the committed changes. Closed by commit R310:1d1eb6feb7f8: [KRichTextEdit] Always treat key press as single modification in undo stack (authored by poboiko). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 546 - Still Unstable!

2020-04-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/546/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 14 Apr 2020 21:57:59 + Build duration: 7 min 4 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 55 - Still Unstable!

2020-04-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/55/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 14 Apr 2020 21:57:59 + Build duration: 7 min 23 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 47 - Still Unstable!

2020-04-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/47/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 14 Apr 2020 21:57:59 + Build duration: 7 min 32 sec and counting BUILD ARTIFACTS

D24887: WIP slave command behavior assertion system

2020-04-14 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. After much delay some replies but there are yet more questions in here INLINE COMMENTS > commands_p.h:27 > { > +#pragma message "this is awkward since this causes

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 545 - Still Unstable!

2020-04-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/545/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 14 Apr 2020 21:26:59 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 46 - Still Unstable!

2020-04-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/46/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 14 Apr 2020 21:26:59 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 54 - Still Unstable!

2020-04-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/54/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 14 Apr 2020 21:27:01 + Build duration: 9 min 9 sec and counting JUnit Tests Name:

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-04-14 Thread David Faure
dfaure added a comment. For KF6 we could also just replace KCModuleInfo with KPluginInfo. It really doesn't provide anything on top REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28765 To: dfaure, pino, broulik, mart, davidedmundson Cc: cblack,

D28839: [PostingIterator] Make sure skipTo also works for first element

2020-04-14 Thread Stefan Brüns
bruns added a dependent revision: D28845: [OrpostingIterator] Allow skipping elements, implement skipTo. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28839 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,

D19913: [plasma-desktop] make it compiles without foreach

2020-04-14 Thread Nicolas Fella
nicolasfella added a comment. The title says plasma-desktop, but this is plasma-framework? REPOSITORY R242 Plasma Framework (Library) BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19913 To: mlaurent, dfaure Cc: nicolasfella,

D28845: [OrpostingIterator] Allow skipping elements, implement skipTo

2020-04-14 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case an OrPostingIterator is below and AndPostingIterator, which is the

D24025: Don't use KCrash on Android

2020-04-14 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. see Volker's comment REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: vkrause, apol, broulik, kde-frameworks-devel,

D28839: [PostingIterator] Make sure skipTo also works for first element

2020-04-14 Thread Stefan Brüns
bruns added a dependent revision: D28844: [PhraseAndIterator] Replace recursive next() implementation. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28839 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,

D28844: [PhraseAndIterator] Replace recursive next() implementation

2020-04-14 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY This changes the code for the PhraseAndIterator in the same way as done for

D28839: [PostingIterator] Make sure skipTo also works for first element

2020-04-14 Thread Stefan Brüns
bruns added a dependent revision: D28843: [AndPostingIterator] Replace recursive next() implementation. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28839 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,

D28843: [AndPostingIterator] Replace recursive next() implementation

2020-04-14 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The next() call will recurse once for each document in the first set until

D19913: [plasma-desktop] make it compiles without foreach

2020-04-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks like this got lost/abandoned? It's painful to review (because it's so long), but it shouldn't be lost work... Can you rebase and see if it still applies? Maybe in the future

D25443: [chmodjob] Port away from QLinkedList

2020-04-14 Thread Nicolas Fella
nicolasfella edited the summary of this revision. REPOSITORY R241 KIO BRANCH ll REVISION DETAIL https://phabricator.kde.org/D25443 To: nicolasfella, #frameworks, dfaure Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D28811: Add drawer on mobile and clean code

2020-04-14 Thread Carl Schwan
ognarb retitled this revision from "WIP: Use CSS grid to improve layout" to "Add drawer on mobile and clean code". ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To:

D22705: Deprecate KRun::runService

2020-04-14 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Should now point to ApplicationLauncherJob. And please consider porting the users, not just deprecating and letting others do the porting. I'm taking care of run() and

D28811: WIP: Use CSS grid to improve layout

2020-04-14 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb added reviewers: cblack, ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb, cblack, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, michaelh,

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

2020-04-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Can go in, but I'd still suggest starting the separate class now. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D24695 To: meven, #frameworks,

D28811: WIP: Use CSS grid to improve layout

2020-04-14 Thread Carl Schwan
ognarb updated this revision to Diff 80156. ognarb added a comment. Add NoScript support REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80155=80156 BRANCH flex-grid REVISION DETAIL https://phabricator.kde.org/D28811 AFFECTED FILES

D26131: Braces around for, break early.

2020-04-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I'd remove the space after '!' and make the bool const, but I'm nitpicking, you can also push as is. cbegin/cend wouldn't change anything on a const container. REPOSITORY R237

D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

2020-04-14 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I don't understand what these "external causes" might be. The bug report doesn't say more other than "happens after a suspend". This needs further debugging IMHO.

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

2020-04-14 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH single-undo (branched from master) REVISION DETAIL https://phabricator.kde.org/D28819 To: poboiko, #frameworks, mlaurent, dfaure Cc: ahmadsamir, kde-frameworks-devel,

D28831: Add note about porting loadMimeTypeIcon

2020-04-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, for the simple case (no overlays, no extraction of path). More complete documentation would include the args for QIcon::pixmap but OK, very often we just port to QIcon instead.

D25443: [chmodjob] Port away from QLinkedList

2020-04-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. (remember to s/list/stack/ in the commit log) REPOSITORY R241 KIO BRANCH ll REVISION DETAIL https://phabricator.kde.org/D25443 To: nicolasfella, #frameworks, dfaure Cc: dfaure,

D28811: WIP: Use CSS grid to improve layout

2020-04-14 Thread Carl Schwan
ognarb updated this revision to Diff 80155. ognarb added a comment. - Add drawer on mobile (with JS) - Fix some layout issues REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80057=80155 BRANCH flex-grid REVISION DETAIL

D28839: [PostingIterator] Make sure skipTo also works for first element

2020-04-14 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28839 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28839: [PostingIterator] Make sure skipTo also works for first element

2020-04-14 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case next() has never been called on an iterator, docId() returns 0 (it

D28834: Add metadata properties to calendar

2020-04-14 Thread Volker Krause
vkrause added a comment. In D28834#648405 , @winterz wrote: > I don't know how things are done in frameworks but it seems to me that the KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now This is handled

D28834: Add metadata properties to calendar

2020-04-14 Thread Allen Winter
winterz added a comment. I don't know how things are done in frameworks but it seems to me that the KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now REPOSITORY R172 KCalendar Core BRANCH props REVISION DETAIL https://phabricator.kde.org/D28834 To:

D28834: Add metadata properties to calendar

2020-04-14 Thread Allen Winter
winterz accepted this revision. This revision is now accepted and ready to land. REPOSITORY R172 KCalendar Core BRANCH props REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause, winterz Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin,

D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella
nicolasfella marked an inline comment as done. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80150. nicolasfella added a comment. - default to ReadWrite - rename icon to iconname to reflect that it's just the name REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28834?vs=80140=80150 BRANCH props

D28834: Add metadata properties to calendar

2020-04-14 Thread Allen Winter
winterz added a comment. looks good. nice touch using Q_EMIT. INLINE COMMENTS > calendar_p.h:81 > +QString mIcon; > +CalendarType mType; > }; CalendarType mType = ReadWrite ? REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To:

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

2020-04-14 Thread Konrad Materka
kmaterka updated this revision to Diff 80148. kmaterka marked an inline comment as done. kmaterka added a comment. Do not inherit from QObject REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28470?vs=79283=80148 BRANCH master REVISION

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

2020-04-14 Thread Konrad Materka
kmaterka marked an inline comment as done. kmaterka added a comment. In D28470#647757 , @davidedmundson wrote: > Note there's a unit test for IconItem worth running if you haven't already. I've checked that already, these test were

D7563: Add privilegeExecution field to file protocol description

2020-04-14 Thread Nathaniel Graham
ngraham added a comment. @chinmoyr phab reports that this has a missing dependency/patch base. Is there some unmerged patch that's left to do, or does it just need a rebase on master? BRANCH master REVISION DETAIL https://phabricator.kde.org/D7563 To: chinmoyr, #frameworks, dfaure Cc:

D24443: Add a plugin system

2020-04-14 Thread Nicolas Fella
nicolasfella planned changes to this revision. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, dhaumann, fbampaloukas, dcaliste,

D24443: Add a plugin system

2020-04-14 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80142. nicolasfella added a comment. - Convert license headers to SPDX REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=80141=80142 BRANCH arcpatch-D24443_2 REVISION DETAIL

D24443: Add a plugin system

2020-04-14 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80141. nicolasfella added a comment. - Remove calendarentry REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=71067=80141 BRANCH arcpatch-D24443_2 REVISION DETAIL

D24443: Add a plugin system

2020-04-14 Thread Nicolas Fella
nicolasfella edited the summary of this revision. nicolasfella added a dependency: D28834: Add metadata properties to calendar. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: z3ntu, ognarb, kde-pim,

D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella
nicolasfella added a dependent revision: D24443: Add a plugin system. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent,

D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella
nicolasfella added reviewers: Frameworks, KDE PIM, vkrause. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D25443: [chmodjob] Port away from QLinkedList

2020-04-14 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80139. nicolasfella added a comment. - Update comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25443?vs=70143=80139 BRANCH ll REVISION DETAIL https://phabricator.kde.org/D25443 AFFECTED FILES

D25443: [chmodjob] Port away from QLinkedList

2020-04-14 Thread Nicolas Fella
nicolasfella marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25443 To: nicolasfella, #frameworks, dfaure Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D26650: Use KService to look for Filelight

2020-04-14 Thread Nathaniel Graham
ngraham commandeered this revision. ngraham edited reviewers, added: shubham; removed: ngraham. ngraham added a comment. Aha! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: ngraham, broulik, shubham Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel,

D26650: Use KService to look for Filelight

2020-04-14 Thread Nathaniel Graham
ngraham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: ngraham, broulik, shubham Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

2020-04-14 Thread Ahmad Samir
ahmadsamir added a comment. In D28774#647157 , @dfaure wrote: > I mean, the user can press cancel, that's when QColorDialog returns an invalid color. > If there was a concept like an invalid font we could do the same here, but there's no

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

2020-04-14 Thread Ahmad Samir
ahmadsamir added a reviewer: dfaure. ahmadsamir added a comment. I tested this with the krichtexteditor test app from kxmlgui, and it works. (It's never too late to fix a bug, even if it's from 2010 :)). REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D28819

D24773: kio_trash: Add size, modification, access and create date for trash:/

2020-04-14 Thread Ahmad Samir
ahmadsamir added a comment. Hello. This broke the testtrash unit test https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/45/execution/node/36/log/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 45 - Still Unstable!

2020-04-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/45/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 14 Apr 2020 15:15:28 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 53 - Still Unstable!

2020-04-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/53/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 14 Apr 2020 15:15:28 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D22554: Finer No-Dbus on Windows

2020-04-14 Thread Nicolas Fella
nicolasfella added a comment. @brute4s99 Is this still relevant? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 544 - Still Unstable!

2020-04-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/544/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 14 Apr 2020 15:15:28 + Build duration: 7 min 56 sec and counting BUILD ARTIFACTS

D27704: Drop FindAccountsFileDir.cmake

2020-04-14 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27704 To: nicolasfella, #frameworks, bshah, leinir, lbeltrame Cc: lbeltrame

D28831: Add note about porting loadMimeTypeIcon

2020-04-14 Thread Nathaniel Graham
ngraham added a comment. +1 REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D28831 To: nicolasfella, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

2020-04-14 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R241:ee08d0b4e56e: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

2020-04-14 Thread Nicolas Fella
nicolasfella added a comment. In D25707#645694 , @dfaure wrote: > OK. Then let me change my comment to: please document in kiconloader.h how to port away from loadMimeTypeIcon, even if it's not actually deprecated. > > I remember wondering

D28831: Add note about porting loadMimeTypeIcon

2020-04-14 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We're phasing out loadMimeTypeIcon in favor of

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-14 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > display.h:281-288 > /** > * Creates the XdgOutputManagerInterface > * > * @return the created manager > * @since 5.47 > + * @deprecated use the version that takes a version > */ Please use

D27816: KI18N_WRAP_UI macro: set SKIP_AUTOUIC property on ui file and gen. header

2020-04-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. If no-one objects, going to push upcoming WE then, April 18/19 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27816 To: kossebau, #frameworks, ilic Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28745: Skip caching thumbnails on encrypted filesystems

2020-04-14 Thread Méven Car
meven added a comment. This is gonna have an hefty toll on perf as it will add a `getmntent` syscall to every thumbnail generation. Using `Solid::Device::listFromType` would leverage Solid always up-to-date (using events rather thane sysalls) device cache. I am not sure in the end this

D28701: [WIP] Add KPackage support to KNewStuffCore

2020-04-14 Thread Dan Leinir Turthra Jensen
leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

2020-04-14 Thread Dan Leinir Turthra Jensen
leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

2020-04-14 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 80099. leinir added a comment. - Make a touch of noise when encountering the fallback REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28701?vs=80098=80099 BRANCH add-kpackage-support (branched from master) REVISION

D28701: [WIP] Add KPackage support to KNewStuffCore

2020-04-14 Thread Dan Leinir Turthra Jensen
leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

2020-04-14 Thread Dan Leinir Turthra Jensen
leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

Re: Update on Status of Gitlab Migration

2020-04-14 Thread Nate Graham
On 4/13/20 6:59 PM, Ben Cooksley wrote: Why do we need to mimic them? If you Google "KDE Gitlab" then the first hit is invent.kde.org . To flip it around: why do we need to do something different? I don't think it's about mimicking anyone else, but rather using the

D28701: [WIP] Add KPackage support to KNewStuffCore

2020-04-14 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 80098. leinir added a comment. Bunch of new functionality, with a fallback which ought to allow it to work without requiring any kind of changes to the existing knsrc files based on kpackage, as long as they follow the pattern they seem to mostly

D20655: Use generated DBus interface

2020-04-14 Thread Stefan Brüns
bruns added a comment. In D20655#647806 , @davidedmundson wrote: > We copy udisks xml already. I don't think it ends up any better. Otherwise we have a compile time dep on a runtime plugin, which inevitably means we need to make it optional

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

2020-04-14 Thread Igor Poboiko
poboiko edited the summary of this revision. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D28819 To: poboiko, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

2020-04-14 Thread Igor Poboiko
poboiko created this revision. poboiko added reviewers: Frameworks, mlaurent. Herald added a project: Frameworks. poboiko requested review of this revision. REVISION SUMMARY If my cursor is on a bullet list, and I press Enter to create a new element, it registers as 5-7 actions in an undo

D20655: Use generated DBus interface

2020-04-14 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. We copy udisks xml already. I don't think it ends up any better. Otherwise we have a compile time dep on a runtime plugin, which inevitably means we need to make

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

2020-04-14 Thread David Edmundson
davidedmundson added a comment. Note there's a unit test for IconItem worth running if you haven't already. The refactor in general makes sense - it's a lot cleaner. Though I'm not sure what our super long term KF6 plan for IconItem is, it'll definitely be changing quite a bit.

D28701: [WIP] Add KPackage support to KNewStuffCore

2020-04-14 Thread Dan Leinir Turthra Jensen
leinir added a comment. In D28701#644973 , @ngraham wrote: > Okay thanks, can you update the test plan then? Also I think the diff currently does not actually fix 418466. Your comments (and adding on reviewers) seems to suggest to me

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

2020-04-14 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > iconitem.cpp:40 > > +class IconItemSource : public QObject > +{ does it have to be a QObject? it doesn't have properties, signals or invokables.. qobject is an expensive class so if you don't have to use oits features is better to avoid

Re: Update on Status of Gitlab Migration

2020-04-14 Thread Ivan Čukić
Hi all, While I do like the invent name, I agree there should be a redirect of some sort from git.kde.org to it. The aforementioned Debian salsa server has one as well - https:// git.debian.org/ - a message stating that the new server is 'salsa.debian.org' Cheers, Ivan -- dr Ivan Čukić

Re: Update on Status of Gitlab Migration

2020-04-14 Thread Ben Cooksley
On Tue, Apr 14, 2020 at 2:37 PM Nate Graham wrote: > > On 4/13/20 6:59 PM, Ben Cooksley wrote: > > Why do we need to mimic them? > > > > If you Google "KDE Gitlab" then the first hit is invent.kde.org > > . > > To flip it around: why do we need to do something different? I

Re: Update on Status of Gitlab Migration

2020-04-14 Thread Ben Cooksley
On Mon, Apr 13, 2020 at 9:29 AM Johan Ouwerkerk wrote: > > On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk > wrote: > > > > > > > > We may need to do on-the-fly conversion of the kde: repo paths if they > > > won't be expressible as 'kde:foo' in the future, but we should have the > > >

D26650: Use KService to look for Filelight

2020-04-14 Thread Kai Uwe Broulik
broulik added a comment. Superseded by D28266 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: shubham, broulik, ngraham Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 44 - Unstable!

2020-04-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/44/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 14 Apr 2020 05:41:33 + Build duration: 1 hr 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 52 - Still Unstable!

2020-04-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/52/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 14 Apr 2020 05:41:33 + Build duration: 41 min and counting JUnit Tests Name: projectroot

D28814: TypeScript: add the "awaited" type operator

2020-04-14 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Add the new keyword