D28874: Taiwanese holidays

shrapnel edited the summary of this revision. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

shrapnel created this revision. shrapnel added reviewers: VDG, Zren. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shrapnel requested review of this revision. REVISION SUMMARY File containing taiwanese holidays REPOSITORY R175 KHolidays REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/60/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 16 Apr 2020 04:03:44 + Build duration: 17 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/52/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 16 Apr 2020 04:03:44 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 551 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/551/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Apr 2020 04:03:44 + Build duration: 6 min 4 sec and counting BUILD ARTIFACTS

D28870: Updated test file for Logtalk syntax highlighting

pmoura retitled this revision from "Updated test file for syntax highlighting" to "Updated test file for Logtalk syntax highlighting". pmoura edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28870 To: pmoura, cullmann Cc:

D28796: Update Logtalk language syntax support

pmoura added a comment. See https://phabricator.kde.org/D28870 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28796 To: pmoura, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham,

D28870: Updated test file for syntax highlighting

pmoura created this revision. pmoura added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. pmoura requested review of this revision. REVISION SUMMARY Updated test file for syntax highlighting. REPOSITORY R216 Syntax

D28865: [PhraseAndIterator] Remove temporary arrays when checking matches

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Instead of copying all positions and applying the the shift on the copies,

D28863: [Extractor] Fix idle monitoring

bruns added a dependent revision: D28864: [Extractor] Better balance idle and busy mode. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28863 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28864: [Extractor] Better balance idle and busy mode

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Add an additional delay of 500ms after each batch when the computer is in

D28862: [Extractor] Remove IdleStateMonitor wrapper class

bruns added a dependent revision: D28863: [Extractor] Fix idle monitoring. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28862 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh,

D28863: [Extractor] Fix idle monitoring

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Resume events are only signaled when KIdleTime has been explicitly told to

D28862: [Extractor] Remove IdleStateMonitor wrapper class

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY IdleStateMonitor is just a wrapper around KIdleTime, which can be

D28845: [OrpostingIterator] Allow skipping elements, implement skipTo

This revision was automatically updated to reflect the committed changes. Closed by commit R293:4e7626c9488b: [OrpostingIterator] Allow skipping elements, implement skipTo (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28845?vs=80163=80235

D28844: [PhraseAndIterator] Replace recursive next() implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R293:c00cf2022763: [PhraseAndIterator] Replace recursive next() implementation (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28844?vs=80161=80234

D28843: [AndPostingIterator] Replace recursive next() implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5d20560ef6d6: [AndPostingIterator] Replace recursive next() implementation (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28843?vs=80160=80233

D28811: Add drawer on mobile and clean code

ognarb added a comment. I now generate the CSS from aether-sass. The code can be found https://invent.kde.org/websites/aether-sass/-/blob/master/css/aether-sidebar.scss. And all tree wikis are using it. @ochurlaud should I create a sysadmin request for you to get access to the repo in

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure added inline comments. INLINE COMMENTS > trashimpl.cpp:1092 > +TrashSizeCache trashSize(trashPath); > +TrashSizeCache::SizeAndModTime res = > trashSize.calculateSizeAndLatestModDate(); > +size += res.size; It's actually this call which triggers the unittest

D28861: Sonnet add Malayalam trigram

aiswaryak created this revision. aiswaryak created this object with visibility "All Users". Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aiswaryak requested review of this revision. REVISION SUMMARY Add Malayalam trigram which is absent in the current

D28854: [KRichTextWidget] Add support for headings

abstractdevelop added a comment. Hey, thanks for this @poboiko I used to have to implement this myself, so this will be very useful in my app, O20.Word. ;) REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D28854 To: poboiko, #frameworks, mlaurent, ahmadsamir,

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure added a comment. TestTrash::renameDirInTrash makes the dir cache invalid (it still lists trashDirFromHome). I think because of the optimization that we don't always care about the size... but this had the side effect of keeping the cache uptodate I wonder if the test is too

D26034: Replace KLocalSocket with QLocalSocket

dfaure added a comment. It built but apparently the unittests for KIO are disabled on CI :( REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26034 To: nicolasfella, #frameworks, dfaure Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D28854: [KRichTextWidget] Add support for headings

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krichtextedit.cpp:346 > +// level=2 look the same > +int sizeAdjustment = boundedLevel > 0 ? 5 - boundedLevel: 0; > + If boundedLevel is 6, the size

D28811: Add drawer on mobile and clean code

ognarb updated this revision to Diff 80229. ognarb added a comment. - Fix typo in path - Add information about there to find the source of the css files REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80228=80229 BRANCH flex-grid REVISION

D28811: Add drawer on mobile and clean code

ognarb updated this revision to Diff 80228. ognarb added a comment. This revision is now accepted and ready to land. - Use version from cdn REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80156=80228 BRANCH flex-grid REVISION DETAIL

D28854: [KRichTextWidget] Add support for headings

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R310 KTextWidgets BRANCH textwidget-heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28854 To: poboiko, #frameworks, mlaurent,

D28796: Update Logtalk language syntax support

pmoura added a comment. There is a more recent version of that file. How to proceed? By creating a new review request for that file with a diff? Or is there a way to associate it with this review request? REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D28811: Add drawer on mobile and clean code

ochurlaud accepted this revision. ochurlaud added a comment. OK it's clearer: Please add somewhere that it's a generated css so that no-one tries to change it by hand and ship it REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb, cblack,

D28814: TypeScript: add the "awaited" type operator

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1f1f03198aa7: TypeScript: add the awaited type operator (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D28814: TypeScript: add the "awaited" type operator

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks ;=) Even with test. REPOSITORY R216 Syntax Highlighting BRANCH add-awaited-typescript REVISION DETAIL https://phabricator.kde.org/D28814 To: nibags,

D28796: Update Logtalk language syntax support

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Change looks reasonable, but could that testfile be added to our autotests directory? (or the file we have there extended) The current auto test file is

D28845: [OrpostingIterator] Allow skipping elements, implement skipTo

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28845 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28844: [PhraseAndIterator] Replace recursive next() implementation

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28844 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28843: [AndPostingIterator] Replace recursive next() implementation

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28843 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28839: [PostingIterator] Make sure skipTo also works for first element

This revision was automatically updated to reflect the committed changes. Closed by commit R293:dd1b7a6d02a5: [PostingIterator] Make sure skipTo also works for first element (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D28850: Updated Romanian holidays

This revision was automatically updated to reflect the committed changes. Closed by commit R175:28ad589a1fbe: Updated Romanian holidays (authored by sionescu, committed by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28850?vs=80179=80220#toc REPOSITORY R175 KHolidays CHANGES

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.14 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.14/19/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 15 Apr 2020 16:34:35 + Build duration: 2 min 28 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 311 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/311/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 15 Apr 2020 16:34:35 + Build duration: 1 min 54 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.14 - Build # 21 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.14/21/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 15 Apr 2020 16:34:35 + Build duration: 43 sec and counting CONSOLE OUTPUT

D28755: Breeze Icons cannot be built from read-only source location

This revision was automatically updated to reflect the committed changes. Closed by commit R266:0a5dd2972b62: Allow building from a read-only source location (authored by marten). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28755?vs=79867=80219

D28808: [ExpandableListItem] make it touch-friendly

ngraham updated this revision to Diff 80218. ngraham added a comment. Simpler enabled handling REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28808?vs=80217=80218 BRANCH make-ExpandableListItem-touchable (branched from master)

D28855: put minimumkeepsize actually in the netpref KCM

sitter added a comment. Coding style is actually wildly inconsistent in that file, so I've stuck to what similar other lines have. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack,

D28855: put minimumkeepsize actually in the netpref KCM

ahmadsamir added inline comments. INLINE COMMENTS > netpref.cpp:87 > +connect(cb_globalMarkPartial, ::toggled, > +partialWidget, [partialWidget](bool checked) { > partialWidget->setEnabled(checked); }); > +globalLayout->addWidget(partialWidget); Why not "::setEnabled"

D28808: [ExpandableListItem] make it touch-friendly

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28808 To: ngraham, #plasma, apol, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

ngraham updated this revision to Diff 80217. ngraham added a comment. Use TapHandler instead of MultiPointTouchArea REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28808?vs=80054=80217 BRANCH make-ExpandableListItem-touchable (branched

D28488: [Fstab] Ensure uniqueness for all filesystem types

meven added a comment. A consequence of this is the deviceName is used in fstab device description : F8240164: Screenshot_20200415_180517.png Making planner the need for D28590 REPOSITORY R245 Solid

D28808: [ExpandableListItem] make it touch-friendly

ngraham planned changes to this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28808 To: ngraham, #plasma, apol, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28811: Add drawer on mobile and clean code

ognarb added a comment. POC of sharing this code with the wikis: https://wikisandbox.kde.org/Welcome_to_KDE_TechBase REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb, cblack, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack,

D28856: Save disabling of desktop file components in kglobalshortcutsrc

davidre added inline comments. INLINE COMMENTS > globalshortcutsregistry.cpp:274 > +auto disabledComponents = KConfigGroup(&_config, > "disabledComponents").readEntry("disabled", QStringList()); > for (const QString : groupList) > { good point >

D28856: Save disabling of desktop file components in kglobalshortcutsrc

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > globalshortcutsregistry.cpp:274 > +auto disabledComponents = KConfigGroup(&_config, > "disabledComponents").readEntry("disabled", QStringList()); >

D28701: Add KPackage support to KNewStuffCore

ngraham added a comment. This has fixed the issues I was seeing with installation and uninstallation, nice! However I'm not seeing a very long hang when installing certain global themes--for example Sweet KDE and Layan Look and Feel Theme. It does ultimately work, but the dialog freezes for

D28745: Skip caching thumbnails on encrypted filesystems

marcingu added a comment. In D28745#648036 , @meven wrote: > This is gonna have an hefty toll on perf as it will add a `getmntent` syscall to every thumbnail generation. > Using `Solid::Device::listFromType` would leverage Solid always

D28856: Save disabling of desktop file components in kglobalshortcutsrc

davidre updated this revision to Diff 80206. davidre added a comment. foo REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28856?vs=80205=80206 BRANCH disable (branched from master) REVISION DETAIL https://phabricator.kde.org/D28856 AFFECTED

D28856: Save disabling of desktop file components in kglobalshortcutsrc

davidre created this revision. davidre added reviewers: davidedmundson, fvogt, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Works for writable and not writable files. Additional positive

D28855: put minimumkeepsize actually in the netpref KCM

sitter added a comment. And didn't we have a better spinny box for byte units somewhere? Where the user can put `1 byte` or `1 kib` or `1 gib` and the box knows what to do? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc:

D24956: Consider desktop files with NoDisplay attribute

fvogt added a comment. In D24956#648968 , @davidedmundson wrote: > > [14:12] DavidRedondo1: my understanding is that a system might ship "konsole opens with control+t". The UI allows you to remove that. This would remove the entry in

D28855: put minimumkeepsize actually in the netpref KCM

sitter added a comment. F8240046: Screenshot_20200415_164836.png I'm very open for better labels, it's a horrible concept to explain in a few words. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham,

D24956: Consider desktop files with NoDisplay attribute

davidre added a comment. In D24956#648991 , @meven wrote: > In D24956#648968 , @davidedmundson wrote: > > > > [14:12] DavidRedondo1: my understanding is that a system might ship "konsole opens

D28855: put minimumkeepsize actually in the netpref KCM

sitter updated this revision to Diff 80204. sitter added a comment. improve label a tad REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28855?vs=80203=80204 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28855 AFFECTED FILES

D24956: Consider desktop files with NoDisplay attribute

meven added a comment. In D24956#648968 , @davidedmundson wrote: > > [14:12] DavidRedondo1: my understanding is that a system might ship "konsole opens with control+t". The UI allows you to remove that. This would remove the entry in

D28855: put minimumkeepsize actually in the netpref KCM

sitter created this revision. sitter added reviewers: ngraham, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY I didn't even know it was a thing! by the looks of it the setting only applies

D28854: [KRichTextWidget] Add support for headings

poboiko updated this revision to Diff 80202. poboiko added a comment. Added a unit-test testing for everything I could come up with (at least 4 "behavior nuances" from the commit message) Address other feedback as well (const'ify, @since version) REPOSITORY R310 KTextWidgets

D28850: Updated Romanian holidays

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. looks fine. I tested it. can someone commit this please? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28850 To: sionescu, winterz Cc: winterz,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 550 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/550/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 15 Apr 2020 14:12:20 + Build duration: 6 min 45 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/59/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 15 Apr 2020 14:12:20 + Build duration: 6 min 39 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/51/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 15 Apr 2020 14:12:20 + Build duration: 5 min 31 sec and counting BUILD ARTIFACTS

D24956: Consider desktop files with NoDisplay attribute

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > [14:12] DavidRedondo1: my understanding is that a system might ship "konsole opens with control+t". The UI allows you to remove that. This would remove the entry in

D28851: Mark KStatusBarOfflineIndicator as deprecated

This revision was automatically updated to reflect the committed changes. Closed by commit R241:cd53f10cad27: Mark KStatusBarOfflineIndicator as deprecated (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28851?vs=80190=80201 REVISION

D28851: Mark KStatusBarOfflineIndicator as deprecated

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yeah, it's from before Solid existed... KIO was the only place for this kind of stuff back then. REPOSITORY R241 KIO BRANCH offl REVISION DETAIL https://phabricator.kde.org/D28851

D28701: Add KPackage support to KNewStuffCore

leinir added reviewers: ngraham, mart, davidedmundson. leinir added a comment. Tagging in those active in the referenced bug, except for the reporter who doesn't have a phabricator account REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma,

D25705: Deprecate KIO::pixmapForUrl

kossebau added inline comments. INLINE COMMENTS > pixmaploader.h:37 > * > + * @deprecated since 5.70, use KIO::iconNameForUrl() > + * to get the icon name and use QIcon::fromTheme().pixmap() `@deprecated` should go after `@return` here, cmp.

D25705: Deprecate KIO::pixmapForUrl

nicolasfella planned changes to this revision. nicolasfella added a comment. Seems like I missed some usages REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack,

D25705: Deprecate KIO::pixmapForUrl

nicolasfella updated this revision to Diff 80199. nicolasfella added a comment. - Fix update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25705?vs=80197=80199 BRANCH arcpatch-D25705_1 REVISION DETAIL https://phabricator.kde.org/D25705 AFFECTED FILES

D25705: Deprecate KIO::pixmapForUrl

nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25705: Deprecate KIO::pixmapForUrl

nicolasfella updated this revision to Diff 80197. nicolasfella added a comment. - Update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25705?vs=72413=80197 BRANCH arcpatch-D25705_1 REVISION DETAIL https://phabricator.kde.org/D25705 AFFECTED FILES

D28854: [KRichTextWidget] Add support for headings

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. Can you improve autotest KRichTextEditTest ? INLINE COMMENTS > krichtextedit.cpp:346 > +// level=2 look the same > +int sizeAdjustment = boundedLevel > 0 ? 5 -

D28701: Add KPackage support to KNewStuffCore

leinir retitled this revision from "[WIP] Add KPackage support to KNewStuffCore" to "Add KPackage support to KNewStuffCore". leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir updated this revision to Diff 80195. leinir added a comment. Think we're at the point where testing would be good, now. This update means we now attempt to adopt already installed kpackages if you try and install the package from knewstuff, and removal of entries installed using

D25267: Improve XCF support

cfeck added a comment. Thanks for your work, Martin! Could you please add a note (or resolve) bug 360821? REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D25267 To: sandsmark, aacid, cfeck, apol, vkrause Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack,

D10989: Check for nullptr in indexForNode

jtamate abandoned this revision. jtamate added a comment. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10989 To: jtamate, #frameworks, dfaure Cc: kde-frameworks-devel, mpyne, LeGast00n, cblack, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

fvogt added a comment. In D24956#648905 , @davidedmundson wrote: > kglobalshortcutseditor.cpp > needs updating to match > > I think you're right with your reasoning about NoDisplay, but we do want something to be able to mask system

D24956: Consider desktop files with NoDisplay attribute

davidedmundson added a comment. kglobalshortcutseditor.cpp needs updating to match I think you're right with your reasoning about NoDisplay, but we do want something to be able to mask system files. From the spec should we be checking Hidden= ? REPOSITORY R268 KGlobalAccel

D28854: [KRichTextWidget] Add support for headings

poboiko edited the test plan for this revision. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D28854 To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28854: [KRichTextWidget] Add support for headings

poboiko created this revision. poboiko added reviewers: Frameworks, mlaurent, ahmadsamir, dfaure. Herald added a project: Frameworks. poboiko requested review of this revision. REVISION SUMMARY This patch adds support of different headings (essentially, HTML h1..h6 tags). Those might be

D24956: Consider desktop files with NoDisplay attribute

apol added a comment. +1 This makes sense to me REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D24956 To: meven, mart, #plasma, fvogt, apol Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D17805: Allow specifying multiple mimetypes as constraints

nicolasfella abandoned this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17805 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28851: Mark KStatusBarOfflineIndicator as deprecated

nicolasfella added a task: T12373: Move or kill KStatusBarOfflineIndicator. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28851 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28851: Mark KStatusBarOfflineIndicator as deprecated

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Conceptually it doesn't really belong to KIO and KTorrent

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/50/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 15 Apr 2020 11:21:51 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/58/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 15 Apr 2020 11:21:50 + Build duration: 10 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 549 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/549/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 15 Apr 2020 11:21:51 + Build duration: 7 min 1 sec and counting BUILD ARTIFACTS

D26034: Replace KLocalSocket with QLocalSocket

This revision was automatically updated to reflect the committed changes. Closed by commit R241:28da79f2119e: Replace KLocalSocket with QLocalSocket (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26034?vs=71642=80188 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/57/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 15 Apr 2020 10:48:54 + Build duration: 31 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/49/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 15 Apr 2020 10:48:54 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 548 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/548/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 15 Apr 2020 10:48:54 + Build duration: 12 min and counting BUILD ARTIFACTS

D28831: Add note about porting loadMimeTypeIcon

This revision was automatically updated to reflect the committed changes. Closed by commit R302:fe3f59b27dcf: Add note about porting loadMimeTypeIcon (authored by nicolasfella). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28831?vs=80128=80186 REVISION

D25443: [chmodjob] Port away from QLinkedList

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e18ae3ea52dc: [chmodjob] Port away from QLinkedList (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25443?vs=80139=80187 REVISION DETAIL

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir updated this revision to Diff 80184. leinir edited the test plan for this revision. leinir added a comment. (the fallback handling needs some more work, but also progress) - Clean up some of the error reporting, and reset the entry's state - Check if installedFile is a file, if

D28811: Add drawer on mobile and clean code

ognarb planned changes to this revision. ognarb added a comment. In D28811#648700 , @ochurlaud wrote: > I really dislike how you close brackets in css : it's more dense and harder to read. > > You indent sometimes with 1,2 or 3 spaces: it

  1   2   >