D28808: [ExpandableListItem] make it touch-friendly

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:52c0a136f9ff: [ExpandableListItem] make it touch-friendly (authored by ngraham). REPOSITORY R242 Plasma Framework

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80444. xuetianweng added a comment. Fix the handling when layout formats has background. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25339?vs=80438=80444 BRANCH arcpatch-D25339 REVISION DETAIL

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. F8244684: Screenshot_20200417_222110.png Add a screenshot to demostrate the change. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: xuetianweng, #ktexteditor, cullmann, dhaumann

Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

Hi all, Please see below - any ideas as to why KHelpCenter no longer successfully builds? It doesn't look like KHelpCenter has changed... Cheers, Ben -- Forwarded message - From: CI System Date: Sat, Apr 18, 2020 at 4:38 PM Subject: KDE CI: Administration » Dependency Build

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

On Fri, Apr 17, 2020 at 8:28 AM Nicolas Fella wrote: > > Hi, Hi Nicolas, > > > > this looks like a simple prison build failure to me. However, I cannot > reprocuce this with the binary factory container and the current Prison > Android CI builds is blue. There is a single red Android build in

D28934: baloo_file stop throwing ASSERT failure

leszeklesner created this revision. leszeklesner added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. leszeklesner requested review of this revision. REVISION SUMMARY I build baloo from 5.69 and always get on executing baloo_file.

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 554 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/554/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 18 Apr 2020 02:56:18 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/63/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 18 Apr 2020 02:56:19 + Build duration: 7 min 53 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/55/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 18 Apr 2020 02:56:19 + Build duration: 7 min 15 sec and counting BUILD ARTIFACTS

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bd7607f43dea: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69 (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28910?vs=80440=80441

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

ahmadsamir updated this revision to Diff 80440. ahmadsamir added a comment. Remove ifdef, all KF5 parts require the same version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28910?vs=80364=80440 BRANCH l-kbookmark (branched from master) REVISION DETAIL

D28874: Taiwanese holidays

ngraham added a comment. Sure, I can do it. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: ngraham, winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

ahmadsamir added a comment. In D28910#650745 , @dfaure wrote: > Thanks. > > Well, all of KF5 is supposed to always be the same version. You don't need the ifdef for old kbookmarks version. KIO 5.70 requires KBookmarks 5.70. Ah, yes,

D28932: Store filename terms just once

bruns updated this revision to Diff 80439. bruns added a comment. add missing tests REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28932?vs=80435=80439 BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28932 AFFECTED FILES

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. In D25339#563937 , @cullmann wrote: > Actually, I could live with: > > 1. All lines are a bit higher, for me that makes reading even easier. But the rendering shall have no glitches. > 2. Some lines have

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80438. xuetianweng added a comment. handle the range with multiple lines. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25339?vs=80433=80438 BRANCH arcpatch-D25339 REVISION DETAIL

D28933: [Coding] Avoid recurrent detach and size checks

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY QVector::append() is quite expensive, as each access checks if the array

D28900: Fix wayland scanner warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R240:3734a5368e44: Fix wayland scanner warnings (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28900?vs=80334=80436 REVISION DETAIL

D28932: Store filename terms just once

bruns updated this revision to Diff 80435. bruns added a comment. whitespace REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28932?vs=80434=80435 BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28932 AFFECTED FILES

D28932: Store filename terms just once

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Filename terms where stored twice, once with the "F" filename property

D28929: [QueryTest] Track if phrase matches in content or filename

bruns added a dependent revision: D28932: Store filename terms just once. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28929 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh,

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80433. xuetianweng added a comment. Try to fill the gap if we increase the line height with representitive char. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25339?vs=69848=80433 BRANCH arcpatch-D25339

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks. Well, all of KF5 is supposed to always be the same version. You don't need the ifdef for old kbookmarks version. KIO 5.70 requires KBookmarks 5.70. REPOSITORY R241 KIO

D27816: KI18N_WRAP_UI macro: set SKIP_AUTOUIC property on ui file and gen. header

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R249:2797750b7f8f: KI18N_WRAP_UI macro: set SKIP_AUTOUIC property on ui file and gen. header (authored by kossebau).

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

dfaure updated this revision to Diff 80428. dfaure added a comment. Remove comment change above StatBasic REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28901?vs=80335=80428 BRANCH 2020_optimize_recursive_size REVISION DETAIL

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

dfaure added inline comments. INLINE COMMENTS > meven wrote in trashimpl.cpp:1105 > Maybe, check for `details & KIO::StatTime` > Down the rabbit hole... Well, if StatRecursiveSize is set, we have the info, so we might as well provide it. If it's not set, then this would mean we need to do the

D28924: [SearchStore] Allow querying exact matches for non-properties

This revision was automatically updated to reflect the committed changes. Closed by commit R293:de261f8bae5a: [SearchStore] Allow querying exact matches for non-properties (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28924?vs=80417=80426

D28925: [QueryTest] Extend phrase query tests

This revision was automatically updated to reflect the committed changes. Closed by commit R293:0a626db918a9: [QueryTest] Extend phrase query tests (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28925?vs=80418=80427 REVISION DETAIL

D28874: Taiwanese holidays

winterz added a comment. In D28874#650661 , @ngraham wrote: > Do you not have commit access? I thought you were the maintainer based on the repo's history! Yes of course. I'm asking for assistance at this time. REPOSITORY R175

D28929: [QueryTest] Track if phrase matches in content or filename

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY When checking for matches, a phrase can match the content, the filename, or

D28925: [QueryTest] Extend phrase query tests

bruns added a dependent revision: D28929: [QueryTest] Track if phrase matches in content or filename. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28925 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,

D28923: Update links in README.md

This revision was automatically updated to reflect the committed changes. Closed by commit R266:e5dfa14b64a6: Update links in README.md (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28923?vs=80414=80423 REVISION DETAIL

D28924: [SearchStore] Allow querying exact matches for non-properties

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28924 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28925: [QueryTest] Extend phrase query tests

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28925 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28874: Taiwanese holidays

ngraham added a comment. Do you not have commit access? I thought you were the maintainer based on the repo's history! REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: ngraham, winterz, kde-frameworks-devel, LeGast00n,

D28923: Update links in README.md

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH readme (branched from master) REVISION DETAIL https://phabricator.kde.org/D28923 To: ndavis, #vdg, ngraham Cc: alex-l, ngraham, kde-frameworks-devel, LeGast00n, cblack,

D28925: [QueryTest] Extend phrase query tests

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Add the filename also with the "F" prefix, like the BasicIndexingJob does.

D28924: [SearchStore] Allow querying exact matches for non-properties

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Exact matches were only possible for prefixed properties, e.g. filename=test

D28891: Nicaragua Holidays

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. other than the indentation in the .qrc file this is good to go.. tests pass would appreciate if someone would commit this for us. (after fixing the indentation) REPOSITORY R175

D28874: Taiwanese holidays

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. looks good. all tests pass. could someone commit this for us? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz

D28923: Update links in README.md

ndavis added a subscriber: alex-l. ndavis added inline comments. INLINE COMMENTS > ngraham wrote in README.md:22 > Should we mention this? Is it still a thing? It hasn't been used much for quite a while, but I don't think @alex-l would like it if we didn't include it. I'm in there, so at least

D28701: Add KPackage support to KNewStuffCore

leinir added a comment. In D28701#650616 , @ngraham wrote: > Thanks, the hang is gone now. However I have a new problem: > > 1. Open Global Themes KCM and click new new global themes > 2. Install Sweet KDE and McMojave LAF global themes >

D28874: Taiwanese holidays

shrapnel updated this revision to Diff 80415. shrapnel added a comment. Removed patch-file REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28874?vs=80346=80415 REVISION DETAIL https://phabricator.kde.org/D28874 AFFECTED FILES holidays/holidays.qrc

D28923: Update links in README.md

ngraham added inline comments. INLINE COMMENTS > README.md:22 > +- The VDG Telegram room: > +- The Breeze Icons Telegram room: > +- The visual-des...@kde.org mailing list: >

D28701: Add KPackage support to KNewStuffCore

ngraham added a comment. Thanks, the hang is gone now. However I have a new problem: 1. Open Global Themes KCM and click new new global themes 2. Install Sweet KDE and McMojave LAF global themes 3. Close the GHNS dialog 4. Open the dialog again 5. Uninstall the McMojave LAF theme

D28923: Update links in README.md

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY - Change the HIG link to hig.kde.org - Changed the bugtracker link to include the icons

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 420 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/420/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 17 Apr 2020 17:18:42 + Build duration: 3 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/23/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 17 Apr 2020 17:18:42 + Build duration: 2 min 55 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/27/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 17 Apr 2020 17:18:42 + Build duration: 1 min 21 sec and counting JUnit Tests Name:

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80411. apol added a comment. Include the server side and some renames REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80284=80411 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED

D28882: Create protocol to manage video feeds

apol marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28919: Drop delayed second phase

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense, sounds like the second phase is quite arbitrary there. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D28919 To: broulik, #plasma, dfaure, davidedmundson,

D28874: Taiwanese holidays

winterz added a comment. remove holidays/0001-added-holiday_tw_zh-and-updated-holiday.qrc.patch REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28891: Nicaragua Holidays

winterz added inline comments. INLINE COMMENTS > holidays.qrc:101 > plan2/holiday_mx_es > -plan2/holiday_na_en-gb > + plan2/holiday_na_en-gb > plan2/holiday_nc_fr realign the indentation > holidays.qrc:103 > plan2/holiday_nc_fr > +

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

davidedmundson added a comment. > This seems super complicated. It is :D REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28892 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 125 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/125/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 17 Apr 2020 14:02:21 + Build duration: 6 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 17 Apr 2020 14:02:21 + Build duration: 6 min 30 sec and counting JUnit Tests Name:

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

This revision was automatically updated to reflect the committed changes. Closed by commit R127:1b1412943b6b: [autotests] Optimistic attempt to fix RemoteAccessTest reilability (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D28919: Drop delayed second phase

davidedmundson added a comment. > @davidedmundson did some bootchart that showed startup is actually faster without this It was probably just noise as it wasn't a full average of N tests, just 2 clean boots. However ksplash removed 100ms earlier. I can attach if needed. As for the

D28919: Drop delayed second phase

broulik created this revision. broulik added reviewers: Plasma, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY kded runs Phase 0 and Phase 1 on startup and then

D28355: Introduce function ecm_install_configured_file

apol added a comment. Are we stuck somewhere? The patch looks good to me. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28355 To: davidedmundson Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh,

D28128: Add force save behavior to KEntryMap

This revision was automatically updated to reflect the committed changes. Closed by commit R237:be28e096c533: Add force save behavior to KEntryMap (authored by bport). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28128?vs=78861=80383 REVISION DETAIL

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

ahmadsamir added a comment. Though maybe I should add a comment about the action collection, if the kfiledialog ever grows a shortcuts editor dialog, those actions will be missing, and tracking down the issue mightn't be that easy... REPOSITORY R241 KIO REVISION DETAIL

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, nicolasfella. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use new KBookMarkMenu ctor that doesn't take a KActionCollection parameter; AFAICS there's no need

D28909: smb: port to Result system to force serialization of error/finish condition

sitter created this revision. sitter added a reviewer: dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the Result system was originally introduced to the FTP slave and now

D28701: Add KPackage support to KNewStuffCore

leinir added reviewers: broulik, bshah. leinir added a comment. Tagging in a couple of people who were in the original chat about doing this integration... :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks,

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

dfaure added inline comments. INLINE COMMENTS > meven wrote in global.h:323 > I don't think we should assume that, it defeats quite the purpose. > For instance even if we the ioslave gets the filename or type for its needs > it may just not include it in the UDSEntry if StatBasic was not

D28882: Create protocol to manage video feeds

romangg added inline comments. INLINE COMMENTS > screencast.xml:8 > + ]]> > + > + Interface names should be scoped too. Example

D28882: Create protocol to manage video feeds

jgrulich added inline comments. INLINE COMMENTS > screencast.xml:13 > + > + > + Can we switch the values to follow xdg-desktop-portal specification? See

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/22/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 17 Apr 2020 08:17:54 + Build duration: 2 min 43 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 419 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/419/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 17 Apr 2020 08:17:54 + Build duration: 2 min 0 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/26/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 17 Apr 2020 08:17:54 + Build duration: 51 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/21/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 17 Apr 2020 08:03:09 + Build duration: 5 min 21 sec and counting BUILD ARTIFACTS

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

meven requested changes to this revision. meven added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > global.h:323 > StatNoDetails = 0x0, > -/// Filename, access, type, size, linkdest > +/// Filename, access, type, size, linkdest -- necessary for

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 418 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/418/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 17 Apr 2020 08:03:09 + Build duration: 1 min 56 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/25/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 17 Apr 2020 08:03:09 + Build duration: 54 sec and counting JUnit Tests Name:

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. So we are gonna need a patch to baloo-widget stat, with `KIO::StatRecursiveSize` A test would nice for trash:/ with `KIO::StatRecursiveSize` INLINE COMMENTS > trashimpl.cpp:1105 > - > -

D28902: CopyJob: when stat'ing the dest, use StatBasic.

meven added a comment. I believe that's just fine but the comment could be updated : From udsentry.h /// A local file path if the ioslave display files sitting /// on the local filesystem (but in another hierarchy, e.g. settings:/ or remote:/) UDS_LOCAL_PATH So the

D28902: CopyJob: when stat'ing the dest, use StatBasic.

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. This seems super complicated. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D28892 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel,