D29032: Add 16px Vvave icon

2020-04-20 Thread Noah Davis
ndavis added a comment. There is already a newer vvave icon with a different style, but not at 16px. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29032 To: manueljlin, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29033: Remove duplicated code

2020-04-20 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Went through it while reviewing some code. TEST PLAN Been running it for a while, including direct

D29032: Add 16px Vvave icon

2020-04-20 Thread Manuel Jesús de la Fuente
manueljlin created this revision. manueljlin added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. manueljlin requested review of this revision. REVISION SUMMARY This adds a 16px version of the "babe.svg" icon REPOSITORY R266 Breeze Icons

D29018: Align description in metainfo.yaml with the one of README.md

2020-04-20 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R174 KContacts BRANCH fixmetainfodescription REVISION DETAIL https://phabricator.kde.org/D29018 To: kossebau, mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D7563: Add privilegeExecution field to file protocol description

2020-04-20 Thread Alexander Saoutkin
feverfew added a comment. In D7563#653171 , @elvisangelaccio wrote: > In D7563#650117 , @ngraham wrote: > > > [insert I-have-no-idea-what-I'm-doing dog meme here] > > > > When trying to create

D7563: Add privilegeExecution field to file protocol description

2020-04-20 Thread Elvis Angelaccio
elvisangelaccio added a comment. In D7563#650117 , @ngraham wrote: > [insert I-have-no-idea-what-I'm-doing dog meme here] > > When trying to create items in root-owned locations, I'm getting an errors saying "The process for the file protocol

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 12 - Still Unstable!

2020-04-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/12/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 20 Apr 2020 22:00:07 + Build duration: 2 min 41 sec and counting JUnit Tests Name:

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-04-20 Thread David Edmundson
On Thu, Apr 16, 2020 at 10:26 PM David Edmundson wrote: > > > Given Doodle's take forever and everyone's probably quarantined > > anyway, I propose we do it just after the Monday Plasma meeting. If > > someone is eager to share an opinion and can't make that, message here > > and we'll choose

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-04-20 Thread David Edmundson
> > The slight twist on that which we need to be wary of is that client > > code will return shared objects if you request a > > KWaylandClient::PlasmaShellSurface::get(window()) > > for the same window from two places you'll get the same PlasmaShell > > instance returned - and therefore the same

D29027: Move document corner fold to top right in two icons

2020-04-20 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 424 - Still Unstable!

2020-04-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/424/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 20 Apr 2020 21:42:21 + Build duration: 4 min 18 sec and counting BUILD ARTIFACTS

D29027: Move document corner fold to top right in two icons

2020-04-20 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 27 - Still Unstable!

2020-04-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/27/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 20 Apr 2020 21:41:28 + Build duration: 3 min 11 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 423 - Unstable!

2020-04-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/423/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 20 Apr 2020 21:38:17 + Build duration: 4 min 2 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 26 - Unstable!

2020-04-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/26/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 20 Apr 2020 21:38:17 + Build duration: 3 min 10 sec and counting BUILD ARTIFACTS

D28802: Add standard shortcut for "Show/Hide Hidden Files"

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. I pondered that myself but every app needs to implement its own behavior, and we're not even consistent about making this a toggle action vs two separate actions. That alone is probably a good reason to make a standard action, though. REPOSITORY R237 KConfig

D28802: Add standard shortcut for "Show/Hide Hidden Files"

2020-04-20 Thread Elvis Angelaccio
elvisangelaccio added a comment. Does it make sense to also create a standard action in kconfigwidgets? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28802: Add standard shortcut for "Show/Hide Hidden Files"

2020-04-20 Thread Elvis Angelaccio
elvisangelaccio added a comment. > and F8 seems kind of random. I was asking myself why F8 was chosen and yes, it looks like it was totally random: https://github.com/KDE/kdelibs/commit/8e26f7410a9280b504d97cdfbe5d3568cfa7b9d4 REPOSITORY R237 KConfig REVISION DETAIL

D29027: Move document corner fold to top right in two icons

2020-04-20 Thread David Hurka
davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29027: Move document corner fold to top right in two icons

2020-04-20 Thread David Hurka
davidhurka updated this revision to Diff 80707. davidhurka added a comment. - Use Highlight instead of ButtonFocus, Noah already decided that somewhere else REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29027?vs=80702=80707 BRANCH

D29027: Move document corner fold to top right in two icons

2020-04-20 Thread David Hurka
davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28995: Add imperial gallon and US pint

2020-04-20 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R292:be0ef896c3f3: Add imperial gallon and US pint (authored by riiga, committed by ngraham). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE

D28995: Add imperial gallon and US pint

2020-04-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, and sorry for the earlier confusion. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D28995 To: riiga, #frameworks, ngraham Cc: bruns, ngraham,

D29027: Move document corner fold to top right in two icons

2020-04-20 Thread David Hurka
davidhurka retitled this revision from "Move document corner fold to top right in two icons This updates document-close in the sizes below 32px and gnumeric-link-internal to the new style. I forgot them in D28203. gnumeric-link-internal uses ButtonFocus." to "Move document corner fold to top

D29027: Move document corner fold to top right in two iconsThis updates document-close in the sizes below 32px and gnumeric-link-internal to the new style. I forgot them in D28203.gnumeric-link-intern

2020-04-20 Thread David Hurka
davidhurka created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 AFFECTED FILES

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. T13008: Figure out a good UI for the "show which settings have been changed" feature REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport,

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. Let's have the rest of the discussion in a central phab patch, which I probably should have pushed for at the start. I'll make one... REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven,

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Noah Davis
ndavis added a comment. I'm sorry this happened. I was working with what I could see. For what it's worth, I would have accepted it if you said it could not be done well. I know I don't know as much about the technical side of this as you do. REPOSITORY R265 KConfigWidgets REVISION

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Andres Betts
abetts added a comment. My opinion on this patch from the beginning has been that it really doesn't add much more than was there before. Visually, it clutters the UI. The icon selected for it might also not be visually appealing or meaningful enough. I believe there should be a different

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-04-20 Thread Nicolas Fella
nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. nicolasfella added reviewers: Frameworks, Plasma, broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29021 To: nicolasfella, #frameworks, #plasma, broulik

D28995: Add imperial gallon and US pint

2020-04-20 Thread Felix Riiga
riiga updated this revision to Diff 80686. riiga added a comment. Changed to regular unit from common unit. REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28995?vs=80587=80686 REVISION DETAIL https://phabricator.kde.org/D28995 AFFECTED FILES

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-04-20 Thread Nicolas Fella
nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R289 KNotifications BRANCH nofallback2 REVISION DETAIL https://phabricator.kde.org/D29021 AFFECTED FILES

D29020: Add example/test application

2020-04-20 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80685. nicolasfella added a comment. - Add license header REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29020?vs=80684=80685 BRANCH example REVISION DETAIL https://phabricator.kde.org/D29020

D29020: Add example/test application

2020-04-20 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The purpose of this is twofold. It serves as a code

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. Yeah, I'm sorry about that. If VDG people ask for something that's technically impossible, you've gotta push back on that. They often don't know what is and isn't possible, or reasonable. We've been trying to help VDG people be more technical so they don't

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Kevin Ottens
ervin added a comment. You know it started as a proper painted indicator within the widget area, right? As such it couldn't have any of the issues you're pointing out now... Who pushed me to have them at distance I wonder? Right, was people from the VDG. So I find grand that then it goes

D28995: Add imperial gallon and US pint

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. In D28995#652857 , @riiga wrote: > The imperial gallon has limited use in the UK as liters mostly are used these days except for mileage which is in miles per imperial gallon. So I agree that it shouldn't be a common

D29014: Fix the exclusive group box case for default indicators

2020-04-20 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R265:14ecec53296a: Fix the exclusive group box case for default indicators (authored by ervin). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D28701: Add KPackage support to KNewStuffCore

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. Great. There are still a few more bugs though: When you install certain global themes, they ask for authentication so install an SDDM theme. However when you uninstall that theme, it doesn't request authentication to remove them SDDM theme. So

D28882: Create protocol to manage video feeds

2020-04-20 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 80677. apol added a comment. Improve how we initialise the sourceId REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80662=80677 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED

D28780: [FstabWatcher] Fix loosing of fstab watcher

2020-04-20 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28780 To: bruns, #frameworks, ngraham, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28995: Add imperial gallon and US pint

2020-04-20 Thread Felix Riiga
riiga added a comment. The imperial gallon has limited use in the UK as liters mostly are used these days except for mileage which is in miles per imperial gallon. So I agree that it shouldn't be a common unit for volume. @ngraham How widespread is usage of the pint in the US? Does it

D29018: Align description in metainfo.yaml with the one of README.md

2020-04-20 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R174 KContacts BRANCH fixmetainfodescription REVISION DETAIL

D29017: WIP: Introduce three new methods that return all "entries" in a folder

2020-04-20 Thread Ahmad Samir
ahmadsamir added a comment. Todo: port kwalletmanager locally and see if it still works (which isn't saying much as I don't use kwallet that much). I think we can delay this to KF 5.71, to get more testing. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D29017 To:

D28995: Add imperial gallon and US pint

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. Ah, I see. I wonder if it actually makes sense to mark the non-US imperial measurements as common. Are these units still widely used outside of the USA? Speaking as an American where everything is gallons, it will be kind of annoying to see imperial gallons

D28780: [FstabWatcher] Fix loosing of fstab watcher

2020-04-20 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28780 To: bruns, #frameworks, ngraham, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

2020-04-20 Thread Ahmad Samir
ahmadsamir abandoned this revision. ahmadsamir added a comment. Talking with kbroulik on irc confirms your POV, the format of those patterns aren't documented anywhere so changing the matching now would change the behaviour... I'll abandon this, (I suggest that X-Plasma-DropUrlPatterns

D29017: WIP: Introduce three new methods that return all "entries" in a folder

2020-04-20 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY As was discussed in https://phabricator.kde.org/D28880 with dfaure, it seems that all users (only two,

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

2020-04-20 Thread Stefan Brüns
bruns added a comment. Ping! REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28776 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28780: [FstabWatcher] Fix loosing of fstab watcher

2020-04-20 Thread Stefan Brüns
bruns added a reviewer: ngraham. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28780 To: bruns, #frameworks, ngraham Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28780: [FstabWatcher] Fix loosing of fstab watcher

2020-04-20 Thread Stefan Brüns
bruns marked an inline comment as done. bruns added a comment. Ping! REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28780 To: bruns, #frameworks, ngraham Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D7563: Add privilegeExecution field to file protocol description

2020-04-20 Thread Nathaniel Graham
ngraham updated this revision to Diff 80668. ngraham added a comment. Maybe fix a thing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80645=80668 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Nathaniel Graham
ngraham added a subscriber: GB_2. ngraham added a comment. In D27540#652692 , @ervin wrote: > In D27540#652664 , @ngraham wrote: > > > David asked for VDG to approve before this landed, which wasn't

D29014: Fix the exclusive group box case for default indicators

2020-04-20 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D29014 To: ervin, ngraham, davidedmundson, bport, crossi Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28995: Add imperial gallon and US pint

2020-04-20 Thread Felix Riiga
riiga added a comment. In D28995#652764 , @ngraham wrote: > Aren't Imperial and US the same thing?The USA is the only country that still officially uses the imperiaI system. The US uses USC

D28995: Add imperial gallon and US pint

2020-04-20 Thread Stefan Brüns
bruns added a comment. In D28995#652764 , @ngraham wrote: > Aren't Imperial and US the same thing?The USA is the only country that still officially uses the imperiaI system. Every time you use "is the same as" in reference to imperial

D28995: Add imperial gallon and US pint

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. Aren't Imperial and US the same thing?The USA is the only country that still officially uses the imperiaI system. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D28995 To: riiga, #frameworks, ngraham Cc: ngraham,

D29014: Fix the exclusive group box case for default indicators

2020-04-20 Thread Kevin Ottens
ervin updated this revision to Diff 80664. ervin added a comment. Fix misplaced * REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29014?vs=80661=80664 REVISION DETAIL https://phabricator.kde.org/D29014 AFFECTED FILES

D28882: Create protocol to manage video feeds

2020-04-20 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 80662. apol added a comment. Iterate tests (which work now) and uses REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80658=80662 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Kevin Ottens
ervin added a comment. In D27540#652669 , @ngraham wrote: > Finally clicking on the revert button in Spectacle's settings page causes a segfault for me: P590 Spectacle crash backtrace Couldn't quite

D29014: Fix the exclusive group box case for default indicators

2020-04-20 Thread Kevin Ottens
ervin created this revision. ervin added reviewers: ngraham, davidedmundson, bport, crossi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY Turns out there was an oversight here, in case of an

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 24 - Fixed!

2020-04-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/24/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 20 Apr 2020 15:54:40 + Build duration: 2 min 54 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 421 - Fixed!

2020-04-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/421/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 20 Apr 2020 15:54:40 + Build duration: 2 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 28 - Fixed!

2020-04-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/28/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 20 Apr 2020 15:54:39 + Build duration: 1 min 18 sec and counting JUnit Tests Name:

D28882: Create protocol to manage video feeds

2020-04-20 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 80658. apol added a comment. Fix test REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80637=80658 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Kevin Ottens
ervin added a comment. In D27540#652664 , @ngraham wrote: > David asked for VDG to approve before this landed, which wasn't done. Dude, I jumped through all the hoops for the past weeks. Also it got no further reply after I updated the

D29011: Fix variable mixup

2020-04-20 Thread David Redondo
davidre abandoned this revision. davidre added a comment. Oh I diffed the wrong repo... REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29011 To: davidre, #breeze, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29011: Fix variable mixup

2020-04-20 Thread David Redondo
davidre added reviewers: Breeze, Plasma. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29011 To: davidre, #breeze, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29011: Fix variable mixup

2020-04-20 Thread David Redondo
davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Caused icons to be not longer recolored when changing the color scheme until an application is started again TEST

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. I have concerns about this. The button has no tooltip so it's not obvious what will happen when clicked on. It should at least say "Revert to default setting" in a tooltip, and preferably even the name or text of the default setting that will be reverted to.

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. David asked for VDG to approve before this landed, which wasn't done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik Cc: alexde, ndavis, iasensio,

D27840: Introduce SettingState* elements to ease KCM writing

2020-04-20 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R296:24211925f835: Introduce SettingState* elements to ease KCM writing (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=80305=80654

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

2020-04-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 20 Apr 2020 14:35:14 + Build duration: 55 sec and counting JUnit Tests Name:

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

2020-04-20 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R119:dfc144bf3f45: Port desktoptheme, icons and workspace KCMs to SettingStateBinding (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27839: Properly name the content of the kcmcontrols project

2020-04-20 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R296:3501bcbe8da6: Properly name the content of the kcmcontrols project (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27839?vs=76951=80653

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R265:11186c056198: KCModule: Indicate when a setting has been changed from the default or previous… (authored by ervin). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Assuming VDG are happy, go for it. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi,

D27840: Introduce SettingState* elements to ease KCM writing

2020-04-20 Thread David Edmundson
davidedmundson accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

2020-04-20 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27841 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma, #vdg Cc: plasma-devel,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. Heh. That can happen. :) Maybe try again once the adaptive transparency patch has landed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-20 Thread Nathaniel Graham
ngraham added a task: T11925: Breeze Desktop Theme Transparency. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

2020-04-20 Thread Nathaniel Graham
ngraham updated this revision to Diff 80645. ngraham added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80644=80645 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES

D7563: Add privilegeExecution field to file protocol description

2020-04-20 Thread Nathaniel Graham
ngraham updated this revision to Diff 80644. ngraham added a comment. Install auth helper too REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80343=80644 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

2020-04-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 20 Apr 2020 12:35:19 + Build duration: 1 min 17 sec and counting JUnit Tests Name:

D28805: Tweak kcmcontrols docs

2020-04-20 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R296:b8accaad1eda: Tweak kcmcontrols docs (authored by nicolasfella). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28805?vs=80044=80640 REVISION DETAIL

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-20 Thread Niccolò Venerandi
niccolove abandoned this revision. niccolove added a comment. I've tweaked it so many times that I eventually ended up with something that looks almost identical to default without even noticing. I still think there is margin for improvement over the default, but I need to take some more

D28882: Create protocol to manage video feeds

2020-04-20 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 80637. apol added a comment. iterate test REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80605=80637 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D28805: Tweak kcmcontrols docs

2020-04-20 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH tweakdocs REVISION DETAIL https://phabricator.kde.org/D28805 To: nicolasfella, #frameworks, jucato, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

2020-04-20 Thread Ben Cooksley
On Mon, Apr 20, 2020 at 10:29 AM Friedrich W. H. Kossebau wrote: > > Am Sonntag, 19. April 2020, 21:13:01 CEST schrieb Ben Cooksley: > > Hi all, > > > > Another breakage in Qt? > > Should be fixed now (restarted build now completed), with similar traps also > removed for the future, thanks to

D6794: assert the testpackage appstream data validates

2020-04-20 Thread Ben Cooksley
bcooksley added a comment. I've added it in https://invent.kde.org/sysadmin/ci-tooling/commit/cd1eb8d0a91502f8aaf0c7fc402060bd38a3cf25 and have now initiated an image rebuild REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D6794 To: sitter, sebas, apol Cc:

D23926: Move "Details" tab to second place in Properties dialog

2020-04-20 Thread Matej Mrenica
mthw abandoned this revision. mthw added a comment. I don't have the time (nor skill really) to work on this. Feel free to take over if you want to. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc:

D27133: kconfig_compiler : generate kconfig settings with subgroup

2020-04-20 Thread Méven Car
meven accepted this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27133 To: crossi, ervin, dfaure, #frameworks, meven Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22701: [kfileutils] Add isExecutableFile from KRun

2020-04-20 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D22701 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

2020-04-20 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

2020-04-20 Thread Björn Feber
GB_2 added a comment. Ping :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, azyx, dmenig, nikolaik, pberestov, manueljlin,

D28221: Don't write default value to configuration file when default value came from /etc/* file

2020-04-20 Thread Benjamin Port
bport added a comment. Indeed probably need to update configuration too. Not sure why we didn't allow to track default value from file in the past by the way. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28221 To: bport, ervin, dfaure, davidedmundson Cc:

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-20 Thread Niccolò Venerandi
niccolove added a comment. F8248684: Screenshot_20200420_111621.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-20 Thread Niccolò Venerandi
niccolove updated this revision to Diff 80625. niccolove added a comment. Toned down transparency REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28353?vs=78675=80625 BRANCH contrast_and_transparency (branched from master) REVISION

D28221: Don't write default value to configuration file when default value came from /etc/* file

2020-04-20 Thread Benjamin Port
bport updated this revision to Diff 80624. bport added a comment. Add KConfig unittest REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28221?vs=78862=80624 REVISION DETAIL https://phabricator.kde.org/D28221 AFFECTED FILES

D28919: Drop delayed second phase

2020-04-20 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R297:093a673f0e59: Drop delayed second phase (authored by broulik). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28919?vs=80388=80621 REVISION DETAIL

  1   2   >