D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement_interface.cpp:297 > > +void PlasmaWindowManagementInterface::setStackingOrder(const > QVector& stackingOrder) > +{ coding style: whitespace before `&` REPOSITORY R127 KWayland REVISION DETAIL

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Nathaniel Graham
ngraham added a comment. It's okay. :) This is gonna seem like a really dumb question, but which images are the befores and which are the afters? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc:

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Nathaniel Graham
ngraham added a comment. FWIW all the mice in my house have this exact shape, but they're black, not gray. So I don't think the shape is too old-fashioned per se. It's the gray color that's anacrhonistic part, since it's a very 90s/early 2000s color and modern mice tend to be black:

D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

2020-04-22 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R242:25ce2b90dab1: Prefer QIcon::pixmap(QWindow*, ...) overload (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27252: add maui index icon in pm style

2020-04-22 Thread Mathis Brüchert
mbruchert added a reviewer: ndavis. REPOSITORY R266 Breeze Icons BRANCH index (branched from master) REVISION DETAIL https://phabricator.kde.org/D27252 To: mbruchert, camiloh, #vdg, ndavis Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. niccolove added a dependency: D28627: Adaptive panel opacity. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Niccolò Venerandi
niccolove reclaimed this revision. niccolove added a comment. This should've been "Changes planned", not "Abandoned". I'm really feeling sorry for all of the emails. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Niccolò Venerandi
niccolove planned changes to this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 63 - Fixed!

2020-04-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/63/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 22 Apr 2020 20:57:11 + Build duration: 7 min 50 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 71 - Unstable!

2020-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/71/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 22 Apr 2020 20:57:11 + Build duration: 6 min 58 sec and counting JUnit Tests Name:

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Niccolò Venerandi
niccolove edited the summary of this revision. niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh,

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment. > If on the other hand you really like the old mouse icon as well but just want it to work better for dark themes then another option might be to recolour the old icon to get better contrast out of it against the dark background. I tried modifying the

D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

2020-04-22 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Yeah, size is in logical pixels. Multiplying doesn't make sense. I'm sure more high DPI bugs are caused by clients trying to be clever. REPOSITORY R242 Plasma

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Johan Ouwerkerk
ouwerkerk added a comment. In D29095#655060 , @saligari wrote: > > Maybe this is just me but the overall width to height ratio makes it seem that the closest "real" mice are quite dated as well. > > I don't understand what you mean with

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari updated this revision to Diff 80935. saligari added a comment. Added a better border, it does look better like this. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29095?vs=80928=80935 BRANCH input-mouse-patch (branched from master)

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment. > Maybe this is just me but the overall width to height ratio makes it seem that the closest "real" mice are quite dated as well. I don't understand what you mean with this, do you think it should be slimmer? I kind of followed the old one in this, even if it

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Noah Davis
ndavis added a comment. Yes, I agree that the mouse should have fairly realistic and modern proportions. My favorite icons in Breeze are the ones that look pretty realistic while still maintaining the soft gradients and shadows. REPOSITORY R266 Breeze Icons REVISION DETAIL

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Johan Ouwerkerk
ouwerkerk added a comment. One thing I find really striking about the new icon is how closely it resembles stress balls: F8253927: stress-ball-mice.png I kinda like that... :) REPOSITORY R266 Breeze Icons REVISION DETAIL

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Johan Ouwerkerk
ouwerkerk added a comment. Hmm, the old icon also has the virtue of looking more like genuine computer mice: it resembles the logi(tech) style of mouse design quite well. This one is rather abstract while at the same time somehow not looking like any "real" mouse would, in particular in its

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari updated this revision to Diff 80928. saligari added a comment. - Fixed margins - added *some* perspective, I hope it looks better. I don't know if maybe I should add curvature - used inkscape to optimize it - I really have no idea on how to make it less boring REPOSITORY

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment. In D29095#655030 , @ngraham wrote: > Awesome, that's much nicer. > > I think it needs the outline.border to extend up to the top, or else the top of the icon starts to blend in with the default window color:

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Nathaniel Graham
ngraham added a comment. Awesome, that's much nicer. I think it needs the outline.border to extend up to the top, or else the top of the icon starts to blend in with the default window color: F8253868: Screenshot_20200422_124714.png REPOSITORY

D27152: Introduce FilesystemEntry class

2020-04-22 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > hallas wrote in fstabhandling.cpp:374 > @bruns - I am little confused now. You wrote previously that you could see > the point in the `id()` function, but now you want it moved? > What kind of unit test are you missing? I can't quite follow the

D27152: Introduce FilesystemEntry class

2020-04-22 Thread David Hallas
hallas marked an inline comment as done. hallas added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:374 > The `id()` method and members are still part of the FstabEntry, where they do > not belong. > > The UDIs go through some further mangling in

D29065: [KFontChooser] Add a DisplayFlag to allow not showing fixedOnly checkbox

2020-04-22 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfontchooser.h:90 > 1/2/4 looked like powers of 2, i.e. a flag set. > > Using 5 here gives is the same value as FixedFontsOnly | ShowDifferences. > > On the other hand it makes sense FixedFontsOnly would automatically hide the

D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Noah Davis
ndavis added a comment. yes, I agree with @ngraham REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29098 To: saligari, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

2020-04-22 Thread Konrad Materka
kmaterka added a comment. Any other comment? Is it OK and can be approved? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28470 To: kmaterka, #plasma, broulik, apol, davidedmundson Cc: mart, davidre, cblack, kde-frameworks-devel, #plasma,

D29061: [KCharSelect] Minor code optimisation

2020-04-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. ahmadsamir marked an inline comment as done. Closed by commit R236:6a9e93c698b8: [KCharSelect] Minor code optimisation (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D29083: correct vscode icon name

2020-04-22 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R266:d44aa218457b: correct vscode icon name (authored by Guo Yunhe i...@guoyunhe.me). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29083?vs=80838=80916#toc REPOSITORY R266 Breeze Icons

D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

2020-04-22 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R240:ebc874095b4d: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D29083: correct vscode icon name

2020-04-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I suppose anyone using an old version would be on a discrete release distro that wouldn't update breeze icons either. OK, ship it! REPOSITORY R266 Breeze Icons BRANCH master

D29032: Add 16px Vvave icon

2020-04-22 Thread Manuel Jesús de la Fuente
This revision was automatically updated to reflect the committed changes. Closed by commit R266:1315014b521c: Add 16px Vvave icon (authored by manueljlin). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29032?vs=80902=80911 REVISION DETAIL

D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

2020-04-22 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It takes into account the dpi of the screen we're rendering to. Other overloads

D29101: WIP BUG: 420312 Fix file path and process call

2020-04-22 Thread Alexander Lohnau
alex created this revision. alex added reviewers: KNewStuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The bug was caused by two issues:

D29083: correct vscode icon name

2020-04-22 Thread Yunhe Guo
guoyunhe added a comment. The icon was renamed since 2018. Most users should have updated to newer version. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29083 To: guoyunhe, #breeze, cblack, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack,

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29054 To: bport, zzag, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29032: Add 16px Vvave icon

2020-04-22 Thread Manuel Jesús de la Fuente
manueljlin updated this revision to Diff 80902. manueljlin added a comment. Use scour REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29032?vs=80763=80902 BRANCH vvave16px (branched from master) REVISION DETAIL https://phabricator.kde.org/D29032

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread Benjamin Port
bport updated this revision to Diff 80901. bport added a comment. Add missing const ref and fix coding style REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29054?vs=80887=80901 REVISION DETAIL https://phabricator.kde.org/D29054 AFFECTED FILES

D29083: correct vscode icon name

2020-04-22 Thread Nathaniel Graham
ngraham added reviewers: cblack, VDG, ndavis. ngraham added a comment. Could the old one still ever be valid ? Should we maybe add a symlink instead of renaming? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29083 To: guoyunhe, #breeze, cblack, #vdg, ndavis

D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

2020-04-22 Thread Aleix Pol Gonzalez
apol added a comment. +1 makes sense REPOSITORY R240 Extra CMake Modules BRANCH avoidnewwarningsinfindkf5 REVISION DETAIL https://phabricator.kde.org/D29097 To: kossebau, #frameworks, #build_system, cgiboudeaux Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack,

D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Nathaniel Graham
ngraham added a comment. Hmm, now there's a huge empty area on those icons. I think the Plasma logo was visually balancing out the composition a bit. Maybe the Plasma logo itself wasn't appropriate, but it looks like maybe *something* needs to live there in its place, or we need to

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment. In D29095#654825 , @ndavis wrote: > Regarding SVG optimization, the main point of it these days is to make the code easier to read, not to get the smallest size possible. Use the settings on this page for your SVG

D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29098 To: saligari, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29098 To: saligari, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Noah Davis
ndavis added a comment. Regarding SVG optimization, the main point of it these days is to make the code easier to read, not to get the smallest size possible. Use the settings on this page for your SVG optimizer: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips REPOSITORY

D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29098 To: saligari, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari updated this revision to Diff 80898. saligari added a comment. cleaned them and svgcleaned them REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29098?vs=80897=80898 BRANCH remove-kde-logo (branched from master) REVISION DETAIL

D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. saligari requested review of this revision. REVISION SUMMARY I think it is not needed, especially since these icons are usually rather small REPOSITORY R266 Breeze Icons

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Nathaniel Graham
ngraham added a comment. Things I like: - It's lighter and will show up in both light and dark themes - It isn't trying to look like a cool gaming mouse, which always seemed a bit childish to me Things I don't like: - The horizontal line in the center needs some perspective

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari updated this revision to Diff 80889. saligari added a comment. Used svgcleaner to change the icon from 7.3KiB to 1.6KiB REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29095?vs=80882=80889 BRANCH input-mouse-patch (branched from master)

D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-22 Thread Erik Schilling
ablu added a comment. The SYSROOT variable should not (directly) impact that. The install directory is configured by ECM_MKSPECS_INSTALL_DIR, which usually will point to /usr/lib/mkspecs/modules/ on Linux. For a cross-compile toolchain it will however be additionally prefixed with separate

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement.cpp:47 > void windowCreated(org_kde_plasma_window *id, quint32 internalId); > +void setStackingOrder(const QVector& ids); > Coding style: whitespace before `&` and `*` > plasmawindowmanagement_interface.cpp:297 >

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread Benjamin Port
bport updated this revision to Diff 80887. bport added a comment. Increase protocol version and use const ref for QVector parameter REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29054?vs=80784=80887 REVISION DETAIL https://phabricator.kde.org/D29054

D29061: [KCharSelect] Minor code optimisation

2020-04-22 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-general-code-opti (branched from master) REVISION DETAIL https://phabricator.kde.org/D29061 To: ahmadsamir, #frameworks, cfeck, dfaure Cc: kde-frameworks-devel,

D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

2020-04-22 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH avoidnewwarningsinfindkf5 REVISION DETAIL https://phabricator.kde.org/D29097 To: kossebau, #frameworks, #build_system, cgiboudeaux Cc: kde-frameworks-devel,

D29061: [KCharSelect] Minor code optimisation

2020-04-22 Thread Ahmad Samir
ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kcharselectdata.cpp:870 > Shouldn't this be moved to inside the `if (match.hasMatch())` check? Indeed. REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-22 Thread Friedrich W. H. Kossebau
kossebau added a comment. No current clue about qmake, just wondering from my little knowledge: how does having $$[QT_SYSROOT] here influence any QMAKEPATH env var set? Would pri files installed into a custom prefix still be found? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D29061: [KCharSelect] Minor code optimisation

2020-04-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 80886. ahmadsamir added a comment. Only use captured() if there's a match REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29061?vs=80781=80886 BRANCH l-general-code-opti (branched from master) REVISION

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment. Running svgcleaner on this icon turns it from a 7.3 KiB monstrosity to 1.6 KiB beauty. However I don't know how to update this patch :(. The existing icon is something like 7.9KiB but this one is doesn't have that much detail, it shouldn't be such a big file.

D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

2020-04-22 Thread Friedrich W. H. Kossebau
kossebau added a comment. Warning: I have not really investigated in full detail if the current code of FindKF5 is completely sane besides a quick check, more or less assume that it has worked all the time, so the new warning here can be silenced. REPOSITORY R240 Extra CMake Modules

D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

2020-04-22 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, Build System. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN KF modules configure build as before, same

D29017: WIP: Introduce three new methods that return all "entries" in a folder

2020-04-22 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kwallet.cpp:219 > +KSecretsService::ReadItemPropertyJob *readLabelJob = > item->label(); > +if (readLabelJob->exec()) { > +

D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-22 Thread Erik Schilling
ablu created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. ablu requested review of this revision. REVISION SUMMARY If this is not done a cross compilation will attempt to load headers and libs from /usr/

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari edited the test plan for this revision. saligari added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: saligari, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. saligari requested review of this revision. REVISION SUMMARY A very very simple mouse icon, which hopefully adheres to the general HIG. Most colors are borrowed from the

D29065: [KFontChooser] Add a DisplayFlag to allow not showing fixedOnly checkbox

2020-04-22 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfontchooser.h:90 > +ShowDifferences = 4,///< Display the font differences interfaces > +NoFixedOnlyToggle = 5 ///< Show a checkbox to

D29061: [KCharSelect] Minor code optimisation

2020-04-22 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcharselectdata.cpp:870 > +const QRegularExpressionMatch match = hexExp.match(s); > +const QString cap = match.captured(1); > if

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

2020-04-22 Thread David Faure
dfaure accepted this revision. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

2020-04-22 Thread Ahmad Samir
ahmadsamir added a comment. Depends on D29091 . REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D29093 To: ahmadsamir, #frameworks, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

2020-04-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 80880. ahmadsamir retitled this revision from "[NetworkManager-qt] Replace foreach with range for" to "[NetworkManager-qt] Replace foreach with range for, hopefully last pass". ahmadsamir edited the summary of this revision. ahmadsamir removed 1 blocking

D29093: [NetworkManager-qt] Replace foreach with range for

2020-04-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 80879. ahmadsamir added a comment. Get the last ones REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29093?vs=80877=80879 BRANCH l-foreach-4 (branched from master) REVISION DETAIL

D29093: [NetworkManager-qt] Replace foreach with range for

2020-04-22 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, jgrulich. Herald added a project: Frameworks. Herald added 1 blocking reviewer(s): jgrulich. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-4

D29070: add alligator icon

2020-04-22 Thread Andres Betts
abetts added a comment. Look great! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29070 To: mbruchert, tfella, #vdg, ndavis Cc: abetts, ognarb, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29091: [NetworkManager-qt] Replace foreach with range/index for loop, third pass

2020-04-22 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, jgrulich. Herald added a project: Frameworks. Herald added 1 blocking reviewer(s): jgrulich. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-3

D29070: add alligator icon

2020-04-22 Thread Tobias Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R266:9f5f2a060662: add alligator icon (authored by mbruchert, committed by tfella). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29070?vs=80807=80867 REVISION

D29084: Make the HTML file template more useful

2020-04-22 Thread Grzegorz Szymaszek
gszymaszek requested review of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29084 To: gszymaszek, #frameworks, dfaure, ognarb Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28701: Add KPackage support to KNewStuffCore

2020-04-22 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 80862. leinir added a comment. Some documentation and whitespace fixes for Frameworksiness - Fix up a few whitespace errors - Add some documentation to KPackageJob, and a few @since REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D29086: [NetworkManager-qt] Replace foreach with range/index for loop

2020-04-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R282:f0b1c412074a: [NetworkManager-qt] Replace foreach with range/index for loop (authored by ahmadsamir). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D29086: [NetworkManager-qt] Replace foreach with range/index for loop

2020-04-22 Thread Jan Grulich
jgrulich accepted this revision. REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29086 To: ahmadsamir, #frameworks, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29086: [NetworkManager-qt] Replace foreach with range/index for loop

2020-04-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 80860. ahmadsamir added a comment. Some missing ones REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29086?vs=80858=80860 BRANCH l-foreach-2 (branched from master) REVISION DETAIL

D29086: [NetworkManager-qt] Replace foreach with range/index for loop

2020-04-22 Thread Jan Grulich
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29086 To: ahmadsamir, #frameworks, jgrulich Cc: kde-frameworks-devel, LeGast00n,

D29084: Make the HTML file template more useful

2020-04-22 Thread Grzegorz Szymaszek
gszymaszek updated this revision to Diff 80859. gszymaszek added a comment. - Add common HTML elements to the HTML file template REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29084?vs=80853=80859 BRANCH html-file-template (branched from master) REVISION

D29086: [NetworkManager-qt] Replace foreach with range/index for loop

2020-04-22 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, jgrulich. Herald added a project: Frameworks. Herald added 1 blocking reviewer(s): jgrulich. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-2

D29070: add alligator icon

2020-04-22 Thread Mathis Brüchert
mbruchert added a comment. In D29070#654121 , @ngraham wrote: > This is my favorite icon in a very long time. Thank you:) REPOSITORY R266 Breeze Icons BRANCH alligator (branched from master) REVISION DETAIL

D29084: Make the HTML file template more useful

2020-04-22 Thread Carl Schwan
ognarb added a comment. In D29084#654489 , @gszymaszek wrote: > In D29084#654484 , @ognarb wrote: > > > - Don't include

D29084: Make the HTML file template more useful

2020-04-22 Thread Grzegorz Szymaszek
gszymaszek updated this revision to Diff 80853. gszymaszek added a comment. - Remove stylesheets from the HTML file template REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29084?vs=80839=80853 BRANCH html-file-template (branched from master) REVISION

D29084: Make the HTML file template more useful

2020-04-22 Thread Grzegorz Szymaszek
gszymaszek added a comment. In D29084#654484 , @ognarb wrote: > - Don't include

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

2020-04-22 Thread Tobias Junghans
junghans updated this revision to Diff 80852. junghans added a comment. The initial diff was incomplete. This one covers all occurrences of Q_EMIT. REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29003?vs=80610=80852 REVISION DETAIL

D29084: Make the HTML file template more useful

2020-04-22 Thread Carl Schwan
ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. Good idea to improve the default HTML file. Improvement ideas: - Don't include

D28574: KRunner: Improve code snippet

2020-04-22 Thread Alexander Lohnau
This revision was automatically updated to reflect the committed changes. Closed by commit R308:b503fc4578b8: KRunner: Improve code snippet (authored by alex). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28574?vs=79342=80842 REVISION DETAIL

D29084: Make the HTML file template more useful

2020-04-22 Thread Ahmad Samir
ahmadsamir added reviewers: Frameworks, dfaure, ognarb. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29084 To: gszymaszek, #frameworks, dfaure, ognarb Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

2020-04-22 Thread Cyril Rossi
This revision was automatically updated to reflect the committed changes. Closed by commit R237:00213a3a0906: kconfig_compiler : generate kconfig settings with subgroup (authored by crossi). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27133?vs=77426=80841

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

2020-04-22 Thread Friedrich W. H. Kossebau
kossebau added a comment. The failure which triggered this patch is that appstreamcli or one of the things it links to (since recently?) wants to use some gsettings stuff, which it tries to look up in the system via XDG_DATA_DIRS, as found by sitter. See

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

2020-04-22 Thread Pino Toscano
pino added a comment. (Commented in the wrong place) Shouldn't the test completely ignore the system location, to avoid interferences from the system installation? REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D29063 To: kossebau, #frameworks, mart, apol,

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.14 - Build # 6 - Fixed!

2020-04-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.14/6/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 22 Apr 2020 07:05:04 + Build duration: 2 min 19 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

2020-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 22 Apr 2020 07:05:04 + Build duration: 1 min 9 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 97 - Fixed!

2020-04-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/97/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 22 Apr 2020 07:05:04 + Build duration: 1 min 54 sec and counting BUILD ARTIFACTS

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

2020-04-22 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R290:bb560f8dfa0a: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended (authored by kossebau). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE

  1   2   >