D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread Vlad Zahorodnii
zzag added inline comments.

INLINE COMMENTS

> plasmawindowmanagement_interface.cpp:297
>  
> +void PlasmaWindowManagementInterface::setStackingOrder(const 
> QVector& stackingOrder)
> +{

coding style: whitespace before `&`

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29054

To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Nathaniel Graham
ngraham added a comment.


  It's okay. :)
  
  This is gonna seem like a really dumb question, but which images are the 
befores and which are the afters?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Nathaniel Graham
ngraham added a comment.


  FWIW all the mice in my house have this exact shape, but they're black, not 
gray. So I don't think the shape is too old-fashioned per se. It's the gray 
color that's anacrhonistic part,  since it's a very 90s/early 2000s color and 
modern mice tend to be black: F8254746: Screenshot_20200422_210145.png 

  
  However that dark color causes visibility problems that this new icon is 
fixing. Maybe you could use the same color that's used in the joystick/gaming 
controller icon? That's sort of dark enough to connote darkness while not being 
darn enough to cause visibility issues.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

2020-04-22 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:25ce2b90dab1: Prefer QIcon::pixmap(QWindow*, ...) 
overload (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29102?vs=80908=80945

REVISION DETAIL
  https://phabricator.kde.org/D29102

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/windowthumbnail.cpp

To: apol, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns


D27252: add maui index icon in pm style

2020-04-22 Thread Mathis Brüchert
mbruchert added a reviewer: ndavis.

REPOSITORY
  R266 Breeze Icons

BRANCH
  index (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27252

To: mbruchert, camiloh, #vdg, ndavis
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Niccolò Venerandi
niccolove edited the test plan for this revision.
niccolove added a dependency: D28627: Adaptive panel opacity.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns


D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Niccolò Venerandi
niccolove reclaimed this revision.
niccolove added a comment.


  This should've been "Changes planned", not "Abandoned". I'm really feeling 
sorry for all of the emails.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns


D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Niccolò Venerandi
niccolove planned changes to this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns


D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Niccolò Venerandi
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns


D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Niccolò Venerandi
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns


KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 63 - Fixed!

2020-04-22 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/63/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Wed, 22 Apr 2020 20:57:11 +
 Build duration:
7 min 50 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34946/62172)40%
(17729/43938)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9812/10281)46%
(4569/9884)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(101/115)88%
(101/115)59%
(8492/14316)51%
(4465/8698)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4690/8343)43%
(2077/4822)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(425/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 71 - Unstable!

2020-04-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/71/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Wed, 22 Apr 2020 20:57:11 +
 Build duration:
6 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-22 Thread Niccolò Venerandi
niccolove edited the summary of this revision.
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment.


  >   If on the other hand you really like the old mouse icon as well but just 
want it to work better for dark themes then another option might be to recolour 
the old icon to get better contrast out of it against the dark background.
  
  I tried modifying the existing icon but the results were horrible. I gave up 
on modifying and made this really simple one. Turns out modifying something 
sounds easier than it is. Or maybe that's because I don't really know how to 
use inkscape
  
  ¯\_ (ツ) _/¯

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

2020-04-22 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Yeah, size is in logical pixels.  Multiplying doesn't make sense.
  
  I'm sure more high DPI bugs are caused by clients trying to be clever.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29102

To: apol, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Johan Ouwerkerk
ouwerkerk added a comment.


  In D29095#655060 , @saligari wrote:
  
  > > Maybe this is just me but the overall width to height ratio makes it seem 
that the closest "real" mice are quite dated as well.
  >
  > I don't understand what you mean with this, do you think it should be 
slimmer? I kind of followed the old one in this, even if it doesn't seem like 
it. Right now its ratio is ~0,67 while microsoft's standard old mouse is kind 
of close to that (but has a different shape)
  
  
  Right but that shape makes quite a bit of difference here -- especially since 
real mouse design is *all about* shape. You'll also note that the actual mouse 
you took for inspiration has a much more pronounced "hump" (as many modern mice 
do).
  
  > I don't think an icon for its place needs side buttons, fast scrolling 
buttons etc. Being kind of abstract, simple and out of the way I think is a 
plus in its case.
  
  That is an artistic choice.
  
  > The ergonomic mouse shape/ especially existing icon's left side is really 
cool, but unfortunately I don't have the skills to make something like this (I 
hardly know how to use inkscape). I think it takes a lot of skill to be able to 
create something realistic but also manage to strike a balance and I don't even 
have a little skill.
  
  Rght, I wouldn't have much of a clue either on how to make *any* icon. (It's 
just a lot easier to criticise than it is to create...) If on the other hand 
you really like the old mouse icon as well but just want it to work better for 
dark themes then another option might be to recolour the old icon to get better 
contrast out of it against the dark background.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari updated this revision to Diff 80935.
saligari added a comment.


  Added a better border, it does look better like this.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29095?vs=80928=80935

BRANCH
  input-mouse-patch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29095

AFFECTED FILES
  icons-dark/devices/64/input-mouse.svg
  icons/devices/64/input-mouse.svg

To: saligari, #vdg
Cc: ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment.


  > Maybe this is just me but the overall width to height ratio makes it seem 
that the closest "real" mice are quite dated as well.
  
  I don't understand what you mean with this, do you think it should be 
slimmer? I kind of followed the old one in this, even if it doesn't seem like 
it. Right now its ratio is ~0,67 while microsoft's standard old mouse is kind 
of close to that (but has a different shape)
  
  I don't think an icon for its place needs side buttons, fast scrolling 
buttons etc. Being kind of abstract, simple and out of the way I think is a 
plus in its case.
  
  The ergonomic mouse shape/ especially existing icon's left side is really 
cool, but unfortunately I don't have the skills to make something like this (I 
hardly know how to use inkscape). I think it takes a lot of skill to be able to 
create something realistic but also manage to strike a balance and I don't even 
have a little skill.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Noah Davis
ndavis added a comment.


  Yes, I agree that the mouse should have fairly realistic and modern 
proportions. My favorite icons in Breeze are the ones that look pretty 
realistic while still maintaining the soft gradients and shadows.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Johan Ouwerkerk
ouwerkerk added a comment.


  One thing I find really striking about the new icon is how closely it 
resembles stress balls:
  
  F8253927: stress-ball-mice.png 
  
  I kinda like that... :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Johan Ouwerkerk
ouwerkerk added a comment.


  Hmm, the old icon also has the virtue of looking more like genuine computer 
mice: it resembles the logi(tech) style of mouse design quite well. This one is 
rather abstract while at the same time somehow not looking like any "real" 
mouse would, in particular in its outline: it misses all the traits of mouse 
design that would make it more ergonomic or smaller. Maybe this is just me but 
the overall width to height ratio makes it seem that the closest "real" mice 
are quite dated as well.
  
  F8253896: so-many-mice.png 
  
  This may be deliberate, but if you complain about it being boring you might 
want to mimic existing mice design a bit closer. For example: why not ditch 
white (which is also a trait of many elderly/ancient mice) and go with a 
different colour (bright colours are quite popular for laptop mice).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari updated this revision to Diff 80928.
saligari added a comment.


  - Fixed margins
  - added *some* perspective, I hope it looks better. I don't know if maybe I 
should add curvature
  - used inkscape to optimize it
  - I really have no idea on how to make it less boring

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29095?vs=80889=80928

BRANCH
  input-mouse-patch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29095

AFFECTED FILES
  icons-dark/devices/64/input-mouse.svg
  icons/devices/64/input-mouse.svg

To: saligari, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment.


  In D29095#655030 , @ngraham wrote:
  
  > Awesome, that's much nicer.
  >
  > I think it needs the outline.border to extend up to the top, or else the 
top of the icon starts to blend in with the default window color: F8253868: 
Screenshot_20200422_124714.png 
  
  
  erm, that was kind of intentional, I'll give it a go but I'm not sure about a 
border extending up to the top

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Nathaniel Graham
ngraham added a comment.


  Awesome, that's much nicer.
  
  I think it needs the outline.border to extend up to the top, or else the top 
of the icon starts to blend in with the default window color: F8253868: 
Screenshot_20200422_124714.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D27152: Introduce FilesystemEntry class

2020-04-22 Thread Stefan Brüns
bruns added inline comments.

INLINE COMMENTS

> hallas wrote in fstabhandling.cpp:374
> @bruns - I am little confused now. You wrote previously that you could see 
> the point in the `id()` function, but now you want it moved? 
> What kind of unit test are you missing? I can't quite follow the added 
> mangling in `FstabHandling::deviceList()`? I don't think we have (or ever 
> have) had any unit test of FstabHandling, but that was one of the things I am 
> trying to achieve was this patch series that breaks up and decouples the code 
> pieces into smaller bits.
> 
> Could I ask you to take a look at it again? Sorry for nagging, I just really 
> want to close this up soon and move on with the next patches ;D

I never said anything like that. "here" == fstabhandling.cpp

The name is exported by deviceList(), after mangling it. Thats the reason any 
further processing should go there, not into fstentry, but that is matter for 
another patch.

The code should be be split up, but the splitting should be done at the right 
places.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27152

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D27152: Introduce FilesystemEntry class

2020-04-22 Thread David Hallas
hallas marked an inline comment as done.
hallas added inline comments.

INLINE COMMENTS

> bruns wrote in fstabhandling.cpp:374
> The `id()` method and members are still part of the FstabEntry, where they do 
> not belong.
> 
> The UDIs go through some further mangling in `FstabHandling::deviceList()`, 
> which should be covered by the unit-tests as well.
> 
> Conceptually, the 
> `_k_deviceNameForMountpoint`/`_k_deviceNameForFilesystemEntry` should be part 
> of the m_mtabCache/m_fstabCache class (which currently is just a 
> `QMultiHash<>`). This class can then be unit tested easily.
> 
> For now, keep the `_k_deviceNameForMountpoint` inside fstabhandling.cpp

@bruns - I am little confused now. You wrote previously that you could see the 
point in the `id()` function, but now you want it moved? 
What kind of unit test are you missing? I can't quite follow the added mangling 
in `FstabHandling::deviceList()`? I don't think we have (or ever have) had any 
unit test of FstabHandling, but that was one of the things I am trying to 
achieve was this patch series that breaks up and decouples the code pieces into 
smaller bits.

Could I ask you to take a look at it again? Sorry for nagging, I just really 
want to close this up soon and move on with the next patches ;D

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27152

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29065: [KFontChooser] Add a DisplayFlag to allow not showing fixedOnly checkbox

2020-04-22 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kfontchooser.h:90
> 1/2/4 looked like powers of 2, i.e. a flag set.
> 
> Using 5 here gives is the same value as FixedFontsOnly | ShowDifferences.
> 
> On the other hand it makes sense FixedFontsOnly would automatically hide the 
> checkbox, no? If the app says "fixed fonts only", the user has no choice in 
> the matter.
> 
> I'm also confused by the name "No[...]Toggle" and the docu saying this will 
> show a checkbox. Something's off by "not" ;)
> Sounds wrong?

> 1/2/4 looked like powers of 2, i.e. a flag set.
>  Using 5 here gives is the same value as FixedFontsOnly | ShowDifferences.

I missed the fact that combining two or more flags would give the same value... 
will fix.

> On the other hand it makes sense FixedFontsOnly would automatically hide the 
> checkbox, no? If the app says "fixed fonts only", the user has no choice in 
> the matter.

Yeah, that makes sense (a special case is Konsole, which embeds KFontChooser 
and adds a checkbox to "show all fonts", IIRC this is to offer users a way out 
with some mis-configured fonts... etc).

> I'm also confused by the name "No[...]Toggle" and the docu saying this will 
> show a checkbox. Something's off by "not" ;)
>  Sounds wrong?

I wrote the enum docs, _then_ changed the name of the member to 
NoFixedOnlyToggle (this way apps can set it if they want but it doesn't have to 
be set by default, i.e. we always show the box unless told otherwise). So yeah 
off by "Do not".

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29065

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Noah Davis
ndavis added a comment.


  yes, I agree with @ngraham

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29098

To: saligari, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D28470: [PlasmaCore.IconItem] Refactor source handling for different types

2020-04-22 Thread Konrad Materka
kmaterka added a comment.


  Any other comment? Is it OK and can be approved?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: mart, davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, michaelh, 
ngraham, bruns


D29061: [KCharSelect] Minor code optimisation

2020-04-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
ahmadsamir marked an inline comment as done.
Closed by commit R236:6a9e93c698b8: [KCharSelect] Minor code optimisation 
(authored by ahmadsamir).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29061?vs=80886=80917

REVISION DETAIL
  https://phabricator.kde.org/D29061

AFFECTED FILES
  CMakeLists.txt
  src/kcharselectdata.cpp

To: ahmadsamir, #frameworks, cfeck, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29083: correct vscode icon name

2020-04-22 Thread Phabricator
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:d44aa218457b: correct vscode icon name (authored by Guo 
Yunhe i...@guoyunhe.me).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29083?vs=80838=80916#toc

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29083?vs=80838=80916

REVISION DETAIL
  https://phabricator.kde.org/D29083

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons-dark/apps/48/code.svg
  icons-dark/apps/48/com.visualstudio.code.oss.svg
  icons-dark/apps/48/com.visualstudio.code.svg
  icons/apps/48/code-oss.svg
  icons/apps/48/code.svg
  icons/apps/48/com.visualstudio.code.oss.svg
  icons/apps/48/com.visualstudio.code.svg

To: guoyunhe, #breeze, cblack, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

2020-04-22 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:ebc874095b4d: Adapt FindKF5 to stricter checks in newer 
find_package_handle_standard_args (authored by kossebau).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29097?vs=80884=80914

REVISION DETAIL
  https://phabricator.kde.org/D29097

AFFECTED FILES
  find-modules/FindKF5.cmake

To: kossebau, #frameworks, #build_system, cgiboudeaux
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns


D29083: correct vscode icon name

2020-04-22 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I suppose anyone using an old version would be on a discrete release distro 
that wouldn't update breeze icons either. OK, ship it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29083

To: guoyunhe, #breeze, cblack, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29032: Add 16px Vvave icon

2020-04-22 Thread Manuel Jesús de la Fuente
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:1315014b521c: Add 16px Vvave icon (authored by 
manueljlin).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29032?vs=80902=80911

REVISION DETAIL
  https://phabricator.kde.org/D29032

AFFECTED FILES
  icons-dark/apps/16/vvave.svg
  icons/apps/16/vvave.svg

To: manueljlin, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

2020-04-22 Thread Aleix Pol Gonzalez
apol created this revision.
apol added reviewers: Plasma, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  It takes into account the dpi of the screen we're rendering to.
  Other overloads assume the window is nullptr and will use the primary 
screen's dpi which can change almost randomly.

TEST PLAN
  Icons still look fine even if I drag windows from a screen to another.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29102

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/windowthumbnail.cpp

To: apol, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29101: WIP BUG: 420312 Fix file path and process call

2020-04-22 Thread Alexander Lohnau
alex created this revision.
alex added reviewers: KNewStuff, ngraham, nicolasfella, elvisangelaccio, meven, 
mlaurent.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alex requested review of this revision.

REVISION SUMMARY
  The bug was caused by two issues: The file path that was stored was wrong, 
for example:
  Old paths:
  
/home/user/.local/share/servicemenu-download//rootactions_servicemenu_2.9.1.tar.gz
  New paths:
  /home/user/.local/share/servicemenu-download/iso_mounter_unmounter.desktop
  
  Additionally the overload for the process call always fails, for example:
  `qWarning() << QProcess::execute("echo \"Hello there!\""); // Works
  qWarning() << QProcess::execute("echo",{"\"Hello there!\""}); // Works
  qWarning() << QProcess::execute("echo \"Hello there!\"",{}); // Fails, 
returns -2`/
  
  As in 
https://phabricator.kde.org/R304:9322aaf990dd0500a81914d9f69183293cc08a58 
explained 
  QProcess::execute(QString) is deprecated, should KShell be used?
  And should this be split up, because it is unrelated to the other change?

TEST PLAN
  Try out what was described in bug report

REPOSITORY
  R304 KNewStuff

BRANCH
  bugfix_uninstall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29101

AFFECTED FILES
  src/core/installation.cpp

To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29083: correct vscode icon name

2020-04-22 Thread Yunhe Guo
guoyunhe added a comment.


  The icon was renamed since 2018. Most users should have updated to newer 
version.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29083

To: guoyunhe, #breeze, cblack, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29054

To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29032: Add 16px Vvave icon

2020-04-22 Thread Manuel Jesús de la Fuente
manueljlin updated this revision to Diff 80902.
manueljlin added a comment.


  Use scour

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29032?vs=80763=80902

BRANCH
  vvave16px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29032

AFFECTED FILES
  icons-dark/apps/16/vvave.svg
  icons/apps/16/vvave.svg

To: manueljlin, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread Benjamin Port
bport updated this revision to Diff 80901.
bport added a comment.


  Add missing const ref and fix coding style

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29054?vs=80887=80901

REVISION DETAIL
  https://phabricator.kde.org/D29054

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29083: correct vscode icon name

2020-04-22 Thread Nathaniel Graham
ngraham added reviewers: cblack, VDG, ndavis.
ngraham added a comment.


  Could the old one still ever be valid ? Should we maybe add a symlink instead 
of renaming?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29083

To: guoyunhe, #breeze, cblack, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

2020-04-22 Thread Aleix Pol Gonzalez
apol added a comment.


  +1 makes sense

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  avoidnewwarningsinfindkf5

REVISION DETAIL
  https://phabricator.kde.org/D29097

To: kossebau, #frameworks, #build_system, cgiboudeaux
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns


D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Nathaniel Graham
ngraham added a comment.


  Hmm, now there's a huge empty area on those icons. I think the Plasma logo 
was visually balancing out the composition a bit. Maybe the Plasma logo itself 
wasn't appropriate, but it looks like maybe *something* needs to live there in 
its place, or we need to re-arrange things a bit.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29098

To: saligari, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment.


  In D29095#654825 , @ndavis wrote:
  
  > Regarding SVG optimization, the main point of it these days is to make the 
code easier to read, not to get the smallest size possible. Use the settings on 
this page for your SVG optimizer: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips
  
  
  Dang it! I did it to another proposal as well before I read this comment. 
Will look into it.
  
  I will look how to add perspective and correct the margins!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29098

To: saligari, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29098

To: saligari, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Noah Davis
ndavis added a comment.


  Regarding SVG optimization, the main point of it these days is to make the 
code easier to read, not to get the smallest size possible. Use the settings on 
this page for your SVG optimizer: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29098

To: saligari, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari updated this revision to Diff 80898.
saligari added a comment.


  cleaned them and svgcleaned them

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29098?vs=80897=80898

BRANCH
  remove-kde-logo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29098

AFFECTED FILES
  icons-dark/devices/64/media-flash-memory-stick.svg
  icons-dark/devices/64/media-flash-sd-mmc.svg
  icons/devices/64/media-flash-memory-stick.svg
  icons/devices/64/media-flash-sd-mmc.svg

To: saligari
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
saligari requested review of this revision.

REVISION SUMMARY
  I think it is not needed, especially since these icons are usually rather 
small

REPOSITORY
  R266 Breeze Icons

BRANCH
  remove-kde-logo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29098

AFFECTED FILES
  icons-dark/devices/64/media-flash-memory-stick.svg
  icons-dark/devices/64/media-flash-sd-mmc.svg
  icons/devices/64/media-flash-memory-stick.svg
  icons/devices/64/media-flash-sd-mmc.svg

To: saligari
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Nathaniel Graham
ngraham added a comment.


  Things I like:
  
  - It's lighter and will show up in both light and dark themes
  - It isn't trying to look like a cool gaming mouse, which always seemed a bit 
childish to me
  
  Things I don't like:
  
  - The horizontal line in the center needs some perspective so the mouse 
doesn't look totally flat
  - It's maybe a bit "boring" looking, but I guess that's the point, right? Not 
sure what we could do to spice it up a bit without looking silly like the 
current icon
  - The margins aren't right; follow 
https://hig.kde.org/style/icons/colorful/category_preferences.html

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari updated this revision to Diff 80889.
saligari added a comment.


  Used svgcleaner to change the icon from 7.3KiB to 1.6KiB

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29095?vs=80882=80889

BRANCH
  input-mouse-patch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29095

AFFECTED FILES
  icons-dark/devices/64/input-mouse.svg
  icons/devices/64/input-mouse.svg

To: saligari, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-22 Thread Erik Schilling
ablu added a comment.


  The SYSROOT variable should not (directly) impact that. The install directory 
is configured by ECM_MKSPECS_INSTALL_DIR, which usually will point to 
/usr/lib/mkspecs/modules/ on Linux. For a cross-compile toolchain it will 
however be additionally prefixed with separate path. But Qt and qmake will also 
be configured with that prefix so those know to lookup the mkspecs dir under 
that prefix. Issuing QT +=  can then trigger the including of the 
include and lib paths from the .pri generated by this code. So the case I am 
trying to fix with this patch is the case where the .pri is found (so 
ECM_MKSPECS_INSTALL_DIR was specified correctly) but now the libs and include 
paths are pointing to /usr/{include,lib} and not to 
/usr/{include,lib}. Now since  can 
differ depending on the installation dir of the tool chain it may not be 
possible to know that path during compile / install time. However, we can 
assume that Qt / qmake will know about the sysroot (which is the prefix 
essentially). So as long qmake is configured for the cross compile our Qt 
module now should be too.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29096

To: ablu
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
bencreasy, michaelh, ngraham, bruns


D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread Vlad Zahorodnii
zzag added inline comments.

INLINE COMMENTS

> plasmawindowmanagement.cpp:47
>  void windowCreated(org_kde_plasma_window *id, quint32 internalId);
> +void setStackingOrder(const QVector& ids);
>  

Coding style: whitespace before `&` and `*`

> plasmawindowmanagement_interface.cpp:297
>  
> +void PlasmaWindowManagementInterface::setStackingOrder(QVector 
> stackingOrder)
> +{

const ref

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29054

To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread Benjamin Port
bport updated this revision to Diff 80887.
bport added a comment.


  Increase protocol version and use const ref for QVector parameter

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29054?vs=80784=80887

REVISION DETAIL
  https://phabricator.kde.org/D29054

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29061: [KCharSelect] Minor code optimisation

2020-04-22 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-general-code-opti (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29061

To: ahmadsamir, #frameworks, cfeck, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

2020-04-22 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  avoidnewwarningsinfindkf5

REVISION DETAIL
  https://phabricator.kde.org/D29097

To: kossebau, #frameworks, #build_system, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns


D29061: [KCharSelect] Minor code optimisation

2020-04-22 Thread Ahmad Samir
ahmadsamir marked an inline comment as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kcharselectdata.cpp:870
> Shouldn't this be moved to inside the `if (match.hasMatch())` check?

Indeed.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29061

To: ahmadsamir, #frameworks, cfeck, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-22 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  No current clue about qmake, just wondering from my little knowledge:
  how does having $$[QT_SYSROOT] here influence any QMAKEPATH env var set? 
Would pri files installed into a custom prefix still be found?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29096

To: ablu
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
bencreasy, michaelh, ngraham, bruns


D29061: [KCharSelect] Minor code optimisation

2020-04-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 80886.
ahmadsamir added a comment.


  Only use captured() if there's a match

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29061?vs=80781=80886

BRANCH
  l-general-code-opti (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29061

AFFECTED FILES
  CMakeLists.txt
  src/kcharselectdata.cpp

To: ahmadsamir, #frameworks, cfeck, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment.


  Running svgcleaner on this icon turns it from a 7.3 KiB monstrosity to 1.6 
KiB beauty. However I don't know how to update this patch :(.
  
  The existing icon is something like 7.9KiB but this one is doesn't have that 
much detail, it shouldn't be such a big file.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

2020-04-22 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  Warning: I have not really investigated in full detail if the current code of 
FindKF5 is completely sane besides a quick check, more or less assume that it 
has worked all the time, so the new warning here can be silenced.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29097

To: kossebau, #frameworks, #build_system
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns


D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

2020-04-22 Thread Friedrich W. H. Kossebau
kossebau created this revision.
kossebau added reviewers: Frameworks, Build System.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
kossebau requested review of this revision.

TEST PLAN
  KF modules configure build as before, same some apps.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  avoidnewwarningsinfindkf5

REVISION DETAIL
  https://phabricator.kde.org/D29097

AFFECTED FILES
  find-modules/FindKF5.cmake

To: kossebau, #frameworks, #build_system
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns


D29017: WIP: Introduce three new methods that return all "entries" in a folder

2020-04-22 Thread David Faure
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kwallet.cpp:219
> +KSecretsService::ReadItemPropertyJob *readLabelJob = 
> item->label();
> +if (readLabelJob->exec()) {
> +const QString label = 
> readLabelJob->propertyValue().toString();

Urgh. This actually calls for async API instead.

But now I'm really confused. HAVE_KSECRETSSERVICE is never set anywhere (except 
to 0), how does one even compile this code?

> kwallet.h:382
> + * is the entry key.
> + *  @return Returns 0 on success, non-zero on error.
> + *

Are there documented error codes somewhere? Otherwise a bool would do be more 
readable, no?

But then if we don't have error codes, wouldn't

  QMap entriesList()

be better?

> kwalletbackend.cc:558
> +const EntryMap  = _entries[_folder];
> +rc.append(map.values());
> +

`rc = map.values()`, append() makes little sense if it's empty.

> kwalletbackend.h:140
> +// Get a list of all the entries in the current folder.
> +// You delete the list.
> +// @since 5.70

This makes no sense. The list is a value. Does this mean "The caller takes 
ownership of the entries"?

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D29017

To: ahmadsamir, #frameworks, dfaure
Cc: blaze, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-22 Thread Erik Schilling
ablu created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
ablu requested review of this revision.

REVISION SUMMARY
  If this is not done a cross compilation will attempt to load headers and
  libs from /usr/ usually, even if the lib is part of the crosscompile's
  sysroot directory.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  pri-sysroot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29096

AFFECTED FILES
  modules/ECMGeneratePriFile.cmake

To: ablu
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari edited the test plan for this revision.
saligari added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
saligari requested review of this revision.

REVISION SUMMARY
  A very very simple mouse icon, which hopefully adheres to the general HIG. 
Most colors are borrowed from the keyboard icon for consistency and the wheel 
is taken from the previous icon but rounded.

REPOSITORY
  R266 Breeze Icons

BRANCH
  input-mouse-patch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29095

AFFECTED FILES
  icons-dark/devices/64/input-mouse.svg
  icons/devices/64/input-mouse.svg

To: saligari
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29065: [KFontChooser] Add a DisplayFlag to allow not showing fixedOnly checkbox

2020-04-22 Thread David Faure
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfontchooser.h:90
> +ShowDifferences = 4,///< Display the font differences interfaces
> +NoFixedOnlyToggle = 5   ///< Show a checkbox to toggle showing only 
> fixed fonts
>  };

1/2/4 looked like powers of 2, i.e. a flag set.

Using 5 here gives is the same value as FixedFontsOnly | ShowDifferences.

On the other hand it makes sense FixedFontsOnly would automatically hide the 
checkbox, no? If the app says "fixed fonts only", the user has no choice in the 
matter.

I'm also confused by the name "No[...]Toggle" and the docu saying this will 
show a checkbox. Something's off by "not" ;)
Sounds wrong?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29065

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29061: [KCharSelect] Minor code optimisation

2020-04-22 Thread David Faure
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcharselectdata.cpp:870
> +const QRegularExpressionMatch match = hexExp.match(s);
> +const QString cap = match.captured(1);
>  if (match.hasMatch()) {

Shouldn't this be moved to inside the `if (match.hasMatch())` check?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29061

To: ahmadsamir, #frameworks, cfeck, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

2020-04-22 Thread David Faure
dfaure accepted this revision.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D29003

To: junghans, kossebau, dfaure, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

2020-04-22 Thread Ahmad Samir
ahmadsamir added a comment.


  Depends on D29091 .

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D29093

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

2020-04-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 80880.
ahmadsamir retitled this revision from "[NetworkManager-qt] Replace foreach 
with range for" to "[NetworkManager-qt] Replace foreach with range for, 
hopefully last pass".
ahmadsamir edited the summary of this revision.
ahmadsamir removed 1 blocking reviewer(s): jgrulich.
ahmadsamir added a comment.
Herald added 1 blocking reviewer(s): jgrulich.


  Verbatim

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29093?vs=80879=80880

BRANCH
  l-foreach-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29093

AFFECTED FILES
  CMakeLists.txt
  examples/createconnection/main.cpp
  examples/main.cpp
  src/settings/connectionsettings.cpp
  src/settings/dcbsetting.cpp
  src/settings/security8021xsetting.cpp
  src/settings/tcsetting.cpp
  src/settings/wirelesssecuritysetting.cpp
  src/utils.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29093: [NetworkManager-qt] Replace foreach with range for

2020-04-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 80879.
ahmadsamir added a comment.


  Get the last ones

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29093?vs=80877=80879

BRANCH
  l-foreach-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29093

AFFECTED FILES
  CMakeLists.txt
  examples/createconnection/main.cpp
  examples/main.cpp
  src/settings/connectionsettings.cpp
  src/settings/dcbsetting.cpp
  src/settings/security8021xsetting.cpp
  src/settings/tcsetting.cpp
  src/settings/wirelesssecuritysetting.cpp
  src/utils.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29093: [NetworkManager-qt] Replace foreach with range for

2020-04-22 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, jgrulich.
Herald added a project: Frameworks.
Herald added 1 blocking reviewer(s): jgrulich.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29093

AFFECTED FILES
  src/settings/connectionsettings.cpp
  src/settings/dcbsetting.cpp
  src/settings/security8021xsetting.cpp
  src/settings/tcsetting.cpp
  src/settings/wirelesssecuritysetting.cpp
  src/utils.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29070: add alligator icon

2020-04-22 Thread Andres Betts
abetts added a comment.


  Look great!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29070

To: mbruchert, tfella, #vdg, ndavis
Cc: abetts, ognarb, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns


D29091: [NetworkManager-qt] Replace foreach with range/index for loop, third pass

2020-04-22 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, jgrulich.
Herald added a project: Frameworks.
Herald added 1 blocking reviewer(s): jgrulich.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29091

AFFECTED FILES
  src/settings/ipv6setting.cpp
  src/settings/teamportsetting.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29070: add alligator icon

2020-04-22 Thread Tobias Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:9f5f2a060662: add alligator icon (authored by mbruchert, 
committed by tfella).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29070?vs=80807=80867

REVISION DETAIL
  https://phabricator.kde.org/D29070

AFFECTED FILES
  icons-dark/apps/48/alligator.svg
  icons/apps/48/alligator.svg

To: mbruchert, tfella, #vdg, ndavis
Cc: ognarb, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29084: Make the HTML file template more useful

2020-04-22 Thread Grzegorz Szymaszek
gszymaszek requested review of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29084

To: gszymaszek, #frameworks, dfaure, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28701: Add KPackage support to KNewStuffCore

2020-04-22 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 80862.
leinir added a comment.


  Some documentation and whitespace fixes for Frameworksiness
  
  - Fix up a few whitespace errors
  - Add some documentation to KPackageJob, and a few @since

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28701?vs=80617=80862

BRANCH
  add-kpackage-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28701

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/cache.cpp
  src/core/cache.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/installation.cpp
  src/core/installation.h
  src/core/jobs/kpackagejob.cpp
  src/core/jobs/kpackagejob.h
  src/downloaddialog.h

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29086: [NetworkManager-qt] Replace foreach with range/index for loop

2020-04-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:f0b1c412074a: [NetworkManager-qt] Replace foreach with 
range/index for loop (authored by ahmadsamir).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29086?vs=80860=80861

REVISION DETAIL
  https://phabricator.kde.org/D29086

AFFECTED FILES
  src/activeconnection.cpp
  src/device.cpp
  src/dnsconfiguration.cpp
  src/fakenetwork/fakenetwork.cpp
  src/fakenetwork/settings.cpp
  src/fakenetwork/wirelessdevice.cpp
  src/settings.cpp
  src/wirelessnetwork.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29086: [NetworkManager-qt] Replace foreach with range/index for loop

2020-04-22 Thread Jan Grulich
jgrulich accepted this revision.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29086

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29086: [NetworkManager-qt] Replace foreach with range/index for loop

2020-04-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 80860.
ahmadsamir added a comment.


  Some missing ones

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29086?vs=80858=80860

BRANCH
  l-foreach-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29086

AFFECTED FILES
  src/activeconnection.cpp
  src/device.cpp
  src/dnsconfiguration.cpp
  src/fakenetwork/fakenetwork.cpp
  src/fakenetwork/settings.cpp
  src/fakenetwork/wirelessdevice.cpp
  src/settings.cpp
  src/wirelessnetwork.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29086: [NetworkManager-qt] Replace foreach with range/index for loop

2020-04-22 Thread Jan Grulich
jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29086

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29084: Make the HTML file template more useful

2020-04-22 Thread Grzegorz Szymaszek
gszymaszek updated this revision to Diff 80859.
gszymaszek added a comment.


  - Add common HTML elements to the HTML file template

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29084?vs=80853=80859

BRANCH
  html-file-template (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29084

AFFECTED FILES
  src/new_file_templates/HTMLFile.html

To: gszymaszek, #frameworks, dfaure, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29086: [NetworkManager-qt] Replace foreach with range/index for loop

2020-04-22 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, jgrulich.
Herald added a project: Frameworks.
Herald added 1 blocking reviewer(s): jgrulich.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29086

AFFECTED FILES
  src/activeconnection.cpp
  src/device.cpp
  src/dnsconfiguration.cpp
  src/fakenetwork/fakenetwork.cpp
  src/fakenetwork/settings.cpp
  src/settings.cpp
  src/wirelessnetwork.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29070: add alligator icon

2020-04-22 Thread Mathis Brüchert
mbruchert added a comment.


  In D29070#654121 , @ngraham wrote:
  
  > This is my favorite icon in a very long time.
  
  
  Thank you:)

REPOSITORY
  R266 Breeze Icons

BRANCH
  alligator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29070

To: mbruchert, tfella, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29084: Make the HTML file template more useful

2020-04-22 Thread Carl Schwan
ognarb added a comment.


  In D29084#654489 , @gszymaszek 
wrote:
  
  > In D29084#654484 , @ognarb wrote:
  >
  > > - Don't include 

D29084: Make the HTML file template more useful

2020-04-22 Thread Grzegorz Szymaszek
gszymaszek updated this revision to Diff 80853.
gszymaszek added a comment.


  - Remove stylesheets from the HTML file template

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29084?vs=80839=80853

BRANCH
  html-file-template (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29084

AFFECTED FILES
  src/new_file_templates/HTMLFile.html

To: gszymaszek, #frameworks, dfaure, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29084: Make the HTML file template more useful

2020-04-22 Thread Grzegorz Szymaszek
gszymaszek added a comment.


  In D29084#654484 , @ognarb wrote:
  
  > - Don't include 

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

2020-04-22 Thread Tobias Junghans
junghans updated this revision to Diff 80852.
junghans added a comment.


  The initial diff was incomplete. This one covers all occurrences of Q_EMIT.

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29003?vs=80610=80852

REVISION DETAIL
  https://phabricator.kde.org/D29003

AFFECTED FILES
  CMakeLists.txt
  autotests/proxymodeltestsuite/dynamictreemodel.cpp
  src/core/kcheckableproxymodel.cpp
  src/core/kconcatenaterowsproxymodel.cpp
  src/core/kdescendantsproxymodel.cpp
  src/core/kextracolumnsproxymodel.cpp
  src/core/knumbermodel.cpp
  src/core/kselectionproxymodel.cpp
  tests/proxymodeltestapp/kreparentingproxymodel.cpp
  tests/proxymodeltestapp/lessthanwidget.cpp

To: junghans, kossebau, dfaure, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29084: Make the HTML file template more useful

2020-04-22 Thread Carl Schwan
ognarb accepted this revision.
ognarb added a comment.
This revision is now accepted and ready to land.


  Good idea to improve the default HTML file.
  
  Improvement ideas:
  
  - Don't include 

D28574: KRunner: Improve code snippet

2020-04-22 Thread Alexander Lohnau
This revision was automatically updated to reflect the committed changes.
Closed by commit R308:b503fc4578b8: KRunner: Improve code snippet (authored by 
alex).

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28574?vs=79342=80842

REVISION DETAIL
  https://phabricator.kde.org/D28574

AFFECTED FILES
  src/abstractrunner.h

To: alex, #plasma, davidedmundson, broulik, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29084: Make the HTML file template more useful

2020-04-22 Thread Ahmad Samir
ahmadsamir added reviewers: Frameworks, dfaure, ognarb.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29084

To: gszymaszek, #frameworks, dfaure, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D27133: kconfig_compiler : generate kconfig settings with subgroup

2020-04-22 Thread Cyril Rossi
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:00213a3a0906: kconfig_compiler : generate kconfig 
settings with subgroup (authored by crossi).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=77426=80841

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd

To: crossi, ervin, dfaure, #frameworks, meven
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

2020-04-22 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  The failure which triggered this patch is that appstreamcli or one of the 
things it links to (since recently?) wants to use some gsettings stuff, which 
it tries to look up in the system via XDG_DATA_DIRS, as found by sitter.
  See 
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/96/testReport/projectroot/autotests/testpackage_appstream/
  
  The old code tried to still make any existing XDG_DATA_DIRS content used, 
just in a broken way. Which this patch fixes. Or: I do not take further 
responsibilities :P
  If that setup is broken/questionable by design, could be possible, did not 
investigate that, leaving to the actual kpackage maintainers/experts.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D29063

To: kossebau, #frameworks, mart, apol, sitter, bcooksley
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

2020-04-22 Thread Pino Toscano
pino added a comment.


  (Commented in the wrong place)
  
  Shouldn't the test completely ignore the system location, to avoid 
interferences from the system installation?

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D29063

To: kossebau, #frameworks, mart, apol, sitter, bcooksley
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.14 - Build # 6 - Fixed!

2020-04-22 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.14/6/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Wed, 22 Apr 2020 07:05:04 +
 Build duration:
2 min 19 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.70.0.xmlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)74%
(1641/2230)51%
(1035/2022)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(529/531)48%
(212/442)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(567/763)63%
(532/843)src.kpackage.private100%
(7/7)100%
(7/7)80%
(304/382)47%
(94/199)src.kpackagetool100%
(3/3)100%
(3/3)42%
(227/536)36%
(190/526)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

2020-04-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/6/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Wed, 22 Apr 2020 07:05:04 +
 Build duration:
1 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 97 - Fixed!

2020-04-22 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/97/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 22 Apr 2020 07:05:04 +
 Build duration:
1 min 54 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.70.0.xmlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)74%
(1641/2230)51%
(1035/2022)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(529/531)48%
(212/442)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(567/763)63%
(532/843)src.kpackage.private100%
(7/7)100%
(7/7)80%
(304/382)47%
(94/199)src.kpackagetool100%
(3/3)100%
(3/3)42%
(227/536)36%
(190/526)

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

2020-04-22 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:bb560f8dfa0a: Fix testpackage-appstream: XDG_DATA_DIRS 
needs to be explicitly extended (authored by kossebau).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29063?vs=80787=80840

REVISION DETAIL
  https://phabricator.kde.org/D29063

AFFECTED FILES
  autotests/CMakeLists.txt

To: kossebau, #frameworks, mart, apol, sitter, bcooksley
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


  1   2   >