D29079: android: include the architecture on the apk name

This revision was automatically updated to reflect the committed changes. Closed by commit R240:fca97c036c8d: android: include the architecture on the apk name (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29079?vs=80829=81480

D29258: Don't use notifybysnore.h on MSYS2

vonreth requested changes to this revision. vonreth added a comment. This revision now requires changes to proceed. Well the code is header only, so gcc can use it too. Everything needed is to pull in a binary, that's not ideal but I guess its better than no notifications on Windows.

D22554: Finer No-Dbus on Windows

brute4s99 abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

brute4s99 added a comment. closing this diff. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29258: Don't use notifybysnore.h on MSYS2

brute4s99 added a comment. > SnoreToast fails to build on MSYS2 due to missing > which apparently is not available for this compiler. I'm sorry, missing what exactly? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29258 To: wojnilowicz, broulik,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 187 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/187/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 28 Apr 2020 21:26:13 + Build duration: 4 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 15 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/15/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 28 Apr 2020 21:26:13 + Build duration: 4 min 30 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/14/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 28 Apr 2020 21:26:13 + Build duration: 2 min 8 sec and counting JUnit Tests Name:

D29269: Consistently use knotify-config.h to pass in flags about Canberra/Phonon

This revision was automatically updated to reflect the committed changes. Closed by commit R305:e2a22b0f0c62: Consistently use knotify-config.h to pass in flags about Canberra/Phonon (authored by kossebau). REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE

D29269: Consistently use knotify-config.h to pass in flags about Canberra/Phonon

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R305 KNotifyConfig BRANCH useconsistentlyconfigfile REVISION DETAIL https://phabricator.kde.org/D29269 To: kossebau, #frameworks, broulik, nicolasfella Cc: kde-frameworks-devel, LeGast00n,

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in CMakeLists.txt:56 > This breaks builds with CMake 3.5 - 3.7, as `$` was only added for CMake > 3.8. > > See what the official minimum required CMake version 3.5 allows here: >

D29079: android: include the architecture on the apk name

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D29079 To: apol, #android, #frameworks, nicolasfella Cc: vkrause, kde-frameworks-devel, kde-buildsystem,

D29123: Do not mark entry as uninstalled if uninstallation script failed

alex updated this revision to Diff 81476. alex added a comment. Display more technical information in error message REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29123?vs=81076=81476 BRANCH arcpatch-D29123 REVISION DETAIL

D29251: API dox: use ulong typedef with Q_PROPERTY(percent) to avoid doxygen bug

kossebau added a comment. In D29251#659376 , @dfaure wrote: > Yes indeed, for sure "int" would be enough. So okay if I add a "// KF6 TODO: make int" behind the Q_PROPERTY(percent) at the end of the line? REPOSITORY R244 KCoreAddons

D29269: Consistently use knotify-config.h to pass in flags about Canberra/Phonon

kossebau updated this revision to Diff 81475. kossebau added a comment. use consistently Canberra_FOUND REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29269?vs=81474=81475 BRANCH useconsistentlyconfigfile REVISION DETAIL

D29269: Consistently use knotify-config.h to pass in flags about Canberra/Phonon

kossebau created this revision. kossebau added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R305 KNotifyConfig BRANCH useconsistentlyconfigfile REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/13/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 28 Apr 2020 19:55:25 + Build duration: 1 min 44 sec and counting JUnit Tests Name:

D29251: API dox: use ulong typedef with Q_PROPERTY(percent) to avoid doxygen bug

This revision was automatically updated to reflect the committed changes. Closed by commit R244:9e76c0bbdec4: API dox: use ulong typedef with Q_PROPERTY(percent) to avoid doxygen bug (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 79 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/79/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 28 Apr 2020 19:44:57 + Build duration: 6 min 4 sec and counting JUnit Tests Name:

D29251: API dox: use ulong typedef with Q_PROPERTY(percent) to avoid doxygen bug

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yes indeed, for sure "int" would be enough. REPOSITORY R244 KCoreAddons BRANCH fixkjobpercentdocs REVISION DETAIL https://phabricator.kde.org/D29251 To: kossebau, #frameworks,

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure added inline comments. INLINE COMMENTS > broulik wrote in applicationlauncherjob.cpp:155 > With this it starts to look as hard to follow as KRun :) Not even close :-) (OpenUrlJob will be more complicated, somewhere in between this one and KRun...) REPOSITORY R241 KIO BRANCH

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f0ae038490e6: Move handling of untrusted programs to ApplicationLauncherJob. (authored by dfaure). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29153?vs=81173=81472

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 54 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/54/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 28 Apr 2020 19:35:57 + Build duration: 1 min 25 sec and counting JUnit Tests Name:

D29101: KNewStuff: Fix file path and process call

alex updated this revision to Diff 81467. alex added a comment. Get program in exclusive line And should this go to release/20.04? REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29101?vs=81062=81467 BRANCH arcpatch-D29101 REVISION DETAIL

D29256: [server] Introduce mapped() signal

zzag marked an inline comment as done. REPOSITORY R127 KWayland BRANCH introduce-mapped-signal REVISION DETAIL https://phabricator.kde.org/D29256 To: zzag, #kwin, davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29256: [server] Introduce mapped() signal

zzag added inline comments. INLINE COMMENTS > apol wrote in surface_interface.cpp:333 > I don't understand, ^ and != are logically equivalent, ^ is the bitwise > counterpart. > > Am I missing something? Oh, I thought you suggested to do `source->buffer != target->buffer`. REPOSITORY R127

D29256: [server] Introduce mapped() signal

zzag updated this revision to Diff 81456. zzag marked 2 inline comments as done. zzag added a comment. Use != REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29256?vs=81453=81456 BRANCH introduce-mapped-signal REVISION DETAIL

D29256: [server] Introduce mapped() signal

apol added inline comments. INLINE COMMENTS > zzag wrote in surface_interface.cpp:333 > We can't use != because mapped() will be emitted each time a new buffer is > attached to the surface. I don't understand, ^ and != are logically equivalent, ^ is the bitwise counterpart. Am I missing

D29256: [server] Introduce mapped() signal

zzag added inline comments. INLINE COMMENTS > apol wrote in surface_interface.cpp:333 > Using != would probably be more readable and accurate (we're don't need it to > be bitwise, we're assuming bool changes it to 1 or 0). We can't use != because mapped() will be emitted each time a

D29256: [server] Introduce mapped() signal

zzag updated this revision to Diff 81453. zzag added a comment. Check whether the attached buffer flip-flopped between non-null and null only when bufferChanged is true. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29256?vs=81432=81453 BRANCH

D29256: [server] Introduce mapped() signal

apol added a comment. +1 INLINE COMMENTS > surface_interface.cpp:333 > const bool childrenChanged = source->childrenChanged; > +const bool visibilityChanged = bool(source->buffer) ^ > bool(target->buffer); > bool sizeChanged = false; Using != would probably be more readable

D29259: Missed a date on previous update

sionescu created this revision. sionescu created this object with edit policy "Subscribers". Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sionescu requested review of this revision. REVISION SUMMARY Modified the day for Ziua mamei from may 8 to may 3,

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-srt-to-dest (branched from master) REVISION DETAIL https://phabricator.kde.org/D29254 To: ahmadsamir, #frameworks, dfaure, meven, ngraham Cc: ngraham, kde-frameworks-devel,

D28093: [breeze-icons] add TeamViewer tray icons

davidre added a comment. Couldn't we put the tray icon in the plasma theme? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28093 To: rocka, #vdg, ngraham, ndavis Cc: davidre, IlyaBizyaev, ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29258: Don't use notifybysnore.h on MSYS2

wojnilowicz created this revision. wojnilowicz added reviewers: broulik, brute4s99. wojnilowicz added a project: Frameworks. wojnilowicz requested review of this revision. REVISION SUMMARY SnoreToast fails to build on MSYS2 due to missing which apparently is not available for this compiler.

D28093: [breeze-icons] add TeamViewer tray icons

ngraham added a comment. Oh gosh, Can confirm. :/ Now we have two icons with different casing: `teamviewer` (colorful, app icon) and `TeamViewer` (monochrome, tray icon). I guess the app uses the same icon name for its tray icon as its main icon (b) and also KIconLoader isn't

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ahmadsamir added a comment. I meant it worked with Arabic, the direction was the same, just the text is translated, so the renamedialog and dolphin aren't RTL AFAICS. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29254 To: ahmadsamir, #frameworks, dfaure, meven Cc:

D29163: RFC: Add document-replace icon (Like for Overwrite action)

ngraham added a comment. Personally I like the design. All rules are flexible; if the guideline to leave 1px of space is getting in the way, feel free to ignore if it the result looks better. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29163 To:

D29027: Move document corner fold to top right in two icons

ngraham added a comment. Shipit! REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ngraham added a comment. Maybe this helps for RTL? https://doc.qt.io/qt-5.9/qtwidgets-tools-i18n-mainwindow-cpp.html INLINE COMMENTS > renamedialog.cpp:302 > +const int size = d->m_srcPreview->height(); > +const QPixmap pix = >

Re: Information regarding upcoming Gitlab Migration

Um, guys… Google is your friend... I am a former KDE Games developer. I play KPatience quite a lot, as well as other games to keep my brain active, especially during COVID-19 lockdown. Recently I thought I could see where the answer lay to three bugs in the solver(s), two in the Forty Eight

Re: Information regarding upcoming Gitlab Migration

There are a whole bunch of considerations and use-cases being discussed at once in this thread, and Leinir's post made me think a bit about different actors can interact with "the collection of repositories". One actor is "tooling", as Albert has pointed out. Whatever the resulting structure

Re: Information regarding upcoming Gitlab Migration

On Monday, 27 April 2020 21:25:09 BST Albert Astals Cid wrote: > El dilluns, 27 d’abril de 2020, a les 13:58:02 CEST, Bhushan Shah va escriure: > > In part I am mostly re-iterating what Ben already mentioned in different > > messages. > > > > On Mon, Apr 27, 2020 at 12:38:42PM +0200, Aleix Pol

Re: Splitting KWayland

That is what I imagined. The protocols section contains some things we can strip down. We shouldn't host anything that's in wayland-protocols like text-input. Also I think there's some dead things like plasma-effects. But we can do that sort of thing anytime before the first release. David

Re: Splitting KWayland

On Mon, Apr 27, 2020 at 2:57 PM Aleix Pol wrote: > > Hi, > As discussed in the meeting last week, I've been looking into the split. > > Here's what I was thinking of, please tell me if there's something > massively important I'm missing. > > The idea would be to start working on it after kwayland

D29256: [server] Introduce mapped() signal

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH introduce-mapped-signal REVISION DETAIL https://phabricator.kde.org/D29256 To: zzag, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29101: KNewStuff: Fix file path and process call

anthonyfieroni added inline comments. INLINE COMMENTS > installation.cpp:610 > +QStringList args = KShell::splitArgs(command); > +int exitcode = QProcess::execute(args.takeFirst(), args); > Get program in exclusive line auto program = args.takeFirst(); int

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ahmadsamir added a comment. I tried with Arabic, and the rename dialog had some Arabic text, but the layout was still LTR (can it switch to RTL?). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29254 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel,

D29256: [server] Introduce mapped() signal

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY In KWin, we need to know when a sub-surface becomes mapped or unmapped so we can generate or

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ahmadsamir edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29254 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This adds a visual indication to show the direction of the copy/move..etc operation pointing from source

D29251: API dox: use ulong typedef with Q_PROPERTY(percent) to avoid doxygen bug

kossebau added a comment. Given `unsigned long` is 32 bit on some systems and 64 bit on others, perhaps this should also get a KF6 TODO to use a different type. 32 bit might be enough in general for the percent value, no? REPOSITORY R244 KCoreAddons REVISION DETAIL

D29251: API dox: use ulong typedef with Q_PROPERTY(percent) to avoid doxygen bug

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY See https://github.com/doxygen/doxygen/issues/7734 REPOSITORY R244

Re: Information regarding upcoming Gitlab Migration

Hi Adriaan, On Tue, Apr 28, 2020 at 01:08:33PM +0200, Adriaan de Groot wrote: > A tool-like actor that I don't think has been mentioned so far is "existing > checkouts". I have a src/kde with all the bits I've looked at "recently". > There may even be some SVN checkouts there -- I'm willing to

Re: Information regarding upcoming Gitlab Migration

On Tue, Apr 28, 2020 at 11:09 PM Adriaan de Groot wrote: > > There are a whole bunch of considerations and use-cases being discussed at > once in this thread, and Leinir's post made me think a bit about different > actors can interact with "the collection of repositories". > > One actor is

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

filipf added a comment. LGTM REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

Re: KF 5 & C++14?

On Monday, 27 April 2020 14:53:32 CEST Friedrich W. H. Kossebau wrote: > Am Montag, 27. April 2020, 00:45:41 CEST schrieb David Faure: > > On Sunday, April 26, 2020 5:30:37 PM CEST Friedrich W. H. Kossebau wrote: > > > Hi, > > > > > > I just saw that at least kimageformats, knewstuff &

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > applicationlauncherjob.cpp:155 > +} > +proceedAfterSecurityChecks(); > +} With this it starts to look as hard to follow as KRun :) REPOSITORY R241 KIO

D28624: Print a warning if runner is incompatible with KRunner

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Would be lovely if we could get this date parsing into `QVersionNumber` of `KFormat`, I'm seeing similar code also in kscreenlocker, kwin, libksysguard, ... REPOSITORY R308 KRunner

D29232: [WIP][RFC]Introduce the Header color set

mart added inline comments. INLINE COMMENTS > davidre wrote in kcolorscheme.cpp:271 > Because the new colors are the replacement for theses colors. I thought one > of those might map to this i also added a question on the task, whether final colors are decided for it, they should go up here

D28701: Add KPackage support to KNewStuffCore

leinir added a comment. Ping team framework and such? (i realise we're all a tiny bit more stressy than usual...) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, broulik, bshah

D29101: KNewStuff: Fix file path and process call

leinir accepted this revision as: leinir. leinir added a comment. This revision is now accepted and ready to land. That's well spotted. Thanks for taking that one on :) REPOSITORY R304 KNewStuff BRANCH bugfix_uninstall (branched from master) REVISION DETAIL

Re: Splitting KWayland

On Tue, 28 Apr 2020, 07:24 Vlad Zahorodnii, wrote: > On 4/27/20 4:12 PM, David Edmundson wrote: > > I don't think we want to remove client or server tests on this one. As > > the client tests covered the server side too > > Hmm, does this mean we are going to keep both the client and the server

D29222: Fix update auto selection

leinir updated this revision to Diff 81412. leinir added a comment. Thanks @ngraham, learn me to add debug information and then forget to commit it :P - Compile... REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29222?vs=81318=81412 BRANCH

D28093: [breeze-icons] add TeamViewer tray icons

IlyaBizyaev added a comment. When I updated my parents' PC, they lost the TeamViewer desktop icon because it became monochrome. Confirmed locally, the TeamViewer icon in the Dashboard menu is also monochrome. This does not happen to the recently introduced Flameshot icon, so what's the

D29232: [WIP][RFC]Introduce the Header color set

davidre added inline comments. INLINE COMMENTS > ndavis wrote in kcolorscheme.cpp:271 > Why is that? The only one that might is Active, but that's not really used > much right now. Because the new colors are the replacement for theses colors. I thought one of those might map to this

Re: Splitting KWayland

On 4/27/20 4:12 PM, David Edmundson wrote: I don't think we want to remove client or server tests on this one. As the client tests covered the server side too Hmm, does this mean we are going to keep both the client and the server side in KWaylandServer? Cheers, Vlad