D29050: WIP KRunner fix prepare/teardown signals

alex added a comment. > Adding a test would be the best way to demonstrate the issue and the fix. I debugged this and the debugger said that the `matchSessionComplete` method got called somewhere from QML, but I don't know from where. I also know only basic QML and the way the QML

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 4:38 PM Nate Graham wrote: > > > > On 4/30/20 5:59 PM, Aleix Pol wrote: > > El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid > >> Am I the only person that just has all the repos on the same folder? I > >> thought it was the common thing to do :? > > > > I do

Re: Information regarding upcoming Gitlab Migration

On Fri, May 1, 2020 at 2:46 AM Nate Graham wrote: > > If I'm understanding things, we have solutions to most or all of the > objections raised so far: > > - Projects will be allowed to live in--or at least appear in--multiple > top-level groups (e.g. plasma-framework could appear in both the >

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 1:08 AM Nicolás Alvarez wrote: > > El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid > (aa...@kde.org) escribió: > > > > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va > > escriure: > > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > >

Re: Information regarding upcoming Gitlab Migration: clarifications

El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid (aa...@kde.org) escribió: > > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure: > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > > > We have made a big fuss in the past about having different

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. In D29299#660620 , @pino wrote: > In D29299#660614 , @kossebau wrote: > > > One does not need to define KDE_INSTALL_LOCALEDIR oneself. One only needs to use

Re: Information regarding upcoming Gitlab Migration: clarifications

On 4/30/20 11:43 AM, Aleix Pol wrote: IMHO needing tools ad-hoc to KDE development can be a barrier of entrance. I feel like these things make us look distant, it's important that people's skills translate automatically when they want to get started. True, but if you're a new contributor,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 80 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/80/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 30 Apr 2020 21:11:23 + Build duration: 17 min and counting JUnit Tests Name: projectroot

2 new repositories: plasma-wayland-protocols and kwayland-server

Hi everyone, After long discussions, we have broken kwayland into 3 pieces so we can work and improve kwin_wayland without having to extend our stable framework constantly. This of course comes together with an updated policy with regards to where things should be developed with the goal of only

Re: Information regarding upcoming Gitlab Migration: clarifications

El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure: > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > We have made a big fuss in the past about having different projects > > > that do the same thing and now we'll have that but also we'll have > > > several

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

kmaterka added a comment. Regression fixed in D29314 . REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28470 To: kmaterka, #plasma, broulik, apol, davidedmundson, #frameworks Cc: ngraham, mart, davidre, cblack,

D29314: [PlasmaCore.IconItem] Regression: fix crash on source change

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4b0d4c4bdaed: [PlasmaCore.IconItem] Regression: fix crash on source change (authored by kmaterka). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D29314: [PlasmaCore.IconItem] Regression: fix crash on source change

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. This also fixes another crash I was seeing with the ExpandableListItem applets. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

D29314: [PlasmaCore.IconItem] Regression: fix crash on source change

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29314 To: kmaterka, #plasma, #frameworks, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29314: [PlasmaCore.IconItem] Regression: fix crash on source change

kmaterka edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29314 To: kmaterka, #plasma, #frameworks, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29314: [PlasmaCore.IconItem] Regression: fix crash on source change

kmaterka edited the summary of this revision. kmaterka edited the test plan for this revision. kmaterka added a reviewer: davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29314 To: kmaterka, #plasma, #frameworks, ngraham, davidedmundson

D29314: [PlasmaCore.IconItem] Regression: fix crash on source change

kmaterka created this revision. kmaterka added reviewers: Plasma, Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kmaterka requested review of this revision. REVISION SUMMARY When SvgSource is changed, old one is deleted. Connections are

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ahmadsamir edited the summary of this revision. REPOSITORY R241 KIO BRANCH l-srt-to-dest (branched from master) REVISION DETAIL https://phabricator.kde.org/D29254 To: ahmadsamir, #frameworks, dfaure, meven, ngraham, #dolphin Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ahmadsamir updated this revision to Diff 81628. ahmadsamir edited the summary of this revision. ahmadsamir added a reviewer: Dolphin. ahmadsamir removed subscribers: safaalfulaij, hpereiradacosta, pino, ngraham. ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ahmadsamir updated this revision to Diff 81627. ahmadsamir added a comment. Take RTL layout into consideration when setting the arrow icon by using qApp->isRightToLeft() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29254?vs=81492=81627 BRANCH

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 5:58 AM Nate Graham wrote: > > > > On 4/30/20 11:43 AM, Aleix Pol wrote: > > IMHO needing tools ad-hoc to KDE development can be a barrier of entrance. > > I feel like these things make us look distant, it's important that > > people's skills translate automatically when

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > We have made a big fuss in the past about having different projects > > that do the same thing and now we'll have that but also we'll have > > several projects with the same name? > > It really feels off to me and I wonder if this is related

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 5:44 AM Aleix Pol wrote: > > On Wed, Apr 29, 2020 at 12:25 PM Bhushan Shah wrote: > > > > Good afternoon, > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > replies] > > > > I want to clarify some bits for which we have gotten a questions about,

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ahmadsamir added a comment. OK, thank you :) I'll adjust the diff accordingly. REPOSITORY R241 KIO BRANCH l-srt-to-dest (branched from master) REVISION DETAIL https://phabricator.kde.org/D29254 To: ahmadsamir, #frameworks, dfaure, meven, ngraham Cc: safaalfulaij,

D29175: DBus Runner: Add service property to request actions once

alex updated this revision to Diff 81623. alex added a comment. Create test REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29175?vs=81165=81623 BRANCH request_actions_once (branched from master) REVISION DETAIL https://phabricator.kde.org/D29175

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

safaalfulaij added inline comments. INLINE COMMENTS > ahmadsamir wrote in renamedialog.cpp:299 > @pino, right; dolphin isn't rtl-aware (or if it is, I couldn't find out how > to switch it to rtl). But I agree the code here should account for rtl anyway. > > @ngraham: I think we should stick to

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

hpereiradacosta added inline comments. INLINE COMMENTS > hpereiradacosta wrote in renamedialog.cpp:299 > dolphin --reverse > should run it in right-to-left mode > (or whatever the opposite of your current locale) you can use qApp->isRightToLeft() to check the rtl direction REPOSITORY R241

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

pino added inline comments. INLINE COMMENTS > ahmadsamir wrote in renamedialog.cpp:299 > @pino, right; dolphin isn't rtl-aware (or if it is, I couldn't find out how > to switch it to rtl). But I agree the code here should account for rtl anyway. > > @ngraham: I think we should stick to the

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

hpereiradacosta added inline comments. INLINE COMMENTS > ahmadsamir wrote in renamedialog.cpp:299 > @pino, right; dolphin isn't rtl-aware (or if it is, I couldn't find out how > to switch it to rtl). But I agree the code here should account for rtl anyway. > > @ngraham: I think we should stick

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. In D29299#660614 , @kossebau wrote: > In D29299#660519 , @pino wrote: > > > In D29299#660505 , @kossebau wrote: > > > > > Because

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > pino wrote in renamedialog.cpp:299 > this is not right-to-left aware; please use the layout direction of the > widget to use "go-next" or "go-previous" @pino, right; dolphin isn't rtl-aware (or if

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. In D29299#660519 , @pino wrote: > In D29299#660505 , @kossebau wrote: > > > Because people do strange things, and I prefer to rather not break their card house unless

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ngraham added inline comments. INLINE COMMENTS > pino wrote in renamedialog.cpp:299 > this is not right-to-left aware; please use the layout direction of the > widget to use "go-next" or "go-previous" (`go-next-rtl-symbolic`, not `go-previous`; that would be semantically inaccurate.)

Re: Information regarding upcoming Gitlab Migration: clarifications

> We have made a big fuss in the past about having different projects > that do the same thing and now we'll have that but also we'll have > several projects with the same name? > It really feels off to me and I wonder if this is related to the move to > gitlab. +1 to both sentiments - that

Re: Information regarding upcoming Gitlab Migration: clarifications

On Wed, Apr 29, 2020 at 12:25 PM Bhushan Shah wrote: > > Good afternoon, > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > replies] > > I want to clarify some bits for which we have gotten a questions about, > > - Non unique naming: There's some teams which prefer if we

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

ngraham added a comment. No worries, it happens to the best of us. :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28470 To: kmaterka, #plasma, broulik, apol, davidedmundson, #frameworks Cc: ngraham, mart, davidre, cblack, kde-frameworks-devel,

Re: Information regarding upcoming Gitlab Migration

If I'm understanding things, we have solutions to most or all of the objections raised so far: - Projects will be allowed to live in--or at least appear in--multiple top-level groups (e.g. plasma-framework could appear in both the Frameworks top-level group and also the Plasma top-level

Re: changing icon sizes no longer emits signal

On dimanche 26 avril 2020 14:24:27 CEST David Faure wrote: > On Saturday, April 25, 2020 4:54:43 PM CEST Friedrich W. H. Kossebau wrote: > > Am Samstag, 25. April 2020, 15:10:37 CEST schrieb Martin Koller: > > > Hi, > > > > > > in liquidshell I'm using > > > > > >

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. In D29299#660505 , @kossebau wrote: > Because people do strange things, and I prefer to rather not break their card house unless necessary. Again, in which cases? The only way it might change the path is: use ki18n

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. Because people do strange things, and I prefer to rather not break their card house unless necessary. Only looking at the undeprecated variable second should be fine, no? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau,

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

kmaterka added a comment. In D28470#660492 , @ngraham wrote: > `git bisect` says this caused https://bugs.kde.org/show_bug.cgi?id=420801. I will check that, sorry... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. In D29299#660490 , @kossebau wrote: > D29136 in the current version though changes behaviour by favouring KDE_INSTALL_LOCALEDIR over LOCALE_INSTALL_DIR. Which at least in theory might

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

ngraham added a comment. `git bisect` says this caused https://bugs.kde.org/show_bug.cgi?id=420801. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28470 To: kmaterka, #plasma, broulik, apol, davidedmundson, #frameworks Cc: ngraham, mart, davidre,

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. In D29299#660468 , @pino wrote: > In D29299#660466 , @kossebau wrote: > > > In D29299#660465 , @pino wrote: > > > > > Also,

D29303: Make KI18N_INSTALL() compatible to KDE_INSTALL_DIRS_NO_DEPRECATED

kossebau created this revision. kossebau added reviewers: ilic, heikobecker. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY LOCALE_INSTALL_DIR is a deprecated variable from KDEInstallDirs, which

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. In D29299#660466 , @kossebau wrote: > In D29299#660465 , @pino wrote: > > > Also, your patch basically includes D29136 in the case of no

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. In D29299#660453 , @pino wrote: > The problem is that ki18n_install() is rarely used manually, and generally it is appended by the release scripts to the top-level CMakeLists.txt file that goes into the tarballs.

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. > The patch should not require existing users to adapt Yes, that's also what I wrote earlier. Also, your patch basically includes D29136 in the case of no DESTINATION parameter specified, hence my suggestion is: - edit

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. The patch should not require existing users to adapt (though personally I would favour explit DESTINATION args, perhaps a KF6 time thing). That is also why there is no warning emitted in case the DESTINATION is not passed. So nothing should need to be changed

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. > The problem is that ki18n_install() is rarely used manually OK, at least from LXR search it seems a bit more than that: KF packages using ki18n, some extragear stuff, and few Plasma bits. This means that KF packages can switch to that immediately (because of the

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. The problem is that ki18n_install() is rarely used manually, and generally it is appended by the release scripts to the top-level CMakeLists.txt file that goes into the tarballs. This means that either the majority of the packages will not make use of this, or a

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added reviewers: aacid, ltoscano. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker, #frameworks, aacid, ltoscano Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a reviewer: Frameworks. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29136: Use non-deprecated KDEInstallDir

heikobecker abandoned this revision. heikobecker added a comment. Abandoned in favour of https://phabricator.kde.org/D29136 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29136 To: heikobecker Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

heikobecker added a comment. Fixes the problem I had with marble, which prompted the creation of https://phabricator.kde.org/D29136. Passing the destination as an parameter seems indeed like a better way, so +1 from me. REPOSITORY R249 KI18n REVISION DETAIL

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. Tested now (with DESTINATION passed, without, without & LOCALE_INSTALL_DIR not set), so state: working proposal :) REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker Cc: kde-frameworks-devel, LeGast00n,

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau updated this revision to Diff 81597. kossebau added a comment. - fix typo: ARGS_DESTINATION - small doc improvement REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29299?vs=81590=81597 BRANCH adddestinationargtoki18ninstall REVISION DETAIL

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. Have to yet test this properly, uploaded for now as alternative approach to D29136 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker Cc: kde-frameworks-devel,

D29136: Use non-deprecated KDEInstallDir

kossebau added a comment. In D29136#660358 , @heikobecker wrote: > > Where would you see "that the macro already used KDEInstallDirs before"? When it comes to "LOCALE_INSTALL_DIR", that is set to a default is not set when calling the macro.

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau created this revision. kossebau added reviewers: ilic, heikobecker. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY a) LOCALE_INSTALL_DIR is a deprecated variable from KDEInstallDirs,

D29136: Use non-deprecated KDEInstallDir

heikobecker added a comment. > Where would you see "that the macro already used KDEInstallDirs before"? When it comes to "LOCALE_INSTALL_DIR", that is set to a default is not set when calling the macro. Ideally would be documented though. (my first approach would be to also allow a soft

D29210: [NestedListHelper] Fix indentation of selection, add tests

poboiko added inline comments. INLINE COMMENTS > dfaure wrote in nestedlisthelper.cpp:225 > should the opposite happen? delete the list when decreasing indentation? > > Or is that what the blkFmt.setObjectIndex(-1); is about? > A comment there would be useful... > > To me setObjectIndex(-1)

D29210: [NestedListHelper] Fix indentation of selection, add tests

poboiko updated this revision to Diff 81585. poboiko added a comment. Make the code that removes the block from the list more obvious (without `setObjectIndex` magic) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29210?vs=81267=81585 BRANCH change-indent (branched from master)

D29292: Port KKeySequenceItem to QQC2

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works for me, and we can bikeshed about the tooltip stuff elsewhere. :) REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D29292 To:

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

pino added inline comments. INLINE COMMENTS > renamedialog.cpp:299 > +// direction from src to dest > +const QPixmap pix = > QIcon::fromTheme(QStringLiteral("go-next")).pixmap(d->m_srcPreview->height()); > +srcToDestArrow->setPixmap(pix); this is not right-to-left

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R241 KIO BRANCH l-srt-to-dest (branched from master) REVISION DETAIL https://phabricator.kde.org/D29254 To: ahmadsamir, #frameworks, dfaure, meven, ngraham Cc:

D29208: [NestedListHelper] Improve indentation code

poboiko added inline comments. INLINE COMMENTS > dfaure wrote in nestedlisthelper.cpp:87 > So the last block cannot be unindented? How come? That's the current block being checked, not the next one. I've just checked to be sure, last block can be unindented :) TBH, I don't really know if it's

KDE CI: Frameworks » plasma-wayland-protocols » kf5-qt5 SUSEQt5.12 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-wayland-protocols/job/kf5-qt5%20SUSEQt5.12/1/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 30 Apr 2020 12:51:24 + Build duration: 1 min 32 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-wayland-protocols » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-wayland-protocols/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 30 Apr 2020 12:51:23 + Build duration: 1 min 35 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-wayland-protocols » kf5-qt5 FreeBSDQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-wayland-protocols/job/kf5-qt5%20FreeBSDQt5.14/1/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 30 Apr 2020 12:51:21 + Build duration: 35 sec and counting

D29136: Use non-deprecated KDEInstallDir

kossebau added a comment. I understand the desire for pragmatic solution, but I am too old now and have seen too many places where being pragmatic at one point resulted in tightly coupled systems which later prevented progress. When it comes to build dependencies, forcing users of a

D29136: Use non-deprecated KDEInstallDir

heikobecker added a comment. In D29136#660270 , @kossebau wrote: > using kdeinstalldirs variables needs to ensure that KDEInstallDirs has been included before, also introduces ahard dependency on ECM for any users of KI18n. While 99% of apps

D29136: Use non-deprecated KDEInstallDir

kossebau added a comment. Just came by, have to get back later, but first comment: using kdeinstalldirs variables needs to ensure that KDEInstallDirs has been included before, also introduces ahard dependency on ECM for any users of KI18n. While 99% of apps using KI18n might do this, by

D29278: Port KWin to KWaylandServer

This revision was automatically updated to reflect the committed changes. Closed by commit R108:3a9d7a6e9d75: Port KWin to KWaylandServer (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29278?vs=81574=81575#toc REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D29278: Port KWin to KWaylandServer

zzag accepted this revision. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 To: apol, #kwin, #plasma, #frameworks, davidedmundson, zzag Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski,

D29278: Port KWin to KWaylandServer

apol updated this revision to Diff 81574. apol added a comment. Address @zzag's comments REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29278?vs=81521=81574 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 AFFECTED FILES

D29278: Port KWin to KWaylandServer

apol marked an inline comment as done. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 To: apol, #kwin, #plasma, #frameworks, davidedmundson Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D29278: Port KWin to KWaylandServer

davidedmundson added a comment. > Hmm, I can't build kwin Hit the same thing, we've since fixed that (patch in kwayland-server) REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 To: apol, #kwin, #plasma, #frameworks, davidedmundson Cc: zzag,

D29278: Port KWin to KWaylandServer

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 To: apol, #kwin, #plasma, #frameworks, davidedmundson Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev,

D29292: Port KKeySequenceItem to QQC2

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in KeySequenceItem.qml:57 > Why is it the worst? It keeps us from having to hardcode magic numbers. See task. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29292 To: davidedmundson, #plasma,

D29096: Prefix includes and libs dir with QT_SYSROOT

ablu abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure, kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D28701: Add KPackage support to KNewStuffCore

leinir added a comment. In D28701#660186 , @mart wrote: > +1 from me. Thanks! :) > does it need to go into next release or can also get in next+1? It really wants to go in soon as possible (since it fixes the whole global

D28701: Add KPackage support to KNewStuffCore

mart added a comment. +1 from me. does it need to go into next release or can also get in next+1? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, broulik, bshah Cc: alex,

D29096: Prefix includes and libs dir with QT_SYSROOT

ablu added a comment. Ah, right. If you are using a normal sysroot for system libs, but conan for some libs then it makes sense! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure, kossebau,

D29096: Prefix includes and libs dir with QT_SYSROOT

dfaure added a comment. I'm using conan, not doing cross compilation. But with relative paths it's no problem, both use cases work. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure,

D29292: Port KKeySequenceItem to QQC2

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in KeySequenceItem.qml:57 > > Can we use the non-attached version here please since it's not likely > > It's the worst! > > > Are we able to use some form of units? Hardcoding this seems wrong. > > It's come up before, this

D29050: WIP KRunner fix prepare/teardown signals

alex edited the test plan for this revision. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29278: Port KWin to KWaylandServer

zzag added a comment. Hmm, I can't build kwin /home/vlad/Workspace/KDE/src/kde/workspace/kwin/libkwineffects/kwineffects.cpp:44:10: fatal error: KWaylandServer/surface_interface.h: No such file or directory 44 | #include |

D29050: WIP KRunner fix prepare/teardown signals

meven added a comment. > Try out what was described in bug report. Please copy it the TEST PLAN (it is easier on reviewers and better for history) Adding a test would be the best way to demonstrate the issue and the fix. REPOSITORY R308 KRunner REVISION DETAIL

D29175: DBus Runner: Add service property to request actions once

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me. Before merging, maybe you could make a diff with a few runners in plasma-workspace use it. And if you could add a test. REPOSITORY R308 KRunner BRANCH