D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-02 Thread Weisi Dai
weisi created this revision.
weisi added a reviewer: winterz.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
weisi requested review of this revision.

REVISION SUMMARY
  It's a trivial fix, but this syntax error poped up when I was doing another 
holiday change on KHolidays.
  
  According to Early May Bank Holiday in the United Kingdom 
, this is a 
public holiday, so I'm marking this `public`.

TEST PLAN
  Tested with
  
QT_LOGGING_RULES="*.debug=true" ./bin/testholidayregion -maxwarnings 0 | 
grep 'syntax error'
  
  Seeing no output.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29374

AFFECTED FILES
  holidays/plan2/holiday_gb-sct_en-gb

To: weisi, winterz
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

2020-05-02 Thread Weisi Dai
weisi updated this revision to Diff 81772.
weisi added a comment.


  Renamed "農曆除夕" (//Lunar New Year's eve on Lunar calendar//) to "除夕" (//Lunar 
New Year's eve//). There's no need to specify "lunar calendar" here.

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29373?vs=81770=81772

REVISION DETAIL
  https://phabricator.kde.org/D29373

AFFECTED FILES
  holidays/plan2/holiday_tw_zh

To: weisi, winterz
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

2020-05-02 Thread Weisi Dai
weisi created this revision.
weisi added a reviewer: winterz.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
weisi requested review of this revision.

REVISION SUMMARY
  The previous revision put in fixed dates (month/day) for many holidays which 
are actually based on the Lunar calendar, instead of the Georgian calendar. 
They are not observed on a fixed date each year.
  
  As a workaround, I put in the dates for the holidays over years 2020 to 2024:
  
  - Chinese New Year's Eve 除夕 *
  - Spring Festival 春節 *
  - Lantern Festival 元宵節 *
  - Matsu's Birthday 媽祖聖誕 *#
  - Buddha's Birthday 佛誕日 *#
  - Chinese Valentine's Day 七夕節 *
  - Double Ninth Day 重陽節 *
  - Dragon Boat Festival 端午節
  - Mid-Autumn Festival 中秋節
  
  The //star *// ones are specified using the "lunar new year date" minus/plus 
some days, hoping to make it easier to adapt to additional years in the future.
  
  There are holidays entries regarding specific arrangements (an extra day is 
observed in lieu of an extra working day) that can't be calculated in advance - 
usually they published early that year. I removed these from future years since 
the arrangement has not been published and I don't want to include holiday 
entries that are too speculative.
  
  I also removed a few religious holidays from the holidays list, simply 
because I think they are not on a fixed date of each Georgian year. 2 of these 
are converted to the format above, as marked with the # sign.
  
  I also specified the start year of Peace Memorial Day 228和平紀念日, and added 
Freedom of Expression Day 言論自由日.
  
  I think there are still issues with the 4 season dates (March Equinox 春分, Jun 
Solstice 夏至, September Equinox 秋分, December Solstice 冬至) but maybe there's some 
better solution for this.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29373

AFFECTED FILES
  holidays/plan2/holiday_tw_zh

To: weisi, winterz
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.14 - Build # 23 - Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.14/23/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 02 May 2020 23:24:33 +
 Build duration:
2 hr 19 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 489 test(s), Skipped: 0 test(s), Total: 491 test(s)Failed: projectroot.autotests.RecursOn_ConnectDaily6.icsFailed: projectroot.autotests.RecursOn_ConnectDaily8.ics

D28745: Skip caching thumbnails on encrypted filesystems

2020-05-02 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


  @bruns?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, rdieter, mikesomov


KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.14 - Build # 13 - Fixed!

2020-05-02 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.14/13/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sun, 03 May 2020 00:49:54 +
 Build duration:
3 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Declarative-5.70.0.xmlcompat_reports/KF5Declarative_compat_report.htmllogs/KF5Declarative/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(5/15)18%
(11/60)18%
(11/60)15%
(501/3364)10%
(202/1933)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)91%
(195/214)38%
(99/259)src.calendarevents0%
(0/3)0%
(0/3)0%
(0/63)0%
(0/2)src.kdeclarative75%
(3/4)75%
(3/4)49%
(149/307)36%
(50/140)src.kdeclarative.private100%
(2/2)100%
(2/2)19%
(6/31)0%
(0/18)src.kpackagelauncherqml0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/18)src.qmlcontrols.draganddrop0%
(0/7)0%
(0/7)0%
(0/362)0%
(0/170)src.qmlcontrols.kcmcontrols0%
(0/1)0%
(0/1)0%
(0/3)0%
(0/2)src.qmlcontrols.kconfig0%
(0/2)0%
(0/2)0%
(0/11)0%
(0/2)src.qmlcontrols.kcoreaddons0%
(0/4)0%
(0/4)0%
(0/85)0%
(0/66)src.qmlcontrols.kioplugin0%
(0/2)0%
(0/2)0%
(0/20)0%
(0/24)src.qmlcontrols.kquickcontrols.private0%
(0/4)0%
(0/4)0%
(0/327)0%
(0/236)src.qmlcontrols.kquickcontrolsaddons7%
(1/15)7%
(1/15)5%
(65/1377)4%
(30/756)src.qmlcontrols.kwindowsystemplugin0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/36)src.quickaddons14%
(1/7)14%
(1/7)21%
(86/414)11%
(23/202)tests0%
(0/2)0%
(0/2)0%
(0/27)0%
(0/2)

D29372: Taiwan: Use "zh_TW" language code

2020-05-02 Thread Weisi Dai
weisi added a reviewer: winterz.
weisi added a comment.


  Adding a reviewer to this diff. Thanks!

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29372

To: weisi, winterz
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29372: Taiwan: Use "zh_TW" language code

2020-05-02 Thread Weisi Dai
weisi created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
weisi requested review of this revision.

REVISION SUMMARY
  It was set to `tw_zh` which I think is a typo. According to Wikipedia,
  
  > `zh-TW` is the IETF language tag for the Chinese language as used in Taiwan
  
  Also note that HK uses `zh_HK` and CN uses `zh_CN`.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29372

AFFECTED FILES
  holidays/plan2/holiday_tw_zh

To: weisi
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 23 - Fixed!

2020-05-02 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/23/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 02 May 2020 22:50:34 +
 Build duration:
1 hr 41 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.14 - Build # 13 - Fixed!

2020-05-02 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.14/13/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 02 May 2020 23:18:07 +
 Build duration:
34 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.70.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 47 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(244/272)90%
(244/272)85%
(27757/32804)53%
(11165/21001)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12614/12687)50%
(6629/13155)autotests.server100%
(6/6)100%
(6/6)99%
(518/521)50%
(233/468)src.client96%
(73/76)96%
(73/76)85%
(6356/7494)65%
(1839/2838)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(120/126)95%
(120/126)83%
(8188/9822)63%
(2464/3909)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 10 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/10/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 02 May 2020 23:12:15 +
 Build duration:
36 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.70.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)87%
(260/298)87%
(260/298)67%
(33047/49193)49%
(14833/30096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src97%
(37/38)97%
(37/38)93%
(4797/5131)49%
(1812/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5526/5568)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1678/1892)74%
(1083/1472)src.completion100%
(11/11)100%
(11/11)57%
(1785/3131)42%
(1008/2423)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/855)0%
(0/180)src.document100%
(4/4)100%
(4/4)61%
(1938/3176)48%
(1426/2977)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)84%
(187/222)55%
(125/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1050)16%
(146/897)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(7/7)100%
(7/7)79%
(962/1224)68%
(621/916)src.schema29%
(2/7)29%
(2/7)1%
(19/1468)1%
(6/625)src.script100%
(16/16)100%
(16/16)69%
(716/1038)56%
(226/403)src.search100%
   

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 16 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/16/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 23:01:31 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-05-02 Thread Michael Pyne
On Fri, May 01, 2020 at 09:25:18AM -0400, Allen Winter wrote:
> On Thursday, April 30, 2020 5:15:43 PM EDT Albert Astals Cid wrote:
> > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va 
> > escriure:
> > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić  wrote:
> > > >
> > > > > We have made a big fuss in the past about having different projects
> > > > > that do the same thing and now we'll have that but also we'll have
> > > > > several projects with the same name?
> > > > > It really feels off to me and I wonder if this is related to the move 
> > > > > to
> > > > > gitlab.
> > > >
> > > > +1 to both sentiments - that projects should have different names and 
> > > > that
> > > > this is a bit off topic for the gitlab migration.
> > > 
> > > The projects *DO* have very different names. That *HAS NOT* changed.
> > > To use the example Bhushan gave above, one is called Plasma Mobile
> > > Dialer and the other one is called Maui Dialer.
> > > 
> > > With the current git.kde.org setup, we have a flat namespace, so all
> > > repositories if the name appears to be generic (as dialer is) have to
> > > be namespaced by prefixing of the repository name.
> > > 
> > > With Gitlab however we will now namespaces that group repositories,
> > > making the prefixing unnecessary and as some projects have complained
> > > about, duplicative.
> > > 
> > > Otherwise you end up with plasma-mobile/plasma-mobile-dialer as your
> > > path, which just looks silly.
> > 
> > Am I the only person that just has all the repos on the same folder? I 
> > thought it was the common thing to do :?
> > 
> I use kdesrc-build and I see the repos in a hierarchy.
> In particular, I like frameworks in frameworks in kdepim in kde/pim
> 
> I don't see that I'm setting any special "layout in a hierarchy" option in my 
> kdesrc-buildrc

So it's been a few months since we had switched the default, but since
it's clearly an invasive change, the way we addressed it was to make the
flat hierarchy a default for new users (who use either of the 'quick
config' schemes like kdesrc-build-setup or kdesrc-build
--initial-setup), but to leave the built-in default unchanged.

So in essence, existing kdesrc-build users (who had a folder-based
layout by default unless they went out of their way to find the right
option) saw no change, but new users would have that option pre-set for
them in the config.

Regards,
 - Michael Pyne


KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 17 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/17/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 02 May 2020 22:54:01 +
 Build duration:
33 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.70.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6934/9126)43%
(10805/24857)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2902/2996)49%
(6200/12734)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/800)42%
(956/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/11/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 22:50:30 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.14 - Build # 12 - Failure!

2020-05-02 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.14/12/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 02 May 2020 22:52:15 +
 Build duration:
31 min and counting
   CONSOLE OUTPUT
  [...truncated 97 lines...][2020-05-02T23:23:10.122Z]  > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10[2020-05-02T23:23:10.124Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-05-02T23:23:10.147Z]  > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10[2020-05-02T23:23:10.171Z] Fetching upstream changes from https://anongit.kde.org/kapidox[2020-05-02T23:23:10.171Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-05-02T23:23:10.422Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-05-02T23:23:10.450Z]  > git config core.sparsecheckout # timeout=10[2020-05-02T23:23:10.458Z]  > git checkout -f efbc6aa56a7fe4c3cf788cdec224bf73a5e54865 # timeout=10[Pipeline] checkout[2020-05-02T23:23:10.839Z] No credentials specified[2020-05-02T23:23:10.845Z] Cloning the remote Git repository[2020-05-02T23:23:10.847Z] Cloning repository https://anongit.kde.org/kde-dev-scripts[2020-05-02T23:23:10.847Z]  > git init /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.14/ci-tooling/kde-dev-scripts # timeout=10[2020-05-02T23:23:10.856Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2020-05-02T23:23:10.857Z]  > git --version # timeout=10[2020-05-02T23:23:10.868Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-05-02T23:23:12.349Z] Checking out Revision de1e2fd97aae301bf39e4015b456a247721a155c (origin/master)[2020-05-02T23:23:12.428Z] Commit message: "Add myself (davidhurka) to relicensecheck.pl"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[2020-05-02T23:23:12.006Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2020-05-02T23:23:12.018Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-05-02T23:23:12.046Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2020-05-02T23:23:12.060Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2020-05-02T23:23:12.061Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-05-02T23:23:12.333Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-05-02T23:23:12.353Z]  > git config core.sparsecheckout # timeout=10[2020-05-02T23:23:12.365Z]  > git checkout -f de1e2fd97aae301bf39e4015b456a247721a155c # timeout=10[Pipeline] sh[2020-05-02T23:23:13.443Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kdeclarative --branchGroup kf5-qt5 --environment production --platform SUSEQt5.14 --installTo /home/jenkins//install-prefix/[2020-05-02T23:23:18.039Z] Retrieving: Frameworks-extra-cmake-modules-kf5-qt5[2020-05-02T23:23:18.039Z] Retrieving: Frameworks-karchive-kf5-qt5[2020-05-02T23:23:18.039Z] Retrieving: Frameworks-ki18n-kf5-qt5[2020-05-02T23:23:18.039Z] Retrieving: Frameworks-kcoreaddons-kf5-qt5[2020-05-02T23:23:18.039Z] Retrieving: Frameworks-kdoctools-kf5-qt5[2020-05-02T23:23:18.039Z] Retrieving: Frameworks-kwindowsystem-kf5-qt5[2020-05-02T23:23:18.039Z] Retrieving: Frameworks-kconfig-kf5-qt5[2020-05-02T23:23:18.039Z] Retrieving: Frameworks-kcrash-kf5-qt5[2020-05-02T23:23:18.039Z] Retrieving: Frameworks-kdbusaddons-kf5-qt5[2020-05-02T23:23:18.039Z] Retrieving: Frameworks-phonon-kf5-qt5[2020-05-02T23:23:18.039Z] Retrieving: Frameworks-polkit-qt-1-kf5-qt5[2020-05-02T23:23:18.039Z] Retrieving: Frameworks-kauth-kf5-qt5[2020-05-02T23:23:18.302Z] Retrieving: Frameworks-kcodecs-kf5-qt5[2020-05-02T23:23:18.302Z] Retrieving: Frameworks-kguiaddons-kf5-qt5[2020-05-02T23:23:18.302Z] Retrieving: Frameworks-kwidgetsaddons-kf5-qt5[2020-05-02T23:23:18.302Z] Retrieving: Frameworks-kconfigwidgets-kf5-qt5[2020-05-02T23:23:18.558Z] Retrieving: Frameworks-kitemviews-kf5-qt5[2020-05-02T23:23:18.558Z] Retrieving: Frameworks-kiconthemes-kf5-qt5[2020-05-02T23:23:18.815Z] Retrieving: Frameworks-knotifications-kf5-qt5[2020-05-02T23:23:18.815Z] Retrieving: Frameworks-kservice-kf5-qt5[2020-05-02T23:23:18.815Z] Retrieving: Frameworks-kcompletion-kf5-qt5[2020-05-02T23:23:19.076Z] Retrieving: Frameworks-sonnet-kf5-qt5[2020-05-02T23:23:19.337Z] Retrieving: Frameworks-attica-kf5-qt5[2020-05-02T23:23:19.337Z] Retrieving: Frameworks-kglobalaccel-kf5-qt5[2020-05-02T23:23:19.337Z] Retrieving: Frameworks-ktextwidgets-kf5-qt5[2020-05-02T23:23:19.337Z] Retrieving: Frameworks-breeze-icons-kf5-qt5[2020-05-02T23:23:20.704Z] Traceback (most recent call 

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 16 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/16/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 22:47:54 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.14 - Build # 12 - Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.14/12/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 02 May 2020 22:01:20 +
 Build duration:
1 hr 16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.70.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 47 test(s)Failed: projectroot.autotests.client.kwayland_testDataDevice
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(244/272)90%
(244/272)85%
(27736/32805)53%
(11151/21001)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12599/12688)50%
(6620/13155)autotests.server100%
(6/6)100%
(6/6)99%
(518/521)50%
(233/468)src.client96%
(73/76)96%
(73/76)85%
(6353/7494)65%
(1836/2838)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(120/126)95%
(120/126)83%
(8185/9822)63%
(2462/3909)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

Re: Information regarding upcoming Gitlab Migration

2020-05-02 Thread Ben Cooksley
On Sun, May 3, 2020 at 2:13 AM Michał Policht  wrote:
>
> Hi all,

Hi Michal,

>
> Sorry for late response, but project "cutehmi" fits into "sdk" category
> better than "applications" (technically it's a framework, but I guess
> "frameorks" is reserved for well integrated KDE Frameworks).

I have now relocated CuteHMI within the proposed layout to SDK.

The initial allocation to applications/ was done based on it's
position at the moment in playground/base/

>
> Speaking generally on subject, categorization is always problematic.
> Categories often are fuzzy, they overlap, element can match more than
> one type/category/group at the same time and there are many criteria by
> which you could partition a set of elements.
>
> Maybe for future reference, it would be good if there was some
> explanation on how these groups are created. From what I can see large
> projects organized into subprojects have dedicated groups (e.g. plasma,
> kdevelop). There are groups based on project status (e.g. unmaintained,
> historical). Then we have a division, which seems to be based on use
> case from development applicability perspective (e.g. libraries,
> frameworks, sdk). Then we have applications divided into something like
> user interests (e.g. multimedia, games, office, education). Since you
> mention that project may belong to many groups it would be nice to
> clarify, if for example game-oriented library (which occupies
> "libraries") fits into "games" group as well or is "games" group
> reserved for end-user applications only.

There are no hard and fast rules for categorisation.

Libraries that are only suitable for a specific purpose (like Games)
could certainly go in Games.
In general we'd expect maintainers to indicate a preference when
requesting repositories.

>
> Regards
> Michał

Cheers,
Ben

>
>
> On 4/27/20 3:40 AM, Bhushan Shah wrote:
> > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for
> > replies]
> >
> > Hello Community members,
> >
> > In view of upcoming Gitlab migration, we sysadmin team wants to share
> > the recommended structuring for the repositories on Gitlab.
> >
> > We had multiple options,
> >
> > - Flat structure: In this option we would have everything under one
> >single namespace/group: https://invent.kde.org/kde/knetwalk
> > - Subgroups under top-level group: In this option we would have a groups
> >under KDE namespace: https://invent.kde.org/kde/games/knetwalk
> > - Groups at top level: In this option we would establish a series of
> >groups at the top level, e.g.  https://invent.kde.org/games/knetwalk
> >
> > We have discussed this with small but representative group of
> > contributors or maintainers, and based on their suggestions, we
> > recommend that we go with option 3. Having sub-groups at top level will
> > allow us to,
> >
> > - Provides good visibility on all reviews, tasks and other items within
> >the groups/modules we define
> > - Provides improvements to discoverability of projects
> > - Makes it possible for groups of projects to establish a group level
> >task board should it fit their needs (for tracking a release for
> >instance)
> > - Makes the most semantic sense, as the ‘KDE’ top level group suggested
> >in option 2 is duplicative considering the Gitlab instance is under
> >kde.org.
> > - The discoverability of projects is maximised, as there is no need to
> >open the top level ‘KDE’ group before going into the subgroup.
> >
> > I've worked on draft "move" of the current set of the repositories in
> > their respective subgroups at the repo-metadata project's branch [1].
> > You can browse the directory structure to get idea of how final
> > structure on Gitlab would look like.
> >
> > If we don't have any objections we would like to implement this next
> > week and move projects to https://invent.kde.org.
> >
> > Thanks!
> > Bhushan for sysadmin team
> >
> > [1] 
> > https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent
> >
>


KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 9 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/9/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 02 May 2020 22:00:54 +
 Build duration:
1 hr 11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.70.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)87%
(260/298)87%
(260/298)67%
(33011/49191)49%
(14806/30096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src97%
(37/38)97%
(37/38)93%
(4791/5129)49%
(1812/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5526/5568)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1677/1892)74%
(1082/1472)src.completion100%
(11/11)100%
(11/11)57%
(1785/3131)42%
(1008/2423)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/855)0%
(0/180)src.document100%
(4/4)100%
(4/4)61%
(1937/3176)48%
(1419/2977)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)84%
(187/222)55%
(125/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1050)16%
(146/897)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(7/7)100%
(7/7)77%
(947/1224)67%
(612/916)src.schema29%
(2/7)29%
(2/7)1%
(19/1468)1%
(6/625)src.script100%
(16/16)100%
(16/16)68%
(706/1038)54%

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

2020-05-02 Thread David Faure
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Please don't remove this, but port it to QEventLoopLocker.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D29371

To: dvratil, dfaure, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/8/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 22:38:12 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/8/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 22:37:18 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/15/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 22:02:32 +
 Build duration:
58 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 16 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/16/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 02 May 2020 21:56:46 +
 Build duration:
57 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.70.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6934/9126)43%
(10805/24857)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2902/2996)49%
(6200/12734)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/800)42%
(956/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 22 - Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/22/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 02 May 2020 21:55:59 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kbookmarktest

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/10/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 22:00:55 +
 Build duration:
49 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/15/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 22:01:20 +
 Build duration:
46 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/7/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 22:00:27 +
 Build duration:
37 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/7/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 22:00:05 +
 Build duration:
37 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.14/5/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 21:56:09 +
 Build duration:
38 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 487 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.RecursOn_ConnectDaily2.icsFailed: projectroot.autotests.RecursOn_ConnectDaily3.icsFailed: projectroot.autotests.RecursOn_ConnectDaily6.icsFailed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/8/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 21:57:14 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

2020-05-02 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29371

To: dvratil, dfaure, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.14/5/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 21:57:24 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 188 - Fixed!

2020-05-02 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/188/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 May 2020 21:56:46 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.70.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6933/9127)43%
(10804/24863)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2901/2996)49%
(6198/12736)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/801)42%
(957/2273)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/11/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 21:57:02 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Still Unstable!

2020-05-02 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/15/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 02 May 2020 21:56:46 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

2020-05-02 Thread Daniel Vrátil
dvratil added a reviewer: Frameworks.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D29371

To: dvratil, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

2020-05-02 Thread Daniel Vrátil
dvratil created this revision.
dvratil added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dvratil requested review of this revision.

REVISION SUMMARY
  There's no sign of KGlobal (obviously, it's been moved to kdelibs4support)
  or any other similar code in KMainWindow, so remove the outdated paragraph
  from the documentation.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29371

AFFECTED FILES
  src/kmainwindow.h

To: dvratil, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29370: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau created this revision.
kossebau added reviewers: Frameworks, Localization, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  usemoreuicontextmarker

REVISION DETAIL
  https://phabricator.kde.org/D29370

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: kossebau, #frameworks, #localization, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29369: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau created this revision.
kossebau added reviewers: Frameworks, Localization.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Also fix lowercase "toolbar" in action text to Title Capitalization

REPOSITORY
  R294 KBookmarks

BRANCH
  usemoreuicontextmarker

REVISION DETAIL
  https://phabricator.kde.org/D29369

AFFECTED FILES
  src/kbookmarkcontextmenu.cpp
  src/kbookmarkmenu.cpp
  src/konqbookmarkmenu.cpp

To: kossebau, #frameworks, #localization
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29368: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau created this revision.
kossebau added reviewers: Frameworks, Localization.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R284 KCompletion

BRANCH
  usemoreuicontextmarker

REVISION DETAIL
  https://phabricator.kde.org/D29368

AFFECTED FILES
  src/khistorycombobox.cpp
  src/klineedit.cpp

To: kossebau, #frameworks, #localization
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29367: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau created this revision.
kossebau added reviewers: Frameworks, Localization, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Also align placeholder string of KFilterProxySearchLine with the one
  of KTreeWidgetSearchLine

REPOSITORY
  R276 KItemViews

BRANCH
  usemoreuicontextmarker

REVISION DETAIL
  https://phabricator.kde.org/D29367

AFFECTED FILES
  src/kfilterproxysearchline.cpp
  src/ktreewidgetsearchline.cpp

To: kossebau, #frameworks, #localization, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29210: [NestedListHelper] Fix indentation of selection, add tests

2020-05-02 Thread Igor Poboiko
This revision was automatically updated to reflect the committed changes.
Closed by commit R310:7012493410ae: [NestedListHelper] Fix indentation of 
selection, add tests (authored by poboiko).
Herald added a project: Frameworks.

REPOSITORY
  R310 KTextWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29210?vs=81585=81758

REVISION DETAIL
  https://phabricator.kde.org/D29210

AFFECTED FILES
  autotests/krichtextedittest.cpp
  autotests/krichtextedittest.h
  src/widgets/krichtextedit.cpp
  src/widgets/nestedlisthelper.cpp
  src/widgets/nestedlisthelper_p.h

To: poboiko, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29101: KNewStuff: Fix file path and process call

2020-05-02 Thread Alexander Lohnau
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:4c6b3afcd80a: KNewStuff: Fix file path and process call 
(authored by alex).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29101?vs=81467=81753

REVISION DETAIL
  https://phabricator.kde.org/D29101

AFFECTED FILES
  src/core/installation.cpp

To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, 
leinir, anthonyfieroni
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29101: KNewStuff: Fix file path and process call

2020-05-02 Thread Alexander Lohnau
alex added a comment.


  Ups, that makes sense ^^
  Thanks!

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D29101

REVISION DETAIL
  https://phabricator.kde.org/D29101

To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, 
leinir, anthonyfieroni
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29101: KNewStuff: Fix file path and process call

2020-05-02 Thread Anthony Fieroni
anthonyfieroni accepted this revision.
anthonyfieroni added a comment.


  KNewstuff is framework, it has only master.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D29101

REVISION DETAIL
  https://phabricator.kde.org/D29101

To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, 
leinir, anthonyfieroni
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29101: KNewStuff: Fix file path and process call

2020-05-02 Thread Alexander Lohnau
alex added a comment.


  Friendly ping regarding the question :-)

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D29101

REVISION DETAIL
  https://phabricator.kde.org/D29101

To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, 
leinir
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29175: DBus Runner: Add service property to request actions once

2020-05-02 Thread Alexander Lohnau
alex added inline comments.

INLINE COMMENTS

> meven wrote in dbusrunnertest.cpp:206
> You should have added a QSignalSpy to check prepare was called, and another 
> for requestAction to check it has been called only once.

The concept behind this test is, that the runner is just loaded. If the 
Request-Actions-Once property is correctly implemented the actions are 
requested when the plugin is initialized. That means that they should be 
available and `prepare` doesn't need to be called.

So it would make sense to add a signal spy to check if prepare was not called 
at all, or am I missing something?

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29175

To: alex, #plasma, meven, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29347: KAuthorized: export method to reload restrictions

2020-05-02 Thread David Faure
dfaure added a comment.


  Yes declaring the function there, as in the code sample shown here.
  
  We do the same for internally-exported variables like KSERVICE_EXPORT int 
ksycoca_ms_between_checks;
  Qt does the same kind of things.
  
  A _p.h header would have to be installed, which we don't normally do.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D29347

To: dfaure, aacid, apol, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29347: KAuthorized: export method to reload restrictions

2020-05-02 Thread David Faure
dfaure edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D29347

To: dfaure, aacid, apol, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29363: Use UI marker context in more tr() calls

2020-05-02 Thread Albert Astals Cid
aacid added a comment.


  The descriptions seem reasonable.
  
  The problem with this is that it makes all strings untranslated and i'm not 
sure it's worth the effort.
  
  My hope is that at this point anything that was actually ambiguous would have 
been reported by the translators and fixed. But i know that's a hope ^_^ more 
than a reality
  
  So take this as a +0.1 i guess :D

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29363

To: kossebau, #frameworks, #localization, cfeck
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29363: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 81744.
kossebau added a comment.


  also done for ui files

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29363?vs=81742=81744

BRANCH
  usemoreuicontextmarker

REVISION DETAIL
  https://phabricator.kde.org/D29363

AFFECTED FILES
  src/kactionselector.cpp
  src/kassistantdialog.cpp
  src/kcharselect.cpp
  src/kcolorcombo.cpp
  src/kdatepicker.cpp
  src/kdatetimeedit.cpp
  src/keditlistwidget.cpp
  src/kfontchooser.cpp
  src/kfontchooserdialog.cpp
  src/kfontrequester.cpp
  src/kmessagewidget.cpp
  src/kmimetypechooser.cpp
  src/knewpassworddialog.cpp
  src/knewpasswordwidget.ui
  src/kpassworddialog.cpp
  src/kpassworddialog.ui
  src/kpasswordlineedit.cpp
  src/kpixmapregionselectordialog.cpp
  src/kpixmapregionselectorwidget.cpp
  src/ksqueezedtextlabel.cpp

To: kossebau, #frameworks, #localization, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


Re: Information regarding upcoming Gitlab Migration

2020-05-02 Thread Michał Policht

Hi all,

Sorry for late response, but project "cutehmi" fits into "sdk" category 
better than "applications" (technically it's a framework, but I guess 
"frameorks" is reserved for well integrated KDE Frameworks).


Speaking generally on subject, categorization is always problematic. 
Categories often are fuzzy, they overlap, element can match more than 
one type/category/group at the same time and there are many criteria by 
which you could partition a set of elements.


Maybe for future reference, it would be good if there was some 
explanation on how these groups are created. From what I can see large 
projects organized into subprojects have dedicated groups (e.g. plasma, 
kdevelop). There are groups based on project status (e.g. unmaintained, 
historical). Then we have a division, which seems to be based on use 
case from development applicability perspective (e.g. libraries, 
frameworks, sdk). Then we have applications divided into something like 
user interests (e.g. multimedia, games, office, education). Since you 
mention that project may belong to many groups it would be nice to 
clarify, if for example game-oriented library (which occupies 
"libraries") fits into "games" group as well or is "games" group 
reserved for end-user applications only.


Regards
Michał


On 4/27/20 3:40 AM, Bhushan Shah wrote:

[Please keep sysad...@kde.org list or bs...@kde.org in the CC for
replies]

Hello Community members,

In view of upcoming Gitlab migration, we sysadmin team wants to share
the recommended structuring for the repositories on Gitlab.

We had multiple options,

- Flat structure: In this option we would have everything under one
   single namespace/group: https://invent.kde.org/kde/knetwalk
- Subgroups under top-level group: In this option we would have a groups
   under KDE namespace: https://invent.kde.org/kde/games/knetwalk
- Groups at top level: In this option we would establish a series of
   groups at the top level, e.g.  https://invent.kde.org/games/knetwalk

We have discussed this with small but representative group of
contributors or maintainers, and based on their suggestions, we
recommend that we go with option 3. Having sub-groups at top level will
allow us to,

- Provides good visibility on all reviews, tasks and other items within
   the groups/modules we define
- Provides improvements to discoverability of projects
- Makes it possible for groups of projects to establish a group level
   task board should it fit their needs (for tracking a release for
   instance)
- Makes the most semantic sense, as the ‘KDE’ top level group suggested
   in option 2 is duplicative considering the Gitlab instance is under
   kde.org.
- The discoverability of projects is maximised, as there is no need to
   open the top level ‘KDE’ group before going into the subgroup.

I've worked on draft "move" of the current set of the repositories in
their respective subgroups at the repo-metadata project's branch [1].
You can browse the directory structure to get idea of how final
structure on Gitlab would look like.

If we don't have any objections we would like to implement this next
week and move projects to https://invent.kde.org.

Thanks!
Bhushan for sysadmin team

[1] 
https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent





D29347: KAuthorized: export method to reload restrictions

2020-05-02 Thread Albert Astals Cid
aacid added a comment.


  So how you're going to use it from unittests? declaring the function there?
  
  maybe better to declare it to some of the _p.h headers ?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D29347

To: dfaure, aacid, apol, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29210: [NestedListHelper] Fix indentation of selection, add tests

2020-05-02 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

BRANCH
  change-indent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29210

To: poboiko, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel


D29208: [NestedListHelper] Improve indentation code

2020-05-02 Thread Igor Poboiko
This revision was automatically updated to reflect the committed changes.
Closed by commit R310:18a2371fe394: [NestedListHelper] Improve indentation code 
(authored by poboiko).

REPOSITORY
  R310 KTextWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29208?vs=81738=81743

REVISION DETAIL
  https://phabricator.kde.org/D29208

AFFECTED FILES
  src/widgets/krichtextedit.cpp
  src/widgets/nestedlisthelper.cpp
  src/widgets/nestedlisthelper_p.h

To: poboiko, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


Re: Information regarding upcoming Gitlab Migration

2020-05-02 Thread Alexander Potashev
On Fri, May 1, 2020 at 10:14 PM Ben Cooksley  wrote:
> On Sat, May 2, 2020 at 6:17 AM Alexander Potashev  
> wrote:
> > I have a similar use case. Sometimes I need to share a URL to a
> > project. For this purpose I used to share e.g.
> > https://cgit.kde.org/releaseme.git/about
> >
> > Does this migration make such permalinks impossible?
> >
> >
> > From what I see, we lose permalinks because
> >  1. cgit.kde.org will be discontinued
>
> We provide the commits.kde.org redirector for permanent links.
> Anywhere needing a long life link to a particular repository, commit,
> etc (like documentation) should be using these links and not anything
> else.

This is helpful. Thank you Ben!

-- 
Alexander Potashev


D29363: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  Given the amounts of changes only to be applied directly after a KF tagging, 
to give translators as much time as possible to catch up.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29363

To: kossebau, #frameworks, #localization, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29363: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau created this revision.
kossebau added reviewers: Frameworks, Localization, cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Also fix some tooltip text styles to follow KDE HIG

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  usemoreuicontextmarker

REVISION DETAIL
  https://phabricator.kde.org/D29363

AFFECTED FILES
  src/kactionselector.cpp
  src/kassistantdialog.cpp
  src/kcharselect.cpp
  src/kcolorcombo.cpp
  src/kdatepicker.cpp
  src/kdatetimeedit.cpp
  src/keditlistwidget.cpp
  src/kfontchooser.cpp
  src/kfontchooserdialog.cpp
  src/kfontrequester.cpp
  src/kmessagewidget.cpp
  src/kmimetypechooser.cpp
  src/knewpassworddialog.cpp
  src/kpassworddialog.cpp
  src/kpasswordlineedit.cpp
  src/kpixmapregionselectordialog.cpp
  src/kpixmapregionselectorwidget.cpp
  src/ksqueezedtextlabel.cpp

To: kossebau, #frameworks, #localization, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29362: [KCharSelect] Initially give focus to the search lineedit

2020-05-02 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, cfeck.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  If the search lineedit widget is added, give it initial focus, so that you
  launch the dialogue and start typing to find the character you want;
  (much like a web browser).

TEST PLAN
  make && ctest

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-searchline-focus-initial (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29362

AFFECTED FILES
  src/kcharselect.cpp

To: ahmadsamir, #frameworks, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28932: Store filename terms just once

2020-05-02 Thread Stefan Brüns
bruns edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28932

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D28932: Store filename terms just once

2020-05-02 Thread Stefan Brüns
bruns added a comment.


  Ping!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28932

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D29361: KCrash: remove debug output which breaks unittests from using ~/.qttest/config for categorized logging

2020-05-02 Thread David Faure
dfaure created this revision.
dfaure added reviewers: kossebau, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  kdebugsettings --test-mode allows to tune the categorized logging for 
unittests,
  but if a very early qCDebug happens, QLoggingRegistry::initializeRules is 
called
  before the unittest gets a chance to call 
QStandardPaths::setTestModeEnabled(true).
  
  This is obviously a bit fragile overall; should all unittests do that in a 
constructor function? A bit ugly...

REPOSITORY
  R285 KCrash

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29361

AFFECTED FILES
  src/kcrash.cpp

To: dfaure, kossebau, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29208: [NestedListHelper] Improve indentation code

2020-05-02 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R310 KTextWidgets

BRANCH
  unused (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29208

To: poboiko, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29208: [NestedListHelper] Improve indentation code

2020-05-02 Thread Igor Poboiko
poboiko updated this revision to Diff 81738.
poboiko added a comment.


  Improve readability as suggested, also const'ify

REPOSITORY
  R310 KTextWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29208?vs=81256=81738

BRANCH
  unused (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29208

AFFECTED FILES
  src/widgets/krichtextedit.cpp
  src/widgets/nestedlisthelper.cpp
  src/widgets/nestedlisthelper_p.h

To: poboiko, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29208: [NestedListHelper] Improve indentation code

2020-05-02 Thread David Faure
dfaure added inline comments.

INLINE COMMENTS

> poboiko wrote in nestedlisthelper.cpp:87
> That's the current block being checked, not the next one. I've just checked 
> to be sure, last block can be unindented :)
> 
> TBH, I don't really know if it's even possible for the current block to be 
> invalid (that would probably mean that `textCursor()` returned by `QTextEdit` 
> is invalid?). 
> I've just borrowed this particular check from the old code...

Oh. I see. Well, it would be much more readable to move that if() *before* the 
line that declares and sets nextBlock.

And yes I can't really see how this can happen, either.

> nestedlisthelper.cpp:93
>  }
> -
> -QTextCursor cursor = textEdit->textCursor();
> -bool handled = false;
> -
> -if (!cursor.hasSelection() && cursor.currentList()) {
> -
> -// Check if we're on the last list item.
> -// itemNumber is zero indexed
> -QTextBlock currentBlock = cursor.block();
> -if (cursor.currentList()->count() == 
> cursor.currentList()->itemNumber(currentBlock) + 1) {
> -// Last block in this list, but may have just gained another 
> list below.
> -if (currentBlock.next().textList()) {
> -reformatList();
> -}
> -
> -// No need to reformatList in this case. reformatList is slow.
> -if ((event->key() == Qt::Key_Return) || (event->key() == 
> Qt::Key_Backspace)) {
> -handled = true;
> -}
> -} else {
> -reformatList();
> -}
> +if (!nextBlock.textList()) {
> +return true;

nextBlock is only used here so I would move its definition to just before this 
line.

(same thing in the previous method, about prevBlock)

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29208

To: poboiko, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29358: Implement lock-screen visibility control on Android

2020-05-02 Thread Volker Krause
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This is only the backend part, lacking a proper frontend API this is
  using a custom hint for now. Android knows three levels for this:
  
  - public: visible completely on the lock screen
  - private: lock screen only shows that $app has notifications
  - secret: nothing shown on the lock screen at all

REPOSITORY
  R289 KNotifications

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D29358

AFFECTED FILES
  src/android/org/kde/knotifications/KNotification.java
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/notifybyandroid.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause updated this revision to Diff 81731.
vkrause added a comment.


  Replace the simple ref count with a full child id tracking.
  
  The ref count got out of sync when an existing notification is updated, using 
a set fixes that.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29335?vs=81725=81731

BRANCH
  grouping

REVISION DETAIL
  https://phabricator.kde.org/D29335

AFFECTED FILES
  src/android/org/kde/knotifications/KNotification.java
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/notifybyandroid.cpp

To: vkrause, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

2020-05-02 Thread Niccolò Venerandi
niccolove accepted this revision as: niccolove.
niccolove added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  heading-only-if-svg-exists (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29352

To: filipf, #vdg, #plasma, niccolove
Cc: niccolove, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause added a comment.


  Still not good enough, updating existing notfication messes up the 
refcounter, resulting still in leftover group elements.

REPOSITORY
  R289 KNotifications

BRANCH
  grouping

REVISION DETAIL
  https://phabricator.kde.org/D29335

To: vkrause, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29357: Display rich text notification messages on Android (API level 24+)

2020-05-02 Thread Volker Krause
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D29357

AFFECTED FILES
  src/android/org/kde/knotifications/KNotification.java
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/notifybyandroid.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29357: Display rich text notification messages on Android (API level 24+)

2020-05-02 Thread Volker Krause
vkrause added a comment.


  Example: F8278136: Screenshot_20200502_112835.PNG 


REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29357

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29254: [RenameDialog] Add an arrow indicating direction from src to dest

2020-05-02 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:baa38ebee32e: [RenameDialog] Add an arrow indicating 
direction from src to dest (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29254?vs=81628=81728

REVISION DETAIL
  https://phabricator.kde.org/D29254

AFFECTED FILES
  src/widgets/renamedialog.cpp

To: ahmadsamir, #frameworks, dfaure, meven, ngraham, #dolphin
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28745: Skip caching thumbnails on encrypted filesystems

2020-05-02 Thread Marcin Gurtowski
marcingu added a comment.


  PING!
  Is current code fine or should we get rid of KMountPoint completely somehow?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, rdieter, mikesomov


D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause updated this revision to Diff 81725.
vkrause added a comment.


  Explicitly track if notification groups are still in use.
  
  This fixes group summaries staying active when we explicitly
  close a notification, rather then having the user or system
  dismiss it.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29335?vs=81678=81725

BRANCH
  grouping

REVISION DETAIL
  https://phabricator.kde.org/D29335

AFFECTED FILES
  src/android/org/kde/knotifications/KNotification.java
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/notifybyandroid.cpp

To: vkrause, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause added a comment.


  This isn't good to go yet, there are corner cases where the group summary 
item stays around after closing the last notification, working on fixing this.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29335

To: vkrause, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29339: Implement updating of notifications on Android

2020-05-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:c5688295e45f: Implement updating of notifications on 
Android (authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29339?vs=81686=81722#toc

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29339?vs=81686=81722

REVISION DETAIL
  https://phabricator.kde.org/D29339

AFFECTED FILES
  src/notifybyandroid.cpp
  src/notifybyandroid.h

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29323: Handle multi-line and rich-text notifications on Android

2020-05-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:9bfd98a3d3da: Handle multi-line and rich-text 
notifications on Android (authored by vkrause).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29323?vs=81657=81721

REVISION DETAIL
  https://phabricator.kde.org/D29323

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/notifybyandroid.cpp

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns