D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread Kåre Särs
sars added a comment. I'm starting to think that we need an option for enabling/disabling this change/feature. I would not want to have the extra space between the lines, but at the same time I can see that actually not seeing the whole character is not an acceptable situation...

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread Frederick Yin
fakefred added a comment. In D25339#663322 , @rjvbb wrote: > but that's hardly the domain of application for a text editing framework. It's "KTextEditor", not "KCodeEditor". This rendering issue, though not from an "intended purpose",

D29436: Use font: instead of font.pointSize: where possible

2020-05-04 Thread Nathaniel Graham
ngraham retitled this revision from "Use theme.smallestFont instead of various ad-hoc alternatives" to "Use font: instead of font.pointSize: where possible". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library)

D29436: Use theme.smallestFont instead of various ad-hoc alternatives

2020-05-04 Thread Nathaniel Graham
ngraham added a reviewer: cblack. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29436 To: ngraham, #plasma, cblack Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29436: Use theme.smallestFont instead of various ad-hoc alternatives

2020-05-04 Thread Nathaniel Graham
ngraham updated this revision to Diff 81959. ngraham added a comment. Revert a thing that shoudnta been thunged REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29436?vs=81957=81959 BRANCH use-whole-font (branched from master) REVISION

D29436: Use theme.smallestFont instead of various ad-hoc alternatives

2020-05-04 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Diff should be fairly self-explanatory. We should be using `font:

D29434: Use small font for ExpandableListItem subtitle

2020-05-04 Thread Nathaniel Graham
ngraham updated this revision to Diff 81956. ngraham marked an inline comment as done. ngraham added a comment. Use the whole font, not just the point size REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29434?vs=81951=81956 BRANCH

D29434: Use small font for ExpandableListItem subtitle

2020-05-04 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > ExpandableListItem.qml:434 > visible: text.length > 0 > +font.pointSize: theme.smallestFont.pointSize > `font: theme.smallestFont` REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-04 Thread Allen Winter
winterz added a comment. I committed this one for Weisi Dai REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29374 To: weisi, winterz, davidedmundson Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-04 Thread Allen Winter
This revision was automatically updated to reflect the committed changes. Closed by commit R175:682b18f75ca7: holidays/plan2/holiday_gb-sct_en-gb (authored by weisi, committed by winterz). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29374?vs=81773=81953

D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread David Faure
dfaure added a comment. Yep, doing it already. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D29427 To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread Friedrich W. H. Kossebau
kossebau added a comment. 5.70 wants this as appended commit, no? REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D29427 To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29434: Use small font for ExpandableListItem subtitle

2020-05-04 Thread Kai Uwe Broulik
broulik added a comment. Yes, please! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29434 To: ngraham, #plasma, #vdg, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29434: Use small font for ExpandableListItem subtitle

2020-05-04 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, VDG, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY We're moving towards using the small font for subtitles in Kirigami

D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R294:8a282319bc9e: [KBookmarkMenu] Assign m_actionCollection early to prevent crash (authored by ahmadsamir). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE

D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH l-bookmarkmenu-assign-actioncoll (branched from master) REVISION DETAIL https://phabricator.kde.org/D29427 To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella Cc:

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-04 Thread Allen Winter
winterz accepted this revision. winterz added a comment. do you need me to commit this for you? my fault. I should have run the test that looks for the syntax errors .. I don't recall doing that. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29374 To:

D29415: Add holiday file for DE-BE (Germany/Berlin)

2020-05-04 Thread Allen Winter
winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. I don't know German and I don't know the Berlin holidays. but the tests pass and in general things look fine. REPOSITORY R175 KHolidays BRANCH master REVISION DETAIL

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread Shinjo Park
pshinjo added a comment. In D25339#663462 , @rjvbb wrote: > This patch is only needed when mixing a main Latin1 (like) alphanumeric font with occasional glyphs from a font that have a different, taller height? Yes, though the "occasion"

D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread Ahmad Samir
ahmadsamir added a reviewer: nicolasfella. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D29427 To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread René J . V . Bertin
rjvbb added a comment. This patch is only needed when mixing a main Latin1 (like) alphanumeric font with occasional glyphs from a font that have a different, taller height? Am I right that any text that uses only a single font will see some form of significant loss of the number of

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 80 - Fixed!

2020-05-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/80/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 04 May 2020 20:17:25 + Build duration: 5 min 14 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.14 - Build # 59 - Still unstable!

2020-05-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.14/59/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 04 May 2020 19:52:40 + Build duration: 23 min and counting JUnit Tests Name:

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.14 - Build # 32 - Fixed!

2020-05-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.14/32/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 04 May 2020 19:52:42 + Build duration: 6 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.12 - Build # 195 - Fixed!

2020-05-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/195/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 May 2020 19:52:38 + Build duration: 5 min 15 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knewstuff » kf5-qt5 FreeBSDQt5.14 - Build # 34 - Fixed!

2020-05-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/34/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 04 May 2020 19:52:35 + Build duration: 4 min 30 sec and counting JUnit Tests Name:

D28932: Store filename terms just once

2020-05-04 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:7605f4d7f7c4: Store filename terms just once (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28932?vs=80439=81937 REVISION DETAIL

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread Shinjo Park
pshinjo added a comment. In D25339#563370 , @xuetianweng wrote: > And what I'd like to point is, for CJK users, it is uncommon for them to select a single font to cover all the characters, because such fonts are really rare. People usually

D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread Ahmad Samir
ahmadsamir added a reviewer: kossebau. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D29427 To: ahmadsamir, #frameworks, dfaure, kossebau Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread Ahmad Samir
ahmadsamir added a subscriber: rikmills. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D29427 To: ahmadsamir, #frameworks, dfaure Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY The deprecated ctor that took a KActionCollection param called the new ctor (that doesn't take an

D28932: Store filename terms just once

2020-05-04 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Sorry for the delay. Makes sense. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28932 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel,

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread René J . V . Bertin
rjvbb requested changes to this revision. rjvbb added a comment. This revision now requires changes to proceed. I can't speak for the special cases where this change would improve matters, but for me it introduces a clear regression (waste of vertical space: 12 lines less) in a basic ascii

D29200: test the extractNothing flag

2020-05-04 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:5e1ed919bdf6: test the extractNothing flag (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29200?vs=81237=81928 REVISION DETAIL

D29199: honor the extractMetaData flag

2020-05-04 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:538c34b58057: honor the extractMetaData flag (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81258=81927 REVISION DETAIL

D28800: Always create actioncollection

2020-05-04 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kbookmarkmenu.cpp:69 > { > m_actionCollection = actionCollection; > } This resetting of m_actionCollection in the constructor taking an actionCollection still results in issues, as this KBookmarkMenu constructor taking an

D29231: Add keyboard_shortcuts_inhibit protocol

2020-05-04 Thread Nathaniel Graham
ngraham added a dependent revision: D29272: Add support to keyboard shortcuts inhibitor. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29231 To: bport, zzag, davidedmundson, apol Cc: romangg, crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29420: Generate DBus interface

2020-05-04 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We already use a generated interface in

D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-05-04 Thread Alexander Lohnau
alex updated this revision to Diff 81918. alex added a comment. Merge branch master REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29123?vs=81476=81918 BRANCH arcpatch-D29123_1 REVISION DETAIL https://phabricator.kde.org/D29123 AFFECTED FILES

D28932: Store filename terms just once

2020-05-04 Thread Stefan Brüns
bruns added a comment. This has been pending for more than two weeks now, without any sort of review ... @ngraham If you have any questions, please ask! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28932 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel,

D29396: Suppress find_package_handle_standard_args package name mismatch warning.

2020-05-04 Thread Xuetian Weng
This revision was automatically updated to reflect the committed changes. Closed by commit R240:8d181637a033: Suppress find_package_handle_standard_args package name mismatch warning. (authored by xuetianweng). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D29415: Add holiday file for DE-BE (Germany/Berlin)

2020-05-04 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The generic DE file doesn't really work anymore since Berlin got creative in adding non-standard public holidays.

D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Aleix Pol Gonzalez
apol added a comment. > If I understand correctly, it is necessary to use dbus spectacle in this case, so that dbus can manage the application instance and make sure we end up with only one, whether we launch the app, use a shortcut or launch from command line. I don't think that's a

D29414: Be noisy about deprecated KPageWidgetItem::setHeader(empty-non-null string)

2020-05-04 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R236 KWidgetsAddons BRANCH warnaboutdeprecatedemptynonnullheader REVISION

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 37 - Unstable!

2020-05-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/37/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 04 May 2020 14:35:43 + Build duration: 2 min 6 sec and counting JUnit Tests

D29412: Add smallFont to Kirigami plasma style

2020-05-04 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R242:68d5995c6352: Add smallFont to Kirigami plasma style (authored by cblack). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29412?vs=81897=81898

D29412: Add smallFont to Kirigami plasma style

2020-05-04 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH cblack/smallfont-kirigami (branched from master) REVISION DETAIL https://phabricator.kde.org/D29412 To: cblack, #kirigami, mart Cc: kde-frameworks-devel,

D29412: Add smallFont to Kirigami plasma style

2020-05-04 Thread Carson Black
cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. TEST PLAN F8283833: ksnip_20200504-102619.png REPOSITORY R242

D29409: Add documentation line on KCM translations

2020-05-04 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > configmodule.h:98 > + * > + * Translation domain will be set to "kcm_componentName" from the KAboutData > as described above. > + * You probably want to use backticks instead of quotes as this is referring to something codewise. REPOSITORY

D29409: Add documentation line on KCM translations

2020-05-04 Thread David Edmundson
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D29409 AFFECTED FILES

D29336: Remove galago from method/variable naming

2020-05-04 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R289:2012f675aed2: Remove galago from method/variable naming (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29336?vs=81680=81892

D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Kai Uwe Broulik
broulik added a comment. > Maybe we need something similar to `X-GNOME-UsesNotifications=true` Or we just also use that :D REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29405 To: nicolasfella, #frameworks, broulik, vkrause Cc: apol,

D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Nicolas Fella
nicolasfella added a comment. In D29405#662963 , @apol wrote: > Won't this make it harder to put together the notifications kcm? Good point, we use the notifyrc file to know which apps send notifications ahead of time. Maybe we need

D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Nicolas Fella
nicolasfella added a comment. We want to phase out notifyrc files for several reasons: - They are an overkill for many simple use cases - A common pitfall when using KNotifications are missing or incorrect notifyrc files - Most of the information in there is duplicate/overridden at

D17816: Support for xattrs on kio copy/move

2020-05-04 Thread Nathaniel Graham
ngraham added a comment. Ping @cochise REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika,

D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Méven Car
meven added a comment. In D29406#662932 , @apol wrote: > This should be documented somewhere, as is it's really confusing. I am not sure where to document this, but agrees this is needed. Will look on existing documentation to find the

D29336: Remove galago from method/variable naming

2020-05-04 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH nogalago REVISION DETAIL https://phabricator.kde.org/D29336 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Aleix Pol Gonzalez
apol added a comment. What's the advantage? Won't this make it harder to put together the notifications kcm? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29405 To: nicolasfella, #frameworks, broulik, vkrause Cc: apol, kde-frameworks-devel, LeGast00n,

D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Méven Car
meven added a dependent revision: D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D29406 To: meven, #frameworks, davidedmundson, apol, bport Cc: kde-frameworks-devel,

D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Aleix Pol Gonzalez
apol added a comment. This should be documented somewhere, as is it's really confusing. I'm not sure it wouldn't be better to have spectacle launched again there instead of going through dbus (which is a change I admittedly don't understand very well). REPOSITORY R309 KService

D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, davidedmundson, apol, bport. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Sometimes Exec entries are replaced by qdbus invocation

D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY In KNotificationManager when reading the actions

D29256: [server] Introduce mapped() signal

2020-05-04 Thread Vlad Zahorodnii
zzag closed this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29256 To: zzag, #kwin, davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29381: Thumbnail text: use libmagic to detect encoding

2020-05-04 Thread Harald Sitter
sitter added a comment. I have zero background knowledge here, but it really feels like there must be an existing solution to this problem other than libmagic. Like how does kate figure out the encoding of a text file. INLINE COMMENTS > Findlibmagic.cmake:1 > +# - Try to find libssh > +#

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Alexander Lohnau
alex updated this revision to Diff 81873. alex added a comment. Increase @since to 5.71 REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29201?vs=81856=81873 BRANCH service_path_append (branched from master) REVISION DETAIL

KDE CI: Frameworks » knewstuff » kf5-qt5 FreeBSDQt5.14 - Build # 33 - Still Failing!

2020-05-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/33/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 04 May 2020 10:53:22 + Build duration: 51 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » knewstuff » kf5-qt5 FreeBSDQt5.14 - Build # 32 - Failure!

2020-05-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/32/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 04 May 2020 10:45:47 + Build duration: 7 min 31 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.14 - Build # 58 - Failure!

2020-05-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.14/58/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 04 May 2020 10:45:47 + Build duration: 4 min 58 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.12 - Build # 194 - Still Failing!

2020-05-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/194/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 May 2020 10:48:08 + Build duration: 1 min 41 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.14 - Build # 31 - Still Failing!

2020-05-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.14/31/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 04 May 2020 10:47:21 + Build duration: 57 sec and counting CONSOLE OUTPUT [...truncated 195

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.12 - Build # 193 - Failure!

2020-05-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/193/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 May 2020 10:45:47 + Build duration: 2 min 18 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.14 - Build # 30 - Failure!

2020-05-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.14/30/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 04 May 2020 10:45:47 + Build duration: 1 min 31 sec and counting CONSOLE OUTPUT [...truncated

D29222: Fix update auto selection

2020-05-04 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:12642a1c0174: Fix update auto selection (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29222?vs=81412=81869 REVISION DETAIL

D28701: Add KPackage support to KNewStuffCore

2020-05-04 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:3f38da8a70d8: Add KPackage support to KNewStuffCore (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28701?vs=81859=81868 REVISION DETAIL

D29222: Fix update auto selection

2020-05-04 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH fix-update-autoselection (branched from master) REVISION DETAIL https://phabricator.kde.org/D29222 To: leinir, #frameworks, #plasma, bugseforuns, ngraham, mart Cc:

D28701: Add KPackage support to KNewStuffCore

2020-05-04 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH add-kpackage-support (branched from master) REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson,

D28701: Add KPackage support to KNewStuffCore

2020-05-04 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 81859. leinir added a comment. Since we have had a new Frameworks release while this is waiting for the thumbs up, increase the @since to the next version. - Merge branch 'master' into add-kpackage-support - Merge branch 'master' into

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Alexander Lohnau
alex added a reviewer: mart. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D29201 To: alex, #plasma, ngraham, meven, broulik, mart Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Alexander Lohnau
alex updated this revision to Diff 81856. alex added a comment. Linebreak REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29201?vs=81855=81856 BRANCH service_path_append (branched from master) REVISION DETAIL https://phabricator.kde.org/D29201

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Alexander Lohnau
alex updated this revision to Diff 81855. alex added a comment. Improve documentation Is that what you had in mind :-) ? And should I maybe add a comment to make this the default in KF6? REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread Frederick Yin
fakefred added a comment. So I tested this, great improvements regarding line height can be seen: F8283136: kate_1.png 在使用本身就是 CJK 的字体时,显示仍然正常。 F8283141: kate_2.png REPOSITORY R39 KTextEditor REVISION

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Marco Martin
mart added a comment. indeed, a bit more documentation then go for it REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D29201 To: alex, #plasma, ngraham, meven, broulik Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 79 - Failure!

2020-05-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/79/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 04 May 2020 09:03:39 + Build duration: 5 min 5 sec and counting CONSOLE OUTPUT [...truncated 80

D28499: [LauncherJobs] Emit description

2020-05-04 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:692d9bc81f00: [LauncherJobs] Emit description (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28499?vs=79700=81849#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D29381: Thumbnail text: use libmagic to detect encoding

2020-05-04 Thread Méven Car
meven added a comment. In D29381#662084 , @pino wrote: > why not KEncodingProber from the KCodecs framework, like also the commented bits hint about? I tested first KEncodingProber, it just returns bad data, returning "UTF-8" sometimes

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

2020-05-04 Thread David Faure
dfaure updated this revision to Diff 81840. dfaure added a comment. Remove local-files fast path. This also showed a small mistake in the handling of error texts (this job isn't a KIO::Job so we need to call buildErrorString ourselves). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-04 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > previewjob.cpp:717 > +qreal imgDevicePixelRatio; > +str >> width >> height >> iFormat >> imgDevicePixelRatio; > QImage::Format format

D29197: filenamesearch: Implement stat to display metainfo

2020-05-04 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R320:951e2f2d49a8: filenamesearch: Implement stat to display metainfo (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29197?vs=81232=81837

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-04 Thread Méven Car
meven created this revision. meven added reviewers: dfaure, broulik, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Allow users of KPreviewJob to request a devicePixelRatio for generated