D29223: Update Taiwanese holidays

[N. Higa]

nhiga set the repository for this revision to R175 KHolidays.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29223

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, 
fbampaloukas, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

Re: kcoreaddons_add_plugin executable/plugin directory conflict

[David Faure]

On lundi 11 mai 2020 14:07:28 CEST Friedrich W. H. Kossebau wrote:
> Am Montag, 11. Mai 2020, 10:21:10 CEST schrieb Daniel Vrátil:
> > Hi all,
> > 
> > I'm moving some plugins in kaddressbook and I ran into a problem with
> 
> > kcoreaddons_add_plugin:
> Problem found because you require ECM >= 5.38, triggering the use of the
> CMAKE_BUILD_DIR/bin as executable artifact placement dir by
> KDECMakeSettings, compare
> https://api.kde.org/ecm/kde-module/KDECMakeSettings.html#build-settings
> > I have this in the plugin CMakeLists.txt:
> > 
> > kaddressbook_add_plugin(
> > 
> > kaddressbook_importexportvcardplugin
> > JSON kaddressbook_importexportvcardplugin.json
> > SOURCES ${kaddressbook_importexport_vcard_SRCS}
> > INSTALL_NAMESPACE kaddressbook/importexportplugin
> > 
> > )
> > 
> > When I run make on the entire project, it fails with
> > 
> > [ 65%] Linking CXX shared module ../../../../bin/kaddressbook/
> > importexportplugin/kaddressbook_importexportvcardplugin.so
> > ld: error: cannot open output file ../../../../bin/kaddressbook/
> > importexportplugin/kaddressbook_importexportvcardplugin.so: Not a
> > directory
> > 
> > Alternatively, if a plugin gets created first, it fails on
> > 
> > [ 96%] Linking CXX executable ../bin/kaddressbook
> > ld: error: cannot open output file ../bin/kaddressbook: Is a directory
> > 
> > I realized the problem is that CMake is unable to create the plugin in
> > $BUILDDIR/bin/kaddressbook/importexportplugin/ directory, because there's
> > already $BUILDDIR/bin/kaddressbook executable (or vice versa).
> > 
> > I would assume this is a very common problem - having plugins "namespaced"
> > in the same directory as is the name of the program (and executable).

I didn't anticipate this because that name conflict with an executable doesn't 
happen in KDE Frameworks,
where the install namespace starts with kf5 :(

> > Should the macro maybe put the plugins into
> > "$BUILDDIR/bin/plugins/$INSTALL_NAMESPACE/"? Would that make the lookup
> > any more complicated?

Yes, at least that was the initial reasoning, because "." is a default search 
path for plugins in Qt. But see below.

> > Is there some known solution/workaround to this? I'd prefer not to have to
> > rename the executable or the plugins namespaces, since having different
> > name for the program and the plugin "namespace" somewhat defeats the
> > purpose of a namespace...

Well, for kontact I used kontact5 as plugin namespace, to avoid ever risking a 
mixup between qt5/kf5-based plugins and qt6/kf6-based plugins.
This sounds like a good solution to both problems.

But otherwise:

I later realized that while '.' is in the search path, it has less priority 
than QT_PLUGIN_PATH,
so it was picking up my installed plugins instead of the locally built ones.
So now modules/ECMAddTests.cmake sets the QT_PLUGIN_PATH env var for when 
running tests (https://phabricator.kde.org/D8660).
Therefore we could indeed move all plugins to a subdir.
The attached patches do that.

We however lose the magic of finding plugins in $PWD, when running a 
test/program directly (rather than via ctest)
(i.e. like an IDE would run them), if the plugins aren't otherwise available in 
the system.

So I'm thinking how about just adding a 5? :-)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
diff --git i/KF5CoreAddonsMacros.cmake w/KF5CoreAddonsMacros.cmake
index d7cc464..e443d2c 100644
--- i/KF5CoreAddonsMacros.cmake
+++ w/KF5CoreAddonsMacros.cmake
@@ -126,7 +126,7 @@ function(kcoreaddons_add_plugin plugin)
 # If find_package(ECM 5.38) or higher is called, output the plugin in a INSTALL_NAMESPACE subfolder.
 # See https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled
 if(NOT ("${ECM_GLOBAL_FIND_VERSION}" VERSION_LESS "5.38.0"))
-set_target_properties(${plugin} PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/${KCA_ADD_PLUGIN_INSTALL_NAMESPACE}")
+set_target_properties(${plugin} PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/plugins/${KCA_ADD_PLUGIN_INSTALL_NAMESPACE}")
 endif()
 
 if (NOT KCA_ADD_PLUGIN_INSTALL_NAMESPACE)
diff --git i/modules/ECMAddTests.cmake w/modules/ECMAddTests.cmake
index eb9601c..2d98cfe 100644
--- i/modules/ECMAddTests.cmake
+++ w/modules/ECMAddTests.cmake
@@ -121,7 +121,7 @@ function(ecm_add_test)
   set(PATHSEP ":")
 endif()
 set(_plugin_path $ENV{QT_PLUGIN_PATH})
-set_property(TEST ${_testname} PROPERTY ENVIRONMENT QT_PLUGIN_PATH=${CMAKE_LIBRARY_OUTPUT_DIRECTORY}${PATHSEP}${_plugin_path})
+set_property(TEST ${_testname} PROPERTY ENVIRONMENT QT_PLUGIN_PATH=${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/plugins${PATHSEP}${_plugin_path})
   endif()
   if (ARG_TARGET_NAME_VAR)
 set(${ARG_TARGET_NAME_VAR} "${_targetname}" PARENT_SCOPE)

D29414: Be noisy about deprecated KPageWidgetItem::setHeader(empty-non-null string)

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:a5692448a750: Be noisy about deprecated 
KPageWidgetItem::setHeader(empty-non-null string) (authored by kossebau).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29414?vs=81902=82613

REVISION DETAIL
  https://phabricator.kde.org/D29414

AFFECTED FILES
  src/kpagewidgetmodel.cpp
  src/kpagewidgetmodel.h

To: kossebau, #frameworks, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28221: Don't write default value to configuration file when default value came from /etc/* file

[Benjamin Port]

bport updated this revision to Diff 82612.
bport added a comment.


  Simplify the patch and adapt unittest
  
  I expected revertToDefault to revert either to cpp defined default or default 
from global file, but concept behind is to revert only for cpp based default.

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28221?vs=82028=82612

REVISION DETAIL
  https://phabricator.kde.org/D28221

AFFECTED FILES
  autotests/kconfigskeletontest.cpp
  autotests/kconfigskeletontest.h
  autotests/kconfigtest.cpp
  autotests/kconfigtest.h
  src/core/kconfigdata.cpp

To: bport, ervin, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27203: Don't try to open files we can't figure out where they are

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kdeplatformfiledialoghelper.cpp:226
> +//passing non-local files as the working directory is not supported.
> +//See QFileDialogPrivate::initialSelections
> +//Selectingg files should be done through the correct method.

That's not what that method says. It just says it can't know if the initial 
*selection* is a file or directory.

That's unrelated to what is the start directory.

QFileDialogPrivate::workingDirectory does support remote dirs.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26066: [KProcessInfo] Add parent PID

[David Faure]

dfaure added a comment.


  Yep, seems fine to me.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26066

To: broulik, #frameworks, davidedmundson
Cc: meven, dfaure, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29668: Do not reject icon theme dir with invalid context/type.

[David Faure]

dfaure added a comment.


  What are the values of Context and Type?
  
  "Legacy" and "UI" ?
  
  I can't see anything in index.theme 
https://ftp.gnome.org/pub/GNOME/sources/adwaita-icon-theme/3.36/

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29668

To: xuetianweng, #frameworks, dfaure, apol
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29668: Do not reject icon theme dir with invalid context/type.

[David Edmundson]

davidedmundson added a comment.


  Seems sensible, given it's valid to have an empty context.
  
  I don't know enough about icons to know all possible ill effects. If there's 
no other comments in a few days consider this a "ship it!"

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29668

To: xuetianweng, #frameworks, dfaure, apol
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29667: Export metalist to json file

[Carson Black]

cblack updated this revision to Diff 82608.
cblack added a comment.


  Dump output information as well

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29667?vs=82603=82608

BRANCH
  cblack/metadata (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29667

AFFECTED FILES
  src/kapidox/hlfunctions.py

To: cblack, ochurlaud
Cc: bcooksley, kde-frameworks-devel, kde-doc-english, ognarb, LeGast00n, 
cblack, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D29668: Do not reject icon theme dir with invalid context/type.

[Xuetian Weng]

xuetianweng edited the test plan for this revision.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29668

To: xuetianweng, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29668: Do not reject icon theme dir with invalid context/type.

[Xuetian Weng]

xuetianweng added reviewers: dfaure, apol.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29668

To: xuetianweng, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29668: Do not reject icon theme dir with invalid context/type.

[Xuetian Weng]

xuetianweng edited the test plan for this revision.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29668

To: xuetianweng, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29668: Do not reject icon theme dir with invalid context/type.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
xuetianweng requested review of this revision.

REVISION SUMMARY
  For example, gnome's default theme adwaita has their own context type like
  Legacy/UI. This check prevents the icon with such lines to be rendered for Qt 
app
  running under KDE. Even if it would result in some unexpected result, it's 
still
  better than not rendering the icon.

TEST PLAN
  Test with gnome default icon theme.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29668

AFFECTED FILES
  src/kicontheme.cpp

To: xuetianweng, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/15/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 11 May 2020 18:38:33 +
 Build duration:
1 min 42 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D29292: Port KKeySequenceItem to QQC2

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:c730edc8dce4: Port KKeySequenceItem to QQC2 (authored by 
davidedmundson).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29292?vs=81557=82604

REVISION DETAIL
  https://phabricator.kde.org/D29292

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml
  tests/keysequencetest.qml

To: davidedmundson, #plasma, davidre, ngraham
Cc: ngraham, cblack, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D29123: Do not mark entry as uninstalled if uninstallation script failed

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:a2ecdd333c49: Do not mark entry as uninstalled if 
uninstallation script failed (authored by alex).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29123?vs=82228=82606

REVISION DETAIL
  https://phabricator.kde.org/D29123

AFFECTED FILES
  src/core/engine.cpp
  src/core/installation.cpp
  src/core/installation.h

To: alex, #knewstuff, meven, ngraham, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29667: Export metalist to json file

[Carson Black]

cblack created this revision.
cblack added a reviewer: ochurlaud.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This will allow tooling to better introspect the generated pages.

REPOSITORY
  R264 KApiDox

BRANCH
  cblack/metadata (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29667

AFFECTED FILES
  src/kapidox/hlfunctions.py

To: cblack, ochurlaud
Cc: bcooksley, kde-frameworks-devel, kde-doc-english, ognarb, LeGast00n, 
cblack, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D29123: Do not mark entry as uninstalled if uninstallation script failed

[Alexander Lohnau]

alex marked 4 inline comments as done.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D29123_1

REVISION DETAIL
  https://phabricator.kde.org/D29123

To: alex, #knewstuff, meven, ngraham, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29390: Respect QIcon::fallbackSearchpaths()

[Nicolas Fella]

nicolasfella updated this revision to Diff 82600.
nicolasfella added a comment.


  - Use array

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29390?vs=81821=82600

BRANCH
  fallback

REVISION DETAIL
  https://phabricator.kde.org/D29390

AFFECTED FILES
  src/kiconloader.cpp

To: nicolasfella, #plasma, #frameworks
Cc: kossebau, aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29390: Respect QIcon::fallbackSearchpaths()

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> aacid wrote in kiconloader.cpp:1142
> I just realized that function is private, not really easy to use :/
> 
> anyhow do you think we should remove svgz?
> 
> Also i think using
> 
> const QStringList extensions = { QStringLiteral(".png"), 
> QStringLiteral(".svg"), QStringLiteral(".svgz"), QStringLiteral(".xpm") };
> 
> should be a bit faster

I copied that list from somewhere else in KIconLoader. It would seem weird to 
me to support a different set of formats in the fallback than in the regular 
path

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29390

To: nicolasfella, #plasma, #frameworks
Cc: kossebau, aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29631: [android] Allow specifying APK install location

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:a70e9a0162f7: [android] Allow specifying APK install 
location (authored by nicolasfella).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29631?vs=82531=82569

REVISION DETAIL
  https://phabricator.kde.org/D29631

AFFECTED FILES
  toolchain/Android.cmake
  toolchain/ECMAndroidDeployQt.cmake

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29357: Display rich text notification messages on Android

[Volker Krause]

vkrause retitled this revision from "Display rich text notification messages on 
Android (API level 24+)" to "Display rich text notification messages on 
Android".

REPOSITORY
  R289 KNotifications

BRANCH
  rich-text

REVISION DETAIL
  https://phabricator.kde.org/D29357

To: vkrause, tfella
Cc: z3ntu, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29357: Display rich text notification messages on Android (API level 24+)

[Volker Krause]

vkrause updated this revision to Diff 82566.
vkrause added a comment.


  Support API level < 24 as well.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29357?vs=81729=82566

BRANCH
  rich-text

REVISION DETAIL
  https://phabricator.kde.org/D29357

AFFECTED FILES
  src/android/org/kde/knotifications/KNotification.java
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/notifybyandroid.cpp

To: vkrause, tfella
Cc: z3ntu, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29634: sftp: break large writes into multiple requests

[Alexander Saoutkin]

feverfew added a comment.


  Seems like something similar should also occur in `FileJob::write`?

INLINE COMMENTS

> kio_sftp.cpp:1831-1832
> +while (offset < buffer.size()) {
> +const auto length = qMin(MAX_XFER_BUF_SIZE, 
> buffer.size());
> +ssize_t bytesWritten = sftp_write(file, buffer.data() + 
> offset, length);
> +if (bytesWritten < 0) {

AFAICT the size of the buffer never changes so this will easily cause a buffer 
overrun if I'm not mistaken?

Say for example you have a buffer with `buffer.size() == MAX_XFER_BUF_SIZE + 
1`. Then on the second iteration of the while loop (assuming `bytesWritten == 
MAX_XFER_BUF_SIZE`) you'll do a `sftp_write()` pointing to a `char` buffer of 
size 1, but which incorrectly states that the size is `MAX_XFER_BUF_SIZE`.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29634

To: sitter, ngraham
Cc: feverfew, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29631: [android] Allow specifying APK install location

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  androinstall

REVISION DETAIL
  https://phabricator.kde.org/D29631

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixbuildwithoutdeprecated

REVISION DETAIL
  https://phabricator.kde.org/D29600

To: kossebau, #plasma, mart, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29634: sftp: break large writes into multiple requests

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  servers have arbitrary limits that we should stay below. to ensure this
  happens use MAX_XFER_BUF_SIZE as maximum size per request. if we read
  data large than that, break it apart into multiple requests
  
  (I am mostly guessing here, the rfc doesn't seem to impose any size
   constraint on the write requests themselves, so probably packet
   constraints apply by default)
  
  BUG: 404890
  FIXED-IN: 20.04.2

TEST PLAN
  - fallocate -l 128M file
  - sftp to localhost
  - copy file from one dir to another

REPOSITORY
  R320 KIO Extras

BRANCH
  release/20.04

REVISION DETAIL
  https://phabricator.kde.org/D29634

AFFECTED FILES
  sftp/kio_sftp.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29631: [android] Allow specifying APK install location

[Nicolas Fella]

nicolasfella updated this revision to Diff 82531.
nicolasfella added a comment.


  - Rename variable

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29631?vs=82527=82531

BRANCH
  androinstall

REVISION DETAIL
  https://phabricator.kde.org/D29631

AFFECTED FILES
  toolchain/Android.cmake
  toolchain/ECMAndroidDeployQt.cmake

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29631: [android] Allow specifying APK install location

[Nicolas Fella]

nicolasfella marked 2 inline comments as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29631

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D27203: Don't try to open files we can't figure out where they are

[Méven Car]

meven accepted this revision.
meven added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kdeplatformfiledialoghelper.cpp:226
> +//passing non-local files as the working directory is not supported.
> +//See QFileDialogPrivate::initialSelections
> +//Selectingg files should be done through the correct method.

QFileDialogPrivate::initialSelection

> kdeplatformfiledialoghelper.cpp:227
> +//See QFileDialogPrivate::initialSelections
> +//Selectingg files should be done through the correct method.
> +m_fileWidget->setUrl(directory);

typo Selectingg

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29631: [android] Allow specifying APK install location

[Aleix Pol Gonzalez]

apol added a comment.


  +1 overall, good idea.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29631

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29631: [android] Allow specifying APK install location

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> Android.cmake:93
>  #
> -# The APK would then be found in ``myapp_build_apk/bin`` in the build 
> directory.
> +# You can specify the APK output directory by setting 
> ANDROID_APK_INSTALL_DIR.
> +# Otherwise the APK can be found in ``myapp_build_apk/`` in the build 
> directory.

ANDROID_APK_INSTALL_DIR should be between quotes like other variables.
Also I'd call the variable ANDROID_APK_OUTPUT_DIR. We have an install concept 
already.

> ECMAndroidDeployQt.cmake:85
>  add_custom_target(install-apk-${QTANDROID_EXPORTED_TARGET}
>  COMMAND adb install -r 
> "${EXPORT_DIR}/${QTANDROID_EXPORTED_TARGET}-${CMAKE_ANDROID_ARCH_ABI}.apk"
>  )

Needs adapting.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29631

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D18883: Add PDF thumbnailer

[Méven Car]

meven added a comment.


  In D18883#424888 , @aacid wrote:
  
  > Also do we have a way to limit thumbnailers to run say for X seconds? 
There's some files in which poppler will run "forever"
  
  
  kio-extras thumbnail is a an ioslave so I guess we can add it simply.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: meven, bruns, dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, 
kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

D29631: [android] Allow specifying APK install location

[Nicolas Fella]

nicolasfella added a comment.


  This is used in https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/68

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29631

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D27203: Don't try to open files we can't figure out where they are

[Nathaniel Graham]

ngraham added a comment.


  Does this fix https://bugs.kde.org/show_bug.cgi?id=408174?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27203: Don't try to open files we can't figure out where they are

[Nathaniel Graham]

ngraham added reviewers: meven, ahmadsamir.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27203: Don't try to open files we can't figure out where they are

[Nathaniel Graham]

ngraham added a reviewer: dfaure.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29631: [android] Allow specifying APK install location

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, Android, apol, vkrause.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  This allows `make create-apk` to directly write the APK to /output instead of 
the cp-with-prefix step in /opt/helpers/create-apk. It's also useful for manual 
development builds where one would need to copy it to some output location 
manually or for CI setups that expect the output in a certain location.
  
  If ANDROID_APK_INSTALL_DIR is not set the current behaviour is kept.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  androinstall

REVISION DETAIL
  https://phabricator.kde.org/D29631

AFFECTED FILES
  toolchain/Android.cmake
  toolchain/ECMAndroidDeployQt.cmake

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Allen Winter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R175:7f7533260efc: holidayregion.cpp - provide translatable 
strings for the German regions. (authored by winterz).

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29575?vs=82442=82525

REVISION DETAIL
  https://phabricator.kde.org/D29575

AFFECTED FILES
  src/holidayregion.cpp

To: winterz, vkrause
Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D18883: Add PDF thumbnailer

[Nathaniel Graham]

ngraham added a comment.


  Yeah, seems like this got bikeshedded to death but I think it would still be 
quite worthwhile to have.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: meven, bruns, dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, 
kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis updated this revision to Diff 82520.
araujoluis added a comment.


  - kwidgetsaddons: kcolorcombo: set a constant variables.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29502?vs=82517=82520

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

AFFECTED FILES
  src/kcolorcombo.cpp
  src/kcolorcombo.h
  tests/kcolorcombotest.cpp

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked 2 inline comments as done.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre updated this revision to Diff 82519.
davidre added a comment.


  - fix

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28208?vs=82492=82519

BRANCH
  sni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28208

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidre, kmaterka, broulik, mart, #plasma, #vdg, #frameworks
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[patrick j pereira]

patrickelectric accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[patrick j pereira]

patrickelectric added inline comments.

INLINE COMMENTS

> kcolorcombo.cpp:67
>  // inner color
> +QVariant tv = index.data(Qt::DisplayRole);
>  QVariant cv = index.data(ColorRole);

Missing const.

> kcolorcombo.cpp:69
>  QVariant cv = index.data(ColorRole);
> +QColor innerColor = ((cv.type() == QVariant::Color) ? cv.value() 
> : QPalette::Base);
> +

missing const.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D26066: [KProcessInfo] Add parent PID

[Méven Car]

meven added subscribers: dfaure, meven.
meven added a comment.


  In D26066#598036 , @broulik wrote:
  
  > Am now using ksysguard..
  
  
  I think this would makes sense, and is a nice addition to `KProcessInfo`.
  @dfaure an opinion ?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26066

To: broulik, #frameworks, davidedmundson
Cc: meven, dfaure, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked 2 inline comments as done.
araujoluis added inline comments.

INLINE COMMENTS

> cblack wrote in kcolorcombo.cpp:90
> I would probably do what Kirigami does for `ColorUtils::brightnessForColor` 
> here: `((0.299 * color.red() + 0.587 * color.green() + 0.114 * color.blue()) 
> / 255) > 0.5 ? Qt::black : Qt::white`

Done!

> cfeck wrote in kcolorcombo.cpp:89
> Please don't use "value" component to calculate the brightness of a color. 
> #81 is much darker than #808080. To decide, use qGray(). The threshold 
> also needs to be higher than 128; I use 170, but this mostly depends on 
> correctness of monitor gamma settings.
> 
> See  
> https://stackoverflow.com/questions/3942878/how-to-decide-font-color-in-white-or-black-depending-on-background-color

Done!

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked 2 inline comments as done.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked 2 inline comments as done.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis updated this revision to Diff 82517.
araujoluis added a comment.


  - kwidgetsaddons: kcolorcombo: fix paint font colors and simplify painting

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29502?vs=82484=82517

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

AFFECTED FILES
  src/kcolorcombo.cpp
  src/kcolorcombo.h
  tests/kcolorcombotest.cpp

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

Re: kcoreaddons_add_plugin executable/plugin directory conflict

[Friedrich W. H. Kossebau]

Am Montag, 11. Mai 2020, 10:21:10 CEST schrieb Daniel Vrátil:
> Hi all,
> 
> I'm moving some plugins in kaddressbook and I ran into a problem with
> kcoreaddons_add_plugin:

Problem found because you require ECM >= 5.38, triggering the use of the 
CMAKE_BUILD_DIR/bin as executable artifact placement dir by KDECMakeSettings, 
compare https://api.kde.org/ecm/kde-module/KDECMakeSettings.html#build-settings

> I have this in the plugin CMakeLists.txt:
> 
> kaddressbook_add_plugin(
>   kaddressbook_importexportvcardplugin
>   JSON kaddressbook_importexportvcardplugin.json
>   SOURCES ${kaddressbook_importexport_vcard_SRCS}
>   INSTALL_NAMESPACE kaddressbook/importexportplugin
> )
> 
> When I run make on the entire project, it fails with
> 
> [ 65%] Linking CXX shared module ../../../../bin/kaddressbook/
> importexportplugin/kaddressbook_importexportvcardplugin.so
> ld: error: cannot open output file ../../../../bin/kaddressbook/
> importexportplugin/kaddressbook_importexportvcardplugin.so: Not a directory
> 
> Alternatively, if a plugin gets created first, it fails on
> 
> [ 96%] Linking CXX executable ../bin/kaddressbook
> ld: error: cannot open output file ../bin/kaddressbook: Is a directory
> 
> I realized the problem is that CMake is unable to create the plugin in
> $BUILDDIR/bin/kaddressbook/importexportplugin/ directory, because there's
> already $BUILDDIR/bin/kaddressbook executable (or vice versa).
> 
> I would assume this is a very common problem - having plugins "namespaced"
> in the same directory as is the name of the program (and executable).
> Should the macro maybe put the plugins into
> "$BUILDDIR/bin/plugins/$INSTALL_NAMESPACE/"? Would that make the lookup any
> more complicated?
> 
> Is there some known solution/workaround to this? I'd prefer not to have to
> rename the executable or the plugins namespaces, since having different name
> for the program and the plugin "namespace" somewhat defeats the purpose of
> a namespace...

kdeconnect solved this by renaming before, but not with much happiness.

Okular recently in some (later discarded) patches raising min ECM was about to 
hit the same issue as well, there the hint by David was to manually overwrite 
the LIBRARY_OUTPUT_DIRECTORY property for the plugin targets.

Open question is how any changed path there effects the goal of being able to 
run tests against the uninstalled plugins...

Cheers
Friedrich

D28460: Add KCModuleData as base class for plugin

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> kcmoduledata.h:35
> + *
> + * @since 5.70
> + */

@since 5.71

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28460

To: bport, #plasma, ervin
Cc: meven, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28460: Add KCModuleData as base class for plugin

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> kcmoduleloader.h:113
> + *
> + * @since 5.69
> + */

@since 5.71

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28460

To: bport, #plasma, ervin
Cc: meven, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R175 KHolidays

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29575

To: winterz, vkrause
Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> SpinBox.qml:54
> +// Because we're stomping the Text Input's own mouse handling
> +textField.forceActiveFocus()
> +}

You can do `mouse.accepted = false` instead of forceActiveFocus to allow the 
mouse press to go to items below it. However, you might instead want to use 
DragHandler's onActiveChanged for this, as that signals when the actual drag is 
active.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D29357: Display rich text notification messages on Android (API level 24+)

[Luca Weiss]

z3ntu added a comment.


  I don't see a reason why rich text should be limited to API24+? Yes, the 
`fromHtml(String source, int flags)` method is API 24+ but for APIs lower than 
that you can use `fromHtml(String source)` as for example wrapped in 
`androidx.core.text.HtmlCompat`:
  
/**
* Invokes {@link Html#fromHtml(String, int)} on API 24 and newer, 
otherwise {@code flags} are
* ignored and {@link Html#fromHtml(String)} is used.
*/
@NonNull
public static Spanned fromHtml(@NonNull String source, @FromHtmlFlags int 
flags) {
if (Build.VERSION.SDK_INT >= 24) {
return Html.fromHtml(source, flags);
}
//noinspection deprecation
return Html.fromHtml(source);
}

REPOSITORY
  R289 KNotifications

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D29357

To: vkrause, tfella
Cc: z3ntu, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

kcoreaddons_add_plugin executable/plugin directory conflict

[Daniel Vrátil]

Hi all,

I'm moving some plugins in kaddressbook and I ran into a problem with 
kcoreaddons_add_plugin:

I have this in the plugin CMakeLists.txt:

kaddressbook_add_plugin(
kaddressbook_importexportvcardplugin
JSON kaddressbook_importexportvcardplugin.json
SOURCES ${kaddressbook_importexport_vcard_SRCS}
INSTALL_NAMESPACE kaddressbook/importexportplugin
)

When I run make on the entire project, it fails with

[ 65%] Linking CXX shared module ../../../../bin/kaddressbook/
importexportplugin/kaddressbook_importexportvcardplugin.so
ld: error: cannot open output file ../../../../bin/kaddressbook/
importexportplugin/kaddressbook_importexportvcardplugin.so: Not a directory

Alternatively, if a plugin gets created first, it fails on

[ 96%] Linking CXX executable ../bin/kaddressbook
ld: error: cannot open output file ../bin/kaddressbook: Is a directory

I realized the problem is that CMake is unable to create the plugin in 
$BUILDDIR/bin/kaddressbook/importexportplugin/ directory, because there's 
already $BUILDDIR/bin/kaddressbook executable (or vice versa).

I would assume this is a very common problem - having plugins "namespaced" in 
the same directory as is the name of the program (and executable). Should the 
macro maybe put the plugins into "$BUILDDIR/bin/plugins/$INSTALL_NAMESPACE/"? 
Would that make the lookup any more complicated?

Is there some known solution/workaround to this? I'd prefer not to have to 
rename the executable or the plugins namespaces, since having different name 
for the program and the plugin "namespace" somewhat defeats the purpose of a 
namespace...

/Dan

-- 
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683

signature.asc
Description: This is a digitally signed message part.

D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre updated this revision to Diff 82492.
davidre added a comment.


  - Rebase without test

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28208?vs=78982=82492

BRANCH
  sni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28208

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidre, kmaterka, broulik, mart, #plasma, #vdg, #frameworks
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart