D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-24 Thread Méven Car
meven marked an inline comment as done. meven added a comment. In D29397#673758 , @ngraham wrote: > Overall seems sane. Two questions though: > Is this @2x suffix standardized? No but it is already being used for icon caching.

Re: KEmoticons, emoticons kcm

2020-05-24 Thread Aleix Pol
On Sun, May 24, 2020 at 3:09 AM Sandro Knauß wrote: > Hi, > > > Now while I know why this exists, it feels like it's more of a thing > > of the past from when people wrote :) instead of . > > Okay now I feeling old :-) - I don't even know how to create a unicode > smiley, that's why I always

Re: New Framework Review: KDAV

2020-05-24 Thread Aleix Pol
On Sun, May 24, 2020 at 8:52 AM Volker Krause wrote: > > The remaining issues that didn't change ABI anymore (movable value types, hide > private methods/slots inside the private classes, etc) have long since been > addressed. > > I think there's two possible time slots to actually execute the

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-24 Thread Stefan Brüns
bruns accepted this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter, dfaure, ngraham Cc: ngraham, dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-24 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. LGTM. @bruns? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter, dfaure, ngraham Cc: ngraham, dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29525: Make Previews devicePixelRatio aware

2020-05-24 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. (once the dependent patches have landed) REPOSITORY R318 Dolphin BRANCH arcpatch-D29525 REVISION DETAIL https://phabricator.kde.org/D29525 To: meven, #dolphin, #frameworks,

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-24 Thread Nathaniel Graham
ngraham added a comment. Overall seems sane. Two questions though: INLINE COMMENTS > previewjob.cpp:401 > +thumbPath = thumbRoot + QLatin1String(cacheWidth == 128 ? "normal" : > "large"); > +thumbPath.append(qFuzzyCompare(devicePixelRatio, 2) ? > QStringLiteral("@2x/") :

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-05-24 Thread Albert Astals Cid
aacid added a comment. Personally I'm happy enough with this, i guess wait a few days and if noone disagrees, land it REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29826 To: poboiko, aacid, mart, broulik Cc: mart, kde-frameworks-devel, LeGast00n, cblack,

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-24 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D29747#671169 , @svuorela wrote: > I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate. `@deprecated since 5.69 Prefer preferredSize() or trueMinimumSize().`

D28528: UDSEntry: add constructor variant with std::initializer_list

2020-05-24 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision. kossebau added a comment. As I am not sure about the risk introduced by the just-works-currently alignment in the union, I would rather discard this patch for now. Going from union to having both fields increases the runtime for what I measured, despite

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 21 - Still Unstable!

2020-05-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/21/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 24 May 2020 15:31:57 + Build duration: 8 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 22 - Still Unstable!

2020-05-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/22/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 24 May 2020 15:27:05 + Build duration: 7 min 14 sec and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 20 - Still Unstable!

2020-05-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/20/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 24 May 2020 15:22:07 + Build duration: 9 min 48 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 21 - Still Unstable!

2020-05-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/21/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 24 May 2020 15:22:07 + Build duration: 4 min 53 sec and counting JUnit Tests Name:

D17816: Support for xattrs on kio copy/move

2020-05-24 Thread Gleb Popov
arrowd updated this revision to Diff 83143. arrowd marked 5 inline comments as done. arrowd added a comment. - Refactor common code from compareXattr() into readXattr() as requested in comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 51 - Unstable!

2020-05-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/51/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 24 May 2020 14:05:48 + Build duration: 7 min 4 sec and counting JUnit Tests

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

2020-05-24 Thread Friedrich W. H. Kossebau
kossebau added a comment. @junghans Hi. Do you have push rights, or do you need someone to merge your patch? REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack,

D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

2020-05-24 Thread Friedrich W. H. Kossebau
kossebau closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29600 To: kossebau, #plasma, mart, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-05-24 Thread Igor Poboiko
poboiko updated this revision to Diff 83141. poboiko added a comment. Sure, it's a temporary workaround anyways :) Update comment: add TODO mark and link to @aacid Qt patch REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29826?vs=83129=83141 BRANCH

D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED

2020-05-24 Thread Friedrich W. H. Kossebau
kossebau closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D29574 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: KEmoticons, emoticons kcm

2020-05-24 Thread Sandro Knauß
Hi, > Now while I know why this exists, it feels like it's more of a thing > of the past from when people wrote :) instead of . Okay now I feeling old :-) - I don't even know how to create a unicode smiley, that's why I always create these :-) smileys. hefee

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-24 Thread Méven Car
meven updated this revision to Diff 83140. meven added a comment. Rebasing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=83139=83140 BRANCH arcpatch-D29397 REVISION DETAIL https://phabricator.kde.org/D29397 AFFECTED FILES

Re: New Framework Review: KDAV

2020-05-24 Thread Volker Krause
The remaining issues that didn't change ABI anymore (movable value types, hide private methods/slots inside the private classes, etc) have long since been addressed. I think there's two possible time slots to actually execute the move to frameworks now: * ASAP, for the June release. * For the