D26113: Places: Use Solid::Device::DisplayName for DisplayRole

meven updated this revision to Diff 83162. meven added a comment. Update to new Solid::Device::DisplayName REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26113?vs=79277=83162 BRANCH arcpatch-D26113 REVISION DETAIL https://phabricator.kde.org/D26113

D29461: Fix kio-extras build on Windows

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH arcpatch-D29461 REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx,

D29814: Fix segfault on no restart args

jpalecek added a reviewer: dfaure. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29810: Don't use the setenv function after fork

jpalecek added a reviewer: dfaure. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek, #frameworks, dfaure Cc: bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D29809: Don't invoke qstring localized stuff in critical section

jpalecek added a reviewer: dfaure. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29809 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29810: Don't use the setenv function after fork

jpalecek added inline comments. INLINE COMMENTS > bruns wrote in kcrash.cpp:698 > `std::copy_if`, instead of a separate `remove_if` pass. Thanks for that suggestion, updated accordingly. I admit I'm still more accustomed to the old ways of `remove_if`. REPOSITORY R285 KCrash REVISION

D29810: Don't use the setenv function after fork

jpalecek updated this revision to Diff 83160. jpalecek marked an inline comment as done. jpalecek added a comment. Change remove_if and copy to copy_if, per suggestion REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29810?vs=83137=83160 BRANCH

D29668: Do not reject icon theme dir with invalid context/type.

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kicontheme.cpp:761 > } else if (tmp.isEmpty()) { > // do nothing. key not required > } else { (OK, if this key is not required then surely

D29461: Fix kio-extras build on Windows

brute4s99 added a comment. updated libssh to use version 0.9.4 by default in Craft. We can merge this and get  for kio-extras builds. \o/ REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven,

D29461: Fix kio-extras build on Windows

brute4s99 marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack,

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/19/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 26 May 2020 19:31:35 + Build duration: 51 sec and counting JUnit Tests Name:

D29461: Fix kio-extras build on Windows

brute4s99 marked 3 inline comments as done. brute4s99 added inline comments. INLINE COMMENTS > vonreth wrote in CMakeLists.txt:26 > yes pls update libssh Hi! Sorry, I got around to this patch quite late. I added a new patch for 0.9.4 release as parent revision to this revision, please take a

D29461: Fix kio-extras build on Windows

brute4s99 added a dependency: D29835: Add libssh 0.9.4 to fix kio-extras on windows. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov,

D29461: Fix kio-extras build on Windows

brute4s99 updated this revision to Diff 83159. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29461?vs=82069=83159 BRANCH arcpatch-D29461 REVISION DETAIL https://phabricator.kde.org/D29461 AFFECTED FILES sftp/CMakeLists.txt sftp/kio_sftp.cpp To:

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.12 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.12/96/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 26 May 2020 15:48:39 + Build duration: 4 min 43 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » krunner » kf5-qt5 FreeBSDQt5.14 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20FreeBSDQt5.14/20/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 26 May 2020 15:48:38 + Build duration: 2 min 41 sec and counting JUnit Tests Name:

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.14/19/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 26 May 2020 15:48:38 + Build duration: 2 min 31 sec and counting BUILD ARTIFACTS

D29668: Do not reject icon theme dir with invalid context/type.

xuetianweng added a comment. In D29668#669069 , @dfaure wrote: > What are the values of Context and Type? > > "Legacy" and "UI" ? > > I can't see anything in index.theme https://ftp.gnome.org/pub/GNOME/sources/adwaita-icon-theme/3.36/

D29668: Do not reject icon theme dir with invalid context/type.

xuetianweng added a comment. You can try to install one from your distro to check the actual content. index.theme is generated during the "configure & make". REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29668 To: xuetianweng, #frameworks, dfaure, apol Cc:

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

vkrause added a comment. PIM has been fully adapted meanwhile, only https://phabricator.kde.org/D29478 missing I think. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack,

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/28/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 26 May 2020 12:13:26 + Build duration: 2 min 0 sec and counting JUnit Tests Name:

Re: Recent breakage in kwallet

here's my understanding of the problem: firstly, this is likely only a problem on debian-derived systems. and also only with blowfish debian has this patch [1] which on *actual* little endian systems (x86,arm64...) would run the conditional branches. the thing to note is that not only QBO is

Re: Recent breakage in kwallet

Thanks for the pointer. Pretty sure it's wrong, but I'll reply there. On mardi 26 mai 2020 09:31:26 CEST Marco Martin wrote: > would the recent patch > https://invent.kde.org/frameworks/kwallet/-/merge_requests/1 > fix anything? > > On Sat, May 16, 2020 at 10:40 AM David Faure wrote: > > On

Re: Recent breakage in kwallet

would the recent patch https://invent.kde.org/frameworks/kwallet/-/merge_requests/1 fix anything? On Sat, May 16, 2020 at 10:40 AM David Faure wrote: > > On vendredi 15 mai 2020 12:43:37 CEST Marco Martin wrote: > > Hi all, > > Recently, the package of KWallet framework for neon (devel unstable,

D29832: Fix Endianness issue during wallet decryption

chriscz added a comment. Hi @ngraham Thanks for letting me know! I've opened the PR over on gitlab: https://invent.kde.org/frameworks/kwallet/-/merge_requests/1. It must be quite a mission getting everyone over to new platforms   REPOSITORY R311 KWallet REVISION DETAIL

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

junghans added a comment. Thank you for committing! Although I recently gained push rights, I did not have time yet to dig into the details of how to create/push commit respecting the KDE standards etc. Next time, I'll try on my own :) REPOSITORY R275 KItemModels REVISION DETAIL