D26113: Places: Use Solid::Device::DisplayName for DisplayRole

meven added a comment. In D26113#674129 , @dfaure wrote: > Please check that kfileplacesmodeltest and kfileplacesviewtest still pass. Just did, nothing changed, it is expected : only fstab declared filesystem or manually mounted fs

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 143 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/143/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 30 May 2020 04:48:46 + Build duration: 11 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 640 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/640/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 May 2020 04:48:46 + Build duration: 8 min 45 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 141 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/141/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 30 May 2020 04:48:46 + Build duration: 8 min 58 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 142 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/142/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 29 May 2020 22:35:07 + Build duration: 8 min 58 sec and counting JUnit Tests Name:

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I have modified DesktopExecParser in kio commit d1e9325fba37eddb9cb44173edfc1fee122a0c57 to return an

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

dfaure added a comment. Please check that kfileplacesmodeltest and kfileplacesviewtest still pass. (they fail here with baloosearch: stuff for some reason, I didn't investigate; but it passes on CI) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven,

D29814: Fix segfault on no restart args

dfaure added a comment. Can you explain how to trigger this crash in the first place? Which application triggers it? INLINE COMMENTS > jpalecek wrote in kcrash.cpp:272 > Well I was thinking about `resize()`, then found there wasn't any. However, > if we want to be clear, maybe `args = {

D29051: Add ecm_generate_dbus_service_file

kossebau added a comment. A unit test would be good to have. The test for ECMGeneratePkgConfigFile might be a sample for this. INLINE COMMENTS > ECMGenerateDBusServiceFile.cmake:17 > +# > +# A D-Bus service file ``.service` will will be generated and > installed > +# in the relevant D-Bus

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

ahmadsamir added inline comments. INLINE COMMENTS > kopenwithdialog.cpp:1009 > +if (QDir::isAbsolutePath(binaryName)) { > +QFileInfo fi(binaryName); > +if (fi.exists() && !fi.isExecutable()) { It's created on the next line. Anyway my initial comment

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

broulik added inline comments. INLINE COMMENTS > ahmadsamir wrote in kopenwithdialog.cpp:1008 > https://doc.qt.io/qt-5.15/qfileinfo.html#isAbsolute ? But I don't want to create a `QFIleInfo` just because REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29445 To: broulik,

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

ahmadsamir added inline comments. INLINE COMMENTS > broulik wrote in kopenwithdialog.cpp:1008 > Actually, that doesn't exist https://doc.qt.io/qt-5.15/qfileinfo.html#isAbsolute ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29445 To: broulik, #frameworks, #vdg Cc:

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven added a comment. ping @pino REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29806: Thumbnail folders: scale down sub image when their height is too big

meven abandoned this revision. meven added a comment. Moved to https://invent.kde.org/network/kio-extras/-/merge_requests/2 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29806 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, waitquietly,

D21555: [KFilePlacesModel] Explicitly query for PTP cameras

broulik abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21555 To: broulik, #frameworks, bruns Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

broulik added inline comments. INLINE COMMENTS > broulik wrote in kopenwithdialog.cpp:1008 > Forgot that also existed, will update Actually, that doesn't exist REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29445 To: broulik, #frameworks, #vdg Cc: ahmadsamir, dfaure,

D21126: [KUiServerJobTracker] Register jobs asynchronously

broulik abandoned this revision. broulik added a comment. I've got a jobviewv2 thing in the works which is qvariantmap-based so it can easily queue any changes and send them out once registered. I think jobviewv1 should just stay as is and be phased out eventually, cf. T12574

D21127: [KDynamicJobTracker] Ask kuiserver asynchronously

broulik abandoned this revision. broulik added a comment. I've got a jobviewv2 thing in the works which is qvariantmap-based so it can easily queue any changes and send them out once registered. I think jobviewv1 should just stay as is and be phased out eventually, cf. T12574

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/24/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 29 May 2020 06:33:26 + Build duration: 9 min 32 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/25/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 29 May 2020 06:33:26 + Build duration: 6 min 3 sec and counting JUnit Tests Name: