D29397: KPreviewJob : Support for DeviceRatioPixel

2020-06-08 Thread Nathaniel Graham
ngraham added a comment. The proposed additions to the spec are non-controversial IMO. Let's push that forward. I left a supportive comment in the email thread, so maybe it's time to put together a patch that people can comment on. REPOSITORY R241 KIO REVISION DETAIL

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2020-06-08 Thread Dawid Wrobel
wrobelda added a comment. @cullmann I will do my best to try and test it with KMyMoney this coming weekend. I'll keep you posted. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l Cc:

KDE CI: Frameworks » kcrash » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Still Failing!

2020-06-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/18/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 08 Jun 2020 17:35:49 + Build duration: 36 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.14 - Build # 18 - Still Unstable!

2020-06-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.14/18/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 08 Jun 2020 17:37:22 + Build duration: 20 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 183 - Still Unstable!

2020-06-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/183/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 08 Jun 2020 17:37:21 + Build duration: 3 min 34 sec and counting BUILD ARTIFACTS

D27223: add kirigami-gallery icon

2020-06-08 Thread Noah Davis
ndavis added a comment. I think I'd prefer to keep this similar to the original Kirigami icon. Do you mind if I commandeer this? I've already made the changes. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert, mart, #vdg, ndavis, ngraham Cc:

D27223: add kirigami-gallery icon

2020-06-08 Thread Noah Davis
ndavis added a comment. I noticed that the lighting in this version of the Kirigami is flipped. Is that intentional? I don't think it makes sense for the top of the K popout to be darker than the bottom. Since the light in Breeze icons comes from the top left, the top should be light, like

D27223: add kirigami-gallery icon

2020-06-08 Thread Mathis Brüchert
mbruchert added a comment. I believe everything should be fixed now REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert, mart, #vdg, ndavis, ngraham Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D27223: add kirigami-gallery icon

2020-06-08 Thread Mathis Brüchert
mbruchert updated this revision to Diff 83252. mbruchert added a comment. - fix color REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27223?vs=83251=83252 BRANCH kirigami_galery (branched from master) REVISION DETAIL

D27223: add kirigami-gallery icon

2020-06-08 Thread Mathis Brüchert
mbruchert updated this revision to Diff 83251. mbruchert added a comment. - align pixel grid - fix typo - fix overlapping bug REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27223?vs=75859=83251 BRANCH kirigami_galery (branched from master)

D28355: Introduce function ecm_install_configured_file

2020-06-08 Thread David Edmundson
davidedmundson added a comment. Moved to invent. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28355 To: davidedmundson, #build_system Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham,

D28355: Introduce function ecm_install_configured_file

2020-06-08 Thread David Edmundson
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:2976b27a6c0b: Introduce function ecm_install_configured_file (authored by davidedmundson). REPOSITORY R240 Extra

D27223: add kirigami-gallery icon

2020-06-08 Thread Marco Martin
mart added a comment. can we fix this and go ahead? @mbruchert can you still work on it? want to put it on invent? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert, mart, #vdg, ndavis, ngraham Cc: ngraham, ognarb, ndavis,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2020-06-08 Thread Christoph Cullmann
cullmann added a comment. That depends. If somebody else would test this and we can agree that this is a nicer way to hard-code breeze icons compared to having that code in kiconthemes it would make sense. REPOSITORY R266 Breeze Icons REVISION DETAIL

KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.12 - Build # 97 - Fixed!

2020-06-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.12/97/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 08 Jun 2020 08:30:51 + Build duration: 2 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.14 - Build # 14 - Fixed!

2020-06-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.14/14/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 08 Jun 2020 08:30:51 + Build duration: 1 min 41 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ki18n » kf5-qt5 FreeBSDQt5.14 - Build # 13 - Fixed!

2020-06-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20FreeBSDQt5.14/13/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 08 Jun 2020 08:30:51 + Build duration: 43 sec and counting JUnit Tests Name: projectroot

D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

2020-06-08 Thread David Redondo
davidre added a comment. Ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29463 To: Zren, #kirigami, mart Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns