D17816: Support for xattrs on kio copy/move

2020-06-23 Thread Gleb Popov
arrowd added inline comments. INLINE COMMENTS > bruns wrote in file_unix.cpp:625 > Infinite loop on valuelen == 0 Why? `ERANGE` means we need to come up with new value for `valuelen`, so we set it to zero and start over. On the new iteration it gets passed into `fgetxattr`/`extattr_get_fd` to

D17816: Support for xattrs on kio copy/move

2020-06-23 Thread Gleb Popov
arrowd updated this revision to Diff 83309. arrowd marked an inline comment as done. arrowd added a comment. - Improve comment. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83302=83309 BRANCH arcpatch-D17816 REVISION DETAIL https://phabricator.kde.org/D17816

D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions

2020-06-23 Thread Christophe Giboudeaux
cgiboudeaux added a comment. Can you create an invent MR? I'll look later REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28379 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns