D20026: Go up in folder hierachy when in "edit mode"

2020-07-11 Thread Nathaniel Graham
ngraham added a comment.


  Great! Can you Abandon this?

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D20026: Go up in folder hierachy when in "edit mode"

2020-07-11 Thread Mikhail Krutov
krutovmikhail added a comment.


  Thanks for the headsup!
  
  https://invent.kde.org/frameworks/kio/-/merge_requests/74

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D20026: Go up in folder hierachy when in "edit mode"

2020-07-11 Thread Nathaniel Graham
ngraham added a comment.


  Thanks for resuming the work on this!
  
  We've since moved to GitLab; could you open this up as a merge request at 
https://invent.kde.org/system/dolphin/-/merge_requests/?  Thanks!

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.15 - Build # 22 - Fixed!

2020-07-11 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.15/22/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Sun, 12 Jul 2020 01:42:08 +
 Build duration:
3 min 8 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

D20026: Go up in folder hierachy when in "edit mode"

2020-07-11 Thread Mikhail Krutov
krutovmikhail added a comment.


  So, I'm really sorry for *very* long absence in this context. Updated diff.. 
Which works. I'll go over style and things tomorrow.

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D20026: Go up in folder hierachy when in "edit mode"

2020-07-11 Thread Mikhail Krutov
krutovmikhail updated this revision to Diff 83328.
krutovmikhail added a comment.


  - fix build
  - Fixes for behaviour

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20026?vs=54897&id=83328

BRANCH
  arcpatch-D20026

REVISION DETAIL
  https://phabricator.kde.org/D20026

AFFECTED FILES
  src/CMakeLists.txt
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h
  src/widgets/kurlcombobox.cpp
  src/widgets/kurlcombobox.h

To: krutovmikhail, ngraham, #dolphin
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29163: RFC: Add document-replace icon (Like for Overwrite action)

2020-07-11 Thread David Hurka
davidhurka abandoned this revision.
davidhurka added a comment.


  Moved to https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/18

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29163

To: davidhurka, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

2020-07-11 Thread Kurt Hindenburg
hindenburg added a comment.


  What's the status of this?  Did it get moved to invent MR?

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham, #vdg
Cc: kossebau, cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns


Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-07-11 Thread Ben Cooksley
On Sun, Jul 12, 2020 at 3:23 AM Christoph Cullmann
 wrote:
>
> On 2020-07-09 10:03, Christoph Cullmann wrote:
> > On 2020-07-08 00:07, David Faure wrote:
> >> On mardi 7 juillet 2020 17:58:26 CEST Christoph Cullmann wrote:
> >>> On 2020-07-07 12:16, David Faure wrote:
> >>> > Yep :(
> >>> >
> >>> > You'll tell Simon and/or QTBUG-*?
> >>>
> >>> I will take a look if I can find some existing bug or open a new.
> >>>
> >>> Simon left Qt, or?
> >>
> >> Yes but I think that was already the case when he fixed the last one
> >> :-)
> >
> > I did so some research.
> >
> > Might this be fixed by
> >
> > https://code.qt.io/cgit/qt/qtdeclarative.git/commit/src/qml?h=5.15&id=082247604219316035484cfdc83662936df2edb5
> >
> > or
> >
> > https://code.qt.io/cgit/qt/qtdeclarative.git/commit/src/qml?h=5.15&id=082247604219316035484cfdc83662936df2edb5
> >
> > At least the backtraces in the referenced bugs look similar.
> >
> > That isn't in 5.15?
> >
> > Is there a chance to have the CI use some Qt with these backported?
> > (or is it already and it is a different issue?)
>
> I talked with Simon and very likely these commits in the 5.15 branch
> would fix our issues.
>
> Is there a change to get a patched Qt for the CI?

This is not exactly straight forward, but would be possible for Linux at least.
Windows would require they be adopted by Craft, and FreeBSD by the KDE
FreeBSD folks.

>
> If that fixes it, actually, it would be highly important to get these
> fixes in the distro Qt packages,
> otherwise all of KDE that uses the QJSEngine (or QML) will just randomly
> crash.

If SUSE pick up the patches, then the CI system will automatically
pick them up as we use OpenSUSE for the Linux CI images.

>
> Greetings
> Christoph

Regards,
Ben

>
> > Greetings
> > Christoph
>
> --
> Ignorance is bliss...
> https://cullmann.io | https://kate-editor.org


KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 7 - Still Unstable!

2020-07-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.15/7/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Sat, 11 Jul 2020 15:40:06 +
 Build duration:
52 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.72.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.72.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 4 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testAdaFailed: projectroot.autotests.kateindenttest_testCstyleFailed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)85%
(262/307)85%
(262/307)67%
(33049/49268)49%
(14784/30050)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src97%
(37/38)97%
(37/38)93%
(4786/5138)49%
(1812/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5528/5570)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1677/1892)74%
(1078/1464)src.completion100%
(11/11)100%
(11/11)57%
(1788/3134)42%
(1009/2425)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/865)0%
(0/184)src.document100%
(4/4)100%
(4/4)61%
(1936/3179)48%
(1407/2945)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor78%
(14/18)78%
(14/18)83%
(189/227)55%
(125/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1051)16%
(146/891)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(8/8)100%
(8/8)79%
(965/1227)68%
(619/914)src.schema22%
(2/9)22%
(2/9)1%
(19/1472)1%
(6/625)src.script94%
(16/17)94%
(

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.15 - Build # 7 - Still Unstable!

2020-07-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.15/7/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Sat, 11 Jul 2020 15:40:05 +
 Build duration:
6 min 57 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-07-11 Thread Christoph Cullmann

On 2020-07-09 10:03, Christoph Cullmann wrote:

On 2020-07-08 00:07, David Faure wrote:

On mardi 7 juillet 2020 17:58:26 CEST Christoph Cullmann wrote:

On 2020-07-07 12:16, David Faure wrote:
> Yep :(
>
> You'll tell Simon and/or QTBUG-*?

I will take a look if I can find some existing bug or open a new.

Simon left Qt, or?


Yes but I think that was already the case when he fixed the last one 
:-)


I did so some research.

Might this be fixed by

https://code.qt.io/cgit/qt/qtdeclarative.git/commit/src/qml?h=5.15&id=082247604219316035484cfdc83662936df2edb5

or

https://code.qt.io/cgit/qt/qtdeclarative.git/commit/src/qml?h=5.15&id=082247604219316035484cfdc83662936df2edb5

At least the backtraces in the referenced bugs look similar.

That isn't in 5.15?

Is there a chance to have the CI use some Qt with these backported?
(or is it already and it is a different issue?)


I talked with Simon and very likely these commits in the 5.15 branch 
would fix our issues.


Is there a change to get a patched Qt for the CI?

If that fixes it, actually, it would be highly important to get these 
fixes in the distro Qt packages,
otherwise all of KDE that uses the QJSEngine (or QML) will just randomly 
crash.


Greetings
Christoph


Greetings
Christoph


--
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org


KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 6 - Still Unstable!

2020-07-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.15/6/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Sat, 11 Jul 2020 10:05:11 +
 Build duration:
8 min 37 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.72.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.72.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)85%
(262/307)85%
(262/307)67%
(33067/49271)49%
(14792/30050)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src97%
(37/38)97%
(37/38)93%
(4804/5142)49%
(1812/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5528/5570)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1677/1892)74%
(1078/1464)src.completion100%
(11/11)100%
(11/11)57%
(1788/3134)42%
(1009/2425)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/864)0%
(0/184)src.document100%
(4/4)100%
(4/4)61%
(1939/3179)48%
(1409/2945)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor78%
(14/18)78%
(14/18)83%
(189/227)55%
(125/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1051)16%
(146/891)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(8/8)100%
(8/8)77%
(950/1227)67%
(610/914)src.schema22%
(2/9)22%
(2/9)1%
(19/1472)1%
(6/625)src.script94%
(16/17)94%
(16/17)68%
(707/1040)54%
 

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 355 - Fixed!

2020-07-11 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/355/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 11 Jul 2020 10:05:11 +
 Build duration:
6 min 5 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.72.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.72.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)86%
(265/307)86%
(265/307)68%
(33473/49294)50%
(15032/30054)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4849/5147)49%
(1819/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5528/5570)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)90%
(1700/1892)75%
(1099/1464)src.completion100%
(11/11)100%
(11/11)57%
(1788/3134)42%
(1009/2425)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/864)0%
(0/184)src.document100%
(4/4)100%
(4/4)61%
(1945/3179)48%
(1421/2945)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor78%
(14/18)78%
(14/18)90%
(205/227)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1051)16%
(146/891)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(8/8)100%
(8/8)79%
(965/1227)68%
(619/914)src.schema22%
(2/9)22%
(2/9)1%
(19/1472)1%
(6/625)src.script94%
(16/17)94%
(16/17)69%
(717/1040)56%
(226/403)src.search100%
(7/7)100%
   

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.15 - Build # 6 - Still Unstable!

2020-07-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.15/6/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Sat, 11 Jul 2020 10:05:11 +
 Build duration:
5 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testAdaFailed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testRubyName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 354 - Still Unstable!

2020-07-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/354/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 11 Jul 2020 09:30:37 +
 Build duration:
8 min 37 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.72.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.72.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.katedocument_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)86%
(265/307)86%
(265/307)68%
(33454/49294)50%
(15021/30054)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4848/5147)49%
(1818/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5528/5570)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)90%
(1700/1892)75%
(1099/1464)src.completion100%
(11/11)100%
(11/11)57%
(1788/3134)42%
(1009/2425)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/864)0%
(0/184)src.document100%
(4/4)100%
(4/4)61%
(1945/3179)48%
(1421/2945)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor78%
(14/18)78%
(14/18)90%
(205/227)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1051)16%
(146/891)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(8/8)100%
(8/8)77%
(950/1227)67%
(610/914)src.schema22%
(2/9)22%
(2/9)1%
(19/1472)1%
(6/625)src.script94%
(16/17)94%
(16/17)69%
(717/1040)56%
(226/403)src.search100%