D28745: Skip caching thumbnails on encrypted filesystems

[Thiago Macieira]

thiago added a comment.


  BTW, have you checked if the thumbnails are still generated for non-removable 
but encrypted filesystems? My whole system is encrypted (except for /boot), so 
it would be a performance loss if no thumbnails were ever cached.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

D28745: Skip caching thumbnails on encrypted filesystems

[Stefan Brüns]

bruns added a comment.


  In D28745#676320 , @marcingu wrote:
  
  > In D28745#676317 , @bruns wrote:
  >
  > > In D28745#676313 , @marcingu 
wrote:
  > >
  > > > Ping!
  > > >  I'm remanding about question early, because I could do much more work 
if I get to do it on weekend.
  > > >
  > > > Question:
  > > >  This code won't save thumbnail for file on any device that isn't 
`StorageVolume` or is `StorageVolume` with `usage` `UsageType::Encrypded`.
  > >
  > >
  > > The whole block can never return true, so it should just be removed, 
along with all its dependencies.
  >
  >
  > I tested it once more and it returns true when it should, as expected. What 
makes you think it doesn't?
  
  
  Even worse, its almost random:
  
udi = '/org/kde/fstab///pebbles/foo:/mnt'
  parent = '/org/kde/fstab'  (string)
  vendor = 'pebbles'  (string)
  product = 'foo:/mnt'  (string)
  description = 'foo:/mnt on pebbles'  (string)
  icon = 'network-server'  (string)
  StorageAccess.accessible = false  (bool)
  StorageAccess.filePath = '/mnt'  (string)
  StorageAccess.ignored = false  (bool)
  NetworkShare.type = 'Cifs'  (0x2)  (enum)
  NetworkShare.url = 'smb://pebbles/foo:/mnt'  (string)
  
  `if (device.is())` -> false, though it should be cached
  
udi = '/org/freedesktop/UDisks2/block_devices/dm_2d2'
  parent = '/'  (string)
  vendor = ''  (string)
  product = ''  (string)
  description = '100,0 GiB Hard Drive'  (string)
  icon = 'drive-harddisk-root'  (string)
  Block.major = 254  (0xfe)  (int)
  Block.minor = 2  (0x2)  (int)
  Block.device = '/dev/dm-2'  (string)
  StorageAccess.accessible = true  (bool)
  StorageAccess.filePath = '/'  (string)
  StorageAccess.ignored = true  (bool)
  StorageVolume.ignored = false  (bool)
  StorageVolume.usage = 'FileSystem'  (0x2)  (enum)
  StorageVolume.fsType = 'btrfs'  (string)
  StorageVolume.label = ''  (string)
  StorageVolume.uuid = '5832ebfa-bf02-40d2-bdc7-90403b207b62'  (string)
  StorageVolume.size = 107374182400  (0x19)  (qulonglong)
  
  This is an LUKS encrypted volume so should be cached ...

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

D28745: Skip caching thumbnails on encrypted filesystems

[Marcin Gurtowski]

marcingu added a comment.


  In D28745#676317 , @bruns wrote:
  
  > In D28745#676313 , @marcingu 
wrote:
  >
  > > Ping!
  > >  I'm remanding about question early, because I could do much more work if 
I get to do it on weekend.
  > >
  > > Question:
  > >  This code won't save thumbnail for file on any device that isn't 
`StorageVolume` or is `StorageVolume` with `usage` `UsageType::Encrypded`.
  >
  >
  > The whole block can never return true, so it should just be removed, along 
with all its dependencies.
  
  
  I tested it once more and it returns true when it should, as expected. What 
makes you think it doesn't?
  
  >> Is this fine?
  >>  Should we take something else into consideration?
  >>  Do we want that feature tested to avoid regression in the future?
  > 
  > This code duplicates functionality already present in the thumbnailer code 
in KIO core. It can be replaced by a trivial "CacheThumbnail" flag provided by 
the caller.
  
  I wasn't able to prevent catching of directory thumbnails from KIO. The fact 
that files used for making a preview can be on different storage, makes it 
extra tricky.
  But I'm new the project, so if you do know how to make it simpler I'm all 
ears.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 838 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/838/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 04 Sep 2020 20:21:20 +
 Build duration:
5 min 21 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.74.0.xmllogs/KF5KIO/5.74.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 58 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report68%
(25/37)67%
(292/437)67%
(292/437)57%
(36829/64351)41%
(18707/45655)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(10588/11068)46%
(5024/10936)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core87%
(103/118)87%
(103/118)60%
(8753/14499)52%
(4572/8742)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(32/43)74%
(32/43)58%
(4942/8483)45%
(2180/4868)src.gui100%
(8/8)100%
(8/8)80%
(728/914)59%
(376/636)src.gui.systemd50%
(2/4)50%
(2/4)4%
(7/183)1%
(1/116)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(720/1302)41%
(433/1056)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1376)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1802/4306)36%
(1309/3640)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(630/1328)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 837 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/837/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 04 Sep 2020 20:03:45 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.74.0.xmllogs/KF5KIO/5.74.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: projectroot.autotests.kiofilewidgets_kurlrequestertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report68%
(25/37)67%
(291/437)67%
(291/437)57%
(36658/64343)41%
(18584/45655)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)95%
(10494/11066)45%
(4973/10936)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core87%
(103/118)87%
(103/118)61%
(8776/14501)52%
(4575/8742)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(32/43)74%
(32/43)58%
(4937/8483)45%
(2177/4868)src.gui100%
(8/8)100%
(8/8)80%
(728/914)59%
(376/636)src.gui.systemd50%
(2/4)50%
(2/4)4%
(7/183)1%
(1/116)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(720/1302)41%
(433/1056)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1376)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1802/4306)36%
(1309/3640)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(630/1328)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
   

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.15 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.15/27/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Fri, 04 Sep 2020 16:17:34 +
 Build duration:
54 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.15 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.15/26/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Fri, 04 Sep 2020 15:38:01 +
 Build duration:
51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.15 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.15/25/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Fri, 04 Sep 2020 15:37:04 +
 Build duration:
53 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D28745: Skip caching thumbnails on encrypted filesystems

[Stefan Brüns]

bruns added a comment.


  In D28745#676313 , @marcingu wrote:
  
  > Ping!
  >  I'm remanding about question early, because I could do much more work if I 
get to do it on weekend.
  >
  > Question:
  >  This code won't save thumbnail for file on any device that isn't 
`StorageVolume` or is `StorageVolume` with `usage` `UsageType::Encrypded`.
  
  
  The whole block can never return true, so it should just be removed, along 
with all its dependencies.
  
  > Is this fine?
  >  Should we take something else into consideration?
  >  Do we want that feature tested to avoid regression in the future?
  
  This code duplicates functionality already present in the thumbnailer code in 
KIO core. It can be replaced by a trivial "CacheThumbnail" flag provided by the 
caller.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

D28745: Skip caching thumbnails on encrypted filesystems

[Marcin Gurtowski]

marcingu added a comment.


  Ping!
  I'm remanding about question early, because I could do much more work if I 
get to do it on weekend.
  
  Question:
  This code won't save thumbnail for file on any device that isn't 
`StorageVolume` or is `StorageVolume` with `usage` `UsageType::Encrypded`.
  Is this fine?
  Should we take something else into consideration?
  Do we want that feature tested to avoid regression in the future?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov