KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.14 - Build # 177 - Fixed!

2020-09-08 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.14/177/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 08 Sep 2020 19:56:56 +
 Build duration:
2 min 20 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.14 - Build # 176 - Failure!

2020-09-08 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.14/176/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 08 Sep 2020 19:42:16 +
 Build duration:
4.6 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeRunning on Windows Builder Theta in C:\CI\workspace\Frameworks\knewstuff\kf5-qt5 WindowsMSVCQt5.14[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] ws[2020-09-08T19:42:18.672Z] Running in C:/CI/Job Build[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] }[Pipeline] // stage[Pipeline] }[2020-09-08T19:42:20.645Z] Also:   	Also:   java.nio.file.FileSystemException: C:\CI\Job Build\build: The process cannot access the file because it is being used by another process.[2020-09-08T19:42:20.646Z] [2020-09-08T19:42:20.646Z] 			at sun.nio.fs.WindowsException.translateToIOException(Unknown Source)[2020-09-08T19:42:20.646Z] 			at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)[2020-09-08T19:42:20.646Z] 			at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)[2020-09-08T19:42:20.646Z] 			at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source)[2020-09-08T19:42:20.646Z] 			at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(Unknown Source)[2020-09-08T19:42:20.646Z] 			at java.nio.file.Files.deleteIfExists(Unknown Source)[2020-09-08T19:42:20.646Z] 			at jenkins.util.io.PathRemover.removeOrMakeRemovableThenRemove(PathRemover.java:237)[2020-09-08T19:42:20.646Z] 	Also:   java.nio.file.FileSystemException: C:\CI\Job Build\build: The process cannot access the file because it is being used by another process.[2020-09-08T19:42:20.646Z] [2020-09-08T19:42:20.646Z] 			at sun.nio.fs.WindowsException.translateToIOException(Unknown Source)[2020-09-08T19:42:20.646Z] 			at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)[2020-09-08T19:42:20.646Z] 			at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)[2020-09-08T19:42:20.646Z] 			at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source)[2020-09-08T19:42:20.646Z] 			at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(Unknown Source)[2020-09-08T19:42:20.646Z] 			at java.nio.file.Files.deleteIfExists(Unknown Source)[2020-09-08T19:42:20.646Z] 			at jenkins.util.io.PathRemover.removeOrMakeRemovableThenRemove(PathRemover.java:241)[2020-09-08T19:42:20.646Z] jenkins.util.io.CompositeIOException: Unable to remove directory C:\CI\Job Build\build with directory contents: [][2020-09-08T19:42:20.646Z] 		at jenkins.util.io.PathRemover.removeOrMakeRemovableThenRemove(PathRemover.java:250)[2020-09-08T19:42:20.646Z] 		at jenkins.util.io.PathRemover.tryRemoveFile(PathRemover.java:205)[2020-09-08T19:42:20.646Z] 		at jenkins.util.io.PathRemover.tryRemoveRecursive(PathRemover.java:216)[2020-09-08T19:42:20.646Z] 		at jenkins.util.io.PathRemover.tryRemoveDirectoryContents(PathRemover.java:226)[2020-09-08T19:42:20.646Z] 		at jenkins.util.io.PathRemover.tryRemoveRecursive(PathRemover.java:215)[2020-09-08T19:42:20.646Z] 		at jenkins.util.io.PathRemover.forceRemoveRecursive(PathRemover.java:96)[2020-09-08T19:42:20.646Z] Also:   	Also:   java.nio.file.DirectoryNotEmptyException: C:\CI\Job Build[2020-09-08T19:42:20.646Z] 			at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source)[2020-09-08T19:42:20.646Z] 			at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(Unknown Source)[2020-09-08T19:42:20.646Z] 			at java.nio.file.Files.deleteIfExists(Unknown Source)[2020-09-08T19:42:20.646Z] 			at jenkins.util.io.PathRemover.removeOrMakeRemovableThenRemove(PathRemover.java:237)[2020-09-08T19:42:20.646Z] 	Also:   java.nio.file.DirectoryNotEmptyException: C:\CI\Job Build[2020-09-08T19:42:20.646Z] 			at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source)[2020-09-08T19:42:20.646Z] 			at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(Unknown Source)[2020-09-08T19:42:20.646Z] 			at java.nio.file.Files.deleteIfExists(Unknown Source)[2020-09-08T19:42:20.646Z] 			at jenkins.util.io.PathRemover.removeOrMakeRemovableThenRemove(PathRemover.java:241)[2020-09-08T19:42:20.646Z] jenkins.util.io.CompositeIOException: Unable to remove directory C:\CI\Job Build with directory contents: [C:\CI\Job Build\build][2020-09-08T19:42:20.646Z] 		at jenkins.util.io.PathRemover.removeOrMakeRemovableThenRemove(PathRemover.java:250)[2020-09-08T19:42:20.646Z] 		at jenkins.util.io.PathRemover.tryRemoveFile(PathRemover.java:205)[2020-09-08T19:42:20.646Z] 		at jenkins.util.io.PathRemover.tryRemoveRecursive(PathRemover.java:216)[2020-09-08T19:42:20.646Z] 		at jenkins.util.io.PathRemover.forceRemoveRecursive(PathRemover.java:96)[2020-09-08T19:42:20.646Z] Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from ange.kde.org/144

D17816: Support for xattrs on kio copy/move

2020-09-08 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> jobtest.cpp:467
> +path.removeLast();
> +QString writeTest = path.join("/") + "/fsXattrTestFile";
> +createTestFile(writeTest);

const QString

And if you just call this with the target directory (e.g. ` homeTmpDir()`), you 
can skip the split/join dance.

> jobtest.cpp:780
> +checkXattrFsSupport(filePath);
> +checkXattrFsSupport(dest);
> +if (!m_SkipXattr) {

This will set `m_SkipXattr` unconditionally even if the source FS does not 
support Xattrs.

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.15 - Build # 104 - Fixed!

2020-09-08 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.15/104/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Tue, 08 Sep 2020 15:09:23 +
 Build duration:
50 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515 Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)

D29526: Thumbnails: make thumbnail generation dpr-aware

2020-09-08 Thread Stefan Brüns 
bruns added a comment.


  In D29526#676402 , @meven wrote:
  
  > In D29526#676386 , @bruns wrote:
  >
  > > For all but text the DPR is completely irrelevant, large@1 is identical 
to normal@2.
  >
  >
  > Yes and that's up to thumbnail creators to decide. To take advantage of 
this, we would need to introduce some ThumbnailCreator type that would say 
whether or not generated thumbnail might be influenced by DPR (i.e) text. That 
would necessitate change the ThumbnailCreator API.
  
  
  No, just add a "DisplayPixelRatioDependent=true"  key to the service data of 
the thumbnailer.
  
  > But the implementation will stay a lot simpler if we don't this level of 
complexity and adding will have a limited interest. Storing twice large@1 would 
happen only when a user would change DPR, thumbnails cache size limit will stay 
enforced.
  
  You are changing every single thumbnailer implementation, although the 
results are binary identical for normal@2 and large@1. And that are only the 
thumbnailers in kio-extra.
  
  And on top of all this, the only thumbnailer which is DPR dependent (text) 
does not even cache the data on disk.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29526

To: meven, #frameworks, dfaure, broulik, sitter, ngraham, bruns
Cc: bruns, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, emmanuelp, rdieter, mikesomov

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.15 - Build # 103 - Unstable!

2020-09-08 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.15/103/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Tue, 08 Sep 2020 12:53:28 +
 Build duration:
1 min 33 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515 Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_keynavigation.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_listskeynavigation.qml

D29526: Thumbnails: make thumbnail generation dpr-aware

2020-09-08 Thread Méven Car 
meven added a comment.


  In D29526#676386 , @bruns wrote:
  
  > For all but text the DPR is completely irrelevant, large@1 is identical to 
normal@2.
  
  
  Yes and that's up to thumbnail creators to decide. To take advantage of this, 
we would need to introduce some ThumbnailCreator type that would say whether or 
not generated thumbnail might be influenced by DPR (i.e) text. That would 
necessitate change the ThumbnailCreator API.
  
  But the implementation will stay a lot simpler if we don't this level of 
complexity and adding will have a limited interest. Storing twice large@1 would 
happen only when a user would change DPR, thumbnails cache size limit will stay 
enforced.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29526

To: meven, #frameworks, dfaure, broulik, sitter, ngraham, bruns
Cc: bruns, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, emmanuelp, rdieter, mikesomov

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.15 - Build # 29 - Fixed!

2020-09-08 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.15/29/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Tue, 08 Sep 2020 10:12:47 +
 Build duration:
1 min 3 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 611 - Fixed!

2020-09-08 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/611/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 08 Sep 2020 09:51:07 +
 Build duration:
3 min 3 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.74.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.74.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)58%
(25/43)58%
(25/43)42%
(2073/4898)28%
(882/3101)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src70%
(19/27)70%
(19/27)40%
(1564/3871)27%
(654/2386)src.libkirigami67%
(4/6)67%
(4/6)70%
(480/685)39%
(221/571)src.scenegraph13%
(1/8)13%
(1/8)8%
(28/333)5%
(7/144)

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-09-08 Thread Méven Car 
meven added a comment.


  FYI on this patch serie, I am currently focusing on the specification work : 
https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/35
  Then I am thinking about moving my patch serie to gitlab reflecting on the 
last feedback of course.
  Those patchs are getting old and are going to need some degree of rebasing.

INLINE COMMENTS

> meven wrote in previewjob.cpp:754
> Maybe add it optionally, when different from 1

Not needed.

> bruns wrote in previewjob.cpp:699
> mixing floating point and integers for a memory-allocation like function is a 
> real bad idea.

I am thinking about making devicePixelRatio an int.

> previewjob.h:196
> + *
> + * @since 5.71
> + */

update

> dfaure wrote in thumbcreator.h:191
> 5.70 is tagged already

update

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: bruns, elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, 
LeGast00n, cblack, michaelh, ngraham