KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.15 - Build # 232 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.15/232/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Tue, 24 Nov 2020 15:12:58 +
 Build duration:
51 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515 Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_keynavigation.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_listskeynavigation.qml

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Hannah von Reth]

vonreth added a comment.


  In D25119#676781 , @cullmann wrote:
  
  > Hmm, I don't think you need a theme chooser, we just need to watch for the 
palette change signal and then trigger again the theme name setting based on 
the background palette.
  >  That would be enough to detect bright/dark mode.
  
  
  But with a theme chooser and a plugin approach we can handle multiple 
different themes which can easily be added.
  At the moment we would need to link too breeze, to add support for oxygen we 
would need to link to oxygen 😅

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: brute4s99, nicolasfella, aboyer, sars, wrobelda, davidedmundson, broulik, 
rempt, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Christoph Cullmann]

cullmann added a comment.


  Hmm, I don't think you need a theme chooser, we just need to watch for the 
palette change signal and then trigger again the theme name setting based on 
the background palette.
  That would be enough to detect bright/dark mode.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: brute4s99, nicolasfella, aboyer, sars, wrobelda, davidedmundson, broulik, 
rempt, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Piyush Aggarwal]

brute4s99 added subscribers: nicolasfella, brute4s99.
brute4s99 added a comment.


  +1 to adding the breeze icons support for other OSes. (Thanks @nicolasfella 
for linking me to this diff).
  
  I have hit the same problem with the KDE Connect Windows port. Thank you for 
working on it!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: brute4s99, nicolasfella, aboyer, sars, wrobelda, davidedmundson, broulik, 
rempt, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Hannah von Reth]

vonreth added a comment.


  And change those during runtime

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: aboyer, sars, wrobelda, davidedmundson, broulik, rempt, 
kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Hannah von Reth]

vonreth added a comment.


  Yea my idea didn't make much sense.
  Reading your comment I realized that we should probably implement a theme 
chooser in a kf5 and provide the themes as plugins, that way we could also 
provide other themes, not just breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: aboyer, sars, wrobelda, davidedmundson, broulik, rempt, 
kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns