Thoughts on Knotification and Signaling
Hey y'all, So I notice that `KNotification` has this concept of actions and it's a hard- coded numeric approach (at least when emitted from the signal). Is there reasoning around that and not having a single signal emitted with a variable signifying what action was invoked? I ask because I can see that being expanded for more actions and even open the door for more dynamic actions (like changing it to be not active if it's irrelevant). signature.asc Description: This is a digitally signed message part.
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 354 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/354/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Sun, 29 Nov 2020 19:50:41 + Build duration: 3 min 56 sec and counting JUnit Tests Name: projectroot Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 353 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/353/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Sun, 29 Nov 2020 19:46:09 + Build duration: 4 min 29 sec and counting JUnit Tests Name: projectroot Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
Re: KCGroups in KDEreview
Hello, On Friday, 20 November 2020 14:55:16 CET Henri Chain wrote: > KCgroups has been moved to KDEReview ! > What is that, you ask ? It's a library that wraps the systemd dbus API to > expose a higher-level concept of desktop application and allow control of > its system resource usage (CPU, RAM, IO, etc). > > It relies on the recent ability of plasma to launch applications in their > own systemd scopes, with correspond to cgroups and provides a more robust > definition for an application (more details at > https://lwn.net/Articles/834329/ ) . > > The main use of the library is to expose related resource control settings > for those applications, at a user space level that other KDE applications > and frameworks can use, including consumption straight from QML as > demonstrated in the test application. > > KCgroups is intended to become a (Tier 1) framework. A first user of this > library might be the foreground window CPU booster daemon that is available > here: > https://invent.kde.org/libraries/kcgroups/-/tree/work/foreground-booster > > Packages are already available for both Neon and Arch Linux. > > Looking forward to your feedback and ideas for using this, Glad to see this come to fruition. One concern regarding use with other libraries: * the OPTIONAL_GADGET use introduce names that I could see potentially clashing with application code or code in third party libraries, I wonder if they should be moved in a namespace as well (as in "like optional") or have a K name at least; Minor things I found: * tests/main.cpp needs to have some of its includes cleaned up (at a glance QDebug and QTimer aren't needed there); * tests/main.qml should have better ids for its elements IMHO, often those manual tests end up used as examples by people and having better readability helps (also avoids having people copying and pasting shameful things). ;-) That's not much but I'm obviously biased by the fact that we discussed this API together already. :-) Regards. -- Kevin Ottens, http://ervin.ipsquad.net signature.asc Description: This is a digitally signed message part.
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 352 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/352/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Sun, 29 Nov 2020 16:46:56 + Build duration: 3 min 53 sec and counting JUnit Tests Name: projectroot Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 351 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/351/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Sun, 29 Nov 2020 16:31:39 + Build duration: 15 min and counting JUnit Tests Name: projectroot Failed: 3 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: projectroot.autotests.applicationlauncherjob_forkingtestFailed: projectroot.autotests.applicationlauncherjob_servicetestFailed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.14 - Build # 2 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.14/2/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 29 Nov 2020 14:12:22 + Build duration: 15 min and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5Purpose-5.77.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.77.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report23% (5/22)31% (15/48)31% (15/48)23% (488/2089)19% (179/953)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (2/2)100% (2/2)98% (143/146)59% (54/92)src100% (9/9)100% (9/9)68% (261/384)49% (96/197)src.externalprocess0% (0/2)0% (0/2)0% (0/136)0% (0/98)src.fileitemactionplugin0% (0/1)0% (0/1)0% (0/24)0% (0/18)src.plugins.bluetooth0% (0/1)0% (0/1)0% (0/32)0% (0/8)src.plugins.email0% (0/1)0% (0/1)0% (0/65)0% (0/24)src.plugins.imgur0% (0/2)0% (0/2)0% (0/184)0% (0/63)src.plugins.kdeconnect0% (0/1)0% (0/1)0% (0/31)0% (0/6)src.plugins.kdeconnect_sms0% (0/1)0% (0/1)0% (0/16)0% (0/2)src.plugins.ktp-sendfile0% (0/1)0% (0/1)0% (0/28)0% (0/6)src.plugins.pastebin0% (0/1)0% (0/1)0% (0/54)0% (0/23)src.plugins.phabricator0% (0/3)0% (0/3)0% (0/219)0% (0/74)src.plugins.phabricator.quick0% (0/5)0% (0/5)0% (0/93)0% (0/48)src.plugins.phabricator.tests0% (0/1)0% (0/1)0% (0/60)0% (0/22)src.plugins.reviewboard0% (0/3)0% (0/3)0% (0/229)0% (0/70)src.plugins.reviewboard.quick0% (0/7)0% (0/7)0% (0/154)0% (0/80)src.plugins.saveas100% (1/1)100% (1/1)57% (29/51)61%
KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.15 - Build # 44 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.15/44/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Sun, 29 Nov 2020 14:12:22 + Build duration: 14 min and counting JUnit Tests Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.15 - Build # 48 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.15/48/ Project: kf5-qt5 SUSEQt5.15 Date of build: Sun, 29 Nov 2020 14:12:22 + Build duration: 12 min and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5Purpose-5.77.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.77.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report23% (5/22)31% (15/48)31% (15/48)23% (488/2089)19% (179/953)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (2/2)100% (2/2)98% (143/146)59% (54/92)src100% (9/9)100% (9/9)68% (261/384)49% (96/197)src.externalprocess0% (0/2)0% (0/2)0% (0/136)0% (0/98)src.fileitemactionplugin0% (0/1)0% (0/1)0% (0/24)0% (0/18)src.plugins.bluetooth0% (0/1)0% (0/1)0% (0/32)0% (0/8)src.plugins.email0% (0/1)0% (0/1)0% (0/65)0% (0/24)src.plugins.imgur0% (0/2)0% (0/2)0% (0/184)0% (0/63)src.plugins.kdeconnect0% (0/1)0% (0/1)0% (0/31)0% (0/6)src.plugins.kdeconnect_sms0% (0/1)0% (0/1)0% (0/16)0% (0/2)src.plugins.ktp-sendfile0% (0/1)0% (0/1)0% (0/28)0% (0/6)src.plugins.pastebin0% (0/1)0% (0/1)0% (0/54)0% (0/23)src.plugins.phabricator0% (0/3)0% (0/3)0% (0/219)0% (0/74)src.plugins.phabricator.quick0% (0/5)0% (0/5)0% (0/93)0% (0/48)src.plugins.phabricator.tests0% (0/1)0% (0/1)0% (0/60)0% (0/22)src.plugins.reviewboard0% (0/3)0% (0/3)0% (0/229)0% (0/70)src.plugins.reviewboard.quick0% (0/7)0% (0/7)0% (0/154)0% (0/80)src.plugins.saveas100% (1/1)100% (1/1)57% (29/51)61%
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 350 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/350/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Sun, 29 Nov 2020 10:08:49 + Build duration: 27 min and counting JUnit Tests Name: projectroot Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
