[Differential] [Updated, 79 lines] D3826: Detect inotify.

adridg updated this revision to Diff 10439. adridg added a comment. Restricted Application added projects: Frameworks, Buildsystem. - Follow up on review REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3826?vs=9401=10439 BRANCH inotify

[Differential] [Commented On] D4248: Add Boost_INCLUDE_DIR to kactivities-stats autotests.

adridg added a comment. Also, kactivities-stats could use an .arcconfig REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D4248 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: adridg, #frameworks, ivan, #kactivities

[Differential] [Updated] D4248: Add Boost_INCLUDE_DIR to kactivities-stats autotests.

adridg added reviewers: Frameworks, ivan, KActivities. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D4248 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: adridg, #frameworks, ivan, #kactivities Cc: #frameworks

[Differential] [Updated] D3826: Detect inotify.

adridg marked 5 inline comments as done. adridg added inline comments. INLINE COMMENTS > kfunk wrote in FindInotify.cmake:51 > Style: Indent off Assuming that means "comments indent 0" and not "comments indentation should match surrounding indent, which is 4". It's a bit ambiguous. > kfunk

[Differential] [Request, 1 line] D4248: Add Boost_INCLUDE_DIR to kactivities-stats autotests.

adridg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The autotests/CMakeLists.txt doesn't add Boost_INCLUDE_DIR to the include search path (src/CMakeLists.txt does) so the autotests fail to

[Differential] [Closed] D3826: Detect inotify.

This revision was automatically updated to reflect the committed changes. adridg marked 2 inline comments as done. Closed by commit R240:a02c4d0152a7: Detect inotify. (authored by adridg). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4248: Add Boost_INCLUDE_DIR to kactivities-stats autotests.

This revision was automatically updated to reflect the committed changes. Closed by commit R159:d2cbef5d94f3: Add Boost_INCLUDE_DIR to kactivities-stats autotests. (authored by adridg). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4248: Add Boost_INCLUDE_DIR to kactivities-stats autotests.

adridg added a comment. I'm going to claim feedback timeout, plus all it does is add some -I flags when compiling the tests. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D4248 EMAIL PREFERENCES

[Differential] [Updated] D3826: Detect inotify.

adridg added a reviewer: ervin. adridg added a comment. Adding Kevin as reviewer -- I feel uncomfortable having so little feedback and I'm not sure who should be added if https://phabricator.kde.org/tag/buildsystem/ and https://phabricator.kde.org/tag/frameworks/ don't ACK. REPOSITORY

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

uot;login"; const char logout_cmd[] = "logout"; #endif then in the actual code you only have one path, and use `QStringList() << QStringLiteral(appropriate_cmd)` as needed. - Adriaan de Groot On

[Differential] [Closed] D3952: Fix message when searching for libclang.

This revision was automatically updated to reflect the committed changes. Closed by commit R240:738972a9a29a: Fix message when searching for libclang. (authored by adridg). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3952?vs=9694=9705 REVISION

[Differential] [Commented On] D3830: Add a new FindGperf module

adridg added a comment. gperf is also available in the base system for FreeBSD, so this doesn't have any effects on the build there, either. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

adridg added a comment. Might want to add a comment about "this is the actual inode creation time; support depends on the underlying filesystem (e.g. UFS and ZFS have this information, NFS doesn't)", and change the comment about buff.st_ctime and KDE 2.0. In addition, please insert the

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

adridg added a comment. Further to the Linux bits: while ext4 and btrfs have the necessary fields, stat(2) doesn't expose them, xstat(2) doesn't exist yet (see LWN from a few years back), and extracting the info using other tools depends on fun stuff like knowing what kind of filesystem the

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

adridg accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

adridg updated this revision to Diff 13529. adridg added a comment. - Brain-o on the OpenBSD code - Reduce whitespace changes - Update comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=13528=13529 BRANCH arcpatch-D5138 REVISION DETAIL

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

adridg commandeered this revision. adridg edited reviewers, added: tcberner; removed: adridg. REPOSITORY R241 KIO BRANCH arcpatch-D5138 REVISION DETAIL https://phabricator.kde.org/D5138 To: adridg, rakuco, dfaure, arrowdodger, tcberner Cc: aacid, kfunk, emmanuelp, #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

adridg updated this revision to Diff 13528. adridg added a comment. Take over the review so as to land it, based on tcberner's comments from april 6th, and Albert's reminder. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=12745=13528 BRANCH

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit R241:16f69a5d0d55: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD (authored by adridg). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=13529=13530

D3830: Add a new FindGperf module

adridg accepted this revision. adridg added a comment. I just happened to need a FindGperf in another project today, so I've tested this in non-ECM settings (adding this plus ECMFindModuleHelpers to that project's own cmake/) and it works fine on FreeBSD. The docs in the header are good,

D6265: Use FindInotify.cmake to decide wheter inotify is available.

This revision was automatically updated to reflect the committed changes. Closed by commit R293:401b38989f0d: Use FindInotify.cmake to decide wheter inotify is available. (authored by adridg). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6265?vs=15563=15583

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

This revision was automatically updated to reflect the committed changes. Closed by commit R266:c6a290a2e154: Do not depend on bash uncessarily, and do not validate icons by default. (authored by tcberner, committed by adridg). CHANGED PRIOR TO COMMIT

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

adridg commandeered this revision. adridg added a reviewer: tcberner. adridg added a comment. Taking over to follow up Albert's suggestion -- this could be two patches, one to de-bash it, one to make validation optional. REPOSITORY R266 Breeze Icons REVISION DETAIL

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

adridg updated this revision to Diff 15820. adridg added a comment. Make the diff smaller: only de-bash it, and save make-validation-optional for a later patch. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6076?vs=15116=15820 BRANCH

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

adridg added reviewers: kfunk, poboiko. adridg added a comment. Add reviewers who have commented, or who have committed to baloo recently. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, kfunk, poboiko Cc: adridg, kfunk, #frameworks

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

adridg added a comment. So this patch looks ready to land to me: it simplifies the code, defers fstype-detection to QStorageInfo (for FreeBSD, we should fix the original issue there), and is otherwise non-intrusive. REPOSITORY R293 Baloo REVISION DETAIL

D6049: Extend unittests to test stable sort.

adridg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - Helper function constructs a permutation of the list of menu-items that need to be sorted, then sorts and tests. - Test ten permutations

D6049: Extend unittests to test stable sort.

adridg added reviewers: whiting, Frameworks. adridg added a comment. (also, this repo has a .reviewboardrc but no .arcconfig) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6049 To: adridg, whiting, #frameworks Cc: #frameworks

D6049: Extend unittests to test stable sort.

This revision was automatically updated to reflect the committed changes. Closed by commit R304:28833ae05d00: Extend unittests to test stable sort. (authored by adridg). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6049?vs=15016=15530 REVISION DETAIL

D5715: Fix tier-indicator.

adridg abandoned this revision. adridg added a comment. https://phabricator.kde.org/R159:b5e20a709fbef7015874e9536cc06e5aa22aa5c0 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D5715 To: adridg, ivan Cc: apol, #frameworks

D6265: Use FindInotify.cmake to decide wheter inotify is available.

adridg added reviewers: vhanda, tcberner. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D6265 To: adridg, dfaure, vhanda, tcberner Cc: #frameworks

D6265: Use FindInotify.cmake to decide wheter inotify is available.

adridg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY FreeBSD also has sys/inotify.h available, but it is a library. We added FindInotify.cmake to ecm a while a go for this, but never got

D5713: Fix quoting of preprocessor-definition.

adridg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY If the LIBEXECDIR contains spaces (as it does specifically on the CI systems) then this needs one extra layer of quoting to protect it from

D5716: Fix build on CI.

adridg created this revision. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: Documentation, Frameworks. REVISION SUMMARY In the presence of spaces in directory names, things end up double-escaped by using TO_NATIVE_PATH and then the

D5717: Fix autotests on the FreeBSD CI.

adridg added a reviewer: graesslin. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5717 To: adridg, bcooksley, graesslin Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas

D5715: Fix tier-indicator.

adridg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Since activities-stats depends on kactivities, which is tier-3 itself, -stats must be tier-3 as well. REPOSITORY R159 KActivities

D5716: Fix build on CI.

adridg added reviewers: winterz, bcooksley, vonreth. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D5716 To: adridg, winterz, bcooksley, vonreth Cc: #frameworks, #documentation, skadinna

D5717: Fix autotests on the FreeBSD CI.

adridg created this revision. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY Include explicitly, for EPROTO. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL

D4906: Fix kactivities-stats into tier3

adridg added a comment. The default configuration of kactivities has option KACTIVITIES_LIBRARY_ONLY set to OFF, which means src/imports is added as subdirectory, and it uses KIO and other tier-3 libraries. So the default build of kactivities is still tier-3. And as long as kactivities is

D5717: Fix autotests on the FreeBSD CI.

This revision was automatically updated to reflect the committed changes. Closed by commit R127:a5d279198fee: Fix autotests on the FreeBSD CI. (authored by adridg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5717?vs=14155=14160 REVISION DETAIL

D5713: Fix quoting of preprocessor-definition.

This revision was automatically updated to reflect the committed changes. Closed by commit R241:def270105286: Fix quoting of preprocessor-definition. (authored by adridg). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5713?vs=14149=14159 REVISION DETAIL

D5716: Fix build on CI.

This revision was automatically updated to reflect the committed changes. Closed by commit R264:2e7cd3bc4704: Fix build on CI. (authored by adridg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5716?vs=14152=18817#toc REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE

D5716: Fix build on CI.

adridg abandoned this revision. adridg added a comment. Closed by 2e7cd3bc4704408358f11ad4d92af17a1b8ce2b5 REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D5716 To: adridg, winterz, bcooksley, vonreth Cc: #frameworks, #documentation, skadinna

D9076: Have an application that can cross-check if the promised platforms are correct

adridg added a comment. To understand the expected output better: suppose something says "platforms: All", like kcontacts. If there's no actual build configured in CI for that something, for FreeBSD, it will say "FreeBS is a disabled platform". The message can probably be improved, then.

D11235: [DrKonqi] Request change of ptrace scope from KCrash

adridg added a comment. Comments directed at licensing and non-Linux cases. INLINE COMMENTS > queryptrace.cpp:1 > +#include > + Missing file header / license bits > queryptrace.cpp:49 > + > +#endif For non-Linuxen, include a null implementation here. > queryptrace.h:1 > +#ifndef

D13328: A backend is required for kdnssd

adridg added inline comments. INLINE COMMENTS > cgiboudeaux wrote in CMakeLists.txt:65-66 > wrong place Hi. If you're posting a review, please provide constructive input. If there are policies or guidelines about places, please link to them. If there aren't, but you would prefer a change,

D13328: A backend is required for kdnssd

adridg updated this revision to Diff 35524. adridg added a comment. Use the right place (sorry Christophe, to use a Dutch phrase: I must have been looking with my nose). REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13328?vs=35514=35524 BRANCH

D13327: Fix conversion error when compiled against MDNSRESPONDER option

adridg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. adridg requested review of this revision. REVISION SUMMARY If QT_NO_CAST_FROM_BYTEARRAY is set, along with using MDNSRESPONDER, then the implicit

D13328: A backend is required for kdnssd

adridg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. adridg requested review of this revision. REVISION SUMMARY Refuse to build if there are no backends for DNSSD at all. The messages for the OPTIONAL

D13328: A backend is required for kdnssd

adridg added a comment. Something to consider, though, is that it might perhaps be useful to have kdnssd build -- without a backend -- for environments where there is no real dnssd and any service discovery returns "not found". Requiring a backend makes that impossible. (So something

D13328: A backend is required for kdnssd

adridg edited the test plan for this revision. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D13328 To: adridg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13752: Kill solidautoeject

adridg added a comment. Since the ticket is rather unclear on what functionality is being tested, or how: - Put a CD with an ISO9660 filesystem in the drive (I used one with Debian from 1995 on it) - When device notifier pops up, pick "open with filemanager" (`*`) - Ensure the

D13752: Kill solidautoeject

adridg added a comment. It's not clear to me what this revision is trying to change (in terms of user-visible behavior) or how to test the change; what I've written above is current behavior on FreeBSD 11 with Plasma 5.12.5; HAL is running. REPOSITORY R120 Plasma Workspace REVISION

D13752: Kill solidautoeject

adridg added a comment. - Start systemsettings; under *workspace*, *startup and shutdown*, find *background services*. - Untick the box for *Drive Ejector*; also check status is *not running*, click *stop* button if it is still running. - Insert CD, pick *open in file manager* from the

D10450: Generate a custom target in kcoreaddons_desktop_to_json

adridg added a comment. Associated bug https://bugs.kde.org/show_bug.cgi?id=389982 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10450 To: tcberner, #freebsd, mpyne, bshah, dfaure Cc: adridg, kossebau, #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

adridg added a comment. In D10450#204623 , @kossebau wrote: > "This (hopefully) fixes the build failure noticed in the FreeBSD (and some linuxes)" - leaves the question: why should it exactly fix it? :) From reading the CMake

D10662: indexerconfig: Describe some functions

adridg added inline comments. INLINE COMMENTS > indexerconfig.h:45 > + * match any of the exclude filters. Only the name of the > + * dir itself it checked. > + * This makes it unclear if the entire path is used, (e.g. `\p path`) or whether some special part of the path (the dir)

D10661: indexerconfig: Expose canBeSearched function

adridg added inline comments. INLINE COMMENTS > indexerconfig.h:42 > + * Check if \p folder can be searched taking only > + * the includeFolders() into account. > + * This description says only `includeFolders()` is taken into account. The next paragraph says "should be indexed",

D10823: idutils: Fix typo

adridg accepted this revision. adridg added a comment. I'm so happy :) This is partly to help @michaelh get into the swing of things, with writing a patch, pushing it to review, getting it okayed .. a bit of "this is the process". Of course later there's no need for typo-fix reviews

Re: ktextwidgets on FreeBSD

On Saturday, 4 August 2018 13:06:42 CEST David Faure wrote: > Anyone running FreeBSD, who could to try and debug this hanging unittest > from the ktextwidgets framework? > > https://build.kde.org/view/Frameworks/job/Frameworks%20ktextwidgets%20kf5-qt >

D14927: KConfig: handle directory symlinks correctly.

adridg added a comment. This shows up in the unit tests. Whether it has any effect in real life is unknown. FreeBSD often -- sometimes, maybe, depending on FS setup and layout -- has /home -> /usr/home or /home -> usr/home, and of course there could be weird user setups as well where .cache

D14927: KConfig: handle directory symlinks correctly.

adridg added a comment. Without patch, all tests Totals: 44 passed, 2 failed, 0 skipped, 0 blacklisted, 225ms The two failed tests are: - testThreads - testDelete With patch, all tests = Totals: 45 passed, 1 failed, 0

D14927: KConfig: handle directory symlinks correctly.

adridg added a comment. Sorry, this is getting very confusing: - when running all tests, unpatched: testDelete and testThreads fail - when running all tests, patched: testDefaults fails I suspect there are some more missing canonicalizations, but I don't have time right now to go

D15072: [server] Abort drag start on correct conditions and without posting error

adridg added inline comments. INLINE COMMENTS > adridg wrote in datadevice_interface.cpp:103 > this looks like it's still missing a !, based on the explanation "when the > client does not have an implicit pointer grab" I need new glasses :) REPOSITORY R127 KWayland REVISION DETAIL

D15072: [server] Abort drag start on correct conditions and without posting error

adridg added inline comments. INLINE COMMENTS > datadevice_interface.cpp:103 > // TODO: allow touch > -if (seat->hasImplicitPointerGrab(serial) && > seat->focusedPointerSurface() != origin) { > -wl_resource_post_error(resource, 0, "Surface doesn't have pointer > grab"); > +

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

adridg added a comment. Given the other reviews (which just drop this function), this one should be abandoned. tcberner@? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov,

D12135: Allow disabling of CoW to fail when not supported by filesystem

adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. Accepted as "doesn't hurt the non-Linux crowd, since they all live in the #ifndef Q_OS_LINUX branch" REPOSITORY R293 Baloo BRANCH accept_eopnotsupp_on_chattr REVISION DETAIL

D12136: Avoid hardcoding of filesystems supporting CoW

adridg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH disble_cow_unconditionally REVISION DETAIL https://phabricator.kde.org/D12136 To: bruns, #baloo, adridg Cc: #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun,

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

adridg added a comment. The question is mostly: does the existing (complicated) code do anything that QStorageInfo doesn't? Because switching to QStorageInfo gives us the functionality on FreeBSD for free (even if it's not useful because we'll never have btrfs). REPOSITORY R293 Baloo

D12231: Reduce the number of zombies to a minimum

adridg added a comment. Since you're using a global variable to accumulate ${numberOfProcesses} worth of po-files in one go, you should definitely clear out the variable when that bunch has been processed, or you'll grind through each po file more than once (with a growing command-list,

D17070: Don't double-count size of directories in DirectorySizeJob

adridg added a comment. With UFS, stat(1) tells me [adridg@beastie .../kio/build]$ stat . 2080587972 222556 drwxr-xr-x 9 adridg adridg 4294967295 17 "Nov 22 14:40:28 2018" "Nov 22 14:42:22 2018" "Nov 22 14:42:22 2018" "Nov 22 14:39:51 2018" 131072 17 0x800 . So that's a size

D17071: Don't include any directory sizes in DirectorySizeJob

adridg added a comment. With UFS, stat(1) tells me [adridg@beastie .../kio/build]$ stat . 2080587972 222556 drwxr-xr-x 9 adridg adridg 4294967295 17 "Nov 22 14:40:28 2018" "Nov 22 14:42:22 2018" "Nov 22 14:42:22 2018" "Nov 22 14:39:51 2018" 131072 17 0x800 . So that's a size

D20007: Add GetProcessList for retrieving the list of currently active processes

adridg added a comment. Config: Using QtTest library 5.12.1, Qt 5.12.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 6.0.1 (tags/RELEASE_601/final 335540)) PASS : KProcessListTest::initTestCase() PASS :

D20007: Add GetProcessList for retrieving the list of currently active processes

adridg added a comment. On FreeBSD, `/proc` is not necessarily mounted (it might be a Linuxism). So while I do **have** `/proc`, it's empty because procfs isn't mounted there. If I **do** mount it, then there's the expected list of processes and a curproc symlink. But `/proc/` doesn't

D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code.

adridg added a comment. I'd start to think about three separate files , unix_impl.cpp, windows_impl.cpp, stub_impl.cpp (although then you get API-syncing issues, probably, when only one of them is updated). REPOSITORY R286 KFileMetaData REVISION DETAIL

D21245: KAr::openArchive: Also check ar_longnamesIndex is not < 0

adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. ar_longnamesIndex is used as an array-index into ar_longnames, which is new[]ed, so a negative index is UB. This patch voids that case. REPOSITORY R243 KArchive BRANCH master

D21146: KProcessInfoList -- add proclist backend for FreeBSD

adridg added inline comments. INLINE COMMENTS > adridg wrote in kprocesslist_unix_procstat.cpp:38 > I absolutely have Opinions on C++ style that apply here, so I'm going to talk > to Tobias elsewhere. In order to simplify cleanup, I'd use a RAII class as well: /** @brief Wrapper around

D21146: KProcessInfoList -- add proclist backend for FreeBSD

adridg added inline comments. INLINE COMMENTS > kprocesslist_unix_proc.cpp:56 > #else > +# ifdef Q_OS_FREEBSD > +static const char formatC[] = "pid,state,user,command"; Are there situations where you would end up here? I mean, libprocstat is in base, since 9.0, so it is unlikely to be

D21305: Add the FreeBSD default-path for os-release.

adridg edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21305 To: adridg, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21305: Add the FreeBSD default-path for os-release.

adridg edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21305 To: adridg, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21305: Add the FreeBSD default-path for os-release.

adridg created this revision. adridg added a reviewer: sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. adridg requested review of this revision. REVISION SUMMARY - After much hemming and hawing we ended up with /usr/local/etc/os-release, which isn't

D21305: Add the FreeBSD default-path for os-release.

adridg abandoned this revision. adridg added a comment. Thanks for looking at this, Harald. For various downstream packaging reasons, we're going to be stuck with patching, so I'm going to give up on this particular patch. REPOSITORY R244 KCoreAddons REVISION DETAIL

D23335: Q_UNUSED doesn't need a ; after it.

adridg created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. adridg requested review of this revision. REVISION SUMMARY This reduces compiler warnings (-Wall, or just clang) about unnecessary ;s. REPOSITORY R244 KCoreAddons BRANCH

D23335: Q_UNUSED doesn't need a ; after it.

This revision was automatically updated to reflect the committed changes. Closed by commit R244:8e34c0b97393: Q_UNUSED doesnt need a ; after it. (authored by adridg). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23335?vs=64272=64282 REVISION DETAIL

D23338: Use baseFactory for K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL

adridg created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. adridg requested review of this revision. REVISION SUMMARY The existing macro always inherits from KPluginFactory -- making it hard to use when sub-classing KPluginFactory in

D22765: Docs: fix bad example code

adridg created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. adridg requested review of this revision. REVISION SUMMARY - setupBindings() doesn't take an engine parameter - setupBindings() is deprecated and suggests to call setupContext()

D22765: Docs: fix bad example code

This revision was automatically updated to reflect the committed changes. Closed by commit R296:2d39e2f0ad56: Docs: fix bad example code (authored by adridg). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22765?vs=62614=62623 REVISION DETAIL

D23692: kdesu: set kernel flags to prevent ptrace instead of relying on setgid

adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. LGTM on the FreeBSD side (I've checked, the procctl() code does block debugger access which is all we're asking to do). REPOSITORY R299 KDESu REVISION DETAIL

D25084: Allow a Multiple instances to become Unique

adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. This has been applied to FreeBSD ports because it works. +1 (with the other konsole patch that **is** on invent). REPOSITORY R271 KDBusAddons BRANCH multiple_to_unique REVISION

D25084: Allow a Multiple instances to become Unique

adridg added a comment. Now you (@davidedmundson ) mention it, yeah .. I've only tested positively, to see if konsole then does what I want. You're right that this could have surprising effects when multiple unique applications share a prefix (e.g. org.kde.plasma.something and

D21146: KProcessInfoList -- add proclist backend for FreeBSD

adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. Let's get this in, and then quibble about how much commentary needs to be written for the `_p.h` file (since, looking back, it's a bit heavy on the C++ fancyness -- my Opinions have

D24431: Restore cursor thumbnailer

adridg added inline comments. INLINE COMMENTS > CMakeLists.txt:149 > > -# if(X11_Xcursor_FOUND) > -# > -#set(cursorthumbnail_PART_SRCS cursorcreator.cpp) > -# > -#add_library(cursorthumbnail MODULE ${cursorthumbnail_PART_SRCS}) > -# > -#target_link_libraries(cursorthumbnail

Re: Does FreeBSD have HAL?

On Saturday, 4 January 2020 18:16:30 CET David Faure wrote: > qdbus --system org.freedesktop.HalManage Does not exist. There's some complications around HAL. We don't necessarily run it, but solid wants it, and the CD-eject functionality of Plasma Device notifier needs it (so I can't eject CD's

Re: Information regarding upcoming Gitlab Migration

There are a whole bunch of considerations and use-cases being discussed at once in this thread, and Leinir's post made me think a bit about different actors can interact with "the collection of repositories". One actor is "tooling", as Albert has pointed out. Whatever the resulting structure

Re: Information regarding upcoming Gitlab Migration

On 2020 prilula d. 28id 13:35:22 CEST Ben Cooksley wrote: > Would some form of git alias/custom command script that works similar > to the following be suitable? > > git kde-clone skrooge > > That script would then search the appropriate groups (ignoring any > personal repositories including

Re: Information regarding upcoming Gitlab Migration

On 2020 mayula d. 1id 07:08:41 CEST Ben Cooksley wrote: > On Fri, May 1, 2020 at 2:46 AM Nate Graham wrote: > > If I'm understanding things, we have solutions to most or all of the > > objections raised so far: > > > > - Projects will be allowed to live in--or at least appear in--multiple > >

Re: CI Breakage in Solid on FreeBSD

On Thursday, 15 October 2020 11:22:02 CEST Ben Cooksley wrote: > Yesterday changes were landed to Solid, allowing it to make use of new > libimobiledevice API. Unfortunately these changes failed to handle the > situation where an older version of libimobiledevice is in use, causing a > build

D10856: [WIP] Make tests compile, except one

adridg added a comment. Herald added a subscriber: kde-frameworks-devel. This looks abandoned, no movement in over two years. @michaelh did you still want to introduce docId instead of quint64? This diff was supposed to supplant D10851 but seems to have

D10851: autotests: Introduce alias DocId

adridg added a comment. Herald added a subscriber: kde-frameworks-devel. This looks abandoned, no movement in over two years. @michaelh do you want to explicitly abandon this one, so we have a clean slate for invent? None of the docId type changes seem to have made it to master (see also

D10825: [WIP] Introduce aliases DocId, DeviceId and Inode

adridg added a comment. Herald added a subscriber: kde-frameworks-devel. This looks abandoned with 2 years of no movement. @michaelh do you still feel this is a WIP? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10825 To: michaelh, adridg, #baloo, #frameworks Cc:

  1   2   >