D27965: [KPasswdServer] replace foreach with range/index-based for

This revision was automatically updated to reflect the committed changes. Closed by commit R241:018f223692de: [KPasswdServer] replace foreach with range/index-based for (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27965?vs=77554=77648

D27947: Port away from deprecated QList::toSet()

ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in kcoredirlister.cpp:1045 > Is this to force dir at the end? You mean at the front? I am not sure, but I matched the behaviour of the original code, it first appended "dir" then the QUrl list from canonicalUrls. It sort of makes

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir updated this revision to Diff 77554. ahmadsamir added a comment. QList::erase() invalidates the iterators REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27965?vs=77477=77554 BRANCH l-kpasswdserver (branched from master) REVISION DETAIL

D27947: Port away from deprecated QList::toSet()

ahmadsamir added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27947 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir updated this revision to Diff 77538. ahmadsamir added a comment. As pointed out by dfaure, we have to make sure the unit test passes even if KIO isn't installed (which might be the case on the KDE CI system). Since we aren't actually executing the ktelnetservice5 binary and only

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir updated this revision to Diff 77533. ahmadsamir added a comment. - Use QStandardPaths::findExecutable(), as the path isn't hardcoded to /usr/bin/ on all systems - More QVERIFY() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27999?vs=77521=77533

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir updated this revision to Diff 77521. ahmadsamir added a reviewer: feverfew. ahmadsamir added a comment. Tweak REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27999?vs=77520=77521 BRANCH l-krun-ssh (branched from master) REVISION DETAIL

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir updated this revision to Diff 77520. ahmadsamir edited the summary of this revision. ahmadsamir removed a reviewer: feverfew. ahmadsamir removed a subscriber: feverfew. ahmadsamir added a comment. Address comments, use QFINDTESTDATA() REPOSITORY R241 KIO CHANGES SINCE LAST

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir added a comment. FTR, I don't have access to any smb:// servers, so couldn't test the KIOFuse stuff. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, sitter, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Extend krununittest to test ktelnetservice. Use CMake target_compile_definitions() to set the

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir updated this revision to Diff 77477. ahmadsamir added a comment. - I missed one foreach before - Use erase() instead of remove(), safer to work on QList iterators REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27965?vs=77339=77477 BRANCH

D25315: KDirModel: implement showing a root node for the requested URL

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kdirmodeltest_gui.cpp:92 > It doesn't look "normal" : without the ShowRoot feature, you wouldn't see the > "/" root node. > So I would say the test program is valid, no matter what the starting > directory is. > > (I was

D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4b4ed81cc5f3: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively() (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

ahmadsamir updated this revision to Diff 77462. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27963?vs=77336=77462 BRANCH l-http-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D27963

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir added a comment. In D27965#625526 , @apol wrote: > Having the iterated value change under the hood will eventually break. I'd suggest preferring QList::erase to QList::removeOne. Actually, the code also uses 'delete current',

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir added a comment. In D27965#625234 , @meven wrote: > Please wait for a second review, I am not authoritative here. OK, thanks. REPOSITORY R241 KIO BRANCH l-kpasswdserver (branched from master) REVISION DETAIL

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. ahmadsamir added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-kpasswdserver (branched from master) REVISION DETAIL

D27964: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27964 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27964: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27964

D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use prefix increment operator. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-http-foreach

D27947: Port away from deprecated QList::toSet()

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-kcoredirlister-toset (branched from master) REVISION DETAIL

D27941: [protocoltojson] Replace foreach with range-for

This revision was automatically updated to reflect the committed changes. Closed by commit R241:283b8fce056e: [protocoltojson] Replace foreach with range-for (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27941?vs=77270=77273 REVISION

D27941: [protocoltojson] Replace foreach with range-for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-protocoltojson (branched from master) REVISION DETAIL

D25315: KDirModel: implement showing a root node for the requested URL

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kdirmodel.h:79 > That sounds more confusing to me, depending on how one thinks about all this. > > There's nothing special about the first child compared to other direct > children, one misinterpretation of your suggested

D25315: KDirModel: implement showing a root node for the requested URL

ahmadsamir added inline comments. INLINE COMMENTS > kdirmodeltest_gui.cpp:92 > +dirmodel->openUrl(QUrl(QStringLiteral("file:///")), > KDirModel::ShowRoot); > > const QUrl url = > QUrl::fromLocalFile(QStringLiteral("/usr/share/applications/kde")); I think a test with

D25315: KDirModel: implement showing a root node for the requested URL

ahmadsamir added inline comments. INLINE COMMENTS > kdirmodel.cpp:222 > +QUrl > parent(url.adjusted(QUrl::RemoveFilename|QUrl::StripTrailingSlash)); > +if (url.path() == QLatin1String("/")) > +parent.setPath(QString()); Braces around if. > kdirmodel.h:79 > + *

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

ahmadsamir updated this revision to Diff 77153. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27865?vs=77139=77153 BRANCH l-kfilefiltercombo (branched from master) REVISION DETAIL https://phabricator.kde.org/D27865

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9cb7cf957a1c: [KFileFilterCombo] Dont add invalid QMimeType to mimes filter (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

ahmadsamir updated this revision to Diff 77139. ahmadsamir added a comment. Rebase. Per dfaure's recommendation use qCWarning instead of qCDebug, the former is visible by default, which makes sense for a programmer error (feeding the open file dialog invalid mimeTypes). REPOSITORY R241

D27898: [autotests/*] Port foreach (deprecated) to range-based for loop

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e9f2cf0685df: [autotests/*] Port foreach (deprecated) to range-based for loop (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27898: [autotests/*] Port foreach (deprecated) to range-based for loop

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27898

D27894: [src/kcms/*] Replace foreach (deprecated) with range/index-based for

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d617bb704d1f: [src/kcms/*] Replace foreach (deprecated) with range/index-based for (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27894: [src/kcms/*] Replace foreach (deprecated) with range/index-based for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Add KF6 TODO about removing KURIFilterModule::load(), it's been redundant for a long time (circa 2014).

D27112: Fix errors in the QRegularExpression porting commit

This revision was automatically updated to reflect the committed changes. Closed by commit R269:408bdaa752fa: Fix errors in the QRegularExpression porting commit (authored by ahmadsamir). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27112?vs=77096=77097

D27112: Fix errors in the QRegularExpression porting commit

ahmadsamir updated this revision to Diff 77096. ahmadsamir added a comment. Rebase REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27112?vs=74880=77096 BRANCH l-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D27112 AFFECTED

D27112: Fix errors in the QRegularExpression porting commit

ahmadsamir added a comment. Can I land this? I keep getting side tracked and I haven't written those unit tests, but until then I hate leaving this broken. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D27112 To: ahmadsamir, #frameworks, drosca, apol, dfaure Cc:

D27811: [KConfigGui] Check font weight when clearing styleName property

ahmadsamir added a comment. In D27811#622885 , @ervin wrote: > This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in though since it can have ramifications I might miss. Well this one is the tip of

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

ahmadsamir added a comment. FTR, gwenview should be fixed by D27875 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27865 To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

ahmadsamir updated this revision to Diff 77032. ahmadsamir added a comment. Remove redundant #include REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27865?vs=77031=77032 BRANCH l-kfilefiltercombo (branched from master) REVISION DETAIL

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

ahmadsamir updated this revision to Diff 77031. ahmadsamir added a comment. Fix _debug.h file name REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27865?vs=77029=77031 BRANCH l-kfilefiltercombo (branched from master) REVISION DETAIL

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

ahmadsamir updated this revision to Diff 77029. ahmadsamir retitled this revision from "[KFileFilterCombo] Don't add inavlid QMimeType to mime filter" to "[KFileFilterCombo] Don't add invalid QMimeType to mimes filter". ahmadsamir removed a reviewer: kossebau. ahmadsamir removed a subscriber:

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

ahmadsamir added a reviewer: kossebau. ahmadsamir added a subscriber: kossebau. ahmadsamir added a comment. @kossebau: did I get the Qt logging bits correctly? (I copied from your other related commits :)). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27865 To:

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

ahmadsamir updated this revision to Diff 77015. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Give a warning about invalid mimeTypes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27865?vs=77012=77015 BRANCH l-kfilefiltercombo

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

ahmadsamir added a comment. Looking at upstream code, it looks like they introduced a static splitCommad() method since 5.15, so I think we'll have to use a #if QT_VERSION < QT_VERSION_CHECK(5, 15, 0) kludge to handle this case. Their rationale is more precise argument handling, which

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

ahmadsamir added a comment. In D27865#622605 , @dfaure wrote: > Maybe add a warning about the invalid type? After all it's a programmer error to send us invalid mimetypes here, right? Are you also fixing the source of the issue in gwenview?

D27864: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/

This revision was automatically updated to reflect the committed changes. Closed by commit R241:082e01b19a8e: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/ (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, sitter, broulik. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY When setting the mime filter, check that the QMimeType we get from

D27864: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, sitter, broulik. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY For trash:/ we have two individual cases: - trash:/ itself, show empty/full trash

D27846: Fix KNewFileMenuTest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b40856730534: Fix KNewFileMenuTest (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27846?vs=76968=76973 REVISION DETAIL

D27846: Fix KNewFileMenuTest

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Commit ebbfe14309c54476fac changed

D27811: [KConfigGui] Check font weight when clearing styleName property

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, davidedmundson, cfeck, ervin, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This is an addendum for commit a2774ff5b41987c3919a9e

D23457: Port the search interface from QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 76852. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Modify the extended context menu: - QRegularExpression supports fixed-length positive/negative lookbehind - With QRegularExpression/PCRE, \x escape sequences

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

This revision was automatically updated to reflect the committed changes. Closed by commit R237:a2774ff5b419: [KConfigGui] Clear styleName font property for Regular font sytles (authored by ahmadsamir). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

Re: kreversi 19.12 fails to build at IconSize call

ing%20-%20stable-kf5-qt5/job/kwordquiz/ I would be glad if someone could investigate these issues. Thanks, Christoph -- Ahmad Samir

D26211: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R246:633a9f22340b: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26211?vs=76705=76724 REVISION DETAIL

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir added a comment. To get those numbers I tested with this code: QFontDatabase fdb; const QStringList fontFamilies = fdb.families(); QStringList list; int regularCnt = 0; int normalCnt = 0; int bookCnt = 0; int romanCnt = 0; for (const QString :

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir updated this revision to Diff 76721. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Add some relevant statistics REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27735?vs=76682=76721 BRANCH l-font-sytleName

D26211: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 76705. ahmadsamir added a comment. - Move the QRegularExpression definition out of the for loop, more efficient as it'll reused - match() always allocates a QRegularExpressionMatch anyway, so move it inside the while loop - Make the first ()

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir updated this revision to Diff 76682. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Tweak commit message REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27735?vs=76671=76682 BRANCH l-font-sytleName (branched from

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir added a comment. Caveat: setting the general font to e.g. "Noto Sans" and then restarting the fonts KCM; opening the general font selection dialog, "Semi condensed" is selected instead of Regular. That looks like a bug in the static method nearestExistingFont() from

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir added a comment. Konsole's workaroun: https://phabricator.kde.org/R319:41693fe9ee263f8f2281852a740ee52d55f003ef KTextEditor workaround: https://phabricator.kde.org/R39:4d91fa7e918d983e6569798dfe20c7c9faf4bb9e REPOSITORY R237 KConfig REVISION DETAIL

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir added a comment. Some relevant info: https://bugreports.qt.io/browse/QTBUG-63792?focusedCommentId=377225=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-377225 https://codereview.qt-project.org/c/qt/qtbase/+/181645/ REPOSITORY R237 KConfig REVISION

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, davidedmundson, cfeck, ervin. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY If the styleName property is set for a QFont, using setBold(true) would lead to Qt

D27616: [UrlHandler] Handle opening the online docs for KCM modules

This revision was automatically updated to reflect the committed changes. Closed by commit R273:1275529bc2d5: [UrlHandler] Handle opening the online docs for KCM modules (authored by ahmadsamir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27616?vs=76522=76555#toc REPOSITORY R273

D27616: [UrlHandler] Handle opening the online docs for KCM modules

ahmadsamir updated this revision to Diff 76522. ahmadsamir added a comment. Really revert some changes REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27616?vs=76474=76522 BRANCH l-urlhandler-optimi (branched from master) REVISION DETAIL

D27616: [UrlHandler] Handle opening the online docs for KCM modules

ahmadsamir added a comment. In D27616#618382 , @apol wrote: > We can't add new dependencies to a tier1 framework, it would break the whole dependency system. > > Just make it a qCWarning. I opted for qDebug() for now, and will change

D27616: [UrlHandler] Handle opening the online docs for KCM modules

ahmadsamir updated this revision to Diff 76474. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Don't change dependencies for a low tier framework REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27616?vs=76463=76474 BRANCH

D27616: [UrlHandler] Handle opening the online docs for KCM modules

ahmadsamir updated this revision to Diff 76463. ahmadsamir retitled this revision from "[UrlHandler] optimise the code and less if nesting" to "[UrlHandler] Handle opening the online docs for KCM modules". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this

D27615: [UrlHandler] Handle opening the online docs for KCM modules

ahmadsamir abandoned this revision. ahmadsamir added a comment. See D27616 REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27615 To: ahmadsamir, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27097: Port from QRegExp to QRegularExpression

ahmadsamir added a comment. Looking at the incremental stuff some more, there are no public methods that mention incremental; the only way is to set the KFind::FindIncremental flag; the only method I could find is in the private API (find_p.h) startNewIncrementalSearch(). So technically

D27097: Port from QRegExp to QRegularExpression

ahmadsamir marked an inline comment as done. ahmadsamir added a comment. In D27097#615648 , @dfaure wrote: > OK for deprecating Incremental. A full revert (at KF6 time) of commit 9ac82e27ad0322e444c16

D27616: [UrlHandler] optimise the code and less if nesting

ahmadsamir added a comment. I created D27615 first; then this one on top of it (optimising the code in a separate commit). INLINE COMMENTS > apol wrote in urlhandler.cpp:55 > won't this recurse forever? I could be wrong, but this is exactly equivalent

D27615: [UrlHandler] Handle opening the online docs for KCM modules

ahmadsamir added a dependent revision: D27616: [UrlHandler] optimise the code and less if nesting. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27615 To: ahmadsamir, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27616: [UrlHandler] optimise the code and less if nesting

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Depends on D27615 TEST PLAN make && ctest REPOSITORY R273 KGuiAddons

D27615: [UrlHandler] Handle opening the online docs for KCM modules

ahmadsamir added a dependent revision: D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27615 To: ahmadsamir, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27615: [UrlHandler] Handle opening the online docs for KCM modules

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY For KCM modules, clicking the "Help" button when khelpcenter isn't installed should open the corresponding

D27597: KRunner: Refactor deprecated toSet() method

ahmadsamir added a comment. Hi there. Since KF5 min. supported Qt version is 5.12, you have to make the code conditional so that it still build on Qt < 5.14. (Qt 5.14 is where range-iterators-based constructors were introduced to Qt containers including QList

D27451: Drop KToolInvocation support from KRun::runService

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27451 To: davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27288: [policy-gen] Fix the code to actually use the correct capture group

This revision was automatically updated to reflect the committed changes. Closed by commit R283:f6020e857424: [policy-gen] Fix the code to actually use the correct capture group (authored by ahmadsamir). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE

D27288: [policy-gen] Fix the code to actually use the correct capture group

ahmadsamir updated this revision to Diff 75459. ahmadsamir retitled this revision from "[policy-gen] Fix the code to actually captured the correct capture group" to "[policy-gen] Fix the code to actually use the correct capture group". ahmadsamir added a comment. Fix commit message

D27288: [policy-gen] Fix the code to actually captured the correct capture group

ahmadsamir updated this revision to Diff 75458. ahmadsamir added a comment. Follow naming convention, KAuth REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27288?vs=75451=75458 BRANCH l-policy-gen (branched from master) REVISION DETAIL

D27288: [policy-gen] Fix the code to actually captured the correct capture group

ahmadsamir updated this revision to Diff 75451. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Add a simple/crude unit test REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE

D27269: Use ecm_qt_install_logging_categories over manual categories file

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27269 To: kossebau, #build_system, #frameworks, broulik, mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27268: Fixed handling of relative paths by KUrlNavigator

ahmadsamir added reviewers: dfaure, elvisangelaccio. ahmadsamir added a comment. I am curious, why would you remove the already present part of the path? when I make the url navigator editable the text cursor is already at the end of the path, so I can just start typing the name of a

D27288: [policy-gen] Fix the code to actually captured the correct capture group

ahmadsamir edited the test plan for this revision. ahmadsamir added a reviewer: apol. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D27288 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26118: Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26118#608935 , @broulik wrote: > This appears to have broken policy file generation. The polkit files I now get have > > Neues Plymouth-Design installieren > > > Note the "Name" in the `xml:lang`

D27288: [policy-gen] Fix the code to actually captured the correct capture group

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This was a mistake in porting form QRegExp::capturedTexts() to QRegularExpression; capturedTexts(1) translates

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

ahmadsamir requested review of this revision. ahmadsamir added a comment. krununittest fails to pass, I tried to debug it but can't get it to work. Disabling the third row "QTest::newRow("tempfile") << true << false;" in KRunUnitTest::KRunRunService_data, makes it pass... I can't figure it

D26468: Tests: don't build benchmark test by default

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26468 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27157: [KConfigLoader] Code cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R237:9dec6961b3ae: [KConfigLoader] Code cleanup (authored by ahmadsamir). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27157?vs=75029=75210 REVISION DETAIL

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

ahmadsamir planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27216 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY When a process that KRun tried to run fails to launch: - Tell the user when the executable could not be found

D27148: update d->m_file in ReadOnlyPart::setUrl()

ahmadsamir added a comment. I thought of making ReadOnlyPart::setUrl() set d->m_file if the url is a local file... but I am guessing d->m_file and d->m_url are kept separate on purpose, so the idea seemed a bit off. REPOSITORY R306 KParts REVISION DETAIL

D27148: update d->m_file in ReadOnlyPart::setUrl()

ahmadsamir added a comment. IIUC, this diff is fixing https://bugs.kde.org/show_bug.cgi?id=416989 (Konqueror -> Tools -> open terminal, doesn't work after D26140 ). Looking at the code in dolphin/src/dolphinpart.cpp, openUrl() is reimplemented[1],

D27157: [KConfigLoader] Code cleanup

ahmadsamir updated this revision to Diff 75029. ahmadsamir added a comment. Tweak commit message REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27157?vs=75008=75029 BRANCH l-configloader (branched from master) REVISION DETAIL

D27158: Fix some compiler warnings

ahmadsamir updated this revision to Diff 75028. ahmadsamir added a comment. Add missing space after , REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27158?vs=75009=75028 BRANCH l-compiler-warnings (branched from master) REVISION DETAIL

D27158: Fix some compiler warnings

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Fix order of member initialisation (compiling with -Wreorder) - Use Q_UNUSED where needed -

D27157: [KConfigLoader] Code cleanup

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Drop redundant args to startElement()/endEelement() - Use range-for - Drop ConfigLoaderHandler methods

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir updated this revision to Diff 74893. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24951?vs=68769=74893 BRANCH arcpatch-D24951 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24951

<    1   2   3   4   5   6   7   8   9   10   >