D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added a comment. In D24951#554138 , @ngraham wrote: > Why wouldn't you want the first result chosen when there's more than one result? If you enter a search term and get (say) 2 results and the one you want to select is the first

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added a comment. The user typing 'arc' then pressing Enter, and getting the file opened with wireshark is broken behaviour form the user's POV, that's the crux of the bug report in question. That combobox uses KCompletion and not having the up/down arrow keys navigate

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added a comment. In D24951#554485 , @ngraham wrote: > In D24951#554468 , @ahmadsamir wrote: > > > The user typing 'arc' then pressing Enter, and getting the file opened with wireshark is

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a comment. In D24928#553952 , @vkrause wrote: > The cipher naming stuff looks very fishy though, that's not due to your changes though but coming from old KSslCipher code. I'm wondering where the ssl_cipher meta data is being

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added a comment. In D24951#554516 , @dfaure wrote: > A sort model allows to define any sorting criteria you want (see QSortFilterProxyModel::lessThan), so this is technically possible: the criteria would say "if A is a match and B

D25421: [file_extractor] improve log message when the database can't be opened

ahmadsamir created this revision. ahmadsamir added reviewers: Baloo, astippich. Herald added projects: Frameworks, Baloo. ahmadsamir requested review of this revision. REVISION SUMMARY Bug: 407786 REPOSITORY R293 Baloo BRANCH l-log-messages (branched from master) REVISION DETAIL

D25421: [kio_tags] improve log message when the database can't be opened

ahmadsamir updated this revision to Diff 70062. ahmadsamir retitled this revision from "[file_extractor] improve log message when the database can't be opened" to "[kio_tags] improve log message when the database can't be opened". ahmadsamir edited the summary of this revision. ahmadsamir

D25421: [file_extractor] improve log message when the database can't be opened

ahmadsamir added a comment. In D25421#565217 , @bruns wrote: > This is obviously the wrong line of code for the referenced bug report. Well, it's obvious now. :) (I should have tested, but now that I try to test, I can't reproduce

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir added a comment. Ping. (I want to get this committed to close the gates before any more implicit conversions sneak in :)). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24349 To: ahmadsamir, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir updated this revision to Diff 70271. ahmadsamir marked 8 inline comments as done. ahmadsamir retitled this revision from "More (and last) fixes to compile without implicit conversion from ASCII/ByteArray" to "More fixes to compile without implicit conversion from ASCII/ByteArray".

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in slavebase.h:979 > This method should be const A B C, nothing changed inside make it const, D E F. > dfaure wrote in ftp.cpp:1232 > Should this be remoteEncoding()->decode(...) given that the method will then > use

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir added inline comments. INLINE COMMENTS > yurchor wrote in kfileplacesmodel.cpp:275 > This does not work. Our translation system cannot extract from something like > > I18NC_NOOP(fsBookmarks, QStringLiteral("Desktop")) > > all the strings below with I18NC_NOOP should be left as is.

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir updated this revision to Diff 70379. ahmadsamir marked 5 inline comments as done. ahmadsamir added a comment. - Keep I18NC_NOOP working - QLatin1String where appropriate - Rename mProtocolToStr() to protocolName(), and make it private (only used in slavebase) REPOSITORY R241

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir updated this revision to Diff 70407. ahmadsamir added a comment. Per dfaure's recommendation, change createSystemBookmark 2nd and 3rd params to take a const char * (since this is the translation context which will be dropped) and a QByteArray, respectively. REPOSITORY R241 KIO

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

This revision was automatically updated to reflect the committed changes. Closed by commit R36:aee422b0b2c4: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel (authored by ahmadsamir). REPOSITORY R36 Ark CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25631?vs=70624=70631

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

ahmadsamir added a comment. Thank you. REPOSITORY R36 Ark REVISION DETAIL https://phabricator.kde.org/D25631 To: ahmadsamir, #ark, elvisangelaccio, apol Cc: apol, kde-frameworks-devel, kde-utils-devel, fbampaloukas, tctara

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

ahmadsamir created this revision. ahmadsamir added reviewers: Ark, elvisangelaccio. Herald added a project: Ark. ahmadsamir requested review of this revision. REVISION SUMMARY KRecursiveFilterProxyModel was only needed to have recursive filtering, which became available upstream since Qt

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. In D23457#568067 , @dhaumann wrote: > Any news here? For starters, this needs to be rebased; I'll try and get to it soon. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To:

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. IIUC, FILENAME_MAX corresponds to PATH_MAX, 4096 (bytes; or chars in an array). NAME_MAX is the max. filename (the filename part only, without the canonical path) length, this is 255 on Linux. So using FILENAME_MAX is correct in the code. See:

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

ahmadsamir added a subscriber: ngraham. ahmadsamir added a comment. @ngraham: I do know how to land a diff :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24828 To: ahmadsamir, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

ahmadsamir added a reviewer: dfaure. ahmadsamir added a comment. IMHO, it's such a user-visible bug with several reports and it affects all apps that use KIO; it should be included if it can catch the 5.65 train. I can confirm it fixes the issue in my local build (and the code LGTM).

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

This revision was automatically updated to reflect the committed changes. ahmadsamir marked an inline comment as done. Closed by commit R241:54ccb1ac4883: More fixes to compile without implicit conversion from ASCII/ByteArray (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST

D24150: Fix crash on exit in kio_file

ahmadsamir added reviewers: dfaure, broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24150 To: hwti, cfeck, dfaure, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24217: [src/ioslaves/*] replace deprecated foreach with range for

ahmadsamir abandoned this revision. ahmadsamir added a comment. git branch mess up on my end, will submit again after cleaning. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24217 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24217: [src/ioslaves/*] replace deprecated foreach with range for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN The code compiles and passes all unit tests REPOSITORY R241 KIO BRANCH ahmad/foreach-ioslaves (branched from

D24220: [src/ioslaves/*] replace deprecated foreach with range for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN The code compiles and passes all unit tests REPOSITORY R241 KIO BRANCH ahmad/foreach-ioslaves2 (branched from

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks, ngraham, dfaure Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24372: Compile without deprecated foreach

ahmadsamir updated this revision to Diff 67510. ahmadsamir marked 7 inline comments as done. ahmadsamir added a comment. - User more descriptive var names other than list2 - qAsConst isn't needed if the method is const and the container is a member var REPOSITORY R241 KIO CHANGES SINCE

D24372: Compile without deprecated foreach

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in job.cpp:181 > You need a local const var to hold the result of the subjobs() method call. > > (repeats) IIUC, subjobs() returns a const QList &, do we still need a local const var?

D23902: [KCoreDirLister] replace deprecated foreach with range-for

ahmadsamir added a comment. In D23902#542046 , @dfaure wrote: > In D23902#542037 , @ahmadsamir wrote: > > > In D23902#542026 , @dfaure wrote: > > > >

D23902: [KCoreDirLister] replace deprecated foreach with range-for

ahmadsamir added a comment. In D23902#542026 , @dfaure wrote: > For the record, JFBastien was actually wrong. Calling .begin() on a const return value does call the const overload. Testcase http://www.davidfaure.fr/kde/const_retval.cpp

D24308: [DataProtocol] compile without implicit coversion from ascii

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3b98d91436f5: [DataProtocol] compile without implicit coversion from ascii (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir added a dependent revision: D24597: Port from deprecated KTcpSocket to QSslSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24588 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24597: Port from deprecated KTcpSocket to QSslSocket

ahmadsamir added reviewers: hein, mlaurent. ahmadsamir added subscribers: Konversation, kde-frameworks-devel. REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D24597 To: ahmadsamir, #konversation, hein, mlaurent Cc: kde-frameworks-devel, #konversation

D24597: Port from deprecated KTcpSocket to QSslSocket

ahmadsamir added a task: T11577: Port Konversation away from KTcpSocket. REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D24597 To: ahmadsamir, #konversation, hein, mlaurent Cc: kde-frameworks-devel, #konversation

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This is needed as part of porting Koversation to use QSslSocket instead of KTcpSocket. TEST PLAN The code

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir added a task: T11577: Port Konversation away from KTcpSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24588 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24372: Compile without deprecated foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7c0402ed9fd7: Compile without deprecated foreach (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24372?vs=67804=67808 REVISION DETAIL

D24372: Compile without deprecated foreach

ahmadsamir updated this revision to Diff 67804. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24372?vs=67510=67804 BRANCH arcpatch-D24372 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24372

D24372: Compile without deprecated foreach

ahmadsamir added a comment. I had to fix one conflict when rebasing, and basically D24419 ate the foreach src/core/ksslcertificatemanager.cpp@line 128 (by returning the result of calling contains() on the container, neater :)). REPOSITORY R241 KIO

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir added a comment. In D24588#546229 , @dfaure wrote: > Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or even just `askIgnoreSslErrors(KSslErrorUiData(socket), storedRules)`. > Don't know, just wondering (not

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir updated this revision to Diff 67818. ahmadsamir added a comment. @since should actually be in the future REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24588?vs=67817=67818 BRANCH ahmad/ktcpsocket-qsslsocket (branched from master) REVISION

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir updated this revision to Diff 67817. ahmadsamir added a comment. Api docs... REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24588?vs=67778=67817 BRANCH ahmad/ktcpsocket-qsslsocket (branched from master) REVISION DETAIL

D24603: Port away from deprecated KDELibs4Support

ahmadsamir added a comment. F7582001: kmenuedit-vs-dolphin-settings-dialog.png Looking at kmenuedit and dolphin settings dialog, the margin and spacing look comparable, so those setContentMargins and setSpacing calls aren't needed any more.

D24603: Port away from deprecated KDELibs4Support

ahmadsamir created this revision. ahmadsamir added a reviewer: mlaurent. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY kmenuedit seems to work, adding new submenus and items REPOSITORY R103 KMenu Editor

D24603: Port away from deprecated KDELibs4Support

ahmadsamir added a task: T11566: Port kmenuedit away from kdelibs4support. REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D24603 To: ahmadsamir, mlaurent Cc: plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D24597: Port from deprecated KTcpSocket to QSslSocket

ahmadsamir updated this revision to Diff 67833. ahmadsamir edited the summary of this revision. ahmadsamir removed reviewers: hein, mlaurent. ahmadsamir added a comment. Use KSslErrorUiData directly when calling askIgnoreSslErrors REPOSITORY R7 Konversation CHANGES SINCE LAST UPDATE

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir added a comment. In D24588#546367 , @vkrause wrote: > In D24588#546229 , @dfaure wrote: > > > Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or even just

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir removed a task: T11577: Port Konversation away from KTcpSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24588 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket

ahmadsamir updated this revision to Diff 67835. ahmadsamir retitled this revision from "Port from deprecated KTcpSocket to QSslSocket" to "[Konversation] Port from deprecated KTcpSocket to QSslSocket". ahmadsamir added a comment. Better commit message REPOSITORY R7 Konversation CHANGES

D24603: Port away from deprecated KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit R103:e3b8910670e3: Port away from deprecated KDELibs4Support (authored by ahmadsamir). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24603?vs=67820=67831

D24588: [SslUi] Add api docs for askIgnoreSslErrors()

ahmadsamir updated this revision to Diff 67834. ahmadsamir retitled this revision from "[SslUi] Overload askIgnoreSslErrors() to take a QSslSocket" to "[SslUi] Add api docs for askIgnoreSslErrors()". ahmadsamir added a comment. Since I wrote the docs bit anyway REPOSITORY R241 KIO CHANGES

D24588: [SslUi] Add api docs for askIgnoreSslErrors()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c38591b9d2a9: [SslUi] Add api docs for askIgnoreSslErrors() (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24588?vs=67834=67892 REVISION

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

ahmadsamir added reviewers: dfaure, vkrause. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19504 To: habacker, dfaure, vkrause Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24631: exclude ioslaves directory from api docs

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24631 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26106: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added a reviewer: drosca. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN The code compiles and the unit tests pass. REPOSITORY R269 BluezQt BRANCH l-qregularexpression (branched from master)

D26099: Port QRegExp to QRegularExpression

ahmadsamir planned changes to this revision. ahmadsamir added a comment. I messed up exactMatch stuff, will have to rethink it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich Cc: kde-frameworks-devel, hurikhan77,

D26123: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71941. ahmadsamir added a comment. Frameworks min. required Qt has just been raised to 5.12 REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=71934=71941 BRANCH l-qregexp (branched from master) REVISION

D26099: Port QRegExp to QRegularExpression

ahmadsamir marked an inline comment as done. ahmadsamir added a comment. I guess I was confused because I saw KItemModels has the min. Qt version 5.12.0 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71954. ahmadsamir added a comment. Don't assign inside if condition REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71943=71954 BRANCH l-qregexp (branched from master) REVISION DETAIL

D26123: Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kemailaddress.cpp:631 > Message from Giuseppe D'Angelo (author of QRegularExpression) : if you can > depend from Qt 5.12, there's QRegularExpression::anchoredPattern instead of > manual wrapping in \A and \z > > We can't

D26123: Port QRegExp to QRegularExpression

ahmadsamir added a comment. Sorry, I did reply to your inline comments but didn't "submit" the replies only "save draft"ed. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26123 To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel,

D26102: QAtomicInteger::loadRelaxed() and storeRelaxed() are available since Qt 5.14

ahmadsamir added a reviewer: mlaurent. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26102 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

D26123: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71934. ahmadsamir marked 4 inline comments as done. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Address review comments REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71936. ahmadsamir added a comment. Add TODO for when we can depend on Qt 5.12 REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71888=71936 BRANCH l-qregexp (branched from master) REVISION DETAIL

D26118: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71948. ahmadsamir added a comment. KF5 now requires Qt 5.12 REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26118?vs=71884=71948 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26106: Port QRegExp to QRegularExpression

ahmadsamir added a reviewer: Framework: Syntax Highlighting. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26106 To: ahmadsamir, drosca, #framework_syntax_highlighting Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71943. ahmadsamir added a comment. Frameworks now require Qt 5.12 REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71936=71943 BRANCH l-qregexp (branched from master) REVISION DETAIL

D26106: Port QRegExp to QRegularExpression

ahmadsamir edited reviewers, added: Frameworks; removed: Framework: Syntax Highlighting. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26106 To: ahmadsamir, drosca, #frameworks, #framework_syntax_highlighting Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26106: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71994. ahmadsamir added a comment. Link to KF6 task REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26106?vs=71843=71994 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26145: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71995. ahmadsamir added a comment. Link to KF6 task REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26145?vs=71959=71995 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26123: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71999. ahmadsamir added a comment. Verbatim REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=71941=71999 BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricator.kde.org/D26123

D26145: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71996. ahmadsamir added a task: T12279: Port frameworks away from QRegExp. ahmadsamir added a comment. Verbatim REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26145?vs=71995=71996 BRANCH l-qregularexpression

D26106: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71997. ahmadsamir added a comment. Verbatim REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26106?vs=71994=71997 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71992. ahmadsamir added a comment. Link to KF6 task REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71954=71992 BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricator.kde.org/D26099

D26145: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: mlaurent, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY With QRegularExpression \x escape sequences that use more than two hex digists have be in the form \x{}.

D26102: QAtomicInteger::loadRelaxed() and storeRelaxed() are available since Qt 5.14

This revision was automatically updated to reflect the committed changes. Closed by commit R293:de269bf48e58: QAtomicInteger::loadRelaxed() and storeRelaxed() are available since Qt 5.14 (authored by ahmadsamir). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D26156: [KDocTools] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Documentation, ltoscano. Herald added projects: Frameworks, Documentation. ahmadsamir requested review of this revision. REVISION SUMMARY xslt.cpp didn't really use QRegExp as the line using it has been commented out since 2013,

D26157: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: sitter, fvogt, jriddell. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R299 KDESu BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26158: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R286 KFileMetaData BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26157: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R299:8376e5f664a9: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26157?vs=72005=72007 REVISION DETAIL

D26177: Port QRegExp to QRegularExpression

ahmadsamir requested review of this revision. ahmadsamir added a comment. IINM, fileNameOnly() can be safely deleted; it's only used once on line 2226: fileNameOnly(baseName) and baseName is initialised on line 1630: QString baseName = QFileInfo(codegenFilename).fileName(); so it's

D26177: Port QRegExp to QRegularExpression

ahmadsamir planned changes to this revision. ahmadsamir added a comment. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26177 To: ahmadsamir, #frameworks, dfaure, ervin, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26118: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mlaurent. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Require Qt 5.12 for QRegularExpression::anchoredPattern() TEST PLAN make && ctest REPOSITORY R283 KAuth

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71869. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Use QRegularExpression::anchoredPattern() to port QRegExp::exactMatch() REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D26118: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71884. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Don't touch Qt required version directly for frameworks. Use \A and \z anchors instead of the convenience function QRegularExpression::anchoredPattern() REPOSITORY

D26118: Port QRegExp to QRegularExpression

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:14 > kauth is a framework package. You can't increase qt version directly. I didn't know that, sorry. Luckily fixing it is easy in this particular case, I'll anchor

D26101: Port away from Qt 5.14 deprecated QList methods

This revision was automatically updated to reflect the committed changes. Closed by commit R293:e1ad18533db3: Port away from Qt 5.14 deprecated QList methods (authored by ahmadsamir). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26101?vs=71837=71885 REVISION

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71888. ahmadsamir removed a subscriber: mlaurent. ahmadsamir added a comment. Revert min required Qt version REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71869=71888 BRANCH l-qregexp (branched from

D25980: [KAutoSaveFile] Use QUrl::path() instead of toLocalFile()

This revision was automatically updated to reflect the committed changes. Closed by commit R244:8e2768a69075: [KAutoSaveFile] Use QUrl::path() instead of toLocalFile() (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D25980: [KAutoSaveFile] Use QUrl::path() instead of toLocalFile()

ahmadsamir added a comment. In D25980#579978 , @dfaure wrote: > Yes. This matches the path() on line 77. Thanks for the pointer. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25980 To: ahmadsamir,

D26123: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71907. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. One more QRegExp REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=71900=71907 BRANCH l-qregexp (branched from master)

D26123: Port QRegExp to QRegularExpression

ahmadsamir planned changes to this revision. ahmadsamir added a comment. I missed one QRegExp. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26123 To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26123: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, mlaurent, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY I had to modify the regex pattern slightly to make kemailaddresstest pass TEST PLAN make &&

D26099: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Baloo, meven, bruns, astippich. Herald added projects: Frameworks, Baloo. ahmadsamir requested review of this revision. TEST PLAN The code builds and unit tests pass. REPOSITORY R293 Baloo BRANCH l-qregexp (branched from

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, aacid. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern() Port QRegExp::Wildcard with

D26195: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R236:84d17cbde725: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26195?vs=72115=72143 REVISION

D26136: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72081. ahmadsamir added a comment. Verbatim REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72035=72081 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26156: [KDocTools] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. ahmadsamir marked an inline comment as done. Closed by commit R238:36fae9517502: [KDocTools] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE

D26136: Port QRegExp to QRegularExpression

ahmadsamir edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

<    1   2   3   4   5   6   7   8   9   10   >