D26226: [KListOpenFilesJob] Use QString::splitRef()

This revision was automatically updated to reflect the committed changes. Closed by commit R244:4bcf55e06c2f: [KListOpenFilesJob] Use QString::splitRef() (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26226?vs=72207=72216

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir updated this revision to Diff 72206. ahmadsamir added a comment. Remove the call to std::unique: - It doesn't work like that - it's not needed as `lsof -t` already produces a sorted and unique list of pid's REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D26236: Port QRegExp to QRegularExpression (and some QStringRef) optimisation

ahmadsamir added inline comments. INLINE COMMENTS > kurlcompletion.cpp:503 > // no protocol. (QUrl does this only for absolute paths) > -if (protocol_regex.indexIn(url_copy) == 0) { > +if (protocol_regex.match(url_copy).hasMatch()) { > m_kurl = QUrl(url_copy); hasMatch()

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir updated this revision to Diff 72207. ahmadsamir added a comment. Make it const... :/ REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26226?vs=72206=72207 BRANCH l-splitref (branched from master) REVISION DETAIL

D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26236 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir added a comment. One more thing, since this is `lsof -t` it's only 52 entries on my system (not +10 of `lsof`), so it's not as big of an optimisation as I first thought (see D26226 for context). REPOSITORY R244 KCoreAddons REVISION

D26236: Port QRegExp to QRegularExpression (and some QStringRef) optimisation

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY First pass. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-qregularexpression (branched from

D26118: Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26118 To: ahmadsamir, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26099: Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

ahmadsamir updated this revision to Diff 72213. ahmadsamir retitled this revision from "Port QRegExp to QRegularExpression (and some QStringRef) optimisation" to "Port QRegExp to QRegularExpression (and some QStringRef optimisation)". ahmadsamir added a comment. Fix commit message typo

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26226 To: ahmadsamir, #frameworks, mpyne, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26118: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72039. ahmadsamir added a comment. QRegularExpression is an object like any other, make it const as need be. REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26118?vs=71948=72039 BRANCH l-qregularexpression (branched

D26123: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72045. ahmadsamir added a comment. Use const REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=71999=72045 BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricator.kde.org/D26123

D26136: Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26136#581721 , @apol wrote: > I'm a bit confused as to why the regex needs to be different. Explain in the commit message? Fair point. Done. REPOSITORY R265 KConfigWidgets REVISION DETAIL

D26136: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72035. ahmadsamir added a comment. Explain why the regex was changed REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=71923=72035 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26156: [KDocTools] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72037. ahmadsamir added a comment. Make QRegularExpression objects const. Declare and assign on one line. REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26156?vs=72004=72037 BRANCH l-qregularexpression

D26156: [KDocTools] Port QRegExp to QRegularExpression

ahmadsamir marked 2 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in docbookl10nhelper.cpp:184 > Just do `QRegularExpressionMatch match = rxEntity.match(line);` I did it that way to indicate match is going to be re-assigned-to later on, but it does

D26145: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R174:66ed335757c5: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26145?vs=71996=72038 REVISION DETAIL

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72040. ahmadsamir added a comment. Use const REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71992=72040 BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricator.kde.org/D26099

D26106: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72042. ahmadsamir added a comment. Fix copy-paste error Use const as need be REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26106?vs=71997=72042 BRANCH l-qregularexpression (branched from master) REVISION

D26158: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R286:6d6327868c8c: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26158?vs=72006=72036 REVISION

D26177: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, ervin, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::exactMatch() by using QRegularExpression::anchoredPattern() to match the entire

D25877: [KColorschemeManager] Add option to reenable following global theme

ahmadsamir added inline comments. INLINE COMMENTS > davidre wrote in kcolorschememanager.h:111 > Would I need to add @since for a new overload? I would say yes (your question made me search for an answer since I wanted too:)), from

D25877: [KColorschemeManager] Add option to reenable following global theme

ahmadsamir added inline comments. INLINE COMMENTS > ahmadsamir wrote in kcolorschememanager.h:111 > I would say yes (your question made me search for an answer since I wanted > too:)), from > https://community.kde.org/Guidelines_and_HOWTOs/API_Documentation: > > > The @since tag tells users

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, ilic, dfaure, mlaurent, aacid. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port toVisualText() and finalizeVisualText() to use QRegularExpression. Replace

D26118: Port QRegExp to QRegularExpression

ahmadsamir added reviewers: dfaure, apol. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26118 To: ahmadsamir, #frameworks, mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26208: [KEmailAddress] Remove redundant bool var

ahmadsamir added a comment. Ping. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26208 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26292: [KSambaShare] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use QRegularExpression::anchoredPattern() to port QRegExp::exactMatch(). TEST PLAN make && ctest REPOSITORY

D26429: [KCompletion] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This was pretty trivial. TEST PLAN make && ctest and klineedittest still works. REPOSITORY R284

D26194: Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D26194 To: ahmadsamir, #plasma, davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26177: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R237:2055025c0c79: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26177?vs=72138=72779 REVISION DETAIL

D26429: [KCompletion] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R284:846f686dfe5b: [KCompletion] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26429?vs=72777=72786

D26412: [Kuit] Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26412#587395 , @dfaure wrote: > Unittest for this method added in https://commits.kde.org/ki18n/a92305a4c15ac361417eeb7b933682960c7545e1 > Please check your change passes the test. > Extend as needed if you

D24793: [Konqueror] Remove KonqView::setActiveComponent()

This revision was automatically updated to reflect the committed changes. Closed by commit R226:fefbc0ce295c: [Konqueror] Remove KonqView::setActiveComponent() (authored by ahmadsamir). REPOSITORY R226 Konqueror CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24793?vs=72782=72783

D24793: [Konqueror] Remove KonqView::setActiveComponent()

ahmadsamir updated this revision to Diff 72782. ahmadsamir added a comment. Rebase REPOSITORY R226 Konqueror CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24793?vs=68322=72782 BRANCH ahmad/setactiveComponent (branched from master) REVISION DETAIL

D26099: Port QRegExp to QRegularExpression

ahmadsamir added reviewers: apol, dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent, apol, dfaure Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov,

D26136: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72780. ahmadsamir added a comment. Rebase REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72083=72780 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26136: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R265:05ea3d2926e7: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72780=72781 REVISION

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

This revision was automatically updated to reflect the committed changes. Closed by commit R249:a9f4cbdda790: [Kuit] Port QRegExp to QRegularExpression, third pass (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26366?vs=72748=72763

D26412: [Kuit] Port QRegExp to QRegularExpression

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26412 To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26412: [Kuit] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R249:7e20f49520d9: [Kuit] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26412?vs=72756=72764 REVISION

D26461: [networkmanager-qt] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R282:7627f64e0103: [networkmanager-qt] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D26461: [networkmanager-qt] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, jgrulich, dfaure. Herald added a project: Frameworks. Herald added 1 blocking reviewer(s): jgrulich. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R282 NetworkManagerQt BRANCH

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. I hacked up some (rather crude, to say the least) benchmarking: void KLocalizedStringTest::benchmarkRegexSimple() { QString roleName, cueName, formatName; QString context = QStringLiteral("@info:tooltip/plaintext"); QBENCHMARK

D26453: [Purpose] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY QRegExp::exactMatch -> QRegularExpression::anchoredPattern() QRegExp::Wildcard ->

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. In D26366#588416 , @dfaure wrote: > Benchmarking is complex ;) > > 1. you need to make sure both Qt and your benchmark are built with optimizations enabled (-O2) > 2. you need to actually use those 3 variables

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. In D26366#588416 , @dfaure wrote: > Benchmarking is complex ;) > > 1. you need to make sure both Qt and your benchmark are built with optimizations enabled (-O2) > 2. you need to actually use those 3 variables

D26470: [Solid] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern(). TEST PLAN make && ctest

D26470: [Solid] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R245:11ec991bd14b: [Solid] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26470?vs=72894=72903 REVISION

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. In D26366#589229 , @dfaure wrote: > So, the old way was 76 times faster than the new regexp :-) > > I'm not surprised, though, it's consistent with my experience with regexps. > > This might be a good reason to

D26453: [Purpose] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R495:8dc165f088f3: [Purpose] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26453?vs=72856=72949

D26487: [Kuit] Revert changes in parseUiMarker()

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, ilic, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This commit partially reverts a9f4cbdda790c3962

D26194: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R308:7b356e9dd1ad: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26194?vs=72946=72947 REVISION DETAIL

D26194: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72946. ahmadsamir added a comment. Rebase REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26194?vs=72116=72946 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

ahmadsamir added a comment. Hello. Bug 415951 doesn't look related to this diff. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26492 To: broulik, #frameworks, ngraham Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

ahmadsamir updated this revision to Diff 72266. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Address comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26236?vs=72213=72266 BRANCH l-qregularexpression (branched from

D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ee88418ec827: Port QRegExp to QRegularExpression (and some QStringRef optimisation) (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27964: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27964

D27964: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27964 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use prefix increment operator. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-http-foreach

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir updated this revision to Diff 77477. ahmadsamir added a comment. - I missed one foreach before - Use erase() instead of remove(), safer to work on QList iterators REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27965?vs=77339=77477 BRANCH

D25315: KDirModel: implement showing a root node for the requested URL

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kdirmodeltest_gui.cpp:92 > It doesn't look "normal" : without the ShowRoot feature, you wouldn't see the > "/" root node. > So I would say the test program is valid, no matter what the starting > directory is. > > (I was

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir added a comment. FTR, I don't have access to any smb:// servers, so couldn't test the KIOFuse stuff. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, sitter, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Extend krununittest to test ktelnetservice. Use CMake target_compile_definitions() to set the

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir added a comment. In D27965#625526 , @apol wrote: > Having the iterated value change under the hood will eventually break. I'd suggest preferring QList::erase to QList::removeOne. Actually, the code also uses 'delete current',

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir added a comment. In D27965#625234 , @meven wrote: > Please wait for a second review, I am not authoritative here. OK, thanks. REPOSITORY R241 KIO BRANCH l-kpasswdserver (branched from master) REVISION DETAIL

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

ahmadsamir updated this revision to Diff 77139. ahmadsamir added a comment. Rebase. Per dfaure's recommendation use qCWarning instead of qCDebug, the former is visible by default, which makes sense for a programmer error (feeding the open file dialog invalid mimeTypes). REPOSITORY R241

D27898: [autotests/*] Port foreach (deprecated) to range-based for loop

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e9f2cf0685df: [autotests/*] Port foreach (deprecated) to range-based for loop (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9cb7cf957a1c: [KFileFilterCombo] Dont add invalid QMimeType to mimes filter (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

ahmadsamir updated this revision to Diff 77153. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27865?vs=77139=77153 BRANCH l-kfilefiltercombo (branched from master) REVISION DETAIL https://phabricator.kde.org/D27865

D25315: KDirModel: implement showing a root node for the requested URL

ahmadsamir added inline comments. INLINE COMMENTS > kdirmodel.cpp:222 > +QUrl > parent(url.adjusted(QUrl::RemoveFilename|QUrl::StripTrailingSlash)); > +if (url.path() == QLatin1String("/")) > +parent.setPath(QString()); Braces around if. > kdirmodel.h:79 > + *

D25315: KDirModel: implement showing a root node for the requested URL

ahmadsamir added inline comments. INLINE COMMENTS > kdirmodeltest_gui.cpp:92 > +dirmodel->openUrl(QUrl(QStringLiteral("file:///")), > KDirModel::ShowRoot); > > const QUrl url = > QUrl::fromLocalFile(QStringLiteral("/usr/share/applications/kde")); I think a test with

D25315: KDirModel: implement showing a root node for the requested URL

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kdirmodel.h:79 > That sounds more confusing to me, depending on how one thinks about all this. > > There's nothing special about the first child compared to other direct > children, one misinterpretation of your suggested

D27947: Port away from deprecated QList::toSet()

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-kcoredirlister-toset (branched from master) REVISION DETAIL

D27941: [protocoltojson] Replace foreach with range-for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-protocoltojson (branched from master) REVISION DETAIL

D27941: [protocoltojson] Replace foreach with range-for

This revision was automatically updated to reflect the committed changes. Closed by commit R241:283b8fce056e: [protocoltojson] Replace foreach with range-for (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27941?vs=77270=77273 REVISION

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir updated this revision to Diff 77521. ahmadsamir added a reviewer: feverfew. ahmadsamir added a comment. Tweak REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27999?vs=77520=77521 BRANCH l-krun-ssh (branched from master) REVISION DETAIL

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir updated this revision to Diff 77520. ahmadsamir edited the summary of this revision. ahmadsamir removed a reviewer: feverfew. ahmadsamir removed a subscriber: feverfew. ahmadsamir added a comment. Address comments, use QFINDTESTDATA() REPOSITORY R241 KIO CHANGES SINCE LAST

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. ahmadsamir added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-kpasswdserver (branched from master) REVISION DETAIL

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir updated this revision to Diff 77533. ahmadsamir added a comment. - Use QStandardPaths::findExecutable(), as the path isn't hardcoded to /usr/bin/ on all systems - More QVERIFY() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27999?vs=77521=77533

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

ahmadsamir updated this revision to Diff 77462. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27963?vs=77336=77462 BRANCH l-http-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D27963

D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4b4ed81cc5f3: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively() (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To: ahmadsamir, #frameworks, dfaure, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir added a comment. OK, thanks for the pointers. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To: ahmadsamir, #frameworks, dfaure, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir added a comment. hmm... first this is a copy-paste "error" on my part, I personally never use & when the RHS is a temporary (I don't see the point). Anyway; looking at statResult(): const UDSEntry ::statResult() const { return d_func()->m_statResult; } it

D28271: [KFontChooser] More code cleanup

ahmadsamir added a comment. Ping. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28271 To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir added a comment. Ping. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28274 To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir added a comment. I did some more testing: $ grep -ir :local *protocol about.protocol:Class=:local activities.protocol:Class=:local applications.protocol:Class=:local ar.protocol:Class=:local baloosearch.protocol:Class=:local

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir added a comment. And it seems recentdocuments:/ shows representation of recent "documents", parsed from .desktop files in ~/.local/share/RecentDocuments/, so it doesn't need to be handled here. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To:

D28726: [KJS] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, porten. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R314 KJs BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D28723: [KPropertiesDialog] Fix QLayout warning

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY If a widget, QFrame in this case, already has a QLayout, adding/parenting another layout to it shows a

D28679: [KPropertiesDialog] Disable changing remote dir icons

ahmadsamir updated this revision to Diff 79766. ahmadsamir retitled this revision from "[KPropertiesDialog] Disable changing dir icon on samba shares" to "[KPropertiesDialog] Disable changing remote dir icons". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for

D28723: [KPropertiesDialog] Fix QLayout warning

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e4bf478b7d07: [KPropertiesDialog] Fix QLayout warning (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28723?vs=79767=79778 REVISION DETAIL

D28793: [KBookMarksMenu] Set objectName for newBookmarkFolderAction

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This is needed if users of this class are expected to add the action manually to their program actionCollection.

D28793: [KBookMarksMenu] Set objectName for newBookmarkFolderAction

This revision was automatically updated to reflect the committed changes. Closed by commit R294:9075f6345cfa: [KBookMarksMenu] Set objectName for newBookmarkFolderAction (authored by ahmadsamir). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R236:56090c8f380e: [KFontRequester] Port from QFontDialog to KFontChooserDialog (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

ahmadsamir added inline comments. INLINE COMMENTS > ahmadsamir wrote in kfontrequester.cpp:188 > Plus we can't end up with a non-valid QFont, the dialog is filled from > QFontDataBase; so unless the user went and uninstalled the font while the > dialog was open, it should be OK. Also, font

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfontrequester.cpp:188 > It's really not obvious from the above that this modifies m_selFont. > > But I see QFont has no isValid() so we can't adopt an API like > QColorDialog::getColor (plus KFontChooserDialog has been

D28271: [KFontChooser] More code cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R236:11589f5e4166: [KFontChooser] More code cleanup (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28271?vs=78986=79812 REVISION

<    1   2   3   4   5   6   7   8   9   10   >