D24398: Rewrite ugly for with pointer arithmetic into range for

aacid closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24398 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

aacid added a comment. Lol it's opensuse being silly, oh well. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24384 To: guoyunhe, #frameworks, #vdg Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

aacid added a comment. Really? toys are only for children and adults should be ashamed to play with toys? Come on, i thought we were past that. Anyway, i'm really confused now, does your Stream have the Amusement category? Because the steam.desktop from

D24398: Rewrite ugly for with pointer arithmetic into range for

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D24398 AFFECTED FILES

D24395: Add some std::move in setter functions

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY typically we pass the param as const &, but here we forgot, we can fix that problem by adding an std::move and have a

D24384: Move Amusement to Games directory instead of Games > Toys

aacid added a comment. Have you contacted Valve to tell them amusement is the wrong category for Steam? Because the spec says Amusement - > a simple amusement And that's not what steam is IMHO this patch is wrong and steam is what needs fixing. REPOSITORY R309 KService

D24348: Use range for loop instead of ugly sizeof arithmetic

aacid closed this revision. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D24348 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24347: Use range for loop instead of sizeof(x) / sizeof(x[0])

aacid closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D24347 To: aacid, vkrause Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales,

D24346: Use range for instead of sizeof(aztec_code_double_symbols) / sizeof(aztec_code_double_symbols[0])

aacid closed this revision. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D24346 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24344: Use range for instead of sizeof(buttons) / sizeof(buttons[0])

aacid closed this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D24344 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24348: Use range for loop instead of ugly sizeof arithmetic

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R310 KTextWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D24348 AFFECTED FILES

D24347: Use range for loop instead of sizeof(x) / sizeof(x[0])

aacid created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D24347 AFFECTED FILES

D24346: Use range for instead of sizeof(aztec_code_double_symbols) / sizeof(aztec_code_double_symbols[0])

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D24346 AFFECTED FILES src/lib/aztecbarcode.cpp

D24344: Use range for instead of sizeof(buttons) / sizeof(buttons[0])

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24344 AFFECTED FILES src/kdatepicker.cpp

D24245: Add support for passing Unix file descriptors

aacid added a comment. In D24245#539508 , @volkov wrote: > Without UnixFileDescriptor you could try to write > > int fd = ... > Action action(...); > action.addArgument(QStringLiteral("fd"), fd); > > > but then KAuth won't be

D24312: Small performance enhacements

This revision was automatically updated to reflect the committed changes. Closed by commit R237:33bcefa50dcf: Small performance enhacements (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24312?vs=67066=67084#toc REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D24311: Remove useless variable

aacid closed this revision. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D24311 To: aacid, cullmann Cc: cullmann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24312: Small performance enhacements

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY suggested by clang-tidy REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D24312

D24311: Remove useless variable

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL https://phabricator.kde.org/D24311 AFFECTED FILES src/kemailaddress.cpp To:

D24245: Add support for passing Unix file descriptors

aacid added a comment. Applications are supposed to do that? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24293: Make QSslError::SslError <-> KSslError::Error conversion reusable

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24293 To: vkrause, dfaure, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

aacid added inline comments. INLINE COMMENTS > kauthunixfiledescriptor.h:33 > + > +class KAUTH_EXPORT UnixFileDescriptor > +{ Does this class really need to be exported and its header installed? Seems like this is implementation detail? Who would use this header? REPOSITORY R283 KAuth

D24245: Add support for passing Unix file descriptors

aacid added inline comments. INLINE COMMENTS > HelperProxy.cpp:25 > + > +#include > +#include i don't think we should have dbus stuff in HelperProxy, dbus stuff should be in DBusHelperProxy, no? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov,

D24245: Add support for passing Unix file descriptors

aacid added a reviewer: security-team. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24150: Fix crash on exit in kio_file

aacid added a comment. why the void? do you get a warning otherwise? Also a comment in that line quoting the Qt docs "Note that you should not delete codecs yourself: once created they become Qt's responsibility." makes sense IMHO otherwise someone will move it back to the old code to

D24113: xcf: Properly read image resolution

aacid closed this revision. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D24113 To: aacid, cfeck, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24114: xcf: Fix regression when reading files with "unsupported" properties

aacid closed this revision. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D24114 To: aacid, cfeck, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24113: xcf: Properly read image resolution

aacid created this revision. aacid added reviewers: cfeck, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY QDataStream reads 64 bits when reading into a float unless you tell it to use

D24114: xcf: Fix regression when reading files with "unsupported" properties

aacid created this revision. aacid added reviewers: cfeck, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY The fact that we don't know the property is most of the times not fatal, so what we

D24010: Fix generating properties that start with an uppercase letter

aacid added a comment. Doesn't this create any change on the other test13 files? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24010 To: apol, #frameworks Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

aacid added a comment. In D23894#530619 , @dfaure wrote: > Not that QML code will get any warning for using a deprecated property though... Maybe something we can suggest for KF6 to add a DEPRECATED to properties? Anyhow this looks

D23713: strongswan support for custom proposals

This revision was automatically updated to reflect the committed changes. Closed by commit R116:9d88ac7082cf: strongswan support for custom proposals (authored by rrichmond, committed by aacid). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. CHANGED PRIOR TO COMMIT

D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. The test fails here because the autotests/read/hdr/rgb.png file is 0 bytes, but if that is a phabricator artifact and it's really not a 0 bytes size, go ahead and commit :) REPOSITORY

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

aacid added a comment. maybe add the angleX property so we can tell people to move from angle to angleX and in KF6 we can remove angle and all is nice? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23894 To: dfaure, mart, davidedmundson Cc: aacid,

D23896: [KDeclarative] Port away from deprecated QQuickWindow::sendEvent

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH quickwindow_sendevent (branched from master) REVISION DETAIL https://phabricator.kde.org/D23896 To: dfaure, mart, davidedmundson, aacid Cc: kde-frameworks-devel, LeGast00n,

D23919: Make KSslError hold a QSslError internally

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23919 To: vkrause, dfaure, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23839: Port away from Qt's foreach

aacid added a comment. seems good to me, but let someone of the people that actually know the code to the +2 REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D23839 To: kossebau, #kwin, zzag Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23825: Split KSslErrorUiData from KTcpSocket

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Other than that just commit it i'd say, you're just moving code around so no need to "re-review" code that we already accept as "good" for the moment imho REPOSITORY R241 KIO BRANCH

D23825: Split KSslErrorUiData from KTcpSocket

aacid added inline comments. INLINE COMMENTS > ksslerroruidata.h:26 > + > +template class QList; > +class KTcpSocket; Minor comment, with all the "noise" around QList in Qt6, would it be maybe more future proof to just #include ehre so we don't end up declaring a class that doesn't exist in

D23797: [KWidgetAddons] port to non-deprecated Qt API

aacid added a comment. +1 looks sane but i have **not** tried this INLINE COMMENTS > kcollapsiblegroupbox.cpp:288 > { > -int top, left, right, bottom; > -getContentsMargins(, , , ); > +QMargins margins = contentsMargins(); > if you get bored, add const? >

D23753: Fix test failing

aacid closed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D23753 To: aacid, ngraham, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23753: Fix test failing

aacid created this revision. aacid added reviewers: ngraham, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Need to set the QLocale manually since when we call setlocale Qt has already

D23739: Fix uninitialized memory read

aacid closed this revision. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D23739 To: aacid, dfaure, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

aacid added a comment. But i guess @huftis is right, the test is not setting the language "enough" to be french, just "a bit" (there's too many layers of stuff to set) and it just works for me because i'm also in a locale tht uses , like the french REPOSITORY R249 KI18n REVISION DETAIL

D22069: Localize long number strings

aacid added a comment. In D22069#526284 , @ngraham wrote: > In D22069#526278 , @aacid wrote: > > > In D22069#526243 , @ngraham wrote: > > > > > That's

D22069: Localize long number strings

aacid added a comment. In D22069#526243 , @ngraham wrote: > That's the same failure I have too, but @aacid said it was because my system was mis-configured. I don't really understand the issue, I'm afraid. Are you really saying that when

D23739: Fix uninitialized memory read

aacid created this revision. aacid added reviewers: dfaure, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Make sure whole of pixel_size in pixel has data either because it was read or

D22069: Localize long number strings

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH localized-long-number-strings (branched from master) REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik, aacid Cc: aacid, huftis,

D23119: Fix dates being on the wrong locale when setting an application language individually

aacid added a comment. In D23119#519676 , @asemke wrote: > The original problem in LabPlot was reported by a windows user. The proposed fix won't fix the problem on windows. I think the only way to get the proper strings on Windows is to get

D22069: Localize long number strings

aacid added a comment. Other tests are telling you "French test files not usable." You don't have the setup correct for the test to work. You need to fix your setup for the test to pass, but first since you already have a "wrong" setup, please add the qskip like the other tests

D22069: Localize long number strings

aacid added a comment. In D22069#523253 , @ngraham wrote: > I'm not sure I understand about about localization to figure that out. Would you be able to help me out? Figure *what* out? Just remove this diff --git

D23119: Fix dates being on the wrong locale when setting an application language individually

aacid updated this revision to Diff 64176. aacid edited the summary of this revision. aacid removed a subscriber: ltoscano. aacid added a comment. update commit log REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23119?vs=63633=64176 BRANCH

D23119: Fix dates being on the wrong locale when setting an application language individually

aacid added inline comments. INLINE COMMENTS > asemke wrote in kxmlgui_unittest.cpp:1089 > does this test work? The name of the month is "январь" in russian, not > "января". Yes, it may surprise you, but i did actually run the tests before submitting this code change. REPOSITORY R263

D23224: Fix capitalization of Nextcloud

aacid closed this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D23224 To: z3ntu, nicolasfella, apol Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23119: Fix dates being on the wrong locale when setting an application language individually

aacid added a comment. hmmm, now that i think about it LC_ALL probably needs a .UTF-8 suffix or something to be correct But OTOH this is working fine for me. comments? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23119 To: aacid Cc:

D23119: Fix dates being on the wrong locale when setting an application language individually

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY We were only setting LANGUAGE, but that does not set LC_TIME so the time was still set to the "system" locale, we now

Re: KCrash crash racing

El dimecres, 7 d’agost de 2019, a les 16:36:31 CEST, Harald Sitter va escriure: > On Mon, Aug 5, 2019 at 10:58 PM Albert Astals Cid wrote: > > > I am fairly out of ideas :/ > > > > Tried looking at what breakpad does? > > Breakpad does mostly what we do,

D22979: Security: remove support for $(...) in config keys with [$e] marker.

aacid added a reviewer: security-team. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22979 To: dfaure, mdawson, aacid, broulik, davidedmundson, kossebau, apol, sitter, security-team Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22698: Support passing target to ki18n_wrap_ui macro

This revision was automatically updated to reflect the committed changes. Closed by commit R249:8f84d19aad04: Support passing target to ki18n_wrap_ui macro (authored by daandemeyer, committed by aacid). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

Re: KCrash crash racing

El dimecres, 31 de juliol de 2019, a les 12:26:23 CEST, Harald Sitter va escriure: > Moin Moin! > > I've been haunting down a nasty backtrace problem in drkonqi where it > entirely fails to create a backtrace and am now fairly confident this > is in fact a design flaw with kcrash, but I have no

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

aacid added a comment. Ok, yep i may have misunderstood :) But if you say "kapidox supports Python 2.7" we need to commit this to keep it true :) REPOSITORY R264 KApiDox BRANCH handlenonasciipathwpython27 REVISION DETAIL https://phabricator.kde.org/D22836 To: kossebau,

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Pino please take a step back and rethink your position. Yes, supporting Python2 sucks, but this is **2** lines of code while porting everything to Python 3 is lots of work more. If

D22786: KTar::openArchive: Don't assert if file has two root dirs

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22786 To: aacid, apol, dfaure Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22786: KTar::openArchive: Don't assert if file has two root dirs

aacid updated this revision to Diff 62749. aacid added a comment. don't return false on the "two roots scenario" as suggested by dfaure REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22786?vs=62684=62749 BRANCH arcpatch-D22786 REVISION DETAIL

D22782: KZip::openArchive: Don't assert when opening broken files

aacid added a comment. Ok, if you think so, you're the maintainer after all. But since you seem to have a clear idea of how the error messages should look like, maybe we can do it the other way around, you do the patch and i review it? REPOSITORY R243 KArchive REVISION DETAIL

D22789: KZip::openArchive: Don't assert when opening broken files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22789 To: aacid, apol Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22797: Fix typo - GridView -> ScrollView

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D22797 To: ognarb, #plasma, aacid Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22782: KZip::openArchive: Don't assert when opening broken files

aacid added a comment. In D22782#503345 , @dfaure wrote: > Yes, I mean all of them. I think it can useful to have such "technical" error messages, obviously not something you'd show the user directly, but maybe in an "advanced" button of

D22789: KZip::openArchive: Don't assert when opening broken files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY It's not nice bringing down the application just because the user opens a broken file REPOSITORY R243 KArchive BRANCH

D22786: KTar::openArchive: Don't assert if file has two root dirs

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY I was wondering if adding this check in KArchive::setRootDir instead but i ended doing it here since i think an assert in

D22786: KTar::openArchive: Don't assert if file has two root dirs

aacid added subscribers: apol, dfaure. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22786 To: aacid Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22782: KZip::openArchive: Don't assert when opening broken files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22782 To: aacid, dfaure Cc: dfaure, kde-frameworks-devel, apol, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22782: KZip::openArchive: Don't assert when opening broken files

aacid added a comment. I can do that if you prefer but if you look the setErrorString just 8 lines above it's also mega "technical". Want me to change that one too? REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D22782 To: aacid, dfaure Cc:

D22780: KZip::openArchive: turn assert into if+return false

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22780 To: aacid, dfaure Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22782: KZip::openArchive: Don't assert when opening broken files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY It's not nice bringing down the application just because the user opens a broken file REPOSITORY R243 KArchive BRANCH

D22780: KZip::openArchive: turn assert into if+return false

aacid updated this revision to Diff 62651. aacid added a comment. better tr string? REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22780?vs=62649=62651 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22780 AFFECTED FILES src/kzip.cpp

D22780: KZip::openArchive: turn assert into if+return false

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Asserting just because you opened a broken file is not nice REPOSITORY R243 KArchive BRANCH master REVISION DETAIL

D22715: Save and load page margins

aacid added a comment. > It seems the QPrinter/QPrintDialog still do not correctly read info from CUPS E_NEEDS_MORE_INFO > neither does it correctly remember print settings This is by design AFAIK, but maybe a patch would be accepted if people would submit one. I'm still not

D22751: KTar::openArchive: Remove "bad" assert

This revision was automatically updated to reflect the committed changes. Closed by commit R243:70e834050a61: KTar::openArchive: Remove bad assert (authored by aacid). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22751?vs=62573=62647 REVISION DETAIL

D22751: KTar::openArchive: Remove "bad" assert

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY There's nothing the caller of this function can do to control the assert condition, so asserting is "too rude", and on

D22723: Fix RunnerManager::queryFinished()

aacid added a comment. I honestly don't see the problem with this patch, one may argue that the ThreadWeaver API is awkward, ok, but this is using it correctly AFAICS, i.e. have a ThreadWeaver::QObjectDecorator, give it a ThreadWeaver::Job on its constructor, and go on from there.

D22730: KZip::openArchive: Remove "bad" assert

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22730 To: aacid, apol Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

Re: Qt dependency policy

El diumenge, 21 de juliol de 2019, a les 12:55:21 CEST, David Faure va escriure: > Taking into account the feedback from the SUSE packagers > (about how dropping support for Qt 5.9 LTS the very month Qt 5.12 LTS comes > out is a problem since not everyone can upgrade to Qt 5.12 LTS right away) >

D22730: KZip::openArchive: Remove "bad" assert

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY There's nothing the caller of this function can do to control the assert condition, so asserting is "too rude", and on

D22729: KZip::openArchive: Return false instead of asserting in broken files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22729 To: aacid, apol Cc: kde-frameworks-devel, dfaure, apol, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22729: KZip::openArchive: Return false instead of asserting in broken files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY We can easily return false, so do that instead of asserting REPOSITORY R243 KArchive BRANCH master REVISION DETAIL

D22689: Replace QString::null with QString

aacid abandoned this revision. aacid added a comment. Fixed it manually, marking it as abandoned since i can't close any other way. Sorry, should have tested this a bit more, yesterday it was late :/ REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22689 To:

D22689: Replace QString::null with QString

aacid closed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22689 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22689: Replace QString::null with QString

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D22689 AFFECTED FILES cmake/kf5i18nuic.cmake

D19005: android: don't default to gcc anymore

aacid closed this revision. aacid added a comment. Talked with Aleix, we're deciding to drop this for the moment REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19005 To: apol, #frameworks, vkrause Cc: aacid, kde-frameworks-devel, kde-buildsystem,

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

aacid added a comment. @jtamate Does that "let's continue in that other review" mean we should cancel this one? Still shows on the list of reviews to consider REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10742 To: jtamate, #frameworks, dfaure Cc: aacid,

D19903: Fix build with msvc

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. yep, having it build with gcc is important :) REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19903 To: vonreth, mlaurent, davidedmundson,

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

aacid closed this revision. REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks, dfaure Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

aacid added a comment. nxisss can we have your real name and email for commit this to the codebase? REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks, dfaure Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

Re: New framework: KCalCore

El dissabte, 20 de juliol de 2019, a les 12:14:09 CEST, David Faure va escriure: > Hi everyone, > > I just discussed this with Volker IRL and I found a solution to address my > initial concern with the name, the fact that a developer (who's new to all > this) seeing "Cal" might not understand

Re: kdewebkit tarball gone missing?!

El dijous, 18 de juliol de 2019, a les 0:15:16 CEST, René J. V. Bertin va escriure: > Albert Astals Cid wrote: > > > https://download.kde.org/stable/frameworks/5.60/portingAids/ > > Ah, thanks, I must have missed the announcement of its promotion. > > So what kind of

D21002: Remove kde4 migration agent completely

aacid added a comment. It seems you broke the build https://build.kde.org/job/Frameworks/job/kwallet/ is all read REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid Cc: aacid, lbeltrame,

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

aacid added a comment. Ok, you will need to update your @since when landing this REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks-devel, LeGast00n,

D21002: Remove kde4 migration agent completely

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. i guess 路 REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid Cc: aacid, lbeltrame,

D22488: invoke QIcon::setFallbackThemeName a bit later

aacid added a comment. I don't think this is going to work. Who is going to create a KIconTheme when running Okular on gnome shell? From what i can see we do create one in okular/part.cpp:386 because we happen to call KParts::Part::iconLoader() there, but that's too late, there has

<    1   2   3   4   5   6   7   8   9   10   >