firewall-applet icons break breeze auto tests

Hi Noah, At the moment breeze-icons auto tests are failing with this error (both for icons and icons-dark) The following icons are not available in a scalable directory: firewall-applet-shields_up firewall-applet-panic firewall-applet firewall-applet-error This is because the test

Frameworks minimum Qt version raised to 5.9

I just executed the policy that says last three Qt versions, i.e. 5.9, 5.10 and 5.11 Cheers, Albert

D16949: Support for TLS 1.3 (part of Qt 5.12)

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16949 AFFECTED FILES src/core/ktcpsocket.cpp

Re: Regression in Frameworks - DBus Hangs

El diumenge, 11 de novembre de 2018, a les 11:29:51 CET, Albert Astals Cid va escriure: > El diumenge, 11 de novembre de 2018, a les 6:51:39 CET, Ben Cooksley va > escriure: > > On Thu, Nov 8, 2018 at 8:15 PM Ben Cooksley wrote: > > > > > > On Sat, Nov 3, 2018

Re: Regression in Frameworks - DBus Hangs

El diumenge, 11 de novembre de 2018, a les 6:51:39 CET, Ben Cooksley va escriure: > On Thu, Nov 8, 2018 at 8:15 PM Ben Cooksley wrote: > > > > On Sat, Nov 3, 2018 at 4:41 PM Ben Cooksley wrote: > > > > > > Hi all, > > > > > > Following commits made to Frameworks somewhere in the October 21 to >

D16562: Reuse resultMap instead of converting to map two times more

aacid closed this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D16562 To: aacid, apol Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D16575: Remove unused variables

aacid closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16575 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16561: Remove unused variable

aacid closed this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D16561 To: aacid, svuorela Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D16567: Remove unused variable

aacid closed this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16567 To: aacid, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16568: Remove unused variables

aacid closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16568 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16569: Remove unused variable

aacid closed this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D16569 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16571: Remove unused variable

aacid closed this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16571 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16572: don't assign variable to itself

This revision was automatically updated to reflect the committed changes. Closed by commit R278:09b4523248ab: dont assign variable to itself (authored by aacid). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16572?vs=44595=44735 REVISION DETAIL

D16573: Remove unused variables

This revision was automatically updated to reflect the committed changes. Closed by commit R263:4a7c3dbdaf25: Remove unused variables (authored by aacid). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16573?vs=44596=44734 REVISION DETAIL

D16574: Remove unused variable

aacid closed this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D16574 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16565: Remove unused variable

This revision was automatically updated to reflect the committed changes. Closed by commit R237:d5c5113e8ea1: Remove unused variable (authored by aacid). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16565?vs=44588=44733 REVISION DETAIL

D16563: Actually use fileNameTerms and xAttrTerms

aacid closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16563 To: aacid, #baloo, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16563: Actually use fileNameTerms and xAttrTerms

aacid updated this revision to Diff 44618. aacid retitled this revision from "Remove unused variables" to "Actually use fileNameTerms and xAttrTerms". aacid added a comment. update summary REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16563?vs=44617=44618

D16563: Actually use fileNameTerms and xAttrTerms

aacid edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16563 To: aacid, #baloo, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16563: Remove unused variables

aacid updated this revision to Diff 44617. aacid added a comment. actually use the variables REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16563?vs=44586=44617 BRANCH arcpatch-D16563 REVISION DETAIL https://phabricator.kde.org/D16563 AFFECTED FILES

D16570: Remove unused variables

aacid closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16570 To: aacid, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, sars, dhaumann

D16575: Remove unused variables

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D16575 AFFECTED FILES

D16574: Remove unused variable

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D16574 AFFECTED FILES

D16573: Remove unused variables

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D16573 AFFECTED FILES

D16572: don't assign variable to itself

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D16572 AFFECTED FILES

D16571: Remove unused variable

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D16571 AFFECTED FILES

D16570: Remove unused variables

aacid created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aacid requested review of this revision. REVISION SUMMARY commentLineMark is commented since the code that uses it is also commented a bit below REPOSITORY

D16569: Remove unused variable

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D16569 AFFECTED FILES src/core/engine.cpp To:

D16568: Remove unused variables

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16568 AFFECTED FILES src/core/job_error.cpp

D16567: Remove unused variable

aacid created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D16567 AFFECTED FILES

D16565: Remove unused variable

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D16565 AFFECTED FILES

D16563: Remove unused variables

aacid created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY As far as i can see the declaration of the variables and calling get "does nothing", so we can remove them

D16562: Reuse resultMap instead of converting to map two times more

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D16562 AFFECTED FILES

D16561: Remove unused variable

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D16561 AFFECTED FILES

D16344: Do not try to fallback to "less secure" protocols

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e11d4d18f66a: Do not try to fallback to less secure protocols (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16344?vs=43997=44509#toc REPOSITORY R241 KIO CHANGES SINCE

D16500: Wait for docbookl10nhelper to be built before building our own manpages

This revision was automatically updated to reflect the committed changes. Closed by commit R238:002940d2e0c3: Wait for docbookl10nhelper to be built before building our own manpages (authored by aacid). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE

D16500: Wait for docbookl10nhelper to be built before building our own manpages

aacid created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY BUGS: 398263 REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL

D16464: [KSambaShare] Trim trailing / from share path

aacid added a comment. In case you didn't see it, you broke compilation with Qt 5.9 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16464 To: bruns, #frameworks, broulik Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D16344: Do not try to fallback to "less secure" protocols

aacid added a comment. In D16344#348985 , @stikonas wrote: > Can you confirm that it works with TLSv1.2 only sites? (e.g. https://stikonas.eu:5281/admin/). Ideally we should test with TLSv1.3 too. Yes, it works. And

D16344: Do not try to fallback to "less secure" protocols

aacid added a comment. In D16344#348886 , @jtamate wrote: > What protocol does KTcpSocket::SecureProtocols implement (I can't guess it)? If it is the same as QSsl:SecureProtocols Yes, see

D16344: Do not try to fallback to "less secure" protocols

aacid added a comment. I'll commit this next tuesday unless someone disagrees. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16344 To: aacid Cc: carewolf, dfaure, stikonas, kde-frameworks-devel, michaelh, ngraham, bruns

D16344: Do not try to fallback to "less secure" protocols

aacid added subscribers: stikonas, dfaure, carewolf. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16344 To: aacid Cc: carewolf, dfaure, stikonas, kde-frameworks-devel, michaelh, ngraham, bruns

D16344: Do not try to fallback to "less secure" protocols

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Both Firefox and Chrom[e|ium] do this for a while so most sites have already make sure they are better compliant than

D16137: Add an option to KConfigDialog to fit page contents horizontally

aacid added a comment. Yep, this looks more like it :) You're missing @since markers (in the documentation of the new functions) for the KF5 version this will be introduced, but i'd say let's wait for someone to give the final approval and then you remember to commit the correct version

D16137: Add an option to KConfigDialog to fit page contents horizontally

aacid added a comment. That's almost good, but the flag name should be more general, think like for example you would remove the manage bool and convert it to a flag too, so that if it the future someone needs to add a new flag, they can add it to that enum and don't need a new parameter.

Re: Password field security and information leaking

El diumenge, 14 d’octubre de 2018, a les 11:19:17 CEST, Ivan Čukić va escriure: > Hi all, > > > We are using QLineEdit (and QML equivalent) all over KDE for passwords. This > is an issue for types of attacks that extract raw process memory because the > passwords can be leaked. > > QLineEdit

D16137: Add an option to KConfigDialog to fit page contents horizontally

aacid added a comment. In D16137#341984 , @kadabash wrote: > I have to admit, I don't know how to implement a version with flags correctly. Look at kcmodule.h for example you'll see some flags defined there, then there's a setButtons

D16137: Add an option to KConfigDialog to fit page contents horizontally

aacid added a comment. Adding new parameters is unfortunately Binary Incompatible so this can't go in this way, for it to work you'd need to add a new function with all the parameters and then call one from the other. Maybe what we need is one that takes two bools we should have one

Re: kiowidgets_kdirmodeltest fail

El dimecres, 10 d’octubre de 2018, a les 23:09:49 CEST, David Faure va escriure: > On mercredi 10 octobre 2018 22:11:12 CEST Albert Astals Cid wrote: > > El dimecres, 10 d’octubre de 2018, a les 16:33:43 CEST, Jaime va escriure: > > > Hello, > > > > > > Abou

Re: kiowidgets_kdirmodeltest fail

El dimecres, 10 d’octubre de 2018, a les 16:33:43 CEST, Jaime va escriure: > Hello, > > About > https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/429/testReport/junit/(root)/TestSuite/kiowidgets_kdirmodeltest/ > > I'm only able to reproduce the crash 1/7 times I run ctest

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

aacid added a comment. In D14631#331827 , @emateli wrote: > @aacid Would be great if you'd point me towards making them installable. Only the dialog itself should be exported. install(FILES ${KIOWidgets_HEADERS}

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

aacid added a comment. I'm not a KWindowSystem developer so take this with a grain of salt, but maybe it makes sense to still support the old name in case someone is really using it and add the new one as a synonym? REPOSITORY R278 KWindowSystem REVISION DETAIL

D14529: Android: Make sure Qm translations get loaded

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. ok then i guess :) REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D14529 To: apol, #frameworks, aacid Cc: svuorela, aacid,

Re: KDE apps have missing icons when not on Breeze

> Dominik > > > Albert Astals Cid schrieb am Di., 28. Aug. 2018, 22:45: > > > El dijous, 16 d’agost de 2018, a les 15:19:36 CEST, Albert Astals Cid va > > escriure: > > > Missatge de Albert Vaca del dia dj., 16 d’ag. > > 2018 a > > > les 13:57: > &g

D15155: [KMountPoint] Fix typo in probablySlow()

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15155 To: broulik, dfaure, dhaumann, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: KDE apps have missing icons when not on Breeze

29, 2018, 19:29 Albert Astals Cid wrote: > > > El dimecres, 29 d’agost de 2018, a les 12:56:53 CEST, Aleix Pol va > > escriure: > > > On Tue, Aug 28, 2018 at 10:45 PM Albert Astals Cid > > wrote: > > > > > > > > El dijous, 16 d’agost de 2018

Re: KDE apps have missing icons when not on Breeze

El dimecres, 29 d’agost de 2018, a les 12:56:53 CEST, Aleix Pol va escriure: > On Tue, Aug 28, 2018 at 10:45 PM Albert Astals Cid wrote: > > > > El dijous, 16 d’agost de 2018, a les 15:19:36 CEST, Albert Astals Cid va > > escriure: > > > Missatge de Albert Va

D14674: handle non-ASCII encodings of file names in tar archives

aacid added a comment. @ibragimovrinat Actually can you please send me that tarball file to aa...@kde.org ? I don't seem to be able to recreate that from the diff file you attached. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure,

D14674: handle non-ASCII encodings of file names in tar archives

aacid added a comment. @ibragimovrinat ah my fault, arc didn't create the tar.gz file correctly from the diff REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure, kossebau Cc: aacid, xyquadrat, broulik, cfeck, ibragimovrinat,

D14674: handle non-ASCII encodings of file names in tar archives

aacid added a comment. @ibragimovrinat KArchiveTest::testTarShortNonASCIINames is failing both in CI [1] and for me locally 23:54:20 FAIL! : KArchiveTest::testTarShortNonASCIINames() Compared values are not the same 23:54:20Actual (listing.count()): 0 23:54:20Expected (1)

D14674: handle non-ASCII encodings of file names in tar archives

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure, kossebau Cc: xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, ngraham, bruns

Re: KDE apps have missing icons when not on Breeze

El dijous, 16 d’agost de 2018, a les 15:19:36 CEST, Albert Astals Cid va escriure: > Missatge de Albert Vaca del dia dj., 16 d’ag. 2018 a > les 13:57: > > > Hi everyone, > > > > If we want to reach more potential users, we have to make sure KDE > > apps loo

D14983: Set breeze as fallback icon theme

aacid closed this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D14983 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D14922: Assert if trying to use a KCatalog without a QCoreApplication

aacid closed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14922 To: aacid, dfaure Cc: dfaure, ltoscano, ilic, kde-frameworks-devel, michaelh, ngraham, bruns

D14940: kformattest: Use plural suffix (s) consequently

aacid added a comment. In D14940#315172 , @habacker wrote: > https://forum.wordreference.com/threads/decimals-plural-singular.2054431/#post-10279600 listed many public organisations that are using signular for values between 1 and -1.

D14940: kformattest: Use plural suffix (s) consequently

aacid added a comment. In D14940#313853 , @habacker wrote: > I see - Qt lacks support for choosing the correct translation string for floating point values like this: > > qreal value = 1.0; >tr("%n second(s)", nullptr, value). >

D14940: kformattest: Use plural suffix (s) consequently

aacid added a comment. In D14940#313136 , @habacker wrote: > According to the section'Handling of plurals' on http://doc.qt.io/qt-5/i18n-source-translation.html, for plurals an '(s)' is used instead of the 's' as suffx. You are refering to a

D14983: Set breeze as fallback icon theme

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. TEST PLAN Ran okular with QT_QPA_PLATFORMTHEME=gtk3 with and without this patch. With icons show up everywhere and looks generally nicer

D14966: Added support for disabling the loading of translations

aacid added a comment. I personally don't think this is the way to go and as said many times think that loading a custom translation for tests like ki18n way does is the way to go. Your issue with that seems to be that it won't work on windows, well then i'd say skip the test on

D14967: Disable loading of translations for kformattest, which was not designed with translations

aacid added a comment. I personally don't think this is the way to go and as said many times think that loading a custom translation for tests like ki18n way does is the way to go. Your issue with that seems to be that it won't work on windows, well then i'd say skip the test on

D14940: kformattest: Use plural suffix (s) consequently

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. This is not how plurals for decimals work, they are always in plural. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14940 To: habacker, aacid Cc:

D14955: Move example from techbase to own repo

aacid added a comment. In D14955#312287 , @ochurlaud wrote: > In D14955#312279 , @aacid wrote: > > > -1 > > > > The example is not getting compiled it will rot > > > I'm not sure to

D14955: Move example from techbase to own repo

aacid added a comment. -1 The example is not getting compiled it will rot REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

aacid added a comment. Can you please replace your setLocale call in initTestCase for void initLocale() { setenv("LC_ALL", "en_US.utf-8", 1); } Q_CONSTRUCTOR_FUNCTION(initLocale) This should make it work (or at least it does here) REPOSITORY R244 KCoreAddons

D14922: Assert if trying to use a KCatalog without a QCoreApplication

aacid updated this revision to Diff 40005. aacid added a comment. Use Q_ASSERT_X REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14922?vs=39980=40005 BRANCH arcpatch-D14922 REVISION DETAIL https://phabricator.kde.org/D14922 AFFECTED FILES

D14922: Assert if trying to use a KCatalog without a QCoreApplication

aacid added subscribers: ilic, ltoscano. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14922 To: aacid Cc: ltoscano, ilic, kde-frameworks-devel, michaelh, ngraham, bruns

D14922: Assert if trying to use a KCatalog without a QCoreApplication

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY QCoreApplication init calls setlocale(LC_ALL, ""); that is crucial for gettext to work, so assert if the user

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

aacid added a comment. In D14779#309943 , @habacker wrote: > With the drawback that the qm file need to be generated on each build and the po file needs to be updated on any translations change in the test app > > BTW: I tried your approach

Re: KDE apps have missing icons when not on Breeze

Missatge de Albert Vaca del dia dj., 16 d’ag. 2018 a les 13:57: > Hi everyone, > > If we want to reach more potential users, we have to make sure KDE > apps look properly in every desktop. Take a look at how KDE apps look > in Gnome, you will see there are lots of missing icons. > >

D11649: Fix crash in the file slave

aacid planned changes to this revision. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11649 To: aacid, #frameworks, dfaure Cc: kde-frameworks-devel, #kde_connect, michaelh, ngraham, bruns

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

aacid added a comment. In D14779#309643 , @habacker wrote: > In D14779#308603 , @aacid wrote: > > > I think that in the test we just need to call > > > > bool

D8964: Fix two bugs in KMessageWidget

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R236:e3368be660e3: Fix two bugs in KMessageWidget (authored by aacid). CHANGED PRIOR TO COMMIT

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

aacid added a comment. In D14779#308593 , @habacker wrote: > You have remembered that in this case the loader created by ecm_create_qm_loader(kcoreaddons_QM_LOADER kcoreaddons5_qt) must be adjusted to find this - not installed - fake

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

aacid added a comment. Personally i would include (and use) a fake translation as part of the tests and then it would just evaluate to the actual result, i.e. QCOMPARE(format.formatSpelloutDuration(361), QStringLiteral("1 hour(s)")); would end up being

D14778: Disable loading of translations when using 'C' locale

aacid added a comment. Honestly i think that test in kformattest is wrong and that it should contain it's own small minitranslation so that stuff works fine and then it should be QCOMPARE(format.formatDecimalDuration(10), QStringLiteral("10 milliseconds")); instead of

D14778: Disable loading of translations when using 'C' locale

aacid added a comment. Doesn't setting the locale to en solve the same problem without needing to change ECM? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14778 To: habacker, #frameworks, apol Cc: aacid, kde-frameworks-devel, kde-buildsystem,

D14723: Add option to disable KWallet entirely in the new wallet dialog

aacid added a comment. Isn't this actually bad for the privacy goal? AFAIK some apps will just write the password in cleartext in a config file when kwallet is not present. INLINE COMMENTS > knewwalletdialog.h:67 > protected Q_SLOTS: > -void onBlowfishToggled(bool); > +void

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

aacid added a comment. As far as i can see none of these headers get installed so should they all be renamed to _p.h ? Also if the headers don't get installed how do you use the new classes? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli,

D14502: Reuse function that already does the same

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D14502 To: apol, #frameworks, ilic, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14528: Android: Make sure we're looking for .mo files in the right path

aacid added a comment. As I am arguing in the other review, let's install the files in a nicer place? We control were we install them, no? REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D14528 To: apol, #frameworks, ilic, ckertesz Cc: aacid,

D14529: Android: Make sure Qm translations get loaded

aacid added a comment. Ok, second option, we are actually installing these files ourselves, right? Can we install them somewhere "nicer"? like maybe QStandardPaths::StandardLocation(DataLocation) + optionally "/share" ? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D14529: Android: Make sure Qm translations get loaded

aacid added a comment. Is there a way we can get /../qt-reserved-files/share/ in a more natural way? fishing up to .. feels always like it'll break REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14529 To: apol, #frameworks Cc: aacid,

D14503: Android: also fall-back to using QLocale

aacid added a comment. Aleix means https://phabricator.kde.org/D14508 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14503 To: apol, #frameworks, ilic, aacid, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14524: Fix compiler warning -Wimplicit-fallthrough

aacid added a comment. Maybe it makes more sense to replace it with the magic words? // fall-through REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14524 To: dhaumann, vkrause Cc: aacid, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew,

D14473: Fix KCatalog::translate when translation is same as original text

This revision was automatically updated to reflect the committed changes. Closed by commit R249:34a22e5ee5d4: Fix KCatalog::translate when translation is same as original text (authored by aacid). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

Re: gettext makes supporting multiple languages translations in ki18n impossible

El diumenge, 29 de juliol de 2018, a les 22:26:56 CEST, Albert Astals Cid va escriure: > El diumenge, 29 de juliol de 2018, a les 21:45:27 CEST, Karl Ove Hufthammer > va escriure: > > Albert Astals Cid skreiv 29. juli 2018 19:31: > > > Ideally one would be able to query

D14473: Fix KCatalog::translate when translation is same as original text

aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY We need to be compare the pointer passed to gettext with the one we get back. If it

Re: gettext makes supporting multiple languages translations in ki18n impossible

El diumenge, 29 de juliol de 2018, a les 21:45:27 CEST, Karl Ove Hufthammer va escriure: > Albert Astals Cid skreiv 29. juli 2018 19:31: > > Ideally one would be able to query gettext about whether the translation > > exists or not (basically having an option to return nullp

gettext makes supporting multiple languages translations in ki18n impossible

I have just realized that gettext has no way of differentiating a translation that is the same of the original over a translation that doesn't exist. That is, char *gettext (const char *__msgid) Will return "foo" for the message "foo" in both cases, when the translation of "foo" to the

D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Does this really make a difference? Also... fix qt to get QStringList::containst(QStringRef)? REPOSITORY R235 Attica BRANCH master REVISION DETAIL

<    3   4   5   6   7   8   9   10   11   12   >