Re: Review Request 126555: Remove unused variable in KConfigPrivate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126555/#review90274 --- Ship it! Ship It! - Albert Astals Cid On des. 29, 2015, 5

Re: Jenkins-kde-ci: ki18n master kf5-qt5 » Linux, gcc - Build # 25 - Still Unstable!

El Monday 23 November 2015, a les 18:49:29, Aleix Pol va escriure: > On Mon, Nov 23, 2015 at 4:38 PM, wrote: > > GENERAL INFO > > > > BUILD UNSTABLE > > Build URL: > > https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compile > > r=gcc/25/ Project:

Re: Review Request 128116: KStandardAction::showStatusbar: fix copy/paste error

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128116/#review96256 --- Ship it! Ship It! - Albert Astals Cid On June 7, 2016

Re: The return of ASAN issues

El dimarts, 31 de maig de 2016, a les 18:49:29 CEST, Ben Cooksley va escriure: > On Tue, May 31, 2016 at 9:36 AM, Albert Astals Cid <aa...@kde.org> wrote: > > El dilluns, 30 de maig de 2016, a les 19:42:38 CEST, Ben Cooksley va escriure: > >> Hi all, > >> >

KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

Having KMessageBox "dontShowMeAgain" feature depend on an integration plugin is a very bad idea. Basically it means programs that use KMessageBox can never asusme it will work so basically they have to use alternative methods to have the "dontShowMeAgain" feature or not have it at all. I

Review Request 128018: Add donate menu item to help menu of our apps

--- Counterpart of https://git.reviewboard.kde.org/r/128017/ for kparts. Diffs - src/mainwindow.cpp 7e2ad9c Diff: https://git.reviewboard.kde.org/r/128018/diff/ Testing --- Works Thanks, Albert Astals Cid ___ Kde-frameworks-devel

Review Request 128019: Remove F1 as standard shortcut for Help

--- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128017: Add donate menu item to help menu of our apps

://i.imgur.com/iAuLId4.png (well for that you need the other review i will use since it's kparts, i tried kiriki (regular kxmlgui) and spectacle (manual khelpmenu) and it works fine) Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 128102: Set encoding on kconfig_compiler generated cpp and headers to utf-8 ( reproducible )

version of the kconfig_compiler? - Albert Astals Cid On jun. 12, 2016, 1:19 a.m., Scarlett Clark wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128017: Add donate menu item to help menu of our apps

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 5ff477302d816d341f1a38009f74ac4ebb3214dd by Albert Astals Cid to branch master. Repository: kxmlgui Description --- Our apps is defined as use our bugzilla for bug reporting. Diffs

Re: Review Request 128018: Add donate menu item to help menu of our apps

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit e6139e4d12fbd70863682eab18a6e0b08f901207 by Albert Astals Cid to branch master. Repository: kparts Description --- Counterpart of https://git.reviewboard.kde.org/r/128017/ for kparts. Diffs

Re: kio/kcookiejar visibility

El dissabte, 28 de maig de 2016, a les 0:33:05 CEST, René J.V. Bertin va escriure: > Hi, > > The kcookiejar kded service contains some code to make sure the posted > window ("Cookie Alert") is actually seen by the user. This uses window Ids > and KWindowSystem::setMainWindow(), and thus doesn't

Re: Review Request 128034: KateHighlightManger::defaultStyleCount() off by one

> On May 28, 2016, 12:35 p.m., Kai Uwe Broulik wrote: > > Afaik you can add enum values as long as you don't cause the other's values > > to change or cause the compiler to choose a larger underlying type to fit > > the enum in. > > Dominik Haumann wrote: > Yes, afaik that is correct. >

Re: Review Request 128035: KTextEditor: Fix foreground color of replaced text

for such an obvious typo case as this. - Albert Astals Cid On May 28, 2016, 1:18 p.m., Dominik Haumann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128039: Fix the window type of the progress widget

But as far as i see it KWidgetJobTracker is public API so it's not hard to imagine it being used somewhere where it actually has a parent. what do you think? - Albert Astals Cid On May 29, 2016, 12:23 a.m., Martin Tobias Holme

Re: Review Request 128019: Remove F1 as standard shortcut for Help

- Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/#review95809 --- On May 25, 2016, 11:01 p.m., Albert Astals

Re: Review Request 128019: Remove F1 as standard shortcut for Help

to launch it, you can go an enable it. - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/#review95818 ----------- On

Re: Review Request 128019: Remove F1 as standard shortcut for Help

/kstandardshortcut.cpp 6be6309 Diff: https://git.reviewboard.kde.org/r/128019/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128019: Remove F1 as standard shortcut for Help

nstead). Once there is a consensus, then I'm > > happy to have those changes implemented. > > > > Since there is a global way to disable F1 for people who find this annoying > > now, this is a -2 from me. People annoyed at F1 can fix their issue now > > without cod

Re: Review Request 128019: Remove F1 as standard shortcut for Help

Ctrl+X? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/#review95797 --- On May 25, 2016, 11:01 p.m., Albe

Re: Review Request 128019: Remove F1 as standard shortcut for Help

-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/#review95848 ----------- On May 25, 2016, 11:01 p.m., Albert Astals Cid wrote: > > --

Re: Review Request 128039: Fix the window type of the progress widget

you a Ship It in a week i guess you can take it as a Ship it. - Albert Astals Cid On May 29, 2016, 6:04 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > This is an automatically generated e-mail. To reply, visit

[Differential] [Commented On] D1861: Fix name of QDialogButtonBox's enumerator "StandardButtons"

aacid added a comment. Is it me or phabricator doesn't say for which repo this patch is for? REVISION DETAIL https://phabricator.kde.org/D1861 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: aspotashev, #frameworks Cc: aacid

Re: KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

El dimarts, 14 de juny de 2016, a les 10:57:19 CEST, David Faure va escriure: > On mardi 14 juin 2016 01:00:09 CEST Albert Astals Cid wrote: > > El dilluns, 13 de juny de 2016, a les 11:27:53 CEST, David Faure va > > escriure: > > > On dimanche 12 juin 2016 22:58:34 CEST

Re: Review Request 128207: Move implementation of class MetaFunction methods into a separate .cpp file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128207/#review96612 --- Ship it! Ship It! - Albert Astals Cid On June 16, 2016

Re: Review Request 128215: Do not use C-style casts into void*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128215/#review96614 --- Ship it! Ship It! - Albert Astals Cid On June 16, 2016

Re: Review Request 128103: Add license texts for KAboutLicense ; add LGPL v2.1 as separate license.

Astals Cid On June 4, 2016, 10:19 p.m., Michael Pyne wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128103: Add license texts for KAboutLicense ; add LGPL v2.1 as separate license.

> On June 19, 2016, 10:37 p.m., Albert Astals Cid wrote: > > See https://git.reviewboard.kde.org/r/114979/ > > Albert Astals Cid wrote: > At least i agree with the "not eating such a common install path". > > Maybe we need to either convice dis

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

-> deleteLater, how does that fix a leak? - Albert Astals Cid On June 10, 2016, 5:07 a.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.k

Re: Review Request 128205: Fix crash when a method exposed to Kross returns QVariant with non-relocatable data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128205/#review96687 --- Ship it! Ship It! - Albert Astals Cid On June 16, 2016

Re: Review Request 127031: Add function to get runtime frameworks version information

n a world of mix & match this may b different frm KXMLGUI::version() (if it existed) Or am i overthinking this? - Albert Astals Cid On Feb. 10, 2016, 5:10 p.m., David Edmundson wrote: > > --- > This is an automatical

Re: KMenu aboutToShowContextMenu KF5 porting options: None. Do we care?

El Monday 01 February 2016, a les 08:39:22, David Faure va escriure: > On Monday 01 February 2016 00:43:27 Albert Astals Cid wrote: > > In the kdelibs4 world one could connect to KMenu aboutToShowContextMenu > > signal to add more entries to the submenu that appears when rig

Re: Review Request 126948: Simplify attica plugin look-up and initialization

idea when there's libraries that do that for you. - Albert Astals Cid On Feb. 1, 2016, 7:37 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

KMenu aboutToShowContextMenu KF5 porting options: None. Do we care?

In the kdelibs4 world one could connect to KMenu aboutToShowContextMenu signal to add more entries to the submenu that appears when right clicking on a menu entry. Nowadays KMenu is gone in apps that do not use kdelibs4support so we can't use that. We still have a default menu that appears

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

> On feb. 22, 2016, 9:55 a.m., Albert Astals Cid wrote: > > I'd prefer if you could fix this at the Qt level, why would > > nativeLanguageName ever return empty? > > Andre Heinecke wrote: > I've just checked. It's a Windows thing. qlocale_win calls wind

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

> On Feb. 22, 2016, 9:55 a.m., Albert Astals Cid wrote: > > I'd prefer if you could fix this at the Qt level, why would > > nativeLanguageName ever return empty? > > Andre Heinecke wrote: > I've just checked. It's a Windows thing. qlocale_win calls wind

Re: QString -> QStringLiteral conversions might make applications crash on exit

El Friday 26 February 2016, a les 01:37:57, Frank Reininghaus va escriure: > Hi everyone, > > sorry if most of you know about this already, but since it seems that > QStringLiterals are being introduced everywhere right now, I think > that it is important to raise awareness about the fact that

Re: CMake Error when building attica

Works here, cc'ing the build-system and frameworks lists in case someone gets an idea of what may be wrong from the log. Cheers, Albert El Monday 29 February 2016, a les 22:26:49, Nilesh Kokane va escriure: > Hello, > > While building attica-5.19.0 cmake threw the following error. > > -- >

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

atically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125682/ > --- > > (Updated oct. 22, 2015, 12:31 a.m.) > > > Review request for KDE Frameworks, Localization and Translation (l10n) and > Albert

Re: KActivities repository split

El Tuesday 16 February 2016, a les 13:31:40, Ivan Čukić va escriure: > Hi everyone, > > As previously announced, KActivities has been split into a few > separate repositories. This mail is mostly intended to notify our dear > packagers of the change, and the plan for the transition period. > >

Re: Review Request 127091: Fix IconItem regression in 5.19

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127091/#review92470 --- Is this testable at all? - Albert Astals Cid On Feb. 16

Re: KActivities repository split

El Thursday 18 February 2016, a les 12:30:59, Ivan Čukić va escriure: > Hi Albert, > > What schedule kio-extras have? kio-extras gets released with KDE Applications. Cheers, Albert > > Cheerio, > Ivan > > p.s. I'm thinking more and more that kactivities-workspace repository > might be a

Re: Review Request 127093: Drop KDocTools requirement

? Do you even get a hint saying you must install kdoctools to get documetnation or it silently skips it? - Albert Astals Cid On Feb. 18, 2016, 10:34 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generat

Re: Review Request 125536: Remove unused variable warnings

and git log it Diffs - src/k7zip.cpp 64c6b52 src/ktar.cpp 49a6791 Diff: https://git.reviewboard.kde.org/r/125536/diff/ Testing --- clang compiles without warnings Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

nativeLanguageName ever return empty? - Albert Astals Cid On Feb. 22, 2016, 9:52 a.m., Andre Heinecke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Raising Qt requirement to Qt 5.4

El dimecres, 16 de març de 2016, a les 13:13:36 CET, Martin Graesslin va escriure: > Hi all, > > with todays release of Qt 5.6 I suggest that we raise the minimum Qt version > requirement to 5.4. This would mean the latest three releases are > supported. > > The important new features in Qt 5.4

Re: Review Request 127632: Prioritize correct extension per theme

> On April 11, 2016, 10:44 p.m., Albert Astals Cid wrote: > > I'm unconvinced, actually the spec mentions order to be "Changed search > > order to png, svg, xpm" https://specifications.freedesktop.org/icon-theme-spec/icon-theme-sp

Re: Review Request 127632: Prioritize correct extension per theme

to be "Changed search order to png, svg, xpm" - Albert Astals Cid On April 10, 2016, 11:05 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 127398: Add unit tests for KNotification and fix a whole bunch of issues uncovered thanks to them

> On March 18, 2016, 5:20 a.m., Anthony Fieroni wrote: > > src/knotification.cpp, line 63 > > > > > > ref can't be UINT_MAX, but id can, no? Negative rage will brake all, > > it's this possible, maybe not.

Re: Review Request 127398: Add unit tests for KNotification and fix a whole bunch of issues uncovered thanks to them

l, > > it's this possible, maybe not. Counters it's not good idea to be signed. > > Martin Klapetek wrote: > Yes...if your application will emit more than 32767 notifications in its > lifetime. At which point the application is probalby broken. > > Albert Astals Cid wr

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

s an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127501/#review94042 --- On March 26, 2016, 5:29 p.m., Albert Astals Cid wrote: > > ---

Re: Raising Qt requirement to Qt 5.4

El diumenge, 20 de març de 2016, a les 10:12:14 CET, David Faure va escriure: > On Friday 18 March 2016 20:16:05 Ivan Čukić wrote: > > Hi all, > > > > IIRC, the last time we talked about this we decided (I'll try to find > > the e-mail thread when I get back home, IIRC the conclusion was by > >

Review Request 127501: Improve TCPSlaveBase::isConnected

/ Testing --- Seesms to work fine and the pop3 bugfix i have also works fine. Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt5 version of qimageblitz

El Sunday 06 March 2016, a les 08:38:14, Boudhayan Gupta va escriure: > On 6 March 2016 at 01:26, Martin Koller wrote: > > Who is in charge of the old SVN repos ? > > Who is in charge of qimageblitz ? > > I asked around on IRC and it seems QIB is "community maintained" and > as

Re: Qt5 version of qimageblitz

El Tuesday 08 March 2016, a les 17:55:30, Ben Cooksley va escriure: > On Tue, Mar 8, 2016 at 8:11 AM, Martin Koller wrote: > > On Sunday 06 March 2016 08:38:14 Boudhayan Gupta wrote: > >> On 6 March 2016 at 01:26, Martin Koller wrote: > >> > Who is in charge of the

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

code). > > UnknownSocketError *means* error, it doesn't mean no error. > > > > It seems to me (from the description, I didn't read the code attentively) > > that the right solution is to actually disconnect after a > > RemoteHostClosedError. Then the state won't be Conn

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

- src/core/tcpslavebase.cpp b9be69d Diff: https://git.reviewboard.kde.org/r/127501/diff/ Testing --- Seesms to work fine and the pop3 bugfix i have also works fine. Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

code). > > UnknownSocketError *means* error, it doesn't mean no error. > > > > It seems to me (from the description, I didn't read the code attentively) > > that the right solution is to actually disconnect after a > > RemoteHostClosedError. Then the state won't be Conn

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

code). > > UnknownSocketError *means* error, it doesn't mean no error. > > > > It seems to me (from the description, I didn't read the code attentively) > > that the right solution is to actually disconnect after a > > RemoteHostClosedError. Then the state won't be Conn

[Differential] [Accepted] D1465: KFileItem: remove separate storage of times, use UDSEntry instead.

aacid accepted this revision. aacid added a reviewer: aacid. aacid added a comment. This revision is now accepted and ready to land. Looks good :) BRANCH master REVISION DETAIL https://phabricator.kde.org/D1465 EMAIL PREFERENCES

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

El dilluns, 25 d’abril de 2016, a les 19:14:00 CEST, Ben Cooksley va escriure: > On Mon, Apr 25, 2016 at 5:59 PM, Martin Graesslin wrote: > > On Saturday, April 23, 2016 8:48:17 PM CEST Ben Cooksley wrote: > >> On Sat, Apr 23, 2016 at 8:35 PM, Martin Graesslin

Re: Review Request 127632: Prioritize correct extension per theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/#review94881 --- Ship it! Ship It! - Albert Astals Cid On April 26

Re: Review Request 127770: Increase maximum string length in KSycoca database

> On April 27, 2016, 8:36 p.m., David Faure wrote: > > src/sycoca/ksycocautils.cpp, line 39 > > > > > > Variable-length arrays are invalid C++. > > > > gcc might accept it, but -pedantic won't, and other

Re: Review Request 127765: RFC: Cache global config files

on runtime? I.e. do we want to get the updated values? - Albert Astals Cid On April 27, 2016, 4:14 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Review Request 127777: Make KTipDialog use the domain of the application when translating the tips

- src/ktipdialog.cpp e6a70af Diff: https://git.reviewboard.kde.org/r/12/diff/ Testing --- kig tips now show translated. Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

El dilluns, 25 d’abril de 2016, a les 9:05:58 CEST, Ben Cooksley va escriure: > On Sun, Apr 24, 2016 at 11:46 AM, Michael Pyne wrote: > > On Sat, April 23, 2016 13:09:00 Ben Cooksley wrote: > >> On Sat, Apr 23, 2016 at 1:04 PM, Daniel Vrátil wrote: > >> > any

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

I object. a) I already told you, don't use something nobody else uses, use the separate reposb) Not going to happen, but why would it matter at all? More reasons for it: c) ASAN does not check for things in the library being broken or not since it only works on code compiled with ASAN, so the

[Differential] [Updated, 2 lines] D1489: Disable new_delete_type_mismatch temporarily

aacid updated this revision to Diff 3511. aacid added a comment. fix syntax REPOSITORY rCONFBUILD build.kde.org jenkins build configuration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1489?vs=3510=3511 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1489

[Differential] [Updated] D1489: Disable new_delete_type_mismatch temporarily

aacid added reviewers: graesslin, bcooksley, scarlettclark. aacid added a subscriber: Frameworks. aacid added a project: build.kde.org. REPOSITORY rCONFBUILD build.kde.org jenkins build configuration REVISION DETAIL https://phabricator.kde.org/D1489 EMAIL PREFERENCES

Re: Review Request 127655: Fix KAboutData::applicationData() to sync to current Q*Application metadata

> On April 29, 2016, 3:15 a.m., Michael Pyne wrote: > > I think I disagree with the idea of overwriting KAboutData properties if > > they are already set by the user. Alex, any thoughts? > > > > In the event the KAboutData doesn't already exist I think automatically > > setting it up makes

Re: Review Request 127788: Fix leak in KNS::Engine

) <https://git.reviewboard.kde.org/r/127788/#comment64498> I'd add a delete m_atticaProviderManager; prior to this line just in case. - Albert Astals Cid On April 29, 2016, 12:45 p.m., Aleix Pol Gonzalez

Review Request 127784: Add a small note to the documentation on how tips are i18n'ed

: kconfigwidgets Description --- See Summary. Diffs - src/ktipdialog.h b18ef96 Diff: https://git.reviewboard.kde.org/r/127784/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 127777: Make KTipDialog use the domain of the application when translating the tips

marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Changes --- Submitted with commit 2ffec51692eae1dad4db816dc462a23a11d0d169 by Albert Astals Cid to branch master. Repository: kconfigwidgets Description --- Makes no sense to use ::tr() here, we need

Re: Review Request 127763: Reduce memory usage footprint

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/#review94997 --- Ship it! Ship It! - Albert Astals Cid On April 28

Re: Review Request 127784: Add a small note to the documentation on how tips are i18n'ed

marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Changes --- Submitted with commit 778e3fdd9597e50b3a4ebe7740224b6711a7b71a by Albert Astals Cid to branch master. Repository: kconfigwidgets Description --- See Summary. Diffs - src/ktipdialog.h

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

g/r/127747/#comment64416> This is already in line 3, doesn't seem like a good idea to duplicate the information. - Albert Astals Cid On April 25, 2016, 9:49 p.m., Olivier Churlaud wrote: > > --- > This is an automatica

Re: Review Request 127973: Fix race in which the file containing the X11 cookie has the wrong permissions

it too - Albert Astals Cid On May 19, 2016, 11:38 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: kptyprocesstest is still flaky

El diumenge, 22 de maig de 2016, a les 15:59:59 CEST, David Faure va escriure: > The CI for KF5 is now all green except for kpty which is still flaky. > > https://build.kde.org/view/Frameworks%20kf5-qt5/job/kpty%20master%20stable-k >

Re: Review Request 127973: Fix race in which the file containing the X11 cookie has the wrong permissions

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 72f3702dbe6cf15c06dc13da2c99c864e9022a58 by Albert Astals Cid to branch master. Repository: kinit Description --- if someone is very fast can watch the file between the open

Re: Review Request 127817: Don't make KIconThemes depend on Oxygen

> On May 17, 2016, 12:29 p.m., Wolfgang Bauer wrote: > > Sorry for coming late, I'm not subscribed to the list (and I'm not a > > maintainer either), just noticed the commit. > > > > I have nothing against the patch per se, and it apparently won't cause the > > wrong fallback to breeze either

Re: Review Request 127929: K4TimeZoneWidget: flag images not displayed because of incorrect path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127929/#review95505 --- Ship it! Ship It! - Albert Astals Cid On May 15, 2016

Re: Review Request 127865: Check size of unix domain socket path before copying to it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127865/#review95506 --- Ship it! Ship It! - Albert Astals Cid On May 8, 2016

Re: Review Request 127817: Don't make KIconThemes depend on Oxygen

for 5.22 to be out) and we'll see if it makes people unhappy :D - Albert Astals Cid On May 2, 2016, 11:09 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Find out whether a file is a remote file or not

El diumenge, 1 de maig de 2016, a les 19:12:11 CEST, Dominik Haumann va escriure: > On Sun, May 1, 2016 at 6:28 PM, Dominik Haumann wrote: > > Hi all, > > > > do we have a mechanism in KDE to find out whether a file is a truly > > local file, or a remote file? > > > > With

Re: Review Request 127808: Minor speedup of KMountPoint::probablySlow()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127808/#review95061 --- Ship it! Ship It! - Albert Astals Cid On May 1, 2016

Re: Review Request 127655: Fix KAboutData::applicationData() to sync to current Q*Application metadata

de that rely on KAboutData not > > changing values. > > > > Would this partial solution be OK for the problem you're running into? > > Albert Astals Cid wrote: > > I think I disagree with the idea of overwriting KAboutData properties > if they are already set

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

tps://git.reviewboard.kde.org/r/127833/#comment64597> See REVIEW: 126681 (commit 901c27ca7cb05cca1a960747b280d40cd7707158) it seems this fixes things. So not a good idea reverting it, probably a different fix needed. - Albert Astals Cid On May 4, 2016, 11:03 p.m., Michael Pyne

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

ed April 25, 2016, 9:49 p.m.) > > > Review request for KDE Frameworks, Albert Astals Cid, Alex Merry, Aurélien > Gâteau, and Allen Winter. > > > Repository: kapidox > > > Description > --- > > Keep in mind that it should not plainly replace kgenframewo

Re: Review Request 127817: Don't make KIconThemes depend on Oxygen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127817/#review95188 --- +1 would i'd like someone else opinion. - Albert Astals Cid

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

) <https://git.reviewboard.kde.org/r/127655/#comment64592> 5.4 is now the minimum supported version of KDE Frameowkrs 5 - Albert Astals Cid On May 4, 2016, 9:41 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is a

Re: Review Request 127813: Process paths just once

> On May 2, 2016, 8:21 p.m., Albert Astals Cid wrote: > > src/core/kconfiggroup.cpp, line 442 > > <https://git.reviewboard.kde.org/r/127813/diff/1/?file=462322#file462322line442> > > > > Are we sure we want this to be static? > > Aleix Pol Gonzalez w

Re: Review Request 127632: Prioritize correct extension per theme

> On April 11, 2016, 10:44 p.m., Albert Astals Cid wrote: > > I'm unconvinced, actually the spec mentions order to be "Changed search > > order to png, svg, xpm" > > Albert Astals Cid wrote: > > https://specifications.freedesktop.org/icon-theme-spec/i

Re: Review Request 127632: Prioritize correct extension per theme

tps://git.reviewboard.kde.org/r/127632/#comment64430> @since missing src/kicontheme.cpp (line 407) <https://git.reviewboard.kde.org/r/127632/#comment64431> constBegin + constEnd + const_iterator (or auto?) - Albert Astals Cid On April 26, 2016, 7:12 p.m., Aleix Pol Go

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

g/r/12/#comment65990> To be honest i don't really see the point of this function. What's the benefit of writing unitAsString() vs unit().symbol() ? - Albert Astals Cid On July 29, 2016, 8:54 a.m., Garret Wassermann

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

g/r/12/#comment66024> You should add @since KF 5.26 markers to all the new enums in this file. Explanation: If noone disagrees with this before, i'll commit it for KF 5.26 just after KF 5.25 is released (since it has lots of new strings to give time to translators). - Albert

Re: Low quality input country flags

El diumenge, 31 de juliol de 2016, a les 17:13:07 CEST, Viorel-Cătălin Răpițeanu va escriure: > Hi all, > > I've got a question related to the flags used to display the input layout > in plasma. > To explain, the flags used for the input sources either don't have the > correct aspect ratio,

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

g/r/128595/#comment66050> @since missing - Albert Astals Cid On Aug. 3, 2016, 7:45 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Where to put kwayland integration plugins

El dissabte, 2 de juliol de 2016, a les 15:25:39 CEST, Martin Graesslin va escriure: > On Saturday, July 2, 2016 11:41:11 AM CEST David Faure wrote: > > On lundi 6 juin 2016 11:26:58 CEST Aleix Pol wrote: > > > On Mon, Jun 6, 2016 at 8:32 AM, Martin Graesslin > > wrote: > >

Re: KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

El dissabte, 2 de juliol de 2016, a les 12:23:31 CEST, David Faure va escriure: > On mercredi 15 juin 2016 00:33:40 CEST Albert Astals Cid wrote: > > El dimarts, 14 de juny de 2016, a les 10:57:19 CEST, David Faure va > > escriure: > > > On mardi 14 juin 2016 01:00:0

Re: Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

96cdb7 Diff: https://git.reviewboard.kde.org/r/128581/diff/ Testing --- Tried rsibreak without the framework integration plugin, worked. Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/

<    2   3   4   5   6   7   8   9   10   11   >