D21327: Support installing multiple Samba packages

apol added a comment. Hope this helps ^^' INLINE COMMENTS > sambausershareplugin.cpp:155 > SIGNAL(package(PackageKit::Transaction::Info,QString,QString)), > > SLOT(packageInstall(PackageKit::Transaction::Info,QString,QString))); > This is a bit weird now, because

D21314: Don't enable QT_STRICT_ITERATORS on Windows.

apol added a comment. +1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21314 To: dfaure, vkrause, dvratil Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21300: KIO: port away from QSslSocket+QFileInfo deprecated API

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH 2019_deprecated_API REVISION DETAIL https://phabricator.kde.org/D21300 To: dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21280: kioslave: preserve argv[0], to fix applicationDirPath() on non-Linux

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LTGM REPOSITORY R241 KIO BRANCH 2019_freebsd_fixed REVISION DETAIL https://phabricator.kde.org/D21280 To: dfaure, sitter, davidedmundson, apol, adridg Cc: kde-frameworks-devel, michaelh

D21232: KAr::openArchive: Fix invalid memory access on broken files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D21232 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21204: Ensure no trailing slash in mountpoint read from fstab file.

apol added inline comments. INLINE COMMENTS > fstabhandling.cpp:169 > +// strips last slash > +if (mountpoint.at(mountpoint.length() -1) == '/') { > +mountpoint = mountpoint.left(mountpoint.length() - 2); mountpoint.endsWith(QLatin1Char('/')) > fstabhandl

D21201: FrameSvgItem: emit maskChanged also from geometryChanged()

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH emitmaskchangedalsoonsizechange REVISION DETAIL https://phabricator.kde.org/D21201 To: kossebau, #plasma, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21200: FrameSvg: prevent crash when calling mask() with no frame yet created

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH donotcrashformask REVISION DETAIL https://phabricator.kde.org/D21200 To: kossebau, #plasma, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

apol added inline comments. INLINE COMMENTS > kossebau wrote in framesvg.cpp:150 > But given the return, if the else needed? Actually some people recommend to > not use else after return. I might be Monday blind, sorry :) I guess it doesn't matter. :) REPOSITORY R242 Plasma Framework (Librar

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

apol added a comment. +1 LGTM REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21174 To: kossebau, #plasma Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

apol added inline comments. INLINE COMMENTS > kossebau wrote in framesvg.cpp:150 > How would you use the `else`? Not yet with you what you mean here, if (prefix.endsWith(QLatin1Char('-'))) { return hasElement(prefix % QLatin1String("center")); } else return hasElement(prefix % QLat

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

apol added inline comments. INLINE COMMENTS > framesvg.cpp:150 > +return hasElement(prefix % QLatin1String("center")); > +} > + else? or we want to test --center if -center fails? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21174 To:

D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'

apol added inline comments. INLINE COMMENTS > framesvg.h:230 > /** > - * Returns the prefix for SVG elements of the FrameSvg > + * Returns the prefix for SVG elements of the FrameSvg (including the > appended '-' if not empty) > * @return the prefix "appended" reads weird. H

D21169: Add app icon for the Kirogi Drone control app

apol added a comment. Let's add it when the application exists? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21169 To: trickyricky26, hein, #vdg Cc: apol, kde-frameworks-devel, hein, michaelh, ngraham, bruns

D18222: Don't hardcode dbus policy install dir

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18222 To: arojas, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21149: KAr::openArchive: Protect against Heap-buffer-overflow in broken files

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Q_ISUNLIKELY? I have no idea if it's a hot path, probably not, yet it could make sense as a way to say this is crazy-town error detection. REPOSITORY R243 KArchive BRANCH master REVI

D21146: KProcessInfoList -- add proclist backend for FreeBSD

apol added inline comments. INLINE COMMENTS > kprocesslist_unix.cpp:59 > > +KProcessInfoList unixProcessListKinfoProcStat() > +{ doesn't that also need `#if HAVE_PROCSTAT`? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21146 To: tcberner, #freebsd, adridg, dav

D21133: Fix KAr::openArchive with older Qt

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D21133 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21119: [JobDialog] Also signal cancellation when window is closed by the user

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D21119 To: broulik, #plasma, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21107: Replace qVariantFromValue with QVariant::fromValue

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Maybe it could make sense to have a clazy fixit for it? REPOSITORY R237 KConfig BRANCH variant REVISION DETAIL https://phabricator.kde.org/D21107 To: nicolasfella, #frameworks, dfaure,

D21109: Fix KAr

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D21109 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21108: Fix build error in uploaddialog.ui

apol accepted this revision. apol added a comment. wird How was this ever generated? :| REPOSITORY R304 KNewStuff BRANCH enum REVISION DETAIL https://phabricator.kde.org/D21108 To: nicolasfella, dhaumann, gregormi, #frameworks, ngraham, apol Cc: apol, kde-frameworks-dev

D21106: FrameSvg: l & r borders or t & b don't need to have same height resp. width

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixassumptionsvgframeborderelementsareequal REVISION DETAIL https://phabricator.kde.org/D21106 To: kossebau, #plasma, apol Cc: kde-frameworks-devel, michaelh, ng

D20844: KTar::KTarPrivate::readLonglink: Fix crash in malformed files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH arcpatch-D20844 REVISION DETAIL https://phabricator.kde.org/D20844 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21028: add multiple gestures and a handler class to KWidgetsAddons

apol added a comment. It could make sense to run clazy on these, I'm pretty sure we'd find interesting stuff. INLINE COMMENTS > koneandtwofingerswipe.h:36 > +{ > +//Q_PROPERTY(bool left READ left WRITE left) > +//Q_PROPERTY(bool right READ right WRITE right) Why is this commented ou

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

apol added a comment. Looks good to me, have you checked that it's now not breaking what @broulik found? REVISION DETAIL https://phabricator.kde.org/D19420 To: croick, broulik, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

apol added a comment. +1 looks good to me besides the nitpick. INLINE COMMENTS > kfilewidget.cpp:594 > // the Filter label/edit > -whatsThisText = i18n("This is the filter to apply to the file list. " > - "File names that do not match the filter will not > be

D21001: Update *.qmltypes to current API of QML modules

apol added a comment. Looks like we were exporting the qmltypes for QtQuick Controls within the calendar file? LGTM overall, but an additional set of eyes would be useful. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21001 To: kossebau, #p

D20999: IconItem: remove remaining & unused smooth property bits

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH removelastsmoothbits REVISION DETAIL https://phabricator.kde.org/D20999 To: kossebau, #plasma, davidedmundson, apol Cc: kde-frameworks-devel, michaelh, ngraham,

D21000: PlatformComponentsPlugin: fix plugin iid to QQmlExtensionInterface

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixiid REVISION DETAIL https://phabricator.kde.org/D21000 To: kossebau, #plasma, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

apol added inline comments. INLINE COMMENTS > ngraham wrote in kfilewidget.cpp:745 > I did it in `setMimeFilter` since that's where it's determined whether or not > there's a limited assortment of mimetypes, which is what controls what the > string should be. Conditionalizing it based on mode s

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

apol added a comment. wouldn't it be almost as complex to `file(WRITE ... qmldir)`? Most of the code is to construct the file. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20984 To: kossebau, #plasma Cc: apol, kde-frameworks-devel, kde-buildsystem, be

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

apol added inline comments. INLINE COMMENTS > kfilewidget.cpp:745 > + > +if (d->operationMode == Saving) { > +d->filterLabel->setText(i18n("&File type:")); Isn't it a bit weird to do this in setMimeFilter? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20964

D20961: [KJS] Allow calling function from KJObject by adding a call function to its api

apol added a comment. What are you using KJs for that needs such changes? INLINE COMMENTS > kjsobject.cpp:225 > + > +KJS::List args = List(); > +foreach(KJSObject arg, arguments) Just `KJS::List args;` > kjsobject.h:149 > + */ > + KJSObject call(KJSContext *ctx, const QList

D20940: [baloo_file] Wait for extractor process to start

apol added inline comments. INLINE COMMENTS > extractorprocess.cpp:47 > m_extractorProcess.start(); > +m_extractorProcess.waitForStarted(); > } Maybe this should be called in ::index then? This way we only block where it breaks. REPOSITORY R293 Baloo REVISION DETAIL https://phab

D20907: Disable broken and no longer needed workaround code with msvc2019

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R314 KJs BRANCH master REVISION DETAIL https://phabricator.kde.org/D20907 To: vonreth, dfaure, arichardson, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20752: Add missing properties in kpackage-generic.desktop

apol accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D20752 To: dfaure, mart, apol, sitter Cc: #frameworks

D20748: Fix wrong "Unable to find service type" warnings

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20748 To: dfaure, mart, arichardson, davidedmundson, mpyne, apol Cc: aacid, kde-frameworks

D19850: Make AppStream generation opt-in

apol abandoned this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D19850 To: apol, #plasma, ngraham Cc: sitter, ngraham, kde-frameworks-devel, michaelh, bruns

D20839: AppStream generation: make sure we look up for the package structure on packages that have metadata.desktop/json too

This revision was automatically updated to reflect the committed changes. Closed by commit R290:bf261881f6fe: AppStream generation: make sure we look up for the package structure on… (authored by apol). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20839?vs=

D20844: KTar::KTarPrivate::readLonglink: Fix crash in malformed files

apol added inline comments. INLINE COMMENTS > ktar.cpp:289 > case 'L': > -name = QFile::decodeName(longlink.constData()); > +name = QFile::decodeName(longlink); > break; Doesn't QString have the same size limitation as

D20839: AppStream generation: make sure we look up for the package structure on packages that have metadata.desktop/json too

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. TEST PLAN Generated the appstream for plasmoids in kdeplasma addons and they properly extend its X-KDE-ParentAp

D20838: Allow to drop one file or one folder on KDirOperator

apol added inline comments. INLINE COMMENTS > kdiroperator.cpp:418 > setFocusPolicy(Qt::WheelFocus); > +setAcceptDrops(true); > } This default change should be documented. > kdiroperator.cpp:1401 > +} else { > +QUrl url = urls.at(0); > + .constFirst() mayb

D20833: Simpler check for flatpak

apol updated this revision to Diff 57023. apol added a comment. No need for inSandbox to be a class member REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20833?vs=56999&id=57023 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20833

D20833: Simpler check for flatpak

apol added a comment. We still use it to check whether to initialise `portalDBusServiceExists`. I'll simplify it a bit. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20833 To: apol, #frameworks Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20833: Simpler check for flatpak

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY I saw it being checked like that, I think it reads a bit cleaner. REPOSITORY R289 KNotif

D20758: kpackagetool: read kpackage-generic.desktop from qrc

apol accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D20758 To: dfaure, sitter, apol Cc: #frameworks

D20749: autotests: don't fail appstream test because of anything on stderr

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D20749 To: dfaure, sitter, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20702: KTar: Protect against negative longlink sizes

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20702 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: New framework: KCalCore

On Wed, Apr 17, 2019 at 6:40 PM Volker Krause wrote: > > On Sunday, 14 April 2019 13:31:41 CEST David Faure wrote: > > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote: > > > Hi, > > > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > > > KCalCore is an i

D20643: Fix invalid memory write on malformed tar files

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > aacid wrote in ktar.cpp:241 > You mean also printing std::numeric_limits::max() ? I meant in a comment, but yeah, it's on the warning already. REPOSITORY R243 KArchive

D20644: Fix memory leak when reading some tar files

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > karchive.cpp:602 > Q_ASSERT(!d->rootDir); // Call setRootDir only once during parsing > please ;) > +delete d->rootDir; // but if it happens, try not to le

D20641: Fix uninitialized memory use when reading malformed tar files

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Should maybe warn if it fails? REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20641 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraha

D20643: Fix invalid memory write on malformed tar files

apol added a comment. +1 in general INLINE COMMENTS > ktar.cpp:241 > size--;// ignore trailing null > +if (size > std::numeric_limits::max()) { > +qCWarning(KArchiveLog) << "Failed to allocate memory for longlink of > size" << size; It could make sense to say that it's

D20639: Remove TODO

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. I don't think you understood the TODO. Also this change breaks ABI, since const it's part of it. The TODO talks about adding a startTimer method and deprecating timer (which it alre

D20558: Bug fix: find c++ stl using regex

apol added a comment. In D20558#451898 , @sh-zam wrote: > In my case if I do this: `include (Android.cmake)`, then it won't be able to find the `ECMAndroidDeployQt.cmake` because I am using android-ndk's toolchain. And why do you have to

D20558: Bug fix: find c++ stl using regex

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D20558 REVISION DETAIL https://phabricator.kde.org/D20558 To: sh-zam, apol Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20558: Bug fix: find c++ stl using regex

apol added a comment. In D20558#450229 , @sh-zam wrote: > > Why are you using it without Android.cmake? > > I am building Krita and to add `create-apk` target I am using `include (ECMAndroidDeployQt.cmake)`, I can't use `Android.cmake` becaus

D20616: KeySequenceHelperPrivate::updateShortcutDisplay: Don't show english text to the user

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. We shouldn't indeed. Maybe it's a candidate to get in KGuiAddons REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D20616 To: aacid, apol Cc: apol,

D20614: KKeySequenceWidget: Don't show English strings to the user

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D20614 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20613: Document that modToStringUser and stringUserToMod only deal with english strings

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D20613 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20604: Fix stack-buffer-overflow read on malformed files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20604 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20605: Fix null-dereference on malformed tar files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20605 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20092: New class KOSRelease - a parser for os-release files

apol accepted this revision. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol, mpyne Cc: davidedmundson, pino, aacid, mpyne, kde-frameworks-devel, michaelh, ngraham, bruns

Re: New framework: KCalCore

On Mon, Apr 15, 2019 at 2:52 PM David Jarvie wrote: > > > > On 15 April 2019 13:25:56 BST, Allen Winter wrote: > > On Monday, April 15, 2019 6:40:06 AM EDT Daniel Vrátil wrote: > > > On Sunday, 14 April 2019 20:17:54 CEST David Faure wrote: > > > > On dimanche 14 avril 2019 19:46:02 CEST David Ja

D20558: Bug fix: find c++ stl using regex

apol added a comment. In D20558#450198 , @sh-zam wrote: > Can we add a `cmake_minimum_required` to `3.7`? Regex fails to compile on older versions, when run outside of `Android.cmake`. Sure, add it. Why are you using it without Android.

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good to me, can you land it? REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D20509 To: sh-zam, apol, vkrause Cc: kde-buildsystem, kd

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ECMAndroidDeployQt.cmake:41 > if (NOT VALUE STREQUAL "") > -string(FIND "${VALUE}" ".so\"" OUT) > -math(EXPR OUT "${OUT}+4") > -

D20493: Introduce and use KArchiveDirectory::addEntryV2

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH arcpatch-D20493 REVISION DETAIL https://phabricator.kde.org/D20493 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20484: Mark archive and directory as const

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. The patch is fine, I wonder how you ended up deciding this was a change to be done. :P REPOSITORY R301 KEmoticons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20484 To: a

D20464: [knotifyconfig] make it compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R305 KNotifyConfig BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D20464 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, brun

D19445: Handle variant list in formatting functions

apol added a comment. Patch looks good to me, @bruns note that you still have it set as "changes required". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhniko

D20443: Move to runtime the decision to use x11 or not

apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Instead of deciding at build time which backend to use, see which is used upon construction. This will make it possible to

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

apol updated this revision to Diff 55913. apol added a comment. Include keystates client side REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20191?vs=55247&id=55913 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20191 AFFECTED FILES sr

D20422: KZip: fix Heap-use-after-free in broken files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20422 To: aacid, apol Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D19908: [ConfigModule] Pass initial properties

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19908 To: broulik, #plasma, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19445: Handle variant list in formatting functions

apol added inline comments. INLINE COMMENTS > propertyinfo.cpp:650 > +for (const auto& entry : valueList) { > +displayList << (d->formatAsString)(entry); > +} `displayList << d->formatAsString(entry);` REPOSITORY R286 KFileMetaData REVI

D20042: Show the plasmoid context menu on long tap

apol added a comment. In D20042#446770 , @ngraham wrote: > That seems... quite sub-optimal to me. > > Is all of this to preserve press-and-hold for moving widgets? Is there a centralized place for this discussion? If not I can create a Phab t

Re: New framework: KContacts

On Sat, Apr 6, 2019 at 6:02 PM Volker Krause wrote: > > Hi, > > I'd like to propose KContacts for review to move from KDE PIM to KF5. > > KContacts is essentially an implementation of the vCard standard, covering the > data model as well as parsing and creating of vCard files. As the recent CI > i

D20042: Show the plasmoid context menu on long tap

apol abandoned this revision. apol added a comment. We discussed it and decided long tap is not the way to go, will have to find alternative ways to access the options on the context menu on a case-by-case basis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabric

D20376: [ktextwidget] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D20376 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20284: Fix l/100 km to MPG conversion

apol added inline comments. INLINE COMMENTS > fuel_efficiency.cpp:36 > +const KLocalizedString &realString, const > KLocalizedString &integerString, > +const bool isReciprocal = false) > : UnitPrivate(categoryId, id, multiplier, I'm not sure I un

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

apol added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20261 To: kossebau, #plasma, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20260: Fix crash in KArchive::findOrCreate with broken files

apol added a comment. Looks good, would it be possible to get a test case? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20260 To: aacid Cc: apol, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20230: Allow building without UDev on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit R245:124760e1a383: Allow building without UDev on Linux (authored by apol). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20230?vs=55353&id=55448 REVISION DETAIL https

D20244: [AppletInterface] Check for corona before accessing it

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20244 To: broulik, #plasma, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20230: Allow building without UDev on Linux

apol added a comment. I don't really remember the reason why we can't use udev there, it was more of a "it can be there but it will be useless", then there was a very long discussion with "what if I..." and people saying that udev needed redesigning. It was few years ago. At the moment if

D20230: Allow building without UDev on Linux

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Flatpak has been patching this for a while, there doesn't seem to be a way to use it ther

D20219: Propose Stefan Bruns as KFileMetaData maintainer

This revision was automatically updated to reflect the committed changes. Closed by commit R286:79db0d55b933: Propose Stefan Bruns as KFileMetaData maintainer (authored by apol). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20219?vs=55323&id=55342 REV

D20225: use more appropriate plasma-specific icon for plasma category

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D20225 To: sitter, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20219: Propose Stefan Bruns as KFileMetaData maintainer

apol created this revision. apol added a reviewer: Frameworks. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY He has been doing most of the work lately and seems very active, I'd say he is

D20031: Declare PropertyInfo as QMetaType

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R286 KFileMetaData BRANCH submit REVISION DETAIL https://phabricator.kde.org/D20031 To: bruns, #baloo, #frameworks, ngraham, astippich, apol Cc: apol, kde-frameworks-dev

D20032: Convert string formatting tests to be data driven

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Whatever. @bruns Have you considered becoming the module maintainer? :) REPOSITORY R286 KFileMetaData BRANCH submit REVISION DETAIL https://phabricator.kde.org/D20032 To: bruns, #balo

D20216: Export path of kwalletd binary for kwallet_pam

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D20216 To: davidedmundson, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

apol retitled this revision from "Depends on D20191" to "Expose locked keystates on KModifierKeyInfo when on wayland". apol edited the summary of this revision. apol added a dependency: D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work. REPOSITORY R273 KGu

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

apol added a dependent revision: D20193: Expose locked keystates on KModifierKeyInfo when on wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20191 To: apol, #kwin Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D20193: Depends on D20191

apol updated this revision to Diff 55250. apol added a comment. description REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20193?vs=55249&id=55250 BRANCH wayland_keystate REVISION DETAIL https://phabricator.kde.org/D20193 AFFECTED FILES src/CMak

D20193: Depends on D20191

apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REPOSITORY R273 KGuiAddons BRANCH wayland_keystate REVISION DETAIL https://phabricator.kde.org/D20193 AFFECTED FILES src/CMakeLists.tx

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

apol added a dependent revision: D20192: Implement the keystate protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20191 To: apol, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

apol created this revision. apol added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. TEST PLAN Tested with both the lock screen and the keyboard indicator plasmoid REPOSITORY R127 KWayland BRANCH

<    5   6   7   8   9   10   11   12   13   14   >