Re: Review Request 127205: Add stubs to allow compilation on Android.

wd* getpwent(void); int setpwent(void); #endif /* MISSING */ ``` So it might make sense. - Aleix Pol Gonzalez On Feb. 28, 2016, 11:14 a.m., Andreas Cord-Landwehr wrote: > > --- > This is an automatically gener

Review Request 127232: Make breeze the default icon theme name for KIconThemes

. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127090: Clean KWalletQuery cmake file

e7a55 - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127090/#review92774 --- On Feb. 25, 2016, 1:34 a.m., Aleix Pol

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

> On Feb. 24, 2016, 8:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific

Re: Review Request 126740: Add a script for optimizing svgs

(master)$ du -sh icons icons-dark/ 17M icons 17M icons-dark/ ``` Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126740: Add a script for optimizing svgs

/ #run the script kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ 17M icons 17M icons-dark/ ``` Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 126738: Remove external dependencies from svgs

> On Jan. 14, 2016, 5:51 a.m., Dirk Hohndel wrote: > > this will need to be done for dozens more SVGs - I sent the four that I > > needed for my app for review, but if this change gets accepted I'll > > volunteer to rewrite all of the SVGs that contain external references. It > > just seemed

Re: Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

tps://git.reviewboard.kde.org/r/126818/#comment62455> Should this (maybe) be static? Or rather Q_GLOBAL_STATIC? Or we'll just have one of those backends anyway? - Aleix Pol Gonzalez On Jan. 20, 2016, 12:21 a.m., David Edmundson

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

it would make sense to abstract out the KGlobalAccel usage? Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) on Windows? - Aleix Pol Gonzalez On Jan. 26, 2016, 7:25 p.m., Andre Heinecke wrote

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

> On Jan. 26, 2016, 7:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel usef

Re: Review Request 126903: Fix buddy widgets working with KFontRequester

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126903/#review91664 --- +1 Smells like a bug in Qt? - Aleix Pol Gonzalez On Jan

Re: Review Request 127044: Show a warning if there's an error in the Engine

marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit 06089b0edb7c7d7e3f8566c8eb01e64d254a167f by Aleix Pol to branch master. Repository: knewstuff Description --- So that we can know what's going on if things don't go

Re: Review Request 127044: Show a warning if there's an error in the Engine

e UI. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127044/#review92325 --- On Feb. 15, 2016, 12:28 a.m., Aleix Pol

Re: Review Request 127024: Don't filter names if we have mimetypes

(updated) - src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb Diff: https://git.reviewboard.kde.org/r/127024/diff/ Testing --- Tested it while porting okular. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 127060: Potentially fix 347962

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 24d27b9cb733f727431c64e0a7845c39152c1104 by Aleix Pol to branch master. Bugs: 347962 https://bugs.kde.org/show_bug.cgi?id=347962 Repository: kdeclarative Description --- I couldn't

Re: Review Request 126740: Add a script for optimizing svgs

/ 17M icons 17M icons-dark/ ``` Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127088: Let KDocTools stay optional on KPackage

Description --- As most other frameworks do. Diffs - CMakeLists.txt cdd4a26 Diff: https://git.reviewboard.kde.org/r/127088/diff/ Testing --- Builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 127088: Let KDocTools stay optional on KPackage

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit c72f315c70e873ad444203b59c27a3f664b8c858 by Aleix Pol to branch master. Repository: kpackage Description --- As most other frameworks do. Diffs - CMakeLists.txt cdd4a26

Review Request 127090: Clean KWalletQuery cmake file

--- Built with and without KDocTools. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127094: Don't use up 16K of /dev/urandom to seed rand() in KRandom

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127094/#review92479 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 17

Re: Review Request 127100: Remove unused dependencies in kactivities

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127100/#review92503 --- +1 Good work! - Aleix Pol Gonzalez On Feb. 17, 2016, 3:20

Re: Review Request 127106: applications.menu: remove references to unused categories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127106/#review92515 --- +1 - Aleix Pol Gonzalez On Feb. 17, 2016, 11:43 p.m

Review Request 127110: Drop KF5DocTools dependency

Description --- Like in many other frameworks. Diffs - CMakeLists.txt 15ecead Diff: https://git.reviewboard.kde.org/r/127110/diff/ Testing --- Builds with and without KDocTools. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Review Request 127093: Drop KDocTools requirement

: kdesignerplugin Description --- Like in many other frameworks. Diffs - CMakeLists.txt bbec850 Diff: https://git.reviewboard.kde.org/r/127093/diff/ Testing --- Builds with and without kdoctools. Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 127031: Add function to get runtime frameworks version information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127031/#review92559 --- +1 - Aleix Pol Gonzalez On Feb. 19, 2016, 1:46 p.m

Re: Review Request 127117: Reverse the filtering logic

in the PersonsProxyModelTest? - Aleix Pol Gonzalez On Feb. 19, 2016, 9:22 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127060: Potentially fix 347962

- src/kdeclarative/qmlobject.cpp f3cee66 Diff: https://git.reviewboard.kde.org/r/127060/diff/ Testing --- Tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Review Request 127060: Potentially fix 347965

. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

) <https://git.reviewboard.kde.org/r/126876/#comment62992> Wouldn't it be a good practice to assume people are doing the right thing and not passing something that isn't a folder? Do other implementations make this check? I doubt it. - Aleix Pol Gonzalez On Feb. 14, 2016, 7:

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

) <https://git.reviewboard.kde.org/r/126876/#comment62993> We shouldn't be calling sync API there. - Aleix Pol Gonzalez On Feb. 14, 2016, 7:25 a.m., Kåre Särs wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 127031: Add function to get runtime frameworks version information

> On Feb. 10, 2016, 11:14 p.m., Albert Astals Cid wrote: > > src/lib/kcoreaddons.h, line 29 > > > > > > Documntation is missing > > > > Also "technically" one could mix and max versions even if we don't

Review Request 127044: Show a warning if there's an error in the Engine

/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

> On March 1, 2016, 5:37 p.m., Aleix Pol Gonzalez wrote: > > Eh... I just realized it's not 100% correct. We have a test > > (testUnknownIconNotCached) that fails, unsure how I didn't see it yesterday. > > > > The problem with this one is that we are not reacting whe

Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

- src/kicontheme.cpp 0996054 Diff: https://git.reviewboard.kde.org/r/127236/diff/ Testing --- Builds, tests still pass, applications start noticeably faster. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.o

Re: Review Request 127211: Properly use static QMaps

marked as submitted. Review request for Kate and KDE Frameworks. Changes --- Submitted with commit 58c0beb95b05a7963d4151a48c99691e10ff2bc5 by Aleix Pol to branch master. Repository: ktexteditor Description --- Only initialize them once. Since they're not const, use ::value rather

Review Request 127233: Skip looking up . and .. to find the translations for an application

, btw) Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127232: Make breeze the default icon theme name for KIconThemes

://git.reviewboard.kde.org/r/127232/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127205: Add stubs to allow compilation on Android.

. Let's see where this goes. :) - Aleix Pol Gonzalez On March 1, 2016, 10:38 p.m., Andreas Cord-Landwehr wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

the port times, anyway this isn't working today. +1 LOL that's a lot of EUR. http://i.imgur.com/WmcJcIp.png - Aleix Pol Gonzalez On March 2, 2016, 1:48 a.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generat

Review Request 127345: Make it possible for an applet to offer a test object

/plasmaquick/appletquickitem.cpp 9242e9e src/plasmaquick/private/appletquickitem_p.h 9c24734 Diff: https://git.reviewboard.kde.org/r/127345/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 127348: [KPeople] Set the contact uri as person uri in PersonData when no person exists

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127348/#review93427 --- Can you add a test case for the `PersonDataTests`? - Aleix

Re: Review Request 127345: Make it possible for an applet to offer a test object

) - src/plasma/private/packages.cpp a5ba81a src/plasmaquick/appletquickitem.h 4f25f5d src/plasmaquick/appletquickitem.cpp 9242e9e src/plasmaquick/private/appletquickitem_p.h 9c24734 Diff: https://git.reviewboard.kde.org/r/127345/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: Review Request 127345: Make it possible for an applet to offer a test object

ch in plasma-workspace. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93422 --- On March 11, 2016, 9:

Re: Review Request 127348: [KPeople] Set the contact uri as person uri in PersonData when no person exists

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127348/#review93506 --- Ship it! Thank you! - Aleix Pol Gonzalez On March 14

Re: Review Request 127380: More conservative approach to saving some disk accesses

--------- On March 15, 2016, 2:52 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127380/ >

Re: Review Request 127380: More conservative approach to saving some disk accesses

is is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127380/#review93538 --- On March 15, 2016, 2:52 a.m., Aleix Pol Gonzalez wrote: > > ---

Re: Review Request 127345: Make it possible for an applet to offer a test object

/appletquickitem.cpp 9242e9e src/plasmaquick/private/appletquickitem_p.h 9c24734 Diff: https://git.reviewboard.kde.org/r/127345/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

git.reviewboard.kde.org/r/127345/#review93455 ------- On March 12, 2016, 4 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 127409: Make sure we're not forcing the window to be created prematurely

being forced on gdb. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127405: Make sure PlasmaQuick export file is properly found

me, so I thought I was crazy. This should be the fix nevertheless (assuming include directories are being exported properly). Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailma

Re: Review Request 127405: Make sure PlasmaQuick export file is properly found

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 0e9976afb1c4442819c9ca2cea9d2c50f4a53b3c by Aleix Pol to branch master. Repository: plasma-framework Description --- Uses `"quotes"` rather than `` to include a neigb

Review Request 127380: More conservative approach to saving some disk accesses

/kicontheme.cpp 0996054 Diff: https://git.reviewboard.kde.org/r/127380/diff/ Testing --- Attempts to call `KIconThemeDir::iconPath` on the benchmark: 4318 after/5040 before= 17% less QFile::exists Thanks, Aleix Pol Gonzalez ___ Kde-frameworks

Re: Review Request 127522: kcodec: Simplify code (qCount -> std::count, homegrown isprint -> QChar::isPrint)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127522/#review94111 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 29

Re: Review Request 127488: Fix usage of std::isprint() function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127488/#review94109 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 27

Re: Review Request 127486: Fix uninitialized int array in UnicodeGroupProber

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127486/#review94108 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 25

Re: Review Request 127597: Fix generation of path to xcb plugin

out the relative > path, though. > > Aleix Pol Gonzalez wrote: > Yes, what Heiko suggests is better. _FULL_ part of the variable name indicates that it's always an absolute path. - Aleix --- This is an automatically gene

Re: Review Request 127597: Fix generation of path to xcb plugin

> On April 7, 2016, 2:17 p.m., Heiko Becker wrote: > > Wouldn't \{$KDE_INSTALL_FULL_PLUGINDIR\}/kf5/org.kde.k... be better suited > > to solve the relative/absolute PLUGINDIR issue? > > Martin Gräßlin wrote: > that generates a proper absolute path. I don't know about the relative > path,

Re: Review Request 126520: [OS X] try to [k]launch the requested application in the foreground [showcase]

tps://git.reviewboard.kde.org/r/126520/#comment64152> You shoudln't/can't have Q* classes outside of Qt. Also does this really need to be in klauncher.h? It's not even being exported. - Aleix Pol Gonzalez On April 6, 2016, 7:18 p.m., René J.V. Bertin

Re: Review Request 127597: Fix generation of path to xcb plugin

very elegant, though... - Aleix Pol Gonzalez On April 7, 2016, 9:55 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127603: [kunitconversion] Create relevant cache dir for libkunitconversion before trying to use it

tps://git.reviewboard.kde.org/r/127603/#comment64170> Move to initializer and make attributes const? - Aleix Pol Gonzalez On April 7, 2016, 5:58 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 127604: [kunitconversion] Simplify isConnected

tps://git.reviewboard.kde.org/r/127604/#comment64171> Indentation is off? - Aleix Pol Gonzalez On April 7, 2016, 5:58 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 127605: [kunitconversion] Fix blocking network file downloading

tps://git.reviewboard.kde.org/r/127605/#comment64173> Maybe it would make sense to use QNetworkManager to write the file as well? This way we can use the async API. src/currency.cpp (line 689) <https://git.reviewboard.kde.org/r/127605/#comment64172> unrelated? - Aleix Pol Gonzalez On April 7, 20

Re: Review Request 127414: Don't enable acl permissions widget if we don't own the file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127414/#review94417 --- Ship it! Makes sense. - Aleix Pol Gonzalez On March 17

Re: Review Request 121903: Clean up how we deal with debug input

rk after the changes, I'm unsure how to test, especially the startkde part. Should be quite straightforward though. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

marked as submitted. Review request for Extra Cmake Modules, KDE Frameworks and Albert Vaca Cintora. Changes --- Submitted with commit a2d184bb89eaee3dc5e5b12ff6dfd4297bfcd5fb by Aleix Pol to branch master. Repository: extra-cmake-modules Description --- Make Qt and ECM-based

Re: Review Request 127380: More conservative approach to saving some disk accesses

/ Testing --- Attempts to call `KIconThemeDir::iconPath` on the benchmark: 4318 after/5040 before= 17% less QFile::exists Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 127633: [kpeople] Add a check for PersonData being valid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127633/#review94512 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 11

Re: Review Request 127632: Prioritize correct extension per theme

mp; grep ENOENT | wc -l 2119 ``` Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127380: More conservative approach to saving some disk accesses

marked as submitted. Review request for KDE Frameworks, Antonio Larrosa Jimenez and Christoph Feck. Changes --- Submitted with commit da3afe6840bf4974bd8d022b86fb9778f2af8688 by Aleix Pol to branch master. Repository: kiconthemes Description --- My previous approach to KIconThemes

Re: Review Request 127380: More conservative approach to saving some disk accesses

marked as submitted. Review request for KDE Frameworks, Antonio Larrosa Jimenez and Christoph Feck. Changes --- Submitted with commit da3afe6840bf4974bd8d022b86fb9778f2af8688 by Aleix Pol to branch master. Repository: kiconthemes Description --- My previous approach to KIconThemes

Review Request 127632: Prioritize correct extension per theme

, since we're not caching all the icon names (which was specially bad as it was per-process). ``` $ strace kwrite |& grep ENOENT | wc -l 4699 $ strace kwrite |& grep ENOENT | wc -l 2119 ``` Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Re: Review Request 127632: Prioritize correct extension per theme

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/#review94547 --- On April 11, 2016, 1:05 a.m., Aleix Pol Gonzalez wrote: > > ---

Re: Review Request 127632: Prioritize correct extension per theme

-l 2119 ``` Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 309c64f5e90453c5253baf19e6c01759e8aa6f83 by Aleix Pol to branch master. Repository: plasma-framework Description --- In an attempt to make it possible for plasmoid to test

Re: Review Request 127380: More conservative approach to saving some disk accesses

t.reviewboard.kde.org/r/127380/#review93636 ------- On March 15, 2016, 2:52 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

? - Aleix Pol Gonzalez On March 17, 2016, 10:37 a.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127209: Fix some issues found by Coverity

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 9ae6d765b37135bbfe3a8b936e5a88b8a435e424 by Aleix Pol to branch master. Repository: kcoreaddons Description --- Mostly initializing values and using printf() correctly. Diffs - src

Re: Review Request 127469: Use QQuickWidget for QML KCMs

> On March 23, 2016, 1:07 p.m., Marco Martin wrote: > > In theory using QQuickWidget is the correct way, but... > > That widget is really not reliable, it has a structural (and probably > > unfixable at least on x11) problem in which anybody calling winId() > > anywhere on any window on the

Re: Review Request 127473: Add const variant to getter method

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 88c73542a89a1c5c4a7d4c2327047f97b3907b7f by Aleix Pol to branch master. Repository: attica Description --- Otherwise the icons cannot be fetched if the object is `const`. Diffs - src

Review Request 127473: Add const variant to getter method

--- Otherwise the icons cannot be fetched if the object is `const`. Diffs - src/content.h 455e903 src/content.cpp fd63444 Diff: https://git.reviewboard.kde.org/r/127473/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 127345: Make it possible for an applet to offer a test object

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 309c64f5e90453c5253baf19e6c01759e8aa6f83 by Aleix Pol to branch master. Repository: plasma-framework Description --- In an attempt to make it possible for plasmoid to test

Re: Review Request 127486: Fix uninitialized int array in UnicodeGroupProber

e 79) <https://git.reviewboard.kde.org/r/127486/#comment63992> This used to be `uint`. - Aleix Pol Gonzalez On March 24, 2016, 9:45 p.m., Dominik Haumann wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 127488: Fix usage of std::isprint() function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127488/#review93956 --- Could we get a test for this? - Aleix Pol Gonzalez

Re: Review Request 127271: Disable session restore for kwalletd5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/#review93147 --- +1 makes sense. - Aleix Pol Gonzalez On March 3, 2016, 9

Re: Review Request 127233: Skip looking up . and .. to find the translations for an application

marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Changes --- Submitted with commit be7e998af0ac032ec201fe88920d4e8b60062a82 by Aleix Pol to branch master. Repository: ki18n Description --- Make sure we're looking where we need to. Diffs - src

Re: Review Request 127233: Skip looking up . and .. to find the translations for an application

ge action needs to be set up. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127233/#review92971 --- On March 1, 2016, 3:01

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

visit: https://git.reviewboard.kde.org/r/127236/#review92976 --- On March 1, 2016, 4:25 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 127209: Fix some issues found by Coverity

/krandom.cpp bdbdec6 src/lib/util/kformatprivate.cpp 3d98007 Diff: https://git.reviewboard.kde.org/r/127209/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 127265: Fix windows build of Ki18n

tried and works here (on Linux+Clang). - Aleix Pol Gonzalez On March 3, 2016, 3:29 p.m., Andre Heinecke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.

Re: Review Request 127267: [KPeople] Set a name for the database connection

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127267/#review93105 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 3

Re: Review Request 127268: Docs for IconItem

tps://git.reviewboard.kde.org/r/127268/#comment63488> Needs to start with `/**` for doxygen to pick up. - Aleix Pol Gonzalez On March 3, 2016, 6:36 p.m., David Edmundson wrote: > > --- > This is an automatically generated e

Re: Review Request 127269: Add unit test for loading QPixmaps and QImages into IconItem

? - Aleix Pol Gonzalez On March 3, 2016, 7:28 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

? - Aleix Pol Gonzalez On March 1, 2016, 4:25 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127549: const

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127549/#review94220 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 2

Re: Review Request 127536: KNewPasswordWidget: fix QPalette when the widget is disabled

tps://git.reviewboard.kde.org/r/127536/#comment64077> `QVERIFY(linePassword && linePassword->isEnabled());` ? autotests/knewpasswordwidgettest.cpp (line 244) <https://git.reviewboard.kde.org/r/127536/#comment64079> I'm not sure this is testing what you want t

[Differential] [Accepted] D1489: Disable new_delete_type_mismatch temporarily

apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. Let's get this in until we can get a fixed Qt... REPOSITORY rCONFBUILD build.kde.org jenkins build configuration BRANCH master REVISION DETAIL

Re: Review Request 127632: Prioritize correct extension per theme

marked as submitted. Review request for KDE Frameworks, Andreas Kainz and Christoph Feck. Changes --- Submitted with commit 536d707981ada478b583f91f31a9dca741881a36 by Aleix Pol to branch master. Repository: kiconthemes Description --- Usually themes will have 1 kind of extension

Re: Review Request 127763: Reduce memory usage footprint

-9774-6ec86aa7f0c3__heaptrack.dolphin.16572-after.gz before https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/6229961c-bf00-4959-9fc1-9effa63b2b34__heaptrack.dolphin.16861-before.gz Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 2:01 p.m., Kai Uwe Broulik wrote: > > src/kiconloader.cpp, line 67 > > > > > > global statics in library are bad Or use Q_GLOBAL_STATIC - Aleix

<    13   14   15   16   17   18   19   20   21   22   >