Re: Review Request 115199: Fix detection of shared-mime-info on Windows

2014-01-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/#review47959 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Jan

Review Request 115207: Improve integration QCommandLineParser - KAboutData

2014-01-21 Thread Aleix Pol Gonzalez
/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

2014-01-22 Thread Aleix Pol Gonzalez
ported because I ported them. OTOH, there will be non-ported applications, that's why we provide this warning. - Aleix Pol Gonzalez On Jan. 22, 2014, 7:01 a.m., David Narváez wrote: --- This is an automatically generated e-mail

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review47996 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 22, 2014

Re: Review Request 115198: Fix KDE4Support compilation

2014-01-22 Thread Aleix Pol Gonzalez
it. I'm unsure what's the best way though. Diffs - src/kdeui/kapplication.cpp 5a7f4c8 Diff: https://git.reviewboard.kde.org/r/115198/diff/ Testing --- Builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

2014-01-22 Thread Aleix Pol Gonzalez
On Jan. 22, 2014, 11:32 a.m., Aleix Pol Gonzalez wrote: Well, but frameworks are not only for frameworks. They're all ported because I ported them. OTOH, there will be non-ported applications, that's why we provide this warning. Luigi Toscano wrote: You ported

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

2014-01-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review48003 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 22, 2014

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Aleix Pol Gonzalez
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Well, we

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Aleix Pol Gonzalez
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Aleix

Re: Review Request 115238: Bug in KDEPlatformFileDialogHelper(?) causes selectFile not to work in QFileDialog

2014-01-22 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/115238/#comment34038 no need for this debug. Thanks for improving the test, will have to look into the implementation. :) - Aleix Pol Gonzalez On Jan. 22, 2014, 10:26 p.m., Gregor Mi wrote: --- This is an automatically

Re: Review Request 115028: Allow the building of deprecated code to be disabled

2014-01-26 Thread Aleix Pol Gonzalez
they already are deprecated in kdelibs 4. I don't really like disabling compilation of deprecated symbols, especially in this case we're not winning that much. - Aleix Pol Gonzalez On Jan. 15, 2014, 1:56 p.m., Alex Merry wrote

Re: Review Request 114997: Improve KAuth README.md

2014-01-26 Thread Aleix Pol Gonzalez
/#comment34187 Need to use? link against? Also the (or similar) looks unsure. I would say: If you are using cmake, you can find KAuth by using: find_package(KF5Auth NO_MODULE) or finding KF5 with the Auth component, from your CMake scripts. - Aleix Pol Gonzalez On Jan. 26

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

2014-01-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/#review48326 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Jan

Re: Review Request 115316: Add demo for KRecentFileList

2014-01-26 Thread Aleix Pol Gonzalez
the developer that he did it right, but I wouldn't see it as documentation. I would rename it to KRecentFilesActionTest - Aleix Pol Gonzalez On Jan. 25, 2014, 10:56 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail

Re: Review Request 115207: Improve integration QCommandLineParser - KAboutData

2014-01-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review48347 --- On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 115361: use renamed kmailservice5

2014-01-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115361/#review48489 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 28, 2014

Re: Review Request 115362: Do not explicitly link against libc

2014-01-28 Thread Aleix Pol Gonzalez
really ugly to have -lc so +1 from me. - Aleix Pol Gonzalez On Jan. 28, 2014, 4:41 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115362

Re: Review Request 115382: Remove unused dependencies

2014-01-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115382/#review48548 --- Ship it! Cool :) - Aleix Pol Gonzalez On Jan. 29, 2014, 3

Re: Review Request 115411: Remove obsolete CMake code from pre-splitting

2014-01-31 Thread Aleix Pol Gonzalez
frameworks, actually. All this checking if it's being built out of kdelibs doesn't make sense anymore. - Aleix Pol Gonzalez On Jan. 31, 2014, 12:03 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 115421: Clean up the CMakeLists.txt files

2014-02-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115421/#review48815 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 1, 2014, 1

Re: Review Request 115477: Remove commands that just set variables to their defaults

2014-02-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115477/#review48995 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 4, 2014, 4

Re: Review Request 115472: fix test for icon path

2014-02-04 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/115472/#comment34595 You probably want endsWith(/.icons). - Aleix Pol Gonzalez On Feb. 4, 2014, 4:30 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115472: fix test for icon path

2014-02-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115472/#review49019 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 5, 2014

Re: Review Request 115525: Deprecate slots in KCompletion and convert into slots the methods they call

2014-02-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115525/#review49161 --- Ship it! Looks good to me - Aleix Pol Gonzalez On Feb. 6

Re: Review Request 115530: Find Qt5::X11Extras only if X11 is found

2014-02-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115530/#review49177 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 7, 2014, 8

Re: Review Request 115616: Add platform to qt options in KCmdLineArgs

2014-02-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115616/#review49439 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 10, 2014

Re: Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

2014-02-10 Thread Aleix Pol Gonzalez
/#comment34891 You can instantiate QApplication in the stack, instead of calling new+delete. Also you probably want to create it in the beginning of the main function body. - Aleix Pol Gonzalez On Feb. 10, 2014, 4:06 p.m., Martin Gräßlin wrote

Re: Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

2014-02-10 Thread Aleix Pol Gonzalez
On Feb. 10, 2014, 4:14 p.m., Aleix Pol Gonzalez wrote: drkonqi/main.cpp, line 74 https://git.reviewboard.kde.org/r/115629/diff/1/?file=243089#file243089line74 You can instantiate QApplication in the stack, instead of calling new+delete. Also you probably want

Re: Review Request 115681: kquitapp - kquitapp5

2014-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115681/#review49609 --- Ship it! - Aleix Pol Gonzalez On Feb. 11, 2014, 9:04 p.m

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-11 Thread Aleix Pol Gonzalez
it as a problem. This could break compilation on some projects other than KParts, will you be able to try the rest of the modules? Thanks for figuring it out! - Aleix Pol Gonzalez On Feb. 11, 2014, 10:15 p.m., David Faure wrote

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

2014-02-11 Thread Aleix Pol Gonzalez
benefits of name-spacing the desktop files besides feeling different and special. :) - Aleix Pol Gonzalez On Feb. 11, 2014, 9:56 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-19 Thread Aleix Pol Gonzalez
On Feb. 19, 2014, 10:06 a.m., Aleix Pol Gonzalez wrote: src/knotificationmanager.cpp, line 180 https://git.reviewboard.kde.org/r/115695/diff/3/?file=243841#file243841line180 ? Martin Klapetek wrote: Yet once again the description xD - it's full of ... FIXMEs to indicate

Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

2014-02-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115634/#review50388 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 20, 2014

Re: Review Request 115207: Improve integration QCommandLineParser - KAboutData

2014-02-21 Thread Aleix Pol Gonzalez
to duplicate information by passing it to the KAboutData _and_ the QApplication. Diffs (updated) - src/lib/kaboutdata.h c9e src/lib/kaboutdata.cpp c347521 Diff: https://git.reviewboard.kde.org/r/115207/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: Review Request 115207: Improve integration QCommandLineParser - KAboutData

2014-02-21 Thread Aleix Pol Gonzalez
/kaboutdata.h c9e src/lib/kaboutdata.cpp c347521 Diff: https://git.reviewboard.kde.org/r/115207/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 116462: Keep KSharedConfigPtr(kdeglobals) around in KHintSettings.

2014-03-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116462/#review51729 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Feb

Re: Review Request 116540: Add configuration for ReviewBoard

2014-03-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116540/#review51731 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 2, 2014

Re: Review Request 116539: Add README

2014-03-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116539/#review51732 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 2, 2014

Review Request 116573: Make KI18n a private dependency in KIO

2014-03-03 Thread Aleix Pol Gonzalez
706c983 src/core/slavebase.h 86f1506 src/core/slavebase.cpp 1236ad5 src/ioslaves/file/file.cpp b8c6220 src/ioslaves/file/file_unix.cpp 96fd6af Diff: https://git.reviewboard.kde.org/r/116573/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

2014-03-03 Thread Aleix Pol Gonzalez
a different patch: https://git.reviewboard.kde.org/r/116573/ I think that having UI strings on a header file is quite bad TBH, but since I see there's consensus I'll discard it. - Aleix Pol Gonzalez On March 3, 2014, 8:59 p.m., Matthieu Gallien wrote

Re: Review Request 116573: Make KI18n a private dependency in KIO

2014-03-03 Thread Aleix Pol Gonzalez
/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review51912 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On March

Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog

2014-03-04 Thread Aleix Pol Gonzalez
this feature, through QDialogButtonBox. Diffs - src/kpassworddialog.h 069e301 src/kpassworddialog.cpp cacf31a Diff: https://git.reviewboard.kde.org/r/116603/diff/ Testing --- Ported sudlg.cpp to it, they need it because it requires an Ignore button over there. Thanks, Aleix Pol

Re: Review Request 115207: Improve integration QCommandLineParser - KAboutData

2014-03-04 Thread Aleix Pol Gonzalez
/kaboutdata.h c9e src/lib/kaboutdata.cpp c347521 Diff: https://git.reviewboard.kde.org/r/115207/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog

2014-03-05 Thread Aleix Pol Gonzalez
/ Testing --- Ported sudlg.cpp to it, they need it because it requires an Ignore button over there. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 115207: Improve integration QCommandLineParser - KAboutData

2014-03-05 Thread Aleix Pol Gonzalez
/kaboutdata.h c9e src/lib/kaboutdata.cpp c347521 Diff: https://git.reviewboard.kde.org/r/115207/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog

2014-03-05 Thread Aleix Pol Gonzalez
to it, they need it because it requires an Ignore button over there. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116628: Avoid multiple warnings caused by CMake Policy 0026

2014-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116628/#review52236 --- Ship it! - Aleix Pol Gonzalez On March 6, 2014, 10:11 a.m

Re: Review Request 116681: Fix kio-help by adding a separator

2014-03-09 Thread Aleix Pol Gonzalez
is quite fragile :/. - Aleix Pol Gonzalez On March 9, 2014, 9:18 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116681

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

2014-03-09 Thread Aleix Pol Gonzalez
not here... http://community.kde.org/Frameworks/Epics/New_Runtime_Organization - Aleix Pol Gonzalez On March 10, 2014, 12:01 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

2014-03-09 Thread Aleix Pol Gonzalez
On March 10, 2014, 4:32 a.m., Aleix Pol Gonzalez wrote: I would say it makes sense. I wonder why it's not here... http://community.kde.org/Frameworks/Epics/New_Runtime_Organization PS: note I'm not the KIO maintainer, you might want to wait for his advise. - Aleix

Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aleix Pol Gonzalez
/116696/diff/ Testing --- Now I can build frameworks that use kservice_desktop_to_json. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/#review52551 --- On March 10, 2014, 2 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 116650: Remove unused targets from KDocToolsMacros.cmake

2014-03-10 Thread Aleix Pol Gonzalez
on it. Am I missing something? Diffs (updated) - KF5DocToolsMacros.cmake 6567b67 Diff: https://git.reviewboard.kde.org/r/116650/diff/ Testing --- Now kde-runtime documentation builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks

Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

2014-03-10 Thread Aleix Pol Gonzalez
? Diffs - KF5DocToolsMacros.cmake 6567b67 Diff: https://git.reviewboard.kde.org/r/116650/diff/ Testing --- Now kde-runtime documentation builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aleix Pol Gonzalez
with 2.8.12, which is the lowest supported version IIRC (at least KF5ConfigTargets.cmake thinks so) and it works for me. Alex Merry wrote: Assuming this is linked to the previous RR on this topic, I think this is only with Visual Studio. Aleix Pol Gonzalez wrote: Nope, this is on linux

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-11 Thread Aleix Pol Gonzalez
. Diffs - KF5ServiceMacros.cmake fd835bd Diff: https://git.reviewboard.kde.org/r/116696/diff/ Testing --- Now I can build frameworks that use kservice_desktop_to_json. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list

Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

2014-03-11 Thread Aleix Pol Gonzalez
any command and nothing depended on it. Am I missing something? Diffs (updated) - KF5DocToolsMacros.cmake 6567b67 Diff: https://git.reviewboard.kde.org/r/116650/diff/ Testing --- Now kde-runtime documentation builds. Thanks, Aleix Pol Gonzalez

Re: Review Request 116723: Update cmake code in apidox to reflect new macro names

2014-03-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116723/#review52653 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 11, 2014

Re: Review Request 116732: Use the new uic macro

2014-03-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116732/#review52663 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 11, 2014

Re: Review Request 116740: Fix kdeglobals location in apidox

2014-03-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116740/#review52701 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 11, 2014

Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

2014-03-11 Thread Aleix Pol Gonzalez
Diff: https://git.reviewboard.kde.org/r/116650/diff/ Testing --- Now kde-runtime documentation builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 116747: Clean up KCompletionBox

2014-03-11 Thread Aleix Pol Gonzalez
there's a reason for that... :/ - Aleix Pol Gonzalez On March 11, 2014, 10:32 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread Aleix Pol Gonzalez
On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote: src/kcompletionbox.h, line 228 https://git.reviewboard.kde.org/r/116747/diff/1/?file=253404#file253404line228 I wouldn't leave the implementation here. Move it to the .cpp file, this way it can be changed in the future

Re: Review Request 116762: Remove new in kde4 comment

2014-03-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116762/#review52753 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 12, 2014

Re: Review Request 116767: Clean up CMake code from pre-splitting

2014-03-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116767/#review52772 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 12, 2014

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/#review53379 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 18, 2014

Re: Review Request 116920: Move the autostart and wrapper docs into a docs/ subdirectory

2014-03-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116920/#review53513 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 20, 2014

Re: Review Request 116939: Add deprecation info to kcombobox, kcompletionbase and klineedit

2014-03-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116939/#review53625 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 20, 2014

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-23 Thread Aleix Pol Gonzalez
/116866/#comment37768 Wouldn't it make more sense to use qIsNan? http://qt-project.org/doc/qt-5.0/qtcore/qtglobal.html#qIsNaN - Aleix Pol Gonzalez On March 22, 2014, 8:54 p.m., Michael Hansen wrote

Re: Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-23 Thread Aleix Pol Gonzalez
On March 23, 2014, 11:51 p.m., Aleix Pol Gonzalez wrote: So what should happen so that we didn't need the workaround? Alexander Richardson wrote: QStandardPaths would have to look in %KDEROOT%\share and not just C:\ProgramData. So why aren't we adding this in Qt? Or even, why

Re: Review Request 117017: Remove forward headers for KTextEditor

2014-03-24 Thread Aleix Pol Gonzalez
added the KDE/ at all... - Aleix Pol Gonzalez On March 24, 2014, 10:48 a.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017

Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

2014-03-24 Thread Aleix Pol Gonzalez
INSTALL_INTERFACE data, no? - Aleix Pol Gonzalez On March 24, 2014, 1:33 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-24 Thread Aleix Pol Gonzalez
should look into libexec too (at least the equivalent KStandardDirs::findExe used to). - Aleix Pol Gonzalez On March 24, 2014, 10:52 a.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 117018: Use qIsNaN() instead of isnan()

2014-03-24 Thread Aleix Pol Gonzalez
/ --- (Updated March 24, 2014, 12:10 p.m.) Review request for KDE Frameworks, Aleix Pol Gonzalez and Michael Hansen. Repository: kguiaddons Description --- Use qIsNaN() instead of isnan() Revert Use std::isnan on compilers that support it This reverts commit

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-24 Thread Aleix Pol Gonzalez
On March 24, 2014, 3:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Agreed. If somebody has the time, it would be interesting to figure out what can be uncommented (see commit

Re: Review Request 117037: Refactor parameter names

2014-03-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117037/#review54052 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 24, 2014

Re: Review Request 117042: Make KLineEdit::completionBox virtual so that konq can reimplement it

2014-03-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117042/#review54053 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 24, 2014

Re: Review Request 117059: Explicitly state link interface for libKF5Activites

2014-03-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117059/#review54131 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 25, 2014

Re: Review Request 117060: Explicitly specify link interface libraries for libKF5PlasmaQuick

2014-03-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117060/#review54132 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 25, 2014

Re: Review Request 117071: Re-enable i18n in KPluginLoader

2014-03-25 Thread Aleix Pol Gonzalez
be a thing... I just checked and it's being used in kde4support as well. - Aleix Pol Gonzalez On March 26, 2014, 12:15 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 117072: Add autotests for KPluginLoader and KPluginFactory

2014-03-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117072/#review54150 --- Ship it! Yay unit tests!! - Aleix Pol Gonzalez On March

Re: Review Request 117089: Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION

2014-03-26 Thread Aleix Pol Gonzalez
with KService. One of the good things of testing different compilers. :) - Aleix Pol Gonzalez On March 26, 2014, 4:05 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 116969: Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()

2014-03-26 Thread Aleix Pol Gonzalez
for preferring resetIndex to reset? - Aleix Pol Gonzalez On March 24, 2014, 9:45 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969

Re: Review Request 117104: Remove KLineEdit::clear(): it doesn't seem to modify clipboard anymore

2014-03-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117104/#review54255 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 26, 2014

Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder

2014-03-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/#review54284 --- Ship it! Less code! - Aleix Pol Gonzalez On March 27

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-27 Thread Aleix Pol Gonzalez
On March 24, 2014, 3:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Aleix Pol Gonzalez wrote: Agreed. If somebody has the time, it would be interesting to figure out

Review Request 117122: Cut the dependency between country files and KIO

2014-03-27 Thread Aleix Pol Gonzalez
-archive.com/kde-frameworks-devel@kde.org/msg11839.html [2] ~/kde5/share/locale/l10n$ grep -R BinaryUnitDialect C/entry.desktop:BinaryUnitDialect=0 Diffs - src/core/global.cpp 99ab2e7 Diff: https://git.reviewboard.kde.org/r/117122/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-27 Thread Aleix Pol Gonzalez
On March 27, 2014, 8:31 p.m., Alex Merry wrote: modules/ECMTrLoader.cpp.in, line 19 https://git.reviewboard.kde.org/r/117052/diff/2/?file=257837#file257837line19 QLatin1String() when you're using + Why? That doesn't make sense on my book. - Aleix

Re: Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

2014-03-27 Thread Aleix Pol Gonzalez
is weird... Additionally, these are used in many places. These should be updated as well. - Aleix Pol Gonzalez On March 26, 2014, 1:44 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 117132: Use QLocale for figuring out what languages we're translated into

2014-03-28 Thread Aleix Pol Gonzalez
--- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117134: Use QLocale to list all languages

2014-03-28 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/117134/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117136: Expose KAssistantDialog buttons

2014-03-28 Thread Aleix Pol Gonzalez
of dr konqi. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread Aleix Pol Gonzalez
On March 28, 2014, 2:13 p.m., David Faure wrote: How does findExecutable() help at all? You plan on adding libexec to your $PATH? KStandardDirs::findExe used to look into libexec, IIRC. Maybe we could make it work. Or do something completely different. - Aleix

Review Request 117136: Expose KAssistantDialog buttons

2014-03-28 Thread Aleix Pol Gonzalez
different methods. Diffs - src/kassistantdialog.cpp 00895f0 src/kassistantdialog.h e7ffaf5 Diff: https://git.reviewboard.kde.org/r/117136/diff/ Testing --- Using it from the ongoing port of dr konqi. Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread Aleix Pol Gonzalez
On March 24, 2014, 3:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Aleix Pol Gonzalez wrote: Agreed. If somebody has the time, it would be interesting to figure out

Re: Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

2014-03-28 Thread Aleix Pol Gonzalez
On March 28, 2014, 4:16 p.m., Commit Hook wrote: This review has been submitted with commit a33377b84b9b312cf5f1f2baae42e6e514731d64 by Jonathan Riddell to branch master. Why did you ignore my comment? This breaks entry.desktop files usage. - Aleix

Re: Review Request 117134: Use QLocale to list all languages

2014-03-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117134/#review54465 --- On March 28, 2014, 11:50 a.m., Aleix Pol Gonzalez wrote

Re: Review Request 117132: Use QLocale for figuring out what languages we're translated into

2014-03-28 Thread Aleix Pol Gonzalez
--- On March 28, 2014, 11:21 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117132

Re: Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

2014-03-28 Thread Aleix Pol Gonzalez
On March 28, 2014, 4:16 p.m., Commit Hook wrote: This review has been submitted with commit a33377b84b9b312cf5f1f2baae42e6e514731d64 by Jonathan Riddell to branch master. Aleix Pol Gonzalez wrote: Why did you ignore my comment? This breaks entry.desktop files usage. Jonathan

<    3   4   5   6   7   8   9   10   11   12   >