---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115199/#review47959
---
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On Jan
/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ported because I
ported them.
OTOH, there will be non-ported applications, that's why we provide this warning.
- Aleix Pol Gonzalez
On Jan. 22, 2014, 7:01 a.m., David Narváez wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115211/#review47996
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 22, 2014
it.
I'm unsure what's the best way though.
Diffs
-
src/kdeui/kapplication.cpp 5a7f4c8
Diff: https://git.reviewboard.kde.org/r/115198/diff/
Testing
---
Builds.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde
On Jan. 22, 2014, 11:32 a.m., Aleix Pol Gonzalez wrote:
Well, but frameworks are not only for frameworks. They're all ported
because I ported them.
OTOH, there will be non-ported applications, that's why we provide this
warning.
Luigi Toscano wrote:
You ported
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115213/#review48003
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 22, 2014
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote:
This seems sensible to me; however, I do wonder if ECM should also provide
an ecm_mark_gui_executable function as well (I'm thinking of the case where
most of the tests should be non-gui, but a handful want to display widgets).
Well, we
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote:
This seems sensible to me; however, I do wonder if ECM should also provide
an ecm_mark_gui_executable function as well (I'm thinking of the case where
most of the tests should be non-gui, but a handful want to display widgets).
Aleix
://git.reviewboard.kde.org/r/115238/#comment34038
no need for this debug.
Thanks for improving the test, will have to look into the implementation. :)
- Aleix Pol Gonzalez
On Jan. 22, 2014, 10:26 p.m., Gregor Mi wrote:
---
This is an automatically
they already are
deprecated in kdelibs 4.
I don't really like disabling compilation of deprecated symbols, especially in
this case we're not winning that much.
- Aleix Pol Gonzalez
On Jan. 15, 2014, 1:56 p.m., Alex Merry wrote
/#comment34187
Need to use? link against?
Also the (or similar) looks unsure. I would say:
If you are using cmake, you can find KAuth by using:
find_package(KF5Auth NO_MODULE)
or finding KF5 with the Auth component, from your CMake scripts.
- Aleix Pol Gonzalez
On Jan. 26
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115148/#review48326
---
Ship it!
Makes sense to me.
- Aleix Pol Gonzalez
On Jan
the developer that
he did it right, but I wouldn't see it as documentation.
I would rename it to KRecentFilesActionTest
- Aleix Pol Gonzalez
On Jan. 25, 2014, 10:56 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review48347
---
On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115361/#review48489
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 28, 2014
really ugly to have -lc so +1
from me.
- Aleix Pol Gonzalez
On Jan. 28, 2014, 4:41 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115362
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115382/#review48548
---
Ship it!
Cool :)
- Aleix Pol Gonzalez
On Jan. 29, 2014, 3
frameworks, actually.
All this checking if it's being built out of kdelibs doesn't make sense anymore.
- Aleix Pol Gonzalez
On Jan. 31, 2014, 12:03 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115421/#review48815
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 1, 2014, 1
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115477/#review48995
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 4, 2014, 4
://git.reviewboard.kde.org/r/115472/#comment34595
You probably want endsWith(/.icons).
- Aleix Pol Gonzalez
On Feb. 4, 2014, 4:30 p.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115472/#review49019
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 5, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115525/#review49161
---
Ship it!
Looks good to me
- Aleix Pol Gonzalez
On Feb. 6
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115530/#review49177
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 7, 2014, 8
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115616/#review49439
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 10, 2014
/#comment34891
You can instantiate QApplication in the stack, instead of calling
new+delete.
Also you probably want to create it in the beginning of the main function
body.
- Aleix Pol Gonzalez
On Feb. 10, 2014, 4:06 p.m., Martin Gräßlin wrote
On Feb. 10, 2014, 4:14 p.m., Aleix Pol Gonzalez wrote:
drkonqi/main.cpp, line 74
https://git.reviewboard.kde.org/r/115629/diff/1/?file=243089#file243089line74
You can instantiate QApplication in the stack, instead of calling
new+delete.
Also you probably want
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115681/#review49609
---
Ship it!
- Aleix Pol Gonzalez
On Feb. 11, 2014, 9:04 p.m
it as a problem.
This could break compilation on some projects other than KParts, will you be
able to try the rest of the modules?
Thanks for figuring it out!
- Aleix Pol Gonzalez
On Feb. 11, 2014, 10:15 p.m., David Faure wrote
benefits of name-spacing the
desktop files besides feeling different and special. :)
- Aleix Pol Gonzalez
On Feb. 11, 2014, 9:56 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Feb. 19, 2014, 10:06 a.m., Aleix Pol Gonzalez wrote:
src/knotificationmanager.cpp, line 180
https://git.reviewboard.kde.org/r/115695/diff/3/?file=243841#file243841line180
?
Martin Klapetek wrote:
Yet once again the description xD - it's full of ... FIXMEs to indicate
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115634/#review50388
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 20, 2014
to
duplicate information by passing it to the KAboutData _and_ the QApplication.
Diffs (updated)
-
src/lib/kaboutdata.h c9e
src/lib/kaboutdata.cpp c347521
Diff: https://git.reviewboard.kde.org/r/115207/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
/kaboutdata.h c9e
src/lib/kaboutdata.cpp c347521
Diff: https://git.reviewboard.kde.org/r/115207/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116462/#review51729
---
Ship it!
Makes sense to me.
- Aleix Pol Gonzalez
On Feb
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116540/#review51731
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 2, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116539/#review51732
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 2, 2014
706c983
src/core/slavebase.h 86f1506
src/core/slavebase.cpp 1236ad5
src/ioslaves/file/file.cpp b8c6220
src/ioslaves/file/file_unix.cpp 96fd6af
Diff: https://git.reviewboard.kde.org/r/116573/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
a different patch:
https://git.reviewboard.kde.org/r/116573/
I think that having UI strings on a header file is quite bad TBH, but since I
see there's consensus I'll discard it.
- Aleix Pol Gonzalez
On March 3, 2014, 8:59 p.m., Matthieu Gallien wrote
/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/#review51912
---
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On March
this feature, through
QDialogButtonBox.
Diffs
-
src/kpassworddialog.h 069e301
src/kpassworddialog.cpp cacf31a
Diff: https://git.reviewboard.kde.org/r/116603/diff/
Testing
---
Ported sudlg.cpp to it, they need it because it requires an Ignore button
over there.
Thanks,
Aleix Pol
/kaboutdata.h c9e
src/lib/kaboutdata.cpp c347521
Diff: https://git.reviewboard.kde.org/r/115207/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
/
Testing
---
Ported sudlg.cpp to it, they need it because it requires an Ignore button
over there.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
/kaboutdata.h c9e
src/lib/kaboutdata.cpp c347521
Diff: https://git.reviewboard.kde.org/r/115207/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
to it, they need it because it requires an Ignore button
over there.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116628/#review52236
---
Ship it!
- Aleix Pol Gonzalez
On March 6, 2014, 10:11 a.m
is quite fragile :/.
- Aleix Pol Gonzalez
On March 9, 2014, 9:18 p.m., Luigi Toscano wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116681
not here...
http://community.kde.org/Frameworks/Epics/New_Runtime_Organization
- Aleix Pol Gonzalez
On March 10, 2014, 12:01 a.m., Luigi Toscano wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On March 10, 2014, 4:32 a.m., Aleix Pol Gonzalez wrote:
I would say it makes sense.
I wonder why it's not here...
http://community.kde.org/Frameworks/Epics/New_Runtime_Organization
PS: note I'm not the KIO maintainer, you might want to wait for his advise.
- Aleix
/116696/diff/
Testing
---
Now I can build frameworks that use kservice_desktop_to_json.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116696/#review52551
---
On March 10, 2014, 2 p.m., Aleix Pol Gonzalez wrote
on it. Am I missing something?
Diffs (updated)
-
KF5DocToolsMacros.cmake 6567b67
Diff: https://git.reviewboard.kde.org/r/116650/diff/
Testing
---
Now kde-runtime documentation builds.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks
?
Diffs
-
KF5DocToolsMacros.cmake 6567b67
Diff: https://git.reviewboard.kde.org/r/116650/diff/
Testing
---
Now kde-runtime documentation builds.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
with 2.8.12, which is the lowest supported version IIRC (at
least KF5ConfigTargets.cmake thinks so) and it works for me.
Alex Merry wrote:
Assuming this is linked to the previous RR on this topic, I think this is
only with Visual Studio.
Aleix Pol Gonzalez wrote:
Nope, this is on linux
.
Diffs
-
KF5ServiceMacros.cmake fd835bd
Diff: https://git.reviewboard.kde.org/r/116696/diff/
Testing
---
Now I can build frameworks that use kservice_desktop_to_json.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
any command and
nothing depended on it. Am I missing something?
Diffs (updated)
-
KF5DocToolsMacros.cmake 6567b67
Diff: https://git.reviewboard.kde.org/r/116650/diff/
Testing
---
Now kde-runtime documentation builds.
Thanks,
Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116723/#review52653
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 11, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116732/#review52663
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 11, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116740/#review52701
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 11, 2014
Diff: https://git.reviewboard.kde.org/r/116650/diff/
Testing
---
Now kde-runtime documentation builds.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
there's a reason for that... :/
- Aleix Pol Gonzalez
On March 11, 2014, 10:32 p.m., David Gil Oliva wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747
On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote:
src/kcompletionbox.h, line 228
https://git.reviewboard.kde.org/r/116747/diff/1/?file=253404#file253404line228
I wouldn't leave the implementation here. Move it to the .cpp file,
this way it can be changed in the future
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116762/#review52753
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 12, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116767/#review52772
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 12, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116886/#review53379
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 18, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116920/#review53513
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 20, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116939/#review53625
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 20, 2014
/116866/#comment37768
Wouldn't it make more sense to use qIsNan?
http://qt-project.org/doc/qt-5.0/qtcore/qtglobal.html#qIsNaN
- Aleix Pol Gonzalez
On March 22, 2014, 8:54 p.m., Michael Hansen wrote
On March 23, 2014, 11:51 p.m., Aleix Pol Gonzalez wrote:
So what should happen so that we didn't need the workaround?
Alexander Richardson wrote:
QStandardPaths would have to look in %KDEROOT%\share and not just
C:\ProgramData.
So why aren't we adding this in Qt? Or even, why
added the KDE/ at all...
- Aleix Pol Gonzalez
On March 24, 2014, 10:48 a.m., Kevin Funk wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117017
INSTALL_INTERFACE data,
no?
- Aleix Pol Gonzalez
On March 24, 2014, 1:33 a.m., Andrius da Costa Ribas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012
should look into
libexec too (at least the equivalent KStandardDirs::findExe used to).
- Aleix Pol Gonzalez
On March 24, 2014, 10:52 a.m., Dan Vrátil wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/
---
(Updated March 24, 2014, 12:10 p.m.)
Review request for KDE Frameworks, Aleix Pol Gonzalez and Michael Hansen.
Repository: kguiaddons
Description
---
Use qIsNaN() instead of isnan()
Revert Use std::isnan on compilers that support it
This reverts commit
On March 24, 2014, 3:41 p.m., Alex Merry wrote:
The correct solution is to get drkonqi merged into kcrash (see
http://community.kde.org/Frameworks/Epics/New_Runtime_Organization).
Agreed. If somebody has the time, it would be interesting to figure out what
can be uncommented (see commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117037/#review54052
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 24, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117042/#review54053
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 24, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117059/#review54131
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 25, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117060/#review54132
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 25, 2014
be a thing... I just
checked and it's being used in kde4support as well.
- Aleix Pol Gonzalez
On March 26, 2014, 12:15 a.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117072/#review54150
---
Ship it!
Yay unit tests!!
- Aleix Pol Gonzalez
On March
with KService.
One of the good things of testing different compilers. :)
- Aleix Pol Gonzalez
On March 26, 2014, 4:05 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
for preferring
resetIndex to reset?
- Aleix Pol Gonzalez
On March 24, 2014, 9:45 p.m., David Gil Oliva wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116969
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117104/#review54255
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 26, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117108/#review54284
---
Ship it!
Less code!
- Aleix Pol Gonzalez
On March 27
On March 24, 2014, 3:41 p.m., Alex Merry wrote:
The correct solution is to get drkonqi merged into kcrash (see
http://community.kde.org/Frameworks/Epics/New_Runtime_Organization).
Aleix Pol Gonzalez wrote:
Agreed. If somebody has the time, it would be interesting to figure out
-archive.com/kde-frameworks-devel@kde.org/msg11839.html
[2]
~/kde5/share/locale/l10n$ grep -R BinaryUnitDialect
C/entry.desktop:BinaryUnitDialect=0
Diffs
-
src/core/global.cpp 99ab2e7
Diff: https://git.reviewboard.kde.org/r/117122/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
On March 27, 2014, 8:31 p.m., Alex Merry wrote:
modules/ECMTrLoader.cpp.in, line 19
https://git.reviewboard.kde.org/r/117052/diff/2/?file=257837#file257837line19
QLatin1String() when you're using +
Why? That doesn't make sense on my book.
- Aleix
is weird...
Additionally, these are used in many places. These should be updated as well.
- Aleix Pol Gonzalez
On March 26, 2014, 1:44 p.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/117134/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
of dr konqi.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On March 28, 2014, 2:13 p.m., David Faure wrote:
How does findExecutable() help at all? You plan on adding libexec to your
$PATH?
KStandardDirs::findExe used to look into libexec, IIRC.
Maybe we could make it work.
Or do something completely different.
- Aleix
different methods.
Diffs
-
src/kassistantdialog.cpp 00895f0
src/kassistantdialog.h e7ffaf5
Diff: https://git.reviewboard.kde.org/r/117136/diff/
Testing
---
Using it from the ongoing port of dr konqi.
Thanks,
Aleix Pol Gonzalez
___
Kde
On March 24, 2014, 3:41 p.m., Alex Merry wrote:
The correct solution is to get drkonqi merged into kcrash (see
http://community.kde.org/Frameworks/Epics/New_Runtime_Organization).
Aleix Pol Gonzalez wrote:
Agreed. If somebody has the time, it would be interesting to figure out
On March 28, 2014, 4:16 p.m., Commit Hook wrote:
This review has been submitted with commit
a33377b84b9b312cf5f1f2baae42e6e514731d64 by Jonathan Riddell to branch
master.
Why did you ignore my comment? This breaks entry.desktop files usage.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117134/#review54465
---
On March 28, 2014, 11:50 a.m., Aleix Pol Gonzalez wrote
---
On March 28, 2014, 11:21 a.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117132
On March 28, 2014, 4:16 p.m., Commit Hook wrote:
This review has been submitted with commit
a33377b84b9b312cf5f1f2baae42e6e514731d64 by Jonathan Riddell to branch
master.
Aleix Pol Gonzalez wrote:
Why did you ignore my comment? This breaks entry.desktop files usage.
Jonathan
701 - 800 of 4253 matches
Mail list logo