Re: Review Request 117161: Drop QApplication usages in units.cpp

/ Testing --- Builds, KAlgebra doesn't have the problem now. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117134: Use QLocale to list all languages

language naming scheme yet? Diffs - src/klanguagebutton.cpp 9f0c055 Diff: https://git.reviewboard.kde.org/r/117134/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 117269: Use KEMailSettings, instead of parsing configurations directly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117269/#review54730 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 31, 2014

Re: Review Request 117272: Use KIconDialog instead of running kdialog to choose icons

dependency such as kde-cli-tools (in kde-runtime now). - Aleix Pol Gonzalez On April 1, 2014, 12:34 a.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 117273: Fix i18n in ksendbugmail

these problems somehow... How did you notice it? - Aleix Pol Gonzalez On April 1, 2014, 12:48 a.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 117274: Fix kf5kross i18n, and resurrect its KAboutData

g/r/117274/#comment38250> You might want to keep the context with, i18nc, no? - Aleix Pol Gonzalez On April 1, 2014, 1:17 a.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 117278: Remove KDE4 TODO

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117278/#review54757 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

refer people to use setters, but please don't deprecate the old one. There's little reason for doing so, it's very old API and it has always worked as is. - Aleix Pol Gonzalez On April 1, 2014, 10:09 a.m., Alex Merry wrote: > > --

Re: Review Request 117274: Fix kf5kross i18n, and resurrect its KAboutData

rom a main() function. - Aleix Pol Gonzalez On April 1, 2014, 1:17 a.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

> On April 1, 2014, 10:55 a.m., Aleix Pol Gonzalez wrote: > > I think it's fine that you add the other one if you prefer people to use > > setters, but please don't deprecate the old one. There's little reason for > > doing so, it's very old API and it

Re: Review Request 117283: Fix i18n in kbuildsycoca5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117283/#review54772 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014

Review Request 117297: Move settings from kde-runtime/doc/api to kapidox

: kapidox Description --- Move the settings we used to have in the Doxyfile.local inside kde-runtime/doc/api to kapidox, so we don't miss any warnings now. Diffs - src/Doxyfile.local e2de7c2 Diff: https://git.reviewboard.kde.org/r/117297/diff/ Testing --- Thanks, Alei

Re: Review Request 117274: Fix i18n in kross

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54789 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014

Re: Review Request 117297: Move settings from kde-runtime/doc/api to kapidox

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117297/#review54783 ------- On April 1, 2014, 2:19 p.m., Aleix Pol Gonzalez wrote: > > --

Re: Review Request 117299: Resolve a KDE4 TODO in KDesktopFileActions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117299/#review54792 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014

Re: Review Request 117314: Improve kross console app i18n

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117314/#review54823 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014

Re: Review Request 117315: [kbuildsycoca] Tidy up command-line parsing and kaboutdata code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117315/#review54824 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014

Re: Review Request 117318: Move methods from KCompletionPrivate to KCompletionMatchesWrapper

after all... :) - Aleix Pol Gonzalez On April 1, 2014, 10:37 p.m., David Gil Oliva wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 117316: Bump source-incompatible KDE4 TODO to KF6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117316/#review54826 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014

Re: Review Request 117297: Move settings from kde-runtime/doc/api to kapidox

de7c2 Diff: https://git.reviewboard.kde.org/r/117297/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117325: Improve the desktoptojson man page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117325/#review54887 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 2, 2014

Re: Review Request 117337: Fix crash in KService

pointer in the argument is quite dirty, but I see how it could crash without this change. - Aleix Pol Gonzalez On April 2, 2014, 5:33 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 117341: Update documentation templates for the KF5 world

tps://git.reviewboard.kde.org/r/117341/#comment38328> Shouldn't it be 5.0? - Aleix Pol Gonzalez On April 2, 2014, 10:02 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://gi

Re: Review Request 117122: Cut the dependency between country files and KIO

l.cpp 99ab2e7 Diff: https://git.reviewboard.kde.org/r/117122/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

> On March 24, 2014, 3:41 p.m., Alex Merry wrote: > > The correct solution is to get drkonqi merged into kcrash (see > > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). > > Aleix Pol Gonzalez wrote: > Agreed. If somebody has the time, it would

Re: Review Request 117132: Use QLocale for figuring out what languages we're translated into

https://git.reviewboard.kde.org/r/117132/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117457: kio-extras: minor dependencies cleanup

rg/r/117457/#comment38522> Good catch! Now that you're here, remove the commented target_link_libraries, it's never going to be useful - Aleix Pol Gonzalez On April 9, 2014, 6:35 p.m., Hrvoje Senjan wrote: > > --

Re: Review Request 117457: kio-extras: minor dependencies cleanup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117457/#review55314 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 9, 2014

Re: Review Request 117132: Use QLocale for figuring out what languages we're translated into

- src/khelpmenu.cpp 4f6ce7b Diff: https://git.reviewboard.kde.org/r/117132/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117435: Import KDirSelectDialog + use it if QFileDialog requests dirs only

tps://git.reviewboard.kde.org/r/117435/#comment38782> ? src/platformtheme/kdeplatformfiledialoghelper.cpp <https://git.reviewboard.kde.org/r/117435/#comment38783> Don't you need to set a title or anything like that? Maybe we can set the same title for either code path? - A

Re: Review Request 117435: Import KDirSelectDialog + use it if QFileDialog requests dirs only

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117435/#review55724 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 8, 2014

Re: Review Request 117490: Improve FindEGL.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117490/#review55749 --- Ship it! Looks good to me too. +1 - Aleix Pol Gonzalez On

Review Request 117565: Expose the quit slot on KDBusService-enabled applications

sting --- Now I have a way to close plasma-shell that doesn't lose all unsaved configuration. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117565: Expose the quit slot on KDBusService-enabled applications

src/kdbusservice.cpp 497c774 Diff: https://git.reviewboard.kde.org/r/117565/diff/ Testing --- Now I have a way to close plasma-shell that doesn't lose all unsaved configuration. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailin

Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

tps://git.reviewboard.kde.org/r/117604/#comment38944> It should be a qWarning. Looks good to me though, it's very annoying to debug this kind of problems without feedback. +1 - Aleix Pol Gonzalez On April 16, 2014, 9:07 p.m., David J

Re: Review Request 117599: Improve tests

experience across frameworks. - Aleix Pol Gonzalez On April 16, 2014, 4:53 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

> On April 23, 2014, 5:09 p.m., David Faure wrote: > > The reason I did it this way was because existing application code uses > > > > #include > > #include > > etc. > > See e.g. > > http://lxr.kde.org/source/kde/kdelibs/kross/kjs/kjsscript.cpp?v=stable-qt4 > > > > So I picked the "namespace

Review Request 117838: Fix KWin decorations look-up

Diff: https://git.reviewboard.kde.org/r/117838/diff/ Testing --- Now my KWin has decorations. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 117838: Fix KWin decorations look-up

/kwindecoration/decorationmodel.cpp bb64b46 libkdecorations/kdecoration_plugins_p.cpp 8570b6a Diff: https://git.reviewboard.kde.org/r/117838/diff/ Testing --- Now my KWin has decorations. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Re: Review Request 117148: use renamed kf5_entry.desktop file

- > > (Updated March 28, 2014, 7:22 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kconfigwidgets > > > Description > --- > > entry.desktop got renamed, use the

Re: Review Request 117148: use renamed kf5_entry.desktop file

on a feature in kdelibs4support. A different solution must be found. - Aleix Pol Gonzalez On April 29, 2014, 11:10 a.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 117864: Move current files from /usr/share/locale/currency/ to /usr/share/locale/currency/kf5/ This allows KF5 to be co-installed with kde-runtime from kdelibs4

aning that those are the files in locale dedicated to currency. Note that share/currency is not a standard place anyway, so we are not being backward compatible. Aren't these files being used anywhere else? - Aleix Pol Gonzalez On April 29, 2014, 12:27 p.m., Jonathan Rid

Re: Review Request 117799: Clean up private slots in KCompletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117799/#review56963 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 26, 2014

Re: Review Request 117895: rename kdebugdialog5 internally and move documentation for co-installability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117895/#review56965 --- No need to rename the folder, no? - Aleix Pol Gonzalez On

Re: Review Request 117907: make documentation match new values in code

added variables as well... - Aleix Pol Gonzalez On April 30, 2014, 3:22 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 117148: use renamed kf5_entry.desktop file

tring::availableApplicationTranslations? Or if we want /all/ languages, maybe just QLocale? Either way, depending on kdelibs4support here is not acceptable. - Aleix Pol Gonzalez On April 29, 2014, 11:10 a.m., Jonathan Riddell wrote: > > --- &

Re: Review Request 118048: Make the KF5_LIBEXEC_INSTALL_DIR default depend on LIBEXEC_INSTALL_DIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118048/#review57568 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 8, 2014, 9

Re: Review Request 118085: adapt to ecm_add_tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118085/#review57735 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 11, 2014, 8

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

doing such changes remember there's things already ported. - Aleix Pol Gonzalez On May 13, 2014, 11:52 p.m., Michael Pyne wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

enter/CMakeLists.txt f1d88d2 Diff: https://git.reviewboard.kde.org/r/118149/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

-name CMakeLists.txt | xargs grep "kdoctools_create_handbook" | grep -v SUBDIR" Maybe kdoctools_create_handbook should fail if it doesn't get a SUBDIR? - Aleix Pol Gonzalez On May 15, 2014, 2:40 p.m., Aleix Pol Gonzalez wrote: > > ---

Review Request 118156: Make SUBDIR argument mandatory in kdoctools_create_handbook

x27;t fail before but were incorrect. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

have the same problem. Diffs - doc/fundamentals/CMakeLists.txt 0921d20 doc/khelpcenter/CMakeLists.txt f1d88d2 Diff: https://git.reviewboard.kde.org/r/118149/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

> On May 14, 2014, 10:48 a.m., Aleix Pol Gonzalez wrote: > > Note that this broke lots of KAboutData uses. > > > > Please, when doing such changes remember there's things already ported. > > Michael Pyne wrote: > Yes, my apologies. > >

Re: Review Request 118156: Make SUBDIR argument mandatory in kdoctools_create_handbook

https://git.reviewboard.kde.org/r/118156/diff/ Testing --- Makes some builds fail that didn't fail before but were incorrect. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailma

Re: Review Request 118276: give kwrite the proper dbus name in desktop file

e why anything would break with the change. Also it's one of those "the-sooner-the-better" changes, in case somebody plans to rely on it. - Aleix Pol Gonzalez On May 23, 2014, 2:29 p.m., Marco Martin wrote: > > ---

Re: Review Request 118352: Add more deprecated notes to KDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118352/#review58573 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 27, 2014, 1

Re: Review Request 118373: Do not delete passed objects to createObjectFromComponent

only in case of error. - Aleix Pol Gonzalez On May 28, 2014, 10:33 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 118415: Fix looking up icons

415/#comment40899> The iconPath call doesn't look trivial. I don't think we want the call twice, put it in a variable maybe? Feel free to do it when pushing if you don't want to do another round in reviewboard. - Aleix Pol Gonzalez On May 30, 2014, 8:23 a.m.,

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

> On May 26, 2014, 8:11 a.m., Àlex Fiestas wrote: > > src/platformtheme/CMakeLists.txt, line 4 > > > > > > This workaround is quite important for 5.3.0 and older at least, maybe > > in those cases we should make i

Re: Review Request 118565: Mark kdelibs4support widgets as deprecated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118565/#review59331 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 5, 2014, 1

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 7, 2014, 1:10 p.m., David Faure wrote: > > Very nice. > > > > The question of "why not in Qt" hasn't been answered though :) > > Aurélien Gâteau wrote: > If you think this has a chance to get in, I can propose it. I think it would be accepted. I'm at Qt Contributor Summit anyway,

Re: Review Request 118666: Simple Cleanups

onf_update/kconfigutils.cpp <https://git.reviewboard.kde.org/r/118666/#comment41659> "" -> QString() - Aleix Pol Gonzalez On June 11, 2014, 1:59 p.m., Thomas Braxton wrote: > > --- > This is an automatically generate

Re: Review Request 118680: Reorder Tests

g/r/118680/#comment41688> Why did you need to create a separate call to ecm_add_test? If it's for the target_include_directories, you can still do it to an ecm_add_tests created target. - Aleix Pol Gonzalez On June 11, 2014, 11:04 p.m., Thomas Br

Re: Review Request 118666: Simple Cleanups

> On June 11, 2014, 2:44 p.m., Aleix Pol Gonzalez wrote: > > src/core/kconfiggroup.cpp, line 205 > > <https://git.reviewboard.kde.org/r/118666/diff/1/?file=280266#file280266line205> > > > > shouldn't this be translated? > > Thomas Braxton wrot

Re: Review Request 118666: Simple Cleanups

r, so go for it! :) - Aleix Pol Gonzalez On June 12, 2014, 12:34 a.m., Thomas Braxton wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 118692: Fix reading of entries for language/country combinations

g/r/118692/#comment41709> Is it really like that? I think the catalan locale is es_CA, and the short representation we use is "ca". - Aleix Pol Gonzalez On June 12, 2014, 9:41 a.m., Martin Gräßlin wrote: > > --

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 12, 2014, 12:54 p.m., Aleix Pol Gonzalez wrote: > > src/core/kconfigini.cpp, line 79 > > <https://git.reviewboard.kde.org/r/118692/diff/1/?file=280469#file280469line79> > > > > Is it really like that? > > > > I thi

Re: Review Request 118639: KCMultiDialog: Fix crash when clicking OK

? - Aleix Pol Gonzalez On June 10, 2014, 8:45 p.m., Aurélien Gâteau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 118680: Reorder Tests

> On June 12, 2014, 10:07 a.m., Aleix Pol Gonzalez wrote: > > autotests/CMakeLists.txt, line 53 > > <https://git.reviewboard.kde.org/r/118680/diff/1/?file=280375#file280375line53> > > > > Why did you need to create a separate call to ecm_add_test?

Re: Review Request 118680: Reorder Tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118680/#review60014 --- Ship it! Seems good to me. - Aleix Pol Gonzalez On June

Re: Review Request 118614: Make KIO thread-safe

sens to me. I'd like to see it in, this way we don't need to do weird things to use KIO from QtQuick, for starters. - Aleix Pol Gonzalez On June 8, 2014, 10:11 a.m., David Faure wrote: > > --- > This is an automatical

Re: Review Request 118690: Introduce a KLocalizedTranslator

> On June 12, 2014, 11:06 p.m., Albert Astals Cid wrote: > > What's the use case? Didn't we have a different way for translating ui > > files? > > Martin Gräßlin wrote: > > What's the use case? > > well as explained in the comment for translating dynamically loaded UI > files. Whe

Re: Review Request 118690: Introduce a KLocalizedTranslator

t could provide something to reduce the boilerplate > elements (addContextToMonitor and language change events). > > Albert Astals Cid wrote: > I can understand the use case for dynamically loaded .ui files. > > For static ones I thought we were using "uic -tr i18n"

Re: Review Request 118838: Don't require mandatory subText in tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118838/#review60512 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 19, 2014

Re: Review Request 118366: Porting keyboard module to Framework5

7;t do coding style changes while coding. - Aleix Pol Gonzalez On June 19, 2014, 6:48 p.m., shivam makkar wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 112449: Move KUnitConverter files to src/

://git.reviewboard.kde.org/r/112449/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112450: Move KScanDialog to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112450/#review39171 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Sept. 2

Review Request 112451: Actually install the modules in the ecm attic

x27;m missing something. Please tell me if that's the case. Diffs - CMakeLists.txt 5a22f85 attic/modules/CMakeLists.txt c832bed Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Po

Re: Review Request 112451: Actually install the modules in the ecm attic

to be polished... Why does it even have a CMakeLists.txt file then? - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39177 --

Review Request 112457: Start cleanup of KDocTools

has no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112401: Let ki18n report the list of available translations of the application

approved. - Aleix Pol Gonzalez On Sept. 1, 2013, 12:22 p.m., Chusslove Illich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 112451: Actually install the modules in the ecm attic

Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112457: Start cleanup of KDocTools

locally, I'll push it once we have a way to find DocBook from ECM. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112457/#review39242 --------

Review Request 112485: Cleaning up KCompletion

Diffs - staging/kcompletion/src/klineedit.cpp b2b430d staging/kcompletion/src/config-kcompletion.h.cmake 35b64a2 staging/kcompletion/src/CMakeLists.txt f08a47d staging/kcompletion/src/klineedit_p.h 4d3cfbc Diff: http://git.reviewboard.kde.org/r/112485/diff/ Testing --- builds,

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

-modules/FindDocBookXSL.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

. Diffs (updated) - attic/modules/FindDocBookXML.cmake 26053bf attic/modules/FindDocBookXSL.cmake ab93c9e Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

for KF5. Diffs (updated) - attic/modules/FindDocBookXML.cmake attic/modules/FindDocBookXSL.cmake Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 112525: Properly check for QtNetwork/QSslSocket

KDE Frameworks. Description --- Don't use QT_INCLUDES, it's not available for Qt5. I have no idea why we didn't trigger that before. Diffs - staging/kde4support/src/ConfigureChecks.cmake 578277c Diff: http://git.reviewboard.kde.org/r/112525/diff/ Testing ---

Review Request 112525: Properly check for QtNetwork/QSslSocket

t use QT_INCLUDES, it's not available for Qt5. I have no idea why we didn't trigger that before. Diffs - staging/kde4support/src/ConfigureChecks.cmake 578277c Diff: http://git.reviewboard.kde.org/r/112525/diff/ Testing --- Thanks, Ale

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

ed e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39371 ----------- On Sept. 4, 2013, 2:50 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an a

Review Request 112536: Move KUnitConversion to tier2

/r/112536/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112536: Move KUnitConversion to tier2

/src/velocity.h staging/kunitconversion/src/velocity.cpp staging/kunitconversion/src/volume.h staging/kunitconversion/src/volume.cpp tier2/CMakeLists.txt 1f110e8 Diff: http://git.reviewboard.kde.org/r/112536/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez

Re: Review Request 112536: Move KUnitConversion to tier2

staging/kunitconversion/src/volume.h staging/kunitconversion/src/volume.cpp tier2/CMakeLists.txt 1f110e8 Diff: http://git.reviewboard.kde.org/r/112536/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Re: Review Request 112525: Properly check for QtNetwork/QSslSocket

board.kde.org/r/112525/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112545: Unify both meinproc5 binaries

ilds, both ways. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112570: Port some kde4_add_executable usages to add_executable

/tests/CMakeLists.txt 5e0d46e Diff: http://git.reviewboard.kde.org/r/112570/diff/ Testing --- Builds, although it doesn't change much in linux. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 112560: Remove KNotification dependency in KCompletion

staging/kcompletion/src/kcompletion.cpp bcd220a staging/kcompletion/src/khistorycombobox.cpp fe955a2 Diff: http://git.reviewboard.kde.org/r/112560/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

ing Qt5::Core and you don't need a ${variable}. BTW, are you sure that many publicly linked libraries are needed? - Aleix Pol Gonzalez On Sept. 7, 2013, 7:45 p.m., David Edmundson wrote: > > --- > This is an autom

Re: Review Request 112545: Unify both meinproc5 binaries

staging/kdoctools/src/CMakeLists.txt 72bb06e staging/kdoctools/src/meinproc.cpp 5d476f6 staging/kdoctools/src/meinproc_simple.cpp 334f13f Diff: http://git.reviewboard.kde.org/r/112545/diff/ Testing --- Builds, both ways. Thanks, Ale

<    5   6   7   8   9   10   11   12   13   14   >