---
On Nov. 11, 2013, 3:23 a.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113723
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113723/#review43411
---
On Nov. 11, 2013, 3:23 a.m., Aleix Pol Gonzalez wrote
/KDocToolsConfig.cmake.in PRE-CREATION
tier2/kdoctools/src/CMakeLists.txt 3940e98
Diff: http://git.reviewboard.kde.org/r/113723/diff/
Testing
---
Builds, Installs, tests still pass; both modularized and monolithic kdelibs.
Thanks,
Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/113795/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/KDocToolsConfig.cmake.in PRE-CREATION
tier2/kdoctools/src/CMakeLists.txt 3940e98
Diff: http://git.reviewboard.kde.org/r/113723/diff/
Testing
---
Builds, Installs, tests still pass; both modularized and monolithic kdelibs.
Thanks,
Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/113695/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/113694/diff/
Testing
---
Builds and installs. All tests are commented out.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Diff: http://git.reviewboard.kde.org/r/113693/diff/
Testing
---
Builds, installs, the test seems to work.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
staging/kio/src/core/job_p.h 55c00fa
staging/kio/src/core/jobclasses.h fb5051c
Diff: http://git.reviewboard.kde.org/r/113795/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
it explained somehow. Why
is it bad to define such values? How will g++ calls compare?
- Aleix Pol Gonzalez
On Nov. 11, 2013, 10:16 p.m., Sune Vuorela wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
On Nov. 12, 2013, 12:02 a.m., Aleix Pol Gonzalez wrote:
Maybe I've missed something, but I would like to have it explained somehow.
Why is it bad to define such values? How will g++ calls compare?
Nicolás Alvarez wrote:
In normal CMake, -DCMAKE_BUILD_TYPE=Debug builds without
to review the rest of
documentation files.
Also some guidelines might be useful as well.
- Aleix Pol Gonzalez
On Nov. 12, 2013, 10:10 a.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113818/#review43527
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 12, 2013, 3
by one is annoying.
- Aleix Pol Gonzalez
On Nov. 7, 2013, 2:42 p.m., Aurélien Gâteau wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113506
Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113683/#review43555
---
Ship it!
No, if it works just push it.
- Aleix Pol Gonzalez
---
On Nov. 12, 2013, 6:46 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113821
On Nov. 12, 2013, 5:11 p.m., Aleix Pol Gonzalez wrote:
CMakeLists.txt, line 18
http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18
I don't think we want that, superbuild shouldn't be used after the
splitting but the kde build script. We will need
On Nov. 12, 2013, 5:11 p.m., Aleix Pol Gonzalez wrote:
CMakeLists.txt, line 18
http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18
I don't think we want that, superbuild shouldn't be used after the
splitting but the kde build script. We will need
builds, couldn't test since I didn't see any test.
Tests still pass though.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
, no?
- Aleix Pol Gonzalez
On Nov. 13, 2013, 5:16 p.m., Jeremy Whiting wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113844
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113844/#review43621
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 13, 2013, 6
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113867/#review43690
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 14, 2013, 6
the Data pointer was
before. It's only defined for one class but both have it as a member?
It was used as a d-ptr only for some members?
- Aleix Pol Gonzalez
On Nov. 15, 2013, 12:20 p.m., Alex Merry wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113882/#review43728
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 15, 2013
been bumping to 5...
- Aleix Pol Gonzalez
On Nov. 15, 2013, 12:22 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113883
/diff/
Testing
---
Nothing stopped building.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/kde4support/cmake/modules/KDE4Macros.cmake 6a63e5e
Diff: http://git.reviewboard.kde.org/r/113887/diff/
Testing
---
Nothing stopped building.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
/CMakeLists.txt 4ef0a9b
tier3/kio/src/CMakeLists.txt 3800e85
tier3/kprintutils/src/CMakeLists.txt da0b7d5
tier4/kde4support/src/CMakeLists.txt 9046c96
Diff: http://git.reviewboard.kde.org/r/113863/diff/
Testing
---
still builds.
Thanks,
Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113972/#review44084
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 21, 2013
/CMakeLists.txt 9223ccf
tier3/kiconthemes/src/CMakeLists.txt 4b3c978
Diff: http://git.reviewboard.kde.org/r/113996/diff/
Testing
---
FrameworksIntegration builds modularized, monolithic kdelibs still build as
well.
Thanks,
Aleix Pol Gonzalez
___
Kde
---
Builds, tests still pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kbuildsycoca5 use it and made sure it works.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/114003/diff/
Testing
---
Builds, tests still pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Diff: http://git.reviewboard.kde.org/r/113975/diff/
Testing
---
Everything still builds.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
9a731fd
tier4/kde4support/src/kio/kmimetyperesolver.h 515dcfb
tier4/kde4support/src/kio/kmimetyperesolver.cpp 69e64fd
tier4/kde4support/tests/CMakeLists.txt 7705381
Diff: http://git.reviewboard.kde.org/r/114003/diff/
Testing
---
Builds, tests still pass.
Thanks,
Aleix Pol Gonzalez
builds modularized, monolithic kdelibs still build as
well.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
05019ad
Diff: http://git.reviewboard.kde.org/r/114038/diff/
Testing
---
Made kbuildsycoca5 use it and made sure it works.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
---
On Nov. 22, 2013, 6:07 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114038
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114272/#review45042
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 3, 2013, 2
/diff/
Testing
---
Created a test app that instantiates a QFileDialog, used a QFileDialog from
systemsettings.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
/platformtheme/kdeplatformtheme.h 69f1f44
tier4/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp 010eed4
Diff: http://git.reviewboard.kde.org/r/114185/diff/
Testing
---
Works with the kfontrequestertest.
Thanks,
Aleix Pol Gonzalez
___
Kde
://git.reviewboard.kde.org/r/114356/#comment32420
Shouldn't that file be called KGlobalAccelConfig.cmake.in?
We're not prefixing the rest of modules with KF5, right?
- Aleix Pol Gonzalez
On Dec. 10, 2013, 6:41 a.m., Martin Gräßlin wrote
to remove this comment-
kioslave/smb/kio_smb_internal.cpp
http://git.reviewboard.kde.org/r/112463/#comment32427
Does it really need QDir::separator()? It seems to me like everything
should be '/'.
- Aleix Pol Gonzalez
On Dec. 5, 2013, 11:44 p.m., Mark Gaiser wrote
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45520
---
Ship it!
- Aleix Pol Gonzalez
On Dec. 10, 2013, 6:51 p.m
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114447/#review45683
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 14, 2013, 3
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114501/#review45802
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 16, 2013, 5
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114502/#review45801
---
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On Dec. 16
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114683/#review46193
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 27, 2013
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114716/#review46422
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 29, 2013
://git.reviewboard.kde.org/r/114937/#comment33590
directoryName is not used now?
- Aleix Pol Gonzalez
On Jan. 10, 2014, 4:03 p.m., Bhushan Shah wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://git.reviewboard.kde.org/r/115016/diff/
Testing
---
Everything still builds, shouldn't be a big deal.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
On Jan. 14, 2014, 8:16 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115016
the now defunct Kross KJS
support).
https://git.reviewboard.kde.org/r/115027/
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
and check if it succeeded.
Diffs
-
src/lib/jobs/kjob.h 24dbaec
Diff: https://git.reviewboard.kde.org/r/115016/diff/
Testing
---
Everything still builds, shouldn't be a big deal.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
://git.reviewboard.kde.org/r/115049/#comment33759
This limits the cwd. Maybe you can pass it as a preprocess definition?
aka with add_definitions(-DKTRANSCRIPT_PATH=${blah}) ).
- Aleix Pol Gonzalez
On Jan. 16, 2014, 11:07 a.m., Aurélien Gâteau wrote
., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115030/
---
(Updated Jan. 16, 2014, 2:33 p.m.)
Review
the source compatibility, but then it improves the API
considerably.
- Aleix Pol Gonzalez
On Jan. 16, 2014, 1:28 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
src/kjsembed/pointer.h e25a5e4
Diff: https://git.reviewboard.kde.org/r/115030/diff/
Testing
---
I ported the share dataengine to use it (it was using the now defunct Kross KJS
support).
https://git.reviewboard.kde.org/r/115027/
Thanks,
Aleix Pol Gonzalez
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote:
KF5DocToolsMacros.cmake, lines 166-172
https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166
These should *not* be renamed, as they are compatibility macros.
However, they should probably be moved to
5a7f4c8
Diff: https://git.reviewboard.kde.org/r/115198/diff/
Testing
---
Builds.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/#comment33948
What's the problem with finding documentation on windows?
- Aleix Pol Gonzalez
On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115199/#review47959
---
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On Jan
/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ported because I
ported them.
OTOH, there will be non-ported applications, that's why we provide this warning.
- Aleix Pol Gonzalez
On Jan. 22, 2014, 7:01 a.m., David Narváez wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115211/#review47996
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 22, 2014
it.
I'm unsure what's the best way though.
Diffs
-
src/kdeui/kapplication.cpp 5a7f4c8
Diff: https://git.reviewboard.kde.org/r/115198/diff/
Testing
---
Builds.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde
On Jan. 22, 2014, 11:32 a.m., Aleix Pol Gonzalez wrote:
Well, but frameworks are not only for frameworks. They're all ported
because I ported them.
OTOH, there will be non-ported applications, that's why we provide this
warning.
Luigi Toscano wrote:
You ported
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115213/#review48003
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 22, 2014
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote:
This seems sensible to me; however, I do wonder if ECM should also provide
an ecm_mark_gui_executable function as well (I'm thinking of the case where
most of the tests should be non-gui, but a handful want to display widgets).
Well, we
Pol Gonzalez wrote:
Well, we can't change the default, can we?
Alex Merry wrote:
I don't understand what you mean.
If we have a /mark as non gui/ function is because executables are /gui
executables/ by default. Having an ecm_mark_gui_executable() would make this
weird I'd say.
(TBH
://git.reviewboard.kde.org/r/115238/#comment34038
no need for this debug.
Thanks for improving the test, will have to look into the implementation. :)
- Aleix Pol Gonzalez
On Jan. 22, 2014, 10:26 p.m., Gregor Mi wrote:
---
This is an automatically
they already are
deprecated in kdelibs 4.
I don't really like disabling compilation of deprecated symbols, especially in
this case we're not winning that much.
- Aleix Pol Gonzalez
On Jan. 15, 2014, 1:56 p.m., Alex Merry wrote
/#comment34187
Need to use? link against?
Also the (or similar) looks unsure. I would say:
If you are using cmake, you can find KAuth by using:
find_package(KF5Auth NO_MODULE)
or finding KF5 with the Auth component, from your CMake scripts.
- Aleix Pol Gonzalez
On Jan. 26
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115148/#review48326
---
Ship it!
Makes sense to me.
- Aleix Pol Gonzalez
On Jan
the developer that
he did it right, but I wouldn't see it as documentation.
I would rename it to KRecentFilesActionTest
- Aleix Pol Gonzalez
On Jan. 25, 2014, 10:56 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review48347
---
On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115361/#review48489
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 28, 2014
really ugly to have -lc so +1
from me.
- Aleix Pol Gonzalez
On Jan. 28, 2014, 4:41 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115362
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115382/#review48548
---
Ship it!
Cool :)
- Aleix Pol Gonzalez
On Jan. 29, 2014, 3
frameworks, actually.
All this checking if it's being built out of kdelibs doesn't make sense anymore.
- Aleix Pol Gonzalez
On Jan. 31, 2014, 12:03 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115421/#review48815
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 1, 2014, 1
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115477/#review48995
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 4, 2014, 4
://git.reviewboard.kde.org/r/115472/#comment34595
You probably want endsWith(/.icons).
- Aleix Pol Gonzalez
On Feb. 4, 2014, 4:30 p.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115472/#review49019
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 5, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115525/#review49161
---
Ship it!
Looks good to me
- Aleix Pol Gonzalez
On Feb. 6
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115530/#review49177
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 7, 2014, 8
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115616/#review49439
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 10, 2014
/#comment34891
You can instantiate QApplication in the stack, instead of calling
new+delete.
Also you probably want to create it in the beginning of the main function
body.
- Aleix Pol Gonzalez
On Feb. 10, 2014, 4:06 p.m., Martin Gräßlin wrote
On Feb. 10, 2014, 4:14 p.m., Aleix Pol Gonzalez wrote:
drkonqi/main.cpp, line 74
https://git.reviewboard.kde.org/r/115629/diff/1/?file=243089#file243089line74
You can instantiate QApplication in the stack, instead of calling
new+delete.
Also you probably want
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115681/#review49609
---
Ship it!
- Aleix Pol Gonzalez
On Feb. 11, 2014, 9:04 p.m
it as a problem.
This could break compilation on some projects other than KParts, will you be
able to try the rest of the modules?
Thanks for figuring it out!
- Aleix Pol Gonzalez
On Feb. 11, 2014, 10:15 p.m., David Faure wrote
benefits of name-spacing the
desktop files besides feeling different and special. :)
- Aleix Pol Gonzalez
On Feb. 11, 2014, 9:56 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Feb. 19, 2014, 10:06 a.m., Aleix Pol Gonzalez wrote:
src/knotificationmanager.cpp, line 180
https://git.reviewboard.kde.org/r/115695/diff/3/?file=243841#file243841line180
?
Martin Klapetek wrote:
Yet once again the description xD - it's full of ... FIXMEs to indicate
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115634/#review50388
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 20, 2014
to
duplicate information by passing it to the KAboutData _and_ the QApplication.
Diffs (updated)
-
src/lib/kaboutdata.h c9e
src/lib/kaboutdata.cpp c347521
Diff: https://git.reviewboard.kde.org/r/115207/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
/kaboutdata.h c9e
src/lib/kaboutdata.cpp c347521
Diff: https://git.reviewboard.kde.org/r/115207/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116462/#review51729
---
Ship it!
Makes sense to me.
- Aleix Pol Gonzalez
On Feb
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116540/#review51731
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 2, 2014
201 - 300 of 3816 matches
Mail list logo
