://git.reviewboard.kde.org/r/117604/#comment38944
It should be a qWarning.
Looks good to me though, it's very annoying to debug this kind of problems
without feedback. +1
- Aleix Pol Gonzalez
On April 16, 2014, 9:07 p.m., David Jarvie wrote
experience across
frameworks.
- Aleix Pol Gonzalez
On April 16, 2014, 4:53 p.m., Michael Palimaka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117599
On April 23, 2014, 5:09 p.m., David Faure wrote:
The reason I did it this way was because existing application code uses
#include kjsembed/kjsembed.h
#include kjsembed/qobject_binding.h
etc.
See e.g.
http://lxr.kde.org/source/kde/kdelibs/kross/kjs/kjsscript.cpp?v=stable-qt4
Diff: https://git.reviewboard.kde.org/r/117838/diff/
Testing
---
Now my KWin has decorations.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
/kwindecoration/decorationmodel.cpp bb64b46
libkdecorations/kdecoration_plugins_p.cpp 8570b6a
Diff: https://git.reviewboard.kde.org/r/117838/diff/
Testing
---
Now my KWin has decorations.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel
.)
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Repository: kconfigwidgets
Description
---
entry.desktop got renamed, use the renamed file
https://git.reviewboard.kde.org/r/117087/
Diffs
-
src/klanguagebutton.cpp 9f0c055
Diff: https
on a feature in
kdelibs4support. A different solution must be found.
- Aleix Pol Gonzalez
On April 29, 2014, 11:10 a.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117799/#review56963
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On April 26, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117895/#review56965
---
No need to rename the folder, no?
- Aleix Pol Gonzalez
added variables as well...
- Aleix Pol Gonzalez
On April 30, 2014, 3:22 p.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117907
::availableApplicationTranslations?
Or if we want /all/ languages, maybe just QLocale?
Either way, depending on kdelibs4support here is not acceptable.
- Aleix Pol Gonzalez
On April 29, 2014, 11:10 a.m., Jonathan Riddell wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118048/#review57568
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 8, 2014, 9
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118085/#review57735
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 11, 2014, 8
doing such changes remember there's things already ported.
- Aleix Pol Gonzalez
On May 13, 2014, 11:52 p.m., Michael Pyne wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117919
/CMakeLists.txt f1d88d2
Diff: https://git.reviewboard.kde.org/r/118149/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
CMakeLists.txt |
xargs grep kdoctools_create_handbook | grep -v SUBDIR
Maybe kdoctools_create_handbook should fail if it doesn't get a SUBDIR?
- Aleix Pol Gonzalez
On May 15, 2014, 2:40 p.m., Aleix Pol Gonzalez wrote
before but were incorrect.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
the same problem.
Diffs
-
doc/fundamentals/CMakeLists.txt 0921d20
doc/khelpcenter/CMakeLists.txt f1d88d2
Diff: https://git.reviewboard.kde.org/r/118149/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
On May 14, 2014, 10:48 a.m., Aleix Pol Gonzalez wrote:
Note that this broke lots of KAboutData uses.
Please, when doing such changes remember there's things already ported.
Michael Pyne wrote:
Yes, my apologies.
But the pain this change would cause if implemented
://git.reviewboard.kde.org/r/118156/diff/
Testing
---
Makes some builds fail that didn't fail before but were incorrect.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
anything would break with
the change.
Also it's one of those the-sooner-the-better changes, in case somebody plans
to rely on it.
- Aleix Pol Gonzalez
On May 23, 2014, 2:29 p.m., Marco Martin wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118352/#review58573
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 27, 2014, 1
in case of error.
- Aleix Pol Gonzalez
On May 28, 2014, 10:33 a.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118373
/#comment40899
The iconPath call doesn't look trivial. I don't think we want the call
twice, put it in a variable maybe?
Feel free to do it when pushing if you don't want to do another round in
reviewboard.
- Aleix Pol Gonzalez
On May 30, 2014, 8:23 a.m., Martin Klapetek wrote
On May 26, 2014, 8:11 a.m., Àlex Fiestas wrote:
src/platformtheme/CMakeLists.txt, line 4
https://git.reviewboard.kde.org/r/118234/diff/1/?file=273903#file273903line4
This workaround is quite important for 5.3.0 and older at least, maybe
in those cases we should make it mandatory?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118565/#review59331
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 5, 2014, 1
On June 7, 2014, 1:10 p.m., David Faure wrote:
Very nice.
The question of why not in Qt hasn't been answered though :)
Aurélien Gâteau wrote:
If you think this has a chance to get in, I can propose it.
I think it would be accepted. I'm at Qt Contributor Summit anyway, if anybody
://git.reviewboard.kde.org/r/118666/#comment41659
- QString()
- Aleix Pol Gonzalez
On June 11, 2014, 1:59 p.m., Thomas Braxton wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118666
/118680/#comment41688
Why did you need to create a separate call to ecm_add_test?
If it's for the target_include_directories, you can still do it to an
ecm_add_tests created target.
- Aleix Pol Gonzalez
On June 11, 2014, 11:04 p.m., Thomas Braxton wrote
On June 11, 2014, 2:44 p.m., Aleix Pol Gonzalez wrote:
src/core/kconfiggroup.cpp, line 205
https://git.reviewboard.kde.org/r/118666/diff/1/?file=280266#file280266line205
shouldn't this be translated?
Thomas Braxton wrote:
It's an error string, should it?
I guess not, none
/118692/#comment41709
Is it really like that?
I think the catalan locale is es_CA, and the short representation we use is
ca.
- Aleix Pol Gonzalez
On June 12, 2014, 9:41 a.m., Martin Gräßlin wrote
On June 12, 2014, 12:54 p.m., Aleix Pol Gonzalez wrote:
src/core/kconfigini.cpp, line 79
https://git.reviewboard.kde.org/r/118692/diff/1/?file=280469#file280469line79
Is it really like that?
I think the catalan locale is es_CA, and the short representation we
use
?
- Aleix Pol Gonzalez
On June 10, 2014, 8:45 p.m., Aurélien Gâteau wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118639
On June 12, 2014, 10:07 a.m., Aleix Pol Gonzalez wrote:
autotests/CMakeLists.txt, line 53
https://git.reviewboard.kde.org/r/118680/diff/1/?file=280375#file280375line53
Why did you need to create a separate call to ecm_add_test?
If it's for the target_include_directories
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/#review60014
---
Ship it!
Seems good to me.
- Aleix Pol Gonzalez
On June
sens to me.
I'd like to see it in, this way we don't need to do weird things to use KIO
from QtQuick, for starters.
- Aleix Pol Gonzalez
On June 8, 2014, 10:11 a.m., David Faure wrote:
---
This is an automatically generated e-mail
On June 12, 2014, 11:06 p.m., Albert Astals Cid wrote:
What's the use case? Didn't we have a different way for translating ui
files?
Martin Gräßlin wrote:
What's the use case?
well as explained in the comment for translating dynamically loaded UI
files. Where is that
:
I can understand the use case for dynamically loaded .ui files.
For static ones I thought we were using uic -tr i18n, but are we? I
can't find where we do it.
Aleix Pol Gonzalez wrote:
IIRC we were waiting for 5.3 to be released to add that change, it would
be a good moment
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118838/#review60512
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 19, 2014
Pol Gonzalez
On June 19, 2014, 6:48 p.m., shivam makkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118366
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118846/#review60630
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 20, 2014
integrated new
design for the about dialog.
For the moment, I'm good with just changing the picture, but I wouldn't like to
leave it there.
- Aleix Pol Gonzalez
On June 22, 2014, 8:13 p.m., Marco Martin wrote
then?
- Aleix Pol Gonzalez
On June 21, 2014, 12:20 a.m., Nicolás Alvarez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118852
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118906/#review60910
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 23, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118960/#review61278
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 26, 2014
for target kauth_tests_static
- Aleix Pol Gonzalez
On May 28, 2014, 2:01 p.m., Hrvoje Senjan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118264
because the backend is loaded
and it crashes.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On May 28, 2014, 12:56 p.m., Aurélien Gâteau wrote:
Building with polkit-qt-1 master (bac771e69887c9253f2b0973f6310810db0061f8)
fails with this error:
[ 55%] Building CXX object
autotests/CMakeFiles/KAuthHelperTest.dir/HelperTest.cpp.o
In file included from
.
- Aleix Pol Gonzalez
On June 30, 2014, 9:53 p.m., Hrvoje Senjan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043
:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/
---
(Updated June 30, 2014, 9:53 p.m.)
Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and
Christophe Giboudeaux
On June 30, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote:
PolkitQt-1Config.cmake.in, line 24
https://git.reviewboard.kde.org/r/119043/diff/4/?file=285776#file285776line24
Passing the include dir is not needed anymore, given that those will be
pulled by the targets.
I
://git.reviewboard.kde.org/r/119037/diff/
Testing
---
When I launch kcmshell5 clock, I get a crash because the backend is loaded
and it crashes.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
://git.reviewboard.kde.org/r/119037/diff/
Testing
---
When I launch kcmshell5 clock, I get a crash because the backend is loaded
and it crashes.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119067/#review61406
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On July 1, 2014, 4
and Qt5? Porting away frmn
KDELibs4Support and trying to compile both Qt4 and Qt5 is not something we can
do I'd say.
Anyway, I haven't spotted anything obvious, so if that helps you can get it in.
I'm not proficient in that code-base.
- Aleix Pol Gonzalez
On July 3, 2014, 8:48 a.m., Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119110/#review61597
---
I confirm this patch fixes the death lock.
- Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/#review61766
---
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On July 1
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118264/#review61810
---
Ship it!
I guess we can get this one in now?
- Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119189/#review61944
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On July 8, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119186/#review61946
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On July 8, 2014, 9
/119241/#comment43220
Why does it need a static_cast if we're upcasting?
Also constructing a shared pointer from the data field in another one seems
dangerous...
- Aleix Pol Gonzalez
On July 12, 2014, 9:41 a.m., Kevin Funk wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119284/#review62355
---
Ship it!
Thanks!
- Aleix Pol Gonzalez
On July 14, 2014, 9
(.. PARENT_SCOPE)
for appending would do the trick as well?
- Aleix Pol Gonzalez
On July 14, 2014, 6 p.m., Andreas Xavier wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119275
wants numbers. Faster? Less memory consumption?
- Aleix Pol Gonzalez
On July 14, 2014, 2:27 p.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119274
On July 17, 2014, 1:42 p.m., David Edmundson wrote:
src/declarativeimports/core/framesvgitem.cpp, line 434
https://git.reviewboard.kde.org/r/119336/diff/2/?file=290831#file290831line434
How is this whole branch simpler ?
We end up doing widths and sizes twice.
Marco
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119343/#review62602
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On July 17, 2014
addHelpOption and addVersionOption, they're added by
setupCommandLine.
Add KAboutData::setApplicationData(aboutData), though.
Also is it really worth having icons? I guess it's fine, but maybe it could be
skipped.
- Aleix Pol Gonzalez
On July 21, 2014, 4:16 p.m., Jonathan Riddell
as it used in
5.0, so no regressions at least.
It means though, that everything that has composeOverBorders will be rendered
by the CPU rather than the GPU.
- Aleix Pol Gonzalez
On July 22, 2014, 2:24 p.m., David Edmundson wrote
://git.reviewboard.kde.org/r/119409/#comment43590
Missing .
src/scriptengines/qml/plasmoid/appletinterface.cpp
https://git.reviewboard.kde.org/r/119409/#comment43592
Why can't you just call the method? You're not delaying it
- Aleix Pol Gonzalez
On July 22, 2014, 3:40 p.m., Marco Martin
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote:
Forgot to say, I think introducing a X-Plasma-Provides is ok.
I guess that it will contain the concepts it's fulfilling, right? such as:
X-Plasma-Provides=clock
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote:
src
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote:
src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555
https://git.reviewboard.kde.org/r/119409/diff/1/?file=291856#file291856line555
Why can't you just call the method? You're not delaying it
Marco Martin wrote
checking :)
- Aleix Pol Gonzalez
On July 24, 2014, 12:10 a.m., Luigi Toscano wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119447
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119446/#review63103
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On July 24, 2014
Pol Gonzalez
On July 27, 2014, 6:29 p.m., Àlex Fiestas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119505
/119510/#comment44162
Unrelated change, commit separately.
+1, makes sense to me. I'd like a from one of our l10n gurus too. ;)
- Aleix Pol Gonzalez
On July 28, 2014, 2:28 p.m., Lukáš Tinkl wrote:
---
This is an automatically
On July 29, 2014, 11:54 a.m., José Manuel Santamaría Lema wrote:
With the patch as is it doesn't build for me with Qt 5 but I could fix it
changing this couple of things in the resulting CMakeLists.txt after
applying the current patch:
- removing the use of
KCoreAddons should only depend on QtCore, but then we can make it an
optional dependency. If Qt5::Qml is there, then build the Qml plugin too.
- Aleix Pol Gonzalez
On July 29, 2014, 2:31 p.m., Sebastian Kügler wrote
On July 29, 2014, 4:34 p.m., Bhushan Shah wrote:
src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44
https://git.reviewboard.kde.org/r/119535/diff/1/?file=294241#file294241line44
Maybe consider creating it a singleton type?
Why? In fact, I think it's usually harder to deal
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119560/#review63619
---
What happened here? Is it actually submitted?
- Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119560/#review63620
---
What happened here? Is it actually submitted?
- Aleix Pol
running Plasma 5...
Actually, frameworksintegration should move to kde/workspace at least. It's not
a framework.
- Aleix Pol Gonzalez
On Aug. 1, 2014, 2:29 p.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail
On Aug. 1, 2014, 2:31 p.m., Aleix Pol Gonzalez wrote:
Well, you only get the frameworks integration when you're running Plasma
5...
Actually, frameworksintegration should move to kde/workspace at least. It's
not a framework.
Martin Klapetek wrote:
Well the message boxes
?
Maybe you forgot some git mv?
- Aleix Pol Gonzalez
On Feb. 10, 2013, 8:40 p.m., Martin Tobias Holmedahl Sandsmark wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107791
PRE-CREATION
staging/kde4support/src/kdeui/ktoolbarspaceraction.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/110674/diff/
Testing
---
Builds and installs fine.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde
Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/k3b-spaceraction.png
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
::addSeparator()
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-nospaceraction.png
KToolBarSpacerAction
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-spaceraction.png
Thanks,
Aleix Pol Gonzalez
___
Kde
addSeparator is enough indeed.
Anyway - please always add @deprecated since 5.0 and the suggested
replacement, for the benefit of people porting the code.
Aleix Pol Gonzalez wrote:
This is tricky, QToolBar does a different thing, it adds a visible
separator in the toolbar instead
KToolBarSpacerAction
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-spaceraction.png
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
, the test seems to work
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/kratingwidget.h PRE-CREATION
tier1/kwidgetsaddons/src/kratingwidget.cpp PRE-CREATION
tier1/kwidgetsaddons/tests/CMakeLists.txt bd00be8
tier1/kwidgetsaddons/tests/kratingwidgettest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/110826/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
/kurlrequester.h 0b07373
tier1/kwidgetsaddons/src/CMakeLists.txt 9802467
tier1/kwidgetsaddons/tests/CMakeLists.txt bd00be8
Diff: http://git.reviewboard.kde.org/r/110825/diff/
Testing
---
everything builds, the test seems to work
Thanks,
Aleix Pol Gonzalez
: http://git.reviewboard.kde.org/r/110825/diff/
Testing
---
everything builds, the test seems to work
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
Diff: http://git.reviewboard.kde.org/r/110826/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/kwidgetsaddons/src/kcursor.cpp PRE-CREATION
tier1/kwidgetsaddons/src/kcursor_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/110827/diff/
Testing
---
builds fine
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks
/utils/kglobalsettings.h 5fb1d9b
staging/kwidgets/src/utils/kglobalsettings.cpp 53b648e
Diff: http://git.reviewboard.kde.org/r/110833/diff/
Testing
---
it builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks
/kiconloader.cpp 795ec93
staging/kwidgets/src/utils/kglobalsettings.h 5fb1d9b
staging/kwidgets/src/utils/kglobalsettings.cpp 53b648e
Diff: http://git.reviewboard.kde.org/r/110833/diff/
Testing
---
it builds
Thanks,
Aleix Pol Gonzalez
___
Kde
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110674/#review33795
---
ping!
- Aleix Pol Gonzalez
On June 3, 2013, 4:08 p.m
af65f34
tier1/kwidgetsaddons/tests/CMakeLists.txt 85a8732
tier1/kwidgetsaddons/tests/kpassivepopuptest.h PRE-CREATION
tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/110815/diff/
Testing
---
It builds fine
Thanks,
Aleix Pol
and installs fine.
File Attachments
::addSeparator()
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-nospaceraction.png
KToolBarSpacerAction
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-spaceraction.png
Thanks,
Aleix Pol Gonzalez
401 - 500 of 3816 matches
Mail list logo
