Re: Review Request 122204: Mark results as required.

2015-01-22 Thread Aleix Pol Gonzalez
On Jan. 23, 2015, 12:11 a.m., Aleix Pol Gonzalez wrote: +1 This change is not source-compatible though... 8-) or is it? Milian Wolff wrote: It's _meant_ to be source-incompatible. All places where it doesn't compile are doing it wrong™. If you mean abi-incompatible

Re: Review Request 122180: [KUnitConversion] Unit::setUnitMultiplier: Do not call oneself

2015-01-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122180/#review74480 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 21, 2015

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-11 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122514/diff/ Testing --- Builds, tests still pass. Now KDevelop boots correctly, I tried to add a test, but I don't know where's the service type file for KService/NSA. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Re: Review Request 122526: Add Debian path to search for qtwaylandscanner

2015-02-11 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122526/#comment52364 You want to use HINTS instead of PATHS. Also wouldn't it make sense to have QtWayland exporting the scanner as a target? - Aleix Pol Gonzalez On Feb. 11, 2015, 2:39 p.m., Jonathan Riddell wrote

Re: Review Request 122453: Improve KPeople documentation, in order to become a Framework

2015-02-11 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122453/diff/ Testing --- Unit tests still pass ;). Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-10 Thread Aleix Pol Gonzalez
, but I don't know where's the service type file for KService/NSA. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122539: Use Q_DECL_OVERRIDE where possible

2015-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122539/#review75897 --- +1 and +1 to the script. - Aleix Pol Gonzalez On Feb. 12

Re: Review Request 122462: [KCompletion] Fix typos in documentation

2015-02-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/#review76203 --- +1 Looks good to me. - Aleix Pol Gonzalez On Feb. 8, 2015

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/#review75956 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 12, 2015

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review75983 --- +1 What's the status of QtSpeech? - Aleix Pol Gonzalez

Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback

2015-02-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/#review76195 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 17, 2015

Re: Review Request 122642: an include is not correct

2015-02-19 Thread Aleix Pol Gonzalez
changed. - Aleix Pol Gonzalez On Feb. 19, 2015, 7:11 p.m., Guy Maurel wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122642

Re: Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.

2015-01-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/#review73609 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 9, 2015, 3

Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-09 Thread Aleix Pol Gonzalez
. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-09 Thread Aleix Pol Gonzalez
/ktoolbarhandler.cpp 83c77bd src/kxmlgui.xsd bca02f1 Diff: https://git.reviewboard.kde.org/r/121952/diff/ Testing --- Fixes the attached bug, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.

2015-01-09 Thread Aleix Pol Gonzalez
parameter? It doesn't look like it needs to be re-used so it's fine like that as well. - Aleix Pol Gonzalez On Jan. 9, 2015, 4:33 p.m., Elias Probst wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-06 Thread Aleix Pol Gonzalez
/#comment50989 Unrelated. And why? Other than that, +1. - Aleix Pol Gonzalez On Jan. 6, 2015, 11:55 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121952/#review73670 --- On Jan. 9, 2015, 4:27 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-12 Thread Aleix Pol Gonzalez
bca02f1 Diff: https://git.reviewboard.kde.org/r/121952/diff/ Testing --- Fixes the attached bug, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 122495: CMake nitpicking on KDiagram

2015-02-09 Thread Aleix Pol Gonzalez
builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122487: Reorder member variables to reduce memory usage.

2015-02-08 Thread Aleix Pol Gonzalez
On Feb. 8, 2015, 9:45 p.m., David Faure wrote: Which magic tool did you come up with this time, to detect such things? :-) +1 :D I too want to know! - Aleix --- This is an automatically generated e-mail. To reply, visit:

Review Request 122562: Add method for converting from QVariant to base64

2015-02-13 Thread Aleix Pol Gonzalez
src/qmlcontrols/kquickcontrolsaddons/clipboard.h ac89b9d Diff: https://git.reviewboard.kde.org/r/122562/diff/ Testing --- Adopted locally in my QuickShare plasmoid implementation Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list

Re: Review Request 122453: Improve KPeople documentation, in order to become a Framework

2015-02-11 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122453/diff/ Testing --- Unit tests still pass ;). Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-12 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122514/diff/ Testing --- Builds, tests still pass. Now KDevelop boots correctly, I tried to add a test, but I don't know where's the service type file for KService/NSA. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks

Re: Review Request 122576: Introduce KMoreTools

2015-02-16 Thread Aleix Pol Gonzalez
/#comment52515 I don't think this class is enough reason to make KService depend on QtWidgets. tests/kmoretools/kmoretoolstest.cpp https://git.reviewboard.kde.org/r/122576/#comment52516 // ...? I like the feature though, I'm sure we'll be able to find it the correct spot. - Aleix Pol

Re: Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Aleix Pol Gonzalez
! Did you forget to git add the file? - Aleix Pol Gonzalez On Jan. 4, 2015, 3:21 p.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121834

Re: Review Request 121836: remove autotests/dynamictreemodel.h

2015-01-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121836/#review73098 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 4, 2015, 3

Re: Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121834/#review73105 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 5, 2015

Re: Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Aleix Pol Gonzalez
- src/kioexec/CMakeLists.txt 1f08845 Diff: https://git.reviewboard.kde.org/r/121895/diff/ Testing --- Now it builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 121907: Small code review

2015-01-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121907/#review73461 --- On Jan. 8, 2015, 2:08 a.m., Aleix Pol Gonzalez wrote

Re: Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread Aleix Pol Gonzalez
a logging_conf if they prefer. Aleix Pol Gonzalez wrote: I'm unsure how to do that. Ideas? Martin Klapetek wrote: Maybe just replace it with QLoggingCategory::setFilterRules(*.debug=false) in main? That still gives QT_LOGGING_CONF and QT_LOGGING_RULES to overwrite it. That's

Review Request 121907: Small code review

2015-01-07 Thread Aleix Pol Gonzalez
/diff/ Testing --- Test still passes, if I don't remove teh ~/.qt-test as discussed in the kde-frameworks list. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread Aleix Pol Gonzalez
--- On Jan. 7, 2015, 5:57 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121903

Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread Aleix Pol Gonzalez
though. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Aleix Pol Gonzalez
/121895/diff/ Testing --- Now it builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122960: Let KXmlGui be useable w/o searching for private deps

2015-03-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122960/#review77492 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 14, 2015

Re: Review Request 122958: Let KTextWidgets be useable w/o searching for private deps

2015-03-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122958/#review77491 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 14, 2015

Re: Review Request 122957: Let KService be useable w/o searching for private deps

2015-03-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122957/#review77490 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 14, 2015

Re: Review Request 122848: Drop all find_dependancy calls from KDED cmake config

2015-03-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122848/#review77487 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 14, 2015

Re: Review Request 122956: Let KParts be useable w/o searching for private deps

2015-03-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122956/#review77489 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 14, 2015

Re: Review Request 122951: Let KEmoticons be useable w/o searching for private deps

2015-03-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122951/#review77488 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 14, 2015

Re: Review Request 122206: [kio] Make tests optional

2015-03-18 Thread Aleix Pol Gonzalez
On March 17, 2015, 4:37 a.m., Albert Vaca Cintora wrote: I know this is merged already but this patch is being applied to every KDE package and I want to keep the discussion in a single place. We already have a toggle option in CMake that is BUILD_TESTING. If Gentoo wants to not

Re: Review Request 122828: Be more explicit regarding KBookmarks deps

2015-03-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122828/#review77698 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 5, 2015

Re: Review Request 123032: Search for public dep in KPeople's cmake config

2015-03-18 Thread Aleix Pol Gonzalez
this is correct... - Aleix Pol Gonzalez On March 18, 2015, 6:34 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123032

Re: Review Request 122844: Let KPty be useable w/o searching for private deps

2015-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122844/#review77140 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 6, 2015

Re: Review Request 122848: Make KDED's config search for KDBusAddons

2015-03-06 Thread Aleix Pol Gonzalez
it the application only? - Aleix Pol Gonzalez On March 6, 2015, 9:42 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122848

Re: Review Request 122847: Let KConfigWidgets be useable w/o searching for private deps

2015-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122847/#review77138 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 6, 2015

Re: Review Request 122848: Make KDED's config search for KDBusAddons

2015-03-06 Thread Aleix Pol Gonzalez
On March 7, 2015, 12:46 a.m., Aleix Pol Gonzalez wrote: What's the purpose of looking for KDED? Isn't it the application only? Hrvoje Senjan wrote: only 2 uses i know are within plasma-desktop and kde-baseapps, to get KDED_DBUS_INTERFACE variable... Ok then why look for anything

Re: Review Request 122845: Let KUnitConversion be useable w/o searching for private deps

2015-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122845/#review77141 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 6, 2015

Re: Review Request 122846: Let KCMUtils be useable w/o searching for private deps

2015-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122846/#review77139 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 6, 2015

Re: Review Request 122876: Delay notifications a bit on Plasma startup

2015-03-09 Thread Aleix Pol Gonzalez
? (We do that, right? show the notifications after going out of lock). Having a timer is kind of hacky... - Aleix Pol Gonzalez On March 9, 2015, 8:03 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 122832: Let KDocTools be useable w/o searching for private deps

2015-03-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122832/#review77075 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 5, 2015

Re: Review Request 122832: Let KDocTools be useable w/o searching for private deps

2015-03-05 Thread Aleix Pol Gonzalez
On March 6, 2015, 12:10 a.m., Luigi Toscano wrote: I'm not exactly a cmake expert, is it about the exported symbols of KDocTools? It's not needed, it's mainly so that when a project is compiled, you still know what include directories to use. - Aleix

Re: Review Request 122829: Let KCompletion be useable w/o searching for private deps

2015-03-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122829/#review77072 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 5, 2015

Re: Review Request 122833: Let KJobWidgets be useable w/o searching for private deps

2015-03-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122833/#review77074 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 5, 2015

Re: Review Request 122828: Be more explicit regarding KBookmarks deps

2015-03-05 Thread Aleix Pol Gonzalez
/#comment52973 The find_package shouldn't change, why does it need KConfig now? Isn't it pulled by KConfigWidgets? +1. Removing an include has happened before in a couple of places already, both in Qt and KF5. I don't think it's a big problem. - Aleix Pol Gonzalez On March 5, 2015, 8:41 p.m

Re: Review Request 122830: Let KCrash be useable w/o searching for private deps

2015-03-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122830/#review77073 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 5, 2015

Re: Review Request 122843: Remove redundant build interface.

2015-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122843/#review77120 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 6, 2015

Re: Review Request 122843: Mark QuickAddons as its own project.

2015-03-06 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122843/#comment52991 Isn't this redundant, then? - Aleix Pol Gonzalez On March 6, 2015, 5:07 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 122843: Mark QuickAddons as its own project.

2015-03-06 Thread Aleix Pol Gonzalez
On March 6, 2015, 5:17 p.m., Aleix Pol Gonzalez wrote: src/quickaddons/CMakeLists.txt, line 22 https://git.reviewboard.kde.org/r/122843/diff/1/?file=353379#file353379line22 Isn't this redundant, then? Michael Palimaka wrote: It builds fine with it removed. I don't know

Re: Review Request 122900: KPluginSelector to provide initialization arguments for the configuration modules

2015-03-13 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122900/diff/ Testing --- Tested over at kdeconnect, where we need this. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122900: KPluginSelector to provide initialization arguments for the configuration modules

2015-03-10 Thread Aleix Pol Gonzalez
/kpluginselector.cpp 98ab59e src/kpluginselector_p.h d80cd2e Diff: https://git.reviewboard.kde.org/r/122900/diff/ Testing --- Tested over at kdeconnect, where we need this. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 122913: Added an event() version that takes no icon and will use a default one

2015-03-12 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122913/#comment53119 Those should be QStringLiteral, as you are constructing a QString. - Aleix Pol Gonzalez On March 12, 2015, 4:37 a.m., Albert Vaca Cintora wrote: --- This is an automatically generated e-mail

Re: Review Request 122149: Fix QCommandLineParser warnings in kcmshell5

2015-04-01 Thread Aleix Pol Gonzalez
to do any further engineering or that's good enough. Diffs - kcmshell/main.cpp 98e646b Diff: https://git.reviewboard.kde.org/r/122149/diff/ Testing --- Ran it again, now it doesn't complain. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks

Re: Review Request 122788: Fix kdoctools_encode_uri() cmake macro call

2015-03-03 Thread Aleix Pol Gonzalez
/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122792: Add test app for showing KUrlNavigator

2015-03-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122792/#review76956 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 3, 2015

Re: Review Request 122793: Fix KUrlNavigator with high DPI pixmaps

2015-03-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122793/#review76957 --- +1 - Aleix Pol Gonzalez On March 3, 2015, 5:37 p.m., David

Re: Review Request 122776: Add test for qimageitem

2015-03-02 Thread Aleix Pol Gonzalez
- Aleix Pol Gonzalez On March 2, 2015, 3:49 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122776

Re: Review Request 122775: Make QImageItem handle non default devicePixelRatios

2015-03-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122775/#review76893 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 2, 2015

Re: Review Request 122774: Fix logic error in qpixmap/image item

2015-03-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122774/#review76895 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 2, 2015

Review Request 122741: Prefer exposing lists to QML with QJsonArray

2015-02-27 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/122741/diff/ Testing --- QuickShare plasmoid can use now DeclarativeMimeData. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122795: Fix crashes when attempting to load invalid package

2015-03-03 Thread Aleix Pol Gonzalez
loading? - Aleix Pol Gonzalez On March 3, 2015, 8:32 p.m., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122795

Re: Review Request 122796: Print a warning message when loading an invalid KDeclarative::QmlObject

2015-03-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122796/#review76972 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 3, 2015

Re: Review Request 122755: Add testcases for KIO::del()

2015-02-28 Thread Aleix Pol Gonzalez
? autotests/deletejobtest.cpp https://git.reviewboard.kde.org/r/122755/#comment52862 Would it be better to use the unicode escaping? This can look weird in some set ups? - Aleix Pol Gonzalez On Feb. 28, 2015, 10:21 p.m., Martin Blumenstingl wrote

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-01 Thread Aleix Pol Gonzalez
/122680/#comment52886 Typo, you added a 0. Should we be using ::tr here instead of not translating at all? - Aleix Pol Gonzalez On March 2, 2015, 4:52 a.m., Jerome Leclanche wrote: --- This is an automatically generated e-mail. To reply

Review Request 122788: Fix kdoctools_encode_uri() cmake macro call

2015-03-03 Thread Aleix Pol Gonzalez
: kdoctools Description --- It takes a variable reference rather than a value, so it can provide some output. Diffs - src/CMakeLists.txt 468e450 Diff: https://git.reviewboard.kde.org/r/122788/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-02-23 Thread Aleix Pol Gonzalez
anymore and we can have different kinds of applications. I like where this is going! :) - Aleix Pol Gonzalez On Feb. 21, 2015, 7:26 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-02-25 Thread Aleix Pol Gonzalez
On Feb. 23, 2015, 12:08 p.m., Marco Martin wrote: I like where this is going! :) Marco Martin wrote: One thing i'm still not sure is what to export to it. it now sets the application commandline arguments, that's not really possible to obtain otherwise. Another thing would

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-02-25 Thread Aleix Pol Gonzalez
/#comment52767 You can add the comments there as well, no? Somebody took his time to write the rest... Also, would it maybe make sense to have a different library in KConfigWidgets for this? It seems quite disjoint from the rest... - Aleix Pol Gonzalez On Feb. 24, 2015, 11:39 a.m., Marco

Re: Review Request 122651: Allow users to configure how many horizontal lines are drawn

2015-02-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122651/#review76365 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 20, 2015

Re: Review Request 122029: Fix generation of KAuth DBus helper service file

2015-01-13 Thread Aleix Pol Gonzalez
. - Aleix Pol Gonzalez On Jan. 13, 2015, 11 a.m., Daniel Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122029

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Aleix Pol Gonzalez
On April 23, 2015, 3:35 p.m., Jan Grulich wrote: And yes, this is required as long as NetworkManager headers are included by NetworkManagerQt headers. Jan Grulich wrote: I just found out that installing FindNetworkManager.cmake into CMake modules is not enough, because it still

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Aleix Pol Gonzalez
cannot find it. I guess this would have to be done according to other FindFoo.cmake modules from extra-cmake-modules, right? Aleix Pol Gonzalez wrote: That would certainly help, but then it's not very nice putting a cmake file into another project's directory. I would suggest

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79411 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 23, 2015

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-23 Thread Aleix Pol Gonzalez
/kconfig_compiler/test_signal.cpp.ref 58e73ef autotests/kconfig_compiler/test_signal.h.ref 19b8b40 src/kconfig_compiler/kconfig_compiler.cpp 5aae340 Diff: https://git.reviewboard.kde.org/r/123367/diff/ Testing --- KConfig tests still pass. Thanks, Aleix Pol Gonzalez

Re: Review Request 123436: Add unit test for KIO::AccessManager

2015-04-20 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/123436/diff/ Testing --- The test passes as is. Served me to fix: https://git.reviewboard.kde.org/r/123325/ https://codereview.qt-project.org/#/c/110745/ Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-25 Thread Aleix Pol Gonzalez
still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-25 Thread Aleix Pol Gonzalez
:39 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 25, 2015, 3:39 a.m

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-26 Thread Aleix Pol Gonzalez
/accessmanager.cpp 239281e Diff: https://git.reviewboard.kde.org/r/123443/diff/ Testing --- New test for the new method. Tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Review Request 123514: Make it possible to treat non-sequential QIODevice asynchronously

2015-04-26 Thread Aleix Pol Gonzalez
lambdas to delay write. I don't think it's available. Can I add some kind of #if HAS_LAMBDA and make the test depend on it? I don't think adding slots and make the buffer an attribute would be very nice... I can also sub-class the buffer. Thanks, Aleix Pol Gonzalez

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Aleix Pol Gonzalez
: https://git.reviewboard.kde.org/r/123367/diff/ Testing --- KConfig tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-22 Thread Aleix Pol Gonzalez
--- New test for the new method. Tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Aleix Pol Gonzalez
. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79343 --- On April 15, 2015, 5:38 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/123367/diff/ Testing --- KConfig tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Aleix Pol Gonzalez
. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79346 --- On April 22, 2015, 4:51 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Aleix Pol Gonzalez
? This seems like a useful thing to have every class use, so adding another configuration only reduces its visibility. Aleix Pol Gonzalez wrote: To minimize changes. I agree it would be interesting, I can do it if you (collectively) are on board. Do you have an idea of what

Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-21 Thread Aleix Pol Gonzalez
/storedtransferjob.h d3e1106 src/core/storedtransferjob.cpp 7f81d00 src/widgets/accessmanager.cpp 239281e Diff: https://git.reviewboard.kde.org/r/123443/diff/ Testing --- New test for the new method. Tests still pass. Thanks, Aleix Pol Gonzalez

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79473 --- On April 24, 2015, 6:56 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 123492: Fix memory leak in AppletQuickItem

2015-04-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123492/#review79480 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 24, 2015

Re: Review Request 123493: Fix leaky incubation controller

2015-04-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123493/#review79481 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 24, 2015

<    3   4   5   6   7   8   9   10   11   12   >