T10262: Integrate KIO Slaves into file system using FUSE gateway

2019-03-13 Thread Alexander Saoutkin
feverfew added a comment.


  @ngraham I'll be having some free time this summer. I was thinking if we 
could solidify this task into exactly what we need to do so we can get a 
proposal in for GSoC?

TASK DETAIL
  https://phabricator.kde.org/T10262

To: cfeck, feverfew
Cc: feverfew, #frameworks, ngraham, #dolphin, cfeck, alexde, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov


D23194: Making FileJob behave consistently.

2019-08-16 Thread Alexander Saoutkin
feverfew added inline comments.

INLINE COMMENTS

> chinmoyr wrote in file.cpp:520
> A loop is required here. The docs don't really specify anything about reading 
> data in one go.

Exactly. The docs weren't specific at all. smb/sftp would read once, and return 
the result. the file slave would read until size was reached (or EOD). I 
decided to just convert file's behaviour to what smb/sftp do and updated the 
docs accordingly, for ease of use (and so that if new slaves implement 
KIO::open() they'd know how to implement the functions. Of course, I could do 
the converse, and change smb/sftp to behave like the file slave when 
reading/writing, but I can leave that up to debate, if others want to chime in.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23194: Making FileJob behave consistently.

2019-08-16 Thread Alexander Saoutkin
feverfew updated this revision to Diff 63861.
feverfew added a comment.


  Addressing comments

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23194?vs=63841=63861

BRANCH
  ConsistentRead (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23194

AFFECTED FILES
  src/core/filejob.cpp
  src/core/filejob.h
  src/core/slavebase.h
  src/core/slaveinterface.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23159: Prevent error() being emitted when purposefully reading 0 bytes

2019-08-14 Thread Alexander Saoutkin
feverfew added inline comments.

INLINE COMMENTS

> apol wrote in file.cpp:520
> this should be
> 
>   {
>   Q_EMIT data({});`
>   return;
>   }
> 
> I'm not sure that we'd need an empty data emitted then. Are you trying to fix 
> a specific bug that triggers this?

I('ve not seen any IOSlave use a Q_EMIT macro, any reason why it's necessary 
here (what's the change in the behaviour).

Please re-read the summary, carefully, the error is subtle.

> apol wrote in file.cpp:526
> alternatively this could also check ` && bytes != 0`

Please reread the summary, this would not fix the bug.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23159

To: feverfew, dfaure, fvogt, chinmoyr
Cc: apol, kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-16 Thread Alexander Saoutkin
feverfew updated this revision to Diff 63876.
feverfew added a comment.


  Unnecessary min version upgraded

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23207?vs=63875=63876

BRANCH
  fixSFTP (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23207

AFFECTED FILES
  sftp/kio_sftp.cpp
  smb/kio_smb.h
  smb/kio_smb_file.cpp

To: feverfew, chinmoyr, fvogt
Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov


D23194: Making FileJob behave consistently.

2019-08-16 Thread Alexander Saoutkin
feverfew added inline comments.

INLINE COMMENTS

> chinmoyr wrote in file.h:117
> Nitpick; why not just closeFile() ?

That's how sftp does it, so for consistency.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23207: Fixing finished() called after error() in smb slave. Do not call finished() in open/read/write/seek operations

2019-08-16 Thread Alexander Saoutkin
feverfew created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
feverfew requested review of this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  fixSFTP (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23207

AFFECTED FILES
  CMakeLists.txt
  sftp/kio_sftp.cpp
  smb/kio_smb.h
  smb/kio_smb_file.cpp

To: feverfew
Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov


D23194: Making FileJob behave consistently.

2019-08-16 Thread Alexander Saoutkin
feverfew added inline comments.

INLINE COMMENTS

> file.cpp:550
> +// Make sure data gets to disk.
> +if (mFile->flush())
> +written(bytesWritten);

Flushing on every write IMO is a bit expensive, but I don't like the fact that 
close() can't report errors and so we have silent data loss. Maybe we should 
implement a flush method in FileJob. It only really makes sense for the file 
slave, for sftp/smb it will be a noop... Thoughts?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23194: Making FileJob behave consistently.

2019-08-16 Thread Alexander Saoutkin
feverfew marked 4 inline comments as done.
feverfew added inline comments.

INLINE COMMENTS

> chinmoyr wrote in filejob.h:48
> Document the methods in SlaveBase as well.

I've used @see to help me out. Is that enough? I don't want to duplicate the 
docs, especially if someone changes it and forgets to change the other...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-16 Thread Alexander Saoutkin
feverfew retitled this revision from "Fixing finished() called after error() in 
smb slave. Do not call finished() in open/read/write/seek operations" to 
"Fixing implementation of FileJob interface in smb/sftp slaves".
feverfew edited the summary of this revision.
feverfew edited the test plan for this revision.
feverfew added reviewers: chinmoyr, fvogt.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23207

To: feverfew, chinmoyr, fvogt
Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov


D23159: Prevent error() being emitted when purposefully reading 0 bytes

2019-08-15 Thread Alexander Saoutkin
feverfew abandoned this revision.
feverfew added inline comments.

INLINE COMMENTS

> feverfew wrote in file.cpp:524
> I think that would be appropriate for a separate revision which I'm doing. 
> This revision is only to handle the case outlined in the summary.

Actually I've realised using the other function would allow me to solve this 
problem much more cleanly. I'll abandon this revision and upload a new patch 
that addresses this problem (and others).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23159

To: feverfew, dfaure, fvogt, chinmoyr
Cc: apol, kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23194: Making FileJob behave consistently.

2019-08-15 Thread Alexander Saoutkin
feverfew edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23194: Making FileJob behave consistently.

2019-08-15 Thread Alexander Saoutkin
feverfew edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23194: Making FileJob behave consistently.

2019-08-15 Thread Alexander Saoutkin
feverfew created this revision.
feverfew added reviewers: dfaure, fvogt, chinmoyr, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
feverfew requested review of this revision.

REVISION SUMMARY
  This patch does the following:
  
  1. Makes sure the close() signal is actually emitted when close() is called.
  2. Documents the FileJob functions more accurately, and ensures the file 
slave acts similarly to the two other slaves that implement these functions
  
  (smb/sftp).
  
  3. Fixes an issue when purposefully reading 0 bytes.

TEST PLAN
  The application I am developing on that depends on FileJob now successfully 
receives the close() signal when required and does not experience the bug 
  mentioned when reading 0 bytes. 
  Existing read/write/seek functionality is not broken.
  Tests also pass.

REPOSITORY
  R241 KIO

BRANCH
  ConsistentRead (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23194

AFFECTED FILES
  src/core/filejob.cpp
  src/core/filejob.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23159: Prevent error() being emitted when purposefully reading 0 bytes

2019-08-15 Thread Alexander Saoutkin
feverfew added inline comments.

INLINE COMMENTS

> chinmoyr wrote in file.cpp:524
> This doesn't support error reporting. Why not refactor this loop using 
> read(char *, qint64)? I believe you can accommodate your changes inside the 
> loop cleanly then.

I think that would be appropriate for a separate revision which I'm doing. This 
revision is only to handle the case outlined in the summary.

> chinmoyr wrote in file.cpp:538
> here `bytes` being negative should be an error..no?

bytes is unsigned, so it is not a worry for us.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23159

To: feverfew, dfaure, fvogt, chinmoyr
Cc: apol, kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23194: Making FileJob behave consistently.

2019-08-19 Thread Alexander Saoutkin
feverfew updated this revision to Diff 64051.
feverfew added a comment.


  Making comments clearer

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23194?vs=63861=64051

BRANCH
  ConsistentRead (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23194

AFFECTED FILES
  src/core/filejob.cpp
  src/core/filejob.h
  src/core/slavebase.h
  src/core/slaveinterface.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23159: Prevent error() being emitted when purposefully reading 0 bytes

2019-08-14 Thread Alexander Saoutkin
feverfew created this revision.
feverfew added reviewers: dfaure, fvogt, chinmoyr.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
feverfew requested review of this revision.

REVISION SUMMARY
  Currently when 0 is passed as a parameter, if the file to be read is 
non-empty both data and error signals 
  are emitted. This behaviour is incorrect, as there is no error. This patch 
makes sure that only data is 
  emitted.

TEST PLAN
  The application I'm developing that hit this bug now no longer hits this 
issue.

REPOSITORY
  R241 KIO

BRANCH
  Read0Bug (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23159

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: feverfew, dfaure, fvogt, chinmoyr
Cc: kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22708: [WIP] Add a kded module infra for fuse mount services

2019-08-21 Thread Alexander Saoutkin
feverfew added a comment.


  In D22708#516128 , @ngraham wrote:
  
  > Oh good. :) Is there anywhere I can follow the progress?
  
  
  All my work goes on KIOFuse goes into review here:
  https://gitlab.com/Vogtinator/kio-fuse/merge_requests
  
  Sometimes I need to upload diffs upstream to KIO to fix bugs or for 
integrating KIOFuse into KIO. Those can be followed via my phabricator diffs. I 
have some (i.e. KIO bug fixes) that I would like to get into 5.62, but no one 
is able to review/approve my KIO changes atm...
  
  Also feel free to pop by #kde-fm for discussions or if you want to ask a 
question.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22708

To: chinmoyr
Cc: feverfew, ngraham, andriusr, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D22708: [WIP] Add a kded module infra for fuse mount services

2019-08-21 Thread Alexander Saoutkin
feverfew added a comment.


  In D22708#516132 , @ngraham wrote:
  
  > In D22708#516131 , @feverfew 
wrote:
  >
  > > In D22708#516128 , @ngraham 
wrote:
  > >
  > > >
  > >
  > >
  > > Also feel free to pop by #kde-fm for discussions or if you want to ask a 
question.
  >
  >
  > It kicks me out for not having a registered nickname even though I totally 
do and am using it. If it's not necessary anymore, it might be nice to remove 
that restriction.
  
  
  Yeah I've had problems accessing that channel via matrix unless I used 
Konversation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22708

To: chinmoyr
Cc: feverfew, ngraham, andriusr, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D22708: [WIP] Add a kded module infra for fuse mount services

2019-08-21 Thread Alexander Saoutkin
feverfew added a comment.


  In D22708#507449 , @ngraham wrote:
  
  > What?
  
  
  Don't worry, all is fine. I've taken over Chinmoy's work on this for now. We 
agreed on a better way to go about integrating KIOFuse into KIO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22708

To: chinmoyr
Cc: feverfew, ngraham, andriusr, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-26 Thread Alexander Saoutkin
feverfew added reviewers: sitter, dfaure.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23207

To: feverfew, chinmoyr, fvogt, sitter, dfaure
Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov


D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-30 Thread Alexander Saoutkin
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:28fdc41f1d45: Fixing implementation of FileJob interface 
in smb/sftp slaves (authored by feverfew).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23207?vs=63876=64977

REVISION DETAIL
  https://phabricator.kde.org/D23207

AFFECTED FILES
  sftp/kio_sftp.cpp
  smb/kio_smb.h
  smb/kio_smb_file.cpp

To: feverfew, chinmoyr, fvogt, sitter, dfaure
Cc: bcooksley, kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov


D23194: Making FileJob behave consistently.

2019-08-30 Thread Alexander Saoutkin
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3154fc3e096e: Making FileJob behave consistently. 
(authored by feverfew).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23194?vs=64673=64976

REVISION DETAIL
  https://phabricator.kde.org/D23194

AFFECTED FILES
  autotests/jobremotetest.cpp
  autotests/jobremotetest.h
  src/core/filejob.cpp
  src/core/filejob.h
  src/core/slavebase.h
  src/core/slaveinterface.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

2019-08-23 Thread Alexander Saoutkin
feverfew created this revision.
feverfew added reviewers: fvogt, chinmoyr.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
feverfew requested review of this revision.

TEST PLAN
  Make sure kded module is installed and loaded.
  Use dolphin and observe that when opening applications that don't support KIO,
  the resulting files are opened in a KIOFuse mount instead of opened via the 
  help of kioexec.

REPOSITORY
  R241 KIO

BRANCH
  KDEDModule (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23384

AFFECTED FILES
  src/core/desktopexecparser.cpp
  src/widgets/krun.cpp

To: feverfew, fvogt, chinmoyr
Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns


D23454: Fixing bug where MTP slave does not return error in stat()/mimetype()

2019-08-25 Thread Alexander Saoutkin
feverfew created this revision.
feverfew added reviewers: chinmoyr, akrutzler, elvisangelaccio, dfaure.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
feverfew requested review of this revision.

REVISION SUMMARY
  This patch fixes two cases where invalid KTMPFile objects would be treated as 
  valid. In particular, this would manifest in KIO::stat() and KIO::mimetype() 
  returning without error when they, in fact, should do. One would note that in 
  the rest of the code, KMTPFile objects that are received via 
  KMTPStorageInterface::getFileMetaData() always have a isValid() check applied 
  before use. The two previously mentioned functions, incorrectly, do not have 
  this check applied. This patch simply adds these necessary checks.

TEST PLAN
  KIOFuse uses KIO::stat() to complete a lookup. Before this patch lookup would
  always succeed and this was determined to be because stat would always 
succeed.
  This bug could be easily found as tab completion would never work correctly. 
  Trying to tab complete would seem to add what was already typed in to the 
  directory. With this patch applied, lookup no longer always succeeds and tab 
  completion now works.

REPOSITORY
  R320 KIO Extras

BRANCH
  mtpFixStat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23454

AFFECTED FILES
  mtp/kio_mtp.cpp

To: feverfew, chinmoyr, akrutzler, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, kfm-devel, fvogt, aprcela, vmarinescu, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov


D23194: Making FileJob behave consistently.

2019-08-25 Thread Alexander Saoutkin
feverfew added inline comments.

INLINE COMMENTS

> dfaure wrote in filejob.h:112
> Why would someone request reading 0 bytes? That doesn't seem sensible to me.

Well it can happen and this is technically more correct than saying that an 
empty `QByteArray()` is always EOD. In fact, the one of the motivations for 
this patch was that for KIOFuse, we do read 0 bytes in case the user truncates 
to 0, otherwise we'd have to have a workaround if it didn't work (for example, 
before this patch, we'd get both an empty QByteArray() and the error signal...).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23194: Making FileJob behave consistently.

2019-08-26 Thread Alexander Saoutkin
feverfew marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23194: Making FileJob behave consistently.

2019-08-26 Thread Alexander Saoutkin
feverfew marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23194: Making FileJob behave consistently.

2019-08-26 Thread Alexander Saoutkin
feverfew updated this revision to Diff 64672.
feverfew added a comment.


  - Fixing typos
  - Adding test for reading of 0 bytes and asserting that the close signal is
  
  actually emitted.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23194?vs=64051=64672

BRANCH
  ConsistentRead (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23194

AFFECTED FILES
  autotests/jobremotetest.cpp
  autotests/jobremotetest.h
  src/core/filejob.cpp
  src/core/filejob.h
  src/core/slavebase.h
  src/core/slaveinterface.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23194: Making FileJob behave consistently.

2019-08-26 Thread Alexander Saoutkin
feverfew updated this revision to Diff 64673.
feverfew added a comment.


  - Removing flush on write

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23194?vs=64672=64673

BRANCH
  ConsistentRead (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23194

AFFECTED FILES
  autotests/jobremotetest.cpp
  autotests/jobremotetest.h
  src/core/filejob.cpp
  src/core/filejob.h
  src/core/slavebase.h
  src/core/slaveinterface.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-27 Thread Alexander Saoutkin
feverfew added a comment.


  In D23207#520233 , @sitter wrote:
  
  > Not knowing the background here at a glance I would argue that SlaveBase in 
KIO should be getting state verification on all of this,.
  
  
  Sorry, I'm not sure what you mean by "state verification" in this case and 
how it relates to SlaveBase.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23207

To: feverfew, chinmoyr, fvogt, sitter, dfaure
Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov


D24076: add a simple smoke test for slaves by using kioclient5

2019-09-19 Thread Alexander Saoutkin
feverfew added a comment.


  I won't review, but would like to note I think that with KIOFuse, in 
conjuction with fio  we can do some really 
complex testing on KIO, correct me if I'm wrong.
  
  If I'm right, then we can test KIO nicely, although if we do notice a bug via 
using fio, it can technically be in any of FUSE/KIOFuse/KIO, but in my 
experience KIO is the most buggy of the lot.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D24076

To: sitter, dfaure
Cc: feverfew, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov