D29200: test the extractNothing flag

This revision was automatically updated to reflect the committed changes. Closed by commit R286:5e1ed919bdf6: test the extractNothing flag (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29200?vs=81237=81928 REVISION DETAIL

D29199: honor the extractMetaData flag

This revision was automatically updated to reflect the committed changes. Closed by commit R286:538c34b58057: honor the extractMetaData flag (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81258=81927 REVISION DETAIL

D29199: honor the extractMetaData flag

astippich updated this revision to Diff 81258. astippich added a comment. - use continue REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81257=81258 BRANCH honorFlag REVISION DETAIL https://phabricator.kde.org/D29199 AFFECTED FILES

D29199: honor the extractMetaData flag

astippich updated this revision to Diff 81257. astippich added a comment. - fix another stupid mistake REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81253=81257 BRANCH honorFlag REVISION DETAIL https://phabricator.kde.org/D29199

D29199: honor the extractMetaData flag

astippich marked 2 inline comments as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in xmlextractor.cpp:103 > skipped, `if (!) { continue; }` sorry, that went lost somehow REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D29199 To:

D29199: honor the extractMetaData flag

astippich updated this revision to Diff 81253. astippich marked an inline comment as done. astippich added a comment. - more fixes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81248=81253 BRANCH honorFlag REVISION DETAIL

D29199: honor the extractMetaData flag

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:99 > when you add the flag check here, you can avoid the extra indentation below. > Likewise in some other places. true, that was still written with D25517 and D25515

D29199: honor the extractMetaData flag

astippich updated this revision to Diff 81248. astippich marked 4 inline comments as done. astippich added a comment. - implement review REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81235=81248 BRANCH honorFlag REVISION DETAIL

D29200: test the extractNothing flag

astippich created this revision. astippich added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Test that nothing is extracted when the corresponding

D29199: honor the extractMetaData flag

astippich added a dependent revision: D29200: test the extractNothing flag. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D29199 To: astippich, #baloo, bruns, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D29199: honor the extractMetaData flag

astippich created this revision. astippich added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Metadata was extracted unconditionally before. Only do so

D28980: Revert "add Baloo DBus signals for moved or removed files"

astippich removed a reviewer: astippich. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28980 To: bruns, #baloo, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun,

D25515: Only extract lyrics when the plain text flag is set

astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25515 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich,

D25518: Extract front cover in the taglib extractor

astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25518 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich,

D25679: Implement writing of front cover in taglibwriter

astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25679 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich,

D25517: Add an option to extract image data and add front cover property

astippich abandoned this revision. astippich added a comment. Okay, since there seems to be no interest at all as even a short reply is not given, I am done here REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien,

D28682: rename and export newBatchTime signal in filecontentindexer

This revision was automatically updated to reflect the committed changes. Closed by commit R293:19e71b3e4a5f: rename and export newBatchTime signal in filecontentindexer (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D28682: rename and export newBatchTime signal in filecontentindexer

astippich added a comment. Thanks REPOSITORY R293 Baloo BRANCH exportSignal REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh,

D28682: rename and export newBatchTime signal in filecontentindexer

astippich retitled this revision from "rename and export done signal in filecontentindexer" to "rename and export newBatchTime signal in filecontentindexer". astippich edited the summary of this revision. REPOSITORY R293 Baloo BRANCH exportSignal REVISION DETAIL

D28682: rename and export done signal in filecontentindexer

astippich marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun,

D28682: rename and export done signal in filecontentindexer

astippich updated this revision to Diff 79904. astippich added a comment. - implement feedback REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28682?vs=79751=79904 BRANCH exportSignal REVISION DETAIL https://phabricator.kde.org/D28682 AFFECTED FILES

D28682: rename and export done signal in filecontentindexer

astippich retitled this revision from "export done signal in filecontentindexer" to "rename and export done signal in filecontentindexer". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77,

D28682: export done signal in filecontentindexer

astippich updated this revision to Diff 79751. astippich added a comment. - rename signal REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28682?vs=79657=79751 BRANCH exportSignal REVISION DETAIL https://phabricator.kde.org/D28682 AFFECTED FILES

D28682: export done signal in filecontentindexer

astippich added a comment. How about committedBatch so that it's clear that they have been committed to the database? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs,

D28682: export done signal in filecontentindexer

astippich added a comment. Then it's fine from my application point of view. I can add a corresponding start signal for convenience, though. Your call. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien,

D28682: export done signal in filecontentindexer

astippich added a comment. > Quoted Text > >> ! In D28682#644412 , @mgallien wrote: > > This is the reason why it is so slow in Elisa? Do you mean slow for picking up changes in files? Then yes. This happens when a track is modified

D28682: export done signal in filecontentindexer

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Applications can subsribe for new files being indexed by baloo via

D25517: Add an option to extract image data and add front cover property

astippich added a comment. Due to the recent circumstances I will probably not implement the support in Elisa, so I won't land this unless @bruns explicitly is okay with it (I still think this is an improvement over the status quo). REPOSITORY R286 KFileMetaData REVISION DETAIL

D25679: Implement writing of front cover in taglibwriter

astippich updated this revision to Diff 77959. astippich added a comment. - adapt to changes - use QMimeDatabase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25679?vs=73099=77959 BRANCH tagLibBinaryWrite REVISION DETAIL

D25518: Extract front cover in the taglib extractor

astippich updated this revision to Diff 77956. astippich added a comment. - adapt to changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25518?vs=73098=77956 BRANCH taglibBinaryExtraction REVISION DETAIL https://phabricator.kde.org/D25518

D25517: Add an option to extract image data and add front cover property

astippich added a comment. Since I got one accept and no other response, I will merge on the weekend REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs,

D25517: Add an option to extract image data and add front cover property

astippich updated this revision to Diff 77954. astippich added a comment. - fix label comment - tweaks - rename flag to ImageData - adress review comments - udpate since tag - update since tag REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D25517: Add an option to extract image data and add front cover property

astippich added a comment. ping @bruns this has now been open and unanswered for month! Same for the dependent patches REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel,

D27767: [ModifiedFileIndexer] Correct time checks for new files

astippich added a comment. I would like to request a clear answer for https://phabricator.kde.org/D25517 once again REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27767 To: bruns, #baloo, ngraham, astippich Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs,

D27767: [ModifiedFileIndexer] Correct time checks for new files

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27767 To: bruns, #baloo, ngraham, astippich Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas,

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27766 To: bruns, #baloo, ngraham, astippich Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n,

D27767: [ModifiedFileIndexer] Correct time checks for new files

astippich added inline comments. INLINE COMMENTS > modifiedfileindexer.cpp:74 > +bool cTimeChanged; > +bool isKnownFile = tr.hasDocument(fileId); > +if (isKnownFile) { const? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27767 To: bruns,

D25517: Add an option to extract image data and add front cover property

astippich added a comment. Ping! At least a reply would be nice REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D25517: Add an option to extract image data and add front cover property

astippich added a comment. Where are we with this? @bruns are you accepting the proposed solution or do you reject it completely? I think it is at least way better than the current solution and maintains current API. A larger refactoring could be done for KF6 REPOSITORY R286

D25517: Add an option to extract image data and add front cover property

astippich updated this revision to Diff 75306. astippich added a comment. - udpate since tag REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25517?vs=73097=75306 BRANCH binaryData REVISION DETAIL https://phabricator.kde.org/D25517 AFFECTED

D25517: Add an option to extract image data and add front cover property

astippich added a comment. friendly ping for the series REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D26671: Cleanup and add 22px media repeat icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:936f84707708: Cleanup and add 22px media repeat icons (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26671?vs=73592=73823 REVISION

D26671: Cleanup and add 22px media repeat icons

astippich added a comment. here you go: F7883937: media-repet.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26671 To: astippich, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26671: Cleanup and add 22px media repeat icons

astippich updated this revision to Diff 73592. astippich added a comment. - remove color REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26671?vs=73567=73592 BRANCH repeatIcons REVISION DETAIL https://phabricator.kde.org/D26671 AFFECTED FILES

D26671: Cleanup and add 22px media repeat icons

astippich created this revision. astippich added reviewers: VDG, ngraham, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY This patch does the following things: -small cleanup to the

D25517: Add an option to extract image data and add front cover property

astippich marked 2 inline comments as done. astippich added a comment. In D25517#588029 , @bruns wrote: > The problem is the extractor serves two different use cases: > > - retrieval for searching/caching properties > - on-demand extraction

D25679: Implement writing of front cover in taglibwriter

astippich updated this revision to Diff 73099. astippich added a comment. - adapt to changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25679?vs=70725=73099 BRANCH tagLibBinaryWrite REVISION DETAIL https://phabricator.kde.org/D25679

D25517: Add an option to extract image data and add front cover property

astippich updated this revision to Diff 73097. astippich added a comment. - adress review comments REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25517?vs=71623=73097 BRANCH binaryData REVISION DETAIL https://phabricator.kde.org/D25517

D25518: Extract front cover in the taglib extractor

astippich updated this revision to Diff 73098. astippich added a comment. - adapt to changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25518?vs=70724=73098 BRANCH taglibBinaryExtraction REVISION DETAIL https://phabricator.kde.org/D25518

D25517: Add an option to extract image data and add front cover property

astippich added a comment. In D25517#587776 , @bruns wrote: > I have thought about this and have come to the conclusion this is not really future proof. > > The `Property::FrontCover` is IMHO fine, i.e. the changes to `propertyinfo.cpp` and

D25517: Add an option to extract image data and add front cover property

astippich added a comment. friendly ping! I would like to continue work on this. Is the new name better? If so, I will rebase follow-up patches REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc:

D26054: partial fix for accentuated characters in file name on Windows

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH fixWriterAccentuatedFileName REVISION DETAIL https://phabricator.kde.org/D26054 To: mgallien, bruns, astippich Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs,

D25517: Add an option to extract image data and add front cover property

astippich retitled this revision from "Add an option to extract binary data and add front cover property" to "Add an option to extract image data and add front cover property". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns,

D25517: Add an option to extract binary data and add front cover property

astippich updated this revision to Diff 71623. astippich added a comment. - rename flag to ImageData REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25517?vs=70723=71623 BRANCH binaryData REVISION DETAIL https://phabricator.kde.org/D25517

D25516: Remove unrequired private declarations for taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:f2fea112: Remove unrequired private declarations for taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D25517: Add an option to extract binary data and add front cover property

astippich added a comment. ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D25622: partial solution to accept accentuated characters on windows

astippich added a comment. taglibwriter should get the same treatment REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25622 To: mgallien, bruns, #windows Cc: astippich, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2,

D25679: Implement writing of front cover in taglibwriter

astippich added a dependency: D25518: Extract front cover in the taglib extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25679 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas,

D25518: Extract front cover in the taglib extractor

astippich added a dependent revision: D25679: Implement writing of front cover in taglibwriter. REPOSITORY R286 KFileMetaData BRANCH taglibBinaryExtraction REVISION DETAIL https://phabricator.kde.org/D25518 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel,

D25679: Implement writing of front cover in taglibwriter

astippich created this revision. astippich added reviewers: Baloo, bruns, mgallien, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Complements the extractor support for writing

D25518: Extract front cover in the taglib extractor

astippich updated this revision to Diff 70724. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25518?vs=70285=70724 BRANCH taglibBinaryExtraction REVISION DETAIL https://phabricator.kde.org/D25518 AFFECTED

D25517: Add an option to extract binary data and add front cover property

astippich updated this revision to Diff 70723. astippich added a comment. - fix label comment - tweaks REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25517?vs=70303=70723 BRANCH binaryData REVISION DETAIL https://phabricator.kde.org/D25517

D25515: Only extract lyrics when the plain text flag is set

astippich added a comment. For baloo-widgets, the display of the lyrics tag is disabled anyways. Displaying a large chunk of text does not really look good in the information panel... REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25515 To: astippich,

D25516: Remove unrequired private declarations for taglibextractor

astippich updated this revision to Diff 70398. astippich added a comment. - put all helper functions into anonymous namespace REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25516?vs=70283=70398 BRANCH cleanupTagLib REVISION DETAIL

D25516: Remove unrequired private declarations for taglibextractor

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:105 > This puts `readGenericProperties(...)` with external linkage in the global > namespace. > > Put the private helpers in an anonymous namespace (and also include > `extractAudioProperties(...)` in it).

D25517: Add an option to extract binary data and add front cover property

astippich added inline comments. INLINE COMMENTS > bruns wrote in extractionresult.h:61 > Binary is **how**, not **what**. Do you have a suggestion for a better name? I tried to be as generic as possible. It could be named more specifically ExtractImages, since this is what it will be

D25517: Add an option to extract binary data and add front cover property

astippich updated this revision to Diff 70303. astippich added a comment. - fix label comment REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25517?vs=70284=70303 BRANCH binaryData REVISION DETAIL https://phabricator.kde.org/D25517 AFFECTED

D25518: Extract front cover in the taglib extractor

astippich added dependencies: D25517: Add an option to extract binary data and add front cover property, D25516: Remove unrequired private declarations for taglibextractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25518 To: astippich, #baloo, bruns,

D25517: Add an option to extract binary data and add front cover property

astippich added a dependent revision: D25518: Extract front cover in the taglib extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n,

D25516: Remove unrequired private declarations for taglibextractor

astippich added a dependent revision: D25518: Extract front cover in the taglib extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25516 To: astippich, #baloo, bruns, ngraham, mgallien Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n,

D25518: Extract front cover in the taglib extractor

astippich added a comment. This is probably how it should have been implemented from the beginning, and not how I did it in the embeddedimagedata class, which duplicates a lot of code and requires additional file operations. Baloo can continue to work as is due to the new flags. Taglib

D25518: Extract front cover in the taglib extractor

astippich created this revision. astippich added reviewers: Baloo, bruns, mgallien, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add the possibility to extract the front cover

D25517: Add an option to extract binary data and add front cover property

astippich created this revision. astippich added reviewers: Baloo, bruns, mgallien, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY prepare for the following patch to

D25516: Remove unrequired private declarations for taglibextractor

astippich created this revision. astippich added reviewers: Baloo, bruns, ngraham, mgallien. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY They do not need to be declared in the header

D25515: Only extract lyrics when the plain text flag is set

astippich created this revision. astippich added reviewers: Baloo, bruns, mgallien, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY One can argue that lyrics are not really

D24957: Add new baloo icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:61331d6ce20a: Add new baloo icons (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24957?vs=69857=69859 REVISION DETAIL

D24957: Add new baloo icons

astippich updated this revision to Diff 69857. astippich added a comment. - tweak icon and shadows - remove baloo symlink REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24957?vs=69501=69857 BRANCH newBalooIcon REVISION DETAIL

D24957: Add new baloo icons

astippich added a comment. the scalable test fails with this one. Is the right solution to just delete the 32px symlink under .../preferences? REPOSITORY R266 Breeze Icons BRANCH newBalooIcon REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc:

D24959: Add new preferences search icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:40acd718572a: Add new preferences search icons (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24959?vs=69500=69830 REVISION DETAIL

D24959: Add new preferences search icons

astippich added a comment. any more comments? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26 Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D23411: Fix crash in writer collection and cleanup

astippich added a comment. Thanks! I pushed a fix which disables the test if taglib is not installed REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D23411 To: astippich, bruns, mgallien, ngraham Cc: justinkb, apol, kde-frameworks-devel, #baloo, hurikhan77,

D24957: Add new baloo icons

astippich updated this revision to Diff 69501. astippich added a comment. - tweak icon and shadows REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24957?vs=68777=69501 BRANCH newBalooIcon REVISION DETAIL https://phabricator.kde.org/D24957

D24959: Add new preferences search icons

astippich added a comment. F7749583: search.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26 Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2,

D24959: Add new preferences search icons

astippich updated this revision to Diff 69500. astippich added a comment. - tweak shadows REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24959?vs=68979=69500 BRANCH newSearchIcon REVISION DETAIL https://phabricator.kde.org/D24959 AFFECTED FILES

D24959: Add new preferences search icons

astippich added a comment. I also think that this is too thin. If you'd like to do the updates, please go ahead! You can do it much better than me I think REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26 Cc:

D24959: Add new preferences search icons

astippich added a comment. This is a scaled copy of the kfind magnifier glass. However, it was way too small to be directly usable imho REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26 Cc: ndavis, trickyricky26,

D24957: Add new baloo icons

astippich added a comment. F7686927: test32.png F7686929: test48.png REPOSITORY R266 Breeze Icons BRANCH newBalooIcon REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham,

D24959: Add new preferences search icons

astippich updated this revision to Diff 68979. astippich added a comment. - modified icon with shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24959?vs=68779=68979 BRANCH newSearchIcon REVISION DETAIL https://phabricator.kde.org/D24959

D24958: Delete nepomuk icon

astippich added a comment. Thanks @broulik for the hint and @ngraham for being faster than me :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24958: Delete nepomuk icon

astippich added a comment. Can you give me a hint exactly where? I searched for usages and found none, and still cannot find it now REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel,

D24958: Delete nepomuk icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:34fa249177e1: Delete nepomuk icon (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24958?vs=68778=68967 REVISION DETAIL

D24959: Add new preferences search icons

astippich added a comment. New proposal F7684533: preferences-desktop-search2.png However, I am not a fan of the shadow. It is barely visbile anyways at such small sizes, and it looks weird with the handle REPOSITORY R266 Breeze Icons

D24959: Add new preferences search icons

astippich added a comment. Yes, that is the plan REPOSITORY R266 Breeze Icons BRANCH newSearchIcon REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D21004: [UserMetaData] Shortcut attribute queries for the common case

astippich added a comment. ping REPOSITORY R824 Baloo Widgets BRANCH bulk_query REVISION DETAIL https://phabricator.kde.org/D21004 To: bruns, #baloo, #frameworks, ngraham, astippich, lbeltrame Cc: hurikhan77, lots0logs, fbampaloukas, domson, ashaposhnikov, astippich, spoorun,

D24959: Add new preferences search icons

astippich added a comment. Correct REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D24959: Add new preferences search icons

astippich added a comment. F7673429: preferences-desktop-search.svg.png Basically the icon from D24957 without the paw REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To:

D24959: Add new preferences search icons

astippich created this revision. astippich added reviewers: VDG, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add a new icon for usage with the system-settings "search" category,

D24957: Add new baloo icons

astippich added a comment. Before: F7673421: test.png which is basically a copy of the kfind icon REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc: kde-frameworks-devel,

D24958: Delete nepomuk icon

astippich created this revision. astippich added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY It's long gone, and is just a symlink to the preference-desktop-baloo icon

D24957: Add new baloo icons

astippich added a comment. F7673101: baloo48.png F7673103: baloo32.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc:

  1   2   3   4   5   6   7   8   9   10   >