D11360: provide sample rate in kHz

astippich updated this revision to Diff 29662. astippich added a comment. - use qlatin1string for comparison and do not display trailing zeros REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11360?vs=29621=29662 BRANCH sample_rate REVISION DETAIL

D10918: taglibextractor: Refactor for better readability

astippich added inline comments. INLINE COMMENTS > michaelh wrote in taglibextractor.cpp:157 > This is an example for what we're discussing. Why the join??? We might lose > info, when the album artist contains a comma. Yeah, I've seen that as well. Looks unnecessary, since we could also just

D10918: taglibextractor: Refactor for better readability

astippich added inline comments. INLINE COMMENTS > michaelh wrote in taglibextractor.cpp:331 > You mean other than lines 225, 233, 240? Yes, but imho we shouldn't even enter the function for mimetypes not having ogg tags. Maybe that is overly careful REPOSITORY R286 KFileMetaData REVISION

D10694: epubextractor: Handle multiple subjects better

astippich added a comment. In D10694#221734 , @mgallien wrote: > In D10694#221719 , @michaelh wrote: > > > This is bad! I have learned baloo itself doesn't handle stringlists. Which in my view

D10918: taglibextractor: Refactor for better readability

astippich requested changes to this revision. astippich added a comment. This revision now requires changes to proceed. Looks good imho, just one small comment inline. of course, @mgallien as the maintainer must also give his ok. INLINE COMMENTS > taglibextractor.cpp:331 > +} else { > +

D10803: handle more tags in taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien, ngraham, michaelh Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, spoorun, bruns,

D10803: handle more tags in taglibextractor

astippich added a comment. @mgallien this should be safe to land now since KF 5.45 has been tagged, right? REPOSITORY R286 KFileMetaData BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien, ngraham, michaelh Cc: vhanda, dfaure, michaelh,

D10803: handle more tags in taglibextractor

astippich added a comment. ping. Can I push? I'm asking again because I don't want to mess up anything before the frameworks release, and this one contains string changes REPOSITORY R286 KFileMetaData BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 To:

D12156: implement reading of rating tag

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12156: implement reading of rating tag

astippich created this revision. astippich added reviewers: mgallien, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY allows to read the rating stored in the

D10803: handle more tags in taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:7f9de32eedff: handle more tags in taglibextractor (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10803?vs=30956=31950#toc REPOSITORY R286 KFileMetaData CHANGES

D12320: add ability to read embedded cover files

astippich created this revision. astippich added reviewers: mgallien, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY read the embedded image of audio files

D12320: add ability to read embedded cover files

astippich added a comment. This revision is only one possibility and is mainly there to start the discussion again on how to read the embedded picture data from e.g. audio files. Before this can land, Baloo has to be patched in order to cope with binary data. I think for Baloo there are

D11874: change 24px view-media-artist icon

astippich added a reviewer: andreask. astippich added a comment. ping REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11874 To: astippich, #vdg, andreask Cc: #frameworks, michaelh, ngraham, bruns

D11820: Handle properties with multiple values

astippich added a comment. Sorry for the late answer. Isn't this already handled in widgetfactory.cpp toString function (line 87)? During my testing with multiple values I've never had issues with baloo-widgets, only with baloo itself. If there are still changes required in baloo-widgets, I

D11820: Handle properties with multiple values

astippich added a comment. Seems to work just fine, see screenshot: F5808864: Screenshot_20180415_181027.png I did a little bit more testing, and in case you didn't already know: It looks like baloo outputs properties with multiple values as a

D12156: implement reading of rating tag

astippich added a comment. In D12156#249951 , @michaelh wrote: > It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used and why xattr are not applicable? It will be used as a fallback when there is no

D12156: implement reading of rating tag

astippich updated this revision to Diff 32587. astippich added a comment. - implement reading of half star ratings for mp3 and add tests REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=31987=32587 BRANCH rating REVISION DETAIL

D12156: implement reading of rating tag

astippich added a comment. Those formulas didn't work with newly added tests with values from Winamp, Windows Media Player and MediaMonkey. I calculated a linear regression line and this one seems to work with some special case handling REPOSITORY R286 KFileMetaData REVISION DETAIL

D12156: implement reading of rating tag

astippich added a comment. code didn't get prettier, but that's the de-facto standard REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12156: implement reading of rating tag

astippich updated this revision to Diff 32591. astippich added a comment. - simplify REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=32587=32591 BRANCH rating REVISION DETAIL https://phabricator.kde.org/D12156 AFFECTED FILES

D12156: implement reading of rating tag

astippich added a comment. In D12156#249223 , @mgallien wrote: > Thanks. > Fix one issue and we should be good to go. > Another nice thing is that we should have a portable way to have ratings in Elisa that could be read or write somewhere

D12320: add ability to read embedded cover files

astippich added a comment. In D12320#249982 , @michaelh wrote: > -2 > https://cgit.kde.org/ffmpegthumbs.git/ should be useable, not sure though. It is also disqualified by the fact that it is not in frameworks. I think a nice solution

D12156: implement reading of rating tag

astippich added a comment. In D12156#249977 , @michaelh wrote: > In D12156#249971 , @astippich wrote: > > > In D12156#249951 , @michaelh wrote: > > >

D10803: handle more tags in taglibextractor

astippich added a comment. All of a sudden :) I've been quiet about this because I'd like to resolve the issues regarding strings/stringlists first, so if you have some spare time, please have a look at D11365 . I will rebase after this one landed

D10803: handle more tags in taglibextractor

astippich updated this revision to Diff 30955. astippich marked an inline comment as done. astippich added a comment. - fix formatting issues during rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=30951=30955 BRANCH enhance_taglib

D10803: handle more tags in taglibextractor

astippich marked 3 inline comments as done. astippich added a comment. In D10803#237133 , @michaelh wrote: > Except for the white space stuff I'm still fine with this. Oops, sorry, messed that up during rebase. INLINE COMMENTS >

D10803: handle more tags in taglibextractor

astippich updated this revision to Diff 30950. astippich added a comment. - rebase on top of master REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=28467=30950 BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803

D10803: handle more tags in taglibextractor

astippich updated this revision to Diff 30956. astippich added a comment. - remove duplicate genre property for mp3 REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=30955=30956 BRANCH enhance_taglib REVISION DETAIL

D10803: handle more tags in taglibextractor

astippich updated this revision to Diff 30951. astippich added a comment. - update value types REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=30950=30951 BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803

D11365: also test for value types in taglibextractortest and fix errors

astippich planned changes to this revision. astippich added a comment. In D11365#236274 , @michaelh wrote: > This patch should be split. > > 1. Test more properties > 2. Change return types of ... > > Also 'fix errors' in the title is

D11874: change 24px view-media-artist icon

astippich created this revision. astippich added a reviewer: VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY the 24px version of the view-media-artist icon is the only

D11874: change 24px view-media-artist icon

astippich added a comment. Before F5781105: Screenshot_20180401_222839.png After F5781107: Screenshot_20180401_222817.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11874

D11365: also test for value types in taglibextractortest and fix errors

astippich added inline comments. INLINE COMMENTS > mgallien wrote in taglibextractor.cpp:363 > Is it really needed to push directly a list ? > You are ignoring the fact that the original developer intended add to be > called once for each value. I would prefer to keep doing that until we can be

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. Thanks a lot! REPOSITORY R266 Breeze Icons BRANCH playlist_shuffle_repeat REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask, ngraham Cc: bcooksley, andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

This revision was automatically updated to reflect the committed changes. Closed by commit R266:f0a96f5f85cb: change 32px icons for playlist shuffle and repeat (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10292?vs=29110=30868

D11461: rename 64 px icons added for elisa

This revision was automatically updated to reflect the committed changes. Closed by commit R266:0f7c93f1b7e8: rename 64 px icons added for elisa (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11461?vs=29851=30869#toc REPOSITORY R266 Breeze Icons CHANGES SINCE

D11461: rename 64 px icons added for elisa

astippich added a comment. any feedback here? would be great to resolve this for frameworks 5.45 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11461 To: astippich, #breeze, #vdg, andreask Cc: #frameworks, michaelh, ngraham

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. Can I land this? phabricator doesn't show it as accepted though REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask, ngraham Cc: andreask, ngraham, #frameworks, michaelh

D11365: also test for value types in taglibextractortest and fix errors

astippich added a comment. any feedback on this? I would like to land this and then get going with D10803 again REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo, mgallien, michaelh

D11365: also test for value types in taglibextractortest and fix errors

astippich added a comment. It's just testing each file for all available properties, one after another. This revision just adds missing bits to the existing test. Refactoring should be done separately imho INLINE COMMENTS > michaelh wrote in propertyinfo.cpp:98 > Looks unrelated to me.

D10803: handle more tags in taglibextractor

astippich added a comment. Okay, I changed my mind, I rebased on top of master. Since the other revision needs more time and the new properties behave like the old ones, I'd like to end this long journey and land this revision if no-one objects :) REPOSITORY R286 KFileMetaData BRANCH

D11457: decrease bitrate precision for display

astippich added reviewers: Frameworks, Baloo. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11457 To: astippich, #frameworks, #baloo Cc: ashaposhnikov, astippich, spoorun, nicolasfella, alexeymin

D11461: rename 64 px icons added for elisa

astippich created this revision. astippich added reviewers: Breeze, VDG, andreask. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY see D10492

D11457: decrease bitrate precision for display

This revision was automatically updated to reflect the committed changes. Closed by commit R824:e9f00ca876a2: decrease bitrate precision for display (authored by astippich). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11457?vs=29840=29849 REVISION

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. ping @andreask REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask, ngraham Cc: andreask, ngraham, #frameworks, michaelh

D11365: also test for value types in taglibextractortest and fix errors

astippich added a comment. In D11365#227241 , @michaelh wrote: > Just in case you didn't use data-driven tests on purpose: https://doc.qt.io/qt-5/qttestlib-tutorial2-example.html Thanks for the hint, that's new for me. Anyways, there are

D11365: also test for value types in taglibextractortest and fix errors

astippich added reviewers: mgallien, michaelh. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo, mgallien, michaelh Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, nicolasfella, ngraham, alexeymin

D10803: handle more tags in taglibextractor

astippich updated this revision to Diff 28467. astippich added a comment. - remove lyrics and map encodedby to generator REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=28300=28467 BRANCH enhance_taglib REVISION DETAIL

D10803: handle more tags in taglibextractor

astippich added a comment. I don't know dolphin works, but given how KFileMetadata is designed, the new tags should be ignored until explicit support is added in dolphin. INLINE COMMENTS > michaelh wrote in properties.h:164 > ? Oops, seems like a wrong copy & paste :) will fix > michaelh

D16135: refactor tests for taglibextractor

astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY refactors all tests so that they can be reused

D16163: refactor taglibextractor to functions specific for metadata type

astippich added a comment. To be on the safe side here: I am allowed to modify private member functions regarding binary compatibility, right? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16163 To: astippich, bruns Cc: kde-frameworks-devel, #baloo,

D16135: refactor tests for taglibextractor

astippich added a comment. In D16135#341549 , @bruns wrote: > Can you split this up in two patches, the first one updating the test files and fixing the values in the tests, and the second one doing the refactoring? see D16162

D16162: harmonize test data for vorbis comment tags

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY harmonize the test data for all files with vorbis comments so that

D16163: refactor taglibextractor to functions specific for metadata type

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Refactor the specific extraction funtions in taglibextractor so

D16165: Don't crash on invalid exiv2 data

astippich added a comment. I guess bugs 352856 353848 361259 will also be fixed by this? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16165 To: poboiko, #baloo, #frameworks Cc: astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun,

D16162: harmonize test data for vorbis comment tags

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1aab09a628ae: harmonize test data for vorbis comment tags (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16162?vs=43485=43489

D16163: refactor taglibextractor to functions specific for metadata type

astippich added a comment. In D16163#342057 , @mgallien wrote: > In D16163#342046 , @astippich wrote: > > > To be on the safe side here: I am allowed to modify private member functions regarding

D16135: refactor tests for taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:2d6b448b69b0: refactor tests for taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16135?vs=43490=43525 REVISION

D16135: refactor tests for taglibextractor

astippich updated this revision to Diff 43490. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16135?vs=43409=43490 BRANCH refactor_tests REVISION DETAIL https://phabricator.kde.org/D16135 AFFECTED FILES

D16163: refactor taglibextractor to functions specific for metadata type

astippich updated this revision to Diff 43500. astippich added a comment. - use forward declaration REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16163?vs=43486=43500 BRANCH refactor_taglib REVISION DETAIL https://phabricator.kde.org/D16163

D16196: add a description property to KFileMetaData

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add the description property to KFileMetaData, as the

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY provide a list of supported mimetypes similar to the

D11869: epubextractor: Add property ReleaseYear

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. Herald edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. Any objections? Otherwise I will merge this on michaelh's behalf REPOSITORY R286 KFileMetaData

D11869: epubextractor: Add property ReleaseYear

This revision was automatically updated to reflect the committed changes. Closed by commit R286:15adb113399e: epubextractor: Add property ReleaseYear (authored by michaelh, committed by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16165: Don't crash on invalid exiv2 data

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH dont-crash-invalid-exiv (branched from master) REVISION DETAIL https://phabricator.kde.org/D16165 To: poboiko, #baloo, #frameworks, astippich Cc: bruns, astippich,

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich added inline comments. INLINE COMMENTS > mgallien wrote in embeddedimagedata.h:62 > You can make it static because you are returning a static member. It means > that you should probably return by const reference (even if I do not remember > if it is always the best answer). I had it

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich updated this revision to Diff 43601. astippich added a comment. - move mimetype list to private REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16197?vs=43587=43601 BRANCH mimetypes_embedded_image REVISION DETAIL

D16283: implement more tags for asf metadata

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:739 > this makes me always wonder why we don't do: > > // decltype(data.albumArtists) == QStringList > for (attribute : lstAsf) { > QString t = TStringToQString(attribute.toString()); >

D16283: implement more tags for asf metadata

astippich updated this revision to Diff 43885. astippich marked 3 inline comments as done. astippich added a comment. - fix comment and simplify iterating - cleanup REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16283?vs=43822=43885 BRANCH

D16281: update epub test data and test for comment property

astippich updated this revision to Diff 43887. astippich added a comment. - fix test file REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16281?vs=43820=43887 BRANCH description_test_preparation REVISION DETAIL https://phabricator.kde.org/D16281

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich added a comment. I've decided to name it similar to the extractor plugins REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16197 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich updated this revision to Diff 43888. astippich marked an inline comment as done. astippich added a comment. - remove read prefix REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16197?vs=43819=43888 BRANCH mimetypes_embedded_image

D16196: add a description property to KFileMetaData

astippich added a comment. ping. would be great to get this in before the string freeze REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16196 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16179: compare with QLatin1String and harmonize handling of all types

This revision was automatically updated to reflect the committed changes. Closed by commit R286:fd9ce3a4e1d2: compare with QLatin1String and harmonize handling of all types (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16179: compare with QLatin1String and harmonize handling of all types

astippich added a comment. Ok. Thanks! REPOSITORY R286 KFileMetaData BRANCH harmonize_optimize REVISION DETAIL https://phabricator.kde.org/D16179 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16282: extract ape tags from ape and wavpack files

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY extend the existing support of ape tags to all types that

D16283: implement more tags for asf metadata

astippich added a comment. for some reason the TagLib::ASF::File tag() function returns only an invalid pointer, so I decided to use the dynamic_cast here. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16283 To: astippich, mgallien, bruns Cc:

D16281: update epub test data and test for comment property

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY update the test data for epub and test for the comment property in

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich updated this revision to Diff 43819. astippich added a comment. - use QVERIFY - use capital T - add since 5.52 tag and rephrase documentation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16197?vs=43601=43819 BRANCH

D16281: update epub test data and test for comment property

astippich added a comment. In preparation of D12114 , which I plan to commandeer REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16281 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D16283: implement more tags for asf metadata

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add some more tags for asf audio files REPOSITORY R286

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in embeddedimagedata.cpp:73 > `supportedMimeTypes()` ? > capital `T`, see `ImageType` and `QMimeType` The "read" is supposed to mark that only read operations for these mimetypes are

D16179: compare with QLatin1String and harmonize handling of all types

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY small optimization and harmonization for all metadata

D16486: implement support for reading ID3 tags from aiff and wav files

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY implement ID3 tags for aiff and wav files as supported by

D16197: provide a list of supported mimetypes for embeddedimagedata

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1e9705162343: provide a list of supported mimetypes for embeddedimagedata (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16283: implement more tags for asf metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R286:02e8cab069ff: implement more tags for asf metadata (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16283?vs=43885=44366#toc REPOSITORY R286 KFileMetaData CHANGES

D16282: extract ape tags from ape and wavpack files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:4582ba5f3d7a: extract ape tags from ape and wavpack files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16282?vs=43821=44365

D16281: update epub test data and test for comment property

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d97b15679179: update epub test data and test for comment property (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16281?vs=43887=44364#toc REPOSITORY R286

D16579: Musepack disk number field name is DISC.

astippich added a comment. In D16579#352147 , @smithjd wrote: > In D16579#351910 , @astippich wrote: > > > The ape tag tests fail with this patch, but the test is actually wrong in that regard. It

D16490: [KFileMetaData] Add unittest for XML extractor

astippich added a comment. In D16490#352109 , @bruns wrote: > In D16490#351935 , @astippich wrote: > > > In D16490#351799 , @bruns wrote: > > > > > In

D16486: implement support for reading ID3 tags from aiff and wav files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:19f0237fdc98: implement support for reading ID3 tags from aiff and wav files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH xml_extractor REVISION DETAIL https://phabricator.kde.org/D16488 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

astippich added a comment. I guess you plan to convert the existing extractors to use this? The only concern I might have that now two iterations over the node are required when this is used in e.g. odfextractor, isn't it? Btw, I don't think it's necessary to prepend KFileMetaData in the

D16554: move supported mimetypes to static string list

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Do not create the list of supported mime types on demand and use a

D16560: create a separate test file for embedded images test

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY if the test.jpg file is altered, e.g. additional metadata is

D16490: [KFileMetaData] Add unittest for XML extractor

astippich added a comment. Only one minor thing: please also check that the mimetype is in the list of supported mimetypes REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc: lbeltrame, kde-frameworks-devel, #baloo,

D16564: cleanup the test for embedded image extraction

astippich created this revision. astippich added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY cleanup the test by converting to a data-driven one

D15829: make units and prefixes of formatValue translatable

astippich added a comment. ping REPOSITORY R244 KCoreAddons BRANCH translate_units REVISION DETAIL https://phabricator.kde.org/D15829 To: astippich, bruns, safaalfulaij Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16489: [KFileMetaData] Add extractor for generic XML and SVG

astippich added inline comments. INLINE COMMENTS > xmlextractor.cpp:24 > + > +#include > +#include seems unused > xmlextractor.cpp:27 > +#include > +#include > + same > xmlextractor.cpp:71 > + > +return list; > +} Can we agree on using a static qstringlist if the mimetypes are

<    1   2   3   4   5   6   7   8   9   10   >