D24826: Enforce 100 chars line width

carewolf added a comment. I agree. A limit of 100 is arbitrary and harmful. Unfortunately clang-format doesn't seem to have a way to make lines over a certain length less desirably, but still allowed if the break would be ugly, so it is better to just allow long lines. REPOSITORY R240 Ext

D21604: Fix building with Qt 5.13

carewolf abandoned this revision. carewolf added a comment. Done independently REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21604 To: carewolf, bruns, ngraham Cc: alexeymin, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D23801: Port kpac from QtScript

carewolf added inline comments. INLINE COMMENTS > kossebau wrote in script.cpp:316 > With queued signals, any const-reference arguments are passed via an internal > value-copy IIRC, so references are not out-dated. > Can the same technique not be expected with any usages of invocables, like > f

D23801: Port kpac from QtScript

carewolf added inline comments. INLINE COMMENTS > kossebau wrote in script.cpp:316 > So why would it be preferable to have the value be copied there? In general, > one prefers to avoid copies, so what is the different motvation here? Invokables can be called asynchronously (queued), if you take

D23801: Port kpac from QtScript

carewolf added inline comments. INLINE COMMENTS > kossebau wrote in script.cpp:316 > Hi @carewolf . Curious: Why all the non-const-ref QString argument types here? > > Is there a need to do that with Q_INVOKABLE methods somehow? > Asking because clazy falgs these, compare D25039 >

D23833: Fix port to QJS

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9e1220bf76ad: Fix port to QJS (authored by carewolf). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23833?vs=65752&id=65767 REVISION DETAIL https://phabricator.kde.o

D23833: Fix port to QJS

carewolf added a comment. It was already described in the two tests included kpactest.pac and kpactest2.pac REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23833 To: carewolf, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23833: Fix port to QJS

carewolf created this revision. carewolf added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. carewolf requested review of this revision. REVISION SUMMARY Two mistakes with DateRange was discovered after I figured out how to test it. R

D23801: Port kpac from QtScript

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4ad1902278f0: Port kpac from QtScript (authored by carewolf). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23801?vs=65690&id=65741 REVISION DETAIL https://phabrica

D23801: Port kpac from QtScript

carewolf created this revision. carewolf added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. carewolf requested review of this revision. REVISION SUMMARY Migrate the QtScript code to QJS classes. Warning: untested REPOSITORY R241

D14948: Port scriptabletags to QJSEngine

carewolf abandoned this revision. REVISION DETAIL https://phabricator.kde.org/D14948 To: carewolf, dhaumann, skelly Cc: vkrause, skelly, dhaumann, kde-frameworks-devel

D21604: Fix building with Qt 5.13

carewolf added inline comments. INLINE COMMENTS > alexeymin wrote in regexpcache.cpp:81 > can probably just be `QString suffixMatch(QLatin1String("^.*\\.("));` then, > without `=` Sure, but it hardly matters, copy-elision will make the statements equivalent. REPOSITORY R293 Baloo REVISION D

D21604: Fix building with Qt 5.13

carewolf added reviewers: bruns, ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21604 To: carewolf, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21604: Fix building with Qt 5.13

carewolf created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. carewolf requested review of this revision. REPOSITORY R293 Baloo BRANCH fix-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D21604 AFF

D17984: Fix emmet script by using HEX instead of OCT numbers in strings

carewolf accepted this revision. carewolf added a comment. This revision is now accepted and ready to land. Looks good to me REPOSITORY R39 KTextEditor BRANCH fix-emmet REVISION DETAIL https://phabricator.kde.org/D17984 To: dhaumann, carewolf, loh.tar Cc: kwrite-devel, kde-frameworks-

D17970: Fix broken Emmet

carewolf added inline comments. INLINE COMMENTS > lib.js:5434 > getImageSize: function(stream) { > - var pngMagicNum = "\211PNG\r\n\032\n", > - jpgMagicNum = "\377\330", Is that even valid JS? Shouldn\t it be \xHH with hexidecimal? R

D14948: Port scriptabletags to QJSEngine

carewolf added a comment. See https://github.com/steveire/grantlee/pull/44 REVISION DETAIL https://phabricator.kde.org/D14948 To: carewolf, dhaumann, skelly Cc: vkrause, skelly, dhaumann, kde-frameworks-devel

D14948: Port scriptabletags to QJSEngine

carewolf added a comment. Yes, he promised to look at it later, but he never got back to me. Maybe I should poke him REVISION DETAIL https://phabricator.kde.org/D14948 To: carewolf, dhaumann, skelly Cc: vkrause, skelly, dhaumann, kde-frameworks-devel

D14948: Port scriptabletags to QJSEngine

carewolf added a comment. Yes it is for grantlee REVISION DETAIL https://phabricator.kde.org/D14948 To: carewolf, dhaumann, skelly Cc: vkrause, skelly, dhaumann, kde-frameworks-devel

D14948: Port scriptabletags to QJSEngine

carewolf added subscribers: kde-frameworks-devel, dhaumann, skelly. REVISION DETAIL https://phabricator.kde.org/D14948 To: carewolf, dhaumann, skelly Cc: skelly, dhaumann, kde-frameworks-devel

D7033: Port ki18n from QtScript to QtQml

This revision was automatically updated to reflect the committed changes. Closed by commit R249:9040bff75a5d: Port ki18n from QtScript to QtQml (authored by carewolf). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7033?vs=39526&id=39629 REVISION DETAIL https

D7033: Port ki18n from QtScript to QtQml

carewolf added a comment. I solved the Ts.acall. Unfortunately I forgot how arc works, so it became a new entry https://phabricator.kde.org/D14769 REVISION DETAIL https://phabricator.kde.org/D7033 To: carewolf, ilic Cc: kde-frameworks-devel, huftis, ngraham, dhaumann, ltoscano, kfunk, mich

D7033: Port ki18n from QtScript to QtQml

carewolf updated this revision to Diff 39526. carewolf added a comment. Fixed acall using a pure javascript bridge REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7033?vs=39460&id=39526 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7033 AFF

D14769: Port ki18n from QtScript to QtQml

carewolf created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. carewolf requested review of this revision. REVISION SUMMARY Moves away from the deprecated QtScript module Change-Id: I02c6aa24bc74e64618dc04

D14769: Port ki18n from QtScript to QtQml

carewolf added a reviewer: ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14769 To: carewolf, ilic Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7033: Port ki18n from QtScript to QtQml

carewolf added a comment. Note the latest patch still has a maximum number of arguments for acall. I checked all the usages, and the only place that uses acall with a variable set of arguments is the sr (Serbian) translation. Since supporting a variable number of arguments would require chan

D14769: Port ki18n from QtScript to QtQml

carewolf abandoned this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14769 To: carewolf, ilic Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7033: Port ki18n from QtScript to QtQml

carewolf updated this revision to Diff 39460. carewolf added a comment. Updated and ensured autotests passes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7033?vs=17489&id=39460 REVISION DETAIL https://phabricator.kde.org/D7033 AFFECTED FILES CMakeLists.txt autotests/CMakeL

D11554: Add warnings to why some actions might be invalid

carewolf added a reviewer: vkrause. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D11554 To: carewolf, vkrause Cc: #frameworks, michaelh, ngraham

D11554: Add warnings to why some actions might be invalid

carewolf created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. carewolf requested review of this revision. REVISION SUMMARY Otherwise we are only told the action is invalid but not why. REPOSITORY R283 KAuth BRANCH

D7033: Port ki18n from QtScript to QtQml

carewolf added a comment. No, but I will see if I can find some. Otherwise feel free to take over an fix the remaining issues. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D7033 To: carewolf, ilic Cc: ngraham, dhaumann, ltoscano, kfunk, #frameworks

D7337: Port rest of scripting API to QJSValue-based solution

carewolf added a comment. A few of the cursor/range functions are used, but not all of them. You could probably rewrite the places using them to use line+col instead. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7337 To: dhaumann, carewolf, cullmann Cc: kwrite

D7337: Port rest of scripting API to QJSValue-based solution

carewolf accepted this revision. carewolf added a comment. This revision is now accepted and ready to land. Looks good to me REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7337 To: dhaumann, carewolf, cullmann Cc: kwrite-devel, #frameworks

D6914: Switch from QtScript to QtQml

This revision was automatically updated to reflect the committed changes. Closed by commit R39:878797830dbd: Switch from QtScript to QtQml (authored by carewolf). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6914?vs=18072&id=18073#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UP

D6914: Switch from QtScript to QtQml

carewolf updated this revision to Diff 18072. carewolf added a comment. Minor cleanups CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6914?vs=17281&id=18072 REVISION DETAIL https://phabricator.kde.org/D6914 AFFECTED FILES CMakeLists.txt autotests/CMakeLists.txt autotests/s

D6914: Switch from QtScript to QtQml

carewolf added a comment. Actually I wanted to clean a few minor things first. I will update it. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6914 To: carewolf, cullmann, dhaumann, #frameworks Cc: dfaure, cullmann, #frameworks

D6895: Handle fine-grained wheel event in zoomin

carewolf closed this revision. carewolf added a comment. Already landed REVISION DETAIL https://phabricator.kde.org/D6895 To: carewolf, cullmann Cc: #frameworks

D7033: Port ki18n from QtScript to QtQml

carewolf created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Moves away from the deprecated QtScript module REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D7033

D6914: Switch from QtScript to QtQml

carewolf updated this revision to Diff 17281. carewolf edited the summary of this revision. carewolf added a comment. Fixed ruby tests REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6914?vs=17224&id=17281 REVISION DETAIL https://phabricator

D6914: Switch from QtScript to QtQml

carewolf updated this revision to Diff 17224. carewolf edited the summary of this revision. carewolf added a comment. Forgot to add the new private headers. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6914?vs=17223&id=17224 REVISION DETAIL https://phabricator.kde.org/D6914 AFF

D6914: Switch from QtScript to QtQml

carewolf updated this revision to Diff 17223. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6914?vs=17209&id=17223 REVISION DETAIL https://phabricator.kde.org/D6914 AFFECTED FILES CMakeLists.txt autotests/CMakeLists.txt autotests/src/bug313759.cpp autotests/src/bug317111.cpp

D6914: Switch from QtScript to QtQml

carewolf added a comment. As I said it has some instrumentation and dead-code. I will clean it up a bit. I was just hoping for a bit of help on why the ruby indent tests are being weird. INLINE COMMENTS > dhaumann wrote in katescripthelpers.cpp:178 > Is this all not required anymore? It is

D6914: Switch from QtScript to QtQml

carewolf added a comment. Note all of the helper functions are now single argument, but no script we have use more. It doesn't however remove templating in the i18n functions. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6914 To: carewolf, cullmann,

D6914: Switch from QtScript to QtQml

carewolf added a comment. Actually the Q_GADGET part is not needed. I have commented out the code that registers the qmetaobject, so at this point those changes are no longer needed. I needed to do manual conversion anyway. The conversion functions doesn't need to be in public headers. But t

D6914: Switch from QtScript to QtQml

carewolf created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Replaces the QtScript depedency with QtQml. WIP: The ruby indentation test doesn't work, and appears unstable as most fai

D6895: Handle fine-grained wheel event in zoomin

carewolf added a comment. DefaultDeltasPerStep is always exactly 120 :D REVISION DETAIL https://phabricator.kde.org/D6895 To: carewolf, cullmann Cc: #frameworks

D6895: Handle fine-grained wheel event in zoomin

carewolf updated this revision to Diff 17169. carewolf added a comment. Fix smoothness of zooming down CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6895?vs=17167&id=17169 REVISION DETAIL https://phabricator.kde.org/D6895 AFFECTED FILES src/render/katerenderer.cpp src/render

D6895: Handle fine-grained wheel event in zoomin

carewolf added a reviewer: cullmann. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6895 To: carewolf, cullmann Cc: #frameworks

D6895: Handle fine-grained wheel event in zoomin

carewolf created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Avoid zooming in or out too fast when wheel events are finer grained. REPOSITORY R252 Framework Integration REVISION DETAIL https://ph

Re: There's no proper replacement for KIcon

On Wednesday 03 September 2014, Albert Astals Cid wrote: > Porting guide lies in saying that KIcon should be replaced with > QIcon::fromTheme since KIcon defauted to oxygen icon theme and obviously > QIcon::fromTheme doesn't do that. > > Please someone provide a solution for this problem or undepr

Re: Review Request 108495: Port kimgio to Qt5

can for instance support multiple formats that has different keys and mimetypes. Qt maps the keys and mimetypes by the order. You could also get rid of the different case keys though. - Allan Sandfeld Jensen On Jan. 21, 2013, 12:20 p.m., Jon Severinsson wrote