Re: ktcpsockettest again

On Saturday 19 January 2013 12:21:57 David Faure wrote: Hi Andreas, Can you shed some light on the intent of this famous test? s-write(HTTPREQUEST); s-waitForReadyRead(); s-close(); //What happens is that during waitForReadyRead() the write buffer is written out

Re: ktcpsockettest again

On Saturday 19 January 2013 12:21:57 David Faure wrote: Hi Andreas, Can you shed some light on the intent of this famous test? s-write(HTTPREQUEST); s-waitForReadyRead(); s-close(); //What happens is that during waitForReadyRead() the write buffer is written out

Re: Review Request 120139: kill warning

, but it is not clear that just ignoring that an assumption was violated is the right thing to do. - Andreas Hartmetz On Sept. 11, 2014, 10:48 vorm., Sune Vuorela wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Relicensing parts of kglobalacceld

(or answer there directly). [1] https://www.gnu.org/licenses/lgpl-2.1.html ...or later. Thank you Cheers, Andreas Hartmetz ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

g by > > the id (the plugin name). > > Andreas Hartmetz wrote: > Depends on the scope in which an ID is guaranteed to be unique. If it's > guaranteed to be globally unique and independent of category, sure, I'm all > for not making it more complicated than necessary.

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

g by > > the id (the plugin name). > > Andreas Hartmetz wrote: > Depends on the scope in which an ID is guaranteed to be unique. If it's > guaranteed to be globally unique and independent of category, sure, I'm all > for not making it more complicated than necessary

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

uot; and tray config dialog, no duplicates anymore. Also no duplicates anymore in KWin effects KCM. Thanks, Andreas Hartmetz ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

s. O(n^2) - Andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/#review90755 --- On Jan. 7, 2016, 3:21 p.m., A

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

marked as submitted. Review request for KDE Frameworks, kdelibs, Plasma, and Marco Martin. Changes --- Submitted with commit 85cc90b65ed8a9aa110018b01813fe1fd6772d48 by Andreas Hartmetz to branch master. Repository: kpackage Description --- That was a problem in a scenario

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

On Mittwoch, 27. Januar 2016 17:21:33 CET Boudewijn Rempt wrote: [snip] > whether kglobalshortcuts is functional or not is besides the point: > the point is that whether it works or not it doesn't add any > functionality to the average application. Global shortcuts are useful > only for a very

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

On Donnerstag, 28. Januar 2016 12:07:54 CET Andre Heinecke wrote: > Hi, > > On Wednesday 27 January 2016 21:28:36 Andreas Hartmetz wrote: > > On Mittwoch, 27. Januar 2016 17:21:33 CET Boudewijn Rempt wrote: > > [snip] > > > > > whether kglobalshort

Re: Review Request 126865: kio_http: fix waiting until the cache cleaner listens to the socket.

was that the first request by the first ioslave started and then failed to connect to the cache cleaner. The cache cleaner then became ready and started to get used after a few requests or so. - Andreas Hartmetz On Jan. 23, 2016, 11 p.m., David Faure wrote

Re: Deadlock in kded whith Qt 5.6

On Dienstag, 19. Januar 2016 10:02:33 CET Aleix Pol wrote: > On Mon, Jan 18, 2016 at 9:23 AM, David Faure wrote: > > On Friday 15 January 2016 13:48:14 Aleix Pol wrote: > >> On Fri, Jan 15, 2016 at 1:02 PM, Aleix Pol wrote: > >> > Hi, > >> > I realized earlier

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

> On Jan. 25, 2016, 9:36 p.m., Luca Beltrame wrote: > > FYI, this breaks Plasma 5 startup completely for me. kinit crashes with > > > > ```gdb > > #0 0x7ff831e58c20 in QObject::thread() const () at > > /usr/lib64/libQt5Core.so.5 > > #1 0x7ff8329d1a20 in KWindowSystem::d_func() () at

Re: Review Request 127121: KWallet::openWallet(Synchronous) : time out after 1 hour rather than 25 seconds.

hat anyway. Is this for e.g. Akonadi agents? Those could as well wait indefinitely. If they can't -> well they shouldn't use synchronous API. Synchronous IPC to an unreliable peer (if the user is involved it's unreliable ;) is asking for problems. - Andreas Hartmetz On Feb. 20, 2016, 2:16 p.m., Davi

Re: Review Request 127121: KWallet::openWallet(Synchronous) : time out after 1 hour rather than 25 seconds.

> On Feb. 20, 2016, 8:25 p.m., Andreas Hartmetz wrote: > > Sorry for being the guy who says "I don't like this improvement because > > it's still not perfect"... > > Why have a timeout at all and not, for example, retry after getting a > > timeout err

Re: Review Request 127077: kio_http: read and discard body after a 404 with errorPage=false.

also mean HTTP error but in fact it's the KIO error code. - Andreas Hartmetz On Feb. 20, 2016, 5:50 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126991: Try multiple authentication methods in case of failures

> Please break this line, it's extremely long with the addition. - Andreas Hartmetz On Feb. 9, 2016, 9:53 p.m., Krzysztof Nowicki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Misbehavior when unloading KStyle

On Mittwoch, 6. April 2016 20:10:53 CEST Aleix Pol wrote: > Hi, > I've seen a couple of times such backtrace [1] which shows Qt waiting > for something that never happens. An easy way to reproduce is to load > konversation (or any application with KDBusService::Unique), hide it > and run it again.

Re: Misbehavior when unloading KStyle

On Donnerstag, 7. April 2016 20:33:19 CEST Andreas Hartmetz wrote: > On Mittwoch, 6. April 2016 20:10:53 CEST Aleix Pol wrote: > > Hi, > > I've seen a couple of times such backtrace [1] which shows Qt > > waiting > > for something that never happens. An easy way

Re: Misbehavior when unloading KStyle

On Freitag, 8. April 2016 17:25:06 CEST Aleix Pol wrote: > On Fri, Apr 8, 2016 at 3:42 PM, Andreas Hartmetz <ahartm...@gmail.com> wrote: > > On Donnerstag, 7. April 2016 20:33:19 CEST Andreas Hartmetz wrote: > >> On Mittwoch, 6. April 2016 20:10:53 CEST Aleix Pol wrote

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

> On March 27, 2016, 10:03 a.m., David Faure wrote: > > Given how the socket API works, you should only call error() after a call > > that returns false (e.g. waitForConnected, etc.). As you found out, calling > > error() at random points in time doesn't give useful information, you get > >

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

::setError(e); } }; // in socket reset code static_cast(>socket)->setError(QAbstractSocket::UnknownSocketError); - Andreas Hartmetz On March 26, 2016, 5:29 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review93157 --- Ship it! Ship It! - Andreas Hartmetz On March 3, 2016

Re: Review Request 126991: Try multiple authentication methods in case of failures

tps://git.reviewboard.kde.org/r/126991/#comment63498> What does this do? (I suggest adding an example of something that triggers this code) - Andreas Hartmetz On March 3, 2016, 11:40 a.m., Krzysztof Nowicki wrote: > > --- > This is a

Re: Review Request 126991: Try multiple authentication methods in case of failures

> On March 3, 2016, 7:43 p.m., Andreas Hartmetz wrote: > > > > Andreas Hartmetz wrote: > OK, this looks good now overall. The comment about the indexOf() is of > course about the whole truncating at space thing, not the particular line. > > Krzysztof No

Re: Review Request 127813: Process paths just once

tps://git.reviewboard.kde.org/r/127813/#comment64595> Talking about same behavior, this also randomizes the order in case there are actually several home paths... however that happens. - Andreas Hartmetz On May 2, 2016, 4:32 p.m., Aleix Pol Gonzalez

Re: Scrap baloo?

On Mittwoch, 28. September 2016 20:42:37 CEST Boudhayan Gupta wrote: > Hi, > > On 28 September 2016 at 20:33, Christoph Cullmann wrote: > > Hi, > > > >> Hi, > >> > >> On 28 September 2016 at 02:36, Christoph Cullmann wrote: > >>> any update? > >> >

Re: Review Request 129259: Fix the buffersize in certain situations.

though. https://quickgit.kde.org/?p=krusader.git=blob=932340774d439b1ea770204903c1f8c431dc86db=f1660b241d195a31a904a1706fb8022b99e4c709=krusader%2FVFS%2Fnormal_vfs.cpp http://git.savannah.gnu.org/cgit/coreutils.git/tree/src/ls.c - Andreas Hartmetz On Oct. 25, 2016, 2:51 p.m., taro yamada wrote

Re: Review Request 129259: Fix the buffersize in certain situations.

> On Oct. 26, 2016, 2:48 p.m., Andreas Hartmetz wrote: > > If a workaround was really necessary I'd agree with Jonathan. But it looks > > like a workaround to fix up st_size is not necessary, because both Krusader > > and ls (just two examples I could easily find)

Re: Review Request 129259: Fix the buffersize in certain situations.

or somebody else can push it for you. - Andreas Hartmetz On Oct. 27, 2016, 3:02 p.m., taro yamada wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129259: Fix the buffersize in certain situations.

/ioslaves/file/file.cpp (line 791) <https://git.reviewboard.kde.org/r/129259/#comment67346> You can use qMin() here. As is the compiler would complain about the different types (off_t and int), which can be fixed by changing the type of initialLimit to off_t. - Andreas Hartmetz On O

[Differential] [Updated] D4060: kio: Ensure user certificate directory has been created before storing certs to it

ahartmetz added a comment. Looks like a stupid mistake on my part, thanks for the fix. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4060 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mpyne, #frameworks, apol, ahartmetz

D14922: Assert if trying to use a KCatalog without a QCoreApplication

ahartmetz added a comment. This change makes kwin_x11 crash on startup. Please fix kwin or degrade this to a warning. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14922 To: aacid, dfaure Cc: ahartmetz, dfaure, ltoscano, ilic, kde-frameworks-devel, michaelh,

D14922: Assert if trying to use a KCatalog without a QCoreApplication

ahartmetz added a subscriber: kwin. ahartmetz added a comment. @kwin REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14922 To: aacid, dfaure Cc: kwin, ahartmetz, dfaure, ltoscano, ilic, kde-frameworks-devel, michaelh, ngraham, bruns

T11627: Improve KIO asynchronicity

ahartmetz added a comment. In T11627#219720 , @meven wrote: > In T11627#219718 , @ahartmetz wrote: > > > You may want to look at the DBus part of this with dfer-monitor, a tool I have written. It

T11627: Improve KIO asynchronicity

ahartmetz added a comment. You may want to look at the DBus part of this with dfer-monitor, a tool I have written. It is especially useful for looking at latency problems. https://cgit.kde.org/dferry.git/ TASK DETAIL https://phabricator.kde.org/T11627 To: meven, ahartmetz Cc: