Review Request 119257: kconfig: Fix QBasicAtomicInt being treated as int.

://git.reviewboard.kde.org/r/119257/diff/ Testing --- Compiled successfully. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119258: kcoreaddons: Fix ecm_generate_headers don't accumulate and only kaboutdata.h is exported.

Diff: https://git.reviewboard.kde.org/r/119258/diff/ Testing --- Compiled and then linked with kauth, which previously couldn't find kjob.h. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 119259: kservice: Fix typo in autotests/nsaplugin.cpp nsapluginfa to nsaplugin

: https://git.reviewboard.kde.org/r/119259/diff/ Testing --- Compiled. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119259: kservice: Fix typo in autotests/nsaplugin.cpp nsapluginfa to nsaplugin

- autotests/nsaplugin.cpp 48aeaf4 Diff: https://git.reviewboard.kde.org/r/119259/diff/ Testing --- Compiled. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 119257: kconfig: Fix QBasicAtomicInt being treated as int.

--- On July 13, 2014, 9:39 a.m., Andreas Xavier wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119257

Re: Review Request 119259: kservice: Fix typo in autotests/nsaplugin.cpp nsapluginfa to nsaplugin

nsapluginfa for nsaplugin. This patch fixes that. Diffs - autotests/nsaplugin.cpp 48aeaf4 Diff: https://git.reviewboard.kde.org/r/119259/diff/ Testing --- Compiled. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 119257: kconfig: Fix QBasicAtomicInt being treated as int.

fixes that problem. Diffs - src/core/kconfig.cpp 14a5d39 Diff: https://git.reviewboard.kde.org/r/119257/diff/ Testing --- Compiled successfully. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 119258: kcoreaddons: Fix ecm_generate_headers don't accumulate and only kaboutdata.h is exported.

case this patch will not be useful. Diffs - src/lib/CMakeLists.txt 26eb5a1 Diff: https://git.reviewboard.kde.org/r/119258/diff/ Testing --- Compiled and then linked with kauth, which previously couldn't find kjob.h. Thanks, Andreas Xavier

Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

to warn when var1 and var2 have the same name. Diffs - src/lib/CMakeLists.txt 26eb5a1 Diff: https://git.reviewboard.kde.org/r/119275/diff/ Testing --- Compiled kcoreaddons, then checked that all headers generated and exported. Ran unittests. Thanks, Andreas Xavier

Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

exported. Then compiled kauth and checked that it found the exported headers. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

On July 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: Is this because of the usage of list(APPEND)? Maybe using set(.. PARENT_SCOPE) for appending would do the trick as well? Andreas Xavier wrote: Can you confirm that you are seeing the same problem? This is my first

Re: Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

://git.reviewboard.kde.org/r/119300/#review62408 --- On July 15, 2014, 1:38 p.m., Andreas Xavier wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

headers generated and exported. Ran unittests. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

/ Testing --- make test Compiled kcoreaddons, checked that all the headers were exported. Then compiled kauth and checked that it found the exported headers. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

Diff: https://git.reviewboard.kde.org/r/119530/diff/ Testing --- Ran unit tests. Ran kdeedu with kanagram. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

., Andreas Xavier wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119530/ --- (Updated July 29, 2014, 9:54 a.m.) Review

Re: Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

autotests/kautosavefiletest.cpp ec0309e ! PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119530/diff/ Testing --- Ran unit tests. Ran kdeedu with kanagram. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 119681: Duplicate header guard from notifybylogfile.h in notifybyaudio.h

/ Testing --- I compiled. There are no unit tests. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

--- On Aug. 11, 2014, 9:22 p.m., Andreas Xavier wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119530/ --- (Updated Aug. 11, 2014