D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-23 Thread Andres Betts
abetts added a comment. Can you guys add a quick picture of what this looks like right now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: abetts, ngraham, alexeymin, #frameworks

D9324: [Air theme] Add task bar progress graphic

2017-12-14 Thread Andres Betts
abetts added a comment. What should be the move here? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9324 To: broulik, #plasma, #vdg, ngraham Cc: abetts, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread Andres Betts
abetts added a comment. My perspective here is that instead of using an actual checkbox to enable the dragging, I would create visual handles instead. Maybe something like this: F5489078: Group.png Why? Because checkboxes generally don't

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-04 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D8056#164287, @ngraham wrote: > I would say make the categories disappear as soon as that view displays search results. Yeah, because in the end, when you want to narrow down the results, the categories will get in your way

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-04 Thread Andres Betts
abetts added a comment. Can I suggest to maybe simplify even a little more and remove the category separators? AKA, system, internet? REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg,

D8348: Add a section for removable devices

2017-11-05 Thread Andres Betts
abetts added a comment. What about something like this as well F548: Unmount.png The removable device gets an "unmount" or "disconnect" icon on hover? Thoughts? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348

D8296: Use Alt+, as the standard shortcut for "Configure "

2017-10-25 Thread Andres Betts
abetts added a comment. Could this also be added to global shortcuts if it is not there already? That the user can define the keys to use for Preferences? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc:

D7828: createKMessageBox tries to focus a default button when available

2017-10-24 Thread Andres Betts
abetts added a comment. I am leaning toward implementing the change. The reason being that the user gets a duplicate indication of focus when likely they might feel confused, I have been at times too, by not knowing clearly where the highlight is. If you have two highlights, how do you know

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Andres Betts
abetts added a comment. If you assume that most computers that run linux will have a windows key, I would call it just windows. Everyone else uses exceptions really. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Andres Betts
abetts added a comment. We don't seem to have anything against it. My only request is that if we do shortcuts, make them use 2 hands instead of just one. If the keys are too close together, this makes it harder to enter. Possibly harder for people with disabilities as well. So, space the

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Andres Betts
abetts added a comment. What about Windows/Meta + Something, let's say , comma? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik,

D12508: Make KMessageWidget match Kirigami inlineMessage's style

2018-05-07 Thread Andres Betts
abetts added a comment. +1 on this! REPOSITORY R236 KWidgetsAddons BRANCH arcpatch-D12508 REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, cfeck Cc: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh,

D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-09 Thread Andres Betts
abetts added a comment. In D10937#260277 , @ngraham wrote: > Someone will need to land the changes for you. I'd prefer a few more thumbs up first. @abetts, are you good with these? I am linking these a lot. I am "almost" there with the

D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-10 Thread Andres Betts
abetts added a comment. In D10937#260688 , @pstefan wrote: > In D10937#260289 , @abetts wrote: > > > In D10937#260277 , @ngraham wrote: > > > > >

D12895: WIP: Add KFileItemActionsPlugin

2018-05-15 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D12895 To: broulik, #plasma, #vdg, apol Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

2018-05-19 Thread Andres Betts
abetts added a comment. In D12986#265231 , @ngraham wrote: > Yeah, that makes sense. Suggestions welcome, of course. Is this any better? > F5859259: After 2.png > > Still not super happy with "When

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

2018-05-19 Thread Andres Betts
abetts added a comment. In D12986#265198 , @rkflx wrote: > I don't think putting whole phrases as a label before the checkbox works very well, and I would be surprised if that's what the HIG now recommends. I assume at most a single subject

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

2018-05-20 Thread Andres Betts
abetts added a comment. In D12986#265235 , @rkflx wrote: > In D12986#265231 , @ngraham wrote: > > > Yeah, that makes sense. Suggestions welcome, of course. Is this any better? > > F5859259:

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

2018-05-20 Thread Andres Betts
abetts added a comment. In D12986#265552 , @ngraham wrote: > Like this? > > F5860366: Radiobutton version.png That looks really good IMHO. Somewhat unrelated, I have seen a few UIs recently that

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

2018-05-20 Thread Andres Betts
abetts added a comment. In D12986#265675 , @rkflx wrote: > In D12986#265666 , @ngraham wrote: > > > In D12986#265662 , @rkflx wrote: > > > > > Anyway,

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

2018-05-20 Thread Andres Betts
abetts added a comment. In D12986#265687 , @rkflx wrote: > In my personal experience spending more time on a limited set of items leads to better results and less churn (as in reverting commits, number of iterations per patch etc.) than only

D12992: New elisa icon

2018-05-21 Thread Andres Betts
abetts added a subscriber: andreask. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To: lshoravi, #vdg, ngraham, #elisa Cc: andreask, kde-frameworks-devel, ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, ognarb, januz, ngraham, bruns,

D13215: Update sizes before generating frame svg background

2018-06-01 Thread Andres Betts
abetts added a comment. +1 on this! Love it! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma, #frameworks Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

2018-06-06 Thread Andres Betts
abetts added a comment. What can we do to help this patch move forward @zzag ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma, #frameworks Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D12992: New elisa icon

2018-05-27 Thread Andres Betts
abetts added a comment. I think we are trying hard to accommodate and the elements are not lending themselves to turn them into an E with some musical tones. I reviewed a few music sheets looking for commonalities. I feel also that the icon is busy, it is trying really hard to tell you that

D13552: [Properties dialog] Improve some permissions-related strings

2018-06-19 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13552 To: ngraham, #frameworks, #vdg, #dolphin Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13643: Add LabPlot project file icon

2018-07-01 Thread Andres Betts
abetts added a comment. My first impression is that it looks a lot like a file emblem. I would probably remove the background and keep only the logo. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze Cc: abetts,

D13643: Add LabPlot project file icon

2018-07-01 Thread Andres Betts
abetts added a comment. Oh great! I thought the team was looking for a logo. Then, I have nothing more to add. It looks great. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze Cc: abetts, asemke, ngraham,

D12392: Fix the "Default" color scheme to match Breeze again

2018-05-02 Thread Andres Betts
abetts added a comment. Just trying to understand. What is happening here is that we have 3 color schemes that are all theoretically the same as Breeze. However, the "default" and "Breeze" scheme are currently not the same. Therefore, we have to make sure that they are. If that's the case

D12077: Show view mode buttons in the open/save dialog's toolbar

2018-05-03 Thread Andres Betts
abetts added a comment. It would be cool if we could introduce it in this release and polish a lot for the next release. I give it a +1. @ngraham ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: elvisangelaccio,

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2018-01-26 Thread Andres Betts
abetts added a comment. Is this change purely a conversation of what developers use in code to call up fonts in their applications? Or does this also include a discussion where regular users have interfaces that allow changes to font naming? Let's say, something like System Settings that

D10211: Suggestion for emacs icon

2018-01-31 Thread Andres Betts
abetts added a comment. I like it! Maybe a way to accentuate that this is an "E" a little more. As a first impression, it didn't strike me as an E for emacs. Overall, the colors are great and the circle shape fits well. REPOSITORY R266 Breeze Icons REVISION DETAIL

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

2018-02-12 Thread Andres Betts
abetts added a comment. Will this hide "All" menu items or will it hide after a certain amount of them are in the menu? For example, it will turn into a sub menu after 3 items? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10329 To: broulik, #vdg, #frameworks, dfaure

D14810: Improve Widgets' removal and configure text

2018-08-13 Thread Andres Betts
abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. This patch is sensible, it saves some strings, space, and it is grammatically consistent. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-this-widget (branched from master)

D14810: Improve Widgets' removal and configure text

2018-08-13 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14810 To: ngraham, #plasma, #vdg Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

2018-08-06 Thread Andres Betts
abetts added a comment. Could the message have 2 buttons? A cancel and an "Enter a different name". That way, if the user inadvertently entered that reserved name can cancel the action still. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14640 To: ngraham,

D14640: Use appropriate icon for a cancel button that will ask for a new name

2018-08-06 Thread Andres Betts
abetts added a comment. In D14640#304400 , @ngraham wrote: > Hmm, I'm not sure a cancel button makes sense here because that would end the process of creating the folder. If you chose an invalid name, presumably you still want to create the

D14640: Use appropriate icon for a cancel button that will ask for a new name

2018-08-06 Thread Andres Betts
abetts added a comment. In D14640#304428 , @ngraham wrote: > In D14640#304405 , @abetts wrote: > > > In D14640#304400 , @ngraham wrote: > > > > > Hmm,

D14640: Use appropriate icon for a cancel button that will ask for a new name

2018-08-06 Thread Andres Betts
abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH rename-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D14640 To: ngraham, #frameworks, #vdg, abetts Cc: abetts, broulik, dfaure, kde-frameworks-devel,

D14579: api for multi level kcms

2018-08-07 Thread Andres Betts
abetts added a comment. Awesome! REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D14579 To: mart, #plasma, #frameworks Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15071: Don't draw frames and shadows around images with an alpha channel

2018-08-25 Thread Andres Betts
abetts added a comment. I support this 100% REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck Cc: abetts, bruns, kde-frameworks-devel, michaelh, ngraham

D15099: add a new property headerVisible

2018-08-27 Thread Andres Betts
abetts added a comment. Thanks for the work Marco! REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D15099 To: mart, #plasma, #frameworks Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

2018-08-29 Thread Andres Betts
abetts added a comment. What does this look like now Marco? REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D14580 To: mart, #plasma, #frameworks Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for list-style views

2018-07-16 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13773 To: ngraham, #frameworks, #vdg, #dolphin Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for multi-column views

2018-07-24 Thread Andres Betts
abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. Looks good! REPOSITORY R241 KIO BRANCH alternating-row-colors-for-list-style-views (branched from master) REVISION DETAIL https://phabricator.kde.org/D13773 To: ngraham,

D15194: Draw a line separating PlasmaComponents tab bar from its content area

2018-09-01 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15194 To: ngraham, #plasma, #vdg Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15071: Don't draw frames and shadows around images with transparency

2018-09-05 Thread Andres Betts
abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH thumbnail-frame-refinement (branched from master) REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck, abetts Cc:

D15240: Create a default wallet when user refuses to do so

2018-09-04 Thread Andres Betts
abetts added a comment. In D15240#319850 , @ngraham wrote: > This strikes me as likely to cause intense frustration. Consider the following dramatized dialogue between a user and the computer: > > User: "Neat, I just set up this KDE plasma

D14580: support for multi pages kcms

2018-08-29 Thread Andres Betts
abetts added a comment. In D14580#317289 , @mart wrote: > F6223394: Spectacle.k3.png > > in case the kcm wants to go multi columns (default off): > F6223399: Spectacle.l3.png

D12130: Use the more user-friendly string "File type" in the save dialogs

2018-04-13 Thread Andres Betts
abetts accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx, abetts Cc: davidc, ltoscano, cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12034: Use the more appropriate "two sliders" icon for "configure"

2018-04-13 Thread Andres Betts
abetts accepted this revision as: VDG, abetts. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH more-consistent-configure-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze, abetts Cc:

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

2018-04-13 Thread Andres Betts
abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH tighter-grid-in-icons-view (branched from master) REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx, abetts Cc: abetts, cfeck, alexeymin,

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

2018-04-13 Thread Andres Betts
abetts added a comment. Can we also create another patch that can add more vertical spacing between the items and the top edge of the field? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: abetts, cfeck, alexeymin,

D12077: Show view mode buttons in the open/save dialog's toolbar

2018-04-13 Thread Andres Betts
abetts accepted this revision. REPOSITORY R241 KIO BRANCH show-view-mode-toggles-on-open-save-dialog-toolbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: rkflx, mmustac, broulik, michaelh, ngraham, bruns

D12034: Use the more appropriate "two sliders" icon for "configure"

2018-04-09 Thread Andres Betts
abetts added a comment. I am in fact, a little bit taken back by the fact that we have a two slider icon. The reason is because I have been told many times that we don't want to use sliders or toggles in the desktop. We are referencing something that doesn't exist in the Plasma desktop. I

D12034: Use the more appropriate "two sliders" icon for "configure"

2018-04-09 Thread Andres Betts
abetts added a comment. In D12034#243522 , @ngraham wrote: > 1. System Settings uses sliders right there in its icon. :) They're already used to mean "Configure me!" in other contexts (KRunner, Plasma widgets, GTK apps) > 2. Sliders aren't

D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-04 Thread Andres Betts
abetts added a comment. I don't have any objections. Good work! +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, firef, alexeymin, skadinna,

D12130: Use the more user-friendly string "File format" in the open/save dialogs

2018-04-11 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R241 KIO BRANCH file-format-label (branched from master) REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns Cc: abetts, bruns, michaelh, ngraham

D12306: Filepicker dialog proper grid icon layout

2018-04-18 Thread Andres Betts
abetts added a comment. I also vote for a little more vertical spacing. Maybe in similar ways to what Marco Martin did recently for spacing in System Settings. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg Cc: abetts, rkflx,

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-04-20 Thread Andres Betts
abetts added a comment. In D12311#250637 , @bruns wrote: > If you really want to save some space (and probably make it easier for users to understand the dialog without getting lost), I think the whole > > > An application is attempting to

D12077: Show view mode buttons in the open/save dialog's toolbar

2018-04-18 Thread Andres Betts
abetts added a comment. In D12077#249447 , @ngraham wrote: > In D12077#249446 , @abetts wrote: > > > Somewhat related, why does the Size header have a number of items listed and not the size in

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

2018-04-20 Thread Andres Betts
abetts added a comment. +1 In D12333#250266 , @rkflx wrote: > In D12333#250194 , @abetts wrote: > > > I gave a +1 to the original idea because I feel that there isn't really much closeness that

D12218: Remove Reload button from the file dialogs' toolbar

2018-04-19 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc: abetts, markg, broulik, rkflx, #dolphin, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

2018-04-19 Thread Andres Betts
abetts added a comment. I gave a +1 to the original idea because I feel that there isn't really much closeness that you can achieve with the open dialog. It is simple, straightforward. If we wanted to do a strict fitt's law follow, then each back and forth icon would be next to each of the

D12327: [WIP/open dependencies] Show Detailed Tree View by default

2018-04-19 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham Cc: abetts, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

2018-04-19 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

2018-04-19 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12333 To: ngraham, #frameworks, #dolphin, #vdg Cc: abetts, jtamate, broulik, anemeth, rkflx, michaelh, bruns

D11768: Add Desktop and Downloads to the default list of Places

2018-04-19 Thread Andres Betts
abetts added a comment. I would say remove search for images audio files and video and move them to the places location REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: abetts, huoni, markg,

D10980: updated hanle icon

2018-04-22 Thread Andres Betts
abetts added a comment. Just to provide perspective at what the rest of the industry is using, here is a search online: https://www.flaticon.com/search?word=drag REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10980 To: andreask, mart Cc: abetts, rkflx,

D12328: Enable preview by default in the filepicker dialog

2018-04-18 Thread Andres Betts
abetts added a comment. What would it look like if it was enabled by default? Screenshot? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

2018-04-18 Thread Andres Betts
abetts added a comment. Somewhat related, why does the Size header have a number of items listed and not the size in bytes for all the items inside the folder? size 0 items 2 items Shouldn't it be: size 1 kb 3 Mb ?? REPOSITORY R241 KIO REVISION DETAIL

D12508: Make KMessageWidget match Kirigami inlineMessage's style

2018-04-25 Thread Andres Betts
abetts added a comment. +1, looking good. Keep up the work! REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, elvisangelaccio, cfeck Cc: abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, bruns

D11569: Improve consistency of "Open With" UI by always showing top app inline

2018-03-30 Thread Andres Betts
abetts accepted this revision. REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts Cc: mmustac, davidedmundson, broulik, dfaure,

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

2018-03-28 Thread Andres Betts
abetts added a comment. Can we just call all of those entries just "Recent" or "Recently Used" independent of when it happened? I feel that would be more clear without having to remove the feature. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham,

D11569: Improve consistency of "Open With" UI

2018-03-22 Thread Andres Betts
abetts added a comment. +1 on this! Easy access to apps! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve usability of "Open With" UI

2018-03-21 Thread Andres Betts
abetts added a comment. Would it look good also that if there were less handlers and they are presented in the same menu that it goes like this: Open With - Gwenview - GIMP I am talking about right justification instead of Open With Gwenview GIMP REPOSITORY R241

D11569: Improve consistency of "Open With" UI by always showing top app inline

2018-03-23 Thread Andres Betts
abetts added a comment. This may be different than this patch is intending to address. Let me know if that's the case. Another thing that adds more characters to the menus are the long names that our applications have. Firefox Web Browser Gwenview Image Editor GIMP Image Editor

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-01 Thread Andres Betts
abetts added a comment. Is there a way that we can add extra clarity by adding a label below the icons? A label that explains what the action is? I agree that the current symbolism can be hard to read but it is also very simple. If you make the connection to label, it will be even stronger

D16395: Update the "About KDE" text

2018-10-31 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2018-10-23 Thread Andres Betts
abetts added a comment. > KDE has created the friendly and powerful Plasma desktop environment KDE has created the most friendly and powerful desktop environment, Plasma. > KDE is a cooperative enterprise in which no single entity KDE is a disaggregated development community not

D16653: Use the new `drive-harddisk-root` icon for the root volume

2018-11-04 Thread Andres Betts
abetts accepted this revision. abetts added a comment. Minor detail with great impact. Thank you for the work. REPOSITORY R245 Solid BRANCH arcpatch-D16653 REVISION DETAIL https://phabricator.kde.org/D16653 To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts Cc: abetts,

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Andres Betts
abetts added a comment. I like both ideas so far. Great improvement! Would it be too hard to create the pointer triangle? I think it make so much sense. That way the poppup doesn't feel like it is floating out of nowhere. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D15821: fix pop up positioning for !compositing mode

2018-09-28 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15821 To: mvourlakos, #plasma, broulik, davidedmundson Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15935: Don't show an emblem for mounted disks, only unmounted disks

2018-10-05 Thread Andres Betts
abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH no-mounted-emblem (branched from master) REVISION DETAIL https://phabricator.kde.org/D15935 To: ngraham, #vdg, abetts Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15973: Add a 'Properties' entry in the places panel context menu

2018-10-07 Thread Andres Betts
abetts retitled this revision from "Add a 'Propreties' entry in the places panel context menu" to "Add a 'Properties' entry in the places panel context menu". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15973 To: thsurrel, #frameworks, #vdg, ngraham, dfaure Cc:

D15591: Add Open Document thumbnailer

2018-09-19 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg, ngraham, kossebau, jtamate, fvogt, wbauer Cc: abetts, kde-frameworks-devel, kfm-devel, leinir, kossebau, jtamate, ngraham, feverfew, michaelh,

D11880: Add firewall-config and firewall-applet icons

2018-09-21 Thread Andres Betts
abetts added a comment. If I understand right, there are three states of firewall security that you can be in. Maybe we could use the traffic lights metaphor and have green for low, yellow for medium and red for high? REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from

D11880: Add firewall-config and firewall-applet icons

2018-09-21 Thread Andres Betts
abetts added a comment. I solemnly approve! +1 REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham,

D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-24 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15721 To: ndavis, #vdg Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

2018-09-26 Thread Andres Betts
abetts added a comment. Love it! Ship it! +100 REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham,

D15194: Draw a line separating PlasmaComponents tab bar from its content area

2018-09-20 Thread Andres Betts
abetts added a comment. In D15194#328651 , @romangg wrote: > If there are more items than space available in the list a line is drawn already now to indicate that there are more items to come by scrolling down. Does this not conflict with the

D11880: Add firewall-config and firewall-applet icons

2018-09-21 Thread Andres Betts
abetts added a comment. Seems good to me. Guys? REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham,

D15739: [Places panel] Don't show Root by default

2018-09-25 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Andres Betts
abetts added a comment. In D15814#85 , @mvourlakos wrote: > In D15814#10 , @ngraham wrote: > > > A big improvement! Even better would be a little downward-pointing triangle pointing to the

D16951: Add mouse button icons

2018-11-17 Thread Andres Betts
abetts added a comment. Looks good to me +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

2018-12-13 Thread Andres Betts
abetts added a comment. +1 for improving visuals REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17461 To: ngraham, #vdg, #frameworks, cullmann, cfeck Cc: abetts, apol, cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D17496: Change network/web color icons to consistent style

2018-12-11 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17496 To: ndavis, #vdg Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17609: KTextEditor: Add action for static word wrap

2018-12-15 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17609 To: loh.tar, #ktexteditor, #vdg Cc: abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17350: Add the missing api for multilevel KCMs to control the columns

2018-12-04 Thread Andres Betts
abetts added a comment. Instead of connection name, would it make sense to call it, network name instead? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

2018-12-03 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

  1   2   >